summaryrefslogtreecommitdiffstats
path: root/ash/shelf
Commit message (Collapse)AuthorAgeFilesLines
* Removes FocusBorder from viewssky@chromium.org2013-12-055-5/+21
| | | | | | | | | | | | | | | | | | | | | | | This patch removes FocusBorder from View along with View::OnPaintFocusBorder. Views that want to render focus and that need to allow overriding get a Painter that is responsible for rendering the focus. Views that render focus differently must override OnFocus/OnBlur to SchedulePaint the necessary region. This patch simplifies View and cleans things up for views that don't ever want to paint focus, or paint focus differently (say TableView, or Textfield). On the down side it does mean any view that is focusable needs to override a few more additional methods. It was easy to get this wrong previously though as a common pattern is to override OnPaint and not invoke View::OnPaint. BUG=none TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/105013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238888 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Rename more Launcher classes to Shelf*.tfarina@chromium.org2013-12-049-74/+299
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Rename LauncherItemDelegate to ShelfItemDelegate. * Move launcher_item_delegate.h from launcher/ to shelf/ * Rename to shelf_item_delegate.h * Rename TestLauncherItemDelegate to TestShelfItemDelegate. * Move test_launcher_item_delegate.* from launcher/ to shelf/ * Rename to test_shelf_item_delegate.* * Rename LauncherItemDelegateManager to ShelfItemDelegateManager. * Move launcher_item_delegate_manager.* from launcher/ to shelf/ * Rename to shelf_item_delegate_manager.* * Rename LauncherItemDelegateManagerTestAPI to ShelfItemDelegateManagerTestAPI. * Move launcher_item_delegate_manager_test_api.* from launcher/ to shelf/ * Rename to shelf_item_delegate_manager_test_api.* * Rename WindowWatcherLauncherItemDelegate to WindowWatcherShelfItemDelegate. * Move window_watcher_launcher_item_delegate.* from launcher/ to shelf/ * Rename to window_watcher_shelf_item_delegate.* * Rename LauncherMenuModel to ShelfMenuModel. * Host it into its own header file named shelf_menu_model.h BUG=248353 TEST=None, no functional changes R=jamescook@chromium.org,harrym@chromium.org Review URL: https://codereview.chromium.org/97173003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238696 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Increase shelf tooltip show up delay to 1s.xiyuan@chromium.org2013-12-021-1/+1
| | | | | | | | BUG=322928 Review URL: https://codereview.chromium.org/99613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238187 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing focus highlight on high DPI devices for accessibilityskuhne@chromium.org2013-12-021-17/+3
| | | | | | | | | | | The name seems rather odd, but I couldn't come up with something better... BUG=320756 TEST=visual Review URL: https://codereview.chromium.org/78803002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238185 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] drag and drop from app list to shelf is not working in secondary monitor.simonhong@chromium.org2013-11-281-31/+31
| | | | | | | | | | | | | | Problem: Callers of ApplicationDragAndDropHost method in ShelfView and AppsGridView uses root window coordinate. R=skuhne@chromium.org, benwells@chromium.org, jamescook@chromium.org BUG=319826 TEST=browser_tests --gtest_filter=LauncherAppBrowserTestWithMultiMonitor.BasicDragAndDrop Review URL: https://codereview.chromium.org/68263026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237668 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] Cannot re-insert an item in the scrolled OverflowBubblesimonhong@chromium.org2013-11-265-10/+86
| | | | | | | | | | | | | | Problem: Origin of DragInsertBounds is calculated by using ShelfView. When scroll is occurred to last item, the origin of ShelfView in OverflowBubble is different from OverflowBubble's. R=jamescook@chromium.org BUG=322389 TEST=ash_unittests --gtest_filter=ShelfViewTest.CheckDragInsertBoundsOfScrolledOverflowBubble Review URL: https://codereview.chromium.org/82793003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237432 0039d316-1c4b-4281-b951-d872f2087c98
* events: Move test related functions into a separate target.sadrul@chromium.org2013-11-251-2/+3
| | | | | | | | | | | | | | | | | | Move events test-related code into a separate target so that these don't get used in non-test code. Notable changes: * Move nested TestApi classes out of Event, LocatedEvent and EventTarget, and into separate classes. The new classes become friends with their old parents. * Move events_x_utils out of x/ into test/ R=sky@chromium.org, tfarina@chromium.org TBR=jam@ for content_tests.gypi and render_view_browsertest.cc changes. BUG=none Review URL: https://codereview.chromium.org/82903005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237149 0039d316-1c4b-4281-b951-d872f2087c98
* This CL eliminates the necessity of calling SizeToContents() after calling ↵npentrel@chromium.org2013-11-251-8/+16
| | | | | | | | | | set_anchor_rect(). BUG= Review URL: https://codereview.chromium.org/66253004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237067 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Rename LauncherButton to ShelfButton.tfarina@chromium.org2013-11-236-71/+811
| | | | | | | | | | | | | * Move launcher_button.* from launcher/ to shelf/ * Rename to shelf_button.* BUG=248353 TEST=None, no functional changes R=jamescook@chromium.org,harrym@chromium.org Review URL: https://codereview.chromium.org/83953003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236982 0039d316-1c4b-4281-b951-d872f2087c98
* Reland - [ash] Enable dragging an item between shelf and overflow bubblesimonhong@chromium.org2013-11-217-256/+432
| | | | | | | | | | | | | | | | | | | | | | | | | | | Previous cl (https://codereview.chromium.org/61703002/) was reverted because win8-aura doesn't support multiple display. Description Copied from original cl: This is the first CL to implement drag and drop from overflow bubble to shelf. Currently ripped off item from overflow bubble cannot be dragged into shelf. But, Item should be dragged from overflow bubble to shelf to implement drag & drop. In this CL, re-insert bounds for shelf/overflow bubble is re-defined like below. - shelf -bounds that include visible items. - overflow bubble - overflow bubble bounds. * The method of ripping off is not changed (dragging an item to above only in bottom alignment) If ripping off is possible by dragging to down side, it could cause flickering because overflow bubble and shelf is located too closely. R=jamescook@chromium.org BUG=137141 TEST=ash_unittest --gtest_filter=*.CheckDragInsertBoundsWithMultiMonitor Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235935 Review URL: https://codereview.chromium.org/74853002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236504 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 235935 "Reland - [ash] Enable dragging an item between sh..."dcheng@chromium.org2013-11-197-433/+256
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Reland - [ash] Enable dragging an item between shelf and overflow bubble > > Previous cl (https://codereview.chromium.org/61703002/) was reverted > because win8-aura doesn't support multiple display. > > Description Copied from original cl: > This is the first CL to implement drag and drop from overflow bubble to shelf. > > Currently ripped off item from overflow bubble cannot be dragged into shelf. > But, Item should be dragged from overflow bubble to shelf to implement drag & drop. > In this CL, re-insert bounds for shelf/overflow bubble is re-defined like below. > - shelf -bounds that include visible items. > - overflow bubble - overflow bubble bounds. > > * The method of ripping off is not changed (dragging an item to above only in bottom alignment) > If ripping off is possible by dragging to down side, it could cause flickering because overflow bubble and shelf is located too closely. > > R=jamescook@chromium.org > BUG=137141 > TEST=ash_unittest --gtest_filter=*.CheckDragInsertBoundsWithMultiMonitor > > Review URL: https://codereview.chromium.org/74853002 TBR=simonhong@chromium.org Review URL: https://codereview.chromium.org/73233003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235947 0039d316-1c4b-4281-b951-d872f2087c98
* Reland - [ash] Enable dragging an item between shelf and overflow bubblesimonhong@chromium.org2013-11-197-256/+433
| | | | | | | | | | | | | | | | | | | | | | | | | Previous cl (https://codereview.chromium.org/61703002/) was reverted because win8-aura doesn't support multiple display. Description Copied from original cl: This is the first CL to implement drag and drop from overflow bubble to shelf. Currently ripped off item from overflow bubble cannot be dragged into shelf. But, Item should be dragged from overflow bubble to shelf to implement drag & drop. In this CL, re-insert bounds for shelf/overflow bubble is re-defined like below. - shelf -bounds that include visible items. - overflow bubble - overflow bubble bounds. * The method of ripping off is not changed (dragging an item to above only in bottom alignment) If ripping off is possible by dragging to down side, it could cause flickering because overflow bubble and shelf is located too closely. R=jamescook@chromium.org BUG=137141 TEST=ash_unittest --gtest_filter=*.CheckDragInsertBoundsWithMultiMonitor Review URL: https://codereview.chromium.org/74853002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235935 0039d316-1c4b-4281-b951-d872f2087c98
* Adding 2 simple UMA stats to track shelf alignment usage, firstly track when ↵harrym@chromium.org2013-11-193-0/+25
| | | | | | | | | | | a shelf alignment is changed (rare), and during usage of the shelf launcher (buttons on the shelf) track the current alignment (more common) to provide some data on how frequent usage is of the various alignments. BUG=298174 TBR=askvitkine@chromium.org Review URL: https://codereview.chromium.org/26373009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235904 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Add GetItemIndexForType() function to ShelfModel.tfarina@chromium.org2013-11-184-45/+13
| | | | | | | | | | | | | | | | | | Now that this function is generic enough, there is no reason to not provide it directly from ShelfModel. See previous CLs: https://codereview.chromium.org/27369004 https://codereview.chromium.org/53513003 https://codereview.chromium.org/71653003 BUG=None TEST=None, no functional changes R=jamescook@chromium.org Review URL: https://codereview.chromium.org/68523017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235641 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] Preferred size of ShelfView is not fixed when item is animatingsimonhong@chromium.org2013-11-181-1/+1
| | | | | | | | | | | | | | | | Problem: When an item is dragged in overflow bubble to left or right, item and bubble are flickered. The reason for this is preferred shelf view size is based on item's bounds which is not a fixed value when it is in animating. Instead, ideal bounds is more better to get the shelf view's preferred size. R=xiyuan@chromium.org, jamescook@chromium.org BUG=316101 TEST=visual test Review URL: https://codereview.chromium.org/68263024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235640 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 235533 because the test added in the CL fails on win8-aurasadrul@chromium.org2013-11-177-448/+256
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The crash trace is as follows: [2188:1892:1117/092153:837538:FATAL:display_manager.cc(571)] Check failed: 1u == updated_display_info_list.size() (1 vs. 2)Multiple display test does not work on Win8 bots. Please skip (don't disable) the test using SupportsMultipleDisplays() Backtrace: base::debug::StackTrace::StackTrace [0x6C2DBBF1+33] logging::LogMessage::~LogMessage [0x6C10D2FE+94] ash::internal::DisplayManager::UpdateDisplays [0x5BC233C5+293] ash::internal::DisplayManager::OnNativeDisplaysChanged [0x5BC22B43+2723] ash::test::DisplayManagerTestApi::UpdateDisplay [0x00CDB1D7+775] ash::test::AshTestBase::UpdateDisplay [0x00CD7309+121] ash::test::ShelfViewMultiMonitorTest::SetUp [0x0098B136+102] testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x00CAF59F+319] testing::Test::Run [0x00C99FBB+107] testing::TestInfo::Run [0x00C9A9CD+221] testing::TestCase::Run [0x00C9B17F+239] testing::internal::UnitTestImpl::RunAllTests [0x00CA1ACD+701] testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x00CB01C7+327] testing::UnitTest::Run [0x00CA0330+192] base::TestSuite::Run [0x00C8EEE0+240] main [0x00BA9227+103] __tmainCRTStartup [0x00E1978F+447] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:555) mainCRTStartup [0x00E195BF+15] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:371) BaseThreadInitThunk [0x76638543+14] RtlInitializeExceptionChain [0x7788AC69+133] RtlInitializeExceptionChain [0x7788AC3C+88] > [ash] Enable dragging an item from the overflow bubble to the shelf bounds > > This is the first CL to implement drag and drop from overflow bubble to shelf. > > Currently ripped off item from overflow bubble cannot be dragged into shelf. > But, Item should be dragged from overflow bubble to shelf to implement drag & drop. > In this CL, re-insert bounds for shelf/overflow bubble is re-defined like below. > - shelf -bounds that include visible items. > - overflow bubble - overflow bubble bounds. > > * The method of ripping off is not changed (dragging an item to above only in bottom alignment) > If ripping off is possible by dragging to down side, it could cause flickering because overflow bubble and shelf is located too closely. > > R=harrym@chromium.org, jamescook@chromium.org > BUG=137141 > TEST=browser_tests, ash_unittests > > Review URL: https://codereview.chromium.org/61703002 TBR=simon.hong81@gmail.com Review URL: https://codereview.chromium.org/74733002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235537 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] Enable dragging an item from the overflow bubble to the shelf boundssimon.hong81@gmail.com2013-11-177-256/+448
| | | | | | | | | | | | | | | | | | | | | This is the first CL to implement drag and drop from overflow bubble to shelf. Currently ripped off item from overflow bubble cannot be dragged into shelf. But, Item should be dragged from overflow bubble to shelf to implement drag & drop. In this CL, re-insert bounds for shelf/overflow bubble is re-defined like below. - shelf -bounds that include visible items. - overflow bubble - overflow bubble bounds. * The method of ripping off is not changed (dragging an item to above only in bottom alignment) If ripping off is possible by dragging to down side, it could cause flickering because overflow bubble and shelf is located too closely. R=harrym@chromium.org, jamescook@chromium.org BUG=137141 TEST=browser_tests, ash_unittests Review URL: https://codereview.chromium.org/61703002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235533 0039d316-1c4b-4281-b951-d872f2087c98
* Set LauncherID as a Window's Propertysimon.hong81@gmail.com2013-11-162-0/+56
| | | | | | | | | | | | | | Currently, we need to query all LauncherItemController when we need to get window's id. This is very inefficient way. Instead, LauncherID associated with window is set as a window property. R=sky@chromium.org BUG=NONE TEST=browser_tests --gtest_filter=*.MatchingLauncherIDandActiveTab Review URL: https://codereview.chromium.org/27335006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235496 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Rename LauncherModel to ShelfModel.tfarina@chromium.org2013-11-1418-58/+734
| | | | | | | | | | | | | * Move launcher_model.* from launcher/ to shelf/ * Rename to shelf_model.* BUG=248353 TEST=None, no functional changes R=jamescook@chromium.org,harrym@chromium.org Review URL: https://codereview.chromium.org/71653003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235217 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Rename LauncherModelObserver to ShelfModelObserver.tfarina@chromium.org2013-11-133-16/+57
| | | | | | | | | | | | | - move launcher_model_observer.h from launcher/ to shelf/ - rename to shelf_model_observer.h BUG=248353 TEST=None, no functional changes R=harrym@chromium.org,jamescook@chromium.org Review URL: https://codereview.chromium.org/68243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234686 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] Disalbe multi-level overflow bubblesimon.hong81@gmail.com2013-11-122-7/+14
| | | | | | | | | | | | | | | | | | | Problem: When shelf can contain only one item (overflow button) due to very small size of shelf, Overflow bubble contains overflow button, too. I think above behavior is strange because overflow bubble can scroll to naviagate all hidden items. This multi-level overflow bubble is created becase of is_overflow_mode() only checks the first index of item. When shelf size is small, ShelfView in bubble is considered not in overflow mode. R=jamescook@chromium.org BUG=316745 TEST=visual test Review URL: https://codereview.chromium.org/68343007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234525 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] Overflow bubble shows empty slotsimon.hong81@gmail.com2013-11-094-14/+136
| | | | | | | | | | | | | | | Problem: When an item is ripped out from the overflow bubble, overflow bubble shows an empty slot for invisible view(drag_view). The size of overflow bubble size should be shrunk. R=skuhne@chromium.org, jamescook@chromium.org BUG=312536 TEST=ash_unittests --gtest_filter=*.OverflowBubbleSize, visual test Review URL: https://codereview.chromium.org/49503005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234077 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate Shell::RootWindowList in favor of aura::Window::Windows.ben@chromium.org2013-11-082-2/+2
| | | | | | | | | | | | | This is necessary as part of my plan to rework RootWindow, specifically making it not be a subclass of Window. (It will eventually be renamed WindowEventDispatcher). Code that expected to get the RootWindow interface from this type can still call GetDispatcher() on members of the returned vector of Windows. R=oshima@chromium.org http://crbug.com/308843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233787 Review URL: https://codereview.chromium.org/64933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233970 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 233787 "Eliminate Shell::RootWindowList in favor of aura:..."ben@chromium.org2013-11-082-2/+2
| | | | | | | | | | | | | | | | | > Eliminate Shell::RootWindowList in favor of aura::Window::Windows. > > This is necessary as part of my plan to rework RootWindow, specifically making it not be a subclass of Window. (It will eventually be renamed WindowEventDispatcher). Code that expected to get the RootWindow interface from this type can still call GetDispatcher() on members of the returned vector of Windows. > > R=oshima@chromium.org > http://crbug.com/308843 > > Review URL: https://codereview.chromium.org/64933002 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/59153004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233813 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate Shell::RootWindowList in favor of aura::Window::Windows.ben@chromium.org2013-11-082-2/+2
| | | | | | | | | | | This is necessary as part of my plan to rework RootWindow, specifically making it not be a subclass of Window. (It will eventually be renamed WindowEventDispatcher). Code that expected to get the RootWindow interface from this type can still call GetDispatcher() on members of the returned vector of Windows. R=oshima@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/64933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233787 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Rename LauncherButtonHost to ShelfButtonHost.tfarina@chromium.org2013-11-068-88/+148
| | | | | | | | | | | | | - move launcher_button_host.h from launcher/ to shelf/ - rename to shelf_button_host.h BUG=248353 TEST=None, no functional changes R=harrym@chromium.org,jamescook@chromium.org Review URL: https://codereview.chromium.org/57453002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233337 0039d316-1c4b-4281-b951-d872f2087c98
* Upon activation on mixed mode, we only show and use apps of the current ↵skuhne@chromium.org2013-11-053-5/+5
| | | | | | | | | | | user. Furthermore we should not show the menu if an app was created. BUG=296269 TEST=visual Review URL: https://codereview.chromium.org/58813002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233142 0039d316-1c4b-4281-b951-d872f2087c98
* Convert event location to screen position.flackr@chromium.org2013-11-051-3/+8
| | | | | | | | | | BUG=313859 TEST=OverviewGestureHandlerTest.GestureSwipeTopOfWindow TEST=Swipe down from the top of a window not at the top of the screen. Overview should not engage. Review URL: https://codereview.chromium.org/54333008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233127 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Rename GetLauncherItemIndexForType to GetShelfItemIndexForType().tfarina@chromium.org2013-11-012-0/+45
| | | | | | | | | | | | | - move launcher_model_util.* from launcher/ to shelf/ - rename to shelf_model_util.* BUG=248353 TEST=None, no functional changes R=harrym@chromium.org,jamescook@chromium.org Review URL: https://codereview.chromium.org/53513003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232415 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 231729zork@chromium.org2013-11-011-16/+0
| | | | | | | | | | | | Focus the default item when the system tray bubble is created BUG=304304 TBR=rkc@chromium.org TBR=xiyuan@chromium.org Review URL: https://codereview.chromium.org/53483002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232364 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] Prevent blinking of last item which is out by ripping out another itemsimon.hong81@gmail.com2013-11-011-12/+18
| | | | | | | | | | | | | | | | Problem: When item is removed from the shelf by ripping out, new last item is out if overflow button is visible. After when user release the mouse button, already outed last item is blinking by fade in animation. R=skuhne@chromium.org, jamescook@chromium.org BUG=312198 TEST=visual test Review URL: https://codereview.chromium.org/48093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232328 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] Check x and y axis to prepare drag operation when rip off from the shellsimon.hong81@gmail.com2013-10-311-3/+4
| | | | | | | | | | | | | Problem: When user drags an item above strictly only y-axis, drag operation is not prepared.(assumed a shelf is at bottom). R=skuhne@chromium.org, jamescook@chromium.org BUG=313073 TEST=browser_tests --gtest_filter=*.DragOffShelf Review URL: https://codereview.chromium.org/51233006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232027 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] Fading in the new last item when an item is ripped out from the shelfsimon.hong81@gmail.com2013-10-302-2/+12
| | | | | | | | | | | | | | Problem: When ripping out an item from the shelf, the sliding animation of last item is overlapped with overflow button. R=skuhne@chromium.org, jamescook@chromium.org BUG=312062 TEST=visual test Review URL: https://codereview.chromium.org/43443003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231951 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] add a space between last item and overflow buttonsimon.hong81@gmail.com2013-10-301-0/+7
| | | | | | | | | | | | | Problem: The gab between last item and overflow button is narrower than other item's gab. R=jamescook@chromium.org BUG=312604 TEST=visual test Review URL: https://codereview.chromium.org/48583004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231775 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Rename LauncherIconObserver to ShelfIconObserver.tfarina@chromium.org2013-10-304-23/+46
| | | | | | | | | | | | And moves from launcher/ to shelf/ directory. BUG=248353 TEST=None, no behavior changes. R=harrym@chromium.org,jamescook@chromium.org Review URL: https://codereview.chromium.org/45973003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231738 0039d316-1c4b-4281-b951-d872f2087c98
* Replace kFullscreenUsesMinimalChrome with ↵pkotwicz@chromium.org2013-10-283-21/+21
| | | | | | | | | | | | | ash::wm::WindowState::hide_shelf_when_fullscreen() BUG=None TEST=None R=jamescook TBR=sky (For trivial change in chrome/browser/notifications/fullscreen_notification_blocker.cc) Review URL: https://codereview.chromium.org/32943006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231398 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] Cleanup - Remove unused class and methods and fix some minor thingssimon.hong81@gmail.com2013-10-252-31/+13
| | | | | | | | | | | | | | * DeleteViewAnimationDelegate is not used anymore. It was replaced by FadeOutAnimationDelegate. * Remove leading_inset(), set_leading_inset(). For now, leading_inset is not set by outside of shelf_view. * Replace remained tooltip_->shelf_layout_manager() to layout_manager_. * Modify some comments. R=jamescook@chromium.org BUG=NONE Review URL: https://codereview.chromium.org/42143004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231082 0039d316-1c4b-4281-b951-d872f2087c98
* Make GetRootWindow() return a Window instead of a RootWindow.ben@chromium.org2013-10-2511-17/+17
| | | | | | | | | | | | Also adds a typedef from RootWindow to WindowEventDispatcher, the eventual name of this type. Adds a GetDispatcher() method that crawls up to the root Window and returns the WindowEventDispatcher. R=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/37733003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231077 0039d316-1c4b-4281-b951-d872f2087c98
* Rename StackingClient -> WindowTreeClientben@chromium.org2013-10-231-1/+1
| | | | | | | | | | | | Remove SetDefaultParentForRootWindow from Window, and replace with new utility function ParentWindowForContext in window_tree_client.h This is part of my current campaign to slim down the aura Window types. I will eventually move WindowTreeClient to a new ui/wm component that I plan to create. R=erg@chromium.org http://crbug.com/308844 Review URL: https://codereview.chromium.org/36473003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230501 0039d316-1c4b-4281-b951-d872f2087c98
* Change GetBrowserItemIndex() to GetLauncherItemIndexForType()simon.hong81@gmail.com2013-10-232-39/+0
| | | | | | | | | | | | | Makes GetBrowserItemIndex() more general function to get item index. Move this function to ./ash/launcher/launcher_item_util.h R=sky@chromium.org BUG=NONE TEST=browser_tests, ash_unittests Review URL: https://codereview.chromium.org/27369004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230456 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] Store ShelfLayoutManger in ShelfView instead of fetching it from ↵simon.hong81@gmail.com2013-10-233-65/+58
| | | | | | | | | | | | | | ShelfTooltipManager When ShelfView needs ShelfLayoutManager, it always fetched it from ShelfTooltipManager. I think storing it in ShelfView is more better. R=jamescook@chromium.org BUG=NONE Review URL: https://codereview.chromium.org/34373004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230288 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] Refactor ShelfView::LayoutToIdealBounds()simon.hong81@gmail.com2013-10-221-6/+6
| | | | | | | | | | | | Remove redundant call of CalculateIdealBounds(). AnimateToIdealBounds() also calls CalculateIdealBounds() and set overflow button rect. R=jamescook@chromium.org BUG=NONE Review URL: https://codereview.chromium.org/34373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230253 0039d316-1c4b-4281-b951-d872f2087c98
* Move the panel container above the shelf.flackr@chromium.org2013-10-221-0/+4
| | | | | | | | | | | The callout widgets (arrows) pointing down from the panel windows need to show above the shelf and must be stacked with the panel windows in order for the shadows to be drawn correctly. A new container is created for shelf bubble windows (currently only the overflow bubble) so that it can show above the attached panel windows. BUG=292840 TEST=Open a panel window such as hangouts and then maximize a browser window. The arrow pointing to the launcher icon from the panel window should still be visible. Review URL: https://codereview.chromium.org/30673003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230125 0039d316-1c4b-4281-b951-d872f2087c98
* linux and chromeos: Turn on -Wunused-const-variable.thakis@chromium.org2013-10-191-4/+0
| | | | | | | | | | BUG=307668 R=hans@chromium.org TBR=oshima Review URL: https://codereview.chromium.org/29263007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229578 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing problem with alignment for right to left languagesskuhne@chromium.org2013-10-181-6/+6
| | | | | | | | | BUG=234271 TEST=visual, using arabic language, made sure that status menu, launcher, notifications and chat window icons were at the right place Review URL: https://codereview.chromium.org/27711005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229388 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Move launcher_view* to shelf/ directory.tfarina@chromium.org2013-10-1812-53/+3770
| | | | | | | | | | | BUG=248353 TEST=none, no functional changes. R=jamescook@chromium.org, xiyuan@chromium.org TBR=sky@chromium.org # for chrome/browser/ui Review URL: https://codereview.chromium.org/27628002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229274 0039d316-1c4b-4281-b951-d872f2087c98
* Move SetLayoutForCurrentDisplays to DisplayManageroshima@chromium.org2013-10-161-2/+1
| | | | | | | | | | BUG=273142 R=mukai@chromium.org TBR=hongbo.min@intel.com, pkotwicz@chromium.org Review URL: https://codereview.chromium.org/27257004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228994 0039d316-1c4b-4281-b951-d872f2087c98
* Update dock size when auto-hiding shelfvarkha@chromium.org2013-10-162-2/+8
| | | | | | | | | BUG=298210 TEST=ash_unittests --gtest_filter=*AttachOneAutoHideShelf* Review URL: https://codereview.chromium.org/26662002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228858 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2: Refactor LauncherItemController and LauncherItemDelegatesimon.hong81@gmail.com2013-10-152-23/+10
| | | | | | | | | | | | | | | | | | | | Previous CL was reverted (https://codereview.chromium.org/23606016/) because LauncherItemDelegateManager holds destoryed LauncherModel pointer (in win7_aura trybot). To handle this, destroy LauncherItemDelegateManager and recreates a new one with new LauncherModel. Original description. * LauncherItemController subclasses LauncherItemDelegate * Register/Unregister when LauncherItemDelegate is created/removed * LauncherItemDelegateManager handles LauncherItemDelegate by LauncherID * LauncherItemDelegateManager take ownership of all LauncherItemDelegate R=sky@chromium.org, skuhne@chromium.org BUG=279105 TEST=unit_tests, browser_tests, ash_unittests, ash_shell Review URL: https://codereview.chromium.org/25823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228595 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] Segfault when shelf position is changed by app's context menu in the ↵simon.hong81@gmail.com2013-10-101-0/+3
| | | | | | | | | | | | | | | overflow bubble When user changes shelf position to different one from current settings, overflow bubble is destroyed before calling OverflowBubble::HideBubbleAndRefreshButton(). R=jamescook@chromium.org BUG=305518 TEST=visual test Review URL: https://codereview.chromium.org/26620002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227896 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 21:54:09 +0000