summaryrefslogtreecommitdiffstats
path: root/ash/shell.cc
Commit message (Collapse)AuthorAgeFilesLines
* Implement cursor compositing mode on Ashhshi@chromium.org2014-02-061-0/+7
| | | | | | | | | | | | | | | | Currently this is only enabled when the accessibility feature "high contrast" mode or "large cursor" mode is enabled. We do not enable this by default because cursor compositing shows some lags especially on slow machines or when CPU is busy. BUG=290837 TEST=trybot, manual testing mirror/extend/dual display mode R=derat@chromium.org, oshima@chromium.org Review URL: https://codereview.chromium.org/145313003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249289 0039d316-1c4b-4281-b951-d872f2087c98
* Merge BaseLayoutManager into WorkspaceLayoutManageroshima@chromium.org2014-02-041-1/+0
| | | | | | | | | BUG=338906 R=pkotwicz@chromium.org Review URL: https://codereview.chromium.org/153143003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248784 0039d316-1c4b-4281-b951-d872f2087c98
* Renames LauncherID, LauncherItem and LauncherItems...tfarina@chromium.org2014-02-031-1/+1
| | | | | | | | | | | | | to ShelfID, ShelfItem and ShelfItems. BUG=248353 TEST=None R=jamescook@chromium.org,harrym@chromium.org Review URL: https://codereview.chromium.org/152223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248619 0039d316-1c4b-4281-b951-d872f2087c98
* Provide real GPUSupport to ash for Chromejamescook@chromium.org2014-01-311-23/+3
| | | | | | | | | | | | | | | | A recent refactor to extract src/content dependencies from ash broke GPU feature detection for panel fitting on Chrome OS. In particular the OutputConfigurator was set up using a stub GPUSupport object. Fix injection of the GPUSupport object -- move its creation to the ash::ShellDelegate interface. BUG=chrome-os-partner:25204,chrome-os-partner:24868 TEST=existing ash_unittests Review URL: https://codereview.chromium.org/132173006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248226 0039d316-1c4b-4281-b951-d872f2087c98
* Reland a11y keyboard.kevers@chromium.org2014-01-291-1/+13
| | | | | | | | | | | | | | BUG=297132 Patch set 1 is the original CL: https://codereview.chromium.org/137543002/ which broke tests on the memory bots. Path set 2 contains the fix for the test failure. Review URL: https://codereview.chromium.org/148213010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247784 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 247420 "Add a11y on-screen keyboard."eugenis@chromium.org2014-01-281-13/+1
| | | | | | | | | | | | | | | | | | | | | | Suspected of breaking ChromeOS ASan: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%285%29/builds/25099/steps/memory%20test%3A%20unit/logs/stdio > Add a11y on-screen keyboard. > > Adds an accessibility option for displaying a virtual keyboard on the login screen and on the settings page. > > Followup patches required to persist the login preference on first time sign in, and to use the full virtual keyboard in place of the touch optimized version. > > BUG=297132 > > Review URL: https://codereview.chromium.org/137543002 TBR=kevers@chromium.org Review URL: https://codereview.chromium.org/137023009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247448 0039d316-1c4b-4281-b951-d872f2087c98
* Add a11y on-screen keyboard.kevers@chromium.org2014-01-281-1/+13
| | | | | | | | | | | | Adds an accessibility option for displaying a virtual keyboard on the login screen and on the settings page. Followup patches required to persist the login preference on first time sign in, and to use the full virtual keyboard in place of the touch optimized version. BUG=297132 Review URL: https://codereview.chromium.org/137543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247420 0039d316-1c4b-4281-b951-d872f2087c98
* Excludes ResolutionNotificationController for non-ChromeOS.mukai@chromium.org2014-01-221-2/+6
| | | | | | | | | | | This feature is ChromeOS specific. BUG=none R=oshima@chromium.org Review URL: https://codereview.chromium.org/137203008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246258 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome OS: avoid suspending on lid close when casting is active.hshi@chromium.org2014-01-171-0/+7
| | | | | | | | | | | | Treat casting (both tab casting and screen casting) the same as external display to avoid suspending on lid close. BUG=268615 TEST=verify that device is not suspended on lid close with casting is active. Review URL: https://codereview.chromium.org/139053003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245659 0039d316-1c4b-4281-b951-d872f2087c98
* Screen cleanup:oshima@chromium.org2014-01-171-10/+3
| | | | | | | | | | | | | * Split ScreenAsh to ScreenUtil (set of utility functions) and the screen implementation. * moved screen_ash from Shell to DisplayManager. Ash specific imp is now hidden in DisplayManager. * Shell now creates a separate screen object which simply keeps the list of displays for shutdown. This allow all screen operation valid during shutdown. BUG=None TBR=hongbo.min@intel.com,sky@chromium.org Review URL: https://codereview.chromium.org/138003007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245562 0039d316-1c4b-4281-b951-d872f2087c98
* Inject GPUDataManager support into ash to abstract a content dependency.ben@chromium.org2014-01-161-8/+25
| | | | | | | | | | | | http://crbug.com/332504 R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245010 Review URL: https://codereview.chromium.org/138223004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245161 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 245010 "Inject GPUDataManager support into ash to abstrac..."ben@chromium.org2014-01-151-25/+8
| | | | | | | | | | | | | | | | > Inject GPUDataManager support into ash to abstract a content dependency. > > http://crbug.com/332504 > > R=oshima@chromium.org > > Review URL: https://codereview.chromium.org/138223004 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/137893010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245018 0039d316-1c4b-4281-b951-d872f2087c98
* Inject GPUDataManager support into ash to abstract a content dependency.ben@chromium.org2014-01-151-8/+25
| | | | | | | | | | http://crbug.com/332504 R=oshima@chromium.org Review URL: https://codereview.chromium.org/138223004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245010 0039d316-1c4b-4281-b951-d872f2087c98
* Use a single ToplevelWindowEventHandler for the ash::Shell. This is part 1 ↵pkotwicz@chromium.org2014-01-151-4/+15
| | | | | | | | | | | | | | in disabling the few cases in which dragging multiple windows is possible (which causes crashiness) BUG=324038 TEST=None R=oshima TBR=sadrul (This is a reland of https://codereview.chromium.org/114643003) Review URL: https://codereview.chromium.org/102253008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244835 0039d316-1c4b-4281-b951-d872f2087c98
* Lock down DEPS a bit more.ben@chromium.org2014-01-141-1/+0
| | | | | | | | | | | As part of my effort to split ash into targets with and without content, I'm locking down the DEPS files very tightly to make using content from anywhere in ash harder. There are some carve-outs for specific subsections that need to use it (e.g. Desktop Background, Screensaver, etc.) and these are exempted in DEPS files. There are a few #includes I can't get rid of just yet in Shell, testing stuff etc, but I've exempted those explicitly for the time being. R=oshima@chromium.org http://crbug.com/332504 Review URL: https://codereview.chromium.org/131223007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244698 0039d316-1c4b-4281-b951-d872f2087c98
* Rename RootWindowHost to WindowTreeHostben@chromium.org2014-01-081-1/+1
| | | | | | | | | TBR=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/126513004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243578 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 242116 "Use a single ToplevelWindowEventHandler for the a..."pkotwicz@chromium.org2013-12-201-14/+4
| | | | | | | | | | | | | | | > Use a single ToplevelWindowEventHandler for the ash::Shell. This is part 1 in disabling the few cases in which dragging multiple windows is possible (which causes crashiness) > > BUG=324038 > TEST=None > > Review URL: https://codereview.chromium.org/114643003 TBR=pkotwicz@chromium.org Review URL: https://codereview.chromium.org/115693009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242198 0039d316-1c4b-4281-b951-d872f2087c98
* Use a single ToplevelWindowEventHandler for the ash::Shell. This is part 1 ↵pkotwicz@chromium.org2013-12-201-4/+14
| | | | | | | | | | | in disabling the few cases in which dragging multiple windows is possible (which causes crashiness) BUG=324038 TEST=None Review URL: https://codereview.chromium.org/114643003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242116 0039d316-1c4b-4281-b951-d872f2087c98
* Move sticky keys files to their own directory and rename to ↵tengs@chromium.org2013-12-201-4/+4
| | | | | | | | | | | | | | StickyKeysController. There will be new files added for the sticky keys UI in the future, and this refactor improves organization for sticky keys code and is more inline with how the other accessibility features are organized. TEST=StickyKeysTests pass Review URL: https://codereview.chromium.org/118543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242036 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Launcher to Shelf.tfarina@chromium.org2013-12-191-11/+11
| | | | | | | | | | | | | | | | | | - move launcher* from launcher to shelf. - rename to launcher.* to shelf.* and launcher_unittest.cc to shelf_unittest.cc - rename LauncherTestAPI to ShelfTestAPI. - rename to launcher_test_api.* to shelf_test_api.* BUG=248353 TEST=None, no functional changes R=jamescook@chromium.org,harrym@chromium.org TBR=sky Review URL: https://codereview.chromium.org/115113006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241794 0039d316-1c4b-4281-b951-d872f2087c98
* Use exact match when removing selector items on window destroying observation.flackr@chromium.org2013-12-161-0/+1
| | | | | | | | | BUG=322119 TEST=WindowSelectorTest.Shutdown,WindowSelectorTest.RemoveDisplay Review URL: https://codereview.chromium.org/106093005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240920 0039d316-1c4b-4281-b951-d872f2087c98
* Adding UMA metric tracking to the status are menu and related tray views to ↵harrym@chromium.org2013-12-131-1/+2
| | | | | | | | | | track usage of the menu's. BUG=297046 Review URL: https://codereview.chromium.org/73583003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240537 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] Create ShelfWindowWatcherItemDelegatesimonhong@chromium.org2013-12-131-2/+3
| | | | | | | | | | | | | | This is second CL for adding an item for dialog. This cl implements ShelfItemDelegate for LauncherItem created by ShelfWindowWatcher. R=sky@chromium.org BUG=121242 TEST=None Review URL: https://codereview.chromium.org/98503004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240496 0039d316-1c4b-4281-b951-d872f2087c98
* Rename LauncherDelegate to ShelfDelegate.tfarina@chromium.org2013-12-091-9/+8
| | | | | | | | | | | | | | | | | | | - move launcher_delegate.h from launcher to shelf. - rename to shelf_delegate.h - rename LauncherDelegateImpl to ShelfDelegateImpl. - rename to shelf_delegate_impl.* - rename TestLauncherDelegate to TestShelfDelegate. - rename test_shelf_delegate.* to test_shelf_delegate.* BUG=248353 TEST=None, no functional changes R=jamescook@chromium.org,harrym@chromium.org Review URL: https://codereview.chromium.org/103223005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239531 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure WindowObservers are removed from window before destructionoshima@chromium.org2013-12-061-13/+26
| | | | | | | | | | | | | | | | * Check if the window observer is empty upon destruction. * remove the all observers in ~WindowObserver() * Remove RemoveObserver that are no longer necessary * Fix shell shutdown order so that observers are removed correctly before deleting all windows. BUG=324018 R=skuhne@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239232 Review URL: https://codereview.chromium.org/101013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239246 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 239232 "Make sure WindowObservers are removed from window..."oshima@chromium.org2013-12-061-22/+11
| | | | | | | | | | | | | | | | | | | | > Make sure WindowObservers are removed from window before destruction > > * Check if the window observer is empty upon destruction. > * remove the all observers in ~WindowObserver() > * Remove RemoveObserver that are no longer necessary > * Fix shell shutdown order so that observers are removed correctly before deleting all windows. > > BUG=324018 > R=skuhne@chromium.org, sky@chromium.org > > Review URL: https://codereview.chromium.org/101013002 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/103863003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239239 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure WindowObservers are removed from window before destructionoshima@chromium.org2013-12-061-11/+22
| | | | | | | | | | | | | | * Check if the window observer is empty upon destruction. * remove the all observers in ~WindowObserver() * Remove RemoveObserver that are no longer necessary * Fix shell shutdown order so that observers are removed correctly before deleting all windows. BUG=324018 R=skuhne@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/101013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239232 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] Add ShelfWindowWatchersimonhong@chromium.org2013-12-061-0/+5
| | | | | | | | | | | | | | This is the first CL to add a LauncherItem of TYPE_DIALOG. ShelfWindowWatcher creates and manages a LauncherItem for aura::Window that has LauncherItemDetails property. R=sky@chromium.org BUG=121242 TEST=ash_unittests --gtest_filter=ShelfWindowWatcherTest.* Review URL: https://codereview.chromium.org/80933003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239169 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Rename more Launcher classes to Shelf*.tfarina@chromium.org2013-12-041-12/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Rename LauncherItemDelegate to ShelfItemDelegate. * Move launcher_item_delegate.h from launcher/ to shelf/ * Rename to shelf_item_delegate.h * Rename TestLauncherItemDelegate to TestShelfItemDelegate. * Move test_launcher_item_delegate.* from launcher/ to shelf/ * Rename to test_shelf_item_delegate.* * Rename LauncherItemDelegateManager to ShelfItemDelegateManager. * Move launcher_item_delegate_manager.* from launcher/ to shelf/ * Rename to shelf_item_delegate_manager.* * Rename LauncherItemDelegateManagerTestAPI to ShelfItemDelegateManagerTestAPI. * Move launcher_item_delegate_manager_test_api.* from launcher/ to shelf/ * Rename to shelf_item_delegate_manager_test_api.* * Rename WindowWatcherLauncherItemDelegate to WindowWatcherShelfItemDelegate. * Move window_watcher_launcher_item_delegate.* from launcher/ to shelf/ * Rename to window_watcher_shelf_item_delegate.* * Rename LauncherMenuModel to ShelfMenuModel. * Host it into its own header file named shelf_menu_model.h BUG=248353 TEST=None, no functional changes R=jamescook@chromium.org,harrym@chromium.org Review URL: https://codereview.chromium.org/97173003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238696 0039d316-1c4b-4281-b951-d872f2087c98
* events: Introduce EventTargeter.sadrul@chromium.org2013-12-021-0/+10
| | | | | | | | | | | | | | | | | EventTargeter will be used for finding the target for dispatching events in aura and views. More details about the design at the document linked at the bug. This patch introduces an EventTargeter interface, with an empty default implementation. It also adds some functions to the EventTarget interface that will be used by the actual EventTargeter implementation. BUG=318879 R=ben@chromium.org Review URL: https://codereview.chromium.org/98293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238146 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 236048 "Rename RootWindowHost* to WindowTreeHost*"ben@chromium.org2013-11-201-1/+1
| | | | | | | | | | | | | | | > Rename RootWindowHost* to WindowTreeHost* > > TBR=sky@chromium.org > http://crbug.com/308843 > > Review URL: https://codereview.chromium.org/76583003 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/77203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236093 0039d316-1c4b-4281-b951-d872f2087c98
* Rename RootWindowHost* to WindowTreeHost*ben@chromium.org2013-11-191-1/+1
| | | | | | | | | TBR=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/76583003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236048 0039d316-1c4b-4281-b951-d872f2087c98
* Adding 2 simple UMA stats to track shelf alignment usage, firstly track when ↵harrym@chromium.org2013-11-191-0/+1
| | | | | | | | | | | a shelf alignment is changed (rare), and during usage of the shelf launcher (buttons on the shelf) track the current alignment (more common) to provide some data on how frequent usage is of the various alignments. BUG=298174 TBR=askvitkine@chromium.org Review URL: https://codereview.chromium.org/26373009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235904 0039d316-1c4b-4281-b951-d872f2087c98
* Add a full screen virtual keyboard to virtual keyboard root windowbshe@chromium.org2013-11-181-9/+22
| | | | | | | | | | | | | | | | | | | This relands https://codereview.chromium.org/47873003. It was reverted because of VirtualKeyboardWindowControllerTest.VirtualKeyboardWindowTest test crash on win8_aura. R=oshima@chromium.org TBR=jamescook, sadrul BUG=310331 TEST= 1. add keyboard-usability-experiment flag 2. hook up an external screen 3. boot device expected: a full screen keyboard on one of the screen Review URL: https://codereview.chromium.org/62833010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235795 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Add GetItemIndexForType() function to ShelfModel.tfarina@chromium.org2013-11-181-2/+1
| | | | | | | | | | | | | | | | | | Now that this function is generic enough, there is no reason to not provide it directly from ShelfModel. See previous CLs: https://codereview.chromium.org/27369004 https://codereview.chromium.org/53513003 https://codereview.chromium.org/71653003 BUG=None TEST=None, no functional changes R=jamescook@chromium.org Review URL: https://codereview.chromium.org/68523017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235641 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r235502 "Add a full screen virtual keyboard to virtual keyboard root ↵thakis@chromium.org2013-11-171-22/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | window" Test has been failing on Win8 Aura since it landed. [ RUN ] VirtualKeyboardWindowControllerTest.VirtualKeyboardWindowTest [1816:612:1115/193527:1412105:FATAL:display_manager.cc(571)] Check failed: 1u == updated_display_info_list.size() (1 vs. 2)Multiple display test does not work on Win8 bots. Please skip (don't disable) the test using SupportsMultipleDisplays() Backtrace: base::debug::StackTrace::StackTrace [0x6C8EBBF1+33] logging::LogMessage::~LogMessage [0x6C71D2FE+94] ash::internal::DisplayManager::UpdateDisplays [0x5BA229F5+293] ash::internal::DisplayManager::OnNativeDisplaysChanged [0x5BA22173+2723] ash::internal::DisplayManager::InitFromCommandLine [0x5BA1E281+817] ash::Shell::Init [0x5B7628A2+210] ash::Shell::CreateInstance [0x5B75C8D9+361] ash::test::AshTestHelper::SetUp [0x01782E29+281] ash::test::AshTestBase::SetUp [0x017753AC+332] ash::test::VirtualKeyboardWindowControllerTest::SetUp [0x016A57D7+247] testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x0174E3BF+319] testing::Test::Run [0x01738DDB+107] testing::TestInfo::Run [0x017397ED+221] testing::TestCase::Run [0x01739F9F+239] testing::internal::UnitTestImpl::RunAllTests [0x017408ED+701] testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x0174EFE7+327] testing::UnitTest::Run [0x0173F150+192] base::TestSuite::Run [0x0172DD00+240] main [0x01647767+103] __tmainCRTStartup [0x018B870F+447] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:555) mainCRTStartup [0x018B853F+15] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:371) BaseThreadInitThunk [0x750D8543+14] RtlInitializeExceptionChain [0x775DAC69+133] RtlInitializeExceptionChain [0x775DAC3C+88] http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/12680/steps/ash_unittests/logs/stdio BUG=310331 TBR=bshe@chromium.org Review URL: https://codereview.chromium.org/74693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235520 0039d316-1c4b-4281-b951-d872f2087c98
* Add a full screen virtual keyboard to virtual keyboard root windowbshe@chromium.org2013-11-161-9/+22
| | | | | | | | | | | | | BUG=310331 TEST= 1. add keyboard-usability-experiment flag 2. hook up an external screen 3. boot device expected: a full screen keyboard on one of the screen Review URL: https://codereview.chromium.org/47873003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235502 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some pass-thrus on RootWindow API in favor of exposing the ↵ben@chromium.org2013-11-151-1/+1
| | | | | | | | | | | RootWindowHost again. R=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/72503002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235293 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Rename LauncherModel to ShelfModel.tfarina@chromium.org2013-11-141-11/+10
| | | | | | | | | | | | | * Move launcher_model.* from launcher/ to shelf/ * Rename to shelf_model.* BUG=248353 TEST=None, no functional changes R=jamescook@chromium.org,harrym@chromium.org Review URL: https://codereview.chromium.org/71653003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235217 0039d316-1c4b-4281-b951-d872f2087c98
* Remove restrictions for cursor visibility from CompoundEventFiltertdanderson@chromium.org2013-11-141-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove the variable |cursor_hidden_by_filter_| from CompoundEventFilter and instead always show the cursor on a (non-synthetic) mousemove and always hide the cursor on touch in the function CompoundEventFilter::SetCursorVisibilityOnEvent(). There shouldn't be a reason for this function to track whether or not it was responsible for showing/hiding the cursor in the first place. If the user moves the cursor, they expect it to become visible, and if they touch the screen then they expect the cursor to hide regardless of where the cursor state had previously been mutated. Of course, the exception to the above would be if the cursor has a lock set. CursorManager::ShowCursor()/HideCursor() already checks if there is a lock on the cursor and, if so, will not change the cursor visibility state. Setting a cursor lock should be the only mechanism for freezing the cursor state. I suspect that landing this patch will resolve the problems related to invisible cursors (issue 267789 and its duplicates). BUG=267789 Review URL: https://codereview.chromium.org/58973005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235024 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some uses of RootWindow in Ash.ben@chromium.org2013-11-091-1/+1
| | | | | | | | | | | Adds a window() accessor to RootWindow. This is redundant now but necessary for when RootWindow is no longer a RootWindow. A subsequent CL will sever that relationship. R=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/67083004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234082 0039d316-1c4b-4281-b951-d872f2087c98
* Elim Shell:browser_contextstevenjb@chromium.org2013-11-081-1/+0
| | | | | | | | | | | | | | | This is some cleanup from another CL where I discovered that Shell::Get()->browser_context() isn't actually used by Chrome, only by ash_shell. To eliminate that confusion I eliminated it and changed the ash_shell code to rely on delegate()->GetCurrentBrowserContext() to be consistent with Chrome. BUG=none R=ben@chromium.org, jamescook@chromium.org Review URL: https://codereview.chromium.org/59153009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234024 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate Shell::RootWindowList in favor of aura::Window::Windows.ben@chromium.org2013-11-081-3/+3
| | | | | | | | | | | | | This is necessary as part of my plan to rework RootWindow, specifically making it not be a subclass of Window. (It will eventually be renamed WindowEventDispatcher). Code that expected to get the RootWindow interface from this type can still call GetDispatcher() on members of the returned vector of Windows. R=oshima@chromium.org http://crbug.com/308843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233787 Review URL: https://codereview.chromium.org/64933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233970 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 233787 "Eliminate Shell::RootWindowList in favor of aura:..."ben@chromium.org2013-11-081-3/+3
| | | | | | | | | | | | | | | | | > Eliminate Shell::RootWindowList in favor of aura::Window::Windows. > > This is necessary as part of my plan to rework RootWindow, specifically making it not be a subclass of Window. (It will eventually be renamed WindowEventDispatcher). Code that expected to get the RootWindow interface from this type can still call GetDispatcher() on members of the returned vector of Windows. > > R=oshima@chromium.org > http://crbug.com/308843 > > Review URL: https://codereview.chromium.org/64933002 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/59153004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233813 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate Shell::RootWindowList in favor of aura::Window::Windows.ben@chromium.org2013-11-081-3/+3
| | | | | | | | | | | This is necessary as part of my plan to rework RootWindow, specifically making it not be a subclass of Window. (It will eventually be renamed WindowEventDispatcher). Code that expected to get the RootWindow interface from this type can still call GetDispatcher() on members of the returned vector of Windows. R=oshima@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/64933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233787 0039d316-1c4b-4281-b951-d872f2087c98
* Sticky keys modifies mouse click and scroll events in addition to key events.tengs@chromium.org2013-11-081-0/+8
| | | | | | | | | | | Also refactor StickyKeys to be an EventHandler itself. BUG=308659, 308662 TEST=enable existing interactive_ui_test case and manual testing Review URL: https://codereview.chromium.org/60013011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233744 0039d316-1c4b-4281-b951-d872f2087c98
* Makes Shell::GetParentTarget() return Envsky@chromium.org2013-11-051-1/+1
| | | | | | | | | | | | This way EventHandlers added to Env are notified. BUG=315155 TEST=covered by test. R=sadrul@chromium.org Review URL: https://codereview.chromium.org/60513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233108 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Rename GetLauncherItemIndexForType to GetShelfItemIndexForType().tfarina@chromium.org2013-11-011-2/+2
| | | | | | | | | | | | | - move launcher_model_util.* from launcher/ to shelf/ - rename to shelf_model_util.* BUG=248353 TEST=None, no functional changes R=harrym@chromium.org,jamescook@chromium.org Review URL: https://codereview.chromium.org/53513003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232415 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce MediaDelegateoshima@chromium.org2013-11-011-0/+4
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/48523010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232330 0039d316-1c4b-4281-b951-d872f2087c98
* Process --ash-host-window-bounds firstoshima@chromium.org2013-10-311-7/+8
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/49713003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232024 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 17:56:39 +0000