summaryrefslogtreecommitdiffstats
path: root/ash/shell/shell_delegate_impl.cc
Commit message (Collapse)AuthorAgeFilesLines
* Remove unused WindowWatcher pointer from Ash [Shell|Shelf]Delegate.msw2016-01-051-11/+3
| | | | | | | | | | | | Other minor cleanup; no functionality changes. BUG=NONE TEST=Ash compliles and works as expected. R=sky@chromium.org Review URL: https://codereview.chromium.org/1555403002 Cr-Commit-Position: refs/heads/master@{#367644}
* Remove Chrome OS "Mirror" UI. Part 1.dzhioev2015-11-171-4/+0
| | | | | | | | | | | Removed ash/ part of the Mirror UI. Sign-in part will be removed in a following CL. BUG=546731 Review URL: https://codereview.chromium.org/1448283002 Cr-Commit-Position: refs/heads/master@{#360201}
* This CL replaces std::string user_id in ash/* with AccountId.alemate2015-11-121-1/+1
| | | | | | | | | | | | | | | This CL replaces most of ASH temporary AccountId to/from email transformations with AccountId references. It also replaces strings in multi_user_util with AccountId objects. This is part of transition to AccountId. BUG=468875 TEST=manual Review URL: https://codereview.chromium.org/1428213004 Cr-Commit-Position: refs/heads/master@{#359225}
* Don't use base::MessageLoop::{Quit,QuitClosure} in ash/, chromeos/, device/ki.stfu2015-10-121-1/+1
| | | | | | | | | | | | | This patch renames base::MessageLoop::{Quit,QuitClosure} to base::MessageLoop::{QuitWhenIdle,QuitWhenIdleClosure}. BUG=131220 TEST= R=oshima@chromium.org,stevenjb@chromium.org,reillyg@chromium.org Review URL: https://codereview.chromium.org/1396083003 Cr-Commit-Position: refs/heads/master@{#353548}
* Extract content dependency from keyboard codeben2015-10-101-4/+3
| | | | | | | | | | | | | Move content specific stuff to content subdir. KeyboardControllerProxy -> KeyboardUI Restructure targets. R=sky@chromium.org http://crbug.com/332504 Review URL: https://codereview.chromium.org/1392713002 Cr-Commit-Position: refs/heads/master@{#353441}
* Extract content-specific aspects of SessionStateDelegate onto ShellContentState.ben2015-10-051-20/+6
| | | | | | | | | R=sky@chromium.org http://crbug.com/332504 Review URL: https://codereview.chromium.org/1377343003 Cr-Commit-Position: refs/heads/master@{#352381}
* Introduce ShellContentState.ben2015-10-031-11/+5
| | | | | | | | | R=sky@chromium.org http://crbug.com/332504 Review URL: https://codereview.chromium.org/1382793002 Cr-Commit-Position: refs/heads/master@{#352262}
* Eliminate a couple of simple uses of BrowserContent in ash by shifting ↵ben2015-09-301-0/+4
| | | | | | | | | | | complexity to ChromeShellDelegate. R=sky@chromium.org http://crbug.com/332504 Review URL: https://codereview.chromium.org/1365413002 Cr-Commit-Position: refs/heads/master@{#351677}
* Deprecating high-conflict acceleratorsafakhry2015-09-091-0/+5
| | | | | | | | | | | | | | | | | | | | | | | This CL designs a framework for deprecated accelerators. In this CL we deprecate the following accelerators: - Lock Screen: Ctrl+Shift+L --> Search+L - Task Manager: Shift+Esc --> Search+Esc The old accelerators are still enabled, but the user is shown a notification message telling him about the new accelerator. UMA stats are recorded for both old and new accelerators. Keyboard overlay has been updated. BUG=492454,486198,498565,405317,503351 TEST=manually, ash_unittests --gtest_filter=DeprecatedAcceleratorTester.*, ash_unittests --gtest_filter=AcceleratorTableTest.CheckDeprecatedAccelerators Committed: https://crrev.com/c2b81c9fca4abc10cafdc75d2e7b4f15314e2e5b Cr-Commit-Position: refs/heads/master@{#335410} Review URL: https://codereview.chromium.org/1177773002 Cr-Commit-Position: refs/heads/master@{#347865}
* Refactoring the ownership of ui::InputMethod.shuchen2015-06-101-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is IMF refactoring according to the design: - For @google.com: https://docs.google.com/document/d/14PQN4fbbSTlJmIk6qk7RzsuNr7O22DUTfNQ6slxKWV0 - For @chromium.org: https://docs.google.com/document/d/1sDES_kuEVUjb_FwCvKsg0Ef48edq5lAx589r0qUtG4g This cl includes some fundamental changes: 1) ui::InputMethod is created & owned by aura::WindowTreeHost. Therefore, the InputMethod instance can be accessed through root_window->GetHost()->GetInputMethod, and no need to save kRootWindowInputMethodKey instance to the root window anymore. 2) Removed InputMethodEventFilter, therefore no need the flag IsTranslated()/SetTranslated() on ui::KeyEvent. 3) Makes aura::WindowTreeHost as a ui::EventSource, because all kinds of WindowTreeHost are also ui::EventSource. Therefore, WindowTreeHost can override DeliverEventToProcessor method to intercept key events for input method processing. Note: 1) The key events processing by input method happens after event rewriters and before the EventHandler's, which remains no change to original on desktop environment. For Ash, the IME key event handling is moved ahead of some other handles: - MagnifierKeyScroller (CrOS only): handles Arrow keys when magnification is enabled. - SpokenFeedbackToggler (CrOS only): handles F6 key when SpokenFeedbackToggler is enabled. - OverlayEventFilter: handles ESC/OEM_2/HELP/F14 keys to cancel the overlay UI. 2) For Ash, remains the singleton ui::InputMethod instance, owned by DisplayController. Because if let each AshWindowTreeHost own separated ui::InputMethod instances, it will break things: a) There is a test: ExtendedDesktopTest.KeyEventsOnLockScreen, which tests the text field in root window X can be inserted with text while dispatching key events to root window Y. I think this test makes no sense and will confirm with oshima@. b) For now for Ozone, DrmWindowHost::CanDispatchEvent() always returns true, so that only primary window tree host can receive the key events, which makes the "primary" InputMethod can receive the key events. c) For Virtual Keyboard on CrOS, it listens to the notification through InputMethodObserver::OnShowImeIfNeeded(), which is bound to the specific InputMethod instance. However, the Virtual Keyboard should work cross multiple root windows & InputMethod instances. BUG=474828 TEST=Verified on local builds, including linux, cros, win7 & win8.1. And all tests passed. Review URL: https://codereview.chromium.org/1155013005 Cr-Commit-Position: refs/heads/master@{#333698}
* Fix the following two cases in multiprofile scenario:xdai2015-04-151-0/+4
| | | | | | | | | | | | | | | | | 1) Window A belongs to user1 and is shown for user1. Minimizes window A. Switch to user2, window A can not be activated by user2. 2) Window A belongs to user1 and is shown for user2. Then windowA can be activated by user2 but cannot be activated by user1. Also add unit tests for these two cases. BUG=471858 TEST=manually tested Review URL: https://codereview.chromium.org/1053013007 Cr-Commit-Position: refs/heads/master@{#325259}
* Implemented ForceMaximizeBrowserWindowOnFirstRun policy, added unit test and ↵peletskyi2015-04-081-0/+4
| | | | | | | | | | browser test. BUG=356285 Review URL: https://codereview.chromium.org/964503002 Cr-Commit-Position: refs/heads/master@{#324244}
* Enable keyboard accelerator for GetHelp in Ash.cylee2015-01-081-0/+1
| | | | | | | | | | | In the past the accelerator is handled at browser level so doesn't work if no browser window present. BUG=321568 Review URL: https://codereview.chromium.org/827253002 Cr-Commit-Position: refs/heads/master@{#310485}
* Standardize usage of virtual/override/final specifiers.dcheng2014-10-281-38/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=jamescook@chromium.org Review URL: https://codereview.chromium.org/679283002 Cr-Commit-Position: refs/heads/master@{#301535}
* replace OVERRIDE and FINAL with override and final in ash/mostynb2014-10-031-32/+32
| | | | | | | | BUG=417463 Review URL: https://codereview.chromium.org/621133002 Cr-Commit-Position: refs/heads/master@{#298040}
* Move ownership of the AppListViewDelegate into the AppListServicetapted2014-09-191-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's currently hard for the AppListService to access the model. The model is now profile keyed. However, to get the "right" profile, the AppListViewDelegate is the current source of truth. And to get this, AppListService needs to dig into its platform-specific parts to get it via the platform-specific view. However, the AppListView can be destroyed, so the delegate doesn't always exist. Therefore the AppListViewDelegate doesn't always exist -- it is created each time the AppListView is created. On ChromeOS, this is each time the app list is shown. Before the model was profile-keyed, some state was tricky to store. E.g., some is stored in ExtensionAppModelBuilder, and updated via notifications (e.g. NOTIFICATION_APP_INSTALLED_TO_APPLIST). Also, since the model must now outlive the AppListView for sync, it makes less sense for the AppListViewDelegate to be owned by the view. Currently showing the app list can create a new ALVD, which must be re-attached to the model each time. This change moves ownership of the AppListViewDelegate into the AppListServiceIpml or test/shell controllers, which will create it lazily and then cache the result. BUG=403647, 404535 Review URL: https://codereview.chromium.org/508813002 Cr-Commit-Position: refs/heads/master@{#295646}
* Providing more information on why certain users can't be added to multi-profilersorokin@chromium.org2014-08-131-0/+3
| | | | | | | | | | | session BUG=388279 Review URL: https://codereview.chromium.org/374853002 Cr-Commit-Position: refs/heads/master@{#289304} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289304 0039d316-1c4b-4281-b951-d872f2087c98
* Move UserInfo to user_manager.nkostylev@chromium.org2014-07-141-31/+6
| | | | | | | | | | Since user_manager::UserInfo is used on non-chromeos ash implementation, defined part of user_manager component that is included on cross-platform ash. BUG=387614 Review URL: https://codereview.chromium.org/379803004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283087 0039d316-1c4b-4281-b951-d872f2087c98
* Media indicator for background recording taskoshima@chromium.org2014-05-031-2/+105
| | | | | | | | | BUG=323766 TEST=MediaTrayItemTest.NotifyMediaCaptureChange Review URL: https://codereview.chromium.org/253183003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268077 0039d316-1c4b-4281-b951-d872f2087c98
* CleanUp: Introduce UserInfo. Move session_state stuff to ash/session.oshima@chromium.org2014-04-301-2/+2
| | | | | | | | | | | | BUG=None R=nkostylev@chromium.org TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267158 Review URL: https://codereview.chromium.org/253063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267337 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 267158 "CleanUp: Introduce UserInfo. Move session_state s..."oshima@chromium.org2014-04-301-2/+2
| | | | | | | | | | | | | | | | > CleanUp: Introduce UserInfo. Move session_state stuff to ash/session. > > BUG=None > R=nkostylev@chromium.org > TBR=sky@chromium.org > > Review URL: https://codereview.chromium.org/253063002 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/260783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267250 0039d316-1c4b-4281-b951-d872f2087c98
* CleanUp: Introduce UserInfo. Move session_state stuff to ash/session.oshima@chromium.org2014-04-301-2/+2
| | | | | | | | | | BUG=None R=nkostylev@chromium.org TBR=sky@chromium.org Review URL: https://codereview.chromium.org/253063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267158 0039d316-1c4b-4281-b951-d872f2087c98
* Introdcue AshWindowTreeHost and move ash/chrome specific code in WTH to ash.oshima@chromium.org2014-04-111-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | Other notable changes: * Removed WindowTreeHostFactory as this is no longer necessary. * Moved RootWindowTransformer to ash/host * Removed Set/GetInsets which are no longer necessary (a code in SetInsets is now a part of SetRootWindowTransformer) * Added TransformerHelper that implements common behavior to transform root window for AshWindowTreeHost * Added DEPS files * Updated metro_viewer code to make sure it creates ash::AshRemoteWindowHostTree A few more simplifications to come: * Simplify RootWindowTransformer * Eliminate EnvObserver in AshWindowTreeHostX11 I'll also work on DEPS reorg to make it more explicit under ash/ BUG=355771 TEST=No functional change. ui/aura/window_tree_host_x11_unittests has been moved to ash/host/ash_window_tree_host_x11_unittests Review URL: https://codereview.chromium.org/201573015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263192 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented system tray UI for new account management.dzhioev@chromium.org2014-04-101-0/+4
| | | | | | | | | | | | | | | | | | | | | | | * Added new mode in TrayUser for the case when new account management is enabled (--new-profile-management flag). In fact TrayUser is now supporting four different modes, depending of states of |multi-profiles| flag and |new-profile-management| flag. * Massive refactoring were made in tray_user.cc to isolate UserCardView creation in separate class and make code more clear. * UI for the cases when new account management is disabled remained without changes. Known issues: * There are no tests for new UI. Hopefully old UI is covered by tests already. * New UI is not accessible yet. * Stub implementation of UserAccountsDelegate is used for backend. BUG=344844 TEST=manually Review URL: https://codereview.chromium.org/210903003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262959 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Virtual keyboard support at OOBE/loginnkostylev@chromium.org2014-04-041-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Enabled TouchView mode test accelerator on login screen, changed to Ctrl+Alt+Shift+T (to avoid conflicts). * Added ash::VirtualKeyboardStateObserver to ShellDelegate. LoginDisplayHost subscribes to virtual keyboard activations and hides/shows login WebUI control bar. * Login WebUI window is no longer fullscreen window so when virtual keyboard is shown, login window is resized accordingly. This means a special case for ShelfLayoutManager i.e. status tray (and shelf) should overflow on top of login window and not resize it (as with maximized windows in session) * Added support for scroll in OOBE/login container. When login window resizes new [scroll-container] it has overflow enabled but without scrollbars being shown. * Since all login / oobe WebUI screens are stacked on top of each other and are hidden just with visibility: hidden, added hidden (display: none) attribute to all screens which is removed right before new screen is activated via toggleStep(). Hidden attribute is added after old screen transition finishes. * Adding hidden attribute to all screens breaks two things which are also addressed in this CL: 1. OOBE screens network/eula/update form a screen group so that their size is adjusted to be the same. This is fixed by removing hidden attribute for OOBE screen group during init. 2. Same OOBE screens have sliding animation defined and adding/removing hidden attributed breaks that. Fix (temporary): don't add hidden attribute to old screen after transition ends. BUG=354413 Review URL: https://codereview.chromium.org/211433002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261751 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate ash::internal namespaceoshima@chromium.org2014-04-031-1/+1
| | | | | | | | | | | Plus obvious style nit fixes. BUG=None TBR=sky@chromium.org Review URL: https://codereview.chromium.org/224113005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261522 0039d316-1c4b-4281-b951-d872f2087c98
* Delete "shutdown without closing browsers"oshima@chromium.org2014-03-251-1/+1
| | | | | | | | | | | | | | | | | | | | | Removing unused ShellDelegate::Shutdown() Added new PreShutdown to safely cleanup DisplayObserver. Chrome no longer access X during shutdown (except for deleting X window, which is safe), so normal SessionEnd path should work. There is another issue when this happens during login screen, and I'll file a separate bug for it. BUG=336653 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259061 R=abodenha@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/205963005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259203 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Delete "shutdown without closing browsers" path ↵michaeln@chromium.org2014-03-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/205963005/) Reason for revert: Didn't compile on Linux GTK builder. http://build.chromium.org/p/chromium.linux/builders/Linux%20GTK%20Builder/builds/1997 ../../chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc: In member function 'virtual void BookmarkBarGtk::BookmarkModelBeingDeleted(BookmarkModel*)': ../../chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc:896:8:error: 'ShuttingDownWithoutClosingBrowsers' is not a member of 'browser_shutdown' Original issue's description: > Delete "shutdown without closing browsers" > > Removing unused ShellDelegate::Shutdown() > > Added new PreShutdown to safely cleanup DisplayObserver. > > Chrome no longer access X during shutdown (except for deleting X window, which is safe), so normal SessionEnd > path should work. > > There is another issue when this happens during login screen, and I'll file a separate bug for it. > > BUG=336653 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259061 TBR=abodenha@chromium.org,thestig@chromium.org,oshima@chromium.org NOTREECHECKS=true NOTRY=true BUG=336653 Review URL: https://codereview.chromium.org/210673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259085 0039d316-1c4b-4281-b951-d872f2087c98
* Delete "shutdown without closing browsers"oshima@chromium.org2014-03-251-1/+1
| | | | | | | | | | | | | | | | | Removing unused ShellDelegate::Shutdown() Added new PreShutdown to safely cleanup DisplayObserver. Chrome no longer access X during shutdown (except for deleting X window, which is safe), so normal SessionEnd path should work. There is another issue when this happens during login screen, and I'll file a separate bug for it. BUG=336653 Review URL: https://codereview.chromium.org/205963005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259061 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Simplify how chrome keeps track of caps lock state.sadrul@chromium.org2014-03-121-5/+0
| | | | | | | | | | | | | | | | | | | | | | | Notable changes: * Make caps-lock related tray-item explicitly chromeos-only, since there has never been an implementation of CapsLockDelegate for other platforms. * As a result, have the tray-item directly communicate with XKeyboard, instead of needing the CapsLockDelegate, so delete it. * Have the code that needs to know when the caps-lock state changes (e.g. TrayCapsLock, SigninScreenHandler) use a pre-target handler on Shell and look for VKEY_CAPITAL key-press events. This simplifies the code, which currently flows from: X11 -> SystemKeyEventListener -> SystemTrayDelegate -> SystemTrayNotifier -> TrayCapsLock to: X11 -> WindowTreeHost -> TrayCapsLock BUG=none R=derat@chromium.org, oshima@chromium.org, yusukes@chromium.org TBR=nkostylev@chromium.org for c/b/ui/webui/chromeos/login changes Review URL: https://codereview.chromium.org/192293004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256363 0039d316-1c4b-4281-b951-d872f2087c98
* Move files from ui/views/corewm to ui/wm/coreben@chromium.org2014-03-111-1/+1
| | | | | | | | | | R=sky@chromium.org TBR=sky@chromium.org http://crbug.com/308710 Review URL: https://codereview.chromium.org/194843004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256329 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Remove client::UserActionClient.sadrul@chromium.org2014-03-061-4/+0
| | | | | | | | | | | | | | | | | | | UserActionClient is used to navigate back/forward when the back/forward on a supported mouse-device is clicked on X11. This can instead be achieved by installing an event-handler on the browser window. This does change the behaviour a little on ChromeOS: clicking these navigation buttons when the cursor is not on top of the browser window will not navigate after this change. I have confirmed with UX that this is a desirable change. BUG=319636 R=sky@chromium.org Previously landed in r255385, reverted in r255398 to allow another revert in r255399. Review URL: https://codereview.chromium.org/183853037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255416 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 255385 "aura: Remove client::UserActionClient."ben@chromium.org2014-03-061-0/+4
| | | | | | | | | | | | | | | | | | | | | | | > aura: Remove client::UserActionClient. > > UserActionClient is used to navigate back/forward when the back/forward on a > supported mouse-device is clicked on X11. This can instead be achieved by > installing an event-handler on the browser window. > > This does change the behaviour a little on ChromeOS: clicking these navigation > buttons when the cursor is not on top of the browser window will not navigate > after this change. I have confirmed with UX that this is a desirable change. > > BUG=319636 > R=sky@chromium.org > > Review URL: https://codereview.chromium.org/183853037 TBR=sadrul@chromium.org Review URL: https://codereview.chromium.org/186123004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255398 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Remove client::UserActionClient.sadrul@chromium.org2014-03-061-4/+0
| | | | | | | | | | | | | | | | | UserActionClient is used to navigate back/forward when the back/forward on a supported mouse-device is clicked on X11. This can instead be achieved by installing an event-handler on the browser window. This does change the behaviour a little on ChromeOS: clicking these navigation buttons when the cursor is not on top of the browser window will not navigate after this change. I have confirmed with UX that this is a desirable change. BUG=319636 R=sky@chromium.org Review URL: https://codereview.chromium.org/183853037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255385 0039d316-1c4b-4281-b951-d872f2087c98
* Move root_window_host* in aura to window_tree_host*.ben@chromium.org2014-02-141-1/+1
| | | | | | | | | | R=sky@chromium.org TBR=sky@chromium.org BUG= Review URL: https://codereview.chromium.org/160573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251379 0039d316-1c4b-4281-b951-d872f2087c98
* Renames LauncherID, LauncherItem and LauncherItems...tfarina@chromium.org2014-02-031-1/+1
| | | | | | | | | | | | | to ShelfID, ShelfItem and ShelfItems. BUG=248353 TEST=None R=jamescook@chromium.org,harrym@chromium.org Review URL: https://codereview.chromium.org/152223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248619 0039d316-1c4b-4281-b951-d872f2087c98
* Provide real GPUSupport to ash for Chromejamescook@chromium.org2014-01-311-0/+6
| | | | | | | | | | | | | | | | A recent refactor to extract src/content dependencies from ash broke GPU feature detection for panel fitting on Chrome OS. In particular the OutputConfigurator was set up using a stub GPUSupport object. Fix injection of the GPUSupport object -- move its creation to the ash::ShellDelegate interface. BUG=chrome-os-partner:25204,chrome-os-partner:24868 TEST=existing ash_unittests Review URL: https://codereview.chromium.org/132173006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248226 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] Add TYPE_DIALOG and its item's LauncherContextMenusimonhong@chromium.org2014-01-091-1/+4
| | | | | | | | | | | | | | This is third CL for adding an item for dialog. This cl adds new LauncherItemType, TYPE_DIALOG, and implements a context menu of item created by ShelfWindowWatcher. R=sky@chromium.org BUG=121242 TEST=NONE Review URL: https://codereview.chromium.org/107163005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243965 0039d316-1c4b-4281-b951-d872f2087c98
* Rename RootWindowHost to WindowTreeHostben@chromium.org2014-01-081-2/+2
| | | | | | | | | TBR=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/126513004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243578 0039d316-1c4b-4281-b951-d872f2087c98
* Adding UMA metric tracking to the status are menu and related tray views to ↵harrym@chromium.org2013-12-131-3/+0
| | | | | | | | | | track usage of the menu's. BUG=297046 Review URL: https://codereview.chromium.org/73583003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240537 0039d316-1c4b-4281-b951-d872f2087c98
* Rename CurrentBrowserContext to ActiveBrowserContextoshima@chromium.org2013-12-121-1/+1
| | | | | | | | | | | | | Remove use of GetDefaultProfileXXX in - c/b/ui/ash/chrome_shell_delegate* - c/b/ui/ash/keyboard_controller_proxy.cc - c/b/ui/ash/screenshot_taker.cc BUG=322682 Review URL: https://codereview.chromium.org/112153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240482 0039d316-1c4b-4281-b951-d872f2087c98
* Rename LauncherDelegate to ShelfDelegate.tfarina@chromium.org2013-12-091-7/+7
| | | | | | | | | | | | | | | | | | | - move launcher_delegate.h from launcher to shelf. - rename to shelf_delegate.h - rename LauncherDelegateImpl to ShelfDelegateImpl. - rename to shelf_delegate_impl.* - rename TestLauncherDelegate to TestShelfDelegate. - rename test_shelf_delegate.* to test_shelf_delegate.* BUG=248353 TEST=None, no functional changes R=jamescook@chromium.org,harrym@chromium.org Review URL: https://codereview.chromium.org/103223005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239531 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 236048 "Rename RootWindowHost* to WindowTreeHost*"ben@chromium.org2013-11-201-2/+2
| | | | | | | | | | | | | | | > Rename RootWindowHost* to WindowTreeHost* > > TBR=sky@chromium.org > http://crbug.com/308843 > > Review URL: https://codereview.chromium.org/76583003 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/77203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236093 0039d316-1c4b-4281-b951-d872f2087c98
* Rename RootWindowHost* to WindowTreeHost*ben@chromium.org2013-11-191-2/+2
| | | | | | | | | TBR=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/76583003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236048 0039d316-1c4b-4281-b951-d872f2087c98
* Add a full screen virtual keyboard to virtual keyboard root windowbshe@chromium.org2013-11-181-1/+1
| | | | | | | | | | | | | | | | | | | This relands https://codereview.chromium.org/47873003. It was reverted because of VirtualKeyboardWindowControllerTest.VirtualKeyboardWindowTest test crash on win8_aura. R=oshima@chromium.org TBR=jamescook, sadrul BUG=310331 TEST= 1. add keyboard-usability-experiment flag 2. hook up an external screen 3. boot device expected: a full screen keyboard on one of the screen Review URL: https://codereview.chromium.org/62833010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235795 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r235502 "Add a full screen virtual keyboard to virtual keyboard root ↵thakis@chromium.org2013-11-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | window" Test has been failing on Win8 Aura since it landed. [ RUN ] VirtualKeyboardWindowControllerTest.VirtualKeyboardWindowTest [1816:612:1115/193527:1412105:FATAL:display_manager.cc(571)] Check failed: 1u == updated_display_info_list.size() (1 vs. 2)Multiple display test does not work on Win8 bots. Please skip (don't disable) the test using SupportsMultipleDisplays() Backtrace: base::debug::StackTrace::StackTrace [0x6C8EBBF1+33] logging::LogMessage::~LogMessage [0x6C71D2FE+94] ash::internal::DisplayManager::UpdateDisplays [0x5BA229F5+293] ash::internal::DisplayManager::OnNativeDisplaysChanged [0x5BA22173+2723] ash::internal::DisplayManager::InitFromCommandLine [0x5BA1E281+817] ash::Shell::Init [0x5B7628A2+210] ash::Shell::CreateInstance [0x5B75C8D9+361] ash::test::AshTestHelper::SetUp [0x01782E29+281] ash::test::AshTestBase::SetUp [0x017753AC+332] ash::test::VirtualKeyboardWindowControllerTest::SetUp [0x016A57D7+247] testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x0174E3BF+319] testing::Test::Run [0x01738DDB+107] testing::TestInfo::Run [0x017397ED+221] testing::TestCase::Run [0x01739F9F+239] testing::internal::UnitTestImpl::RunAllTests [0x017408ED+701] testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x0174EFE7+327] testing::UnitTest::Run [0x0173F150+192] base::TestSuite::Run [0x0172DD00+240] main [0x01647767+103] __tmainCRTStartup [0x018B870F+447] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:555) mainCRTStartup [0x018B853F+15] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:371) BaseThreadInitThunk [0x750D8543+14] RtlInitializeExceptionChain [0x775DAC69+133] RtlInitializeExceptionChain [0x775DAC3C+88] http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/12680/steps/ash_unittests/logs/stdio BUG=310331 TBR=bshe@chromium.org Review URL: https://codereview.chromium.org/74693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235520 0039d316-1c4b-4281-b951-d872f2087c98
* Add a full screen virtual keyboard to virtual keyboard root windowbshe@chromium.org2013-11-161-1/+1
| | | | | | | | | | | | | BUG=310331 TEST= 1. add keyboard-usability-experiment flag 2. hook up an external screen 3. boot device expected: a full screen keyboard on one of the screen Review URL: https://codereview.chromium.org/47873003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235502 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Rename LauncherModel to ShelfModel.tfarina@chromium.org2013-11-141-2/+1
| | | | | | | | | | | | | * Move launcher_model.* from launcher/ to shelf/ * Rename to shelf_model.* BUG=248353 TEST=None, no functional changes R=jamescook@chromium.org,harrym@chromium.org Review URL: https://codereview.chromium.org/71653003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235217 0039d316-1c4b-4281-b951-d872f2087c98
* Elim Shell:browser_contextstevenjb@chromium.org2013-11-081-2/+3
| | | | | | | | | | | | | | | This is some cleanup from another CL where I discovered that Shell::Get()->browser_context() isn't actually used by Chrome, only by ash_shell. To eliminate that confusion I eliminated it and changed the ash_shell code to rely on delegate()->GetCurrentBrowserContext() to be consistent with Chrome. BUG=none R=ben@chromium.org, jamescook@chromium.org Review URL: https://codereview.chromium.org/59153009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234024 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce MediaDelegateoshima@chromium.org2013-11-011-9/+18
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/48523010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232330 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-02 21:57:20 +0000