| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
* Removed dead, unnecessary code.
* Change ash_shell to use this logic. (it should behave roughly the same as chrome)
BUG=272460
Review URL: https://codereview.chromium.org/26043002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently AppsModelBuilder assumes all items are ExtensionAppItems.
This will no longer be true as soon as we add AppListFolderItems.
We need to make AppsModelBuilder only apply to extension items.
By design we no longer wish to sync app list ordering with the extension
ordering used by the NTP. This CL will only use the extension ordering
for initial sorting, and as a result app list order changes will not be
preserved until we start saving / syncing the app list order separately,
crbug.com/305024
BUG=303839
For ash/shell/app_list.cc
R=jennyz@chromium.org, koz@chromium.org, xiyuan@chromium.org
TBR=jamescook@chromium.org
Review URL: https://codereview.chromium.org/26328004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=139313
TEST=None
R=ben@chromium.org
Review URL: https://codereview.chromium.org/26410002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should simplify the view/model structure some by having the View
call ItemModel->Activate() directly, rather than going through the
delegate (which continues to manage the model and handle non item
specific events). This will allow us to create folder items as part
of the non Chrome specific model implementation, without having to
make AppListViewDelegate a concrete class, or adding special folder
handling to the view classes.
BUG=303839
For ash/shell:
TBR=jamescook@chromium.org
Review URL: https://codereview.chromium.org/25859005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a StartPageService PKS that holds the start page contents and
app recommendation generator;
- Implement the initial app recommendation using the 4 most recent apps;
- Expose the start page contents in AppListViewDelegate;
- Update AppsGridView could to handle start page case;
- Implement a WebUI for the start page contents;
- Put the start page feature behind a flag;
- Add a switch to override the start page url for easier mocking;
BUG=268660,268661
Review URL: https://codereview.chromium.org/25152002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
Review URL: https://codereview.chromium.org/25676003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Refactor LauncherItemController and LauncherItemDelegate
>
> * Remove LauncherItem parameter of LauncherItemDelegate method
> * LauncherItemController subclasses LauncherItemDelegate
> * Register/Unregister when LauncherItemDelegate is created/removed
> * LauncherItemDelegateManager handles LauncherItemDelegate by LauncherID
> * LauncherItemDelegateManager take ownership of all LauncherItemDelegate
>
> R=sky@chromium.org, skuhne@chromium.org
> BUG=279105
> TEST=unit_tests, browser_tests, ash_unittests, ash_shell
>
> Review URL: https://codereview.chromium.org/23606016
TBR=simon.hong81@gmail.com
Review URL: https://codereview.chromium.org/25716004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Remove LauncherItem parameter of LauncherItemDelegate method
* LauncherItemController subclasses LauncherItemDelegate
* Register/Unregister when LauncherItemDelegate is created/removed
* LauncherItemDelegateManager handles LauncherItemDelegate by LauncherID
* LauncherItemDelegateManager take ownership of all LauncherItemDelegate
R=sky@chromium.org, skuhne@chromium.org
BUG=279105
TEST=unit_tests, browser_tests, ash_unittests, ash_shell
Review URL: https://codereview.chromium.org/23606016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Ctrl-O had once been handled as global shortcut, but now it is
no-op when no browser is open. It can be moved back to browser
shortcut, as it is handled in all other platforms than Chrome OS.
BUG=301445, 251492
Review URL: https://codereview.chromium.org/25225002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=285365,239849
R=bshe@chromium.org
Review URL: https://codereview.chromium.org/24499002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Notable changes:
* Move TouchFactory from ui/base/ into ui/events/x/.
* Split out some switches from ui/base/ into ui/events/.
* Move SequentialIDGenerator from ui/base/ into ui/gfx/.
BUG=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/24692003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=248353
TEST=none, no functional changes.
R=jamescook@chromium.org,xiyuan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/24265009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As part of the work to removed dependencies on ui/base from ui/gfx I have
changed the public api to Canvas, ImageSkia, ImageSkiaRep and ImagePNGRep
to take float scale values instead of ui::ScaleFactor.
The notion of supported scale factors has been broken into 2 parts.
ui::SetSupportedScaleFactors remains and calls the
new ImageSkia::SetSupportedScales().
The initialization of the supported scale factors has been moved from layout.h
into ResourceBundle, and is done explicitly in tests that don't use
ResourceBundle.
BUG=103304
R=ben@chromium.org, oshima@chromium.org, sky@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224473
Review URL: https://codereview.chromium.org/24175004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Remove dependency on ui::ScaleFactor from ui/gfx
>
> As part of the work to removed dependencies on ui/base from ui/gfx I have
> changed the public api to Canvas, ImageSkia, ImageSkiaRep and ImagePNGRep
> to take float scale values instead of ui::ScaleFactor.
>
> The notion of supported scale factors has been broken into 2 parts.
> ui::SetSupportedScaleFactors remains and calls the
> new ImageSkia::SetSupportedScales().
>
> The initialization of the supported scale factors has been moved from layout.h
> into ResourceBundle, and is done explicitly in tests that don't use
> ResourceBundle.
>
> BUG=103304
> R=ben@chromium.org, oshima@chromium.org, sky@chromium.org
>
> Review URL: https://codereview.chromium.org/24175004
TBR=davemoore@chromium.org
Review URL: https://codereview.chromium.org/24262008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As part of the work to removed dependencies on ui/base from ui/gfx I have
changed the public api to Canvas, ImageSkia, ImageSkiaRep and ImagePNGRep
to take float scale values instead of ui::ScaleFactor.
The notion of supported scale factors has been broken into 2 parts.
ui::SetSupportedScaleFactors remains and calls the
new ImageSkia::SetSupportedScales().
The initialization of the supported scale factors has been moved from layout.h
into ResourceBundle, and is done explicitly in tests that don't use
ResourceBundle.
BUG=103304
R=ben@chromium.org, oshima@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/24175004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding a profile selector in the app list menu because currently the only way
to switch the profile is to go into the app list settings which is hard to
find. This CL covers both the mac and windows app list.
The app list switches the profile in place without respawning the app list.
* Added AppListModel::User struct to represent a User in the app list.
* Added a vector of Users to AppListModel.
* AppListMenu builds it model with respect to AppListModel::Users.
* The AppListViewDelegate profile is now switchable via SetProfilePath(). Calling this rebuilds the AppListModel which notifies the view to update.
* Removed custom menu items and views from app_list_menu_views.cc and deleted current_user_menu_item_view on mac.
* Changed ui assets that indicate the current user of the app list.
* Tweaked PaginationModel to handle an app list with 0 apps.
* Mac app list now sets a new delegate to switch the app list profile rather than
dismissing and reshowing.
BUG=254143,258729,289872,290048
Review URL: https://chromiumcodereview.appspot.com/20656002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move window control methods from window_util.h to WindowState
Removed property_util which is no longer necessary.
BUG=272460
Review URL: https://chromiumcodereview.appspot.com/24108003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This wasn't necessary because chrome used to get extra
event. We know ignore redundant events and may not process
any display change event, so we need to explicitly run
extra task to see if we need to create mirror window.
BUG=293015
TEST=see bug for manual test. Also covered by unit test.
Review URL: https://chromiumcodereview.appspot.com/23620060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=275898
Review URL: https://chromiumcodereview.appspot.com/23483041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original patch was reverted as TestSystemTrayDelegate had an ASH_EXPORT, which caused compile error win-aura builder.
DefaultSystemTrayDelegate is the no-op implementation and
TestSystemTrayDelegate contains the test related bits.
This also fixes a crash in the windows side as
TestSystemTrayDelegate::Shutdown() quits the message loop, which is
the wrong thing to do.
BUG=159693 284358
TEST=none
R=oshima@chromium.org
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/23792007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It broke Aura windows builder
FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma\gomacc.exe "c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\bin\cl.exe" /nologo /showIncludes /FC @obj\ash\test\ash_test_support.test_system_tray_delegate.obj.rsp /c ..\..\ash\test\test_system_tray_delegate.cc /Foobj\ash\test\ash_test_support.test_system_tray_delegate.obj /Fdobj\ash\ash_test_support.pdb
c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.cc(24) : error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.cc(24) : warning C4273: 'ash::test::TestSystemTrayDelegate::TestSystemTrayDelegate' : inconsistent dll linkage
c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.h(15) : see previous definition of '{ctor}'
c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.cc(28) : warning C4273: 'ash::test::TestSystemTrayDelegate::~TestSystemTrayDelegate' : inconsistent dll linkage
c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.h(16) : see previous definition of '{dtor}'
c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.cc(33) : warning C4273: 'ash::test::TestSystemTrayDelegate::SetInitialLoginStatus' : inconsistent dll linkage
c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.h(23) : see previous definition of 'SetInitialLoginStatus'
c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.cc(37) : warning C4273: 'ash::test::TestSystemTrayDelegate::SetLoginStatus' : inconsistent dll linkage
c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.h(30) : see previous definition of 'SetLoginStatus'
c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.cc(42) : warning C4273: 'ash::test::TestSystemTrayDelegate::GetUserLoginStatus' : inconsistent dll linkage
c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.h(37) : see previous definition of 'GetUserLoginStatus'
c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.cc(61) : warning C4273: 'ash::test::TestSystemTrayDelegate::ShouldShowDisplayNotification' : inconsistent dll linkage
c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.h(38) : see previous definition of 'ShouldShowDisplayNotification'
c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.cc(65) : warning C4273: 'ash::test::TestSystemTrayDelegate::ShutDown' : inconsistent dll linkage
c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.h(39) : see previous definition of 'ShutDown'
c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.cc(69) : warning C4273: 'ash::test::TestSystemTrayDelegate::SignOut' : inconsistent dll linkage
c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.h(40) : see previous definition of 'SignOut'
ninja: build stopped: subcommand failed.
> Refactors TestSystemTrayDelegate into DefaultSystemTrayDelegate
>
> DefaultSystemTrayDelegate is the no-op implementation and
> TestSystemTrayDelegate contains the test related bits.
>
> This also fixes a crash in the windows side as
> TestSystemTrayDelegate::Shutdown() quits the message loop, which is
> the wrong thing to do.
>
> BUG=159693 284358
> TEST=none
> R=oshima@chromium.org
>
> Review URL: https://chromiumcodereview.appspot.com/23465018
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/23650004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DefaultSystemTrayDelegate is the no-op implementation and
TestSystemTrayDelegate contains the test related bits.
This also fixes a crash in the windows side as
TestSystemTrayDelegate::Shutdown() quits the message loop, which is
the wrong thing to do.
BUG=159693 284358
TEST=none
R=oshima@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23465018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fixed wrong use of GetActiveRootWindow in couple of places.
BUG=266378
Review URL: https://chromiumcodereview.appspot.com/23461048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
directory.
Minor cleanup, the renames started.
BUG=248353
R=jamescook@chromium.org,xiyuan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23983013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
allow changes
There is no change allowed to the shelf when the enterprise mode 'locks down' the shelf.
BUG=285056
TEST=none
Review URL: https://chromiumcodereview.appspot.com/24076002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The app launcher will now display an app's short name (the new
short_name property in the manifest file). If an app's short name
and full name differ, the tooltip will show the full name. If an
app's short name and full name are identical, a tooltip will only
be shown if the title is truncated.
BUG=226848
TEST=If an app has a short name and it differs from its full name,
a tooltip should always be shown, displaying the full name. If an
app does not have a short name override, there should be no change
in behavior, i.e. a tooltip will only be shown if the title is
truncated.
Review URL: https://chromiumcodereview.appspot.com/23709003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After removing old launcher, new launcher don't need BrowserLauncherItemController as LauncherItemController.
New launcher only needs the functionality of monitoring browser and its status change.
To handle this, BrowserStatusMonitor is introduced.
BrowserStatusMonitor monitors BrowserLists to detects creation and deletion of Browser and its
TabStripModel to keep the launcher representation up to date as the active tab changes.
Also ash::TYPE_TABBED is removed from LauncherItemType since ash::TYPE_TABBED is only used by PerBrowser Launcher.
Existing unit tests that used TYPE_TABBED is replaced with TYPE_PLATFORM_APP.
No new unit tests are added for this. Existing unit tests(browser_tests, unit_tests, ash_unittests) can cover this modification.
R=skuhne@chromium.org, sky@chromium.org
BUG=169303, 277241
TEST=Compiles, Manual test, unit_tests, browser_tests, ash_unittests
Review URL: https://chromiumcodereview.appspot.com/22795003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(This CL is splitted from https://codereview.chromium.org/11513005/ prior to adding LauncherItem for dialog)
Refactor LauncherItem bits in LauncherDelegate into LauncherItemDelegate.
LauncherItemDelegateManager helps Launcher/LauncherView to choose right LauncherItemDelegate based on LauncherItemType.
* AppListLauncherItemDelegate is added for TYPE_APP_LIST.
* LauncherItemManager (subclass of LauncherItemDelegate) will be added for TYPE_DIALOG in the separate CL.
R=sky@chromium.org, skuhne@chromium.org
BUG=121242, 279105
TEST=browser_tests, unit_tests, ash_unittests
Review URL: https://chromiumcodereview.appspot.com/22429004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It will remove unnecessary methods. Also, each ash notifications
has its own notifier id as SYSTEM_COMPONENT. Then we can distinguish
those notification types, which means this will enable to allow
some urgent system notifications (like power) in the lock screen.
BUG=250937
R=dewittj@chromium.org, stevenjb@chromium.org
TEST=no breaks on existing tests
Review URL: https://chromiumcodereview.appspot.com/23340002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new feature has to be enabled by a new flag and this part of the implementation is ...
... adding the business logic to enable the dragging and removing.
... cleaning up a few things.
The still required changes are marked with TODO's accordingly.
BUG=249081
TEST=Unittest
Review URL: https://chromiumcodereview.appspot.com/23338004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move it into base::i18n namespace. That is the namespace that should be used
there.
- Consequently, rename the function to InitializeICU().
R=brettw@chromium.org
TBR=ben,thestig,jam
Review URL: https://chromiumcodereview.appspot.com/22875025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Relanding https://chromiumcodereview.appspot.com/22887015/ in two steps to
preserve history of c/b/ui/ash/launcher/chrome_launcher_controller_per_app.*
Step 2 will rename chrome_launcher_controller_per_app.* to
chrome_launcher_controller.*
Original description:
Remove per-browser.* and related tests.
Remove IsPerAppLauncher() interface in LauncherDelegate.
Remove ash-disable-per-app-launcher switch.
Change class name from ChromeLauncherControllerPerApp to ChromeLauncherController.
In the next CL, BrowserLauncherItemController will be replaced with new browser status monitor only for monitoring browser and tab status.
BUG=169303
TEST=unit_tests, browser_tests Launcher*
TBR=skuhne@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23068021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Remove PerBrowser launcher
>
> Remove per-browser.* and related tests.
> Remove IsPerAppLauncher() interface in LauncherDelegate.
> Remove ash-disable-per-app-launcher switch.
> Change class name from ChromeLauncherControllerPerApp to ChromeLauncherController.
>
> In the next CL, BrowserLauncherItemController will be replaced with new browser status monitor only for monitoring browser and tab status.
>
> R=skuhne@chromium.org,jamescook@chromium.org
> BUG=169303
> TEST=unit_tests, browser_tests
>
> Review URL: https://chromiumcodereview.appspot.com/22887015
TBR=simon.hong81@gmail.com
Review URL: https://codereview.chromium.org/22903020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove per-browser.* and related tests.
Remove IsPerAppLauncher() interface in LauncherDelegate.
Remove ash-disable-per-app-launcher switch.
Change class name from ChromeLauncherControllerPerApp to ChromeLauncherController.
In the next CL, BrowserLauncherItemController will be replaced with new browser status monitor only for monitoring browser and tab status.
R=skuhne@chromium.org,jamescook@chromium.org
BUG=169303
TEST=unit_tests, browser_tests
Review URL: https://chromiumcodereview.appspot.com/22887015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=180021
R=marja@chromium.org
TBR=joi@chromium.org,ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23316003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For increased separation between model and view, the AppListViewDelegate
now updates the model on profile and signin status change which then
notifies the AppListView of changes so it can update.
BUG=
TEST=None
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22268009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23020012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When user session is blocked (login screen, lock etc.), virtual keyboard container
window should still be able to process events to function properly.
BUG=263599
TEST=
1. Enable virtual keyboard
2. go to login screen
verify if you can use virtual keyboard to type you password and login
Review URL: https://chromiumcodereview.appspot.com/22465007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Those two methods are the bridge to TimeFormat. Now
chrome/common/time_format is moved to ui/base/l10n, ash code
can directly call them, there's no need to be in ShellDelegate.
BUG=268688
R=jamescook@chromium.org
TEST=build succeeds
Review URL: https://chromiumcodereview.appspot.com/22391006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch renames:
- "Autohide launcher" to "Autohide shelf"
- "Launcher position" to "Shelf position".
BUG=263531
TEST=out_cros/Debug/chrome --disable-setuid-sandbox --ash-use-alternate-shelf --show-launcher-alignment-menu
R=jamescook@chromium.org,sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22007003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Migrate the test cases to use CrasAudioHandler.
Re-enabled PolicyTest.DisableAudioOutput, and fixed an issue found with this test case.
BUG=233310
TBR=derat@chromium.org, rkc@chromium.org
Review URL: https://codereview.chromium.org/21380002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was added to persist a window (like task manager or v2 app)
across all workspaces like maximized / fullscreen. However, now
all of those windows are in the same desktop workspace, the role
of this property is over.
We still keeps multiple workspace code and switching code, that's
(still unclear but probably) used in multi-profile in the future.
In that situation we do not have a window which should persist
across the workspaces.
This CL also removes a test case because the test scenario doesn't
make sense if PERSIST_ACROSS_ALL_WORKSPACES property doesn't exist.
BUG=264396
R=sky@chromium.org, jamescook@chromium.org
TEST=old tests still succeed
Review URL: https://chromiumcodereview.appspot.com/20221002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ash/.
BUG=260807
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19269013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Remove aura from DisplayManager
-Introduced DislayManager::Delegate to decouple DisplayController
- Moved methods that requires aura to DisplayController
- Changed to use DisplayInfo to get native bounds instead of
RootWindow.
* Moved mirror_window_controller_ from Shell to DisplayControlller.
This should belong to DC rather than Shell.
BUG=253991
Review URL: https://chromiumcodereview.appspot.com/19038002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds support for "--log-net-log" command line option in content_shell.
When the commandline option is specified, NetLogLogger is used to log all network activities to a file.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/17633005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
build works.
Make sure login happens after ash is created.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/16305009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change, ash::internal::PowerStatus is mostly the
same as the old chromeos::PowerManagerHandler: it's a
singleton that asks chromeos::PowerManagerClient to request
the power status at startup and then provides
PowerSupplyStatus structs to various classes in ash/system.
Going forward, I plan to remove the PowerSupplyStatus struct
(so that the PowerStatus class hangs on to the original
PowerSupplyProperties protocol buffers sent by the power
manager) and add methods to PowerStatus for accessing the
interesting parts of the protobufs (instead of having
multiple copies of the status sanitized and stored across
the different classes in ash/system).
BUG=254173
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18023007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=254986
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18050008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1.) The header is now in base/mac instead of base/memory
2.) The class is now in namespace base.
This CL was created programmatically by running:
1.)
git grep -l memory/scoped_nsobject.h | xargs sed -i -e 's/memory\/scoped_nsobject.h/mac\/scoped_nsobject.h/g'
for f in $(git diff --name-only origin); do tools/sort-headers.py $f -f; done
git commit -a -m headers
# manually undo changes to gypi file
git cl upload # patch set 1
2.)
git grep -l 'scoped_nsobject<' | xargs sed -i -e 's/scoped_nsobject</base::scoped_nsobject</g'
# manually undo comment changes in scoped_nsobject.h, tracking_area.h
git commit -a -m format
git cl upload # patch set 2
# Manually audit all files, file bugs and clean up bad clang-format decisions
git cl upload # patch set 3
BUG=251957
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/17593006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The win_aura builder appeared to have trouble running
animations in
DesktopBackgroundControllerTest.SetDefaultWallpaper; this
version of the change splits that test into several smaller
tests so that animations can be avoided.
Original change:
ash: Add flags for specifying default wallpaper.
This adds new command-line flags for specifying image files
that will be used as default wallpaper:
--ash-default-guest-wallpaper-large
--ash-default-guest-wallpaper-small
--ash-default-wallpaper-large
--ash-default-wallpaper-small
This makes it easier for Chrome OS to have per-device custom
wallpaper. (We previously loaded the default wallpaper from
a resource file, but that prevents the same build of Chrome
from being used on different devices.)
BUG=248764
Review URL: https://chromiumcodereview.appspot.com/17502005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207800 0039d316-1c4b-4281-b951-d872f2087c98
|