| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
See http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/handling-a-failing-test
and https://groups.google.com/a/chromium.org/d/topic/chromium-dev/_OwJ_GWfOaY/discussion
BUG=none
Review URL: https://codereview.chromium.org/11293028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a SystemBackgroundController class that's
responsible for a ui::Layer that's stacked underneath all
other layers.
I'm also adding an --ash-copy-host-background-at-boot flag
that can be set to instruct the controller to copy the host
window's content into the system background layer at
startup; otherwise, we display the same background color
used by Chrome OS's boot splash screen.
I suspect that there's a small performance hit from copying
(I've seen the XGetImage() take between 25 and 170 ms
depending on hardware), although it seems to be hidden in
the noise of our total boot times. Regardless, I figure
that we should only turn this on right now for systems that
need it (to hide an even-longer delay where the compositor
is drawing but the login background images hasn't been
loaded).
In any case, once the login background is visible, the
system background layer is reset to display the black
background that's needed for fullscreen animations that
manipulate the desktop background (for the workspace or
power button).
BUG=152309
Review URL: https://chromiumcodereview.appspot.com/11273059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a system modal dialog appears in the normal desktop during lock, it should create the background for SystemModalContainer, not for LockSystemModalContainer.
BUG=156941
TEST=ash_unittests passed with the new test case.
Review URL: https://chromiumcodereview.appspot.com/11234044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- move the code to create/open context menu from launcher to
root window controller.
- updated methods that access shelf/launcher state to take root window so that menu can specify on which display it is working on.
BUG=145978, 155776
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11198078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
updated all clients to use one on RootWindowController and/or
Launcher::ForPrimaryDisplay/ForWindow.
BUG=145978
Review URL: https://chromiumcodereview.appspot.com/11017079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/147653
R=sky@chromium.org,sadrul@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10916221
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
which breaks workspace animations. This makes the z-order as we want it (system background
underneath desktop background) and adds a test.
BUG=137342
TEST=covered by tests.
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10913100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
add to the default container, instead you need to go through the
StackingClient.
BUG=137342
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10857021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added special container for background on lock screen.
Background view can now be created in specific container.
Disabled lock screen wallpaper implementation based on serving PNG image via data source.
BUG=136853,137581
TEST=Lock screen on multimonitor configuration. Check that windows on secondary display are hidden with background.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149869
Review URL: https://chromiumcodereview.appspot.com/10810039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"""
2nd display should show the same background as login/lock screen:
Added special container for background on lock screen.
Background view can now be created in specific container.
Disabled lock screen wallpaper implementation based on serving PNG image via data source.
BUG=136853,137581
TEST=Lock screen on multimonitor configuration. Check that windows on secondary display are hidden with background.
Review URL: https://chromiumcodereview.appspot.com/10810039
TBR=antrim@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10829173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added special container for background on lock screen.
Background view can now be created in specific container.
Disabled lock screen wallpaper implementation based on serving PNG image via data source.
BUG=136853,137581
TEST=Lock screen on multimonitor configuration. Check that windows on secondary display are hidden with background.
Review URL: https://chromiumcodereview.appspot.com/10810039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetClientAreaScreenBounds -> GetClientAreaBoundsInScreen
Get/Set ParentBounds -> Get/Set BoundsInParent
GetWorkAreaScreenBounds -> GetWorkAreaBoundsInScreen
GetClientAreaScreenBounds -> GetClientAreaBoundsInScreen
GetWindowScreenBounds -> GetWindowBoundsInScreen
GetScreenBounds -> GetBoundsInScreen
GetRootWindowBounds -> GetBoundsInRootWindow
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10795013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=123160
TEST=extended_desktop_unittests
Review URL: https://chromiumcodereview.appspot.com/10536187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Update the use of GetContainer to use the correct root window.
BUG=123160
TEST=no functional change. all tests must pass.
Review URL: https://chromiumcodereview.appspot.com/10540076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=123160
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10442017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
never removing them. This is problematic as it is possible for a
Window to be destroyed after the shell.
ScopedObserver is pretty generic, but I'll leave it here for now.
BUG=124860
TEST=covered by unit test
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10206027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes it to be implemented by the Aura client, via a new interface EventClient.
The client can determine whether or not a given window and its subtree can receive events.
I also cleaned up the way screen locking is entered/exited via the delegate, and some stuff in ash/shell.
http://crbug.com/119347
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9788001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes it to be implemented by the Aura client, via a new interface EventClient.
The client can determine whether or not a given window and its subtree can receive events.
I also cleaned up the way screen locking is entered/exited via the delegate, and some stuff in ash/shell.
http://crbug.com/119347
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128328
Review URL: https://chromiumcodereview.appspot.com/9788001
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9808068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes it to be implemented by the Aura client, via a new interface EventClient.
The client can determine whether or not a given window and its subtree can receive events.
I also cleaned up the way screen locking is entered/exited via the delegate, and some stuff in ash/shell.
http://crbug.com/119347
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128328
Review URL: https://chromiumcodereview.appspot.com/9788001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes it to be implemented by the Aura client, via a new interface EventClient.
The client can determine whether or not a given window and its subtree can receive events.
I also cleaned up the way screen locking is entered/exited via the delegate, and some stuff in ash/shell.
http://crbug.com/119347
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9788001
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9808044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes it to be implemented by the Aura client, via a new interface EventClient.
The client can determine whether or not a given window and its subtree can receive events.
I also cleaned up the way screen locking is entered/exited via the delegate, and some stuff in ash/shell.
http://crbug.com/119347
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9788001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
be a bit icky for a handful of reasons. In particular it means the
work area changes after going maximized so that you can't assume
maximized windows get the work area bounds. This makes for some
ordering dependencies. I've had to expose the bounds for maximized
windows (and non-maximized windows).
The code feels a bit messy in a number of places right now. In
particular there a handful of places (in testing code) mucking with
work area insets. We don't want that as it generally doesn't do the
right thing anymore.
BUG=116070 118671
TEST=covered by tests, but all see bugs.
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9764008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove MultipleWindowIndicatorButton
Clean up OpaqueBrowserFrameView
Remove CompactBrowserFrameView
Remove ash/wm/compact_layout_manager and compact_status_area_layout_manager
Remove window mode switches
Remove window mode from ash::Shell
Remove ShellDelegate::CycleOrder
Remove ShellDelegate::GetOverrideWindowMode
Remove all outside calls to Shell::IsWindowModeCompact
BUG=117284
TEST=existing tests
Review URL: https://chromiumcodereview.appspot.com/9630002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We're going with "managed" window mode. Oshima made it the default last week and updated the tests, so this just removes the unused mode. I also removed Shell::set_compact_window_mode_for_test() in favor of using ShellDelegate::GetOverrideWindowMode() for the one test that needs compact mode.
BUG=116614
TEST=aura_shell_unittests
Review URL: https://chromiumcodereview.appspot.com/9600006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't align window to grid when restoring window.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9513004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Going forward we'll select compact mode based on command line flags passed by the session manager. Compact mode should go away entirely when Aura is more mature, so we don't need to maintain the ability to switch modes. This patch simplifies the Shell setup code and updates the Shell unit tests to match.
BUG=115314
TEST=aura_shell_unittests, specifically Shell*
Review URL: http://codereview.chromium.org/9452028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- renames aura_shell_test_base to ash_test_base
- AshTestBase no longer subclasses AuraTestBase, instead now it and AuraTestBase both own a helper that does common initialization. This is necessary because in subsequent changes ash::Shell will be responsible for creating and owning its own RootWindow, whereas Aura code could have N RootWindows.
- Makes ScreenAura take a RootWindow instead of using RootWindow::GetInstance()
http://crbug.com/112131
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9425015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
removing RootWindow::GetInstance().
http://crbug.com/112131
TEST=compiles
Review URL: https://chromiumcodereview.appspot.com/9395038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=108763
TEST=manually && aura_shell_unittests passed
Review URL: http://codereview.chromium.org/9368051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Putting this behind --aura-dynamic-window-mode until we're sure we need it. Reverted default window mode to overlapping, unless --aura-force-window-mode-compact is specified. This simplifies unit test setup, as the tests assume overlapping mode. I made the new flag set a bool so I can write unit tests without modifying CommandLine::ForCurrentProcess().
BUG=114018
TEST=aura_shell_unittests updated
Review URL: https://chromiumcodereview.appspot.com/9388013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=112914
TEST=aura_shell_unittests:ShellTest.FullscreenWindowHidesShelf
Review URL: https://chromiumcodereview.appspot.com/9374008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A. Unit tests run in 800x600 (so width != height) with a special static bool set to force overlapping window mode.
B1. Developers with no switches set start with a 1280x1024 window in overlapping mode.
B2. The screen resolution heuristic will choose overlapping mode if the screen is > 800 pixels tall, which makes B1 easy.
C. Developer host window reshapes are interpreted as resolution changes, so if the developer makes the window big the mode switches to
overlapping.
D. Passing --aura-window-mode=<foo> sets the window mode for the entire session. This is *not* passed by session manager. If a device starts up with a low-resolution external monitor, it gets compact mode.
BUG=113299
TEST=aura_shell_unittests ShellTest.*, manually running linux_chromeos with --aura-window-mode=compact / overlapping, manual test on device
Review URL: http://codereview.chromium.org/9369050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds an always-visible black background when ash is
using the compact window mode, to prevent the compositor's
blue clear color from being visible when logging in, in the
middle of animations, etc.
BUG=chromium:10801
TEST=manual: logged in, switched windows, locked the screen, logged out, and shut down without seeing the blue background
Review URL: http://codereview.chromium.org/9371004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Gets things compiling and running again on Mac/Aura after new
accelerator / dispatcher changes.
BUG=None
TEST=aura_shell_unittests
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9374002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the user plugs in a high-resolution external monitor, dynamically switch out of compact window mode into overlapping window mode. Force re-layout of all containers to ensure launcher, status area, etc. show up in proper locations.
BUG=110174
TEST=aura_shell_unittests ShellTest, try plugging and unplugging a monitor with resolution > 1400 pixels wide
Review URL: http://codereview.chromium.org/9320076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=111148
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/9314040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Rename "normal" to "overlapping", since there was some confusion about whether or not compact mode is "normal"
* Remove "--aura-workspace-manager" flag in favor of "--aura-window-mode=managed", as this feature is not compatible with compact mode.
* Change about:flags Window mode to a three-way choice between modes
BUG=112139
TEST=aura_shell_unittests ShellTest, manual check of about:flags
Review URL: http://codereview.chromium.org/9316005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* In debug builds, Ctrl-Alt-A shows/hides it
* Added test coverage for switching modes
* Refactored Shell initialization to support this
BUG=110174
TEST=aura_shell_unittests ShellTest.ChangeWindowMode, manual toggling
Review URL: https://chromiumcodereview.appspot.com/9289008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Renames the following as per the bug description by ben@:
kShellWindowId_ModalContainer -> kShellWindowId_SystemModalContainer
kShellWindowId_LockModalContainer -> kShellWindowId_LockSystemModalContainer
ModalContainerLayoutManager->SystemModalContainerLayoutManager
ModalityEventFilter->SystemModalContainerEventFilter
BUG=109460
TEST=All tests and compilation still succeed.
Review URL: https://chromiumcodereview.appspot.com/9249022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/109290
TEST=unittests
Review URL: http://codereview.chromium.org/9123016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are actually two types of modality that the WM might care about - window modality and system modality. See the definitions of these in ui/base/ui_base_types.h.
This is a precursor to adding support for window modality to Ash. Right now we only do system modality which is undesirable for almost all cases of window modality.
http://crbug.com/109290
TEST=none
Review URL: http://codereview.chromium.org/9109035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was that programmatically modifying the command line doesn't change switches visible in about:flags -- they are in a special section. Reworked the code to:
* Not modify the command line when automatically setting the mode. We now store the mode in ash::Shell.
* Add an "automatic" option for window mode, equivalent to not specifying anything on the command line.
BUG=109002
TEST=aura_shell_unittests for Shell, manual on device modifying about:flags
Review URL: http://codereview.chromium.org/9093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/108457
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/9033007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
http://crbug.com/108457
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/9036011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115743 0039d316-1c4b-4281-b951-d872f2087c98
|