summaryrefslogtreecommitdiffstats
path: root/ash/sticky_keys
Commit message (Collapse)AuthorAgeFilesLines
* Add explicit display ids in DisplayPlacementoshima2016-02-121-1/+2
| | | | | | | | | | | | | * Client is now responsible to provide parent display id, instead of implicitly using primary display as a parent. BUG=582491 TBR=benwells@chromium.org TEST=no functional change. all tests should pass. plus, DisplayManagerTest.GuessDisplayIdFieldsInDisplayLayout Review URL: https://codereview.chromium.org/1680353003 Cr-Commit-Position: refs/heads/master@{#375066}
* Factor out DisplayPlacement from DisplayLayoutoshima2016-02-101-1/+1
| | | | | | | | | | | | | * move SwapPrimaryDisplayForTest to display_manager_test_api.h (I'm moving primary display stuff to display manager now) BUG=582491 TEST=no functional change. all test should still pass. TBR=benwells@chromium.org Review URL: https://codereview.chromium.org/1679053003 Cr-Commit-Position: refs/heads/master@{#374595}
* Use list instead of pair to represent the set of displays.oshima2016-02-011-3/+3
| | | | | | | | BUG=582491 Review URL: https://codereview.chromium.org/1638413007 Cr-Commit-Position: refs/heads/master@{#372736}
* Switch to standard integer types in ash/.avi2015-12-202-1/+1
| | | | | | | | | BUG=138542 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/1540753002 Cr-Commit-Position: refs/heads/master@{#366304}
* Prevent ~StickyKeysOverlay() from calling back into StickyKeysOverlay via ↵amistry2015-10-161-1/+10
| | | | | | | | | | | | | | | | the animator. The animator calls StickyKeysOverlay::OnLayerAnimationEnded() during the destruction of |overlay_widget_|, which dereferences overlay_widget_. However, unique_ptr in libc++ (which we want to replace scoped_ptr with) sets its value to nullptr before deleting the object, resulting in a nullptr dereference. BUG=535321 Review URL: https://codereview.chromium.org/1398403005 Cr-Commit-Position: refs/heads/master@{#354409}
* IWYU for base/memory/scoped_vector.h.thestig2015-08-221-1/+0
| | | | | | | | | | | List from: git gs base/memory/scoped_vector.h|cut -d: -f 1|uniq|xargs grep -L ScopedVector CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=keybuk@chromium.org Review URL: https://codereview.chromium.org/1307643003 Cr-Commit-Position: refs/heads/master@{#344925}
* Enable sticky key unit tests under Ozone.kpschoedel2015-08-121-9/+54
| | | | | | Review URL: https://codereview.chromium.org/1272383005 Cr-Commit-Position: refs/heads/master@{#343023}
* Rename DisplayController to WindowTreeHostManageroshima2015-07-281-7/+9
| | | | | | | | | | This class manages WTH <-> display mapping, and WTHManager is more appropriate than DisplayController. BUG=None Review URL: https://codereview.chromium.org/1262483003 Cr-Commit-Position: refs/heads/master@{#340624}
* Add time_stamp parameter to MouseEvent constructorrobert.bradford2015-02-181-5/+4
| | | | | | | | | | | | | | | | | | In order to allow the use of accurate kernel timestamps in the events from Ozone it is necessary to add a parameter to the constructor for MouseEvent. This CL was partially generated from using a clang tool with some manual changes for files not included in my build and to add header files as necessary. This change fills in all users of the newly added time_stamp parameter with a call into ui::EventTimeForNow() which was the original behaviour used by the constructor. BUG=450341 TEST=Build on all try bots and all unit tests pass. Review URL: https://codereview.chromium.org/934653002 Cr-Commit-Position: refs/heads/master@{#316869}
* Update {virtual,override,final} to follow C++11 style in ash.dcheng2015-01-161-4/+2
| | | | | | | | | | | | | | | | The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=jamescook@chromium.org Review URL: https://codereview.chromium.org/800983006 Cr-Commit-Position: refs/heads/master@{#311791}
* Speculative fix for sticky keys overlay crash.tengs2014-12-063-12/+57
| | | | | | | | | | | | | | The new test case reproduces the same stack trace as in the bug, so it's very probable that this case is causing the crash. BUG=435600 Committed: https://crrev.com/9391c0e45bc3ae50008d0aebf11437550e7f38c6 Cr-Commit-Position: refs/heads/master@{#306504} Review URL: https://codereview.chromium.org/754763005 Cr-Commit-Position: refs/heads/master@{#307140}
* Revert of Speculative fix for sticky keys overlay crash. (patchset #2 ↵thestig2014-12-033-40/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | id:20001 of https://codereview.chromium.org/754763005/) Reason for revert: StickyKeysBrowserTest leaking memory. Original issue's description: > Speculative fix for sticky keys overlay crash. > > The new test case reproduces the same stack trace as in the bug, so it's very > probable that this case is causing the crash. > > BUG=435600 > > Committed: https://crrev.com/9391c0e45bc3ae50008d0aebf11437550e7f38c6 > Cr-Commit-Position: refs/heads/master@{#306504} TBR=jamescook@chromium.org,tengs@chromium.org NOTREECHECKS=true NOTRY=true BUG=435600 Review URL: https://codereview.chromium.org/757433005 Cr-Commit-Position: refs/heads/master@{#306529}
* Speculative fix for sticky keys overlay crash.tengs2014-12-033-6/+40
| | | | | | | | | | | The new test case reproduces the same stack trace as in the bug, so it's very probable that this case is causing the crash. BUG=435600 Review URL: https://codereview.chromium.org/754763005 Cr-Commit-Position: refs/heads/master@{#306504}
* Standardize usage of virtual/override/final specifiers.dcheng2014-10-272-10/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=derat@chromium.org Review URL: https://codereview.chromium.org/680153002 Cr-Commit-Position: refs/heads/master@{#301490}
* Add [Search] modifier key to sticky keys overlay.tengs2014-10-093-1/+9
| | | | | | | | | | | This CL also adds a new test exercising the visibility of the overlay. BUG=421570 TEST=modified existing tests and added a new one Review URL: https://codereview.chromium.org/638253003 Cr-Commit-Position: refs/heads/master@{#298959}
* replace OVERRIDE and FINAL with override and final in ash/mostynb2014-10-033-6/+6
| | | | | | | | BUG=417463 Review URL: https://codereview.chromium.org/621133002 Cr-Commit-Position: refs/heads/master@{#298040}
* Support search as a sticky key.dtseng2014-09-262-1/+8
| | | | | | | | | | | As an important modifier on Chrome OS, this cl makes it possible to use sequenced and locked sticky key modes with the search key. BUG=416964 TEST=manual Review URL: https://codereview.chromium.org/598733002 Cr-Commit-Position: refs/heads/master@{#297054}
* Distinguish between keystroke and character events.kpschoedel@chromium.org2014-07-251-2/+2
| | | | | | | | | | | | | | | | | | | | As described in its class comment, a ui::KeyEvent can be either of two distinct kinds. When constructing a ui::KeyEvent from a native event, the distinction is made by a new IsCharFromNative() call, in the same way that other ui::Event properties are determined, instead of having the caller inspect the native event itself. Removing the redundant |is_char| parameter from constructors also prevent accidental synthetic `mixed' events that consuming code does not handle. Incidentally, while KeyEvent constructor calls are being touched, use EF_NONE instead of 0 to make that argument's purpose clear. BUG=380349 TEST=unit_tests,ash_unittests,events_unittests,ui_unittests,interactive_ui_tests Review URL: https://codereview.chromium.org/404203003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285605 0039d316-1c4b-4281-b951-d872f2087c98
* Prepare to use gfx::RenderText in views::Label.msw@chromium.org2014-07-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Alter Label's API to support a RenderText implementation. This has minimal functional changes to Label for now. The Label rewrite to use RenderText will land separately. Remove the generally unused Label::SetDirectionalityMode. We should always use the text's directionality anyway. (it seems like this was the case even for *FROM_UI...) Also remove views::LabelButton::SetDirectionalityMode. Fix LabelButton mutli-line preferred sizing and layout. Add RenderText flag to swap newline chars for symbols. (We don't want that for multi-line views::Label layout) Add GetCurrentHorizontalAlignment ALIGN_HEAD helper. Expose ElideBehavior and ShadowValues accessors. Set the styles of the argument FontList in SetFontList. (this is how Label transmits style information for now) Fix partial-pixel treatment for centered alignment. Update Message Center's InnerBoundedLabel Label subclass. (minimal changes to keep it working with older paint path) BUG=240037 TEST=Negligible appearance changes (better multi-line label centering). R=sky@chromium.org,asvitkine@chromium.org Review URL: https://codereview.chromium.org/23228004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284401 0039d316-1c4b-4281-b951-d872f2087c98
* Extract touchscreen device management into a generic managerdnicoara@chromium.org2014-06-231-1/+0
| | | | | | | | | | DeviceDataManager is currently X11 specific, so CrOS code that is responsible for touchscreen management would only work under X11. This CL starts extracting device state as generic state that X11 and Ozone implementations can share. BUG=375848 Review URL: https://codereview.chromium.org/289283015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279126 0039d316-1c4b-4281-b951-d872f2087c98
* Convert sticky keys to a chromeos::EventRewriter phase.kpschoedel@chromium.org2014-06-214-1143/+555
| | | | | | | | | | BUG=354035 TEST=unit_tests,ash_unittests,manual R=sadrul@chromium.org,derat@chromium.org Review URL: https://codereview.chromium.org/255033003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278919 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 278342 "Convert sticky keys to a chromeos::EventRewriter ..."oshima@chromium.org2014-06-194-555/+1143
| | | | | | | | | | | | | | | | > Convert sticky keys to a chromeos::EventRewriter phase. > > BUG=354035 > TEST=unit_tests,ash_unittests,manual > R=sadrul@chromium.org,derat@chromium.org > > Review URL: https://codereview.chromium.org/255033003 TBR=kpschoedel@chromium.org Review URL: https://codereview.chromium.org/341923006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278419 0039d316-1c4b-4281-b951-d872f2087c98
* Convert sticky keys to a chromeos::EventRewriter phase.kpschoedel@chromium.org2014-06-194-1143/+555
| | | | | | | | | | BUG=354035 TEST=unit_tests,ash_unittests,manual R=sadrul@chromium.org,derat@chromium.org Review URL: https://codereview.chromium.org/255033003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278342 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Label::PaintText overrides.msw@chromium.org2014-06-191-18/+2
| | | | | | | | | | | | | | | | | This is simple cleanup in preparation for a Label rewrite. These overrides were supplying an extra gfx::Canvas flag. Instead, add an explicit label flag for NO_SUBPIXEL_RENDERING. Update some callers and the unit test. TODO(followup): Update more Label::SetBackgroundColor callers. BUG=240037 TEST=No exit warning or sticky keys label rendering changes. R=sky@chromium.org Review URL: https://codereview.chromium.org/341713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278213 0039d316-1c4b-4281-b951-d872f2087c98
* Retires ui::TranslatedKeyEvent and replaces it with KeyEvent.yukishiino@chromium.org2014-05-221-3/+1
| | | | | | | | | | BUG=339355 TEST=Run unittests. TBR=jamesr@chromium.org, pfeldman@chromium.org Review URL: https://codereview.chromium.org/267723008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272228 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 271468 "Revert of [Refactor] Consolidate the logic for wh..."erg@chromium.org2014-05-191-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The revert broke Windows interactive_ui_tests. The world has probably changed since this was first committed. WidgetTestInteractive.CanActivateFlagIsHonored http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/29193/steps/interactive_ui_tests/logs/stdio > Revert of [Refactor] Consolidate the logic for whether a widget can be activated. (https://codereview.chromium.org/286733002/) > > Reason for revert: > This CL was causing problems when the value of views::Widget::CanActivate() changes crbug.com/374095 > > I also need to audit the code to find out whether there are any 'non-activatable' widgets which were intended to be activatable > > Original issue's description: > > [Refactor] Consolidate the logic for whether a widget can be activated. > > > > This is a first step towards giving tooltips their own WindowTreeHosts on Linux. > > > > BUG=353533 > > TEST=None > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270597 > > Review URL: https://codereview.chromium.org/297503003 TBR=pkotwicz@chromium.org Review URL: https://codereview.chromium.org/291013003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271511 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of [Refactor] Consolidate the logic for whether a widget can be ↵pkotwicz@chromium.org2014-05-191-0/+1
| | | | | | | | | | | | | | | | | | | | | | | activated. (https://codereview.chromium.org/286733002/) Reason for revert: This CL was causing problems when the value of views::Widget::CanActivate() changes crbug.com/374095 I also need to audit the code to find out whether there are any 'non-activatable' widgets which were intended to be activatable Original issue's description: > [Refactor] Consolidate the logic for whether a widget can be activated. > > This is a first step towards giving tooltips their own WindowTreeHosts on Linux. > > BUG=353533 > TEST=None > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270597 Review URL: https://codereview.chromium.org/297503003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271468 0039d316-1c4b-4281-b951-d872f2087c98
* [Refactor] Consolidate the logic for whether a widget can be activated.pkotwicz@chromium.org2014-05-151-1/+0
| | | | | | | | | | | This is a first step towards giving tooltips their own WindowTreeHosts on Linux. BUG=353533 TEST=None Review URL: https://codereview.chromium.org/286733002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270597 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for mod3 to sticky keyszork@chromium.org2014-04-105-5/+70
| | | | | | | | | | mod3 is the short name for ISO Level 5 shift, which is used by CA multilingual and German Neo2 keyboard layouts to allow support for a 4th shift state in addition to normal, shift, and AltGr. BUG=335368 Review URL: https://codereview.chromium.org/227893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262895 0039d316-1c4b-4281-b951-d872f2087c98
* Fix sticky keys crash when handling synthetic events without a native event.tengs@chromium.org2014-04-083-23/+96
| | | | | | | | | | | BUG=358270 TEST=modified tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262465 Review URL: https://codereview.chromium.org/227113009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262529 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Fix sticky keys crash when handling synthetic events without a ↵tapted@chromium.org2014-04-083-93/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | native event. (https://codereview.chromium.org/227113009/) Reason for revert: Breaks compile on Linux ChromiumOS (Clang dbg) .../sticky_keys_unittest.cc:848:3:error: ignoring return value of function declared with warn_unused_result attribute [-Werror,-Wunused-result] dispatcher->OnEventFromSource(kev.get()); (and 2 more) link: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20%28Clang%20dbg%29/builds/922/ Original issue's description: > Fix sticky keys crash when handling synthetic events without a native event. > > BUG=358270 > TEST=modified tests > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262465 TBR=sadrul@chromium.org,tengs@chromium.org NOTREECHECKS=true NOTRY=true BUG=358270 Review URL: https://codereview.chromium.org/229053002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262469 0039d316-1c4b-4281-b951-d872f2087c98
* Fix sticky keys crash when handling synthetic events without a native event.tengs@chromium.org2014-04-083-23/+93
| | | | | | | | | BUG=358270 TEST=modified tests Review URL: https://codereview.chromium.org/227113009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262465 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate ash::internal namespaceoshima@chromium.org2014-04-031-3/+2
| | | | | | | | | | | Plus obvious style nit fixes. BUG=None TBR=sky@chromium.org Review URL: https://codereview.chromium.org/224113005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261522 0039d316-1c4b-4281-b951-d872f2087c98
* Don't handle NaturalScroll in Chrome but pass it to CMT insteaddenniskempin@chromium.org2014-04-031-9/+0
| | | | | | | | | | | | | | | | | In order to support mice via CMT (Project Cobra) we will have to do the natural scroll handling in the CMT driver instead of Chrome. BUG=chromium:285663 TEST=test with touchpads and traditional mice. Everything should work as before, touchpad should have natural scroll applied, scroll wheels should not. Test changing the natural scroll property and see if it's applied correctly. Also test if touch mice have natural scroll applied. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260926 Review URL: https://codereview.chromium.org/212603005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261478 0039d316-1c4b-4281-b951-d872f2087c98
* Update StickyKeys overlay to show or hide AltGr depending on thezork@chromium.org2014-03-284-2/+38
| | | | | | | | | | current input method. BUG=335368 Review URL: https://codereview.chromium.org/187313002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260280 0039d316-1c4b-4281-b951-d872f2087c98
* Remove window/host accessors from WindowEventDispatcher. ↵ben@chromium.org2014-03-202-4/+6
| | | | | | | | | | | Include-What-You-Use for WindowTreeHost. TBR=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/196383014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258401 0039d316-1c4b-4281-b951-d872f2087c98
* Test that sticky key clicks work for high DPI displays.tengs@chromium.org2014-03-201-22/+57
| | | | | | | | | | | | | Also test MouseEvents backed by XInput2 generic button native events in addition to XButtonEvents. This CL is split from the fix in https://codereview.chromium.org/191293010. BUG=347660 TEST=new test Review URL: https://codereview.chromium.org/192443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258181 0039d316-1c4b-4281-b951-d872f2087c98
* Fix sticky key clicks not working for high DPI displays.tengs@chromium.org2014-03-161-4/+23
| | | | | | | | | | | | | | Mouse events are transformed during an event dispatch, so redispatching a mouse event will effectively apply the transform to the mouse event location twice. Instead, we create a new mouse event from the native event, which has the original location and redispatch this event. BUG=347660 TEST=new test split in another CL for ease of merging Review URL: https://codereview.chromium.org/191293010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257358 0039d316-1c4b-4281-b951-d872f2087c98
* Provide access to the WindowEventDispatcher as a ui::EventProcessor.ben@chromium.org2014-03-101-8/+9
| | | | | | | | | | | | This avoids using WED from a number of places and moves us closer to a world where WED is more of an implementation detail of WTH. R=sky@chromium.org TBR=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/191153004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256053 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up WindowEventDispatcher some more.ben@chromium.org2014-03-072-2/+0
| | | | | | | | | | | | | | | . Eliminate the implementation of LayerAnimationObserver. It seems no one expects WED to be a LAO anymore. . Remove WindowTreeHostDelegate. This involves moving some of the functions to WTH, removing some completely, and moving the remainder to the WED public API. A little icky for now, but I plan to take a pass on cleaning up WED's public API once I get it pared down. . window_tree_host_x11_unittest provided an implementation of WTHD that was not WED. This is not a valid situation now since various functions in WTH now call directly through to WED. Replaced this with a simple EventHandler to test that events are being dispatched. R=sky@chromium.org http://crbug.com/308843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255368 Review URL: https://codereview.chromium.org/188223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255533 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 255368 "Clean up WindowEventDispatcher some more."ben@chromium.org2014-03-062-0/+2
| | | | | | | | | | | | | | | | | | | > Clean up WindowEventDispatcher some more. > > . Eliminate the implementation of LayerAnimationObserver. It seems no one expects WED to be a LAO anymore. > . Remove WindowTreeHostDelegate. This involves moving some of the functions to WTH, removing some completely, and moving the remainder to the WED public API. A little icky for now, but I plan to take a pass on cleaning up WED's public API once I get it pared down. > . window_tree_host_x11_unittest provided an implementation of WTHD that was not WED. This is not a valid situation now since various functions in WTH now call directly through to WED. Replaced this with a simple EventHandler to test that events are being dispatched. > > R=sky@chromium.org > http://crbug.com/308843 > > Review URL: https://codereview.chromium.org/188223002 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/188843003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255399 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up WindowEventDispatcher some more.ben@chromium.org2014-03-062-2/+0
| | | | | | | | | | | | | . Eliminate the implementation of LayerAnimationObserver. It seems no one expects WED to be a LAO anymore. . Remove WindowTreeHostDelegate. This involves moving some of the functions to WTH, removing some completely, and moving the remainder to the WED public API. A little icky for now, but I plan to take a pass on cleaning up WED's public API once I get it pared down. . window_tree_host_x11_unittest provided an implementation of WTHD that was not WED. This is not a valid situation now since various functions in WTH now call directly through to WED. Replaced this with a simple EventHandler to test that events are being dispatched. R=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/188223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255368 0039d316-1c4b-4281-b951-d872f2087c98
* Add sticky key support for AltGrzork@chromium.org2014-03-053-0/+17
| | | | | | | | BUG=335368 Review URL: https://codereview.chromium.org/175343007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255116 0039d316-1c4b-4281-b951-d872f2087c98
* Window ownership -> WindowTreeHostben@chromium.org2014-03-043-8/+8
| | | | | | | | | | | | | Replaces Window::GetDispatcher with Window::GetHost(). Had to clear ScreenPositionClient property prior to window teardown as tests on desktop delete it prior to destroying the window hierarchy. Unhooking the property appears to have no ill-effect. R=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/184903003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254642 0039d316-1c4b-4281-b951-d872f2087c98
* Move root_window.* to window_event_dispatcher.*ben@chromium.org2014-02-213-3/+3
| | | | | | | | | http://crbug.com/308843 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/174803002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252651 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing x11 checks in StickyKeysHandler.kalyan.kondapally@intel.com2014-02-141-0/+2
| | | | | | | | | | We guard all calls to AppendNativeEventMask with X11 platform checks. It appends native masks and are defined only on X11 platform. This CL adds the missing check in AppendNativeEventMask. Review URL: https://codereview.chromium.org/164223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251225 0039d316-1c4b-4281-b951-d872f2087c98
* Make sticky keys overlay spacing dynamic based on the font size.tengs@chromium.org2014-02-121-10/+18
| | | | | | | | | | | | Revision 248131 deprecated constant font sizes and instead use predefined font styles. We need to adjust the spacing to accomodate dynamic font sizes. BUG=342537 TEST=visual Review URL: https://codereview.chromium.org/159313002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250665 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Remove event-dispatch methods from WindowTreeHostDelegate interface.sadrul@chromium.org2014-01-313-30/+42
| | | | | | | | | | | | | | | Update the aura::WindowTreeHost implementations to also be ui::EventSource, and remove the event-dispatch related methods from the WindowTreeHostDelegate interface. The implementation of the WindowTreeHostDelegate interface related to event-dispatch in RootWindow uses ui::EventProcessor for dispatching events anyway, and so it is a good time to remove this redundant code. BUG=318879 R=ben@chromium.org Review URL: https://codereview.chromium.org/147203004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248154 0039d316-1c4b-4281-b951-d872f2087c98
* Renames gfx::FontList::Derive* family.yukishiino@chromium.org2014-01-311-3/+5
| | | | | | | | | | | | | | | | | | | 1. Removes obsolete methods. - DeriveFontList(font_style) # The method name and argument are not clear compared to other versions. Use DeriveWithStyle(style) below instead. - DeriveFontListWithSize(absolute_size) # Don't specify the absolute size. 2. Renames very long named methods. - DeriveFontListWithSizeDeltaAndStyle => Derive - DeriveFontListWithSizeDelta => DeriveWithSizeDelta - new method => DeriveWithStyle Since DeriveFontListWithSizeDeltaAndStyle is used more often than DeriveFontListWithSizeDelta, so give the former a shorter name. Review URL: https://codereview.chromium.org/142523003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248131 0039d316-1c4b-4281-b951-d872f2087c98
* Show overlay displaying the state of all sticky keys when it is enabled.tengs@chromium.org2014-01-167-111/+723
| | | | | | | | | BUG=229042 TEST=manual, new unit tests Review URL: https://codereview.chromium.org/137373003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245382 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 16:20:04 +0000