summaryrefslogtreecommitdiffstats
path: root/ash/system/audio
Commit message (Collapse)AuthorAgeFilesLines
* [Cleanup] rename tray_delegate -> system_tray_delegateoshima@chromium.org2012-12-121-4/+4
| | | | | | | | | | BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/11476034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172566 0039d316-1c4b-4281-b951-d872f2087c98
* Remove observers from SystemTrayNotifier on destructionoshima@chromium.org2012-12-111-0/+3
| | | | | | | | | | | R=stevenjb@chromium.org BUG=145978 TEST=none Review URL: https://chromiumcodereview.appspot.com/11515004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172227 0039d316-1c4b-4281-b951-d872f2087c98
* Stop using shell::GetInstance()->system_tray() in system tray itemsbartfab@chromium.org2012-11-212-3/+3
| | | | | | | | | | | | | | | | | This CL provides all SystemTrayItem objects with a pointer to the parent SystemTray and all Tray*View objects with a pointer to the parent SystemTrayItem. This allows the objects to walk up the chain and access the correct system tray once multiple system trays are introduced. UpdateNagger::~UpdateNagger() in tray_update.cc continues to go through shell::GetInstance() as the refactoring needed to support multiple system trays here is more complex and out of my expertise. BUG=152928 Review URL: https://chromiumcodereview.appspot.com/11415014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169141 0039d316-1c4b-4281-b951-d872f2087c98
* views: Improve the constant names of the ButtonState enum.tfarina@chromium.org2012-11-141-1/+1
| | | | | | | | | | | | | | | | | | | | | We rename then to STATE_FOO, so it is less confusing: Rather than: if (state == views::CustomButton::BS_HOT) { ... } We now have: if (state == views::CustomButton::STATE_HOVERED) { ... } A bit more verbose, but much better to read. R=sky@chromium.org TBR=jochen@chromium.org # for content/shell Review URL: https://chromiumcodereview.appspot.com/11275272 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167684 0039d316-1c4b-4281-b951-d872f2087c98
* Use the same blue solid border among tray and launcher, for focus.mukai@chromium.org2012-10-301-0/+1
| | | | | | | | BUG=158345 Review URL: https://chromiumcodereview.appspot.com/11306012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164959 0039d316-1c4b-4281-b951-d872f2087c98
* Makes toggling the brightness and volumn not force the launcher tosky@chromium.org2012-10-252-0/+5
| | | | | | | | | | | | | show. The arrow needs to be updated, but that can be done separately. BUG=157899 TEST=none R=sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/11275045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164141 0039d316-1c4b-4281-b951-d872f2087c98
* (reland r156610)oshima@chromium.org2012-09-131-1/+1
| | | | | | | | | | | | | add ash_resources.grd and necessary changes to use images in ash/resources BUG=146034 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156610 Review URL: https://codereview.chromium.org/10905242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156637 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r156610 "add ash_resources.grd and necessary changes to use images in ↵oshima@chromium.org2012-09-131-1/+1
| | | | | | | | | | ash/resources" TBR=oshima@chromium.org BUG=146034 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156614 0039d316-1c4b-4281-b951-d872f2087c98
* add ash_resources.grd and necessary changes to use images in ash/resourcesoshima@chromium.org2012-09-131-1/+1
| | | | | | | | | BUG=146034 TEST=none Review URL: https://codereview.chromium.org/10905242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156610 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the title "mute" under the mute button.jennyz@chromium.org2012-09-061-1/+1
| | | | | | | | BUG=143426 Review URL: https://chromiumcodereview.appspot.com/10915110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155199 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate volume_control_delegate and sysmte_tray_delegatejennyz@chromium.org2012-08-141-19/+23
| | | | | | | | | BUG=115936 Review URL: https://chromiumcodereview.appspot.com/10825264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151607 0039d316-1c4b-4281-b951-d872f2087c98
* Replace views::Event with ui::Event.beng@google.com2012-08-101-1/+1
| | | | | | | | | http://crbug.com/125937 TBR=sky@chromium.org,jochen@chromium.org,sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151105 0039d316-1c4b-4281-b951-d872f2087c98
* Display the volume control detailed when user press mute button.jennyz@google.com2012-08-021-0/+2
| | | | | | | | BUG=140068 Review URL: https://chromiumcodereview.appspot.com/10837062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149545 0039d316-1c4b-4281-b951-d872f2087c98
* Implement new slider control and disable the volume control when audio is muted.jennyz@google.com2012-07-273-15/+42
| | | | | | | | | | | | | | Horizontal slider is implemented with image resources, and it changes UI based the on/off state. Vertical slider is kept in the old way, since I don't have the UI resources for drawing the vertical slider. I wonder if I should remove the vertical slider bar supporting code, or leave it as it which is what I choose to do currently. BUG=124097 TEST=Audio and brightness slider control should be in new UI, and audio slider bar should dim when muted. TBR=oshima@chromium.org Review URL: https://chromiumcodereview.appspot.com/10830027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148778 0039d316-1c4b-4281-b951-d872f2087c98
* Make audio volume icon HDCoshima@chromium.org2012-07-241-18/+17
| | | | | | | | | | | | Update the image for 2x which only had 4 icons Show mute icon when volume is 0 (+ some simplification) BUG=122992,137763 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10781021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148089 0039d316-1c4b-4281-b951-d872f2087c98
* Implement new volume mute button.jennyz@chromium.org2012-07-241-1/+26
| | | | | | | | | | | | | | | Add a new TrayBarButtonWithTitle class which can be used for both audio and brightness UI for toggle audio/brightness state. Clip the extra empty space around left/right bar images so that the bar image would not have too much empty space around itself. The new audio/brightness slider will be implemented in another cl. BUG=122832 TEST=The new mute segment should show up and work on uber tray bubble. TBR=oshima@chromium.org Review URL: https://chromiumcodereview.appspot.com/10808080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148002 0039d316-1c4b-4281-b951-d872f2087c98
* This CL moves the contents of ui_resources_standard.grd into ↵benrg@chromium.org2012-07-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | ui_resources.grd and theme_resources_standard.grd into theme_resources.grd. This also eliminates the following Grit outputs: ui_resources.pak ==> duplicated in each scaled-resource pak ui_resources_standard.h ==> merged into ui_resources.h ui_resources_standard_map.h ==> renamed to ui_resources_map.h ui_resources_standard_map.cc ==> renamed to ui_resources_map.cc theme_resources.rc ==> merged into theme_resources_standard.rc theme_resources.pak ==> duplicated in each scaled-resource pak theme_resources_standard.h ==> merged into theme_resources.h theme_resources_standard_map.h ==> merged into theme_resources_map.h theme_resources_standard_map.cc ==> merged into theme_resources_map.cc The image duplication is intentional; we may revisit this later. Currently the standard-size images are included twice in the Windows build, once as an rc and once as a pak. I'll fix this in a followup CL. TBR=ben@chromium.org,brettw@chromium.org,darin@chromium.org,stevenjb@chromium.org BUG=133570 TEST=Trybots, local build Review URL: https://chromiumcodereview.appspot.com/10756018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146224 0039d316-1c4b-4281-b951-d872f2087c98
* Remove #pragma once from ashajwong@chromium.org2012-07-111-1/+0
| | | | | | Review URL: https://chromiumcodereview.appspot.com/10693135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146075 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Add some 2x assets for the uber-tray.sadrul@chromium.org2012-06-011-1/+1
| | | | | | | | | | BUG=119832 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10451101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139956 0039d316-1c4b-4281-b951-d872f2087c98
* Modify the volume visuals:mukai@chromium.org2012-05-221-4/+12
| | | | | | | | | | | | | According to crbug.com/128644 - the mute icon should be in the tray if volume is 0% - volume slider point has to be 0.0 when muted BUG=128644 TEST=manually Review URL: https://chromiumcodereview.appspot.com/10408036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138282 0039d316-1c4b-4281-b951-d872f2087c98
* Change SetImage, SetBackground, and SetToggledImage to take in a gfx::ImageSkiapkotwicz@chromium.org2012-05-211-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The files were changed using the following sed script 1 :top 2 /SetImage/ { 3 s|ToSkBitmap|ToImageSkia|g 4 s|GetBitmapNamed|GetImageSkiaNamed|g 5 n 6 N 7 s|ToSkBitmap|ToImageSkia|g 8 s|GetBitmapNamed|GetImageSkiaNamed|g 9 b top 10 } 11 /SetBackground/ { 12 s|ToSkBitmap|ToImageSkia|g 13 s|GetBitmapNamed|GetImageSkiaNamed|g 14 n 15 N 16 s|ToSkBitmap|ToImageSkia|g 17 s|GetBitmapNamed|GetImageSkiaNamed|g 18 b top 19 } 20 /SetToggledImage/ { 21 s|ToSkBitmap|ToImageSkia|g 22 s|GetBitmapNamed|GetImageSkiaNamed|g 23 n 24 N 25 s|ToSkBitmap|ToImageSkia|g 26 s|GetBitmapNamed|GetImageSkiaNamed|g 27 b top 28 } The following files were modified by hand afterwards: 1 ash/launcher/launcher_button.cc 2 ash/system/audio/tray_volume.cc 3 ash/system/drive/tray_drive.cc 4 ash/system/tray/system_tray_delegate.h 5 ash/system/tray/tray_item_more.cc 6 ash/system/tray/tray_item_more.h 7 chrome/browser/chromeos/login/take_photo_view.cc 8 chrome/browser/chromeos/login/take_photo_view.h 9 chrome/browser/chromeos/options/network_config_view.cc 10 chrome/browser/chromeos/options/network_config_view.h 11 chrome/browser/ui/panels/panel_browser_frame_view.cc 12 chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc 13 chrome/browser/ui/views/autocomplete/autocomplete_result_view.h 14 chrome/browser/ui/views/avatar_menu_bubble_view.cc 15 chrome/browser/ui/views/chrome_to_mobile_bubble_view.cc 16 chrome/browser/ui/views/confirm_bubble_view.cc 17 chrome/browser/ui/views/download/download_shelf_view.cc 18 chrome/browser/ui/views/download/download_started_animation_views.cc 19 chrome/browser/ui/views/dropdown_bar_view.cc 20 chrome/browser/ui/views/dropdown_bar_view.h 21 chrome/browser/ui/views/find_bar_view.cc 22 chrome/browser/ui/views/frame/opaque_browser_frame_view.cc 23 chrome/browser/ui/views/hung_renderer_view.cc 24 chrome/browser/ui/views/location_bar/page_action_image_view.cc 25 chrome/browser/ui/views/tabs/tab_strip.cc 26 chrome/browser/ui/views/tabs/tab_strip.h 27 ui/views/controls/button/image_button.h 28 ui/views/controls/button/image_button_unittest.cc 29 ui/views/controls/scrollbar/bitmap_scroll_bar.cc 30 ui/views/controls/scrollbar/bitmap_scroll_bar.h Whitespace changes were made in the following files manually 1 ash/launcher/launcher_view.cc 2 chrome/browser/chromeos/login/simple_web_view_dialog.cc 3 chrome/browser/ui/views/location_bar/chrome_to_mobile_view.cc 4 chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc 5 chrome/browser/ui/views/toolbar_view.cc Bug=124566 Test=Compiles, try bots pass Review URL: https://chromiumcodereview.appspot.com/10382144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138072 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 136964 - Change SetImage, SetBackground, and SetToggledImage to take ↵vrk@google.com2012-05-141-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | in a gfx::ImageSkia The files were changed using the following sed script 1 :top 2 /SetImage/ { 3 s|ToSkBitmap|ToImageSkia|g 4 s|GetBitmapNamed|GetImageSkiaNamed|g 5 n 6 N 7 s|ToSkBitmap|ToImageSkia|g 8 s|GetBitmapNamed|GetImageSkiaNamed|g 9 b top 10 } 11 /SetBackground/ { 12 s|ToSkBitmap|ToImageSkia|g 13 s|GetBitmapNamed|GetImageSkiaNamed|g 14 n 15 N 16 s|ToSkBitmap|ToImageSkia|g 17 s|GetBitmapNamed|GetImageSkiaNamed|g 18 b top 19 } 20 /SetToggledImage/ { 21 s|ToSkBitmap|ToImageSkia|g 22 s|GetBitmapNamed|GetImageSkiaNamed|g 23 n 24 N 25 s|ToSkBitmap|ToImageSkia|g 26 s|GetBitmapNamed|GetImageSkiaNamed|g 27 b top 28 } The following files were modified by hand afterwards: 1 ash/launcher/launcher_button.cc 2 ash/system/audio/tray_volume.cc 3 ash/system/drive/tray_drive.cc 4 ash/system/tray/system_tray_delegate.h 5 ash/system/tray/tray_item_more.cc 6 ash/system/tray/tray_item_more.h 7 chrome/browser/chromeos/login/take_photo_view.cc 8 chrome/browser/chromeos/login/take_photo_view.h 9 chrome/browser/chromeos/options/network_config_view.cc 10 chrome/browser/chromeos/options/network_config_view.h 11 chrome/browser/ui/panels/panel_browser_frame_view.cc 12 chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc 13 chrome/browser/ui/views/autocomplete/autocomplete_result_view.h 14 chrome/browser/ui/views/avatar_menu_bubble_view.cc 15 chrome/browser/ui/views/chrome_to_mobile_bubble_view.cc 16 chrome/browser/ui/views/confirm_bubble_view.cc 17 chrome/browser/ui/views/download/download_shelf_view.cc 18 chrome/browser/ui/views/download/download_started_animation_views.cc 19 chrome/browser/ui/views/dropdown_bar_view.cc 20 chrome/browser/ui/views/dropdown_bar_view.h 21 chrome/browser/ui/views/find_bar_view.cc 22 chrome/browser/ui/views/frame/opaque_browser_frame_view.cc 23 chrome/browser/ui/views/hung_renderer_view.cc 24 chrome/browser/ui/views/location_bar/page_action_image_view.cc 25 chrome/browser/ui/views/tabs/tab_strip.cc 26 chrome/browser/ui/views/tabs/tab_strip.h 27 ui/views/controls/button/image_button.h 28 ui/views/controls/button/image_button_unittest.cc 29 ui/views/controls/scrollbar/bitmap_scroll_bar.cc 30 ui/views/controls/scrollbar/bitmap_scroll_bar.h Whitespace changes were made in the following files manually 1 ash/launcher/launcher_view.cc 2 chrome/browser/chromeos/login/simple_web_view_dialog.cc 3 chrome/browser/ui/views/location_bar/chrome_to_mobile_view.cc 4 chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc 5 chrome/browser/ui/views/toolbar_view.cc Bug=124566 Test=Compiles, try bots pass Review URL: https://chromiumcodereview.appspot.com/10382144 TBR=pkotwicz@chromium.org Review URL: https://chromiumcodereview.appspot.com/10388129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137005 0039d316-1c4b-4281-b951-d872f2087c98
* Change SetImage, SetBackground, and SetToggledImage to take in a gfx::ImageSkiapkotwicz@chromium.org2012-05-141-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The files were changed using the following sed script 1 :top 2 /SetImage/ { 3 s|ToSkBitmap|ToImageSkia|g 4 s|GetBitmapNamed|GetImageSkiaNamed|g 5 n 6 N 7 s|ToSkBitmap|ToImageSkia|g 8 s|GetBitmapNamed|GetImageSkiaNamed|g 9 b top 10 } 11 /SetBackground/ { 12 s|ToSkBitmap|ToImageSkia|g 13 s|GetBitmapNamed|GetImageSkiaNamed|g 14 n 15 N 16 s|ToSkBitmap|ToImageSkia|g 17 s|GetBitmapNamed|GetImageSkiaNamed|g 18 b top 19 } 20 /SetToggledImage/ { 21 s|ToSkBitmap|ToImageSkia|g 22 s|GetBitmapNamed|GetImageSkiaNamed|g 23 n 24 N 25 s|ToSkBitmap|ToImageSkia|g 26 s|GetBitmapNamed|GetImageSkiaNamed|g 27 b top 28 } The following files were modified by hand afterwards: 1 ash/launcher/launcher_button.cc 2 ash/system/audio/tray_volume.cc 3 ash/system/drive/tray_drive.cc 4 ash/system/tray/system_tray_delegate.h 5 ash/system/tray/tray_item_more.cc 6 ash/system/tray/tray_item_more.h 7 chrome/browser/chromeos/login/take_photo_view.cc 8 chrome/browser/chromeos/login/take_photo_view.h 9 chrome/browser/chromeos/options/network_config_view.cc 10 chrome/browser/chromeos/options/network_config_view.h 11 chrome/browser/ui/panels/panel_browser_frame_view.cc 12 chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc 13 chrome/browser/ui/views/autocomplete/autocomplete_result_view.h 14 chrome/browser/ui/views/avatar_menu_bubble_view.cc 15 chrome/browser/ui/views/chrome_to_mobile_bubble_view.cc 16 chrome/browser/ui/views/confirm_bubble_view.cc 17 chrome/browser/ui/views/download/download_shelf_view.cc 18 chrome/browser/ui/views/download/download_started_animation_views.cc 19 chrome/browser/ui/views/dropdown_bar_view.cc 20 chrome/browser/ui/views/dropdown_bar_view.h 21 chrome/browser/ui/views/find_bar_view.cc 22 chrome/browser/ui/views/frame/opaque_browser_frame_view.cc 23 chrome/browser/ui/views/hung_renderer_view.cc 24 chrome/browser/ui/views/location_bar/page_action_image_view.cc 25 chrome/browser/ui/views/tabs/tab_strip.cc 26 chrome/browser/ui/views/tabs/tab_strip.h 27 ui/views/controls/button/image_button.h 28 ui/views/controls/button/image_button_unittest.cc 29 ui/views/controls/scrollbar/bitmap_scroll_bar.cc 30 ui/views/controls/scrollbar/bitmap_scroll_bar.h Whitespace changes were made in the following files manually 1 ash/launcher/launcher_view.cc 2 chrome/browser/chromeos/login/simple_web_view_dialog.cc 3 chrome/browser/ui/views/location_bar/chrome_to_mobile_view.cc 4 chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc 5 chrome/browser/ui/views/toolbar_view.cc Bug=124566 Test=Compiles, try bots pass Review URL: https://chromiumcodereview.appspot.com/10382144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136964 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent the volume slider from sending accessibility events when updated via ↵zork@chromium.org2012-05-021-0/+4
| | | | | | | | | | | | a system event. BUG=chromium-os:29012 TEST=Turn on accessibility. Change the volume via the keyboard, then change it again while the popup is visible. Ensure the only audible feedback is the system earcon. Review URL: http://codereview.chromium.org/10262030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134869 0039d316-1c4b-4281-b951-d872f2087c98
* Remove scoped_ptr for system tray viewsstevenjb@chromium.org2012-05-012-9/+9
| | | | | | | | | | | | Views are owned by their parent, so having an additional scoped_ptr to them in the associated item/model is confusing and misleading. BUG=124269 TEST=Test status area Review URL: http://codereview.chromium.org/10269017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134710 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Animate changes in the uber tray.sadrul@chromium.org2012-04-231-2/+2
| | | | | | | | | | | | | Specifically, animate when a view in the tray hides/shows itself. For now, the tray does not animate when the size of a view changes (e.g. date-view changes size because it's 10:00). BUG=117209 TEST=none Review URL: https://chromiumcodereview.appspot.com/9969068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133526 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Show better focus rects for the tray.sadrul@chromium.org2012-04-131-0/+2
| | | | | | | | | BUG=122933 TEST=none Review URL: https://chromiumcodereview.appspot.com/10086005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132261 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Update icons for disconnected wifi, and muted audio in the tray.sadrul@chromium.org2012-03-281-18/+7
| | | | | | | | | BUG=120207 TEST=none Review URL: https://chromiumcodereview.appspot.com/9873018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129432 0039d316-1c4b-4281-b951-d872f2087c98
* Display mute icon in uber tray when muted.flackr@chromium.org2012-03-262-10/+13
| | | | | | | | | BUG=119905 TEST=Mute the volume, observe mute icon. Unmute and icon goes away. Review URL: https://chromiumcodereview.appspot.com/9854003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128854 0039d316-1c4b-4281-b951-d872f2087c98
* ash: A couple of small changes..sadrul@chromium.org2012-03-251-2/+2
| | | | | | | | | | | | * Fix mute painting * Do not crash on search-key-mapping pref. BUG=119951 TEST=none Review URL: https://chromiumcodereview.appspot.com/9839100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128813 0039d316-1c4b-4281-b951-d872f2087c98
* Allow sliders to be adjusted with arrow keyszork@chromium.org2012-03-241-1/+0
| | | | | | | | | | R=sky@chromium.org BUG=118012 Review URL: http://codereview.chromium.org/9845005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128730 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Avoid crash when returning from network details popup.derat@chromium.org2012-03-242-3/+12
| | | | | | | | | | | | | | | | | | | | | | | | r128551 changed some Close() calls in SystemTray to CloseNow(), resulting in a segfault when switching from the network details popup back to the main system tray popup. This undoes that change and fixes some related code. The reason for the CloseNow() change was because I was otherwise seeing the volume control be missing from the default popup if I hit F10 first and then clicked the system tray. The reason for this is because TrayVolume just uses a single view, and TrayVolume::DestroyDetailedView() didn't check to make sure that the view that it was destroying wasn't actually being used for the default popup. We'd create a new view for the default popup, but then the detailed popup would get closed afterwards and kill it. BUG=119858 TEST=manual Review URL: https://chromiumcodereview.appspot.com/9849001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128632 0039d316-1c4b-4281-b951-d872f2087c98
* Add accessible names to the sliders in the uber tray.zork@chromium.org2012-03-231-0/+4
| | | | | | | | | | | | This depends on: http://codereview.chromium.org/9838030/ R=dmazzoni@chromium.org BUG=118012 Review URL: http://codereview.chromium.org/9808055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128584 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Improve uber tray bubble lifetimes.derat@chromium.org2012-03-231-1/+1
| | | | | | | | | | | | | | | This makes us extend the lifetime of an already-shown detailed view (e.g. volume or brightness) when the key that shows it is pressed again. It also fixes an issue where there was a delay after one view was hidden before another could be shown. BUG=119624,119745 TEST=manual Review URL: https://chromiumcodereview.appspot.com/9808072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128551 0039d316-1c4b-4281-b951-d872f2087c98
* Initial system tray accessibility fixesdmazzoni@chromium.org2012-03-231-0/+1
| | | | | | | | | | | | | | This makes most system tray items keyboard-focusable and gives many of them an accessible role and name. Some work still remains - please use this as a guide when finishing support for remaining items! BUG=119608 TEST=manual testing: open tray, tab through items, open with space/enter, close with esc Review URL: http://codereview.chromium.org/9838030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128511 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Fix various UI issues.sadrul@chromium.org2012-03-231-3/+11
| | | | | | | | | | | | | | * Show integer battery power. * Hide the user name, since we can't yet get the full name of the user. * Refresh profile pic/avatar immediately after it is changed. * New assets BUG=119623, 119596, 119573 TEST=none Review URL: https://chromiumcodereview.appspot.com/9839011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128490 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Make sure all the popups from the tray have the same width.sadrul@chromium.org2012-03-171-2/+7
| | | | | | | | | | | | This should keep things sane and good if username, email, network name etc. are too long. This also fixes alignment/padding issues for the sliders, chevron icons etc. BUG=110130 TEST=none Review URL: https://chromiumcodereview.appspot.com/9703125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127312 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Clean up some uber-tray related code.sadrul@chromium.org2012-03-142-8/+8
| | | | | | | | | | | | Rename the various 'Controller's to 'Observer's, because that makes more sense, and move these observers from Shell into SystemTray. BUG=110130 TEST=none Review URL: https://chromiumcodereview.appspot.com/9702037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126758 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Update the volume icon when audio is muted/unmuted.sadrul@chromium.org2012-03-141-0/+4
| | | | | | | | | | R=ben@chromium.org BUG=118116 TEST=none Review URL: https://chromiumcodereview.appspot.com/9706007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126671 0039d316-1c4b-4281-b951-d872f2087c98
* ui/gfx: Get rid of CanvasSkia::GetSkCanvas() function.tfarina@chromium.org2012-03-131-1/+1
| | | | | | | | | | BUG=116572 R=asvitkine@chromium.org TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/9663077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126495 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Do not activate volume/bubble popups, and fix a crash.sadrul@chromium.org2012-03-091-1/+1
| | | | | | | | | | | When volume/brightness is changed from the keyboard (or by other means), the popup that shows up should not be activated/focused. Also, when a volume popup shows up to replace a brightness popup (or vice versa), it should not crash. BUG=110130 TEST=none Review URL: https://chromiumcodereview.appspot.com/9669002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125885 0039d316-1c4b-4281-b951-d872f2087c98
* ash uber tray: Add some missing virtual destructors.sadrul@chromium.org2012-03-061-0/+2
| | | | | | | | | BUG=110130 TEST=none Review URL: https://chromiumcodereview.appspot.com/9610012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125169 0039d316-1c4b-4281-b951-d872f2087c98
* ash uber tray: Auto-close volume/brightness popups after a short delay.sadrul@chromium.org2012-03-051-1/+2
| | | | | | | | | BUG=110130,110131 TEST=none Review URL: https://chromiumcodereview.appspot.com/9599001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125018 0039d316-1c4b-4281-b951-d872f2087c98
* ash uber tray: Allow customizing each item depending on whether the user is ↵sadrul@chromium.org2012-03-032-6/+6
| | | | | | | | | | | | | | | | logged in or not. If a user is not logged in (e.g. in the login screen, or during an incognito session), some of the items need to behave differently. So provide this information to each of the items so that such customization is possible. Also, make sure all the items get a chance to update themselves when user logs in. BUG=110130 TEST=tested on device, logged in as normal user, and incognito. Review URL: https://chromiumcodereview.appspot.com/9580024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124863 0039d316-1c4b-4281-b951-d872f2087c98
* ash uber tray: Update the volume icon for various levels of volumes.sadrul@chromium.org2012-03-022-40/+82
| | | | | | | | | | BUG=110130 TEST=none Review URL: http://codereview.chromium.org/9585004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124692 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Use imperative verbs for Audio related methods.tfarina@chromium.org2012-02-291-4/+4
| | | | | | | | R=sadrul@chromium.org,sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/9508002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124221 0039d316-1c4b-4281-b951-d872f2087c98
* ash uber tray: Show just the volume/brightness item when user presses ↵sadrul@chromium.org2012-02-291-2/+3
| | | | | | | | | | | | | appropriate keys. This CL implements SystemTrayItem::PopupDetailedView. This will be used for network details etc. too. BUG=110130,110131 TEST=none Review URL: https://chromiumcodereview.appspot.com/9539002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124213 0039d316-1c4b-4281-b951-d872f2087c98
* views: Tell SliderListener's how the slider value was changed.sadrul@chromium.org2012-02-291-1/+4
| | | | | | | | | BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9533013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124199 0039d316-1c4b-4281-b951-d872f2087c98
* ash uber tray: Make it possible for the system to send notifications to the ↵sadrul@chromium.org2012-02-293-5/+45
| | | | | | | | | | | | | | | tray. Volume/Brightness change notifications are sent from the system to the tray. This can be useful to update the tray items when something changes (either automatically, or by means other than the tray itself) BUG=110130,110131 TEST=none Review URL: https://chromiumcodereview.appspot.com/9522003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124091 0039d316-1c4b-4281-b951-d872f2087c98
* ash uber tray: Some adjustments after discussing with UX.sadrul@chromium.org2012-02-282-2/+15
| | | | | | | | | | | | | | | | * Add padding for the volume/brightness sliders. * Consolidate 'Settings' and 'Help' items into one. * Remove margin of the popup. * Move the trays in ash::internal namespace. * Hover effect on settings/help items. * Fix a crash when clicking on the status-view without closing the popup. BUG=110130 TEST=none Review URL: https://chromiumcodereview.appspot.com/9475041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124002 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 18:59:22 +0000