| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=119832
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10451101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to crbug.com/128644
- the mute icon should be in the tray if volume is 0%
- volume slider point has to be 0.0 when muted
BUG=128644
TEST=manually
Review URL: https://chromiumcodereview.appspot.com/10408036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The files were changed using the following sed script
1 :top
2 /SetImage/ {
3 s|ToSkBitmap|ToImageSkia|g
4 s|GetBitmapNamed|GetImageSkiaNamed|g
5 n
6 N
7 s|ToSkBitmap|ToImageSkia|g
8 s|GetBitmapNamed|GetImageSkiaNamed|g
9 b top
10 }
11 /SetBackground/ {
12 s|ToSkBitmap|ToImageSkia|g
13 s|GetBitmapNamed|GetImageSkiaNamed|g
14 n
15 N
16 s|ToSkBitmap|ToImageSkia|g
17 s|GetBitmapNamed|GetImageSkiaNamed|g
18 b top
19 }
20 /SetToggledImage/ {
21 s|ToSkBitmap|ToImageSkia|g
22 s|GetBitmapNamed|GetImageSkiaNamed|g
23 n
24 N
25 s|ToSkBitmap|ToImageSkia|g
26 s|GetBitmapNamed|GetImageSkiaNamed|g
27 b top
28 }
The following files were modified by hand afterwards:
1 ash/launcher/launcher_button.cc
2 ash/system/audio/tray_volume.cc
3 ash/system/drive/tray_drive.cc
4 ash/system/tray/system_tray_delegate.h
5 ash/system/tray/tray_item_more.cc
6 ash/system/tray/tray_item_more.h
7 chrome/browser/chromeos/login/take_photo_view.cc
8 chrome/browser/chromeos/login/take_photo_view.h
9 chrome/browser/chromeos/options/network_config_view.cc
10 chrome/browser/chromeos/options/network_config_view.h
11 chrome/browser/ui/panels/panel_browser_frame_view.cc
12 chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc
13 chrome/browser/ui/views/autocomplete/autocomplete_result_view.h
14 chrome/browser/ui/views/avatar_menu_bubble_view.cc
15 chrome/browser/ui/views/chrome_to_mobile_bubble_view.cc
16 chrome/browser/ui/views/confirm_bubble_view.cc
17 chrome/browser/ui/views/download/download_shelf_view.cc
18 chrome/browser/ui/views/download/download_started_animation_views.cc
19 chrome/browser/ui/views/dropdown_bar_view.cc
20 chrome/browser/ui/views/dropdown_bar_view.h
21 chrome/browser/ui/views/find_bar_view.cc
22 chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
23 chrome/browser/ui/views/hung_renderer_view.cc
24 chrome/browser/ui/views/location_bar/page_action_image_view.cc
25 chrome/browser/ui/views/tabs/tab_strip.cc
26 chrome/browser/ui/views/tabs/tab_strip.h
27 ui/views/controls/button/image_button.h
28 ui/views/controls/button/image_button_unittest.cc
29 ui/views/controls/scrollbar/bitmap_scroll_bar.cc
30 ui/views/controls/scrollbar/bitmap_scroll_bar.h
Whitespace changes were made in the following files manually
1 ash/launcher/launcher_view.cc
2 chrome/browser/chromeos/login/simple_web_view_dialog.cc
3 chrome/browser/ui/views/location_bar/chrome_to_mobile_view.cc
4 chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
5 chrome/browser/ui/views/toolbar_view.cc
Bug=124566
Test=Compiles, try bots pass
Review URL: https://chromiumcodereview.appspot.com/10382144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in a gfx::ImageSkia
The files were changed using the following sed script
1 :top
2 /SetImage/ {
3 s|ToSkBitmap|ToImageSkia|g
4 s|GetBitmapNamed|GetImageSkiaNamed|g
5 n
6 N
7 s|ToSkBitmap|ToImageSkia|g
8 s|GetBitmapNamed|GetImageSkiaNamed|g
9 b top
10 }
11 /SetBackground/ {
12 s|ToSkBitmap|ToImageSkia|g
13 s|GetBitmapNamed|GetImageSkiaNamed|g
14 n
15 N
16 s|ToSkBitmap|ToImageSkia|g
17 s|GetBitmapNamed|GetImageSkiaNamed|g
18 b top
19 }
20 /SetToggledImage/ {
21 s|ToSkBitmap|ToImageSkia|g
22 s|GetBitmapNamed|GetImageSkiaNamed|g
23 n
24 N
25 s|ToSkBitmap|ToImageSkia|g
26 s|GetBitmapNamed|GetImageSkiaNamed|g
27 b top
28 }
The following files were modified by hand afterwards:
1 ash/launcher/launcher_button.cc
2 ash/system/audio/tray_volume.cc
3 ash/system/drive/tray_drive.cc
4 ash/system/tray/system_tray_delegate.h
5 ash/system/tray/tray_item_more.cc
6 ash/system/tray/tray_item_more.h
7 chrome/browser/chromeos/login/take_photo_view.cc
8 chrome/browser/chromeos/login/take_photo_view.h
9 chrome/browser/chromeos/options/network_config_view.cc
10 chrome/browser/chromeos/options/network_config_view.h
11 chrome/browser/ui/panels/panel_browser_frame_view.cc
12 chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc
13 chrome/browser/ui/views/autocomplete/autocomplete_result_view.h
14 chrome/browser/ui/views/avatar_menu_bubble_view.cc
15 chrome/browser/ui/views/chrome_to_mobile_bubble_view.cc
16 chrome/browser/ui/views/confirm_bubble_view.cc
17 chrome/browser/ui/views/download/download_shelf_view.cc
18 chrome/browser/ui/views/download/download_started_animation_views.cc
19 chrome/browser/ui/views/dropdown_bar_view.cc
20 chrome/browser/ui/views/dropdown_bar_view.h
21 chrome/browser/ui/views/find_bar_view.cc
22 chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
23 chrome/browser/ui/views/hung_renderer_view.cc
24 chrome/browser/ui/views/location_bar/page_action_image_view.cc
25 chrome/browser/ui/views/tabs/tab_strip.cc
26 chrome/browser/ui/views/tabs/tab_strip.h
27 ui/views/controls/button/image_button.h
28 ui/views/controls/button/image_button_unittest.cc
29 ui/views/controls/scrollbar/bitmap_scroll_bar.cc
30 ui/views/controls/scrollbar/bitmap_scroll_bar.h
Whitespace changes were made in the following files manually
1 ash/launcher/launcher_view.cc
2 chrome/browser/chromeos/login/simple_web_view_dialog.cc
3 chrome/browser/ui/views/location_bar/chrome_to_mobile_view.cc
4 chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
5 chrome/browser/ui/views/toolbar_view.cc
Bug=124566
Test=Compiles, try bots pass
Review URL: https://chromiumcodereview.appspot.com/10382144
TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10388129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The files were changed using the following sed script
1 :top
2 /SetImage/ {
3 s|ToSkBitmap|ToImageSkia|g
4 s|GetBitmapNamed|GetImageSkiaNamed|g
5 n
6 N
7 s|ToSkBitmap|ToImageSkia|g
8 s|GetBitmapNamed|GetImageSkiaNamed|g
9 b top
10 }
11 /SetBackground/ {
12 s|ToSkBitmap|ToImageSkia|g
13 s|GetBitmapNamed|GetImageSkiaNamed|g
14 n
15 N
16 s|ToSkBitmap|ToImageSkia|g
17 s|GetBitmapNamed|GetImageSkiaNamed|g
18 b top
19 }
20 /SetToggledImage/ {
21 s|ToSkBitmap|ToImageSkia|g
22 s|GetBitmapNamed|GetImageSkiaNamed|g
23 n
24 N
25 s|ToSkBitmap|ToImageSkia|g
26 s|GetBitmapNamed|GetImageSkiaNamed|g
27 b top
28 }
The following files were modified by hand afterwards:
1 ash/launcher/launcher_button.cc
2 ash/system/audio/tray_volume.cc
3 ash/system/drive/tray_drive.cc
4 ash/system/tray/system_tray_delegate.h
5 ash/system/tray/tray_item_more.cc
6 ash/system/tray/tray_item_more.h
7 chrome/browser/chromeos/login/take_photo_view.cc
8 chrome/browser/chromeos/login/take_photo_view.h
9 chrome/browser/chromeos/options/network_config_view.cc
10 chrome/browser/chromeos/options/network_config_view.h
11 chrome/browser/ui/panels/panel_browser_frame_view.cc
12 chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc
13 chrome/browser/ui/views/autocomplete/autocomplete_result_view.h
14 chrome/browser/ui/views/avatar_menu_bubble_view.cc
15 chrome/browser/ui/views/chrome_to_mobile_bubble_view.cc
16 chrome/browser/ui/views/confirm_bubble_view.cc
17 chrome/browser/ui/views/download/download_shelf_view.cc
18 chrome/browser/ui/views/download/download_started_animation_views.cc
19 chrome/browser/ui/views/dropdown_bar_view.cc
20 chrome/browser/ui/views/dropdown_bar_view.h
21 chrome/browser/ui/views/find_bar_view.cc
22 chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
23 chrome/browser/ui/views/hung_renderer_view.cc
24 chrome/browser/ui/views/location_bar/page_action_image_view.cc
25 chrome/browser/ui/views/tabs/tab_strip.cc
26 chrome/browser/ui/views/tabs/tab_strip.h
27 ui/views/controls/button/image_button.h
28 ui/views/controls/button/image_button_unittest.cc
29 ui/views/controls/scrollbar/bitmap_scroll_bar.cc
30 ui/views/controls/scrollbar/bitmap_scroll_bar.h
Whitespace changes were made in the following files manually
1 ash/launcher/launcher_view.cc
2 chrome/browser/chromeos/login/simple_web_view_dialog.cc
3 chrome/browser/ui/views/location_bar/chrome_to_mobile_view.cc
4 chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
5 chrome/browser/ui/views/toolbar_view.cc
Bug=124566
Test=Compiles, try bots pass
Review URL: https://chromiumcodereview.appspot.com/10382144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
a system event.
BUG=chromium-os:29012
TEST=Turn on accessibility. Change the volume via the keyboard, then change it again while the popup is visible. Ensure the only audible feedback is the system earcon.
Review URL: http://codereview.chromium.org/10262030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Views are owned by their parent, so having an additional scoped_ptr to them in the associated item/model is confusing and misleading.
BUG=124269
TEST=Test status area
Review URL: http://codereview.chromium.org/10269017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifically, animate when a view in the tray hides/shows itself. For now, the
tray does not animate when the size of a view changes (e.g. date-view changes
size because it's 10:00).
BUG=117209
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9969068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=122933
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10086005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=120207
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9873018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=119905
TEST=Mute the volume, observe mute icon. Unmute and icon goes away.
Review URL: https://chromiumcodereview.appspot.com/9854003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fix mute painting
* Do not crash on search-key-mapping pref.
BUG=119951
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9839100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
BUG=118012
Review URL: http://codereview.chromium.org/9845005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r128551 changed some Close() calls in SystemTray to
CloseNow(), resulting in a segfault when switching from the
network details popup back to the main system tray popup.
This undoes that change and fixes some related code.
The reason for the CloseNow() change was because I was
otherwise seeing the volume control be missing from the
default popup if I hit F10 first and then clicked the system
tray. The reason for this is because TrayVolume just uses a
single view, and TrayVolume::DestroyDetailedView() didn't
check to make sure that the view that it was destroying
wasn't actually being used for the default popup. We'd
create a new view for the default popup, but then the
detailed popup would get closed afterwards and kill it.
BUG=119858
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/9849001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This depends on: http://codereview.chromium.org/9838030/
R=dmazzoni@chromium.org
BUG=118012
Review URL: http://codereview.chromium.org/9808055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes us extend the lifetime of an already-shown
detailed view (e.g. volume or brightness) when the key that
shows it is pressed again. It also fixes an issue where
there was a delay after one view was hidden before another
could be shown.
BUG=119624,119745
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/9808072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes most system tray items keyboard-focusable and gives many of them
an accessible role and name. Some work still remains - please use this as
a guide when finishing support for remaining items!
BUG=119608
TEST=manual testing: open tray, tab through items, open with space/enter, close with esc
Review URL: http://codereview.chromium.org/9838030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Show integer battery power.
* Hide the user name, since we can't yet get the full name of the user.
* Refresh profile pic/avatar immediately after it is changed.
* New assets
BUG=119623, 119596, 119573
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9839011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should keep things sane and good if username, email, network name etc. are too long.
This also fixes alignment/padding issues for the sliders, chevron icons etc.
BUG=110130
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9703125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename the various 'Controller's to 'Observer's, because that makes more sense,
and move these observers from Shell into SystemTray.
BUG=110130
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9702037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=ben@chromium.org
BUG=118116
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9706007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=116572
R=asvitkine@chromium.org
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9663077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When volume/brightness is changed from the keyboard (or by other means), the popup that shows up should not be activated/focused. Also, when a volume popup shows up to replace a brightness popup (or vice versa), it should not crash.
BUG=110130
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9669002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=110130
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9610012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=110130,110131
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9599001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
logged in or not.
If a user is not logged in (e.g. in the login screen, or during an incognito
session), some of the items need to behave differently. So provide this
information to each of the items so that such customization is possible. Also,
make sure all the items get a chance to update themselves when user logs in.
BUG=110130
TEST=tested on device, logged in as normal user, and incognito.
Review URL: https://chromiumcodereview.appspot.com/9580024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=110130
TEST=none
Review URL: http://codereview.chromium.org/9585004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=sadrul@chromium.org,sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9508002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
appropriate keys.
This CL implements SystemTrayItem::PopupDetailedView. This will be used for network details etc. too.
BUG=110130,110131
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9539002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9533013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tray.
Volume/Brightness change notifications are sent from the system to the tray.
This can be useful to update the tray items when something changes (either
automatically, or by means other than the tray itself)
BUG=110130,110131
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9522003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add padding for the volume/brightness sliders.
* Consolidate 'Settings' and 'Help' items into one.
* Remove margin of the popup.
* Move the trays in ash::internal namespace.
* Hover effect on settings/help items.
* Fix a crash when clicking on the status-view without closing the popup.
BUG=110130
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9475041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The brightness controller shows up and you can drag the slider, but it doesn't
actually work, because of apparent lack of appropriate libcros API. But that can
be fixed separately.
BUG=110130
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9481011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
As a first step, there are items to open settings, help pages, and an item to
allow [un]muting volume.
The resources have not been uploaded yet. That will be done in a separate CL to
allow this one to go through trybots etc.
This new uber-tray can be turned on at runtime using --ash-uber-tray flag.
BUG=110130
TEST=none yet. will be added when a little more fleshed out.
Review URL: https://chromiumcodereview.appspot.com/9463039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123799 0039d316-1c4b-4281-b951-d872f2087c98
|