| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
See https://codereview.chromium.org/467193003/ for how.
BUG=none
Review URL: https://codereview.chromium.org/470663002
Cr-Commit-Position: refs/heads/master@{#289472}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
lock screen)
BUG=385623
Review URL: https://codereview.chromium.org/357323002
Cr-Commit-Position: refs/heads/master@{#288245}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes spoken feedback treat the items for the enabled IMEs and, if
applicable, menu items provided by the active IME, as check box items.
R=sadrul@chromium.org
BUG=368399
Review URL: https://codereview.chromium.org/255273005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Added new mode in TrayUser for the case when new account management is
enabled (--new-profile-management flag). In fact TrayUser is now supporting
four different modes, depending of states of |multi-profiles| flag and
|new-profile-management| flag.
* Massive refactoring were made in tray_user.cc to isolate UserCardView
creation in separate class and make code more clear.
* UI for the cases when new account management is disabled remained without
changes.
Known issues:
* There are no tests for new UI. Hopefully old UI is covered by tests already.
* New UI is not accessible yet.
* Stub implementation of UserAccountsDelegate is used for backend.
BUG=344844
TEST=manually
Review URL: https://codereview.chromium.org/210903003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Plus obvious style nit fixes.
BUG=None
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/224113005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=337910
R=nona@chromium.org, komatsu@chromium.org, oshima@chromium.org, stevenjb@chromium.org
TEST=compile succeeds
Review URL: https://codereview.chromium.org/167793002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=343650
TEST=manually
Review URL: https://codereview.chromium.org/159903007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Although TrayIME removes the notification, the callback notification
delegate may survive due to complicated ref-counted-ness of
NotificationDelegate.
Anyways WeakPtr would be better here rather than Unretained.
BUG=336650
R=stevenjb@chromium.org, dewittj@chromium.org
TEST=None
Review URL: https://codereview.chromium.org/138833004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This makes the ownership situation much clearer. It also renames the function to SetBorder() (since it is not a simple accessor and can free previous instances of Border), and creates a Border::NullBorder() method (since "SetBorder(scoped_ptr<>())" is not clear).
BUG=none
R=sky@chromium.org
Review URL: https://codereview.chromium.org/145033006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
to use the base:: namespace.
BUG=330556
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/102443009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
track usage of the menu's.
BUG=297046
Review URL: https://codereview.chromium.org/73583003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now the integer id is removed and merged into the string id.
BUG=326296
R=dewittj@chromium.org, stevenjb@chromium.org
TEST=unit_tests
Review URL: https://codereview.chromium.org/105703003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
keyboard only
BUG=314891
TEST=
see crbug.com/314891
Review URL: https://codereview.chromium.org/92663002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238818 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=289546
R=jennyz@chromium.org
Review URL: https://codereview.chromium.org/24228005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL replaces the existing blocking code by the new notification
blocker implementations. The new implementation detects the current
status more precisely, and each platform can implement different
blocking behaviors.
BUG=256404, 260060
TEST=covered by new tests
R=dewittj@chromium.org, stevenjb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23694021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It will remove unnecessary methods. Also, each ash notifications
has its own notifier id as SYSTEM_COMPONENT. Then we can distinguish
those notification types, which means this will enable to allow
some urgent system notifications (like power) in the lock screen.
BUG=250937
R=dewittj@chromium.org, stevenjb@chromium.org
TEST=no breaks on existing tests
Review URL: https://chromiumcodereview.appspot.com/23340002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ash_resources contains images for both of those notifications but
somehow not specified at all.
BUG=262393
R=stevenjb@chromium.org
TEST=manually
Review URL: https://chromiumcodereview.appspot.com/22901015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL also introduces ClosureNotificationDelegate which provides
some reusable simple delegate (mostly for ash).
BUG=259134
R=stevenjb@chromium.org, nona@chromium.org, dewittj@chromium.org
TEST=manually
Review URL: https://chromiumcodereview.appspot.com/21058006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ash/, base/.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/15735027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL also removes some event triggering. They update the default
view when visible, but this is not necessary because the tray bubble
itself will be closed when display configuration has changed.
Also this CL cleans up messages of the tray item contents.
BUG=187516, 171469
R=oshima@chromium.org, stevenjb@chromium.org
TEST=manually
Review URL: https://chromiumcodereview.appspot.com/16046007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=231441
Review URL: https://chromiumcodereview.appspot.com/15229002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=174228
R=jamescook@chromium.org
TBR=xiyuan@chromium.org # for trivial change in chrome/browser/chromeos/system/
Review URL: https://chromiumcodereview.appspot.com/14949004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor the classes related with displaying the shelf (background behind the launcher/status area widget) to be a separate class. Removing background delegates from the launcher and status area widget (represented on tray views).
TBR=ben@chromium.org
BUG=163002
Review URL: https://chromiumcodereview.appspot.com/12313118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=174228
R=jamescook@chromium.org,jennyz@chromium.org
TBR=xiyuan@chromium.org # for trivial change in c/b/chromeos/system/
Review URL: https://chromiumcodereview.appspot.com/12381062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=174228
R=jennyz@chromium.org,jamescook@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12218138
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also made made small changes in HoverHighlightView.
TBR=nkostylev
BUG=chromium-os:35755
Review URL: https://chromiumcodereview.appspot.com/11858008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11476034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=stevenjb@chromium.org
BUG=145978
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11515004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL provides all SystemTrayItem objects with a pointer to the parent
SystemTray and all Tray*View objects with a pointer to the parent
SystemTrayItem. This allows the objects to walk up the chain and access
the correct system tray once multiple system trays are introduced.
UpdateNagger::~UpdateNagger() in tray_update.cc continues to go through
shell::GetInstance() as the refactoring needed to support multiple system
trays here is more complex and out of my expertise.
BUG=152928
Review URL: https://chromiumcodereview.appspot.com/11415014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also remove unnecessary center alignment specifications in:
ash/wm/maximize_bubble_controller.cc
chrome/browser/ui/views/find_bar_view.cc
chrome/browser/ui/views/panels/panel_frame_view.cc
chrome/browser/ui/views/speech_recognition_bubble_views.cc
ui/message_center/message_center_bubble.cc
BUG=90426,155526
TEST=No behavioral changes.
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11377005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=156177
Review URL: https://codereview.chromium.org/11365037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Set multi-line explicitly and left align flag into ime tray, otherwise not all text is displayed.
BUG=157535
TEST=Manually done on lumpy
Review URL: https://chromiumcodereview.appspot.com/11266034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
updated all clients to use one on RootWindowController and/or
Launcher::ForPrimaryDisplay/ForWindow.
BUG=145978
Review URL: https://chromiumcodereview.appspot.com/11017079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added a medium length name to IMEInfo. It is used for the bubble with "Your input method has changed to ...". In most cases the medium length text is equal to the short text except where this issue is concerned.
BUG=137629
TEST=Enable English and Japanese keyboards; restart; Control + Space: observe popup bubble "Your input method has changed to..."
Review URL: https://chromiumcodereview.appspot.com/10960060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
add ash_resources.grd and necessary changes to use images in ash/resources
BUG=146034
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156610
Review URL: https://codereview.chromium.org/10905242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ash/resources"
TBR=oshima@chromium.org
BUG=146034
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=146034
TEST=none
Review URL: https://codereview.chromium.org/10905242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=120576
Review URL: https://chromiumcodereview.appspot.com/10830114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For bottom aligned launcher:
7 pixel padding around left/right of text tray item.
1 pixel padding around all sides of image tray item.
1 pixel around all sides of the uber tray (SystemTrayContainer).
For vertical aligned launcher:
1 pixel padding around all sides of the image tray item.
4 pixel padding above and below the text tray item, and center the text horizontally.
1 pixel around all sides of the uber tray (SystemTrayContainer).
BUG=132450
TEST=The spacing between urber tray items should be consistent.
Review URL: https://chromiumcodereview.appspot.com/10809008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ui_resources.grd and theme_resources_standard.grd into theme_resources.grd. This also eliminates the following Grit outputs:
ui_resources.pak ==> duplicated in each scaled-resource pak
ui_resources_standard.h ==> merged into ui_resources.h
ui_resources_standard_map.h ==> renamed to ui_resources_map.h
ui_resources_standard_map.cc ==> renamed to ui_resources_map.cc
theme_resources.rc ==> merged into theme_resources_standard.rc
theme_resources.pak ==> duplicated in each scaled-resource pak
theme_resources_standard.h ==> merged into theme_resources.h
theme_resources_standard_map.h ==> merged into theme_resources_map.h
theme_resources_standard_map.cc ==> merged into theme_resources_map.cc
The image duplication is intentional; we may revisit this later.
Currently the standard-size images are included twice in the Windows build, once as an rc and once as a pak. I'll fix this in a followup CL.
TBR=ben@chromium.org,brettw@chromium.org,darin@chromium.org,stevenjb@chromium.org
BUG=133570
TEST=Trybots, local build
Review URL: https://chromiumcodereview.appspot.com/10756018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10693135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also move common code to TrayNotificationView and separate into its own file.
BUG=133280
TEST=System notifications should close and spawn detailed views (if appropriate) on click or touch. Web notifications should perform the associated action (if any) on click or touch, e.g. gmail notifications should open gmail. See issue also.
For ash.gyp:
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10694043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=132029
Review URL: https://chromiumcodereview.appspot.com/10626014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=133894
Review URL: https://chromiumcodereview.appspot.com/10584010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=130966
TEST=Change the IME via alt+shift multiple times, and turn caps lock on and off multiple times. Make sure the messages only appear once.
Review URL: https://chromiumcodereview.appspot.com/10540157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
in use
TBR=jhawkins@chromium.org
BUG=None
TEST=Install an IME extension. Enable it. Check that the Language Bar indicates that it is 3rd party
Review URL: https://chromiumcodereview.appspot.com/10544070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=119832
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10451101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=129324
TEST=Change the IME via alt + shift. Make sure a notification appears
Review URL: https://chromiumcodereview.appspot.com/10407117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Separate status area widget from system tray
* Support adding multiple trays to status area widget
* Move the background animation into a common base class
BUG=124914
TEST=Status area should look and behave the same as before.
TBR=ben for ash/ OWNER
Review URL: https://chromiumcodereview.appspot.com/10447040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=129117
TEST=manually on lumpy
Review URL: https://chromiumcodereview.appspot.com/10414058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138520 0039d316-1c4b-4281-b951-d872f2087c98
|