summaryrefslogtreecommitdiffstats
path: root/ash/system/web_notification
Commit message (Collapse)AuthorAgeFilesLines
* Fixed BubbleBorder sizing problems & added unit tests.bruthig2014-08-271-1/+1
| | | | | | | | | | BUG=395622 TEST=automated Review URL: https://codereview.chromium.org/454173002 Cr-Commit-Position: refs/heads/master@{#292145}
* Use qualified path for grit/ui_strings.htfarina2014-08-251-1/+1
| | | | | | | | | | | | | | | | | | This was generated by the following command line: $ for f in $(g grep -l '"grit/ui_strings.h"' -- '*.cc' '*.mm' '*.h'); do sed -i -e 's/"grit\/ui_strings.h"/"ui\/strings\/grit\/ui_strings.h"/' $f; done $ python ./tools/git/for-all-touched-files.py -c "./tools/sort-headers.py -f [[FILENAME]]" BUG=401588 TEST=None R=thestig@chromium.org,thakis@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/499163002 Cr-Commit-Position: refs/heads/master@{#291700}
* Tray elements behave appropriately on the multiple signin screen (more like ↵rsorokin@chromium.org2014-08-081-2/+10
| | | | | | | | | | | lock screen) BUG=385623 Review URL: https://codereview.chromium.org/357323002 Cr-Commit-Position: refs/heads/master@{#288245} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288245 0039d316-1c4b-4281-b951-d872f2087c98
* Move the logic of getting root window to StartObserving()mukai@chromium.org2014-08-061-3/+3
| | | | | | | | | | | | | | | | | | Crashes are reported around getting root window in UpdateShelf(), however the new AshPopupAlignmentDelegate is mostly same as old WorkAreaObserver. One difference is the location of getting root window. This could fix the problem. If this doesn't fix the problem, then the problem happens outside of this file. BUG=400492 R=stevenjb@chromium.org TEST=None Review URL: https://codereview.chromium.org/441013003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287859 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanups for aura/test/event_generator.h (resolve TODOs)tapted@chromium.org2014-07-281-2/+2
| | | | | | | | | | | | | | | | | | Some purely mechanical changes left over from r283694, now that aura::test::EventGenerator has moved to ui::test in src/ui/events. Moves aura/test/event_generator.* to event_generator_delegate_aura.* Removes `using ui::test::EventGenerator;` declaration and redirects includes that don't extend the delegate to include the ui/test event_generator.h directly BUG=378134 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285209 Review URL: https://codereview.chromium.org/406413004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285857 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 285209 "Cleanups for aura/test/event_generator.h (resolve..."markusheintz@chromium.org2014-07-241-2/+2
| | | | | | | | | | | | | | | | | | | | | | > Cleanups for aura/test/event_generator.h (resolve TODOs) > > Some purely mechanical changes left over from r283694, now that > aura::test::EventGenerator has moved to ui::test in src/ui/events. > > Moves aura/test/event_generator.* to event_generator_delegate_aura.* > Removes `using ui::test::EventGenerator;` declaration and redirects > includes that don't extend the delegate to include the ui/test > event_generator.h directly > > BUG=378134 > > Review URL: https://codereview.chromium.org/406413004 TBR=tapted@chromium.org Review URL: https://codereview.chromium.org/413983006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285222 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanups for aura/test/event_generator.h (resolve TODOs)tapted@chromium.org2014-07-241-2/+2
| | | | | | | | | | | | | | | | Some purely mechanical changes left over from r283694, now that aura::test::EventGenerator has moved to ui::test in src/ui/events. Moves aura/test/event_generator.* to event_generator_delegate_aura.* Removes `using ui::test::EventGenerator;` declaration and redirects includes that don't extend the delegate to include the ui/test event_generator.h directly BUG=378134 Review URL: https://codereview.chromium.org/406413004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285209 0039d316-1c4b-4281-b951-d872f2087c98
* Separate the logic of popup alignment and workarea handling as delegate.mukai@chromium.org2014-07-106-190/+520
| | | | | | | | | | | | | | | | | | | | | | | MessagePopupCollection contains plenty size of conditions and ifdefs to work properly with each type of the desktop we have, and some logic makes side effects on another desktop. This design is unhealty and adding more conditions sounds incorrect. Considering this, it would be better to extract platform dependent parts as a delegate class (PopupAlignmentDelegate) and allow subclasses to provide platform-specific features. This design is also beneficial for win-ash, because we had OS_CHROMEOS layout data and logic which actually means Ash. BUG=389656 R=stevenjb@chromium.org, dimich@chromium.org TBR=jamescook@chromium.org, harrym@chromium.org TEST=message_center_unittests, ash_unittests, some manual checks Review URL: https://codereview.chromium.org/369573004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282269 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 280721 "Specifies the popup alignment from Ash."mukai@chromium.org2014-07-011-10/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Specifies the popup alignment from Ash. > > MessagePopupCollection estimates the popup alignment by itself, > checking the work area and display bounds. However, this approach > may misunderstand the reserved area of docked windows as the > taskbar, which causes weird effect as is described in the bug. > > Actually, this estimation is not necessary at all in Ash, because > Ash knows the exact taskbar alignment. This CL allows Ash to > specify the popup alignment, and ignores the estimation code. > > BUG=389656 > R=stevenjb@chromium.org, dimich@chromium.org > TEST=manually > > Review URL: https://codereview.chromium.org/353243002 Revert reason: - this causes a memory leak (referring uninitialized value) - also this doesn't work well with temporary alignment change (in ChromeOS ash, the shelf moves bottom in the lock screen and some important notifications may appear in that situation. However this does not cause SetShelfAlignment() event) TBR=mukai@chromium.org BUG=390500 Review URL: https://codereview.chromium.org/361003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280844 0039d316-1c4b-4281-b951-d872f2087c98
* Specifies the popup alignment from Ash.mukai@chromium.org2014-07-011-0/+10
| | | | | | | | | | | | | | | | | | | MessagePopupCollection estimates the popup alignment by itself, checking the work area and display bounds. However, this approach may misunderstand the reserved area of docked windows as the taskbar, which causes weird effect as is described in the bug. Actually, this estimation is not necessary at all in Ash, because Ash knows the exact taskbar alignment. This CL allows Ash to specify the popup alignment, and ignores the estimation code. BUG=389656 R=stevenjb@chromium.org, dimich@chromium.org TEST=manually Review URL: https://codereview.chromium.org/353243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280721 0039d316-1c4b-4281-b951-d872f2087c98
* Stop Status Area Creation Animationsjonross@chromium.org2014-06-161-1/+0
| | | | | | | | | | | | TrayBackgroundViews animate their visual state transitions. However upon creation some set their visibility to false. This is causing them to first appear on screen, only to animate to hidden. It is not desireable, especially for startup. Switch the children to set their initial visibility via View::SetVisible instead of TrayBackgroundView::SetVisible in order to not animate. Those items that should be visible based on the login status are already receiving login state notifications and will become visible accordingly. BUG=383005 Review URL: https://codereview.chromium.org/329993003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277506 0039d316-1c4b-4281-b951-d872f2087c98
* The 1st patch to disambiguate message center notificationsjuyik@chromium.org2014-06-121-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | This is the first half of the work to disambiguate the message center notifications originated from different profiles. It clarifies the semantics of message center as the backend of notification by: 1) Adding comments on the usage of id in the MessageCenter interface. 2) Adding a FindVisibleNotificationById(id) method to message center interface so users can directly find backend notifications without going to the notification ui manager interface. 3) Removing the redundant HasNotification() method since the FindVisibleNotificationById() can server the same purpose. Reviewers: * davemoore: please review chrome/browser/chromeos/* * jamescook: please review ash/* TBR=davemoore@chromium.org BUG=297867 Review URL: https://codereview.chromium.org/324583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276756 0039d316-1c4b-4281-b951-d872f2087c98
* Add OnDisplayMetricsChanged in DisplayObserver.mlamouri@chromium.org2014-05-221-2/+3
| | | | | | | | | | | | | | This replaces OnDisplayBoundsChanged and add a MetricsType parameter so consumers can now which metrics has changed. The current set of MetricsType include bounds, workarea and rotation. BUG=162827 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271768 Review URL: https://codereview.chromium.org/259253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272040 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Add OnDisplayMetricsChanged in DisplayObserver. ↵zea@chromium.org2014-05-201-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/259253002/) Reason for revert: Breaks DesktopScreenX11Test.RemoveMonitorOnRight and AddMonitorToTheRight on Linux Tests TBR=mlamouri@chromium.org NOTRY=true NOTREECHECKS=true http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests&number=11092 Original issue's description: > Add OnDisplayMetricsChanged in DisplayObserver. > > This replaces OnDisplayBoundsChanged and add a MetricsType > parameter so consumers can now which metrics has changed. The > current set of MetricsType include bounds, workarea and rotation. > > BUG=162827 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271768 Review URL: https://codereview.chromium.org/294963004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271782 0039d316-1c4b-4281-b951-d872f2087c98
* Add OnDisplayMetricsChanged in DisplayObserver.mlamouri@chromium.org2014-05-201-2/+3
| | | | | | | | | | | | This replaces OnDisplayBoundsChanged and add a MetricsType parameter so consumers can now which metrics has changed. The current set of MetricsType include bounds, workarea and rotation. BUG=162827 Review URL: https://codereview.chromium.org/259253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271768 0039d316-1c4b-4281-b951-d872f2087c98
* views: Make view::Views::GetPreferredSize() const.erg@chromium.org2014-05-202-6/+7
| | | | | | | | | | | | | | | | | | | Due to button refactoring patches, we now need to ask views for their preferred sizes in const methods. Across the entire codebase, the overwhelming majority of GetPreferredSize() implementations could be const. There are only a few places where we can't, and they are usually combining the sizing and layout code. BookmarksBarView was simple enough to perform this separation. Most of the other places were solved by adding "mutable" to value caches. BUG=155363 R=jam@chromium.org, pkasting@chromium.org, scheib@chromium.org, sky@chromium.org, pkasting, sky TBR=jam, scheib Review URL: https://codereview.chromium.org/273223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271682 0039d316-1c4b-4281-b951-d872f2087c98
* Remove static initializers in ash.erg@chromium.org2014-05-131-1/+2
| | | | | | | | | | | | | When trying to land the enabling of ash in normal linux builds, I broke the build because there were several static initializers; ash has never been compiled on a platform where we track that information. This removes several <iostream>s, and constants that depend on other constants. BUG=300084 Review URL: https://codereview.chromium.org/281683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270144 0039d316-1c4b-4281-b951-d872f2087c98
* Improve spelling of "notification".tnagel@chromium.org2014-05-081-4/+4
| | | | | | | | | | | | | | | | | | | There are many ways to get it wrong. BUG=none TBR=darin (for base/) TBR=sky (for chrome/ and ui/) TBR=dconnelly (for components/policy/) TBR=tommi (for media/audio/) TBR=asvitkine (for tools/metrics/) TBR=mad (for win8) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268203 Review URL: https://codereview.chromium.org/261293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269103 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 268203 "There are many ways to get it wrong."benjhayden@chromium.org2014-05-051-4/+4
| | | | | | | | | | | | | | | | | | | | | > There are many ways to get it wrong. > > BUG=none > > TBR=darin (for base/) > TBR=sky (for chrome/ and ui/) > TBR=dconnelly (for components/policy/) > TBR=tommi (for media/audio/) > TBR=asvitkine (for tools/metrics/) > TBR=mad (for win8) > > Review URL: https://codereview.chromium.org/261293002 TBR=tnagel@chromium.org Review URL: https://codereview.chromium.org/269893004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268217 0039d316-1c4b-4281-b951-d872f2087c98
* There are many ways to get it wrong.tnagel@chromium.org2014-05-051-4/+4
| | | | | | | | | | | | | | | BUG=none TBR=darin (for base/) TBR=sky (for chrome/ and ui/) TBR=dconnelly (for components/policy/) TBR=tommi (for media/audio/) TBR=asvitkine (for tools/metrics/) TBR=mad (for win8) Review URL: https://codereview.chromium.org/261293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268203 0039d316-1c4b-4281-b951-d872f2087c98
* Add a main menu item for disabling the notification bell on Mac.dewittj@chromium.org2014-04-242-2/+0
| | | | | | | | | | | | | | The menu item reads "Hide Notifications Icon" and is default un-checked. When clicked, it is checked (and remains that way even across restarts.) This selection is saved in a machine-wide preference. R=rsesek@chromium.org,thakis@chromium.org TBR=gene@chromium.org,atwilson@chromium.org,stevenjb@chromium.org BUG=305398 Review URL: https://codereview.chromium.org/242453012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265831 0039d316-1c4b-4281-b951-d872f2087c98
* Creation of a rotation lock system tray item, for use during MaximizeMode.jonross@chromium.org2014-04-151-15/+8
| | | | | | | | | | | | | | The icon will have a visual indicator of the state in the status area. The system tray will have an interactive entry that will toggle the rotation lock. The lock is only available for the primary display. TEST=TrayRotationLockTest TEST=MaximizeModeControllerTest BUG=337627 Review URL: https://codereview.chromium.org/212923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263764 0039d316-1c4b-4281-b951-d872f2087c98
* Shelf Cleanup AlternateShelfLayout P1 Attempt 3harrym@chromium.org2014-04-121-12/+8
| | | | | | | | | | | R=skuhne@chromium.org TBR=jamescook@chromium.org, miket@chromium.org, skuhne@chromium.org BUG=338429 re-landing of https://codereview.chromium.org/176883022/ with fix for the inset of app panel as discussed offline /w jennyz@ Review URL: https://codereview.chromium.org/229453005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263451 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate ash::internal namespaceoshima@chromium.org2014-04-033-28/+20
| | | | | | | | | | | Plus obvious style nit fixes. BUG=None TBR=sky@chromium.org Review URL: https://codereview.chromium.org/224113005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261522 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Shelf Cleanup (- binary files) ↵jennyz@chromium.org2014-03-121-8/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/176883022/) Reason for revert: This cl is breaking the app list launch bubble. see crbug.com/351776. Original issue's description: > Shelf Cleanup (- binary files) > > R=skuhne@chromium.org > TBR=jamescook@chromium.org, miket@chromium.org, skuhne@chromium.org > BUG=338429 > > re-landing of > https://codereview.chromium.org/140323010/ hopefully this time with less breaking everything. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256319 TBR=jamescook@chromium.org,skuhne@chromium.org,harrym@chromium.org NOTREECHECKS=true NOTRY=true BUG=338429 Review URL: https://codereview.chromium.org/198063003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256662 0039d316-1c4b-4281-b951-d872f2087c98
* Shelf Cleanup (- binary files)harrym@chromium.org2014-03-111-12/+8
| | | | | | | | | | | | | R=skuhne@chromium.org TBR=jamescook@chromium.org, miket@chromium.org, skuhne@chromium.org BUG=338429 re-landing of https://codereview.chromium.org/140323010/ hopefully this time with less breaking everything. Review URL: https://codereview.chromium.org/176883022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256319 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Ash:Shelf - Cleanup of Alternate Shelf (part 1) ↵dgrogan@chromium.org2014-03-011-5/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/140323010/) Reason for revert: Broke Linux ChromiumOS Builder (dbg): http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/45933/steps/compile/logs/stdio FAILED: /b/build/goma/gomacc c++ -MMD -MF obj/ash/system/web_notification/ash.web_notification_tray.o.d .... ../../ash/system/web_notification/web_notification_tray.cc: In constructor 'ash::WebNotificationTray::WebNotificationTray(ash::internal::StatusAreaWidget*)': ../../ash/system/web_notification/web_notification_tray.cc:322:7:error: 'UseAlternateShelfLayout' is not a member of 'ash::switches' ../../ui/message_center/message_center_style.h: At global scope: ../../ui/message_center/message_center_style.h:103:15:error: 'message_center::kButtonSeparatorColor' defined but not used [-Werror=unused-variable] ../../ui/message_center/message_center_style.h:104:15:error: 'message_center::kHoveredButtonBackgroundColor' defined but not used [-Werror=unused-variable] ../../ui/message_center/message_center_style.h:111:15:error: 'message_center::kProgressBarBackgroundColor' defined but not used [-Werror=unused-variable] ../../ui/message_center/message_center_style.h:112:15:error: 'message_center::kProgressBarSliceColor' defined but not used [-Werror=unused-variable] ../../ui/message_center/message_center_style.h:43:15:error: 'message_center::settings::kEntrySeparatorColor' defined but not used [-Werror=unused-variable] Original issue's description: > Part 1) of cleaning up the code related to the shelf layout, specifically removing all instances of branching related to the 'alternate shelf layout' as this is now the only option. > Removed the about:flags entry relating to alternate shelf layout. > > A patch will follow to simplify the remaining layout code as it is still a bit of a spaghetti like mess. > > R=jamescook@chromium.org, skuhne@chromium.org > TBR=miket@chromium.org > BUG=338429 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254301 TBR=jamescook@chromium.org,skuhne@chromium.org,harrym@chromium.org NOTREECHECKS=true NOTRY=true BUG=338429 Review URL: https://codereview.chromium.org/185143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254306 0039d316-1c4b-4281-b951-d872f2087c98
* Part 1) of cleaning up the code related to the shelf layout, specifically ↵harrym@chromium.org2014-03-011-8/+5
| | | | | | | | | | | | | | | | removing all instances of branching related to the 'alternate shelf layout' as this is now the only option. Removed the about:flags entry relating to alternate shelf layout. A patch will follow to simplify the remaining layout code as it is still a bit of a spaghetti like mess. R=jamescook@chromium.org, skuhne@chromium.org TBR=miket@chromium.org BUG=338429 Review URL: https://codereview.chromium.org/140323010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254301 0039d316-1c4b-4281-b951-d872f2087c98
* Converts MessagePopupCollection into a long-lived object (2nd).mukai@chromium.org2014-02-281-12/+11
| | | | | | | | | | | | | | | | | | | | | | This improves the behavior since there were several scenarios where observer methods would cause re-entrancy into the destructor of MessagePopupCollection. Since it observes MessageCenter, it knows when it should show popups and when it shouldn't. This CL is based on dewittj's crrev.com/114553002 with a fix for some tests in linux-aura and win because of screen_aura. This is the reland of r254101 with a fix on tests. The previous CL broke some tests because the initialization delay reset their test expectations. BUG=327363 TBR=dewittj@chromium.org, stevenjb@chromium.org TEST=message_center_unittests on linux_chromeos Review URL: https://codereview.chromium.org/184843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254234 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Converts MessagePopupCollection into a long-lived object. ↵erikwright@chromium.org2014-02-281-11/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/180513002/) Reason for revert: Possible cause of build breakage: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/40180 http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/40180/steps/message_center_unittests/logs/LeftPositioningWithLeftTaskbar MessagePopupCollectionTest.LeftPositioningWithLeftTaskbar (run #1): [ RUN ] MessagePopupCollectionTest.LeftPositioningWithLeftTaskbar Xlib: extension "RANDR" missing on display ":9". ../../ui/message_center/views/message_popup_collection_unittest.cc:341: Failure Expected: (r1.x()) \u003C (GetWorkArea().CenterPoint().x()), actual: 433 vs 400 [ FAILED ] MessagePopupCollectionTest.LeftPositioningWithLeftTaskbar (430 ms) Original issue's description: > Converts MessagePopupCollection into a long-lived object. > > This improves the behavior since there were several scenarios where > observer methods would cause re-entrancy into the destructor of > MessagePopupCollection. Since it observes MessageCenter, it knows when > it should show popups and when it shouldn't. > > This CL is based on dewittj's crrev.com/114553002 with a fix > for some tests in linux-aura and win because of screen_aura. > > BUG=327363 > R=dewittj@chromium.org, stevenjb@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254101 TBR=dewittj@chromium.org,stevenjb@chromium.org,mukai@chromium.org NOTREECHECKS=true NOTRY=true BUG=327363 Review URL: https://codereview.chromium.org/183883006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254145 0039d316-1c4b-4281-b951-d872f2087c98
* Converts MessagePopupCollection into a long-lived object.mukai@chromium.org2014-02-281-12/+11
| | | | | | | | | | | | | | | | | This improves the behavior since there were several scenarios where observer methods would cause re-entrancy into the destructor of MessagePopupCollection. Since it observes MessageCenter, it knows when it should show popups and when it shouldn't. This CL is based on dewittj's crrev.com/114553002 with a fix for some tests in linux-aura and win because of screen_aura. BUG=327363 R=dewittj@chromium.org, stevenjb@chromium.org Review URL: https://codereview.chromium.org/180513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254101 0039d316-1c4b-4281-b951-d872f2087c98
* Move root_window.* to window_event_dispatcher.*ben@chromium.org2014-02-211-1/+1
| | | | | | | | | http://crbug.com/308843 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/174803002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252651 0039d316-1c4b-4281-b951-d872f2087c98
* views: Make View::set_border() take a scoped_ptr<>.erg@chromium.org2014-01-241-2/+2
| | | | | | | | | | | This makes the ownership situation much clearer. It also renames the function to SetBorder() (since it is not a simple accessor and can free previous instances of Border), and creates a Border::NullBorder() method (since "SetBorder(scoped_ptr<>())" is not clear). BUG=none R=sky@chromium.org Review URL: https://codereview.chromium.org/145033006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246990 0039d316-1c4b-4281-b951-d872f2087c98
* Update uses of UTF conversions in android_webview/, apps/, ash/, chrome/app ↵avi@chromium.org2013-12-241-7/+7
| | | | | | | | | | | | to use the base:: namespace. BUG=330556 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/102443009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242444 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Launcher to Shelf.tfarina@chromium.org2013-12-192-4/+4
| | | | | | | | | | | | | | | | | | - move launcher* from launcher to shelf. - rename to launcher.* to shelf.* and launcher_unittest.cc to shelf_unittest.cc - rename LauncherTestAPI to ShelfTestAPI. - rename to launcher_test_api.* to shelf_test_api.* BUG=248353 TEST=None, no functional changes R=jamescook@chromium.org,harrym@chromium.org TBR=sky Review URL: https://codereview.chromium.org/115113006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241794 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes the context menu for a notification.mukai@chromium.org2013-12-182-0/+7
| | | | | | | | | | | | | | | | | | | - The contents of the menu is independent from views, so put it into message_center_tray. - Then it can be unit-testable. wrote test case. - Also MessageCenterTrayDelegate can control availability of the menu. - views::ContextMenuController is not necessarily owned by views::View. Moving it to outside of MessageView will reduce a few lines of code from MessageViewController. BUG=327828 R=dewittj@chromium.org, stevenjb@chromium.org TBR=rsesek@chromium.org TEST=message_center_unittests covers Review URL: https://codereview.chromium.org/114323002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241474 0039d316-1c4b-4281-b951-d872f2087c98
* Fix popup crash on ChromeOS.dewittj@chromium.org2013-12-042-0/+13
| | | | | | | | | | | | The popup collection was not handling correctly the case where it tells the message center to mark its popups read, causing a NOTREACHED in observer list. BUG=324142 Review URL: https://codereview.chromium.org/99543003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238515 0039d316-1c4b-4281-b951-d872f2087c98
* Updates the web_notification_tray visibility when login status is changed.mukai@chromium.org2013-11-122-0/+8
| | | | | | | | | BUG=313850 R=stevenjb@chromium.org Review URL: https://codereview.chromium.org/67623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234588 0039d316-1c4b-4281-b951-d872f2087c98
* Replace kFullscreenUsesMinimalChrome with ↵pkotwicz@chromium.org2013-10-281-3/+5
| | | | | | | | | | | | | ash::wm::WindowState::hide_shelf_when_fullscreen() BUG=None TEST=None R=jamescook TBR=sky (For trivial change in chrome/browser/notifications/fullscreen_notification_blocker.cc) Review URL: https://codereview.chromium.org/32943006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231398 0039d316-1c4b-4281-b951-d872f2087c98
* Make GetRootWindow() return a Window instead of a RootWindow.ben@chromium.org2013-10-251-4/+4
| | | | | | | | | | | | Also adds a typedef from RootWindow to WindowEventDispatcher, the eventual name of this type. Adds a GetDispatcher() method that crawls up to the root Window and returns the WindowEventDispatcher. R=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/37733003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231077 0039d316-1c4b-4281-b951-d872f2087c98
* Use display ID only for mirrored display.oshima@chromium.org2013-10-251-2/+2
| | | | | | | | | | | | | | Don't show display size for mirrored display. Rename SoftwareMirroring code to more generic name to be used for virtual keyboard. This is preparation to add VIRTUAL KEYBOARD mode. BUG=310325 TBR=hongbo.min@intel.com Review URL: https://codereview.chromium.org/39133002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231067 0039d316-1c4b-4281-b951-d872f2087c98
* linux and chromeos: Turn on -Wunused-const-variable.thakis@chromium.org2013-10-191-1/+0
| | | | | | | | | | BUG=307668 R=hans@chromium.org TBR=oshima Review URL: https://codereview.chromium.org/29263007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229578 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors TestSystemTrayDelegate into DefaultSystemTrayDelegate (2)sky@chromium.org2013-09-131-1/+1
| | | | | | | | | | | | | | | | | | | | Original patch was reverted as TestSystemTrayDelegate had an ASH_EXPORT, which caused compile error win-aura builder. DefaultSystemTrayDelegate is the no-op implementation and TestSystemTrayDelegate contains the test related bits. This also fixes a crash in the windows side as TestSystemTrayDelegate::Shutdown() quits the message loop, which is the wrong thing to do. BUG=159693 284358 TEST=none R=oshima@chromium.org TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/23792007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223066 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 222957 "Refactors TestSystemTrayDelegate into DefaultSyst..."cpu@chromium.org2013-09-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It broke Aura windows builder FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma\gomacc.exe "c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\bin\cl.exe" /nologo /showIncludes /FC @obj\ash\test\ash_test_support.test_system_tray_delegate.obj.rsp /c ..\..\ash\test\test_system_tray_delegate.cc /Foobj\ash\test\ash_test_support.test_system_tray_delegate.obj /Fdobj\ash\ash_test_support.pdb c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.cc(24) : error C2220: warning treated as error - no 'object' file generated c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.cc(24) : warning C4273: 'ash::test::TestSystemTrayDelegate::TestSystemTrayDelegate' : inconsistent dll linkage c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.h(15) : see previous definition of '{ctor}' c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.cc(28) : warning C4273: 'ash::test::TestSystemTrayDelegate::~TestSystemTrayDelegate' : inconsistent dll linkage c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.h(16) : see previous definition of '{dtor}' c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.cc(33) : warning C4273: 'ash::test::TestSystemTrayDelegate::SetInitialLoginStatus' : inconsistent dll linkage c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.h(23) : see previous definition of 'SetInitialLoginStatus' c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.cc(37) : warning C4273: 'ash::test::TestSystemTrayDelegate::SetLoginStatus' : inconsistent dll linkage c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.h(30) : see previous definition of 'SetLoginStatus' c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.cc(42) : warning C4273: 'ash::test::TestSystemTrayDelegate::GetUserLoginStatus' : inconsistent dll linkage c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.h(37) : see previous definition of 'GetUserLoginStatus' c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.cc(61) : warning C4273: 'ash::test::TestSystemTrayDelegate::ShouldShowDisplayNotification' : inconsistent dll linkage c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.h(38) : see previous definition of 'ShouldShowDisplayNotification' c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.cc(65) : warning C4273: 'ash::test::TestSystemTrayDelegate::ShutDown' : inconsistent dll linkage c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.h(39) : see previous definition of 'ShutDown' c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.cc(69) : warning C4273: 'ash::test::TestSystemTrayDelegate::SignOut' : inconsistent dll linkage c:\b\build\slave\win_aura_builder\build\src\ash\test\test_system_tray_delegate.h(40) : see previous definition of 'SignOut' ninja: build stopped: subcommand failed. > Refactors TestSystemTrayDelegate into DefaultSystemTrayDelegate > > DefaultSystemTrayDelegate is the no-op implementation and > TestSystemTrayDelegate contains the test related bits. > > This also fixes a crash in the windows side as > TestSystemTrayDelegate::Shutdown() quits the message loop, which is > the wrong thing to do. > > BUG=159693 284358 > TEST=none > R=oshima@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/23465018 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/23650004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222973 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors TestSystemTrayDelegate into DefaultSystemTrayDelegatesky@chromium.org2013-09-131-1/+1
| | | | | | | | | | | | | | | | | DefaultSystemTrayDelegate is the no-op implementation and TestSystemTrayDelegate contains the test related bits. This also fixes a crash in the windows side as TestSystemTrayDelegate::Shutdown() quits the message loop, which is the wrong thing to do. BUG=159693 284358 TEST=none R=oshima@chromium.org Review URL: https://chromiumcodereview.appspot.com/23465018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222957 0039d316-1c4b-4281-b951-d872f2087c98
* Introduces NotificationBlocker.mukai@chromium.org2013-09-122-22/+1
| | | | | | | | | | | | | | | This CL replaces the existing blocking code by the new notification blocker implementations. The new implementation detects the current status more precisely, and each platform can implement different blocking behaviors. BUG=256404, 260060 TEST=covered by new tests R=dewittj@chromium.org, stevenjb@chromium.org Review URL: https://chromiumcodereview.appspot.com/23694021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222698 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing various problems with the new shelf layout in conjunction with the ↵skuhne@chromium.org2013-09-062-7/+2
| | | | | | | | | | | | | blue tray background on bubble activation There was a mismatch between the hover animation & the activation state. I cleaned up the activation code, removed the old override functions, and added comments on various places which had none yet. BUG=274105 TEST=visual Review URL: https://chromiumcodereview.appspot.com/23531033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221597 0039d316-1c4b-4281-b951-d872f2087c98
* Update Status Icon menu when menu model changes (Linux Aura)sidharthms@chromium.org2013-08-282-3/+53
| | | | | | | | | | | | Status icon context menus currently do not update themselves when the menu model changes or when the check state of a menu item changes. This patch fixes that behavior. BUG=263926,262395 Review URL: https://chromiumcodereview.appspot.com/20728003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219964 0039d316-1c4b-4281-b951-d872f2087c98
* Removes the quiet mode menu and let the right click toggles the message center.mukai@chromium.org2013-08-242-37/+0
| | | | | | | | | | BUG=271769 R=stevenjb@chromium.org TEST=manually Review URL: https://chromiumcodereview.appspot.com/23037017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219442 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: do not use extension_id, use notifier's id.mukai@chromium.org2013-08-241-2/+2
| | | | | | | | | | | | | | | It will remove unnecessary methods. Also, each ash notifications has its own notifier id as SYSTEM_COMPONENT. Then we can distinguish those notification types, which means this will enable to allow some urgent system notifications (like power) in the lock screen. BUG=250937 R=dewittj@chromium.org, stevenjb@chromium.org TEST=no breaks on existing tests Review URL: https://chromiumcodereview.appspot.com/23340002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219437 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-18 16:54:49 +0000