| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/12211108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently tray_event_filter is owned by tray_bubble_wrapper, but
its location event handler wants to care about multiple bubble wrappers.
A typical situation is that the system notification (like power notification)
appears when the detailed view is opened. Click inside of the detailed view
will be handled by tray_event_filter for the power notification and it will
close the detailed view through ClickOutsideBubble() unexpectedly.
Now the tray_event_filter is owned by tray_background_view and can handle
outside-detection for all of bubbles.
BUG=167118
Review URL: https://chromiumcodereview.appspot.com/12207049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This includes a bit of cleanup to NetworkStateHandler and ShillPropertyHandler.
I made ShillServicePropertyObserver support devices, renamed it
ShillPropertyObserver, and moved it into ShillPropertyHandler since:
a) naming it would be challenging without context
b) It doesn't really do much, so if we want something similar (e.g. in NetworkConfigurationHandler) it will be easier just to copy/paste the code we need
BUG=161869
Review URL: https://chromiumcodereview.appspot.com/12211051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Automated clean up of style checker errors that were missed due to the plugin
not being executed on implementation files.
BUG=115047
Review URL: https://chromiumcodereview.appspot.com/12218027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
watching code.
BUG=174736
Review URL: https://codereview.chromium.org/12210049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=166828
Review URL: https://codereview.chromium.org/12213045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL:
* Cleans up the network status related strings
* Cleans up some code in NetworkListDetailedView and removes some unused code
BUG=171600
For ash_strings.grd:
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/12087136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=174365
Review URL: https://chromiumcodereview.appspot.com/12213023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
default image from Throbber. We may polish the UI with better asset in M27.
Add an interactive_ flag in Throbber to allow it become non-interactive so that the tooltip will show up when user hover the mouse on the Throbber who is the child view of ThrobberView class.
BUG=171676
Review URL: https://codereview.chromium.org/12180027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a WidgetObserver event that is guaranteed to be invoked synchronously
when a Widget is requested to close. Rename the existing event, which
is invoked at Widget destruction time, typically via a task on the event
loop, to OnWidgetDestroying.
The new event will be used in Views-specific WebContentsModalDialogManager
functionality to get close events for Widgets, so that we don't risk
adverse interleaving of Widget close events with other relevant events
(e.g. IPC). This will allow us to avoids test flakiness observed
in https://codereview.chromium.org/12045037 due to event races in
PrintPreviewTest.PrintCommands
BUG=157161
Review URL: https://chromiumcodereview.appspot.com/12089061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These bubbles will be closed differently (such like ClickedOutsideBubble()),
so no need to have this flag. If this flag is on, the close event may arrive
before the button clicks, so the button click doesn't toggle the bubble.
Also this CL changes the handler of ClickedOutsideBubble(). The tray's widget
will contain both of web notification icons and system tray, but the outside
should mean only the outside of the tray view's bounds.
BUG=169940
TEST=click to open the tray and click the tray icon to close the tray.
Review URL: https://chromiumcodereview.appspot.com/12217004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=172333
TEST=compilation succeeds
Review URL: https://chromiumcodereview.appspot.com/12187003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL should have no affect on Chrome's behavior.
It does the following:
* Removes --enable-new-network-handlers and always enables them
* Adds --ash-enable-new-network-status-area and uses that to control whether
or not to use the new status area code
* Adds --enable-new-network-change-notifier and uses that to control whether
or not to use the new NetworkStateHandler based network change notifier
* Deletes the unused NetworkDeviceHandler (this was added thinking that it
was needed for Geolocation, but it turned out that the code had changed
between Flimflam and Shill so it wasn't necessary)
BUG=161869
For chrome/browser/ui/webui/chromeos, ash/ash_switches:
TBR=xiyuan@chromium.org,sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12095106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
toggles the device in the uber tray bubble.
BUG=172677
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/12092120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
visible
BUG=173520
TEST=manual (see bug)
Review URL: https://codereview.chromium.org/12183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a functional rewrite with no observable behavior/appearance changes.
(it helps by merging adjacent equivalent styles, reducing artificial run breaks)
(it helps disambiguate font/adornment styles for application in layout/drawing)
Remove gfx::StyleRange and its use within gfx::RenderText[Win|Linux|Mac].
Add new BreakList class for managing [ranged] colors and styles; add/update tests.
Add gfx::TextStyle enum for bold, italic, underline, strike, and diagonal strike.
Split ApplyStyleRange into [Set|Apply]Color and [Set|Apply]Style.
Split ApplyDefaultStyle and |default_style_| into the first colors_ and styles_.
Split up SkiaTextRenderer::DrawDecorations for Underline/Strike/DiagonalStrike.
Update ApplyCompositionAndSelectionStyles, add UndoCompositionAndSelectionStyles.
Add temporary StyleIterator convenience class for RenderText subclass style iteration.
Update RenderText[Win|Linux|Mac], Textfield classes, and other users.
Simplify OmniboxResultView (nix bold font, and ClassificationData).
Rename gfx::Font::FontStyle::UNDERLINE (was UNDERLINED);
TODO(followup): Only break runs for bold/italic, color/adorn while drawing.
TODO(followup): Support more custom/ranged colors; merge TextStyle/FontStyle?
BUG=90426,164047,131660
TEST=No observable appearance/performance/behavior changes.
R=asvitkine@chromium.org,pkasting@chromium.org,sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11535014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This addresses two probles:
1. Icon animations are not always in sync
2. ash_system_tray_delegate uses 3 NetworkMenuIcon instances, which
can cause 3 * 60 = 180 animation updates per second. Limit this
by only sending a message when the index changes (5 times per
second). This isn't a perfect fix, but NetworkMenuIcon is being
deprecated soon...
BUG=173156
For ash.gyp:
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12094072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This takes the existing message center code for Ash, and refactors it
into two layers - a system-specific layer (WebNotificationTray) and a
platform-independent (modulo Views) layer (MessageCenterTray). The
WebNotificationTray is responsible for rendering the tray icon and
noticing system changes that cause differences in rendering. The
MessageCenterTray delegates responsibility for rendering the message
center and notification bubbles to the WebNotificationTray.
This patch also adds a Windows port of MessageCenterTray -
MessageCenterTrayWin.
BUG=168605
TEST:
message_center_unittests
browser_tests (WebNotificationTrayWinTest.*)
ash_unittests (WebNotificationTrayTest.*)
Review URL: https://chromiumcodereview.appspot.com/11819048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
enabled.
BUG=171577
TEST=enable any a11y feature, enter lock screen and disable all a11y features, and confirm that the a11y menu is still available.
R=zork@chromium.org
TBR=stevenjb@chromium.org
# TBRing for minor change only in a11y tray code.
Review URL: https://codereview.chromium.org/12094025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
bubble.
BUG=140961
Review URL: https://chromiumcodereview.appspot.com/12089030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changed the font size for the status tray text from 12 pixels to 13 pixels. Recently (Issue 166083), it had been changed from 14 pixels to 12 pixels in order to consolidate to standard font sizes, but that was subsequently deemed to small. sgabriel@ reviewed before and after screenshots of this change, which are attached to the bug report.
BUG=169275
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/12087033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Correct problems with the BluetoothAdapter discovery API.
Split the single SetDiscovering() method into StartDiscovering() and StopDiscovering(), the API requires that the underlying implementation count the calls and only changes the adapter state on the first caller to StartDiscovering() and last caller to StopDiscovering().
BlueZ, used within Chromium OS, behaves in this manner.
Make IsDiscovering() return true if the adapter is performing either step of discovery, move its previous meaning to a new IsScanning() method and accompanying AdapterScanningChanged() observer method.
BUG=chromium-os:31117
TEST=device_unittests
Review URL: https://codereview.chromium.org/11859018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=171587
Review URL: https://chromiumcodereview.appspot.com/12079011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=171729
TBR=oshima
Review URL: https://chromiumcodereview.appspot.com/12087011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I don't know why the existing code was once running on my local environment,
but 'context' parameter in WidgetParams is mandatory in Aura. To specify
the context properly, the best way would be to add another method to show
the settings window with the current context.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/12052057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fix removes the "bubble arrow" for the volume and
brightness system tray bubbles. Added an init param for
that purpose. If set, the geometry is still computed as
it would be for a case with arrow, but the arrow is not
shown.
This is in contrast to a case, where no arrow is used at
all. In that case the geometry is different. For volume
and brightness we want to preserve the "arrow geometry"
but not show the arrow itself.
Reviewers:
stevenjb@ : overall
msw@ : as owner of ui/views/bubble/
BUG=170937
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/12041034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current code just relies on gfx::Display() and obtains the display
name based on those instances. This is actually bad because there's
only one gfx::Display which represents both of the (physical) displays
in mirroring mode. It's better to call xrandr functions if possible.
BUG=170790
TEST=on device, plug an external display, switch between mirroring<->extended, and see the status in the tray.
Review URL: https://chromiumcodereview.appspot.com/11867030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a bug where "Wifi Scanning" and other info messages were showing up in the VPN view.
BUG=171576
Review URL: https://chromiumcodereview.appspot.com/12066002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
additional tests to pass.
BUG=154081
TEST=ash_unittests on Win8/Metro
Review URL: https://chromiumcodereview.appspot.com/11953057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the next step.
MessageCeneterNotificationManager now creates MessageCenter and forwards
new notificaitons to it.
1. Upon chat with dewittj@, we decided to not trat MessageCenter as Singleton
since there are issues on process shutdown (MessageCenter should exist
while MessageCeneterNotificationManager does). Changes that.
2. MessageCeneterNotificationManager for now keeps a map of all displayed
Notification objects - to make sure NotificationDelegates are invoked and
Profiles are tracked.
3. Started to pass ExtensionId into as origin_id from Notification API, to
scope the notification updates to a specific app (bug 168924)
4. Additionally scoped update of notifications by profile, since in
multiprofile case the update was also not scoped by profile.
This does not yet render anything, since there is no rendering Observer
set for the MessageCenter. Will coordinate with Justin.
Next step would be to land a test for the add/update/remove logic,
and also move image download from Balloon_view_ash to NotificationUIManagerImpl,
where notifications wait until they are ready to be displayed.
BUG=168924,168605
Review URL: https://chromiumcodereview.appspot.com/11958025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use std::max(0, ) to bound sizes at 0.
TBR=sky
BUG=160158
Relanding https://codereview.chromium.org/11365160/ in pieces.
Review URL: https://chromiumcodereview.appspot.com/12052016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
always."
This reverts commit 190d06bf03d4c310f042396046b2b5b5f7af43cf.
TBR=sky
> ui: Remove gfx::Size::ClampToNonNegative, prevent negative sizes always.
>
> This was added with the intention of using Size as a vector, replacing use of
> IntSize. Since we have Vector2d now, negative sizes should not exist, so clamp
> them in set_width/set_height and the constructor.
>
> Not covered by tests, as we can't test DCHECKs.
>
> TBR=sky
> BUG=160158
> Relanding: https://codereview.chromium.org/11365160/
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175535
Review URL: https://codereview.chromium.org/12049019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In addition to https://codereview.chromium.org/11742019/, the bar should be slightly wider than the current spec.
BUG=134600
TEST=on device, upload a large file from file manager to google drive, open the system tray, and see the progess of the upload in the tray.
Review URL: https://chromiumcodereview.appspot.com/11741013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Win/Metro.
This adds a test viewer process host to the ash unittests that starts and connects to the viewer process, using the provided hwnd as a backing surface for the tests.
This approach allows most of the ash unittests to pass except for two categories:
1) Tests that spin up more than one ash display. These don't work since each RootWindowHost thus created would require a remote connection and there is only one Metro viewer process.
2) Some number of tests seem to tickle a crash in shader.cc. These are short-circuited on Win8 with a TODO.
Some limitations:
1) The tests require chrome.exe to be registered as the default browser on Windows 8 to be used as a viewer process. This could be fixed in a future CL by creating a minimal viewer process for tests.
2) To register chrome.exe as the default browser, setup.exe needs to be built and run with
setup.exe --register-dev-chrome --register-dev-chrome-suffix=.test
This will be fixed in a future CL by extracting the registration code.
The interesting parts are in ash/test/test_metro_viewer_process_host.h
ash/test/test_metro_viewer_process_host.cc
Most of the rest is test disabling or calling the above.
BUG=154081
TEST=ash_unittests.exe on win8.
Review URL: https://chromiumcodereview.appspot.com/11830038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also refactors NetworkListDetailedViewBase::RefreshNetworkList,
shich should help make the code more maintainable, and fixes a subtle bug
where the "scanning" text was not getting removed. It also reduces the
jumpiness of the network list when it updates.
BUG=153004
Review URL: https://chromiumcodereview.appspot.com/12018022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Clear Initialized when Cellular disabled (e.g. on suspend)
* Update Enable Cellular Button when it becomes available
* Add No Cellular Networks message when Cellular is enabled but there are no networks
BUG=168935,169979
TBR=sky@chromium.org for ash_strings.grd
Review URL: https://codereview.chromium.org/11967007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add 'dark' versions for the LTE/HSPA/GPRS icons so that we show them correctly on the network list.
R=stevenjb@chromium.org
BUG=169969
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177323
Review URL: https://codereview.chromium.org/11975029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Add 'dark' lte icons.
> Add 'dark' versions for the LTE/HSPA/GPRS icons so that we show them correctly on the network list.
>
> R=stevenjb@chromium.org
> BUG=169969
>
> Review URL: https://codereview.chromium.org/11975029
TBR=rkc@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add 'dark' versions for the LTE/HSPA/GPRS icons so that we show them correctly on the network list.
R=stevenjb@chromium.org
BUG=169969
Review URL: https://codereview.chromium.org/11975029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=167661
TBR=sadrul
Review URL: https://codereview.chromium.org/11601006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In the data notification, when connected to LTE, show the LTE icon, not the 3g icon. Also fix the LTE icons in the tray to look clearer.
R=stevenjb@chromium.org,benchan@chromium.org,zelidrag@chromium.org
BUG=169969
Review URL: https://codereview.chromium.org/11889024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The goal is to provide connecting icon and text while the cellular network is initializing.
Cellular initializing is defined as:
Cellular technology is enabled, but no powered device present.
BUG=169979
For ash_strings.gyp:
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/11878034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also made made small changes in HoverHighlightView.
TBR=nkostylev
BUG=chromium-os:35755
Review URL: https://chromiumcodereview.appspot.com/11858008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
align).
BUG=159770
Review URL: https://chromiumcodereview.appspot.com/11885007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=161052
TEST=create bunch of notification and open the message center, and see the height of the center.
Review URL: https://chromiumcodereview.appspot.com/11874004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For Public Accounts, enterprise ownership is indicated in the system
tray menu's user details section. A separate menu entry informing the
user that this device is enterprise-owned is not necessary.
BUG=chromium-os:35755
TEST=Manual
Review URL: https://chromiumcodereview.appspot.com/11819063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The revert didn't fix the ChromeOS failures so I'm restoring the change.
> Revert 176087
>
> Appears to break ChromeOS browser_tests.
>
> > Re-introduce the partial magnifier
> >
> > Major Changes:
> > - Adding a selectbox at the right of screen magnifier setting on the setting page.
> > - Adding 'screen_magnifier_type2' pref.
> > - Separating the enable/disable state of magnifier from MagnifierType. MagnifierType does no longer indicate the current enable/disable status.
> > - Add IsMagnifierEnabled() to shell delegate.
> >
> > BUG=166832
> > TEST=confirm that magnifier can be enabled/disabled via the tray and the settings page. browser_test passes.
> >
> > R=zork@chromium.org, derat@chromium.org, nkostylev@chromium.org
> > TBR=jhawkins@chromium.org
> > # TBRing for small changed in C/B/ui/webui/options/ and C/B/resources/options/
> >
> > Review URL: https://chromiumcodereview.appspot.com/11642014
>
> TBR=yoshiki@chromium.org
> Review URL: https://codereview.chromium.org/11821053
TBR=acolwell@chromium.org
Review URL: https://codereview.chromium.org/11783097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Appears to break ChromeOS browser_tests.
> Re-introduce the partial magnifier
>
> Major Changes:
> - Adding a selectbox at the right of screen magnifier setting on the setting page.
> - Adding 'screen_magnifier_type2' pref.
> - Separating the enable/disable state of magnifier from MagnifierType. MagnifierType does no longer indicate the current enable/disable status.
> - Add IsMagnifierEnabled() to shell delegate.
>
> BUG=166832
> TEST=confirm that magnifier can be enabled/disabled via the tray and the settings page. browser_test passes.
>
> R=zork@chromium.org, derat@chromium.org, nkostylev@chromium.org
> TBR=jhawkins@chromium.org
> # TBRing for small changed in C/B/ui/webui/options/ and C/B/resources/options/
>
> Review URL: https://chromiumcodereview.appspot.com/11642014
TBR=yoshiki@chromium.org
Review URL: https://codereview.chromium.org/11821053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Major Changes:
- Adding a selectbox at the right of screen magnifier setting on the setting page.
- Adding 'screen_magnifier_type2' pref.
- Separating the enable/disable state of magnifier from MagnifierType. MagnifierType does no longer indicate the current enable/disable status.
- Add IsMagnifierEnabled() to shell delegate.
BUG=166832
TEST=confirm that magnifier can be enabled/disabled via the tray and the settings page. browser_test passes.
R=zork@chromium.org, derat@chromium.org, nkostylev@chromium.org
TBR=jhawkins@chromium.org
# TBRing for small changed in C/B/ui/webui/options/ and C/B/resources/options/
Review URL: https://chromiumcodereview.appspot.com/11642014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=166786
TEST=login and see if the shelf has the notification icon even though there're no notifications.
Review URL: https://codereview.chromium.org/11761032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175647 0039d316-1c4b-4281-b951-d872f2087c98
|