| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is still not fully finished - but it is functional and might be useful for what you are doing (and already quite big as it is). Note that the functionality is controlled by the flag.
What is missing?
- There are no unit tests yet
- The visual Drop down box to add a new user is missing.
- The error message box which shows the error if there are already 3 users signed in is missing.
- At the moment I have ~7 lines of test code in there which I will remove before I check in. (I need them since the multi login still does not work for me)
I am not sure if you want to wait until I finish the issue - or if you'd rather want to have this to be able to rather merge early then later. I leave this up to you. If you are for the latter one, you can have at least a look at my changes and if they conflict with yours.
BUG=239201
TEST=visual
Review URL: https://chromiumcodereview.appspot.com/14756019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is how ash works on the device (no wm) and
eliminates flaky-ness caused by WM.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/14698005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ash/system/chromeos/power. This helps:
1. Remove the duplicated PowerSupplyStatus from ash/system/power.
2. Remove PowerStatusObserver from ash/system/power.
3. Remove power supply status related state, apis and observer from ash_system_tray_delegate.cc.
Not done yet:
There are still other PowerManagerClient calls in ash_system_tray_delegate.cc, which are used by other code. We may be able to move them into the new PowerManagerHandler, which will further downsize ash_system_tray_delegate. This could be done in another cl.
BUG=190299
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/14691011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Added LauncherItemController for browser shortcut.
2) Merged Stefan's alt+n implementation.
BUG=156953
TEST= unit_tests, ash_unittests, browser_tests
Review URL: https://chromiumcodereview.appspot.com/11596003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Next step on re-factoring Notifications. This will bring the MessageCenter classes, most important message_center::Notification, into build on all systems, including those where the MessageCenter is not yet appearign in UI. This will allow to start using this Notification class in client code and remove the old Notification class defined in chrome/browser/notificaitons/notification.h
That will allow the clients that already use Rich Notifications to use richer data type support, for example supply an image bits for a Notification (as in Snapshot notifications).
This also removes a lot of compile-time @ifdefs and replaces them with checking a runtime flag which we already have anyways.
On Android and iOS, the MessageCenter is not compiled in, for the size concerns and uncertain story for notifications in general - the existing ENABLE_NOTIFICATIONS define is used for that.
BUG=174164
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199625
Review URL: https://chromiumcodereview.appspot.com/15025002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
startup cases.
BUG=237513
R=jamescook@chromium.org, xiyuan@chromium.org
Review URL: https://codereview.chromium.org/14757010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since the proxy icon cannot be moved on Windows as it is done on ASH, the proxy functionality had to move into the drag and drop host as well.
BUG=166429
TEST=unittest
Review URL: https://chromiumcodereview.appspot.com/14683010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Caused a static initializer on Linux:
# message_center_constants.cc __i686.get_pc_thunk.cx
(Not on Mac though. The SkGetColor() macro has a comment about it not adding
a static initializer on release builds, so maybe it's the float-int-multiplication?
I don't have a linux box around to check, sorry.)
> Remove ENABLE_MESSAGE_CENTER
>
> Next step on re-factoring Notifications. This will bring the MessageCenter classes, most important message_center::Notification, into build on all systems, including those where the MessageCenter is not yet appearign in UI. This will allow to start using this Notification class in client code and remove the old Notification class defined in chrome/browser/notificaitons/notification.h
>
> That will allow the clients that already use Rich Notifications to use richer data type support, for example supply an image bits for a Notification (as in Snapshot notifications).
>
> This also removes a lot of compile-time @ifdefs and replaces them with checking a runtime flag which we already have anyways.
>
> On Android and iOS, the MessageCenter is not compiled in, for the size concerns and uncertain story for notifications in general - the existing ENABLE_NOTIFICATIONS define is used for that.
>
> BUG=174164
>
> Review URL: https://chromiumcodereview.appspot.com/15025002
TBR=dimich@chromium.org
Review URL: https://codereview.chromium.org/14631021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Next step on re-factoring Notifications. This will bring the MessageCenter classes, most important message_center::Notification, into build on all systems, including those where the MessageCenter is not yet appearign in UI. This will allow to start using this Notification class in client code and remove the old Notification class defined in chrome/browser/notificaitons/notification.h
That will allow the clients that already use Rich Notifications to use richer data type support, for example supply an image bits for a Notification (as in Snapshot notifications).
This also removes a lot of compile-time @ifdefs and replaces them with checking a runtime flag which we already have anyways.
On Android and iOS, the MessageCenter is not compiled in, for the size concerns and uncertain story for notifications in general - the existing ENABLE_NOTIFICATIONS define is used for that.
BUG=174164
Review URL: https://chromiumcodereview.appspot.com/15025002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the launcher.
Everything basically works with this patch, but two essential things are still missing:
1. The icon which gets dragged should get its own widget so that it can get visually dragged outside the app list.
2. The unit tests.
They will be send as a second patch because of:
a. The patch is already pretty big as it is.
b. I want to make get this "signed off" before continuing this route.
BUG=166429
TEST=visual, tests come with second patch
Review URL: https://chromiumcodereview.appspot.com/14533006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds new ash keyboard shortcuts that mirror common ChromeVox keys,
for use everywhere else in the UI. Only activated when spoken feedback
is on. See bug for more info.
BUG=236922
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14674002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows other tests (Chrome OS BrowserWithTestWindowTest in particular)
to use AshTestHelper without opening an X window. This speeds up the tests
noticably and makes them less flaky when running locally.
This is a partial revert of https://chromiumcodereview.appspot.com/14284017/ - I was too aggressive in moving code from AshTestBase to AshTestHelper.
BUG=233374
TEST=ash_unittests, unit_tests
Review URL: https://chromiumcodereview.appspot.com/14791002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add separate flag for audio device switcher menu, off by default.
Picking this up from https://codereview.chromium.org/14455012/; only fixed tests.
R=jamescook@chromium.org
TBR=stevenjb@chromium.org,jennyz@chromium.org
BUG=160311
TEST=Audio input/output/mute still works
Review URL: https://chromiumcodereview.appspot.com/14678004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=236029
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14283019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
element exists, the window get bounced.
This patch does not contain the switching for browser instances yet. Adding this before the "movable Chrome icon" lands would be possible, but would require a lot of changes (offsetting the launcher index, ..). If desired I could add a workaround for M28 - if mentioned CL does not land within the next few days.
BUG=230903
TEST=unittest
Review URL: https://chromiumcodereview.appspot.com/14551002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update the ash window cycle controller so it can tell aura::Window to rotate
pane focus and pass it the cycle direction, rather than just activating each
window. The end result is that when you press Ctrl+Back and Ctrl+Forward
you get a consistent cycle now, going through all panes within the most
recently active browser window and then the launcher and status area.
BUG=154598
Review URL: https://chromiumcodereview.appspot.com/13861032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=235474,233374
TEST=ash_unittests, unit_tests
Review URL: https://chromiumcodereview.appspot.com/14284017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=229213
TEST=Manual, see bug
R=jamescook
TBR=sky (for change in chrome/browser/ui/views/accelerator_table.cc)
Review URL: https://chromiumcodereview.appspot.com/14389004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In r174057, ajwong@ added support for implicit testing to scoped_ptr<>. Removes
these in ash/.
BUG=232084
Review URL: https://codereview.chromium.org/14297013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The CL turned out to be innocent, the bots turned green without the revert.
> Revert 194578 "Add ash SessionStateDelegate"
>
> > Add ash SessionStateDelegate
> >
> > This CL refactors the ShellDelegate by adding a SessionStateDelegate to
> > which methods dealing with the session state can be moved. This cleans up
> > the huge ShellDelegate interface and paves the way for further Chrome OS
> > multiprofile work which will need to add several new methods related to
> > the session state.
> >
> > This CL is only the first step. Several other methods should also move to
> > SessionStateDelegate but I do not want to overburden a single CL.
> >
> > BUG=None
> > TEST=Manual and browser/unit tests
> >
> > TBR=sky (for c/b/idle_chromeos.cc and c/chrome_browser_ui.gypi)
> >
> > Review URL: https://codereview.chromium.org/14295008
>
> TBR=bartfab@google.com
>
> Review URL: https://codereview.chromium.org/14200034
TBR=gavinp@chromium.org
Review URL: https://codereview.chromium.org/14200038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Add ash SessionStateDelegate
>
> This CL refactors the ShellDelegate by adding a SessionStateDelegate to
> which methods dealing with the session state can be moved. This cleans up
> the huge ShellDelegate interface and paves the way for further Chrome OS
> multiprofile work which will need to add several new methods related to
> the session state.
>
> This CL is only the first step. Several other methods should also move to
> SessionStateDelegate but I do not want to overburden a single CL.
>
> BUG=None
> TEST=Manual and browser/unit tests
>
> TBR=sky (for c/b/idle_chromeos.cc and c/chrome_browser_ui.gypi)
>
> Review URL: https://codereview.chromium.org/14295008
TBR=bartfab@google.com
Review URL: https://codereview.chromium.org/14200034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL refactors the ShellDelegate by adding a SessionStateDelegate to
which methods dealing with the session state can be moved. This cleans up
the huge ShellDelegate interface and paves the way for further Chrome OS
multiprofile work which will need to add several new methods related to
the session state.
This CL is only the first step. Several other methods should also move to
SessionStateDelegate but I do not want to overburden a single CL.
BUG=None
TEST=Manual and browser/unit tests
TBR=sky (for c/b/idle_chromeos.cc and c/chrome_browser_ui.gypi)
Review URL: https://codereview.chromium.org/14295008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and above
and enable it by default for Chrome AURA.
This change should not affect non AURA Chrome.
The changes in this CL are mostly around setting the focused TextInputClient in the
TSFBridgeDelegate class and not handling the traditional IME messages apart from
WM_IME_SETCONTEXT in the input method win subclass.
I also made a change in the TSFBridge class to ensure that Initialize can be called
multiple times.
ASH support will come in a subsequent change. Needs some more research there.
Known issues:-
1. Clicking on the omnibox in Chrome AURA switches the current language setting back to ENG regardless
of the last active language. We have to switch back to the desired lang each time on the omnibox. This works fine
on the web page though. yukawa? do you have any ideas as to why?
2. Chinese IME's when used on the web page in Chrome AURA display the composition window
at the top left corner of the desktop. This works correctly on the omnibox. yukawa? perhaps you may know.
The views_test_base.h/.cc changes are needed for views unittests to pass
The desktop_notifications_unittest.cc/.h and view_event_test_base.cc/.h changes are needed for interactive_ui_tests to
pass.
The ash_test_base.cc/.h changes are needed for ash_unittests to pass.
BUG=225189
TBR=nona
Review URL: https://codereview.chromium.org/13235003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Tray - launch login UI for multi-profiles
* UserManager: GetLoggedInUsers(), SwitchActiveUser(),
add GetActiveUser() which will later replace GetLoggedInUser()
* Login UI: support "sign in to add" mode
Notifications:
* Pass chromeos::User* in details for
- NOTIFICATION_LOGIN_USER_CHANGED
- NOTIFICATION_ACTIVE_USER_CHANGED
- NOTIFICATION_SESSION_STARTED
* Add NOTIFICATION_ACTIVE_USER_CHANGED (only when switching users for now)
Multi-profile hacks
* Initialize BrowserPolicyConnector only for primary user (http://crbug.com/230349)
* Redirect logging only once (http://crbug.com/230345)
* OAuth2LoginManager tracks only last logged in user (http://crbug.com/230342)
Depends on:
* Changes in ProfileManager https://codereview.chromium.org/14028010/
* Adding concept of "signin profile" https://codereview.chromium.org/13633003/
BUG=180903,217016
TEST=ProfileManager tests, manual (with all CLs applied and --multi-profiles)
Review URL: https://codereview.chromium.org/14139003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Renames string16 -> base::string16 and
base/string_number_conversions.h -> base/strings/string_number_conversions.h
BUG=
Review URL: https://codereview.chromium.org/13856005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduces ui/keyboard/ which contains generic code for the control of the keyboard (right now, just creation of the container window).
Also includes the necessary changes to ash so that the keyboard is (always) displayed on ChromeOS builds when the --enable-virtual-keyboard flag is present.
BUG=226986
Review URL: https://codereview.chromium.org/13164002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
A little code cleanup I did while debugging some panel focus issues.
BUG=none
Review URL: https://codereview.chromium.org/12442009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original version broke on the memory bots. Specifically in OnLauncherDestroyed
there was a call to remove an observer from the ShelfLayoutManager, which was
either already destroyed or in the process of being destroyed. There is no need
to make this call.
When the ShelfLayoutManager changes the autohide behaviour this needs to be
propegated to the ChromeLauncherController otherwise when other parts of the
system query the autohide status they can end up with an incorrect value. This
resolves most of the outstanding issues with the "Autohide Launcher" checkbox in
the context menu.
These is still one issue, specifically if you set autohide off, swipe the
launcher off the screen and then make it reappear, via either swiping or mouse
over. The checkbox will not be checked in this case, but the moment you touch or
click off of the launcher it will hide. After hiding the checkbox will be set as
expected, thus partially resolving that fact that you had to turn on autohide
before you could turn it off. This issue due to the fact that the
ShelfLayoutManager is actually turning off autohide, but setting a handler to
watch for future events and when you interact outside of the launcher setting
autohide on again. Resolving this is outside the scope of this CL/bug since it
either requires changing our UI behjaviour or plumbing information about being
in this state to the LaunchContextMenu, both of which would be unlikely to be
backported to 27.
BUG=chromium:173295
TEST=Visually confirmed that the checkbox is repersenative of the state of
autohide or is only transistorially incorrect.
Ran through memory bot to confirm issues have been corrected.
Review URL: https://chromiumcodereview.appspot.com/13430014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remember primary per display pair
- remember power state. Restore when restarted, but not boot time.
- DefaultLayout is used to construct layout for display pair.
It used to be used if the layout wasn't set before, but since layout has other data such as primary/mirror state, it makes more sense to copy it first.
Cleanup: remove unnecessary code.
BUG=218387
TEST=covered by test. manually tested on device.
Review URL: https://chromiumcodereview.appspot.com/12865019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Propegate setting autohide behaviour to prefs
>
> When the ShelfLayoutManager changes the autohide behaviour this needs to be
> propegated to the ChromeLauncherController otherwise when other parts of the
> system query the autohide status they can end up with an incorrect value. This
> resolves most of the outstanding issues with the "Autohide Launcher" checkbox in
> the context menu.
>
> These is still one issue, specifically if you set autohide off, swipe the
> launcher off the screen and then make it reappear, via either swiping or mouse
> over. The checkbox will not be checked in this case, but the moment you touch or
> click off of the launcher it will hide. After hiding the checkbox will be set as
> expected, thus partially resolving that fact that you had to turn on autohide
> before you could turn it off. This issue due to the fact that the
> ShelfLayoutManager is actually turning off autohide, but setting a handler to
> watch for future events and when you interact outside of the launcher setting
> autohide on again. Resolving this is outside the scope of this CL/bug since it
> either requires changing our UI behjaviour or plumbing information about being
> in this state to the LaunchContextMenu, both of which would be unlikely to be
> backported to 27.
>
> BUG=chromium:173295
> TEST=Visually confirmed that the checkbox is repersenative of the state of
> autohide or is only transistorially incorrect.
>
> Review URL: https://chromiumcodereview.appspot.com/12636012
TBR=rharrison@chromium.org
Review URL: https://codereview.chromium.org/13322004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the ShelfLayoutManager changes the autohide behaviour this needs to be
propegated to the ChromeLauncherController otherwise when other parts of the
system query the autohide status they can end up with an incorrect value. This
resolves most of the outstanding issues with the "Autohide Launcher" checkbox in
the context menu.
These is still one issue, specifically if you set autohide off, swipe the
launcher off the screen and then make it reappear, via either swiping or mouse
over. The checkbox will not be checked in this case, but the moment you touch or
click off of the launcher it will hide. After hiding the checkbox will be set as
expected, thus partially resolving that fact that you had to turn on autohide
before you could turn it off. This issue due to the fact that the
ShelfLayoutManager is actually turning off autohide, but setting a handler to
watch for future events and when you interact outside of the launcher setting
autohide on again. Resolving this is outside the scope of this CL/bug since it
either requires changing our UI behjaviour or plumbing information about being
in this state to the LaunchContextMenu, both of which would be unlikely to be
backported to 27.
BUG=chromium:173295
TEST=Visually confirmed that the checkbox is repersenative of the state of
autohide or is only transistorially incorrect.
Review URL: https://chromiumcodereview.appspot.com/12636012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12588008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-DisplayLayout now keeps track of mirroring state as well.
-Load preference before Shell::Init is execute so that display controller can provide the correct state at boot/startup time
-Added OutputConfigurator::Delegate so that OutputConfigurator can determine the state for dual display when the display is connected.
BUG=196818
TEST=covered by unittests.
Review URL: https://codereview.chromium.org/12716007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Reset the overscan to the default value if the display has overscan.
- Move overscan data into kDisplayProperties dictionary value.
- Remove Rotate/Scale shortcut from login screen as we can't store the state in login screen.
BUG=196818
TEST=covered by unit test.
Review URL: https://codereview.chromium.org/12505005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This specifically addresses the tooltip behavior for Panels, but also
makes the behavior more generally flexible.
BUG=188582,168335
Review URL: https://codereview.chromium.org/12871020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use ash::DisplayController::Observer to save preference
- DisplayLayout::FromInets to eliminate conversions
- Create OutputConfiguratorAnimation on desktop, except for test.
This is necessary to get options page working on desktop.
- Store default only when a user modified the layout. I think this matches
the user's expectation better.
Other cleanups:
- Removed unused declaration Shell::InitLayoutManagersForPrimaryDisplay
BUG=196818
TEST=covered by test
Review URL: https://codereview.chromium.org/12843008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=154859
Review URL: https://chromiumcodereview.appspot.com/12771012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=172254
TEST=PanelWindowResizerTest.DragReordersPanels*
Review URL: https://chromiumcodereview.appspot.com/12434007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- moved Rotation enum from ash to gfx::Display so that
views/ui can use it.
- rotate image and hot point.
BUG=119268
TEST=covered by unit tests, and also test on device.
Review URL: https://chromiumcodereview.appspot.com/12666006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=189122
TEST=unittest
Review URL: https://chromiumcodereview.appspot.com/12436012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PanelLayoutManagerTest started failing on CrOS.
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Tests%20%281%29&number=22062
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Tests%20%281%29%28Precise%29&number=1556
ash/wm/panels/panel_layout_manager_unittest.cc:516: Failure
Value of: p1_d1->GetRootWindow()
Actual: 0x7f1b270c2180
Expected: root_windows[1]
Which is: 0x2f65a568de00
ash/wm/panels/panel_layout_manager_unittest.cc:519: Failure
Value of: p2_d2->GetRootWindow()
Actual: 0x7f1b270c2180
Expected: root_windows[1]
Which is: 0x2f65a568de00
ash/wm/panels/panel_layout_manager_unittest.cc:521: Failure
Value of: root_windows[1]->GetBoundsInScreen().Contains( p1_d1->GetBoundsInScreen())
Actual: false
Expected: true
ash/wm/panels/panel_layout_manager_unittest.cc:526: Failure
Value of: p1_d1->GetRootWindow()
Actual: 0x7f1b270c2180
Expected: root_windows[1]
Which is: 0x2f65a568de00
ash/wm/panels/panel_layout_manager_unittest.cc:529: Failure
Value of: p2_d2->GetRootWindow()
Actual: 0x7f1b270c2180
Expected: root_windows[1]
Which is: 0x2f65a568de00
ash/wm/panels/panel_layout_manager_unittest.cc:536: Failure
Value of: p1_d1->GetRootWindow()
Actual: 0x7f1b270c2180
Expected: root_windows[1]
Which is: 0x2f65a568de00
ash/wm/panels/panel_layout_manager_unittest.cc:539: Failure
Value of: p2_d2->GetRootWindow()
Actual: 0x7f1b270c2180
Expected: root_windows[1]
Which is: 0x2f65a568de00
[ FAILED ] PanelLayoutManagerTest.PanelMoveBetweenMultipleDisplays (275 ms)
> Reorder panels in the launcher when dragging the panel window.
>
> BUG=172254
> TEST=PanelWindowResizerTest.DragReordersPanels*
>
>
> Review URL: https://chromiumcodereview.appspot.com/12448004
TBR=flackr@chromium.org
Review URL: https://codereview.chromium.org/12754008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=172254
TEST=PanelWindowResizerTest.DragReordersPanels*
Review URL: https://chromiumcodereview.appspot.com/12448004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows animations to be sped up or slowed down for testing
or debugging. This replaces LayerAnimator::slow_animation_mode
and LayerAnimator::disable_animations_for_tests.
BUG=129683
Review URL: https://chromiumcodereview.appspot.com/12465005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use RootWindow's transform to implement insets
- Update WorksspaceWindowResizerUnittests to use
UpdateDisplay to update display properly.
- Disable updating display when host window's size has
changed during the test. This is causing flakyness as
ConfigureNotify may arrive after the size has changed to
yet another bounds.
- Re-assign screen rotation to shift-ctrl-refresh.
BUG=119268,174721
TEST=covered by unittests. manual.
Review URL: https://codereview.chromium.org/12746002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=175186
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12473004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the case where Ash is displayed on Windows, we want a single
message center data structure with multiple UI surfaces for
notifications.
g_browser_process now manages the lifetime of the global Message
Center object, since its lifetime is always longer than Ash::Shell.
This allows us to re-enable the browser tests for message center
on Ash+Win, and stops a crash bug.
BUG=178429
Review URL: https://chromiumcodereview.appspot.com/12375004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- White list ash accelerator actions;
- White list browser accelerators;
- Use a limited render view context menu;
BUG=178469
TEST=Verify Ctrl-N etc is disabled and no accelerator/menu to get a browser
window in app mode.
R=zelidrag@chromium.org,sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12389083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
moving the highlight of the current item from the top of the list to what ever is active.
BUG=178333
TEST=unittest
Review URL: https://chromiumcodereview.appspot.com/12374059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a first step to fix overscan issue and implement
screen rotation.
* remove bounds_in_pixel from gfx::Display
* promote DisplayInfo to separate class/file
* All display information is now generated in display_change_observer_x11.cc.
almost no X11 depenency in display_manager.cc
(I'll move FindInternalDisplayID out from display_manager.cc once https://codereview.chromium.org/12217120/ is landed)
This makes testing more consistent with real environment.
* Add DisplayManager::ClearCustomOverscanInsets so that
you can reset the insets to default value.
* Removed obsolete AshTestBase::ChangeDisplayConfig
BUG=174721,119268
TEST=covered by test
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185178
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185230
Review URL: https://chromiumcodereview.appspot.com/12218045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> This is a first step to fix overscan issue and implement
> screen rotation.
>
> * remove bounds_in_pixel from gfx::Display
> * promote DisplayInfo to separate class/file
> * All display information is now generated in display_change_observer_x11.cc.
> almost no X11 depenency in display_manager.cc
> (I'll move FindInternalDisplayID out from display_manager.cc once https://codereview.chromium.org/12217120/ is landed)
>
> This makes testing more consistent with real environment.
>
>* Add DisplayManager::ClearCustomOverscanInsets so that
> you can reset the insets to default value.
>* Removed obsolete AshTestBase::ChangeDisplayConfig
>
>BUG=174721,119268
>TEST=covered by test
>
BUG=174721,119268
Review URL: https://codereview.chromium.org/12374017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185243 0039d316-1c4b-4281-b951-d872f2087c98
|