summaryrefslogtreecommitdiffstats
path: root/ash/test
Commit message (Collapse)AuthorAgeFilesLines
* Move UserInfo to user_manager.nkostylev@chromium.org2014-07-142-8/+9
| | | | | | | | | | Since user_manager::UserInfo is used on non-chromeos ash implementation, defined part of user_manager component that is included on cross-platform ash. BUG=387614 Review URL: https://codereview.chromium.org/379803004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283087 0039d316-1c4b-4281-b951-d872f2087c98
* Move MaximizeModeWindowManager to the controllerjonross@chromium.org2014-06-091-4/+0
| | | | | | | | | | | Remove MaximizeModeWindowManager from Shell. Place it within MaximizeModeController. Move notifications to ShellObserver to after the creation of the window manager. This way checks for it being enabled are correct during notifications. Update all files that were working around this deficiency. TEST=MaximizeModeController Review URL: https://codereview.chromium.org/308683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275843 0039d316-1c4b-4281-b951-d872f2087c98
* Add LockLayoutManager responsible for lock container (login/lock).nkostylev@chromium.org2014-06-062-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | Previously WorkspaceManager was used for this container which resulted in various issues when login screen window was not full screen and was supposed to be resized only by virtual keyboard container. Otherwise panels and shelf were taken into account even though they are stacked below the lock container. This CL improves previous fix https://codereview.chromium.org/231123002 Disable this layout manager with --ash-disable-lock-layout-manager Verified that existing out-of-box/login/multi-profiles login/lock* virtual keyboard overscroll/non-overscroll configurations work fine. Non-overscroll lock screen configuration is updated to use the same behavior as login in https://codereview.chromium.org/320523003 BUG=375666 TEST=LockLayoutManager.*, existing tests Review URL: https://codereview.chromium.org/254673004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275431 0039d316-1c4b-4281-b951-d872f2087c98
* MacViews: Minimal to get views_unittests to compile.tapted@chromium.org2014-05-292-0/+300
| | | | | | | | | | | | | | | | - ui/views/test/child_modal_window.{h,cc} is moved from views_test_support to ash_test_support - test_views_delegate.cc is moved to test_views_delegate_aura.cc and a mac version added - the set of unittest.cc files that need refactoring for Aura are left off for mac to be enabled in a followup - http://crbug.com/378134 - a few other small fixes BUG=366007 Review URL: https://codereview.chromium.org/303473010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273554 0039d316-1c4b-4281-b951-d872f2087c98
* Makes Env contain a ContextFactorysky@chromium.org2014-05-221-1/+3
| | | | | | | | | | | | | | This way when creating the Compositor we can supply the ContextFactory from the thread local Env to it. This is part of making aura thread safe. BUG=none TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/296053009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272332 0039d316-1c4b-4281-b951-d872f2087c98
* Makes construction of (ash)RemoteWindowTreeHostWin explicitsky@chromium.org2014-05-152-4/+9
| | | | | | | | | | | | | | | | | I need to do this as I need to pass in state to the constructor and I can't do that with lazy construction. This makes creation a little saner anyway. I'm not happy about the static setting the HWND. I'll see if I can clean that up later. BUG=none TEST=none R=ananta@chromium.org Review URL: https://codereview.chromium.org/277753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270747 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce creation of ViewsDelegatesky@chromium.org2014-05-146-23/+85
| | | | | | | | | | | | | | | | | | | By consolidating override of OnBeforeWidgetInit that finds shell many of the places that were setting a viewsdelegate no longer need to. Also, made AshTestHelper install a ViewsDelegate so that tests don't have. Because of removed an include of views_delegate from ash_test_helper I had to update some includes. BUG=none TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270290 Review URL: https://codereview.chromium.org/280863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270399 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 270290 "Reduce creation of ViewsDelegate"raymes@google.com2014-05-146-85/+23
| | | | | | | | | | | | | | | | | | | | | | | | | Speculatively reverting as it may have caused the tree to break: http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/20345/steps/compile/logs/stdio > Reduce creation of ViewsDelegate > > By consolidating override of OnBeforeWidgetInit that finds shell many > of the places that were setting a viewsdelegate no longer need to. > > Also, made AshTestHelper install a ViewsDelegate so that tests don't have. > > Because of removed an include of views_delegate from ash_test_helper I had to update some includes. > > BUG=none > TEST=none > R=ben@chromium.org > > Review URL: https://codereview.chromium.org/280863002 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/286753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270305 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce creation of ViewsDelegatesky@chromium.org2014-05-146-23/+85
| | | | | | | | | | | | | | | | | By consolidating override of OnBeforeWidgetInit that finds shell many of the places that were setting a viewsdelegate no longer need to. Also, made AshTestHelper install a ViewsDelegate so that tests don't have. Because of removed an include of views_delegate from ash_test_helper I had to update some includes. BUG=none TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/280863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270290 0039d316-1c4b-4281-b951-d872f2087c98
* Send the device scale factor from Windows 8 ASH during initialization via ↵ananta@chromium.org2014-05-132-3/+6
| | | | | | | | | | | | | | | | | | the MetroViewerHostMsg_SetTargetSurface IPC message. cpu, please review everything. sky, please review the ash/chrome/ui portions. I added a dependency on gfx in the metro_driver project for a subsequent change to send the correct device scale factor on Windows 8 as the metro API does not appear to work correctly causing text, etc to appear very small on high dpi monitors with scales above 125%. BUG=371219 R=cpu,sky Review URL: https://codereview.chromium.org/271543009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269993 0039d316-1c4b-4281-b951-d872f2087c98
* Take a screenshot in maximize mode when volume down and power are pressed.flackr@chromium.org2014-05-112-0/+64
| | | | | | | | | | BUG=363732 TEST=MaximizeModeControllerTest.Screenshot TEST=When device is in maximize mode, hold volume down and press power to take a screenshot. Review URL: https://codereview.chromium.org/263813002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269684 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding "Enabled volume buttons when TouchView is active"bruthig@chromium.org2014-05-092-0/+96
| | | | | | | | | | | | | | Original review: https://codereview.chromium.org/251193005 This reverts commit 680db8794d3159acfc6354e7a4ce46a6abf4dac4. BUG=364584 TEST=MaximizeCodeControllerTest.AllowsVolumeControl TBR=oshima Review URL: https://codereview.chromium.org/271713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269306 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 268181 "Enabled volume buttons when TouchView is active"abodenha@google.com2014-05-052-96/+0
| | | | | | | | | | | | | | | > Enabled volume buttons when TouchView is active > > BUG=364584 > TEST=MaximizeModeControllerTest.AllowsVolumeControl > > Review URL: https://codereview.chromium.org/251193005 TBR=bruthig@chromium.org Review URL: https://codereview.chromium.org/266223003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268198 0039d316-1c4b-4281-b951-d872f2087c98
* Enabled volume buttons when TouchView is activebruthig@chromium.org2014-05-052-0/+96
| | | | | | | | | BUG=364584 TEST=MaximizeModeControllerTest.AllowsVolumeControl Review URL: https://codereview.chromium.org/251193005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268181 0039d316-1c4b-4281-b951-d872f2087c98
* Makes PlatformEventSource creation in Env conditionalsky@chromium.org2014-05-051-1/+1
| | | | | | | | | | | | | | | | | | | | Currently mojo runs all services in the same process. We have separate services that manage the display and one that runs aura. The display one needs to create PlatformEventSource (as it gets events). The service running aura doesn't need a PlatformEventSource as it gets events from the display one. This means I need the ability to create aura::Env without a PlatformEventSource. I believe the long term plan is to move some services out of process. When this happens this boolean shouldn't be needed. BUG=365012 TEST=none R=sadrul@chromium.org Review URL: https://codereview.chromium.org/262883011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268148 0039d316-1c4b-4281-b951-d872f2087c98
* Media indicator for background recording taskoshima@chromium.org2014-05-032-3/+40
| | | | | | | | | BUG=323766 TEST=MediaTrayItemTest.NotifyMediaCaptureChange Review URL: https://codereview.chromium.org/253183003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268077 0039d316-1c4b-4281-b951-d872f2087c98
* DisplayManagerTestApi: Fixed out-of-date comment.mgiuca@chromium.org2014-05-021-2/+2
| | | | | | | | | | | This comment directs the reader where to find the display format string specification; it has moved to a new location. NOTRY=true Review URL: https://codereview.chromium.org/260903005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267696 0039d316-1c4b-4281-b951-d872f2087c98
* CleanUp: Introduce UserInfo. Move session_state stuff to ash/session.oshima@chromium.org2014-04-304-49/+90
| | | | | | | | | | | | BUG=None R=nkostylev@chromium.org TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267158 Review URL: https://codereview.chromium.org/253063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267337 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 267158 "CleanUp: Introduce UserInfo. Move session_state s..."oshima@chromium.org2014-04-304-90/+49
| | | | | | | | | | | | | | | | > CleanUp: Introduce UserInfo. Move session_state stuff to ash/session. > > BUG=None > R=nkostylev@chromium.org > TBR=sky@chromium.org > > Review URL: https://codereview.chromium.org/253063002 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/260783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267250 0039d316-1c4b-4281-b951-d872f2087c98
* CleanUp: Introduce UserInfo. Move session_state stuff to ash/session.oshima@chromium.org2014-04-304-49/+90
| | | | | | | | | | BUG=None R=nkostylev@chromium.org TBR=sky@chromium.org Review URL: https://codereview.chromium.org/253063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267158 0039d316-1c4b-4281-b951-d872f2087c98
* app_shell: Add support for mouse cursors.derat@chromium.org2014-04-281-1/+1
| | | | | | | | | | | | | | Move ImageCursors from ash/wm/ to ui/base/cursors/ and add a NativeCursorManager implementation for ShellDesktopController to use. BUG=364290 TEST=cursor is visible when running app_shell on a Chrome OS device and changes after mousing over a link Review URL: https://codereview.chromium.org/258893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266694 0039d316-1c4b-4281-b951-d872f2087c98
* Update naming from OutputConfiguratorAnimation to DisplayConfiguratorAnimationdnicoara@chromium.org2014-04-243-7/+7
| | | | | | | | BUG=333413 Review URL: https://codereview.chromium.org/250163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266034 0039d316-1c4b-4281-b951-d872f2087c98
* Use platform's device scale factor for cursor instead of gfx::Display ↵oshima@chromium.org2014-04-232-7/+12
| | | | | | | | | | | | | | | | | because gfx::Display's DSF may differ from platform's one when UI scaling is used. BUG=361672 TEST=covered by unit test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265592 R=sky@chromium.org, tdanderson@chromium.org Review URL: https://codereview.chromium.org/226293005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265747 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Use platform's device scale factor for cursor ↵pfeldman@chromium.org2014-04-232-12/+7
| | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/226293005/) Reason for revert: There are no resize cursors in DevTools on Linux Aura anymore. Original issue's description: > Use platform's device scale factor for cursor instead of gfx::Display because gfx::Display's DSF may differ from > platform's one when UI scaling is used. > > BUG=361672 > TEST=covered by unit test > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265592 TBR=tdanderson@chromium.org,sky@chromium.org,oshima@chromium.org NOTREECHECKS=true NOTRY=true BUG=361672 Review URL: https://codereview.chromium.org/249303002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265625 0039d316-1c4b-4281-b951-d872f2087c98
* Use platform's device scale factor for cursor instead of gfx::Display ↵oshima@chromium.org2014-04-232-7/+12
| | | | | | | | | | | | | because gfx::Display's DSF may differ from platform's one when UI scaling is used. BUG=361672 TEST=covered by unit test Review URL: https://codereview.chromium.org/226293005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265592 0039d316-1c4b-4281-b951-d872f2087c98
* 3rd part of porting Chrome Ash to Windows 7ananta@chromium.org2014-04-181-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is the Chrome side that 1- removes windows 8 specific checks 2- disconnects the fake window_tree_host_win 3- connects the remote_window_tree_host_win With this change you can now see the ash desktop but not interact with it since input events have not been enabled. Here is the second part https://codereview.chromium.org/211863003/ First part with rationale: https://codereview.chromium.org/199843004/ Note: this is a redo & rebase of https://codereview.chromium.org/227573007/ BUG=356475 TEST=none patch from issue 235683005 BUG= Review URL: https://codereview.chromium.org/235933004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264680 0039d316-1c4b-4281-b951-d872f2087c98
* Split ui/display types into separate module and have Ozone depend on itdnicoara@chromium.org2014-04-151-1/+1
| | | | | | | | | | | | | | | New dependency model: ui/ozone -> ui/display/types ui/display -> ui/ozone ui/display -> ui/display/types Note ui/display/types is its own module separate from ui/display. TBR=derat@chromium.org Review URL: https://codereview.chromium.org/230763004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263865 0039d316-1c4b-4281-b951-d872f2087c98
* x11: Remove X11 message-pump.sadrul@chromium.org2014-04-151-2/+2
| | | | | | | | | | | | | | | | The remaining use of the X11 mesage-pump was opening the connection to the X11 server. This patch moves that out of the message-pump, into gfx. This allows us to remove the X11 message-pump, and just use the base Glib-based message-pump on Linux and ChromeOS. BUG=354062 R=darin@chromium.org, sky@chromium.org Previously landed in r263726, but reverted in r263733 to allow reverting another CL. Review URL: https://codereview.chromium.org/235043005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263777 0039d316-1c4b-4281-b951-d872f2087c98
* Creation of a rotation lock system tray item, for use during MaximizeMode.jonross@chromium.org2014-04-152-0/+68
| | | | | | | | | | | | | | The icon will have a visual indicator of the state in the status area. The system tray will have an interactive entry that will toggle the rotation lock. The lock is only available for the primary display. TEST=TrayRotationLockTest TEST=MaximizeModeControllerTest BUG=337627 Review URL: https://codereview.chromium.org/212923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263764 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 263726 "x11: Remove X11 message-pump."fischman@chromium.org2014-04-141-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Reason for revert: along with 263718 blamed for http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/45298 http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/29956 > x11: Remove X11 message-pump. > > The remaining use of the X11 mesage-pump was opening the connection to the > X11 server. This patch moves that out of the message-pump, into gfx. This > allows us to remove the X11 message-pump, and just use the base Glib-based > message-pump on Linux and ChromeOS. > > BUG=354062 > R=darin@chromium.org, sky@chromium.org > > Review URL: https://codereview.chromium.org/235043005 TBR=sadrul@chromium.org Review URL: https://codereview.chromium.org/238093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263733 0039d316-1c4b-4281-b951-d872f2087c98
* x11: Remove X11 message-pump.sadrul@chromium.org2014-04-141-2/+2
| | | | | | | | | | | | | | The remaining use of the X11 mesage-pump was opening the connection to the X11 server. This patch moves that out of the message-pump, into gfx. This allows us to remove the X11 message-pump, and just use the base Glib-based message-pump on Linux and ChromeOS. BUG=354062 R=darin@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/235043005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263726 0039d316-1c4b-4281-b951-d872f2087c98
* Notify about major session changes events.nkostylev@chromium.org2014-04-142-0/+11
| | | | | | | | | | | This makes sure that multi-profile user adding UI gets 100% of working area and also works fine with onscreen keyboard. BUG=361157 Review URL: https://codereview.chromium.org/231123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263611 0039d316-1c4b-4281-b951-d872f2087c98
* Shelf Cleanup AlternateShelfLayout P1 Attempt 3harrym@chromium.org2014-04-121-2/+3
| | | | | | | | | | | R=skuhne@chromium.org TBR=jamescook@chromium.org, miket@chromium.org, skuhne@chromium.org BUG=338429 re-landing of https://codereview.chromium.org/176883022/ with fix for the inset of app panel as discussed offline /w jennyz@ Review URL: https://codereview.chromium.org/229453005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263451 0039d316-1c4b-4281-b951-d872f2087c98
* Introdcue AshWindowTreeHost and move ash/chrome specific code in WTH to ash.oshima@chromium.org2014-04-115-13/+19
| | | | | | | | | | | | | | | | | | | | | | | | Other notable changes: * Removed WindowTreeHostFactory as this is no longer necessary. * Moved RootWindowTransformer to ash/host * Removed Set/GetInsets which are no longer necessary (a code in SetInsets is now a part of SetRootWindowTransformer) * Added TransformerHelper that implements common behavior to transform root window for AshWindowTreeHost * Added DEPS files * Updated metro_viewer code to make sure it creates ash::AshRemoteWindowHostTree A few more simplifications to come: * Simplify RootWindowTransformer * Eliminate EnvObserver in AshWindowTreeHostX11 I'll also work on DEPS reorg to make it more explicit under ash/ BUG=355771 TEST=No functional change. ui/aura/window_tree_host_x11_unittests has been moved to ash/host/ash_window_tree_host_x11_unittests Review URL: https://codereview.chromium.org/201573015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263192 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete scale related APIs for cursoroshima@chromium.org2014-04-102-5/+0
| | | | | | | | | | | | | | This has been replaced with SetDisplay a while ago. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263043 R=ben@chromium.org, tdanderson@chromium.org Review URL: https://codereview.chromium.org/233053003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263061 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 263043 "Remove obsolete scale related APIs for cursor"gene@chromium.org2014-04-102-0/+5
| | | | | | | | | | | | | | | > Remove obsolete scale related APIs for cursor > This has been replaced with SetDisplay a while ago. > > BUG=None > > Review URL: https://codereview.chromium.org/233053003 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/233693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263048 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete scale related APIs for cursoroshima@chromium.org2014-04-102-5/+0
| | | | | | | | | | This has been replaced with SetDisplay a while ago. BUG=None Review URL: https://codereview.chromium.org/233053003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263043 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented system tray UI for new account management.dzhioev@chromium.org2014-04-104-0/+12
| | | | | | | | | | | | | | | | | | | | | | | * Added new mode in TrayUser for the case when new account management is enabled (--new-profile-management flag). In fact TrayUser is now supporting four different modes, depending of states of |multi-profiles| flag and |new-profile-management| flag. * Massive refactoring were made in tray_user.cc to isolate UserCardView creation in separate class and make code more clear. * UI for the cases when new account management is disabled remained without changes. Known issues: * There are no tests for new UI. Hopefully old UI is covered by tests already. * New UI is not accessible yet. * Stub implementation of UserAccountsDelegate is used for backend. BUG=344844 TEST=manually Review URL: https://codereview.chromium.org/210903003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262959 0039d316-1c4b-4281-b951-d872f2087c98
* Move all wallpaper file loading and decoding from ↵alemate@chromium.org2014-04-095-17/+35
| | | | | | | | | | | | | | DesktopBackgroundController to WallpaperManager. To simplify DesktopBackgroundController and allow customized default wallpapers, we need to move all "default" wallpaper loading to WallpaperManager. BUG=348136 TEST=unittests Review URL: https://codereview.chromium.org/215293003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262862 0039d316-1c4b-4281-b951-d872f2087c98
* Renamed OutputConfigurator to DisplayConfiguratordnicoara@chromium.org2014-04-071-2/+2
| | | | | | | | BUG=333413 Review URL: https://codereview.chromium.org/226183004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262183 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Virtual keyboard support at OOBE/loginnkostylev@chromium.org2014-04-042-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Enabled TouchView mode test accelerator on login screen, changed to Ctrl+Alt+Shift+T (to avoid conflicts). * Added ash::VirtualKeyboardStateObserver to ShellDelegate. LoginDisplayHost subscribes to virtual keyboard activations and hides/shows login WebUI control bar. * Login WebUI window is no longer fullscreen window so when virtual keyboard is shown, login window is resized accordingly. This means a special case for ShelfLayoutManager i.e. status tray (and shelf) should overflow on top of login window and not resize it (as with maximized windows in session) * Added support for scroll in OOBE/login container. When login window resizes new [scroll-container] it has overflow enabled but without scrollbars being shown. * Since all login / oobe WebUI screens are stacked on top of each other and are hidden just with visibility: hidden, added hidden (display: none) attribute to all screens which is removed right before new screen is activated via toggleStep(). Hidden attribute is added after old screen transition finishes. * Adding hidden attribute to all screens breaks two things which are also addressed in this CL: 1. OOBE screens network/eula/update form a screen group so that their size is adjusted to be the same. This is fixed by removing hidden attribute for OOBE screen group during init. 2. Same OOBE screens have sliding animation defined and adding/removing hidden attributed breaks that. Fix (temporary): don't add hidden attribute to old screen after transition ends. BUG=354413 Review URL: https://codereview.chromium.org/211433002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261751 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate ash::internal namespaceoshima@chromium.org2014-04-0313-73/+44
| | | | | | | | | | | Plus obvious style nit fixes. BUG=None TBR=sky@chromium.org Review URL: https://codereview.chromium.org/224113005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261522 0039d316-1c4b-4281-b951-d872f2087c98
* Unittests of color profiles change.mukai@chromium.org2014-04-022-0/+14
| | | | | | | | | | BUG=355776 R=oshima@chromium.org TEST=unit_tests Review URL: https://codereview.chromium.org/217543006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261084 0039d316-1c4b-4281-b951-d872f2087c98
* Delete "shutdown without closing browsers"oshima@chromium.org2014-03-252-2/+2
| | | | | | | | | | | | | | | | | | | | | Removing unused ShellDelegate::Shutdown() Added new PreShutdown to safely cleanup DisplayObserver. Chrome no longer access X during shutdown (except for deleting X window, which is safe), so normal SessionEnd path should work. There is another issue when this happens during login screen, and I'll file a separate bug for it. BUG=336653 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259061 R=abodenha@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/205963005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259203 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Delete "shutdown without closing browsers" path ↵michaeln@chromium.org2014-03-252-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/205963005/) Reason for revert: Didn't compile on Linux GTK builder. http://build.chromium.org/p/chromium.linux/builders/Linux%20GTK%20Builder/builds/1997 ../../chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc: In member function 'virtual void BookmarkBarGtk::BookmarkModelBeingDeleted(BookmarkModel*)': ../../chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc:896:8:error: 'ShuttingDownWithoutClosingBrowsers' is not a member of 'browser_shutdown' Original issue's description: > Delete "shutdown without closing browsers" > > Removing unused ShellDelegate::Shutdown() > > Added new PreShutdown to safely cleanup DisplayObserver. > > Chrome no longer access X during shutdown (except for deleting X window, which is safe), so normal SessionEnd > path should work. > > There is another issue when this happens during login screen, and I'll file a separate bug for it. > > BUG=336653 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259061 TBR=abodenha@chromium.org,thestig@chromium.org,oshima@chromium.org NOTREECHECKS=true NOTRY=true BUG=336653 Review URL: https://codereview.chromium.org/210673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259085 0039d316-1c4b-4281-b951-d872f2087c98
* Delete "shutdown without closing browsers"oshima@chromium.org2014-03-252-2/+2
| | | | | | | | | | | | | | | | | Removing unused ShellDelegate::Shutdown() Added new PreShutdown to safely cleanup DisplayObserver. Chrome no longer access X during shutdown (except for deleting X window, which is safe), so normal SessionEnd path should work. There is another issue when this happens during login screen, and I'll file a separate bug for it. BUG=336653 Review URL: https://codereview.chromium.org/205963005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259061 0039d316-1c4b-4281-b951-d872f2087c98
* Move some code from aura/client to wm/publicben@chromium.org2014-03-211-2/+2
| | | | | | | | | | | Still building as part of the aura target, will fix that in a future step. TBR=sky@chromium.org http://crbug.com/308710 Review URL: https://codereview.chromium.org/206453005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258651 0039d316-1c4b-4281-b951-d872f2087c98
* Show avatar icon on V2 app's frameoshima@chromium.org2014-03-212-3/+19
| | | | | | | | | | BUG=305071 TEST=CustomFrameViewAsh.AvatarIcon + manual test. TBR=sky@chromium.org Review URL: https://codereview.chromium.org/200483004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258550 0039d316-1c4b-4281-b951-d872f2087c98
* Remove window/host accessors from WindowEventDispatcher. ↵ben@chromium.org2014-03-202-3/+3
| | | | | | | | | | | Include-What-You-Use for WindowTreeHost. TBR=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/196383014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258401 0039d316-1c4b-4281-b951-d872f2087c98
* Run ContentMain in a browser_test's browser process. This removes ↵jam@chromium.org2014-03-182-1/+13
| | | | | | | | | | | | | duplication of code in the browser test harness for setting up the browser process, and also ensures that initialization code in ContentMainRunner runs. Most of the changes are to unit tests which run in browser test executables. These were getting all the setup that these binaries did for browser tests even though they were unit tests. Now they have to explicitly setup objects that they need. This would be done automatically if they were in a unit test binary and therefore using the unit test harness. The goal should be to move these tests to unit test binaries, and make them support launching some tests in separate processes building on the work that Pawel did. BUG=350550 R=sky@chromium.org Review URL: https://codereview.chromium.org/190663012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257597 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-11 19:54:55 +0000