summaryrefslogtreecommitdiffstats
path: root/ash/test
Commit message (Collapse)AuthorAgeFilesLines
* Ensure that the first browser window which is created in Windows 8 ASH is ↵ananta@chromium.org2013-11-201-15/+17
| | | | | | | | | | | | | | | | | | | | maximized. This is done via the Ash WindowPositioner class. The change is in the WindowPositioner::GetBoundsAndShowStateForNewWindow function which for windows returns SHOW_STATE_MAXIMIZED if this is the first window being opened. Based on a discussion with oshima, I enabled the WindowSizerAshTest ash unit tests for Windows. There were a number of places in the WindowSizer class where we were allowing browsers to be in ASH only for Chrome OS. Checking for the host desktop type should be enough. This was needed to get the window to be maximized for ASH. Fixes bug http://crbug.com/231603 BUG=231603 R=cpu@chromium.org, oshima@chromium.org, sky@chromium.org, cpu, oshima, sky Review URL: https://codereview.chromium.org/62333015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236134 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 236048 "Rename RootWindowHost* to WindowTreeHost*"ben@chromium.org2013-11-204-7/+7
| | | | | | | | | | | | | | | > Rename RootWindowHost* to WindowTreeHost* > > TBR=sky@chromium.org > http://crbug.com/308843 > > Review URL: https://codereview.chromium.org/76583003 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/77203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236093 0039d316-1c4b-4281-b951-d872f2087c98
* Rename RootWindowHost* to WindowTreeHost*ben@chromium.org2013-11-194-7/+7
| | | | | | | | | TBR=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/76583003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236048 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce AppListSyncableService, owns AppListModel and builderstevenjb@chromium.org2013-11-191-1/+4
| | | | | | | | | | | | | | | | | | | | | | This introduces AppListSyncableService, but does not implement any syncing yet. The purpose is to move ownership of AppListModel so that we can maintain and sync the model state independent of the view. It also made sense to move ExtensionAppModelBuilder ownership to AppListSyncableService. This required a fair bit of (smallish) re-factoring. Here is a simplified diagram that may help: https://docs.google.com/a/google.com/drawings/d/1NgaQzdqddTh1W7altZ6P6t4dNxZDRO0e_HgJqa8V36A/edit BUG=315887 For minor ash/shell/ changes: R=jennyz@chromium.org, tapted@chromium.org, xiyuan@chromium.org TBR=jamescook@chromium.org Review URL: https://codereview.chromium.org/66023003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236020 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 235935 "Reland - [ash] Enable dragging an item between sh..."dcheng@chromium.org2013-11-192-16/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Reland - [ash] Enable dragging an item between shelf and overflow bubble > > Previous cl (https://codereview.chromium.org/61703002/) was reverted > because win8-aura doesn't support multiple display. > > Description Copied from original cl: > This is the first CL to implement drag and drop from overflow bubble to shelf. > > Currently ripped off item from overflow bubble cannot be dragged into shelf. > But, Item should be dragged from overflow bubble to shelf to implement drag & drop. > In this CL, re-insert bounds for shelf/overflow bubble is re-defined like below. > - shelf -bounds that include visible items. > - overflow bubble - overflow bubble bounds. > > * The method of ripping off is not changed (dragging an item to above only in bottom alignment) > If ripping off is possible by dragging to down side, it could cause flickering because overflow bubble and shelf is located too closely. > > R=jamescook@chromium.org > BUG=137141 > TEST=ash_unittest --gtest_filter=*.CheckDragInsertBoundsWithMultiMonitor > > Review URL: https://codereview.chromium.org/74853002 TBR=simonhong@chromium.org Review URL: https://codereview.chromium.org/73233003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235947 0039d316-1c4b-4281-b951-d872f2087c98
* Reland - [ash] Enable dragging an item between shelf and overflow bubblesimonhong@chromium.org2013-11-192-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | Previous cl (https://codereview.chromium.org/61703002/) was reverted because win8-aura doesn't support multiple display. Description Copied from original cl: This is the first CL to implement drag and drop from overflow bubble to shelf. Currently ripped off item from overflow bubble cannot be dragged into shelf. But, Item should be dragged from overflow bubble to shelf to implement drag & drop. In this CL, re-insert bounds for shelf/overflow bubble is re-defined like below. - shelf -bounds that include visible items. - overflow bubble - overflow bubble bounds. * The method of ripping off is not changed (dragging an item to above only in bottom alignment) If ripping off is possible by dragging to down side, it could cause flickering because overflow bubble and shelf is located too closely. R=jamescook@chromium.org BUG=137141 TEST=ash_unittest --gtest_filter=*.CheckDragInsertBoundsWithMultiMonitor Review URL: https://codereview.chromium.org/74853002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235935 0039d316-1c4b-4281-b951-d872f2087c98
* Add a full screen virtual keyboard to virtual keyboard root windowbshe@chromium.org2013-11-181-1/+1
| | | | | | | | | | | | | | | | | | | This relands https://codereview.chromium.org/47873003. It was reverted because of VirtualKeyboardWindowControllerTest.VirtualKeyboardWindowTest test crash on win8_aura. R=oshima@chromium.org TBR=jamescook, sadrul BUG=310331 TEST= 1. add keyboard-usability-experiment flag 2. hook up an external screen 3. boot device expected: a full screen keyboard on one of the screen Review URL: https://codereview.chromium.org/62833010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235795 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 235533 because the test added in the CL fails on win8-aurasadrul@chromium.org2013-11-172-16/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The crash trace is as follows: [2188:1892:1117/092153:837538:FATAL:display_manager.cc(571)] Check failed: 1u == updated_display_info_list.size() (1 vs. 2)Multiple display test does not work on Win8 bots. Please skip (don't disable) the test using SupportsMultipleDisplays() Backtrace: base::debug::StackTrace::StackTrace [0x6C2DBBF1+33] logging::LogMessage::~LogMessage [0x6C10D2FE+94] ash::internal::DisplayManager::UpdateDisplays [0x5BC233C5+293] ash::internal::DisplayManager::OnNativeDisplaysChanged [0x5BC22B43+2723] ash::test::DisplayManagerTestApi::UpdateDisplay [0x00CDB1D7+775] ash::test::AshTestBase::UpdateDisplay [0x00CD7309+121] ash::test::ShelfViewMultiMonitorTest::SetUp [0x0098B136+102] testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x00CAF59F+319] testing::Test::Run [0x00C99FBB+107] testing::TestInfo::Run [0x00C9A9CD+221] testing::TestCase::Run [0x00C9B17F+239] testing::internal::UnitTestImpl::RunAllTests [0x00CA1ACD+701] testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x00CB01C7+327] testing::UnitTest::Run [0x00CA0330+192] base::TestSuite::Run [0x00C8EEE0+240] main [0x00BA9227+103] __tmainCRTStartup [0x00E1978F+447] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:555) mainCRTStartup [0x00E195BF+15] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:371) BaseThreadInitThunk [0x76638543+14] RtlInitializeExceptionChain [0x7788AC69+133] RtlInitializeExceptionChain [0x7788AC3C+88] > [ash] Enable dragging an item from the overflow bubble to the shelf bounds > > This is the first CL to implement drag and drop from overflow bubble to shelf. > > Currently ripped off item from overflow bubble cannot be dragged into shelf. > But, Item should be dragged from overflow bubble to shelf to implement drag & drop. > In this CL, re-insert bounds for shelf/overflow bubble is re-defined like below. > - shelf -bounds that include visible items. > - overflow bubble - overflow bubble bounds. > > * The method of ripping off is not changed (dragging an item to above only in bottom alignment) > If ripping off is possible by dragging to down side, it could cause flickering because overflow bubble and shelf is located too closely. > > R=harrym@chromium.org, jamescook@chromium.org > BUG=137141 > TEST=browser_tests, ash_unittests > > Review URL: https://codereview.chromium.org/61703002 TBR=simon.hong81@gmail.com Review URL: https://codereview.chromium.org/74733002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235537 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] Enable dragging an item from the overflow bubble to the shelf boundssimon.hong81@gmail.com2013-11-172-0/+16
| | | | | | | | | | | | | | | | | | | | | This is the first CL to implement drag and drop from overflow bubble to shelf. Currently ripped off item from overflow bubble cannot be dragged into shelf. But, Item should be dragged from overflow bubble to shelf to implement drag & drop. In this CL, re-insert bounds for shelf/overflow bubble is re-defined like below. - shelf -bounds that include visible items. - overflow bubble - overflow bubble bounds. * The method of ripping off is not changed (dragging an item to above only in bottom alignment) If ripping off is possible by dragging to down side, it could cause flickering because overflow bubble and shelf is located too closely. R=harrym@chromium.org, jamescook@chromium.org BUG=137141 TEST=browser_tests, ash_unittests Review URL: https://codereview.chromium.org/61703002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235533 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r235502 "Add a full screen virtual keyboard to virtual keyboard root ↵thakis@chromium.org2013-11-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | window" Test has been failing on Win8 Aura since it landed. [ RUN ] VirtualKeyboardWindowControllerTest.VirtualKeyboardWindowTest [1816:612:1115/193527:1412105:FATAL:display_manager.cc(571)] Check failed: 1u == updated_display_info_list.size() (1 vs. 2)Multiple display test does not work on Win8 bots. Please skip (don't disable) the test using SupportsMultipleDisplays() Backtrace: base::debug::StackTrace::StackTrace [0x6C8EBBF1+33] logging::LogMessage::~LogMessage [0x6C71D2FE+94] ash::internal::DisplayManager::UpdateDisplays [0x5BA229F5+293] ash::internal::DisplayManager::OnNativeDisplaysChanged [0x5BA22173+2723] ash::internal::DisplayManager::InitFromCommandLine [0x5BA1E281+817] ash::Shell::Init [0x5B7628A2+210] ash::Shell::CreateInstance [0x5B75C8D9+361] ash::test::AshTestHelper::SetUp [0x01782E29+281] ash::test::AshTestBase::SetUp [0x017753AC+332] ash::test::VirtualKeyboardWindowControllerTest::SetUp [0x016A57D7+247] testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x0174E3BF+319] testing::Test::Run [0x01738DDB+107] testing::TestInfo::Run [0x017397ED+221] testing::TestCase::Run [0x01739F9F+239] testing::internal::UnitTestImpl::RunAllTests [0x017408ED+701] testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x0174EFE7+327] testing::UnitTest::Run [0x0173F150+192] base::TestSuite::Run [0x0172DD00+240] main [0x01647767+103] __tmainCRTStartup [0x018B870F+447] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:555) mainCRTStartup [0x018B853F+15] (f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c:371) BaseThreadInitThunk [0x750D8543+14] RtlInitializeExceptionChain [0x775DAC69+133] RtlInitializeExceptionChain [0x775DAC3C+88] http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/12680/steps/ash_unittests/logs/stdio BUG=310331 TBR=bshe@chromium.org Review URL: https://codereview.chromium.org/74693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235520 0039d316-1c4b-4281-b951-d872f2087c98
* Add a full screen virtual keyboard to virtual keyboard root windowbshe@chromium.org2013-11-161-1/+1
| | | | | | | | | | | | | BUG=310331 TEST= 1. add keyboard-usability-experiment flag 2. hook up an external screen 3. boot device expected: a full screen keyboard on one of the screen Review URL: https://codereview.chromium.org/47873003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235502 0039d316-1c4b-4281-b951-d872f2087c98
* Set LauncherID as a Window's Propertysimon.hong81@gmail.com2013-11-162-19/+5
| | | | | | | | | | | | | | Currently, we need to query all LauncherItemController when we need to get window's id. This is very inefficient way. Instead, LauncherID associated with window is set as a window property. R=sky@chromium.org BUG=NONE TEST=browser_tests --gtest_filter=*.MatchingLauncherIDandActiveTab Review URL: https://codereview.chromium.org/27335006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235496 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Remove NetworkHandler::Initialize from AshTestHelper.pneubeck@chromium.org2013-11-152-17/+1
| | | | | | | | | | | Only one test (network_state_notifier_unittest.cc) based on AshTestHelper seems to depend on NetworkHandler, but all tests initialized the Handler. BUG=317651 R=oshima@chromium.org, stevenjb@chromium.org Review URL: https://codereview.chromium.org/72093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235343 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some pass-thrus on RootWindow API in favor of exposing the ↵ben@chromium.org2013-11-151-1/+1
| | | | | | | | | | | RootWindowHost again. R=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/72503002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235293 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Rename LauncherModel to ShelfModel.tfarina@chromium.org2013-11-147-14/+12
| | | | | | | | | | | | | * Move launcher_model.* from launcher/ to shelf/ * Rename to shelf_model.* BUG=248353 TEST=None, no functional changes R=jamescook@chromium.org,harrym@chromium.org Review URL: https://codereview.chromium.org/71653003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235217 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] Overflow bubble shows empty slotsimon.hong81@gmail.com2013-11-096-1/+57
| | | | | | | | | | | | | | | Problem: When an item is ripped out from the overflow bubble, overflow bubble shows an empty slot for invisible view(drag_view). The size of overflow bubble size should be shrunk. R=skuhne@chromium.org, jamescook@chromium.org BUG=312536 TEST=ash_unittests --gtest_filter=*.OverflowBubbleSize, visual test Review URL: https://codereview.chromium.org/49503005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234077 0039d316-1c4b-4281-b951-d872f2087c98
* don't launch chrome.exe when running in metro test binaryscottmg@chromium.org2013-11-081-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | In ash_unittests, TestMetroViewerProcessHost launches the metro viewer, and the metro viewer is expected to connect back to it. By default though, it launches chrome because it normally needs to do that to have something to connect to. Normally, ash_unittests creates the pipe, so chrome.exe's pipe creation fails, and then chrome.exe shuts down when the viewer shuts down. If, however, chrome takes longer to start, then the ash_unittests test may finish, try to kill chrome.exes, then chrome.exe starts up and creates the host pipe, then the next ash_unittest test starts up, and fails because it will fail to create the pipe. To avoid this race, pass an argument to the viewer (normally "open", now in tests "test_open") that inhibits it from starting chrome.exe R=ananta@chromium.org TBR=sky@chromium.org BUG=303478,316012 Review URL: https://codereview.chromium.org/65623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233872 0039d316-1c4b-4281-b951-d872f2087c98
* Upon activation on mixed mode, we only show and use apps of the current ↵skuhne@chromium.org2013-11-052-2/+3
| | | | | | | | | | | user. Furthermore we should not show the menu if an app was created. BUG=296269 TEST=visual Review URL: https://codereview.chromium.org/58813002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233142 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce MediaDelegateoshima@chromium.org2013-11-012-12/+13
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/48523010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232330 0039d316-1c4b-4281-b951-d872f2087c98
* Check for incognito-mode availabilty added.merkulova@chromium.org2013-10-312-0/+5
| | | | | | | | BUG=279953 Review URL: https://codereview.chromium.org/34903002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232096 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce WindowStateDelegate::ToggleFullscreenoshima@chromium.org2013-10-302-4/+0
| | | | | | | | | | | | | | | Replace kAnimateToFullscreenKey with a boolean flag in WindowState I removed #if defined(OS_WIN).. #endif in chrome_shell_delegate.cc because you'll never get window in desktop environment there. Next step. I'll look into if we can change so that WindowState::Restore can restore from fullscreen state properly. BUG=309837 Review URL: https://codereview.chromium.org/42353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231903 0039d316-1c4b-4281-b951-d872f2087c98
* Move test-only ContextFactory implementations out of production targetsjamesr@chromium.org2013-10-302-5/+5
| | | | | | | | | | | | | | | | | | This moves (Test|Default)ContextFactory and associated setup out of the production compositor target into the test-only compositor_test_support library. This removes the need for us to link in fake/mock classes into the prod build and cleans up several pieces of confusing static state. Code that wants to use one of the test ContextFactory implementations now has to call either ui::InitializeContextFactoryForTests() or, if it's depending on content and using aura, content::ImageTransportFactory::InitializeForUnitTests() and pass in a ContextFactory implementation. Content-based tests get the latter for free through content::BrowserTestBase. R=piman,sky Review URL: https://codereview.chromium.org/45963003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231867 0039d316-1c4b-4281-b951-d872f2087c98
* Always adjust the bounds to work area if the new window is the first window.oshima@chromium.org2013-10-301-0/+6
| | | | | | | | | | | | | I think this is correct behavior. Cleanup: remove set_target_root_window() when adding new root window. This was old hack for test and no longer necessary. BUG=286391 TEST=covered by unit test. Review URL: https://codereview.chromium.org/46183004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231840 0039d316-1c4b-4281-b951-d872f2087c98
* Animating and fading a dragged window when dragged onto a multi user icon in ↵skuhne@chromium.org2013-10-302-3/+13
| | | | | | | | | | | the tray BUG=312550 TEST=unittest (& visually tested) Review URL: https://codereview.chromium.org/50763005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231766 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Fix lock-before-suspend regression.derat@chromium.org2013-10-294-1/+19
| | | | | | | | | | | | This fixes an uninitialized member variable in ash::internal::PowerEventObserver that could result in the screen not getting locked before the system goes to sleep. BUG=312210 Review URL: https://codereview.chromium.org/49743004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231622 0039d316-1c4b-4281-b951-d872f2087c98
* Make GetRootWindow() return a Window instead of a RootWindow.ben@chromium.org2013-10-259-21/+22
| | | | | | | | | | | | Also adds a typedef from RootWindow to WindowEventDispatcher, the eventual name of this type. Adds a GetDispatcher() method that crawls up to the root Window and returns the WindowEventDispatcher. R=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/37733003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231077 0039d316-1c4b-4281-b951-d872f2087c98
* Introduces NewWindowDelegate to create or show windows/tabs that are not ↵oshima@chromium.org2013-10-252-32/+20
| | | | | | | | | | | part of ash. BUG=none TBR=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/30533012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230901 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce AccessibiltyDelegateoshima@chromium.org2013-10-242-93/+7
| | | | | | | | | | I'll incorporate changes in https://codereview.chromium.org/27238008 when it's landed. BUG=none Review URL: https://codereview.chromium.org/37663004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230619 0039d316-1c4b-4281-b951-d872f2087c98
* Rename StackingClient -> WindowTreeClientben@chromium.org2013-10-232-6/+7
| | | | | | | | | | | | Remove SetDefaultParentForRootWindow from Window, and replace with new utility function ParentWindowForContext in window_tree_client.h This is part of my current campaign to slim down the aura Window types. I will eventually move WindowTreeClient to a new ui/wm component that I plan to create. R=erg@chromium.org http://crbug.com/308844 Review URL: https://codereview.chromium.org/36473003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230501 0039d316-1c4b-4281-b951-d872f2087c98
* Add autoclick menu item to ash accessibility system tray.tengs@chromium.org2013-10-232-0/+12
| | | | | | | | | BUG=272401 TEST=updated browser_tests Review URL: https://codereview.chromium.org/27238008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230498 0039d316-1c4b-4281-b951-d872f2087c98
* Change GetBrowserItemIndex() to GetLauncherItemIndexForType()simon.hong81@gmail.com2013-10-231-1/+0
| | | | | | | | | | | | | Makes GetBrowserItemIndex() more general function to get item index. Move this function to ./ash/launcher/launcher_item_util.h R=sky@chromium.org BUG=NONE TEST=browser_tests, ash_unittests Review URL: https://codereview.chromium.org/27369004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230456 0039d316-1c4b-4281-b951-d872f2087c98
* Implement app list folder management page UI, including the following feature:jennyz@chromium.org2013-10-232-0/+14
| | | | | | | | | | | | | | | | | | | 1. Clicking on a folder item in the app list grid will open the app list folder management page to show the folder name and items in the folder. 2. User can click on the back button on folder management page to navigate back to the app list page. 3. User can change the app list folder name on folder management page on linux_chromeos_asan. The original cl has been reviewed: https://codereview.chromium.org/27777002/ This one is patched from the original cl and fix the memory issue. BUG=303224 R=xiyuan@chromium.org TBR=oshima, stevenjb Review URL: https://codereview.chromium.org/35683005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230439 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 230227 "Implement app list folder management page UI, inc..."jyasskin@chromium.org2013-10-232-14/+0
| | | | | | | | | | | | | | | | | | | | | It caused use-after-frees at http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%283%29/builds/29082/steps/memory%20test%3A%20ash_unittests/logs/stdio > Implement app list folder management page UI, including the following feature: > 1. Clicking on a folder item in the app list grid will open the app list folder management page to show the folder name and items in the folder. > 2. User can click on the back button on folder management page to navigate back to the app list page. > 3. User can change the app list folder name on folder management page. > > BUG=303224 > TBR=sky > > Review URL: https://codereview.chromium.org/27777002 TBR=jennyz@chromium.org Review URL: https://codereview.chromium.org/35783003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230256 0039d316-1c4b-4281-b951-d872f2087c98
* Implement app list folder management page UI, including the following feature:jennyz@chromium.org2013-10-222-0/+14
| | | | | | | | | | | | | 1. Clicking on a folder item in the app list grid will open the app list folder management page to show the folder name and items in the folder. 2. User can click on the back button on folder management page to navigate back to the app list page. 3. User can change the app list folder name on folder management page. BUG=303224 TBR=sky Review URL: https://codereview.chromium.org/27777002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230227 0039d316-1c4b-4281-b951-d872f2087c98
* Move ToggleMaximized impl to ash and remove ShellDelegate::ToggleMaximizedoshima@chromium.org2013-10-222-7/+0
| | | | | | | | BUG=272460 Review URL: https://codereview.chromium.org/29153006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230005 0039d316-1c4b-4281-b951-d872f2087c98
* Adding "teleport windows to user X" context menuskuhne@chromium.org2013-10-192-5/+29
| | | | | | | | | | | This adds the teleport items to the context menu. At the same time I was also adding a GetUserID function to the SessionStateController to avoid adding the sanitization of the user names all over the place. BUG=306143 TEST=visual, a few things got handled by unit tests Review URL: https://codereview.chromium.org/27217003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229607 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Move launcher_view* to shelf/ directory.tfarina@chromium.org2013-10-185-124/+124
| | | | | | | | | | | BUG=248353 TEST=none, no functional changes. R=jamescook@chromium.org, xiyuan@chromium.org TBR=sky@chromium.org # for chrome/browser/ui Review URL: https://codereview.chromium.org/27628002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229274 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2: Refactor LauncherItemController and LauncherItemDelegatesimon.hong81@gmail.com2013-10-156-69/+167
| | | | | | | | | | | | | | | | | | | | Previous CL was reverted (https://codereview.chromium.org/23606016/) because LauncherItemDelegateManager holds destoryed LauncherModel pointer (in win7_aura trybot). To handle this, destroy LauncherItemDelegateManager and recreates a new one with new LauncherModel. Original description. * LauncherItemController subclasses LauncherItemDelegate * Register/Unregister when LauncherItemDelegate is created/removed * LauncherItemDelegateManager handles LauncherItemDelegate by LauncherID * LauncherItemDelegateManager take ownership of all LauncherItemDelegate R=sky@chromium.org, skuhne@chromium.org BUG=279105 TEST=unit_tests, browser_tests, ash_unittests, ash_shell Review URL: https://codereview.chromium.org/25823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228595 0039d316-1c4b-4281-b951-d872f2087c98
* Adding the multi profile feature to allow drag of windows from the active ↵skuhne@chromium.org2013-10-142-0/+9
| | | | | | | | | | | | | | desktop to another ones desktop. How it works: When multiple users are loaded, the current user can drag one of the windows on his desktop to a user's icon on the tray menu. If a transfer to that icon is possible, the window will "zap back" to it's original location to indicate the operation. If he drops the window there it will be transferred to the other users desktop. BUG=305068 TEST=visual Review URL: https://codereview.chromium.org/27042003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228523 0039d316-1c4b-4281-b951-d872f2087c98
* Makes Env::is_mouse_button_down() query the native OS when appropriate.sky@chromium.org2013-10-141-0/+5
| | | | | | | | | | | | | | | | | | The problem with relying on the flags set in Env is on windows and linux non-chromeos not all events flow through the RootWindow. This means Env is not always upto date with the real state of the OS. I've made this so all tests continue to use existing behavior (state of Env matches that explicitly set), where as non-tests query the OS on windows (linux non-chromeos is TODO). BUG=306048 TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/26467004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228476 0039d316-1c4b-4281-b951-d872f2087c98
* Explicit initialization of aura::Env for browser shell.dnicoara@chromium.org2013-10-091-0/+1
| | | | | | | | | | | | | | | | | | Most implementations (x11 aura with and without chromeos) do not explicitly call aura::Env::GetInstance() to initialize it. These build work as is because the call is done when performing other operations, such as adding observers. In OZONE there are no such calls, so the OZONE build fails when trying to create a compositor since the Compositor::Initialize hasn't been called. This patch adds an explicit initialization for aura based builds to fix this issue. BUG= Review URL: https://codereview.chromium.org/23882007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227745 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "chromeos: Move several power-related classes to Ash"derat@chromium.org2013-10-092-0/+5
| | | | | | | | | | | | | | | | | | This reverts r227562 to reland r227544. Original description: "Move SuspendObserver, UserActivityNotifier, and VideoActivityNotifier from chrome/browser/chromeos/power to ash/system/chromeos/power." This iteration makes ash::Shell's destructor destroy VideoActivityNotifier before VideoDetector to avoid a use-after-free. BUG=none Review URL: https://codereview.chromium.org/26569003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227694 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r227544, "chromeos: Move several power-related ..."derat@chromium.org2013-10-082-5/+0
| | | | | | | | | | | This broke the ASAN builders. BUG=none TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/26561002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227562 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Move several power-related classes to Ash.derat@chromium.org2013-10-082-0/+5
| | | | | | | | | | | | Move SuspendObserver, UserActivityNotifier, and VideoActivityNotifier from chrome/browser/chromeos/power to ash/system/chromeos/power. BUG=none Review URL: https://codereview.chromium.org/25996007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227544 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary DEPS rule.jam@chromium.org2013-10-031-1/+0
| | | | | | | | R=sky@chromium.org Review URL: https://codereview.chromium.org/25676003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226756 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 226547 "Refactor LauncherItemController and LauncherItemD..."dcheng@chromium.org2013-10-026-167/+69
| | | | | | | | | | | | | | | | | | | | | | > Refactor LauncherItemController and LauncherItemDelegate > > * Remove LauncherItem parameter of LauncherItemDelegate method > * LauncherItemController subclasses LauncherItemDelegate > * Register/Unregister when LauncherItemDelegate is created/removed > * LauncherItemDelegateManager handles LauncherItemDelegate by LauncherID > * LauncherItemDelegateManager take ownership of all LauncherItemDelegate > > R=sky@chromium.org, skuhne@chromium.org > BUG=279105 > TEST=unit_tests, browser_tests, ash_unittests, ash_shell > > Review URL: https://codereview.chromium.org/23606016 TBR=simon.hong81@gmail.com Review URL: https://codereview.chromium.org/25716004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226580 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor LauncherItemController and LauncherItemDelegatesimon.hong81@gmail.com2013-10-026-69/+167
| | | | | | | | | | | | | | | | * Remove LauncherItem parameter of LauncherItemDelegate method * LauncherItemController subclasses LauncherItemDelegate * Register/Unregister when LauncherItemDelegate is created/removed * LauncherItemDelegateManager handles LauncherItemDelegate by LauncherID * LauncherItemDelegateManager take ownership of all LauncherItemDelegate R=sky@chromium.org, skuhne@chromium.org BUG=279105 TEST=unit_tests, browser_tests, ash_unittests, ash_shell Review URL: https://codereview.chromium.org/23606016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226547 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: merge separate implementaions of ScreenshotDelegate for tests.mukai@chromium.org2013-10-016-0/+109
| | | | | | | | | | BUG=None R=oshima@chromium.org TEST=ash_unittests Review URL: https://codereview.chromium.org/24257015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226118 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Ash accelerator OPEN_FILE_DIALOG; let Chrome handle it as IDC_OPEN_FILE.kinaba@chromium.org2013-10-012-2/+2
| | | | | | | | | | | | The Ctrl-O had once been handled as global shortcut, but now it is no-op when no browser is open. It can be moved back to browser shortcut, as it is handled in all other platforms than Chrome OS. BUG=301445, 251492 Review URL: https://codereview.chromium.org/25225002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226097 0039d316-1c4b-4281-b951-d872f2087c98
* Multi Profile: Adding hotkey to switch between logged in usersskuhne@chromium.org2013-09-262-0/+5
| | | | | | | | | BUG=296271 TEST=visual Review URL: https://codereview.chromium.org/23533078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225396 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-06 17:56:13 +0000