summaryrefslogtreecommitdiffstats
path: root/ash/wm/app_list_controller.cc
Commit message (Collapse)AuthorAgeFilesLines
* ash: Rename LauncherIconObserver to ShelfIconObserver.tfarina@chromium.org2013-10-301-2/+2
| | | | | | | | | | | | And moves from launcher/ to shelf/ directory. BUG=248353 TEST=None, no behavior changes. R=harrym@chromium.org,jamescook@chromium.org Review URL: https://codereview.chromium.org/45973003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231738 0039d316-1c4b-4281-b951-d872f2087c98
* Make GetRootWindow() return a Window instead of a RootWindow.ben@chromium.org2013-10-251-2/+2
| | | | | | | | | | | | Also adds a typedef from RootWindow to WindowEventDispatcher, the eventual name of this type. Adds a GetDispatcher() method that crawls up to the root Window and returns the WindowEventDispatcher. R=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/37733003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231077 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Fix app launcher closing on uninstall dialog.xiyuan@chromium.org2013-10-041-6/+8
| | | | | | | | | | BUG=303267,276513 TEST=Covered by AppListControllerTest.* R=flackr@chromium.org, jamescook@chromium.org Review URL: https://codereview.chromium.org/25708010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226942 0039d316-1c4b-4281-b951-d872f2087c98
* Losing focus should hide app list.flackr@chromium.org2013-10-011-4/+4
| | | | | | | | | BUG=276513 TEST=WindowSelectorTest.SelectingHidesAppList Review URL: https://codereview.chromium.org/25260004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226322 0039d316-1c4b-4281-b951-d872f2087c98
* Moves ui/base/events to ui/eventssky@chromium.org2013-09-181-1/+1
| | | | | | | | | | | BUG=none TEST=none R=ben@chromium.org TBR=brettw@chromium.org, scherkus@chromium.org, ananta@chromium.org, Review URL: https://codereview.chromium.org/23851041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223906 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing problem of app list showing up in wrong location on second screenskuhne@chromium.org2013-09-141-1/+7
| | | | | | | | | BUG=288725 TEST=visual Review URL: https://chromiumcodereview.appspot.com/23440036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223238 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing problem where opening a menu while closing another can close the new ↵skuhne@chromium.org2013-09-121-0/+7
| | | | | | | | | | | | | | | | menu unexpectedly The problem was as follows: When the app list menu gets closed it gets closed delayed. The right click menu opens. Once the menu got animated out, it will destruct itself. When doing so it will surrender its activation state to the system and the menu controller will close all menus. To avoid this I remove the activation state before the app list gets destroyed. (At that point in time it is not active anymore anyways). I also tried to set the focus in the menu runner on its parent - but that widget is not activatable and that does not work. BUG=285785 TEST=visual Review URL: https://chromiumcodereview.appspot.com/23457008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222868 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] Update applist button status when applist is hiding by outside event ofsimon.hong81@gmail.com2013-09-101-0/+2
| | | | | | | | | | | | applist button. R=harrym@chromium.org BUG=287593 TEST=Compiles, Visual test Review URL: https://chromiumcodereview.appspot.com/23526030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222215 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing the dynamic positioning (move with anchor) for the app launcherskuhne@chromium.org2013-09-101-34/+22
| | | | | | | | | | | The problem was that the positioning was done before it was shown and the move_with_anchor didn't work since there was no anchor. Changed it now to use an anchor offset. BUG=284780 TEST=unittest (partial), visually [(RTL and LTR) x (left, right, bottom aligned) x (always visible, sliding into view, hidden)] Review URL: https://chromiumcodereview.appspot.com/23622020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222191 0039d316-1c4b-4281-b951-d872f2087c98
* Move GetRootWindowController to root_window_controller.hoshima@chromium.org2013-09-061-1/+0
| | | | | | | | | | Remove unnecessary includes, forward decls BUG=272460 Review URL: https://chromiumcodereview.appspot.com/24020002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221605 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] Enable drag and drop support in all visible app listsimon.hong81@gmail.com2013-08-071-3/+11
| | | | | | | | | | | | | | | | Motivation of this CL: Only app list shown by clicking app list button enables drag and drop from app list to launcher because dnd host is only set by app list button click. Other behaviors such as webapp installing from web store or accelerator show app list, too. DnD feature also should be enabled with these cases. R=skuhne@chromium.org BUG=267410 TEST=Manual test Review URL: https://chromiumcodereview.appspot.com/21765002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216265 0039d316-1c4b-4281-b951-d872f2087c98
* More left / right adjustments for for message bubbles, the appmenu and the ↵skuhne@chromium.org2013-07-281-1/+1
| | | | | | | | | | | | | tray menu A couple of pixels offset. BUG=264227 TEST=visual Review URL: https://chromiumcodereview.appspot.com/20487002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214091 0039d316-1c4b-4281-b951-d872f2087c98
* The new alternate shelf requests that all tray / message bubbles / ↵skuhne@chromium.org2013-07-241-9/+52
| | | | | | | | | | | | | application launcher will be flush with the shelf There is one edge case left for a rotated shelf: Messages are slightly offsetted from the system menu (if existent). Beside that everything seems to work now as expected. BUG=259029 TEST=visual with L/R languages and with different shelf alignments Review URL: https://chromiumcodereview.appspot.com/19771021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213500 0039d316-1c4b-4281-b951-d872f2087c98
* Dismiss context menus in app list on scroll.koz@chromium.org2013-07-151-0/+3
| | | | | | | | | BUG=257000 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/18668002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211626 0039d316-1c4b-4281-b951-d872f2087c98
* App list icon changesharrym@chromium.org2013-07-021-7/+25
| | | | | | | | | | Create a separate flow for the app list icon (behind alternate-shelf-layout flag) whereby the app list icon has different state indication (background images), can be reordered, and defaults to be the first item in the launcher. BUG=244994 Review URL: https://chromiumcodereview.appspot.com/16831018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209556 0039d316-1c4b-4281-b951-d872f2087c98
* Turn off the tip for the sytem tray menu and the app list (ChromeOS).skuhne@chromium.org2013-06-161-0/+3
| | | | | | | | | BUG=245016 TEST=visual Review URL: https://chromiumcodereview.appspot.com/16909006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206628 0039d316-1c4b-4281-b951-d872f2087c98
* Rename RootWindowObserver::OnRootWindowResized to OnRootWindowHostResized, andoshima@chromium.org2013-06-121-5/+6
| | | | | | | | | | | | | | | RootWindowObserver::OnRootWindowMoved to OnRootWindowHostMoved - Changed so that this is called only when host window's size is changed. - Remove old argument as it was RootWindow's size but not HostWindow's, and it's not used. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/16410015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205706 0039d316-1c4b-4281-b951-d872f2087c98
* This is the first of two patches to drag and drop items from the app list to ↵skuhne@chromium.org2013-05-081-0/+6
| | | | | | | | | | | | | | | | | | | the launcher. Everything basically works with this patch, but two essential things are still missing: 1. The icon which gets dragged should get its own widget so that it can get visually dragged outside the app list. 2. The unit tests. They will be send as a second patch because of: a. The patch is already pretty big as it is. b. I want to make get this "signed off" before continuing this route. BUG=166429 TEST=visual, tests come with second patch Review URL: https://chromiumcodereview.appspot.com/14533006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199016 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 197366 "ash: Update app list button."xiyuan@chromium.org2013-05-061-46/+15
| | | | | | | | | | | | | | | | | | | | | | | > ash: Update app list button. > > - Update the icons assets; > - Make app list button a ToggleImageButton and wire its > toggle state with app list UI visibility; > - Make app list button icon vertically center aligned and > get rid of the special handling; > - Expose toggled state from ToggleImageButton so that it > could be checked in test; > > BUG=235994 > R=sky@chromium.org > > Review URL: https://codereview.chromium.org/13993027 TBR=jamescook@chromium.org Review URL: https://codereview.chromium.org/14863006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198478 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Update app list button.xiyuan@chromium.org2013-04-301-15/+46
| | | | | | | | | | | | | | | | | - Update the icons assets; - Make app list button a ToggleImageButton and wire its toggle state with app list UI visibility; - Make app list button icon vertically center aligned and get rid of the special handling; - Expose toggled state from ToggleImageButton so that it could be checked in test; BUG=235994 R=sky@chromium.org Review URL: https://codereview.chromium.org/13993027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197366 0039d316-1c4b-4281-b951-d872f2087c98
* Rename BubbleBorder::ArrowLocation to Arrow; etc.msw@chromium.org2013-04-111-7/+4
| | | | | | | | | | | | | | | | Rename ArrowLocation and ArrowLocationMask for brevity. Rename accessors and identifiers to match. Inline the only use of GetInsetsForArrowLocation. Rewrite is_arrow_on_[left|top] as one-liners. Combine previously too-long lines; Minor other cleanup. BUG=None (cleanup) TEST=None; unit tests and no bubble regressions. TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/14105005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193615 0039d316-1c4b-4281-b951-d872f2087c98
* Hide the app menu when hiding the launchermohsen@chromium.org2013-03-141-1/+1
| | | | | | | | | | | | | When the app menu is open, swiping the launcher to hide it should close the app menu first. It is not reasonable to show the app menu when there is no launcher visible. BUG=170900 Review URL: https://chromiumcodereview.appspot.com/12622010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188064 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor: Shelf Widgetharrym@chromium.org2013-03-091-2/+3
| | | | | | | | | | | Refactor the classes related with displaying the shelf (background behind the launcher/status area widget) to be a separate class. Removing background delegates from the launcher and status area widget (represented on tray views). TBR=ben@chromium.org BUG=163002 Review URL: https://chromiumcodereview.appspot.com/12313118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187122 0039d316-1c4b-4281-b951-d872f2087c98
* [win] Make app launcher border not steal mouse clicksbenwells@chromium.org2013-02-281-1/+2
| | | | | | | | | | | Now clicking on the shadowy bit will go through to whatever is underneath. TBR=sky for trivial ash change BUG=166975, 170073 Review URL: https://chromiumcodereview.appspot.com/12335124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185097 0039d316-1c4b-4281-b951-d872f2087c98
* Add synchronous Widget closing eventwittman@chromium.org2013-02-051-1/+1
| | | | | | | | | | | | | | | | | | | | | Adds a WidgetObserver event that is guaranteed to be invoked synchronously when a Widget is requested to close. Rename the existing event, which is invoked at Widget destruction time, typically via a task on the event loop, to OnWidgetDestroying. The new event will be used in Views-specific WebContentsModalDialogManager functionality to get close events for Widgets, so that we don't risk adverse interleaving of Widget close events with other relevant events (e.g. IPC). This will allow us to avoids test flakiness observed in https://codereview.chromium.org/12045037 due to event races in PrintPreviewTest.PrintCommands BUG=157161 Review URL: https://chromiumcodereview.appspot.com/12089061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180796 0039d316-1c4b-4281-b951-d872f2087c98
* Add option to align launcher/shelf to top of screen (similar to left/right ↵harrym@chromium.org2013-01-121-3/+4
| | | | | | | | | | | align). BUG=159770 Review URL: https://chromiumcodereview.appspot.com/11885007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176556 0039d316-1c4b-4281-b951-d872f2087c98
* Skeleton for app_list on OSX, and refactoring for enable_app_list=1 on ↵tapted@chromium.org2013-01-101-1/+1
| | | | | | | | | | | | | | | | | | | | OS=="mac". Moves ui/app_list code specific to toolkit-views to ui/app_list/views. Update gyp[i], include guards, #includes for moved files. Seed chrome/browser/ui/cocoa/app_list and ui/app_list/cocoa with a skeleton Cocoa UI. BUG=138633 TEST=Mostly build changes. Functionality of AppLauncher on ChromeOS and Windows should be unchanged. On OSX, without chrome running, `Chromium.app/Contents/MacOS/Chromium --show-app-list` should show a borderless gray window for 1 second (note: this is for testing only -- OSX needs a different approach for IPC). Review URL: https://chromiumcodereview.appspot.com/11784034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176042 0039d316-1c4b-4281-b951-d872f2087c98
* events: Update mouse-event handlers to not return EventResult.sadrul@chromium.org2012-12-181-2/+1
| | | | | | | | | | This is the last step. Once this is done, we can possibly hide EventResult. BUG=163618 Review URL: https://codereview.chromium.org/11592011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173653 0039d316-1c4b-4281-b951-d872f2087c98
* Enables storing shelf's auto_hide_behavior and alignment per display.mukai@chromium.org2012-12-171-1/+1
| | | | | | | | | BUG=165419 TEST=on a dev-mode device, change the launcher's auto-hide behavior and see how it's stored in Preferences Review URL: https://codereview.chromium.org/11570017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173508 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a bunch of stuff related to Focus/Activation events. ben@chromium.org2012-12-121-2/+1
| | | | | | | | | http://crbug.com/162100 R=sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172624 Review URL: https://codereview.chromium.org/11537019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172674 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 172624 - Remove a bunch of stuff related to Focus/Activation events.ben@chromium.org2012-12-121-1/+2
| | | | | | | | | | | http://crbug.com/162100 R=sadrul@chromium.org Review URL: https://codereview.chromium.org/11537019 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/11558027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172646 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a bunch of stuff related to Focus/Activation events.ben@chromium.org2012-12-121-2/+1
| | | | | | | | http://crbug.com/162100 R=sadrul@chromium.org Review URL: https://codereview.chromium.org/11537019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172624 0039d316-1c4b-4281-b951-d872f2087c98
* - Show app list on 2nd launcheroshima@chromium.org2012-12-111-14/+12
| | | | | | | | | | | | | | | | - Share the launcher mode/delegate in multiple launchers. This CL moves the launcher mode/delegate to Shell - Initialize Display objects before creating RootWindow for 2nd as it'll be used during creation. I'll add tests in next CL, as it crashes without https://codereview.chromium.org/11515004/. BUG=145978 TEST=none Review URL: https://chromiumcodereview.appspot.com/11465037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172310 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidates activation and focus change observers a bit.ben@chromium.org2012-12-111-3/+5
| | | | | | | | | | | | | | Focus observation @ target -> FocusChangeObserver set on target instead of WindowDelegate methods. Activation observation @ target -> ActivationChangeObserver set on target instead of ActivationDelegate methods. Changes FocusChange notifications to be sent regardless of whether or not focus is being cleared. Changes signature of both observers to carry gaining and losing focus/activation. http://crbug.com/162100 R=sky@chromium.org Review URL: https://codereview.chromium.org/11490015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172258 0039d316-1c4b-4281-b951-d872f2087c98
* app_list: Improve initial icon loading.xiyuan@chromium.org2012-12-051-14/+9
| | | | | | | | | | | | | | | | - Creates and populates AppListModel and starts icon loading for current page apps before creating views; - Shows UI when all icons are loaded or a maximum wait time has passed (currently 50ms); BUG=161025 TEST=Bring up app launcher and the app icons should not flash. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11418312 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171299 0039d316-1c4b-4281-b951-d872f2087c98
* Use the correct launcher assets for shelf alignment.oshima@chromium.org2012-12-051-13/+5
| | | | | | | | | | | | | | | Cleanup: remove redundant shelf code. - replaces switch to get values for alignment with template - eliminate alignment member variables and use shelf_layout_manager where possible. other minor clean ups: remove unnecessary namespace, use member variable. BUG=151417 TEST=none Review URL: https://chromiumcodereview.appspot.com/11434099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171120 0039d316-1c4b-4281-b951-d872f2087c98
* events: Change gesture-event handler in EventHandler to not return any values.sadrul@chromium.org2012-12-041-2/+1
| | | | | | | | | | | | | The EventHandler overriddes should mark the event as having been processed (Event::SetHandled) when the event triggered an action, or stop the propagation of the event (Event::StopPropagation) as appropriate (when the handler destroyed the event-target, for example). BUG=163618 Review URL: https://codereview.chromium.org/11280290 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170890 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the FocusController behind a flag.ben@chromium.org2012-12-031-1/+2
| | | | | | | | http://crbug.com/162100 R=sky@chromium.org Review URL: https://codereview.chromium.org/11421194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170752 0039d316-1c4b-4281-b951-d872f2087c98
* Rework FocusManager as FocusClient.ben@chromium.org2012-11-281-3/+3
| | | | | | | | | | This allows us to have multiple focus system implementations. http://crbug.com/162100 R=sky@chromium.org Review URL: https://codereview.chromium.org/11299219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169824 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Add default implementations for EventHandler interface.sadrul@chromium.org2012-11-201-12/+0
| | | | | | | | | | | | This allows getting rid of a whole bunch of noop implementations, and makes it easier to add new event types to be dispatched through the EventDispatcher to EventHandlers. BUG=159632 Review URL: https://codereview.chromium.org/11348145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168817 0039d316-1c4b-4281-b951-d872f2087c98
* app_list: Make over scroll animation faster.xiyuan@chromium.org2012-11-151-8/+8
| | | | | | | | | | | | | | | | | | | | | | - Add an over scroll animation duration of 50ms; - Use the over scroll animation duration for transition to invalid page (i.e. over scroll); This was using normal page transition duration of 180ms before. - Use the same duration for snap back animation; This was 100ms and now changed to 50ms. Also fixed a bug that app launcher bubble moves to wrong location if starting an over scroll before previous over scroll snap back animation finishes. BUG=160590 TEST=Verify over scroll animation is fast enough. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11275320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167784 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Convert some aura::EventFilters into ui::EventHandlers.sadrul@chromium.org2012-11-121-19/+17
| | | | | | | | | | | | | | | | | In this CL, the following EventFilters are converted into EventHandlers: * AcceleratorFilter * MagnificationControllerImpl * TrayEventFilter * TouchObserverHUD * AppListController * ShelfLayoutManager::AutoHideEventFilter * SystemGestureEventFilter BUG=159632 Review URL: https://codereview.chromium.org/11362196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167218 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Remove TouchStatus in favour of EventResult.sadrul@chromium.org2012-11-041-2/+2
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/11364062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165877 0039d316-1c4b-4281-b951-d872f2087c98
* Animation changed to fade out on Launcher related bubbles.harrym@chromium.org2012-10-311-1/+2
| | | | | | | | | BUG=137285 Review URL: https://chromiumcodereview.appspot.com/11341034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165221 0039d316-1c4b-4281-b951-d872f2087c98
* Context menu for multiple launchersoshima@chromium.org2012-10-231-9/+18
| | | | | | | | | | | | | - move the code to create/open context menu from launcher to root window controller. - updated methods that access shelf/launcher state to take root window so that menu can specify on which display it is working on. BUG=145978, 155776 TEST=none Review URL: https://chromiumcodereview.appspot.com/11198078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163459 0039d316-1c4b-4281-b951-d872f2087c98
* cros: Respect app list hit test mask in ProcessLocatedEvent.xiyuan@chromium.org2012-10-181-4/+7
| | | | | | | | | | | | BUG=156497 TEST=Click/touch right below app list (i.e. in the shadow area) should close it. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11194056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162835 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Shell::shelf|status_area_widget|launcher andoshima@chromium.org2012-10-181-4/+4
| | | | | | | | | | | updated all clients to use one on RootWindowController and/or Launcher::ForPrimaryDisplay/ForWindow. BUG=145978 Review URL: https://chromiumcodereview.appspot.com/11017079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162664 0039d316-1c4b-4281-b951-d872f2087c98
* cros: Use screen coordinates for app list animation.xiyuan@chromium.org2012-10-031-10/+11
| | | | | | | | | | | | BUG=150656 TEST=Verify app list bubble is at the right location on all desktops. R=oshima@chromium.org Review URL: https://chromiumcodereview.appspot.com/10996066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159804 0039d316-1c4b-4281-b951-d872f2087c98
* cros: Fix app list bubble over-scroll at wrong position with hidden launcher.xiyuan@chromium.org2012-09-211-4/+5
| | | | | | | | | | | | | | | | This is because cached bubble bounds |view_bounds_| at bubble creation time might not be correct when launcher is hidden and the bubble moves when launcher shows up. The fix is to defer getting the bubble location until first over-scroll movement. BUG=150851 TEST=Verify app list bubble at expected location when over-scrolling with hidden launcher. R=sky@chromium.org Review URL: https://codereview.chromium.org/10967021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158007 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate bubble border code.xiyuan@chromium.org2012-09-211-4/+4
| | | | | | | | | | | | | | | | Per 135200, we should only use image based code. - Add two new sets of bubble border images; - Use the new bubble border images for app menu and launcher tooltip; - Get rid of BubbleBorder2 since it's no longer needed; BUG=135200 TEST=Verify app list, launcher bar tooltip bubbles use shadow based on image and no artifacts. R=msw@chromium.org,sky@chromium.org,oshima@chromium.org Review URL: https://codereview.chromium.org/10905311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158003 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-18 23:20:12 +0000