summaryrefslogtreecommitdiffstats
path: root/ash/wm
Commit message (Collapse)AuthorAgeFilesLines
* Port ScopedDisableInternalMouseAndKeyboardX11 to Ozonepkotwicz2015-01-143-0/+77
| | | | | | | | | BUG=401598 TEST=Manual, see bug Review URL: https://codereview.chromium.org/806693009 Cr-Commit-Position: refs/heads/master@{#311505}
* Change AccelerometerReader to a Singletonjonross2015-01-132-4/+4
| | | | | | | | | | | | | On ChromeOS the accelerometer needs to be read by both ash/ and content/ This change removes the ownership of AccelerometerReader from Shell, changing it into a Singleton. TEST=Confirmed that a device with an accelerometer enters maximize mode. BUG=342908 Review URL: https://codereview.chromium.org/822503003 Cr-Commit-Position: refs/heads/master@{#311353}
* This change renames ScreenOrientationDelegate to ScreenOrientationController ↵jonross2015-01-133-603/+30
| | | | | | | | | | | | | | | | | | | to reflect on the new responsibilities that it is assuming. The tracking of the accelerometer screen rotation, as well as the rotation lock, has been moved from MaximizeModeController to ScreenOrientationController. ScreenOrientationController is now responsible for all rotation lock requests, from both TouchView user interface controls, as well as the Screen Orientation JavaScript API. ScreenOrientationController is Chrome OS only. Classes using the rotation lock API have been updated to only do so on Chrome OS. Screen rotation tests have been moved from MaximizeModeControllerTest to ScreenOrientationControllerTest. Other unittests have been updated to reflect the Chrome OS change. All pre-existing tests for rotation behaviour have been ran. Manual testing of both TouchView and Screen Orientation API have been done. TEST=ScreenOrientationControllerTest, TrayRotationLockTest, MaximizeModeControllerTest, DisplayPreferencesTest BUG=396760 Review URL: https://codereview.chromium.org/759063002 Cr-Commit-Position: refs/heads/master@{#311299}
* System modal dialog unhide shelf launcher, and prevents going into maximized ↵afakhry2015-01-127-34/+151
| | | | | | | | | | | | | | | | | | | | | | | | mode. When shelf is auto hidden, displaying a system modal dialog used to unhide it. That was because the ShelfLayoutManager when updating the shelf visibility, it used to ask the MruWindowTracker to build a list of the windows. This list used to exclude the unfocusable windows (due to the system modal dialog), So the returned list used to be empty which means the shelf should be unhidden. We actually need the list of all visible windows regardless of their focusability. Two unit tests has been written to validate the correct behavior in both single and dual display modes. BUG=277893, 447720 TEST=ash_unittests --gtest_filter=ShelfLayoutManagerTest.ShelfWithSystemModalWindowSingleDisplay, ShelfLayoutManagerTest.ShelfWithSystemModalWindowDualDisplay, MaximizeModeWindowManagerTest.GoingToMaximizedWithModalDialogPresent Review URL: https://codereview.chromium.org/780113002 Cr-Commit-Position: refs/heads/master@{#311063}
* cros: Increase lock timeout for daisy.xiyuan2015-01-071-3/+3
| | | | | | | | | | | - Increase lock timeout for daisy; - CHECK(false) -> LOG(FATAL) so that the log shows up; BUG=445226 Review URL: https://codereview.chromium.org/843553002 Cr-Commit-Position: refs/heads/master@{#310405}
* Fixes smart deploy causing crash on shutdown.rsadam2015-01-071-0/+2
| | | | | | | | | | | | | | Moves the destruction of the Virtual Keyboard Controller before the Maximized Mode Controller so that re-enabling the internal keyboard when leaving touchview due to shutdown does not cause the on-screen keyboard to change state. BUG=446204 TEST=VirtualKeyboardControllerTest.RestoreKeyboardDevices Review URL: https://codereview.chromium.org/834163002 Cr-Commit-Position: refs/heads/master@{#310316}
* Use template specialization to generate WindowProperty code.oshima2015-01-072-4/+0
| | | | | | | | | | | | | | They used to be a inlined function in the header, which led to code generation when method is used. This changes the code generation only in DECLARE_WINDOW_PROPERTY_TYPE(). BUG=None R=sadrul@chromium.org Committed: https://crrev.com/f62e152bb7a13135a597d9766eb79551d3a24a73 Cr-Commit-Position: refs/heads/master@{#309252} Review URL: https://codereview.chromium.org/801953002 Cr-Commit-Position: refs/heads/master@{#310179}
* Standardize usage of virtual/override/final specifiers in ash/.dcheng2014-12-223-7/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. Several formatting edits by clang-format were manually reverted, due to mangling of some of the more complicate IPC macros. BUG=417463 Review URL: https://codereview.chromium.org/817393002 Cr-Commit-Position: refs/heads/master@{#309477}
* Fix references to ui/gfx headers in a*/.Avi Drissman2014-12-2241-47/+47
| | | | | | | | | | BUG=444596 TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/802473003 Cr-Commit-Position: refs/heads/master@{#309448}
* Set capture to the window being dragged when dragging a window on Ashpkotwicz2014-12-202-40/+18
| | | | | | | | | | | | | | | | | | | This CL sets capture to the window being dragged when dragging a window on Ash. This allows state to be reset when a user opens the Ctrl+Alt+Delete dialog on Windows Ash. As a side effect, this CL fixes dragging windows from one screen to another on ChromeOS ozone. Dragging windows from one screen to another worked on X11 because X11 does an implicit grab when the mouse is pressed. This implicit grab guarantees that events are sent to WindowTreeHost where the drag started for the duration of the drag. BUG=439703, 423383 TEST=None Review URL: https://codereview.chromium.org/778043004 Cr-Commit-Position: refs/heads/master@{#309364}
* Revert of Use template specialization to generate WindowProperty code ↵chirantan2014-12-192-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #8 id:330001 of https://codereview.chromium.org/801953002/) Reason for revert: This is breaking chrome on chrome os builds: In file included from ../../ui/aura/client/screen_position_client.cc:7:0: ../../ui/aura/window_property.h:115:58: error: specialization of 'template<class T> void aura::Window::SetProperty(const aura::WindowProperty<T>*, T)' in different namespace [-fpermissive] const aura::WindowProperty<T >* property, T value) { \ ^ ../../ui/aura/window_property.h:127:5: note: in expansion of macro 'DECLARE_EXPORTED_WINDOW_PROPERTY_TYPE' DECLARE_EXPORTED_WINDOW_PROPERTY_TYPE(, T) ^ ../../ui/aura/client/screen_position_client.cc:9:1: note: in expansion of macro 'DECLARE_WINDOW_PROPERTY_TYPE' DECLARE_WINDOW_PROPERTY_TYPE(aura::client::ScreenPositionClient*) ^ In file included from ../../ui/aura/client/screen_position_client.h:9:0, from ../../ui/aura/client/screen_position_client.cc:5: ../../ui/aura/window.h:297:8: error: from definition of 'template<class T> void aura::Window::SetProperty(const aura::WindowProperty<T>*, T)' [-fpermissive] void SetProperty(const WindowProperty<T>* property, T value); ^ Original issue's description: > Use template specialization to generate WindowProperty code. > > They used to be a inlined function in the header, which led to code generation when method is used. This changes the code generation only in DECLARE_WINDOW_PROPERTY_TYPE(). > > BUG=None > R=sadrul@chromium.org > > Committed: https://crrev.com/f62e152bb7a13135a597d9766eb79551d3a24a73 > Cr-Commit-Position: refs/heads/master@{#309252} TBR=sadrul@chromium.org,sky@chromium.org,oshima@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Seems like nobody is around. LGTM. I'm broken by this as well. Review URL: https://codereview.chromium.org/814313002 Cr-Commit-Position: refs/heads/master@{#309285}
* Use template specialization to generate WindowProperty code.oshima2014-12-192-4/+0
| | | | | | | | | | | They used to be a inlined function in the header, which led to code generation when method is used. This changes the code generation only in DECLARE_WINDOW_PROPERTY_TYPE(). BUG=None R=sadrul@chromium.org Review URL: https://codereview.chromium.org/801953002 Cr-Commit-Position: refs/heads/master@{#309252}
* Consolidated WindowSelector(Window|Panel) into WindowSelectorItem.bruthig2014-12-1917-848/+999
| | | | | | | | | BUG=393668 TEST=WindowSelectorTest.PanelStackOrdering, WindowSelectorTest.CloseButtonOnMultipleDisplay Review URL: https://codereview.chromium.org/709563002 Cr-Commit-Position: refs/heads/master@{#309239}
* Refactor AccelerometerReader to provide an Observerjonross2014-12-193-52/+37
| | | | | | | | | | | | | Change chromeos::AccelerometerReader from using a single delegate, to using observers. We need to begin listening to it from both ash/ and content/ Removed the abstraction ash::AccelerometerController, and updated all locations to use the reader directly. TEST=MaximizeModeControllerTes BUG=431865 Review URL: https://codereview.chromium.org/795333002 Cr-Commit-Position: refs/heads/master@{#309219}
* Refactor partial screenshot region selector (2nd)mukai2014-12-184-445/+0
| | | | | | | | | | | | | | | | | | | | | | | | This is the reland of crrev.com/308508 which was reverted due to a failure of valgrind bot. Previously PartialScreenshotView is a view inside of a frameless window, which is actually problematic because it needs to deal with several window manager concepts such like mouse captures and activations. This is now built with ui::Layer and EventHandler, therefore it makes no effects. Also this CL moves the file location to a new directory ash/utility, because this is nothing related to the window manager. BUG=330348 R=oshima@chromium.org TEST=the new test covers with valgrind bot Review URL: https://codereview.chromium.org/813523002 Cr-Commit-Position: refs/heads/master@{#308942}
* Allows OnAppTerminating at AshTestBase::TearDown().mukai2014-12-174-11/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adding OnAppTerminating causes some failures. This CL also includes the fixes for them. OverlayEventFilterTest.CancelAtActivating: - OverlayEventFilter::Cancel() is called, but that does not cleanup |delegate_|, therefore further OnAppTerminating() invokes Cancel() to already canceled delegate_. PartialScreenshotViewTest.DontStartOverOverlay: - delegate should be deactivated before it's removed. RootWindowControllerTest.DontDeleteWindowsNotOwnedByParent: - this test case explicitly invokes CloseAllChildWindows(), therefore it cleans up all of the containers. - SessionStateAnimatorImpl assumed containers still exist when OnAppTerminating() is invoked. WindowManagerTest.TestCursorClientObserver: - observer_a is added to cursor_manager, but not destructed without calling RemoveObserver(). BUG=None R=oshima@chromium.org TEST=ash_unittests Review URL: https://codereview.chromium.org/809603008 Cr-Commit-Position: refs/heads/master@{#308772}
* Add device policy to disallow shutdowncschuet2014-12-164-17/+36
| | | | | | | | | | | This CL introduces a new boolean device policy kDeviceShutdownIsReboot. BUG=312541 TESTS=unit_tests Review URL: https://codereview.chromium.org/776093004 Cr-Commit-Position: refs/heads/master@{#308624}
* Revert of Refactor partial screenshot region selector. (patchset #3 id:40001 ↵mukai2014-12-164-0/+443
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/805793004/) Reason for revert: valgrind failure: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%283%29/builds/35270/steps/memory%20test%3A%20ash_unittests/logs/stdio Original issue's description: > Refactor partial screenshot region selector. > > Previously PartialScreenshotView is a view inside of a frameless > window, which is actually problematic because it needs to deal > with several window manager concepts such like mouse captures > and activations. > > This is now built with ui::Layer and EventHandler, therefore > it makes no effects. > > Also this CL moves the file location to a new directory > ash/utility, because this is nothing related to the window manager. > > BUG=330348 > R=oshima@chromium.org > TEST=the new test covers. > > Committed: https://crrev.com/9a0e3f0b67e057451570cfb254cbf76135d59768 > Cr-Commit-Position: refs/heads/master@{#308508} TBR=oshima@chromium.org NOTREECHECKS=true NOTRY=true BUG=330348 Review URL: https://codereview.chromium.org/808693003 Cr-Commit-Position: refs/heads/master@{#308531}
* Refactor partial screenshot region selector.mukai2014-12-164-443/+0
| | | | | | | | | | | | | | | | | | | | | Previously PartialScreenshotView is a view inside of a frameless window, which is actually problematic because it needs to deal with several window manager concepts such like mouse captures and activations. This is now built with ui::Layer and EventHandler, therefore it makes no effects. Also this CL moves the file location to a new directory ash/utility, because this is nothing related to the window manager. BUG=330348 R=oshima@chromium.org TEST=the new test covers. Review URL: https://codereview.chromium.org/805793004 Cr-Commit-Position: refs/heads/master@{#308508}
* Dismiss the multi window resizer when the user clicks outside of the multipkotwicz2014-12-154-7/+48
| | | | | | | | | | | window resizer BUG=437125 TEST=MultiWindowResizeController.ClickOutside Review URL: https://codereview.chromium.org/753933003 Cr-Commit-Position: refs/heads/master@{#308402}
* [Reland] Remove check for native events in ↵pkotwicz2014-12-111-8/+3
| | | | | | | | | | | | SystemGestureEventFilter::OnMouseEvent() BUG=401590 TEST=None TBR=sadrul Review URL: https://codereview.chromium.org/797713002 Cr-Commit-Position: refs/heads/master@{#307969}
* Revert of Remove check for native events in ↵jam2014-12-111-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | SystemGestureEventFilter::OnMouseEvent() (patchset #1 id:20001 of https://codereview.chromium.org/784233002/) Reason for revert: broke ozone build: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/8366/steps/compile/logs/stdio Original issue's description: > Remove check for native events in SystemGestureEventFilter::OnMouseEvent() > > BUG=401590 > TEST=None > > Committed: https://crrev.com/d2b68827125a71539cbe2ba56eb63aed7c6630e2 > Cr-Commit-Position: refs/heads/master@{#307913} TBR=sadrul@chromium.org,pkotwicz@chromium.org NOTREECHECKS=true NOTRY=true BUG=401590 Review URL: https://codereview.chromium.org/801433002 Cr-Commit-Position: refs/heads/master@{#307921}
* Remove check for native events in SystemGestureEventFilter::OnMouseEvent()pkotwicz2014-12-111-4/+3
| | | | | | | | | BUG=401590 TEST=None Review URL: https://codereview.chromium.org/784233002 Cr-Commit-Position: refs/heads/master@{#307913}
* Cleaning up MruWindowTracker::BuildWindowList()afakhry2014-12-105-24/+14
| | | | | | | | | | | | | | | | | | | Removing the top_most_at_end parameter which was always set to false and was never used. The previous CL (https://codereview.chromium.org/752253002) was reverted as it caused ash_unittests to fail on Windows: http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(1) http://build.chromium.org/p/chromium.win/builders/Win8%20Aura This is a retry, but we keep reversing the windows list after we build it. R=oshima@chromium.org BUG=None Review URL: https://codereview.chromium.org/785273002 Cr-Commit-Position: refs/heads/master@{#307593}
* [Reland] Improve the logic for hiding the multi-window resize handlepkotwicz2014-12-093-82/+194
| | | | | | | | | | | | | | | | Improvements: - The resize handle no longer hides when a user moves the mouse along the shared window edge - The resize handle no longer hides when a user moves the mouse over the resize shadow - Removed call to redundant MultiWindowResizeController::DelayedHide() BUG=None TEST=MultiWindowResizeControllerTest.IsOverWindows Review URL: https://codereview.chromium.org/774983004 Cr-Commit-Position: refs/heads/master@{#307551}
* The WorkspaceLayoutManager responsible for ordering windows in the always on toprsadam2014-12-093-19/+119
| | | | | | | | | | | | | | | container was not being added as a KeyboardObserver. This change refactors the always_on_top_controller to give easier access to the layout manager, and adds this layout manager as a listener to KeyboardBoundsChanging events. BUG=423658 TEST=VirtualKeyboardAlwaysOnTopControllerTest.NotifyKeyboardBoundsChanged Review URL: https://codereview.chromium.org/780433004 Cr-Commit-Position: refs/heads/master@{#307532}
* Do not forward input events to Widget during Widget destructiontdanderson2014-12-081-0/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Set the target handler of an aura::Window to null early in the Window destructor to stop input events from being forwarded to the hosted views::Widget since its event processor (RootView) may have already been destroyed. Furthermore, check for a null RootView in TouchUMA::FindGestureActionType() since this code may be reached during the pretarget phase of event processing at the same time the widget is being destroyed, in which case its root view will have already been destroyed. BUG=430582 TEST=WindowSelectorTest.ClickOnWindowDuringTouch, WindowTest.NoCrashOnWindowDelete, WindowTest.MouseEnterExitWithWindowAppearAndDelete, WindowTest.MouseEnterExitWithParentDelete, WindowTest.MouseEventsOnLeafWindowChange, WindowTest.MouseEventsOnNonLeafWindowDelete, WidgetTest.NoCrashOnWidgetDelete, WidgetTest.NoCrashOnWidgetDeleteWithPendingEvents Review URL: https://codereview.chromium.org/753623005 Cr-Commit-Position: refs/heads/master@{#307338}
* Revert of Cleaning up MruWindowTracker::BuildWindowList() (patchset #1 id:1 ↵gab2014-12-085-17/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/786513003/) Reason for revert: I don't see why this would cause any problems, it looks like a purely aesthetic, yet this is the only Ash related CL in the regression range [1] for ever-failing Win8 Aura [2] and Win7(dbg) ash_unittests since these commits. (the test failures seem to be timing out with no output, weird... I'll check this back in if the revert doesn't help...) [1] https://chromium.googlesource.com/chromium/src/+log/8e72e1d6c13fa6a4cf2859ac6e209be4546bb50d..00df169a990ea09d488f1c13ec0293fc11d7992e?pretty=fuller [2]http://build.chromium.org/p/chromium.win/builders/Win8%20Aura Failing tests: ToggleMinimized WindowDockLeftMinimizeWindowWithRestore WindowPanelDockLeftDockRightRestore WindowSnapLeftDockLeftRestore WindowSnapLeftDockLeftSnapRight WindowSnapRightDockRightRestore EventsDoNotLeakToWindowUnderneath Basic MinimizedWindowsAreLru GestureSwipe SwipeUpDownWithoutReleasing VerticalSwipes PanelsHideAndRestoreWithShelf AcceleratorsWithFullscreen WorkAreaChangeWorkspace AlwaysOnTopMultiWindow AlwaysOnTopWindow CycleMruPanelDestroyed CyclePanels CyclePanelsDestroyed HandleCycleWindow MaximizedWindow MostRecentlyUsed SelectingHidesAppList SecondMaximizedWindowHasProperRestoreSize ActivationCancelsOveriew Basic BasicGesture BasicTabKeyNavigation BasicTextFiltering CloseButton CloseButtonOnPanels CreateLabelUnderPanel FullscreenWindow FullscreenWindowMaximizeMode LastWindowDestroyed NewWindowCancelsOveriew NoCrashWithDesktopTap NonActivatableWindowsHidden SelectWindowWithReturnKey SelectingHidesAppList Shutdown TextFilteringSelection WindowOverviewHidesCalloutWidgets AnimatedNormToMaxToNormRepositionsRemaining AutoPlacingMovesTransientChild BasicAutoPlacingOnShowHide NormToMaxToMinRepositionsRemaining NormToMaxToNormRepositionsRemaining ShelfStateUpdated TestSingleWindowsRestoredBounds TestUserHandledWindowRestore TestUserMovedWindowRepositioning ToMinimizeRepositionsRemaining Original issue's description: > Cleaning up MruWindowTracker::BuildWindowList() > > Removing the top_most_at_end parameter which was always set to false and > was never used. > > R=oshima@chromium.org > BUG=None > > Committed: https://crrev.com/f3848eee6c17acc74543c803bcea7ea542e13cbc > Cr-Commit-Position: refs/heads/master@{#307135} TBR=oshima@chromium.org,afakhry@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Review URL: https://codereview.chromium.org/790503003 Cr-Commit-Position: refs/heads/master@{#307248}
* Chrome OS: Ash support for >=3 displays.hshi2014-12-063-48/+66
| | | | | | | | | | | | | | As the first step, for >=3 displays we always use horizontal layout and disallow mirroring. This would allow basic multi-display functionality. BUG=422161 TEST=trybot Review URL: https://codereview.chromium.org/657583003 Cr-Commit-Position: refs/heads/master@{#307154}
* Cleaning up MruWindowTracker::BuildWindowList()afakhry2014-12-065-29/+17
| | | | | | | | | | | | Removing the top_most_at_end parameter which was always set to false and was never used. R=oshima@chromium.org BUG=None Review URL: https://codereview.chromium.org/786513003 Cr-Commit-Position: refs/heads/master@{#307135}
* Revert of Improve the logic for hiding the multi-window resize handle ↵pkotwicz2014-12-053-191/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #2 id:20001 of https://codereview.chromium.org/771543002/) Reason for revert: This CL broke: FullscreenControllerInteractiveTest.EscapingMouseLock FullscreenControllerInteractiveTest.TestTabExitsMouseLockOnGoBack FullscreenControllerInteractiveTest.TestTabExitsMouseLockOnNavigation Original issue's description: > Improve the logic for hiding the multi-window resize handle > > Improvements: > - The resize handle no longer hides when a user moves the mouse along the shared > window edge > - The resize handle no longer hides when a user moves the mouse over the resize > shadow > - Removed call to redundant MultiWindowResizeController::DelayedHide() > > BUG=None > TEST=MultiWindowResizeControllerTest.IsOverWindows > > Committed: https://crrev.com/ca6988df595e520e353722bbf5361c4dc0d0ee86 > Cr-Commit-Position: refs/heads/master@{#306874} TBR=flackr@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Review URL: https://codereview.chromium.org/776343003 Cr-Commit-Position: refs/heads/master@{#306961}
* Fixing orientation problem of the shelf when entering / exiting add user screenskuhne2014-12-041-3/+6
| | | | | | | | | BUG=436970 TEST=ShelfLayoutManagerTest.SideAlignmentInteractionWithAddUserScreen & visual Review URL: https://codereview.chromium.org/751343004 Cr-Commit-Position: refs/heads/master@{#306935}
* Make EventGenerator::DoubleClickLeftButton() send two synthetic clickspkotwicz2014-12-041-22/+24
| | | | | | | | | BUG=437120 Test=None Review URL: https://codereview.chromium.org/747143003 Cr-Commit-Position: refs/heads/master@{#306906}
* Improve the logic for hiding the multi-window resize handlepkotwicz2014-12-043-82/+191
| | | | | | | | | | | | | | | | Improvements: - The resize handle no longer hides when a user moves the mouse along the shared window edge - The resize handle no longer hides when a user moves the mouse over the resize shadow - Removed call to redundant MultiWindowResizeController::DelayedHide() BUG=None TEST=MultiWindowResizeControllerTest.IsOverWindows Review URL: https://codereview.chromium.org/771543002 Cr-Commit-Position: refs/heads/master@{#306874}
* AppListControllerTest: Increase the display size to 1024x768.mgiuca2014-12-031-3/+7
| | | | | | | | | | | | This fixes test failures once the --enable-experimental-app-list flag is turned on (because the app list is bigger than the default 800x600 display). BUG=438115 Review URL: https://codereview.chromium.org/775573002 Cr-Commit-Position: refs/heads/master@{#306513}
* Make WorkspaceEventHandler no longer a post target event handlerpkotwicz2014-11-272-9/+4
| | | | | | | | | BUG=None TEST=None Review URL: https://codereview.chromium.org/759323003 Cr-Commit-Position: refs/heads/master@{#305997}
* Reenable the apps grid view page switcher in the experimental app list.calamity2014-11-261-6/+3
| | | | | | | | | | | | | | | | | | | This CL restores the apps grid view's page switcher in the experimental app list. It was previously hidden but has been brought back in the latest round of mocks. This CL also changes the apps grid view to transition horizontally in order to match the horizontal movement of the page switcher. The size of the app list has increased by the height of the page switcher. This will be reclaimed by removing the contents switcher in a future patch. BUG=435937 Review URL: https://codereview.chromium.org/753083002 Cr-Commit-Position: refs/heads/master@{#305739}
* Enter maximize mode if only have a lid accelerometer.flackr2014-11-252-89/+117
| | | | | | | | | BUG=435114 TEST=MaximizeModeController.LidOnlyDisplayRotation Review URL: https://codereview.chromium.org/734033006 Cr-Commit-Position: refs/heads/master@{#305646}
* Add AppListView::InitAsFramelessWindow() for fullscreen view.mukai2014-11-251-1/+15
| | | | | | | | | | | | | | | | | | | | This CL is for the fullscreen view mode of experimental applist which will look similar to Athena's home card. - Allow supporting to init as a non-bubble widget. Especially, in that case it won't have BubbleFrameView(). - Create InitContents() for the views initialization and separate it from bubble initialization. - |overlay_view_| as a custom view class, to put the property initialization into its ctor. - Layout() needs to centralize the contents if it's wider. BUG=434113 R=mgiuca@chromium.org, flackr@chromium.org TEST=manually Review URL: https://codereview.chromium.org/734833002 Cr-Commit-Position: refs/heads/master@{#305574}
* events: Remove some usage of Event::native_event().Sadrul Habib Chowdhury2014-11-241-1/+1
| | | | | | | | | BUG=none R=sky@chromium.org Review URL: https://codereview.chromium.org/753603003 Cr-Commit-Position: refs/heads/master@{#305458}
* Introduce AcceleratorController::ProcessCommandIfEnabled() and change somepkotwicz2014-11-191-2/+2
| | | | | | | | | | | | | | | | | callers of AcceleratorController::ProcessCommand() to use AcceleratorController::ProcessCommandIfEnabled() instead. This a step towards splitting AcceleratorController::ProcessCommand() into AcceleratorController::CanPerformAction() and AcceleratorController::PerformAction(). BUG=404473 TEST=None R=oshima TBR=sky (For trivial rename in chrome/browser/policy/policy_browsertest.cc) Review URL: https://codereview.chromium.org/731913003 Cr-Commit-Position: refs/heads/master@{#304821}
* Introduced an animation settings provider into the overview space.bruthig2014-11-1310-95/+187
| | | | | | | | BUG=393668 Review URL: https://codereview.chromium.org/709553002 Cr-Commit-Position: refs/heads/master@{#304099}
* Reland ScreenOrientationDelegate on ChromeOSjonross2014-11-132-0/+10
| | | | | | | | | | | | | This change fixes the error in: https://codereview.chromium.org/648733003 This reverts commit 61aaa96a45aaa556a96ee19b87f0e512129a27d7. TBR=avi@chromium.org, oshima@chromium.org, rbyers@chromium.org, mlamouri@chromium.org BUG=396760 Review URL: https://codereview.chromium.org/723633003 Cr-Commit-Position: refs/heads/master@{#303952}
* Revert "Implement ScreenOrientationDelegate on ChromeOS"tbarzic2014-11-122-10/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 4f3952e7d0172a50d26a6eb57660623db70000db. It broke build packages on daisy: http://build.chromium.org/p/chromiumos.chromium/builders/Daisy%20%28chromium%29/builds/2929 > Extend content::ScreenOrientationDelegate within ash to provide functionality on ChromeOS. > > Also provides a fix for a bug in ScreenOrientationProvider that was found during development. > > TEST=Manual testing on TouchView device with an HTML page that performs ScreenOrientation requests. > BUG=396760 > > Review URL: https://codereview.chromium.org/648733003 > > Cr-Commit-Position: refs/heads/master@{#303898} > TBR=jonross@chromium.org NOTRY=True NOTREECHECKS=true BUG=396760 Review URL: https://codereview.chromium.org/716193005 Cr-Commit-Position: refs/heads/master@{#303915}
* Implement ScreenOrientationDelegate on ChromeOSjonross2014-11-122-0/+10
| | | | | | | | | | | | | Extend content::ScreenOrientationDelegate within ash to provide functionality on ChromeOS. Also provides a fix for a bug in ScreenOrientationProvider that was found during development. TEST=Manual testing on TouchView device with an HTML page that performs ScreenOrientation requests. BUG=396760 Review URL: https://codereview.chromium.org/648733003 Cr-Commit-Position: refs/heads/master@{#303898}
* Implement disable-app-list-dismiss-on-blur for ChromeOS.calamity2014-11-111-2/+5
| | | | | | | | | | | This CL prevents the app list from being dismissed on ChromeOS from a defocus event. BUG=405400 Review URL: https://codereview.chromium.org/698973006 Cr-Commit-Position: refs/heads/master@{#303561}
* ObserverList::HasObserver now takes a const pointer.mgiuca2014-11-102-2/+2
| | | | | | | | | | | | | Updated all clients that wrap HasObserver and expose it to also take a const pointer. This change avoids further propagation of non-constness (which was previously required when using HasObserver methods). BUG=429588 TBR=michaeln@chromium.org,nyquist@chromium.org,pkotwicz@chromium.org,satorux@chromium.org,sky@chromium.org,zea@chromium.org Review URL: https://codereview.chromium.org/697953002 Cr-Commit-Position: refs/heads/master@{#303428}
* Hide Mouse Cursor when entering Maximize Modejonross2014-11-071-0/+3
| | | | | | | | | | | When disabling the touchpad also hide the cursor. TEST=Manual: place mouse in middle of screen, enter TouchView mode. BUG=429769 Review URL: https://codereview.chromium.org/707013003 Cr-Commit-Position: refs/heads/master@{#303234}
* Move all event related devices from ui/events/ to ui/events/devices/dnicoara2014-11-042-4/+4
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/685793002 Cr-Commit-Position: refs/heads/master@{#302647}
* Make chrome/browser/chromeos/accessibility compile on Athena with use_ash=0pkotwicz2014-10-312-3/+3
| | | | | | | | | | | | | | This CL: - Moves the constants in magnifier_constants.h and accessibility_delegate.h to ui/chromeos/accessibility_types. - Stops compiling MagnificationManager on Athena BUG=426561, 408733 TEST=None Review URL: https://codereview.chromium.org/682943002 Cr-Commit-Position: refs/heads/master@{#302218}
generated by cgit v1.1 at 2025-02-12 03:42:54 +0000