| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
some corner cases:
. Deals with windows being deleted while resize widget is up.
. Wires up resizing more than two windows at the same time.
. Adds tests.
. Resize widget is now shown closer to mouse.
BUG=118005
TEST=covered by tests.
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9724025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mostly copying and pasting from chromeos::BrowserView
Changed toplevel_window_event_filter to ignore right clicks.
Bug=117096
Test=Manual
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127392
Review URL: https://chromiumcodereview.appspot.com/9646005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mostly copying and pasting from chromeos::BrowserView
Changed toplevel_window_event_filter to ignore right clicks.
Bug=117096
Test=Manual
Review URL: http://codereview.chromium.org/9646005
TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9724019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mostly copying and pasting from chromeos::BrowserView
Changed toplevel_window_event_filter to ignore right clicks.
Bug=117096
Test=Manual
Review URL: http://codereview.chromium.org/9646005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/9700044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows more control over the interpolation, and in particular, it allows for a rotation about a pivot.
BUG=None
TEST=None
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127269
Review URL: http://codereview.chromium.org/9704070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add ResizeShadow that uses solid-color layers to draw the resize border shadow effect.
* Add ResizeShadowController to create ResizeShadows and track bounds changes for windows.
* Wire both into ToplevelWindowEventFilter to track mouse move/enter events near (but not inside) the window frame.
BUG=118325
TEST=visual, hover mouse near window edges, drag windows
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127268
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=127277
Review URL: http://codereview.chromium.org/9677070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interpolated transform. This allows more control over the interpolation, and in particular, it allows for a rotation about a pivot."
Revert r127280 "Fix Win Aura compile break caused by r127269."
TBR=mpcomplete@chromium.org,vollick@chromium.org
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/9722015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change bool to float.
TBR=vollick
BUG=no
TEST=no
Review URL: https://chromiumcodereview.appspot.com/9719007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add ResizeShadow that uses solid-color layers to draw the resize border shadow effect.
* Add ResizeShadowController to create ResizeShadows and track bounds changes for windows.
* Wire both into ToplevelWindowEventFilter to track mouse move/enter events near (but not inside) the window frame.
BUG=118325
TEST=visual, hover mouse near window edges, drag windows
Review URL: https://chromiumcodereview.appspot.com/9677070
TBR=jamescook@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9724005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows more control over the interpolation, and in particular, it allows for a rotation about a pivot.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/9704070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add ResizeShadow that uses solid-color layers to draw the resize border shadow effect.
* Add ResizeShadowController to create ResizeShadows and track bounds changes for windows.
* Wire both into ToplevelWindowEventFilter to track mouse move/enter events near (but not inside) the window frame.
BUG=118325
TEST=visual, hover mouse near window edges, drag windows
Review URL: https://chromiumcodereview.appspot.com/9677070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
z-order) so that they are one after another.
BUG=118323
TEST=covered by unit tests.
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9717006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the left/up the rightmost window grows.
BUG=118322
TEST=covered by unit tests
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9704093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
couple of reasons:
. RWHVA was never told it was going to become active by way of a
mouse. I fixed this by wiring through the event to
ActivationDelegate::ShouldActivate.
. OmniboxViewViews wasn't telling the model the native view that is
getting focus. I've modified OmniboxViewViews to get the focused
window from the RootWindow.
. OmniboxViewViews was never being told it's losing focus. The call to
BrowserWindow::WebContentsFocused initiates that.
There is a slew of interactive ui tests that exercise this code. They
are currently disabled on linux. Separately I'll see I can reenable
them.
BUG=116940
TEST=make sure instant works correctly on aura.
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9700078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't try to repair the workspace area insets when the ShelfLayoutManager is deleted. This is left over from when we could toggle into and out of compact mode. Now the ShelfLayoutManager exists for the lifetime of the Shell, and we don't want to call Shell::GetInstance() inside its destructor.
BUG=none
TEST=none
TBR=oshima@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9699102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This patch implements a GetTitleFont() function.
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9704027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Bonus points to sadrul if he can get this to rotate down into the launcher item.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9701051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes them clickable when the cursor is at the edge of the screen.
For maximized windows we suppress the resize area that extends 1 pixel inside the window bounds, as maximized windows can't be resized (at least for now). This allows double-clicking on the top edge of the screen to restore a maximized window and suppresses misleading resize cursors.
BUG=117952
TEST=manual, maximize a window and try single and double-clicking along the top screen edge.
Review URL: https://chromiumcodereview.appspot.com/9706044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
stops: .5, 2/3, .8. You get to the next stop by pausing them moving,
or moving enough.
BUG=116213
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9706059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://chromiumcodereview.appspot.com/9689047/
with fix to allow for special conditions under test
BUG=115650
TEST=LauncherUpdaterTest.*
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/9702072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=116213
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9705039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=115650
TEST=LauncherUpdaterTest.*, including new tests
Review URL: https://chromiumcodereview.appspot.com/9689047
TBR=davemoore@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9702054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
relying in DrawLine.
BUG=100898
R=pkasting@chromium.org,sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9703034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=115650
TEST=LauncherUpdaterTest.*, including new tests
Review URL: https://chromiumcodereview.appspot.com/9689047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
snapping/minimizing. FrameMaximizeButton handles all the logic for
this. If you move the mouse the drag threshold we'll trigger to
snapping behavior. moving to the left snaps to the left half, moving
to the right the right half, and below minimizes. Uses
PhantomWindowController to render the snap position. Minimizing
highlights the launcher button. To support this I had to plumb through
getting the bounds of the launcher button.
BUG=116213
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9703026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is clone of issue 9689027, which I can't access due to some internal error.
BUG=115510
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9699013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=116213
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9701011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=116572
R=asvitkine@chromium.org
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9702009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
where this makes sense. I didn't change the class that is
potentially global and not root specific.
This also removes ToplevelLayoutManager that is not longer in use.
BUG=115510
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9665016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-upload of http://codereview.chromium.org/9635003
BUG=114546
TEST=See issue. Also ensure that behavior is expected with multiple windows open, including multiple windows with modal dialogs.
Review URL: http://codereview.chromium.org/9694050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The mocks call for resize handles to function along a single pixel edge inside the window, overlapping the web content. Refactored aura::Window::set_hit_test_bounds_inset() into SetHitTestBoundsOverride() to make hover/click events along that border pass through to the non-client area of the window frames. This also allows windows to be resized when they are flush against the top/left/right edges of the screen.
BUG=117542
TEST=aura_shell_unittests ShelfLayoutManager, manually resize window from left/right/bottom/top edges
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126539
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=126544
Review URL: https://chromiumcodereview.appspot.com/9694012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mocks call for resize handles to function along a single pixel edge inside the window, overlapping the web content. Use the aura::Window::set_hit_test_bounds_inset() functionality to make hover/click events along that border pass through to the non-client area of the window frames. This also allows windows to be resized when they are flush against the top/left/right edges of the screen.
BUG=117542
TEST=aura_shell_unittests ShelfLayoutManager, manually resize window from left/right/bottom/top edges
Review URL: http://codereview.chromium.org/9694012
TBR=jamescook@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9705011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mocks call for resize handles to function along a single pixel edge inside the window, overlapping the web content. Use the aura::Window::set_hit_test_bounds_inset() functionality to make hover/click events along that border pass through to the non-client area of the window frames. This also allows windows to be resized when they are flush against the top/left/right edges of the screen.
BUG=117542
TEST=aura_shell_unittests ShelfLayoutManager, manually resize window from left/right/bottom/top edges
Review URL: http://codereview.chromium.org/9694012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=116572
R=asvitkine@chromium.org
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9663077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
win_aura bot.
Aura/Ash split: Move ScreenAura to aura::RootWindowScreen.
What is now aura::RootWindowScreen was tightly bundled with aura::RootWindow. Instead of moving it to ash::ScreenAsh, I renamed it aurea::RootWindowScreen because there's a bunch of unit tests that use RootWindow as if it were the desktop. Screen integration stuff has been moved out of RootWindow (and related observers) and into ash::Shell.
BUG=116458
First Review URL: http://codereview.chromium.org/9616045
Review URL: http://codereview.chromium.org/9696008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=114546
TEST=See issue. Also ensure that behavior is expected with multiple windows open, including multiple windows with modal dialogs.
Review URL: http://codereview.chromium.org/9635003
TBR=stevenjb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9692060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=114546
TEST=See issue. Also ensure that behavior is expected with multiple windows open, including multiple windows with modal dialogs.
Review URL: http://codereview.chromium.org/9635003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
screen size.
TEST=none
BUG=116213
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9691012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
At the root_window.cc level we defer mouse events triggering a resize while a draw is pending. We are careful to keep the sequence of different event types the same. But we aggregate synthetic mouse moves and mouse drags wwhere possible.
In RWHVA, we ask the root window to throttle the resize if we are waiting on the GPU process for a new image. The net result is that UI can only be one frame ahead of the tab contents that are being resized.
BUG=58782
TEST=goto google.com with --force-compositing-mode; resize the window by stretching to the right; see very little gap between tab contents and window frame
Review URL: https://chromiumcodereview.appspot.com/9662020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=116572
R=asvitkine@chromium.org
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9662034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=115510
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9664010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
What is now aura::RootWindowScreen was tightly bundled with aura::RootWindow. Instead of moving it to ash::ScreenAsh, I renamed it aurea::RootWindowScreen because there's a bunch of unit tests that use RootWindow as if it were the desktop. Screen integration stuff has been moved out of RootWindow (and related observers) and into ash::Shell.
BUG=116458
Review URL: http://codereview.chromium.org/9616045
TBR=erg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9667017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
What is now aura::RootWindowScreen was tightly bundled with aura::RootWindow. Instead of moving it to ash::ScreenAsh, I renamed it aurea::RootWindowScreen because there's a bunch of unit tests that use RootWindow as if it were the desktop. Screen integration stuff has been moved out of RootWindow (and related observers) and into ash::Shell.
BUG=116458
Review URL: http://codereview.chromium.org/9616045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also fixes DCHECKs when you resize the windows too small.
BUG=116872
TEST=manual, resize a browser window to the smallest size possible, can see a tab, can see frame controls
Review URL: https://chromiumcodereview.appspot.com/9669008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=116079
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9648013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
give an indication as to where on the grid the window will land when
dropped.
BUG=116213
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9646007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the bounds can trigger mouse moved, which can trigger attempting to
cancel a tab dragging operation thereby destroying the resizer.
BUG=none
TEST=none
R=jennyz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9648016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
screen.
This makes the bottom-right corner a click target for the tray. want.
BUG=110130
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9633008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=117086
Test=None
Review URL: http://codereview.chromium.org/9625018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125772 0039d316-1c4b-4281-b951-d872f2087c98
|