| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/17887005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
r190446 accidentally made Chrome Frame windows transparent and invisible (except when viewed via RDP). This change brings them back.
BUG=223560,237579
Review URL: https://chromiumcodereview.appspot.com/14263020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
really do anything, instead, it will stop at the volume slider, which will read the volume level and allow user to adjust the volume.
BUG=251531
Review URL: https://chromiumcodereview.appspot.com/17958002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Reset the timer for keeping up the volume popup after changing mute
status.
BUG=151118
Review URL: https://chromiumcodereview.appspot.com/17912004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=253991
Review URL: https://chromiumcodereview.appspot.com/17830004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This define no longer exists in gyp anywhere, and has been replaced
with USE_OZONE.
Review URL: https://chromiumcodereview.appspot.com/17857005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=253639
R=derat@chromium.org
Review URL: https://chromiumcodereview.appspot.com/17883002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/17437004/.
BUG=219292
TEST=none
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/17662002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
"High contrast" -> "High contrast mode"
"Enable high contrast" -> "Use high contrast mode"
BUG=252810
TBR=zork@chromium.org
Review URL: https://codereview.chromium.org/17624006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- 'Large cursor' -> 'Large mouse cursor'
- 'Enable large cursor' -> 'Show large mouse cursor'
BUG=253802
TBR=zork@chromium.org
Review URL: https://codereview.chromium.org/17605006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Manual follow-up to mechanical https://codereview.chromium.org/17593006/
BUG=251957
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/17627005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Charging or Discharging". This is issue is a regression of crrev.com/203952.
BUG=252026
Review URL: https://chromiumcodereview.appspot.com/17569020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Unused assets will be removed in a separate CL.
BUG=253630
Review URL: https://chromiumcodereview.appspot.com/17573015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(and vertical centering since I am on it).
BUG=253461
TEST=visual
Review URL: https://chromiumcodereview.appspot.com/17595005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It should not be notified if the configuration change happens from
the settings UI. To achieve this casually, this CL simply blocks
the display notifications when chrome://settings/display is active.
This is not perfect but good enough I guess.
BUG=250650, 246271
R=oshima@chromium.org, jamescook@chromium.org, stevenjb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16818028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1.) The header is now in base/mac instead of base/memory
2.) The class is now in namespace base.
This CL was created programmatically by running:
1.)
git grep -l memory/scoped_nsobject.h | xargs sed -i -e 's/memory\/scoped_nsobject.h/mac\/scoped_nsobject.h/g'
for f in $(git diff --name-only origin); do tools/sort-headers.py $f -f; done
git commit -a -m headers
# manually undo changes to gypi file
git cl upload # patch set 1
2.)
git grep -l 'scoped_nsobject<' | xargs sed -i -e 's/scoped_nsobject</base::scoped_nsobject</g'
# manually undo comment changes in scoped_nsobject.h, tracking_area.h
git commit -a -m format
git cl upload # patch set 2
# Manually audit all files, file bugs and clean up bad clang-format decisions
git cl upload # patch set 3
BUG=251957
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/17593006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was originally committed in revision 204974, but was
reverted due to a memory leak in revision 204989. This new version
fixes the memory leak and adds an additional test to check that the
tray items have been properly added.
BUG=246277
TEST=unit tests
Review URL: https://chromiumcodereview.appspot.com/17553011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
NOTRY=true
BUG=237847
Review URL: https://chromiumcodereview.appspot.com/17591011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Processed 302 files (out of 508 files) in 01:26:22s
Result : 231689 => 225050 bytes (6639 bytes : 2 %)
TBR=jamescook@chromium.org
BUG=252418
Review URL: https://codereview.chromium.org/17606003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Its function is launch app in the launcher. But its name is a liitle bit
different from functionality.
BUG=NONE
TEST=manual test
Review URL: https://chromiumcodereview.appspot.com/17551014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL contains the following fixes:
- shows the notification for display rotation / ui_scale
- adds (width x height) annotation to the display if something
has been edited
- shows the internal display's status if something for the internal
display has been edited and no external display is connected
- shows the tooltip text to provide the status of both internal and
extrenal displays at the same time
This CL does not contain:
- the feature to prevent notification when the settings change happens
from chrome://settings/display
I think we can achieve this by suppressing the notification when
the current active tab is chrome://settings/display, but anyways
it'll be done in another CL. That is marked as a TODO.
BUG=250650, 246271
Review URL: https://chromiumcodereview.appspot.com/17445002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=251413
BUG=251421
TBR=jeremya@chromium.org
TEST=Drag Hangout panels near screen edge with dual screens. Verify
that panels stay where they are left when mouse is released.
Review URL: https://chromiumcodereview.appspot.com/17431003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=246603
TEST=Open a panel (i.e. hangouts) and double click and tap on header. Panel should minimize.
Review URL: https://chromiumcodereview.appspot.com/17175019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=252667
TEST=No dchecking on calls to LabelTrayView::CreateChildView from ChromeOS.
TBR=sadrul@chromium.org
Review URL: https://chromiumcodereview.appspot.com/17550003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- puts browser windows which would have used AppNonClientFrameViewAsh into maximized mode
- puts v1 app windows which would not have used AppNonClientFrameViewAsh and browser popup windows into tab fullscreen
- Makes Alt+ put windows into maximized mode. (That's what Ctrl+Alt+? indicates)
TEST=ChromeShellDelegateBrowserTest
BUG=251311
Review URL: https://chromiumcodereview.appspot.com/17515005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=179669
R=ygorshenin@chromium.org
TBR=derat@chromium.org
notry=TRUE
Review URL: https://chromiumcodereview.appspot.com/17494004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The win_aura builder appeared to have trouble running
animations in
DesktopBackgroundControllerTest.SetDefaultWallpaper; this
version of the change splits that test into several smaller
tests so that animations can be avoided.
Original change:
ash: Add flags for specifying default wallpaper.
This adds new command-line flags for specifying image files
that will be used as default wallpaper:
--ash-default-guest-wallpaper-large
--ash-default-guest-wallpaper-small
--ash-default-wallpaper-large
--ash-default-wallpaper-small
This makes it easier for Chrome OS to have per-device custom
wallpaper. (We previously loaded the default wallpaper from
a resource file, but that prevents the same build of Chrome
from being used on different devices.)
BUG=248764
Review URL: https://chromiumcodereview.appspot.com/17502005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hardcoding it in a few places and passing it via a flag.
Supporting a more generic use case via flags was making things more complicated for no apparent reason (other than perhaps one day supporting a random-channel-id -- I removed that TODO in this CL). This simplification will make it easier to introduce some sort of --viewer-launch-via-appid-and-connect flag for https://codereview.chromium.org/16022003/
BUG=179830
TEST=Can still launch Ash in Metro.
Review URL: https://chromiumcodereview.appspot.com/15731003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/15600006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Wires up an existing art asset
BUG=249852
TEST=visual, it uses the new art
Review URL: https://chromiumcodereview.appspot.com/17517004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=247059
TEST=covered by test
Review URL: https://chromiumcodereview.appspot.com/17379003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This allows icons to be dragged from the windows App Launcher to the taskbar.
BUG=153335
Review URL: https://chromiumcodereview.appspot.com/17370003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL reverts the following 3 CLs.
crrev.com/205493: Do not create a workspace for a maximized window.
crrev.com/205989: Fixes the test expectation from fullscreen_area.
crrev.com/206487: Recovers the background when the maximized window is closed.
I landed the first patch, but it has caused a few regressions
and the latter 2 CLs has fixed them. However, we expect that
several more regressions will be observed afterall and it would
not be possible to fix all of those regressions in this milestone.
Thus this CL reverts everything to recover the original behavior
for M29. I will reland them and fix the regressions at some earlier
point of M30 cycle.
BUG=245345,248757
TBR=sky@chromium.org, jamescook@chromium.org
TEST=ash_unittests still succeeds
Review URL: https://codereview.chromium.org/17408008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor the code to send the device object itself to the audio devices preferences handler. The preferences handler then pulls the device name and the node_id out of the object to generate it's device identification string. The 'id' field in the AudioDevice object is really
the device_id << 32 | node_id (it is sent as one value from cras), so to get the node_id, we need to & the value out. This changes how we store our audio device list internally, using a map instead of a list, making our active node lookups more efficient too.
Reviews requested,
hshi@ overall review
stevenjb@ chromeos/* and ash/system/chromeos/* OWNERs review
dgreid@ fyi
R=dgreid@chromium.org,hshi@chromium.org,stevenjb@chromium.org
BUG=241441
TEST=Tested with switching between various devices to ensure that preferences were remembered and switched per device correctly.
Review URL: https://chromiumcodereview.appspot.com/17349003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First landed as https://codereview.chromium.org/17157007 and broke win_aura
Encourage the user to plug in the official charger.
Also extract FakeMessageCenter into a message_center_test_support target
so I can use it for a unit test.
BUG=249852
TEST=ash_unittests TrayPowerTest.*
TBR=mukai@chromium.org - previously reviewed
Review URL: https://codereview.chromium.org/17482007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Drover forgot a file somehow. sigh.
> ash: Add flags for specifying default wallpaper.
>
> This adds new command-line flags for specifying image files
> that will be used as default wallpaper:
>
> --ash-default-guest-wallpaper-large
> --ash-default-guest-wallpaper-small
> --ash-default-wallpaper-large
> --ash-default-wallpaper-small
>
> This makes it easier for Chrome OS to have per-device custom
> wallpaper. (We previously loaded the default wallpaper from
> a resource file, but that prevents the same build of Chrome
> from being used on different devices.)
>
> BUG=248764
>
> Review URL: https://chromiumcodereview.appspot.com/16982006
TBR=derat@chromium.org
Review URL: https://codereview.chromium.org/17191005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Failed ash_unittests on WinAura
> ash: Add flags for specifying default wallpaper.
>
> This adds new command-line flags for specifying image files
> that will be used as default wallpaper:
>
> --ash-default-guest-wallpaper-large
> --ash-default-guest-wallpaper-small
> --ash-default-wallpaper-large
> --ash-default-wallpaper-small
>
> This makes it easier for Chrome OS to have per-device custom
> wallpaper. (We previously loaded the default wallpaper from
> a resource file, but that prevents the same build of Chrome
> from being used on different devices.)
>
> BUG=248764
>
> Review URL: https://chromiumcodereview.appspot.com/16982006
TBR=derat@chromium.org
Review URL: https://codereview.chromium.org/17094012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=249852
TEST=none, just a couple new images
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/17091004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds new command-line flags for specifying image files
that will be used as default wallpaper:
--ash-default-guest-wallpaper-large
--ash-default-guest-wallpaper-small
--ash-default-wallpaper-large
--ash-default-wallpaper-small
This makes it easier for Chrome OS to have per-device custom
wallpaper. (We previously loaded the default wallpaper from
a resource file, but that prevents the same build of Chrome
from being used on different devices.)
BUG=248764
Review URL: https://chromiumcodereview.appspot.com/16982006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=245869
R=dewittj@chromium.org, rsesek@chromium.org
TEST=manually / don't break existing tests
Review URL: https://chromiumcodereview.appspot.com/16867003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke Win Aura compile:
http://build.chromium.org/p/chromium.win/builders/Win%20Aura%20Builder/builds/9060
> cros: Show notification when low-power charger connected
>
> Encourage the user to plug in the official charger.
>
> Also extract FakeMessageCenter into a message_center_test_support target
> so I can use it for a unit test.
>
> BUG=249852
> TEST=ash_unittests TrayPowerTest.*
>
> Review URL: https://chromiumcodereview.appspot.com/17157007
TBR=jamescook@chromium.org
Review URL: https://codereview.chromium.org/17363004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Encourage the user to plug in the official charger.
Also extract FakeMessageCenter into a message_center_test_support target
so I can use it for a unit test.
BUG=249852
TEST=ash_unittests TrayPowerTest.*
Review URL: https://chromiumcodereview.appspot.com/17157007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the external display have overscan insets larger, the outside
area is actually drawable. Since auto-hide animation for status area
widget just slide-moves below, it may be visible too in that case.
Setting opacity here means that the status area widget changes
the opacity gradually during the auto-hide animation, but as far
as I checked manually, it doesn't look bad and mostly unrecognizable.
BUG=249165
R=jamescook@chromium.org
Review URL: https://chromiumcodereview.appspot.com/17315013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The RootWindow no longer needs to keep track of the mouse-flags. So remove
|mouse_button_flags_|. Also, make sure the synthesized mouse-enter/exit
events have the EF_IS_SYNTHESIZED flag set.
BUG=none
R=sky@chromium.org
Review URL: https://codereview.chromium.org/17287013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=242666
TEST=covered by test
Review URL: https://chromiumcodereview.appspot.com/17099003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Sticky Keys should be handled before input methods and after event rewriter.
BUG=229042
TEST=None
Review URL: https://chromiumcodereview.appspot.com/16809002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The shield changed to white when the "new dialog style" was enabled
by default, but it looks hazy. Revert to the old style pending UX input
on a new design.
BUG=249779
TEST=manual, open JavaScript console, type alert('foo'), note transparent black covering all UI except the alert
Review URL: https://chromiumcodereview.appspot.com/17020005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=244508
TEST=this fails without the fix for 244508
R=sky@chromium.org, varunjain@chromium.org
Review URL: https://codereview.chromium.org/16705006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also fixes some namespace usage inside the message pump files and updates all users of these files to use the new location.
Reland of 206507.
Original review https://codereview.chromium.org/17078005/
TBR=sky
Review URL: https://codereview.chromium.org/16897006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because Shill routinely removes and adds network services, this was
potentially causing a not insignificant amount of memory bloat, in
addition to incorrect behavior when Shill reuses service path names
after restarting.
Also removes extra NetworkStateList typedefs.
BUG=249129
Review URL: https://chromiumcodereview.appspot.com/16854006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207051 0039d316-1c4b-4281-b951-d872f2087c98
|