| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This puts resources that used to be in chrome.pak and/or compiled in to
chrome.dll into resources.pak. resources.pak is already loaded at startup
on all platforms so having some resources in a separate pak file isn't
beneficial.
This previously landed as https://codereview.chromium.org/22339020 and
was reverted due to various scripts/etc still referencing chrome.pak. This
patch still builds chrome.pak, but with only the (tiny) net_resources in
it. After this lands I'll go remove references to chrome.pak and then remove
it completely once all references are gone.
BUG=52609
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218956
R=phajdan.jr@chromium.org, sky@chromium.org, tony@chromium.org
Review URL: https://codereview.chromium.org/23205023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(which actually disables the feature :)
BUG=272460
Review URL: https://chromiumcodereview.appspot.com/22831037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Recently I've added a code to move the notification popups above
so that they can avoid the system tray. However, when the first
notification is created, the popup is still blocked if system tray
opens.
In this CL, I changed the lifetime of WorkAreaObserver to keep
tracking the system tray's visibility and size, and then the
notification popups can appear above the system tray.
BUG=274851
R=stevenjb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23346005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the cellular modem is locked, it appears as a disabled technology in the
login UI. A locked cellular device must be unlocked before the device can be
enabled, so the SIM unlock dialog should be shown.
BUG=167687
R=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/23319003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=ash_unittests pass.
Review URL: https://chromiumcodereview.appspot.com/22929034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move it into base::i18n namespace. That is the namespace that should be used
there.
- Consequently, rename the function to InitializeICU().
R=brettw@chromium.org
TBR=ben,thestig,jam
Review URL: https://chromiumcodereview.appspot.com/22875025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL creates a new class FrameCaptionButtonContainerView which contains the caption buttons.
This CL makes AppNonClientFrameViewAsh use this new class.
The new class will help:
- Creating different buttons based on whether the new window control style is used or not
- Will be used as a delegate for FrameMaximizeButton so that the FrameMaximizeButton can alter how the minimize and close buttons look after a drag.
- Will remove complexity from ash::FramePainter
TEST=FrameCaptionButtonContainerViewTest.*
BUG=274171
Review URL: https://chromiumcodereview.appspot.com/23280002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should eliminate the following linkage error.
warning: hidden symbol 'switches::kDisablePanelFitting' in obj/chrome/libinstaller_util.a(obj/chrome/../content/public/common/installer_util.content_switches.o) is referenced by DSO lib/libash.so
I looked into removing installer_util from chrome (for chromeos) target, but I couldn't because
there is a real dependency to it.
BUG=174740
R=jamescook@chromium.org, piman@chromium.org
Review URL: https://codereview.chromium.org/23205019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CaptureController and DesktopCaptureClient differed only slightly, and
the latter wasn't always cleaning things up leading to the possibility
of a use after free. Specifically DesktopCaptureClient::SetCapture()
invokes OnOtherCaptureClientTookCapture() *after* updating the
capture_window_. SetCapture in term invokes SetCapture(NULL) on
the other DesktopCaptureClient, which call GetCaptureWindow(), which
returns the first non-null capture_client_, which can be the new one
when it wants the old one.
This change also means when both ash and aura-windows are running at
the same time capture is correctly updated between the two.
BUG=268648
TEST=covered by tests.
R=erg@chromium.org, oshima@chromium.org
Review URL: https://codereview.chromium.org/22929007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It seemes to have broken the mac buildbot.
I'll post more info here soon, crbug.com does not seem to be working at the moment.
> Remove chrome.pak references, build resources into resources.pak (try 2)
>
> This puts resources that used to be in chrome.pak and/or compiled in to
> chrome.dll into resources.pak. resources.pak is already loaded at startup
> on all platforms so having some resources in a separate pak file isn't
> beneficial.
>
> This previously landed as https://codereview.chromium.org/22339020 and
> was reverted due to various scripts/etc still referencing chrome.pak. This
> patch still builds chrome.pak, but with only the (tiny) net_resources in
> it. After this lands I'll go remove references to chrome.pak and then remove
> it completely once all references are gone.
>
> BUG=52609
> TBR=phajdan.jr@chromium.org for chrome/installer/linux
>
> Review URL: https://chromiumcodereview.appspot.com/23205023
TBR=jamesr@chromium.org
Review URL: https://codereview.chromium.org/22807012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This puts resources that used to be in chrome.pak and/or compiled in to
chrome.dll into resources.pak. resources.pak is already loaded at startup
on all platforms so having some resources in a separate pak file isn't
beneficial.
This previously landed as https://codereview.chromium.org/22339020 and
was reverted due to various scripts/etc still referencing chrome.pak. This
patch still builds chrome.pak, but with only the (tiny) net_resources in
it. After this lands I'll go remove references to chrome.pak and then remove
it completely once all references are gone.
BUG=52609
TBR=phajdan.jr@chromium.org for chrome/installer/linux
Review URL: https://chromiumcodereview.appspot.com/23205023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Relanding https://chromiumcodereview.appspot.com/22887015/ in two steps to
preserve history of c/b/ui/ash/launcher/chrome_launcher_controller_per_app.*
Step 2 will rename chrome_launcher_controller_per_app.* to
chrome_launcher_controller.*
Original description:
Remove per-browser.* and related tests.
Remove IsPerAppLauncher() interface in LauncherDelegate.
Remove ash-disable-per-app-launcher switch.
Change class name from ChromeLauncherControllerPerApp to ChromeLauncherController.
In the next CL, BrowserLauncherItemController will be replaced with new browser status monitor only for monitoring browser and tab status.
BUG=169303
TEST=unit_tests, browser_tests Launcher*
TBR=skuhne@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23068021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=277042
TEST=WindowSelectorTest.QuickReentryRestoresInitialTransform
TEST=With --ash-enable-overview-mode, start alt-tabbing, quickly stop and start again and then exit alt tabbing. Windows should be restored to their initial positions.
Review URL: https://chromiumcodereview.appspot.com/22985015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=262393
R=stevenjb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22824030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The first CL was reverted due to compile error on a windows builder.
According to the error message, it seems that the parent class has
to have ASH_EXPORT if its child has ASH_EXPORT.
BUG=275697
TBR=stevenjb@chromium.org, jamescook@chromium.org
TEST=new test cases cover this
Review URL: https://chromiumcodereview.appspot.com/23050017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Remove PerBrowser launcher
>
> Remove per-browser.* and related tests.
> Remove IsPerAppLauncher() interface in LauncherDelegate.
> Remove ash-disable-per-app-launcher switch.
> Change class name from ChromeLauncherControllerPerApp to ChromeLauncherController.
>
> In the next CL, BrowserLauncherItemController will be replaced with new browser status monitor only for monitoring browser and tab status.
>
> R=skuhne@chromium.org,jamescook@chromium.org
> BUG=169303
> TEST=unit_tests, browser_tests
>
> Review URL: https://chromiumcodereview.appspot.com/22887015
TBR=simon.hong81@gmail.com
Review URL: https://codereview.chromium.org/22903020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It tests the case where all native windows are closed automatically
at shutdown and verifies if the shutdown doesn't cause any crashes.
It is working well, but I didn't notice that CreateTestWidget() utility
has WIDGET_OWNS_NATIVE_WIDGET ownership. This means that their native
windows are removed but the widgets themselves are not removed at all.
BUG=NONE
R=jamescook@chromium.org, oshima@chromium.org
TEST=passed locally with heapchecker
Review URL: https://codereview.chromium.org/23137009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is just some code cleanup designed to faciliate moving the Network
Notifications to the message center.
It also improves the logic for showing a notification after a connect
error by eliminating the NetworkState dependency (by explicitly fetching
the properties before showing the notification).
Having two 'network_connect.cc' files was confusing, also the functions
remaining don't directly have anything to do with connect, they are
support functions with Chrome dependencies and belong in
AshSystemTrayDelegate. Now all of the connect flow is in one place
(ash::network_connect).
BUG=271546
R=gauravsh@chromium.org, jennyz@chromium.org, pneubeck@chromium.org
Review URL: https://codereview.chromium.org/22796014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove per-browser.* and related tests.
Remove IsPerAppLauncher() interface in LauncherDelegate.
Remove ash-disable-per-app-launcher switch.
Change class name from ChromeLauncherControllerPerApp to ChromeLauncherController.
In the next CL, BrowserLauncherItemController will be replaced with new browser status monitor only for monitoring browser and tab status.
R=skuhne@chromium.org,jamescook@chromium.org
BUG=169303
TEST=unit_tests, browser_tests
Review URL: https://chromiumcodereview.appspot.com/22887015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Doesn't compile on Win Aura:
c:\b\build\slave\win_aura_builder\build\src\ash\system\tray\test_system_tray_delegate.h(18) : warning C4275: non dll-interface class 'ash::SystemTrayDelegate' used as base for dll-interface class 'ash::test::TestSystemTrayDelegate'
> Fixes a crash bug of TrayLocallyManagedUser notification in initialization.
>
> BUG=275697
> R=stevenjb@chromium.org
> TEST=new test cases cover this
>
> Review URL: https://chromiumcodereview.appspot.com/23332005
TBR=mukai@chromium.org
Review URL: https://codereview.chromium.org/22831018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=275697
R=stevenjb@chromium.org
TEST=new test cases cover this
Review URL: https://chromiumcodereview.appspot.com/23332005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes the text more readable against busy backgrounds.
Also round the corners.
BUG=276317
TEST=visual, ctrl-shift-Q dialog should match screenshots in bug
Review URL: https://chromiumcodereview.appspot.com/22816020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ash_resources contains images for both of those notifications but
somehow not specified at all.
BUG=262393
R=stevenjb@chromium.org
TEST=manually
Review URL: https://chromiumcodereview.appspot.com/22901015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add logging to determine if
CompoundEventFilter::SetCursorVisibilityOnEvent() ever keeps
a currently-invisible cursor invisible when it is called
with |show| = true. I suspect this as a possible cause of
issues 248231 and 267789.
LOG(ERROR) was used instead of LOG(WARNING) because I am
particularly interested in what happens at the login
screen, and the logs in /var/log/ui/ do not log WARNINGs.
I added IsCursorLocked() to the interface for
CursorManager in order to prevent my new logging from
appearing while in pointer lock (which is a case I do not
care about).
BUG=275826
Review URL: https://chromiumcodereview.appspot.com/22867023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=268428
R=mukai@chromium.org, skuhne@chromium.org
Review URL: https://codereview.chromium.org/23301010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ready string.
BUG=270921
TBR=stevenjb,jamescook
Review URL: https://chromiumcodereview.appspot.com/22854027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of simply deleting depth-first, it deletes all
toplevel windows first and then remove the containers.
This would be safer since all of the containers exist during deleting
the child windows.
This change would enable to eliminate other NULL checks in ash,
but it will be done in further CLs.
BUG=273310
R=derat@chromium.org, oshima@chromium.org
TEST=covered by the new test case
Review URL: https://chromiumcodereview.appspot.com/23219004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix too long names displayment (in text / on removal), password/name fields padding,
icon alignmanet on GAIA screen, text alignment on final screen, next button initial status,
wrong name/password bubble positioning. Added scroll bars for case of too long text/i18n.
BUG=268271, 268347, 259092
TBR=nkostylev@chromium.org, oshima@chromium.org
Review URL: https://codereview.chromium.org/22966005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=180021
R=marja@chromium.org
TBR=joi@chromium.org,ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23316003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=135001
TEST=ShellTest.LockScreenClosesActiveMenu
Review URL: https://chromiumcodereview.appspot.com/20868003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This may be called during the initialization and in that case
shelf is NULL.
BUG=275697
R=stevenjb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23332003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This updates DisplayChangeObserverX11 to use the output info
passed by OutputConfigurator instead of querying XRandR for
it. Doing so avoids a 60 ms call to XRRGetScreenResources().
BUG=266113
Review URL: https://chromiumcodereview.appspot.com/23286003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=274040
R=oshima@chromium.org, derat@chromium.org
TEST=ash_unittests
Review URL: https://chromiumcodereview.appspot.com/22936004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This function is to tell if a window has ever been moved by a user, not to tell if it is being moved.
Turns out there is no need to worry about drag case because the bounds is set after it is added.
This CL also changes the target visible area in AjustWindowBoundsWhenAdded from workarea to display area. The work area can be further shrunk by docked area, and
display area is more appropriate for this case.
BUG=248961
Review URL: https://chromiumcodereview.appspot.com/22887012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
setting it to (0,0).
The problem arises by the fact that the view_model does contain the "ideal_bounds" on a per view basis and not on a "per slot" basis. When an item gets removed / added the "ideal_bounds" need re-calculation which is usually done by animating the launcher items to their correct location. In this case however the item was removed and re-inserted as a new item and the ideal location was lost.
I have to say that this scheme to manage the two data sets seems to ask fro trouble - even though I can see why it was done this way. Changing this "cleanly" would require a lot more refactoring which we possibly do not want to do at this time.
BUG=273831
TEST=visual: Have a launcher item showing up automatically by launching. Pin and minimize to see.
Review URL: https://chromiumcodereview.appspot.com/23003012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For increased separation between model and view, the AppListViewDelegate
now updates the model on profile and signin status change which then
notifies the AppListView of changes so it can update.
BUG=
TEST=None
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22268009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23020012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
views::ImageView instead of a views::ImageButton as it is not clickable.
Removes the window icon for CustomFrameViewAsh because in addition to not being clickable the window icon never had an image.
BUG=274171
TEST=None
Review URL: https://chromiumcodereview.appspot.com/22819010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=274607
R=armansito@chromium.org, oshima@chromium.org
Review URL: https://codereview.chromium.org/22824015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This updates OutputConfigurator to include modes'
resolutions and interlaced-ness in OutputSnapshot structs,
and to pass OutputSnapshots to observers after the display
mode is changed.
A following change will update ash's
DisplayChangeObserverX11 class to use OutputSnapshots
instead of asking the X server for the same information via
XRandR.
BUG=266113
Review URL: https://chromiumcodereview.appspot.com/22871010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
make sure no popup windows appear during creation
BUG=267180
Review URL: https://chromiumcodereview.appspot.com/23203006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=jamescook
Review URL: https://chromiumcodereview.appspot.com/23258003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=272455
Review URL: https://chromiumcodereview.appspot.com/22810004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
time_format is now under ui/base/l10n, it's accessible from ash
directly.
BUG=None
R=stevenjb@chromium.org
TEST=compile succeeds
Review URL: https://chromiumcodereview.appspot.com/22923008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
--ash-disable-display-rotation
BUG=273142
R=derat@chromium.org, mazda@chromium.org, xiyuan@chromium.org
Review URL: https://codereview.chromium.org/22957004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For the 268783, HasWindow(aura::Window* window) of App shortcut's controller should only return true
if it has active WebContents of |window|.
For the 268814, In GetIDByWindow(), BrowserShortcutLauncherItemController is used at last
to make other item controller can check first.
Also, empty slot in shelf for BrowserLauncherItemController is not needed anymore in PerAppLauncher.
R=skuhne@chromium.org,jamescook@chromium.org
BUG=268783, 268814
TEST=Compiles, Manual test, unit_tests --gtest_filter=*Launcher*.*, browser_tests --gtest_filter=*Launcher*.*
Review URL: https://chromiumcodereview.appspot.com/22362002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes the following two changes for the case where the service property
"Cellular.ActivationState" has value "flimflam::kActivationStateUnknown" and
payment portal URL is unavailable:
1. NetworkConnectionHandler won't fail to connect with an activation error.
2. InternetOptionsHandler will hide the "View Account" and "Activate" buttons
if a payment portal URL is unavailable.
This CL also removes the NetworkConnectionHandler behavior that causes
a connect operation to fail with an activation related error when
Cellular.OutOfCredits is set to true, which leads to a confusing user
experience.
BUG=272324
Review URL: https://chromiumcodereview.appspot.com/22950007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows part 2
- This CL combines the common parts of ShelfLayoutManager::LayoutShelf() and ShelfLayoutManager::SetState() into
ShelfLayoutManager::UpdateBoundsAndOpacity().
- This CL animates the shelf when a gesture drag is completed / canceled
BUG=268209
TEST=ShelfLayoutManagerTest.ShelfAnimatesWhenGestureComplete
Review URL: https://chromiumcodereview.appspot.com/22638013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=269452
TEST=Enable --ash-enable-overview-mode, enter overview mode and tap a window to select it. Window should be selected.
Review URL: https://chromiumcodereview.appspot.com/23197002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
entire layer.
Allow wallper scaling to up ui scaling.
I'll improve ui-scaling scenario in separate CL
so that it won't scale up and down, which results in
blurry image.
BUG=chrome-os-partner:21037
TEST=manual: see bug for repro step.
Review URL: https://chromiumcodereview.appspot.com/23007009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217675 0039d316-1c4b-4281-b951-d872f2087c98
|