| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
The current code causes a crash if |parent| belongs to 2nd display. We may want to ensure that |parent| shouldn't have kUsesScreenCoordinatesKey, but this CL rather fixes the caller's code as a quick fix.
BUG=155656
TEST=on goobuntu, run chrome with --aura-host-window-size='800+0-1000x800,800+900-800x600', move a window to 2nd display, click the maximize button, and make sure that the click doesn't cause any crashes.
Review URL: https://chromiumcodereview.appspot.com/11150031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MagnificationManager controls the full screen magnifier from chrome-browser side (not ash side. Note that MagnificationController is on ash side).
MagnificationManager does:
- Watch logged-in. Change the behavior between the login screen and user desktop.
- Watch change of the pref. When the pref changes, the setting of the magnifier will interlock with it.
In addition, this patch make the magnifier settings per-user instead of per-device.
BUG=151891
TEST=manual, browser_test passes.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162080
Review URL: https://chromiumcodereview.appspot.com/11065008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Prepare code to introduce two versions of SessionStateController later.
BUG=138171, 139461
Review URL: https://chromiumcodereview.appspot.com/11091023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=151891
TEST=manual
R=zork@chromium.org
TBR=sky@chromium.org
# TRBing for simple change only of magnification_controller
Review URL: https://chromiumcodereview.appspot.com/11172002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MagnificationManager controls the full screen magnifier from chrome-browser side (not ash side. Note that MagnificationController is on ash side).
MagnificationManager does:
- Watch logged-in. Change the behavior between the login screen and user desktop.
- Watch change of the pref. When the pref changes, the setting of the magnifier will interlock with it.
In addition, this patch make the magnifier settings per-user instead of per-device.
BUG=151891
TEST=manual, browser_test passes.
Review URL: https://chromiumcodereview.appspot.com/11065008
TBR=yoshiki@chromium.org
Review URL: https://codereview.chromium.org/11169002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MagnificationManager controls the full screen magnifier from chrome-browser side (not ash side. Note that MagnificationController is on ash side).
MagnificationManager does:
- Watch logged-in. Change the behavior between the login screen and user desktop.
- Watch change of the pref. When the pref changes, the setting of the magnifier will interlock with it.
In addition, this patch make the magnifier settings per-user instead of per-device.
BUG=151891
TEST=manual, browser_test passes.
Review URL: https://chromiumcodereview.appspot.com/11065008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Panel fitting is used by mirror display mode on Chrome OS.
This GPU feature type will tell if it is supported by GPU hardware.
Initially enable it only for Ivy Bridge GPU via blacklisting everything else.
Also add a disable_panel_fitting command flag,
to be able to quickly turn the feature off.
When hardware supports panel fitting,
and there are no common modes between the internal and the external displays,
configure the internal display to the external's resolution,
and let the panel fitter take care of displaying it correctly.
BUG=chromium-os:34442
TEST=Panel Fitting should appear as Hardware Accelerated in about:gpu
on IVB Chrome OS, Unavailable everywhere else.
TEST=Tested mirror mode on device.
Review URL: https://chromiumcodereview.appspot.com/10909242
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Creates TrayEventFilter and TrayBubbleWrapper.
BUG=150872
For ash.gyp:
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/11028134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
valgrind memory fyi here: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%284%29/builds/14345/steps/memory%20test%3A%20unit/logs/stdio
TBR=ben@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/11146011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
One with content dep and one without.
BUG=141187
R=ben@chromium.org
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/11117009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It is more appropriate for Transform class to belong with its fellow
geometry classes in the gfx namespace.
Review URL: https://chromiumcodereview.appspot.com/11145005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Set active root window early when creating browsers on startup.
- Send screen info when device scale factor chagned.
- gfx::Screen::GetDisplayNearestWindow should return Primary when the window's root doesn't exist. I missed this condition in https://chromiumcodereview.appspot.com/10961021
BUG=155201, 152728
TEST=manual: see bug for repro steps
Review URL: https://chromiumcodereview.appspot.com/11066130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in support of supporting separate Screen implementations on Aura for desktop and metro on Windows.
Some callsites are not yet correct, and noted with a reference to the http://crbug.com/133312. As-is those sites will behave the same as before this patch, but may not be correct once desktop/metro can run simultaneously.
BUG=133312
Review URL: https://chromiumcodereview.appspot.com/11030017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The RootWindowController would always use the default modal-container. However,
in the login screen or the lockscreen, the special lock-screen modal container
needs to be used.
BUG=154607
Review URL: https://codereview.chromium.org/11117012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL changes mainly three parts:
- Add LockCursor and UnlockCursor to CursorClient.
- Move the code to change cursor visibility from aura::RootWindow and
aura::RootWindowHostLinux to ash::CursorManager.
- Remove CursorDelegate, which was too much simple delegation and unnecessary.
BUG=153702
TEST=CursorManagerTest.ShowCursor
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161454
Review URL: https://chromiumcodereview.appspot.com/11035050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RootWindowController
This is just preparation to create launchers on all displays.
BUG=145978
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11093050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This test is broken after http://crrev.com/161590.
TBR=ben@chromium.org
BUG=None
Review URL: https://codereview.chromium.org/11115017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
moves the switching animation into its own file and cleans it up.
BUG=155179
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/11106003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11087091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL itself doesn't change the behavior. Another CL will enables the customization.
BUG=139419
Review URL: https://chromiumcodereview.appspot.com/11066107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a bit tricky as the app list should not hide when the taskbar gets focus. Handling this involves using a timer, when the app list does not have focus, to check whether either the taskbar or the app list has focus. Once one of these is not true the app list is closed.
This change also ensures that the app list is never opened multiple times.
Also includes is a bit of cleanup:
- AppListController has been renamed to AppListControllerDelegate
- a singleton AppListController has been introduced for Windows, similar to ash
- default implementations have been added to AppListControllerDelegate where it makes sense.
BUG=152847, 152846
Review URL: https://chromiumcodereview.appspot.com/11094019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL changes mainly three parts:
- Add LockCursor and UnlockCursor to CursorClient.
- Move the code to change cursor visibility from aura::RootWindow and
aura::RootWindowHostLinux to ash::CursorManager.
- Remove CursorDelegate, which was too much simple delegation and unnecessary.
BUG=153702
TEST=CursorManagerTest.ShowCursor
Review URL: https://chromiumcodereview.appspot.com/11035050
TBR=mazda@chromium.org
Review URL: https://codereview.chromium.org/11114007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL changes mainly three parts:
- Add LockCursor and UnlockCursor to CursorClient.
- Move the code to change cursor visibility from aura::RootWindow and
aura::RootWindowHostLinux to ash::CursorManager.
- Remove CursorDelegate, which was too much simple delegation and unnecessary.
BUG=153702
TEST=CursorManagerTest.ShowCursor
Review URL: https://chromiumcodereview.appspot.com/11035050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=143015
Review URL: https://codereview.chromium.org/11092034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=155179
TEST=none, code cleanup
R=ben@chromium.org
Review URL: https://codereview.chromium.org/11086057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
makes it a bit more generic. I'm going to need it for some animations.
BUG=155179
TEST=none
Review URL: https://codereview.chromium.org/11086064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
brightness] to [CTRL + ALT + brightness]
On Developer mode, [Ctrl + Alt + Fn] shortcut keys are hooked by X11 layer and [CTRL + ALT + brightness] doesn't work.
This patch will be reverted for a while until X11 layer is solved.
BUG=153961
Review URL: https://chromiumcodereview.appspot.com/11035051
TBR=yoshiki@chromium.org
Review URL: https://codereview.chromium.org/11088053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
window as focused window when testing if the focused window can receive events. This was causing lock screen to lose focus when mouse is clicked on another root window.
This Cl also adds a debug build/linux desktop only shortcut (F11) to lock/shutdown.
BUG=152982
TEST=covered by test.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160696
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=160804
Review URL: https://chromiumcodereview.appspot.com/11047030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The following changes are for removing TOGGLE_MAXIMIZED_* from Ash reserved actions list.
- Add ShellDelegate::ToggleMaximized
- Remove VKEY_F4 from browser accelerators list
Also added a browser test for ChromeShellDelegate::ToggleMaximized.
BUG=152265
TEST=Manual
Review URL: https://chromiumcodereview.appspot.com/11082002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=151380
TEST=Verify touch fling does not leave launcher icon in strange position.
R=sadrul@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11097003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ben,brettw,oshima,rdsmith
Review URL: https://chromiumcodereview.appspot.com/11087021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a rect is (0, 0, 5, 5) the center should be 2.5, 2.5, not 2, 2.
Tests:
ui_unittests:RectTest.CenterPoint
ui_unittests:RectTest.CenterPointF
BUG=147395
Review URL: https://chromiumcodereview.appspot.com/11065050
TBR=danakj@chromium.org
Review URL: https://codereview.chromium.org/11086037
TBR=cpu@chromium.org
Review URL: https://codereview.chromium.org/11088048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a rect is (0, 0, 5, 5) the center should be 2.5, 2.5, not 2, 2.
Tests:
ui_unittests:RectTest.CenterPoint
ui_unittests:RectTest.CenterPointF
BUG=147395
Review URL: https://chromiumcodereview.appspot.com/11065050
TBR=danakj@chromium.org
Review URL: https://codereview.chromium.org/11086037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a rect is (0, 0, 5, 5) the center should be 2.5, 2.5, not 2, 2.
Tests:
ui_unittests:RectTest.CenterPoint
ui_unittests:RectTest.CenterPointF
BUG=147395
Review URL: https://chromiumcodereview.appspot.com/11065050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a user presses Ctrl-Alt-Shift-F3 repeated their windows can get stuck in
a partially rotated state. The rotation animation chooses its target rotation
and transform based on the values at the start of the animation. By default,
if we trigger a new animation it immediately computes a new target based on
the current values. Instead, queue the animations so we're sure things are
back to neutral before starting a new one.
BUG=154875
TEST=manual, hit Ctrl-Alt-Shift-F3 repeatedly and ensure windows end up in normal position
Review URL: https://chromiumcodereview.appspot.com/11066085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When scaling an integer point or size, return a floating point
result. Implicitly flooring hides design problems and bugs. Add
conversion functions to floor or ceil a SizeF or PointF
into an integer format again.
All existing behaviour has been preserved by replacing uses of
foo.Scale() with ToFlooredFoo(foo.Scale()).
R=sky
BUG=147395
Review URL: https://chromiumcodereview.appspot.com/11081007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=154719
Review URL: https://chromiumcodereview.appspot.com/11096014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverting: Decouple EventClientImpl and root window. Check containers on the same root window as focused window when testing if the focused window can receive events. This was causing lock screen to lose focus when mouse is clicked on another root window.
This Cl also adds a debug build/linux desktop only shortcut (F11) to lock/shutdown.
BUG=152982
TEST=covered by test.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160696
Review URL: https://codereview.chromium.org/11047030
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/11093021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
window as focused window when testing if the focused window can receive events. This was causing lock screen to lose focus when mouse is clicked on another root window.
This Cl also adds a debug build/linux desktop only shortcut (F11) to lock/shutdown.
BUG=152982
TEST=covered by test.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160696
Review URL: https://codereview.chromium.org/11047030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
+ ALT + brightness]
BUG=153961
Review URL: https://chromiumcodereview.appspot.com/11035051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=153879
Review URL: https://chromiumcodereview.appspot.com/11035035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
on date/time section.
BUG=151162
Review URL: https://codereview.chromium.org/11017018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=ben@chromium.org
BUG=153475
Review URL: https://chromiumcodereview.appspot.com/11028074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on the same root window as focused window when testing if the focused window can receive events. This was causing lock screen to lose focus when mouse is clicked on another root window.
This Cl also adds a debug build/linux desktop only shortcut (F11) to lock/shutdown.
BUG=152982
TEST=covered by test.
Review URL: https://chromiumcodereview.appspot.com/11047030
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/11087014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
window as focused window when testing if the focused window can receive events. This was causing lock screen to lose focus when mouse is clicked on another root window.
This Cl also adds a debug build/linux desktop only shortcut (F11) to lock/shutdown.
BUG=152982
TEST=covered by test.
Review URL: https://chromiumcodereview.appspot.com/11047030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove unnecessary borders and backgrounds; use BIG_SHADOW for bubbles.
Also fixes some notification layout issues:
* Layout needs to initially be narrower by the width of the scroll bar so the height is correct.
BUG=132772
TEST=Thoroughly test web notifications (message center). See issue for test url. Also thoroughly test system tray bubble, detailed views, and notifications.
For ash.gyp:
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11026012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Copy-and-paste mishap.
BUG=none
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/11089004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change is needed for adding tests in http://codereview.chromium.org/11033038/.
BUG=154183
Review URL: https://chromiumcodereview.appspot.com/11066045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes crash at startup time.
BUG=151870
TEST=ash_shell.exe no longer crash at startup
Review URL: https://chromiumcodereview.appspot.com/11026075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mirroring to the users.
This CL depends on http://codereview.chromium.org/10989084/.
BUG=149061
Review URL: https://chromiumcodereview.appspot.com/10986087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160521 0039d316-1c4b-4281-b951-d872f2087c98
|