summaryrefslogtreecommitdiffstats
path: root/ash
Commit message (Collapse)AuthorAgeFilesLines
* Moves transient window observer methods out of WindowObserversky@chromium.org2014-01-102-10/+14
| | | | | | | | | | | | | | As transient logic has been moved outside of aura it doesn't make sense for these methods to be in WindowObserver anymore. Instead they have been added to TransientWindowManager. BUG=none TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/132013004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244176 0039d316-1c4b-4281-b951-d872f2087c98
* Fix AdjustBoundsToEnsureWindowVisibility to work with non primary display boundsoshima@chromium.org2014-01-108-28/+103
| | | | | | | | | | | | | | | | | | This was asssuming that the visibile area has 0,0 origin. Move the code to ensure minimum visibility when added, from WorkspaceLayoutManager to DragWindowResizer. BUG=none TEST=WindowUtilTest.AdjustBoundsToEnsureWindowVisibility. This also fixes the test that was failing. TBR=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243986 Review URL: https://codereview.chromium.org/106303005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244131 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 244050 "This is part 1 of implemeting phantom windows for..."dcheng@chromium.org2014-01-109-265/+268
| | | | | | | | | | | | | | | | | | | | | | | This is causing PhantomWindowControllerTest.PhantomWindowShow to fail on the Win 8 Aura bots. > This is part 1 of implemeting phantom windows for the window controls when using --ash-enable-alternate-caption-button > > Other notable changes: > - Switched to using layer animations instead of gfx::SlideAnimation > - Renamed PhantomWindowController::phantom_widget_ and PhantomWindowController::phantom_widget_start_ to PhantomWindowController::phantom_widget_in_target_root_ and PhantomWindowController::phantom_widget_in_start_root_ respectively. > - Removed PhantomWindowController::Hide(). Hiding the phantom window can now only be done via destroying the PhantomWindowController > > BUG=328930 > TEST=PhantomWindowControllerTest.* > > Review URL: https://codereview.chromium.org/101773004 TBR=pkotwicz@chromium.org Review URL: https://codereview.chromium.org/132183006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244090 0039d316-1c4b-4281-b951-d872f2087c98
* This is part 1 of implemeting phantom windows for the window controls when ↵pkotwicz@chromium.org2014-01-109-268/+265
| | | | | | | | | | | | | | | | using --ash-enable-alternate-caption-button Other notable changes: - Switched to using layer animations instead of gfx::SlideAnimation - Renamed PhantomWindowController::phantom_widget_ and PhantomWindowController::phantom_widget_start_ to PhantomWindowController::phantom_widget_in_target_root_ and PhantomWindowController::phantom_widget_in_start_root_ respectively. - Removed PhantomWindowController::Hide(). Hiding the phantom window can now only be done via destroying the PhantomWindowController BUG=328930 TEST=PhantomWindowControllerTest.* Review URL: https://codereview.chromium.org/101773004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244050 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 244005 "Remove SetHostSize/Bounds from RootWindow in favo..."noamsml@google.com2014-01-104-7/+7
| | | | | | | | | | | | | | | > Remove SetHostSize/Bounds from RootWindow in favor of just calling SetBounds() on host() > > R=sky@chromium.org > http://crbug.com/308846 > > Review URL: https://codereview.chromium.org/128753002 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/133003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244033 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 243986 "Fix AdjustBoundsToEnsureWindowVisibility to work ..."oshima@chromium.org2014-01-098-105/+28
| | | | | | | | | | | | | | | | | | | | | > Fix AdjustBoundsToEnsureWindowVisibility to work with non primary display bounds > This was asssuming that the visibile area has 0,0 origin. > > Move the code to ensure minimum visibility when added, from > WorkspaceLayoutManager to DragWindowResizer. > > BUG=none > TEST=WindowUtilTest.AdjustBoundsToEnsureWindowVisibility. > This also fixes the test that was failing. > TBR=oshima@chromium.org > > Review URL: https://codereview.chromium.org/106303005 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/131543006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244021 0039d316-1c4b-4281-b951-d872f2087c98
* Remove SetHostSize/Bounds from RootWindow in favor of just calling ↵ben@chromium.org2014-01-094-7/+7
| | | | | | | | | | | SetBounds() on host() R=sky@chromium.org http://crbug.com/308846 Review URL: https://codereview.chromium.org/128753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244005 0039d316-1c4b-4281-b951-d872f2087c98
* Fix AdjustBoundsToEnsureWindowVisibility to work with non primary display boundsoshima@chromium.org2014-01-098-28/+105
| | | | | | | | | | | | | | | | This was asssuming that the visibile area has 0,0 origin. Move the code to ensure minimum visibility when added, from WorkspaceLayoutManager to DragWindowResizer. BUG=none TEST=WindowUtilTest.AdjustBoundsToEnsureWindowVisibility. This also fixes the test that was failing. TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/106303005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243986 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] Don't remove an item when associated window is draggedsimonhong@chromium.org2014-01-093-10/+228
| | | | | | | | | | | | | | LauncherItem adding/removing is repeated when a Window is dragged because it is reparented to DockedContainer during the dragging. ShelfWindowWatcher should prevent this removing when window is dragging. R=sky@chromium.org BUG=NONE TEST=ash_unittests --gtest_filter=ShelfWindowWatcherTest*.* Review URL: https://codereview.chromium.org/108313006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243970 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] Add TYPE_DIALOG and its item's LauncherContextMenusimonhong@chromium.org2014-01-0919-18/+77
| | | | | | | | | | | | | | This is third CL for adding an item for dialog. This cl adds new LauncherItemType, TYPE_DIALOG, and implements a context menu of item created by ShelfWindowWatcher. R=sky@chromium.org BUG=121242 TEST=NONE Review URL: https://codereview.chromium.org/107163005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243965 0039d316-1c4b-4281-b951-d872f2087c98
* Do not show auto-hidden shelf when dragging a windowvarkha@chromium.org2014-01-092-1/+45
| | | | | | | | | BUG=292238 TEST=ash_unittests --gtest_filter=*ShelfLayoutManagerTest* Review URL: https://codereview.chromium.org/23591049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243964 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Add test for wallpaper-switching bug.derat@chromium.org2014-01-091-3/+31
| | | | | | | | | | | Add a test for the DesktopBackgroundController wallpaper-switching bug that was fixed by r242579. BUG=327443 Review URL: https://codereview.chromium.org/115263004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243761 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression where the active window header was not used for v2 apps on CrOSpkotwicz@chromium.org2014-01-081-12/+5
| | | | | | | | | BUG=331343 TEST=Manual, see bug Review URL: https://codereview.chromium.org/99553008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243677 0039d316-1c4b-4281-b951-d872f2087c98
* Makes Window::Init take a WindowLayerType instead of LayerType.sky@chromium.org2014-01-0819-32/+461
| | | | | | | | | | BUG=none TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/121773003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243656 0039d316-1c4b-4281-b951-d872f2087c98
* Use the tall header for restored browser popups. The new header design uses ↵pkotwicz@chromium.org2014-01-081-1/+1
| | | | | | | | | | | significantly different assets for the headers of browser and non browser windows. Thus it makes sense for popup browser windows to use the tall header like restored tabbed browser windows do. BUG=297187 TEST=None Review URL: https://codereview.chromium.org/123043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243650 0039d316-1c4b-4281-b951-d872f2087c98
* Update the selected resolution to the resolution that is actually selected.oshima@chromium.org2014-01-084-2/+64
| | | | | | | | | | BUG=309720 TEST=covered by test. Also tested manually R=mukai@chromium.org Review URL: https://codereview.chromium.org/106673003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243627 0039d316-1c4b-4281-b951-d872f2087c98
* Rename RootWindowHost to WindowTreeHostben@chromium.org2014-01-0830-99/+99
| | | | | | | | | TBR=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/126513004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243578 0039d316-1c4b-4281-b951-d872f2087c98
* Implements the dialog view for logout confirmation dialog in public sessions.binjin@chromium.org2014-01-0810-13/+705
| | | | | | | | | | | | | | Implements ash::internal::LogoutConfirmationDialogView which is supposed to be used by ash::internal::LogoutButtonTray. BUG=223846 TEST=new unit test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242286 Review URL: https://codereview.chromium.org/40053002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243530 0039d316-1c4b-4281-b951-d872f2087c98
* The new design of the window headers does not use a super transparent window ↵pkotwicz@chromium.org2014-01-0811-904/+3
| | | | | | | | | | | | | | | header when there is just one window on screen. The solo window feature is also broken in the M32 and M33 branches (crbug.com/330212) BUG=297187 TEST=None R=jamescook TBR=oshima (For trivial change in chrome/browser/chromeos/login/login_display_host_impl.*) Review URL: https://codereview.chromium.org/123023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243500 0039d316-1c4b-4281-b951-d872f2087c98
* ToplevelWindowEventHandler::HandleMousePressed() has some comments about ↵pkotwicz@chromium.org2014-01-082-9/+1
| | | | | | | | | | | | | only handling events post target. Those comments are untrue so remove them. It is also non trivial to get the originally desired behavior, namely getting mouse events to HTML elements with the "-webkit-app-region" CSS style applied. BUG=None TEST=None Review URL: https://codereview.chromium.org/108723008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243439 0039d316-1c4b-4281-b951-d872f2087c98
* Moves management of transients out of Windowsky@chromium.org2014-01-0722-64/+95
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | And into TransientWindowManager. Additionally moves handling of NULL layer stacking into TransientStackingWindowClient. The tests that were exercising these code paths have all been moved to ui/views/corewm. Also wires up TransientStackingWindowClient in a couple of places that didn't have it. The order of removing from transient parent as well as destroying of transient children is slightly differently than before. To get the order exactly as it was would require some new specific observer functions. I'm hoping we don't need those. Hopefully this doesn't cause issues, if it does I'll revisit. I ended up exposing convenience functions. That's because typing something like: views::corewm::TransientWindowManager::Get(window)->AddTransientChild() was too much for me. There is also some subtlety in so far as the Get() function that takes a const Window* may return NULL, where as non-const never returns NULL. Lastly I had to make Window friend TransientWindowManager. This is temporary until I create a specific TransientWindowManagerObserver that contains the two transient related observer functions in WindowObserver. BUG=none TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/115453004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243368 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Use the easy-resize window targeter for some window containers.sadrul@chromium.org2014-01-072-0/+75
| | | | | | | | | BUG=318879 R=ben@chromium.org Review URL: https://codereview.chromium.org/125333004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243286 0039d316-1c4b-4281-b951-d872f2087c98
* GetDisplayNearestPoint returns the nearest display when point is outside of ↵varkha@chromium.org2014-01-073-9/+67
| | | | | | | | | | | any display. BUG=146893 TEST=ash_unittests --gtest_filter=DisplayControllerTest.FindNearestDisplay Review URL: https://codereview.chromium.org/99163006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243273 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression preventing sticky key from being enabled after moving mouse.tengs@chromium.org2014-01-072-1/+39
| | | | | | | | | BUG=331399 TEST=unit test Review URL: https://codereview.chromium.org/125533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243262 0039d316-1c4b-4281-b951-d872f2087c98
* Move CycleDirection enum into shelf_constants.tfarina@chromium.org2014-01-074-8/+8
| | | | | | | | | | | | | | | | I decided to move it there, because enum really defines 'constants'. I'm considering moving the remaining of launcher_types.h into a new file called shelf_item.h, since the types there are really related/tied to ShelfItem. BUG=248353 TEST=None, no functional changes R=jamescook@chromium.org,harrym@chromium.org Review URL: https://codereview.chromium.org/123073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243247 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust ChromeVox notification strings.dtseng@chromium.org2014-01-071-2/+2
| | | | | | | | | BUG=261451 TEST=Manual Review URL: https://codereview.chromium.org/112633007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243237 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminates gap at the top and bottom of docked areavarkha@chromium.org2014-01-072-33/+34
| | | | | | | | | | | | BUG=331872 TEST=Visual Dock one browser window - should take all vertical space. Dock two browser windows - should reach to top / bottom of the docked area. TEST=ash_unittests --gtest_filter=*Dock* Review URL: https://codereview.chromium.org/101383004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243236 0039d316-1c4b-4281-b951-d872f2087c98
* Updating XTBs based on .GRDs from branch 1750laforge@chromium.org2014-01-0752-10/+62
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243211 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enables docked windows by default in M34 (reverts issue 109663002)varkha@chromium.org2014-01-066-31/+24
| | | | | | | | | | | | | BUG=None TEST=Visual 1. in chrome://flags verify that ash-disable-docked-windows is present. 2. in chrome://flags verify that ash-enable-docked-windows is absent. 3. When running chrome without ash-enable-docked-windows it should be possible to dock a window at a screen edge. TEST=ash_unittests --gtest_filter=*Dock* Review URL: https://codereview.chromium.org/123743003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243178 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Add an EasyResizeWindowTargeter.sadrul@chromium.org2014-01-064-1/+196
| | | | | | | | | | | | | | | | | | Add EasyResizeWindowTargeter to allow easily resizing windows with mouse/touch with the new event-dispatch code. This will eventually allow getting rid of Window::SetHitTestBoundsOverrideOuter() once the new event-dispatch code is used for all event types. This patch installs an EasyResizeWindowTargeter for the shelf and status-area widgets. Subsequent CLs will install such targeters for the toplevel windows too. Collateral change includes adding some dependencies on wm_public (in DEPS and gyp). BUG=318879 R=ben@chromium.org Review URL: https://codereview.chromium.org/118553004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243177 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup: Don't generate ash_resources_map, they're not used.thakis@chromium.org2014-01-031-2/+0
| | | | | | | | | | BUG=297672 R=ajwong@chromium.org TBR=oshima Review URL: https://codereview.chromium.org/100483011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242847 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused parameter in ash::WindowResizer::CompleteDrag()pkotwicz@chromium.org2013-12-2822-81/+67
| | | | | | | | | | BUG=None TEST=None TBR=oshima Review URL: https://codereview.chromium.org/122093003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242694 0039d316-1c4b-4281-b951-d872f2087c98
* AppListItemModel -> AppListItemstevenjb@chromium.org2013-12-271-4/+4
| | | | | | | | | | | | | As previously discussed, reenaming class to reduce confusion with AppListModel. BUG=none For ash/shell and c/b/sync: TBR=sky@chromium.org,zea@chromium.org Review URL: https://codereview.chromium.org/112593005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242638 0039d316-1c4b-4281-b951-d872f2087c98
* Start the move of launcher_types.h to shelf.tfarina@chromium.org2013-12-2716-39/+71
| | | | | | | | | | | | | | I decided to split the constants into its own component to make the transition easier to do and review. BUG=248353 TEST=None, no functional changes R=jamescook@chromium.org,harrym@chromium.org TBR=tapted@chromium.org # for c/b/ui/apps Review URL: https://codereview.chromium.org/97983003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242588 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Fix DesktopBackgroundController getting stuck.derat@chromium.org2013-12-272-40/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix an issue where DesktopBackgroundController gets confused and stops switching wallpapers. The following sequence of events triggers the bug: a) Default wallpaper is requested and starts getting loaded from disk. b) Before default wallpaper has been loaded, custom wallpaper is requested. c) Default wallpaper is requested again. At b), the default wallpaper load operation is canceled but the WallpaperLoader object is retained. At c), DesktopBackgroundController incorrectly sees the still-present WallpaperLoader and believes that the default wallpaper is still being loaded. This leaves DesktopBackgroundController in a state where it never switches back to the default wallpaper. The fix is to disregard the existing WallpaperLoader if it has already been canceled. BUG=327443 Review URL: https://codereview.chromium.org/110463004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242579 0039d316-1c4b-4281-b951-d872f2087c98
* Clean-up: Replaces gfx::Font with gfx::FontList in ash/.yukishiino@chromium.org2013-12-2611-25/+36
| | | | | | | | | | | | | As part of effort to support multiple fonts, this CL changes methods which are now taking gfx::Font so they will take gfx::FontList instead. See https://docs.google.com/a/chromium.org/document/d/1D_25fp9B8b9aZJORfAjDIFq61NWvUquZ5xmKH-VcC4k/view BUG=265485 TEST=Run unit_tests, ui_unittests, views_unittests, ash_unittests. Review URL: https://codereview.chromium.org/110953006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242535 0039d316-1c4b-4281-b951-d872f2087c98
* This CL refactors ToplevelWindowEventHandler and TwoFingerDragHandler to ↵pkotwicz@chromium.org2013-12-264-175/+201
| | | | | | | | | | | | | | | | | | | make merging the two easier. Notable changes: - Fixed weirdness due to initiating tab dragging while a different drag is in progress. - Makes it no longer possible to alter the window's show type via a fling while resizing (vs moving) the window. - Moved all of the code to set the state when beginning / completing a drag to ToplevelWindowEventHandler::AttemptToStartDrag() and ToplevelWindowEventHandler::CompleteDrag() - Removed unneeded code to animate to the side snapped states - Made the instances where ToplevelWindowEventHandler::OnGestureEvent() stops propagation more obvious BUG=324038 TEST=ToplevelWindowEventHandlerTest.RunMoveLoopRevertsInProgressDrag Review URL: https://codereview.chromium.org/115863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242511 0039d316-1c4b-4281-b951-d872f2087c98
* Update some uses of char16 to use the base:: namespace.avi@chromium.org2013-12-251-1/+1
| | | | | | | | | | BUG=329295 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/113403006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242503 0039d316-1c4b-4281-b951-d872f2087c98
* Update uses of UTF conversions in android_webview/, apps/, ash/, chrome/app ↵avi@chromium.org2013-12-2438-166/+183
| | | | | | | | | | | | to use the base:: namespace. BUG=330556 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/102443009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242444 0039d316-1c4b-4281-b951-d872f2087c98
* Correct the operation of the --high-dpi-support=1 flag under win/ash.girard@chromium.org2013-12-241-0/+7
| | | | | | | | BUG=319941 Review URL: https://codereview.chromium.org/59213007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242430 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 242286 "Implements the dialog view for logout confirmatio..."thakis@chromium.org2013-12-2210-702/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Broke ash_unittests on the cros asan bot, starting here: http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASAN%20Tests%20%281%29/builds/14682 Example leaks: Indirect leak of 584 byte(s) in 1 object(s) allocated from: #0 0x48e7d9 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:52 #1 0x147ca2f in ash::internal::LogoutConfirmationDialogView::LogoutConfirmationDialogView(ash::internal::LogoutButtonTray*, ash::internal::LogoutConfirmationDialogView::Delegate*) ash/system/logout_button/logout_confirmation_dialog_view.cc:39 #2 0x147b683 in EnsureConfirmationDialogIsShowing ash/system/logout_button/logout_button_tray.cc:158 #3 0x147b683 in ash::internal::LogoutButtonTray::ButtonPressed(views::Button*, ui::Event const&) ash/system/logout_button/logout_button_tray.cc:204 #4 0x94e05f in ash::internal::LogoutConfirmationDialogTest::PressButton() ash/system/logout_button/logout_button_tray_unittest.cc:230 #5 0x953d63 in ash::internal::LogoutConfirmationDialogTest_UserClickedButton_Test::TestBody() ash/system/logout_button/logout_button_tray_unittest.cc:317 #6 0xf8b77a in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #7 0xf8d77c in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #8 0xf8e6f2 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #9 0xf9f585 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #10 0xf9eade in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #11 0xf9eade in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #12 0xf4aa22 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #13 0xf4aa22 in base::TestSuite::Run() base/test/test_suite.cc:213 #14 0xf411ef in Run base/callback.h:401 #15 0xf411ef in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:505 #16 0x9a49f5 in main ash/test/ash_unittests.cc:12 #17 0x7fd291b1676c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Indirect leak of 560 byte(s) in 1 object(s) allocated from: #0 0x48e7d9 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:52 #1 0x147b64f in EnsureConfirmationDialogIsShowing ash/system/logout_button/logout_button_tray.cc:158 #2 0x147b64f in ash::internal::LogoutButtonTray::ButtonPressed(views::Button*, ui::Event const&) ash/system/logout_button/logout_button_tray.cc:204 #3 0x94e05f in ash::internal::LogoutConfirmationDialogTest::PressButton() ash/system/logout_button/logout_button_tray_unittest.cc:230 #4 0x953d63 in ash::internal::LogoutConfirmationDialogTest_UserClickedButton_Test::TestBody() ash/system/logout_button/logout_button_tray_unittest.cc:317 #5 0xf8b77a in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #6 0xf8d77c in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #7 0xf8e6f2 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #8 0xf9f585 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #9 0xf9eade in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #10 0xf9eade in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #11 0xf4aa22 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #12 0xf4aa22 in base::TestSuite::Run() base/test/test_suite.cc:213 #13 0xf411ef in Run base/callback.h:401 #14 0xf411ef in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:505 #15 0x9a49f5 in main ash/test/ash_unittests.cc:12 #16 0x7fd291b1676c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 > Implements the dialog view for logout confirmation dialog in public sessions. > > Implements ash::internal::LogoutConfirmationDialogView which is supposed > to be used by ash::internal::LogoutButtonTray. > > BUG=223846 > TEST=new unit test > > Review URL: https://codereview.chromium.org/40053002 TBR=binjin@chromium.org Review URL: https://codereview.chromium.org/116083003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242329 0039d316-1c4b-4281-b951-d872f2087c98
* Update uses of Value in android_webview, apps, ash, cc to use the base:: ↵avi@chromium.org2013-12-214-15/+15
| | | | | | | | | | | | namespace. BUG=88666 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/118293005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242292 0039d316-1c4b-4281-b951-d872f2087c98
* Implements the dialog view for logout confirmation dialog in public sessions.binjin@chromium.org2013-12-2110-13/+702
| | | | | | | | | | | | Implements ash::internal::LogoutConfirmationDialogView which is supposed to be used by ash::internal::LogoutButtonTray. BUG=223846 TEST=new unit test Review URL: https://codereview.chromium.org/40053002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242286 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 242116 "Use a single ToplevelWindowEventHandler for the a..."pkotwicz@chromium.org2013-12-2014-71/+105
| | | | | | | | | | | | | | | > Use a single ToplevelWindowEventHandler for the ash::Shell. This is part 1 in disabling the few cases in which dragging multiple windows is possible (which causes crashiness) > > BUG=324038 > TEST=None > > Review URL: https://codereview.chromium.org/114643003 TBR=pkotwicz@chromium.org Review URL: https://codereview.chromium.org/115693009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242198 0039d316-1c4b-4281-b951-d872f2087c98
* Adds views::corewm::WMState to install common statesky@chromium.org2013-12-205-19/+25
| | | | | | | | | | | | | | I'm going to need to install a another singleton client for transients. Rather than touch all places to explicitly set n clients I'm creating Environment to centralize common setup and teardown. BUG=none TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/105813013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242126 0039d316-1c4b-4281-b951-d872f2087c98
* Use a single ToplevelWindowEventHandler for the ash::Shell. This is part 1 ↵pkotwicz@chromium.org2013-12-2014-105/+71
| | | | | | | | | | | in disabling the few cases in which dragging multiple windows is possible (which causes crashiness) BUG=324038 TEST=None Review URL: https://codereview.chromium.org/114643003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242116 0039d316-1c4b-4281-b951-d872f2087c98
* [ash] Create applist button's context menu in its ShelfItemDelegatesimonhong@chromium.org2013-12-202-7/+3
| | | | | | | | | | | | The context menu of applist button should create by its ShelfItemDelegate. R=jamescook@chromium.org BUG=NONE TEST=manual test Review URL: https://codereview.chromium.org/119643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242083 0039d316-1c4b-4281-b951-d872f2087c98
* Move sticky keys files to their own directory and rename to ↵tengs@chromium.org2013-12-207-43/+44
| | | | | | | | | | | | | | StickyKeysController. There will be new files added for the sticky keys UI in the future, and this refactor improves organization for sticky keys code and is more inline with how the other accessibility features are organized. TEST=StickyKeysTests pass Review URL: https://codereview.chromium.org/118543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242036 0039d316-1c4b-4281-b951-d872f2087c98
* Move some non-event related functionality from RootWindow onto RootWindowHost.ben@chromium.org2013-12-1910-32/+34
| | | | | | | | | | | | | | - Transform logic - Compositor R=sky@chromium.org http://crbug.com/308843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236017 Review URL: https://codereview.chromium.org/70103020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241929 0039d316-1c4b-4281-b951-d872f2087c98
* Prefix string16 with base:: in ash/.dbeam@chromium.org2013-12-1911-21/+23
| | | | | | | | | R=sky@chromium.org BUG=329295 Review URL: https://codereview.chromium.org/118903002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241898 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-04 10:36:33 +0000