| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
R=ben@chromium.org
BUG=117682
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9702024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=ben@chromium.org
BUG=118116
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9706007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Tile app list item horizontally;
- Move item title to the bottom;
- Update padding for model view: 45px from left/right and 32px from top/bottom;
- Change shade from 0.4 black to 0.2 black;
- Update animation;
- Defer app list widget activation until showing animation is finished;
BUG=117238,117073
TEST=Verify fix for issue 117238.
Review URL: https://chromiumcodereview.appspot.com/9677065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=117292
TEST=manually
Review URL: http://codereview.chromium.org/9691037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=116213
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9701011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=116572
R=asvitkine@chromium.org
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9702009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
where this makes sense. I didn't change the class that is
potentially global and not root specific.
This also removes ToplevelLayoutManager that is not longer in use.
BUG=115510
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9665016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-upload of http://codereview.chromium.org/9635003
BUG=114546
TEST=See issue. Also ensure that behavior is expected with multiple windows open, including multiple windows with modal dialogs.
Review URL: http://codereview.chromium.org/9694050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Show a different icon in the launcher for incognito windows
TBR=sky@chromium.org
BUG=116932
TEST=Open an incognito window and a normal window. Check that the icons are different
Review URL: http://codereview.chromium.org/9691027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The mocks call for resize handles to function along a single pixel edge inside the window, overlapping the web content. Refactored aura::Window::set_hit_test_bounds_inset() into SetHitTestBoundsOverride() to make hover/click events along that border pass through to the non-client area of the window frames. This also allows windows to be resized when they are flush against the top/left/right edges of the screen.
BUG=117542
TEST=aura_shell_unittests ShelfLayoutManager, manually resize window from left/right/bottom/top edges
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126539
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=126544
Review URL: https://chromiumcodereview.appspot.com/9694012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mocks call for resize handles to function along a single pixel edge inside the window, overlapping the web content. Use the aura::Window::set_hit_test_bounds_inset() functionality to make hover/click events along that border pass through to the non-client area of the window frames. This also allows windows to be resized when they are flush against the top/left/right edges of the screen.
BUG=117542
TEST=aura_shell_unittests ShelfLayoutManager, manually resize window from left/right/bottom/top edges
Review URL: http://codereview.chromium.org/9694012
TBR=jamescook@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9705011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mocks call for resize handles to function along a single pixel edge inside the window, overlapping the web content. Use the aura::Window::set_hit_test_bounds_inset() functionality to make hover/click events along that border pass through to the non-client area of the window frames. This also allows windows to be resized when they are flush against the top/left/right edges of the screen.
BUG=117542
TEST=aura_shell_unittests ShelfLayoutManager, manually resize window from left/right/bottom/top edges
Review URL: http://codereview.chromium.org/9694012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=110130, 115357
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9694049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=116572
R=asvitkine@chromium.org
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9663077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
win_aura bot.
Aura/Ash split: Move ScreenAura to aura::RootWindowScreen.
What is now aura::RootWindowScreen was tightly bundled with aura::RootWindow. Instead of moving it to ash::ScreenAsh, I renamed it aurea::RootWindowScreen because there's a bunch of unit tests that use RootWindow as if it were the desktop. Screen integration stuff has been moved out of RootWindow (and related observers) and into ash::Shell.
BUG=116458
First Review URL: http://codereview.chromium.org/9616045
Review URL: http://codereview.chromium.org/9696008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=114546
TEST=See issue. Also ensure that behavior is expected with multiple windows open, including multiple windows with modal dialogs.
Review URL: http://codereview.chromium.org/9635003
TBR=stevenjb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9692060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=110143
TEST=Test favicons thoroughly in general + favicons for aura panels
Review URL: http://codereview.chromium.org/9618023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=114546
TEST=See issue. Also ensure that behavior is expected with multiple windows open, including multiple windows with modal dialogs.
Review URL: http://codereview.chromium.org/9635003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
build.
Only support change between default background images currently.
Need more refactor work on code.
BUG=105508
TEST=
Review URL: http://codereview.chromium.org/9580023
TBR=bshe@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9695033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky@chromium.org
BUG=chromium-os:25682
TEST=None
Review URL: http://codereview.chromium.org/9689040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
screen size.
TEST=none
BUG=116213
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9691012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only support change between default background images currently.
Need more refactor work on code.
BUG=105508
TEST=
Review URL: http://codereview.chromium.org/9580023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Make AppListModelView focusable;
- Arrow keys to navigate around app list;
BUG=117070
TEST=Verify arrow keys could move around in app list.
Review URL: http://codereview.chromium.org/9664075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=116932
TEST=Open an incognito window and a normal window. Check that the icons are different
Review URL: https://chromiumcodereview.appspot.com/9649013
TBR=zork@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9692021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=116932
TEST=Open an incognito window and a normal window. Check that the icons are different
Review URL: https://chromiumcodereview.appspot.com/9649013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Ctrl+Shift+F1 brings it up.
http://crbug.com/97266
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9662022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=110130
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9663060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
At the root_window.cc level we defer mouse events triggering a resize while a draw is pending. We are careful to keep the sequence of different event types the same. But we aggregate synthetic mouse moves and mouse drags wwhere possible.
In RWHVA, we ask the root window to throttle the resize if we are waiting on the GPU process for a new image. The net result is that UI can only be one frame ahead of the tab contents that are being resized.
BUG=58782
TEST=goto google.com with --force-compositing-mode; resize the window by stretching to the right; see very little gap between tab contents and window frame
Review URL: https://chromiumcodereview.appspot.com/9662020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
With this change, you can press the hotkey (ctrl-f2) to reach the status-tray with the keyboard, and press space or enter to trigger the popup.
BUG=110130
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9668032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ContextMenuController::ShowContextMenuForView().
BUG=117092
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9665008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=116572
R=asvitkine@chromium.org
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9662034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20UI%20%28valgrind%29%288%29/builds/1350/steps/memory%20test%3A%20unit/logs/A101C11CC97B99B5
BUG=None
TEST=None
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/9663041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=115510
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9664010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=115650
TEST=None
Review URL: https://chromiumcodereview.appspot.com/9633005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
What is now aura::RootWindowScreen was tightly bundled with aura::RootWindow. Instead of moving it to ash::ScreenAsh, I renamed it aurea::RootWindowScreen because there's a bunch of unit tests that use RootWindow as if it were the desktop. Screen integration stuff has been moved out of RootWindow (and related observers) and into ash::Shell.
BUG=116458
Review URL: http://codereview.chromium.org/9616045
TBR=erg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9667017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
What is now aura::RootWindowScreen was tightly bundled with aura::RootWindow. Instead of moving it to ash::ScreenAsh, I renamed it aurea::RootWindowScreen because there's a bunch of unit tests that use RootWindow as if it were the desktop. Screen integration stuff has been moved out of RootWindow (and related observers) and into ash::Shell.
BUG=116458
Review URL: http://codereview.chromium.org/9616045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=110130
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9600062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also fixes DCHECKs when you resize the windows too small.
BUG=116872
TEST=manual, resize a browser window to the smallest size possible, can see a tab, can see frame controls
Review URL: https://chromiumcodereview.appspot.com/9669008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Widgets of TYPE_WINDOW have potentially transparent frames on Ash. I was initializing the transparency flag in the wrong place, leading to a subset of dialogs (edit bookmark, app shortcut, restart chrome, etc.) having black pixels at their outside corners and the wrong appearance in the inactive state. Inspection of the Widget::CreateWindow* callers suggests this is the right place to put this.
BUG=117411
TEST=visual inspection of bookmark windows
Review URL: https://chromiumcodereview.appspot.com/9653011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When volume/brightness is changed from the keyboard (or by other means), the popup that shows up should not be activated/focused. Also, when a volume popup shows up to replace a brightness popup (or vice versa), it should not crash.
BUG=110130
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9669002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=116079
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9648013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
give an indication as to where on the grid the window will land when
dropped.
BUG=116213
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9646007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the bounds can trigger mouse moved, which can trigger attempting to
cancel a tab dragging operation thereby destroying the resizer.
BUG=none
TEST=none
R=jennyz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9648016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I would like to use this data from the keyboard overlay.
BUG=117365
TEST=Manually checked the global shortcuts work as before.
Review URL: http://codereview.chromium.org/9632022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
screen.
This makes the bottom-right corner a click target for the tray. want.
BUG=110130
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9633008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=117086
Test=None
Review URL: http://codereview.chromium.org/9625018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The final goal is to merge these two classes into a single gfx::Canvas class.
BUG=116572
R=ben@chromium.org,asvitkine@chromium.org
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9562038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The tray-delegate has a LockScreen function that is used to lock the screen. It
turns out, PowerManagerClient::Observer has an observer callback, also called
LockScreen, which gets called when the screen is locked. As a result, when the
user locks the screen, the observer's LockScreen gets called again, and it falls into a cycle.
In short, you dawg, I heard you like to lock your screen, so I locked your screen
while I tell you that I locked your screen.
Renamed to RequestLockScreen to avoid the collision.
BUG=110130
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9649008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=117101
TEST=Turn off cookies, go to popuptest.com, open cookie management dialog, verify it has new frames
Review URL: https://chromiumcodereview.appspot.com/9649002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9653003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125672 0039d316-1c4b-4281-b951-d872f2087c98
|