| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/10174037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allow chrome/ash to run on high density screen in High Density Incompatible mode (everything scaled to 2x), except for web contents.
I put this behind ENABLE_DIP to avoid regression. I'll make it runtime flag next week when we get render working.
BUG=114666
TEST=manual: run with --aura-host-window-size=1000x800*2.
Review URL: https://chromiumcodereview.appspot.com/10081011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=125310
TEST=Verify fix for issue 125310.
Review URL: http://codereview.chromium.org/10257009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
down. We were never releasing the capture, so the modal window never
got any mouse events.
I didn't use ScopedObserver for this one as I'm going to merge this to m19.
BUG=125361
TEST=covered by unit tests
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10170036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I have increased the padding in the assets used for the buttons when running with touch optimized ui enabled.
BUG=115520
TEST=Run with --touch-optimized-ui and verify that maximize and close buttons are large and all assets look correct.
Review URL: http://codereview.chromium.org/10159002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL move the wallpaper widget initialization to right after a OnWindowResized
call in shell.cc, so the widget can get correct bounds size and animate.
BUG=125084
TEST=On a chromebook, open a browser and go to about:inducebrowsercrashforrealz to
trigger a browser crash. After browser restore, verify the wallpaper also restored,
instead of a white background.
Review URL: http://codereview.chromium.org/10233022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
deps. Most of these are already listed in DEPS files, and it seems that we want to prevent includes on them just like normal directories that are in our tree (otherwise content can depend on native_client, for ex)
Review URL: https://chromiumcodereview.appspot.com/10248005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=123154, 124861
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10171021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
never removing them. This is problematic as it is possible for a
Window to be destroyed after the shell.
ScopedObserver is pretty generic, but I'll leave it here for now.
BUG=124860
TEST=covered by unit test
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10206027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because we never set launcher_, we never called RemoveObserver.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/10209019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=125102
TEST=aura_shell_unittests --gtest_filter=*Panel* --aura-panels
Review URL: http://codereview.chromium.org/10173016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=132208
TEST=System tray panel should refresh to show bluetooth adapter status when it is plugged in for the case described in the bug.
Review URL: http://codereview.chromium.org/10214005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace OnWidgetActivationChanged handling with OnWindowFocused handling because
we need notification on active window change for any window rather than just for
applist window.
BUG=124874
TEST=Verify fix for issue 124874.
Review URL: http://codereview.chromium.org/10233014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the click.
BUG=122302
TEST=Manual
Review URL: http://codereview.chromium.org/10201002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch contains only the graphics layer. The control layer will be on another patch.
BUG=chromium-os:26713
TEST=manual
Review URL: http://codereview.chromium.org/9950082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=120806
TEST=None
Review URL: http://codereview.chromium.org/10226006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133982
Review URL: https://chromiumcodereview.appspot.com/9956056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with 133961.
---
ash: Add accelerator for snapping windows left/right.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9956056
TBR=sadrul@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10223014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9956056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Moved Monitor class to gfx/.
* Converted all use of gfx::Screen to match new API
BUG=115347,111990
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9960042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This item is only shown for GSM modems w/o SIM card and when mobile config has setup URL defined (initial locale specific).
Initial locale (ex.: en-US, de, es) defines a country where ChromeOS device was bought.
Depends on http://codereview.chromium.org/10141006/
BUG=chrome-os-partner:8092
TEST=Manual.
Review URL: http://codereview.chromium.org/10201015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since panel windows aren't transparent, we didn't draw anything so the
titlebars for panels were black with buttons drawn on top.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/10169044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=123856
BUG=120196
TEST=manual
Review URL: http://codereview.chromium.org/10155022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The regression is introduced in r133603 where we use opacity to hide
newly added view but did not restore it properly on animation cancellation,
which happens when adding launcher item before animation finishes.
BUG=124855
TEST=Verify fix for issue 124855.
Review URL: http://codereview.chromium.org/10169038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
screen bounds.
- Renames aura::Window::GetScreenBounds() to ::GetBoundsInRootWindow(),
which is what it really does.
- NativeWidgetAura now gives its NativeWidgetHelperAura a chance to
modify those bounds.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/10210005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=124864
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10218002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Issue 10146016 was the original issue. It failed on linux_chromeos.
TBR=ben,flackr
BUG=118651
TEST=
Review URL: http://codereview.chromium.org/10205013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
changes.
BUG=124464
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10200006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=sadrul@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10202012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move the remaining status-area code into system-tray.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10140017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move the remaining status-area code into system-tray.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10140017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=124330
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10206016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/ui/views/accelerator_table.cc when USE_ASH is #defined.
The shortcuts should be excluded since they're already included in ash/accelerators/accelerator_table.cc. Removing this kind of duplication is necessary for implementing crbug.com/123856 correctly. Along with the change, add unit tests for preventing the same mistake in the future.
BUG=123856
TEST=ran unit_tests
Review URL: http://codereview.chromium.org/10177002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is for crbug.com/123856 (Aura shell applies accelerators without giving apps the option of handling key events). Currently, shortcuts for IME/layout switching (Shift+Alt, Ctrl+space, and so on) are processed before InputMethodEventFilter, and other Ash global shortcuts are processed after the filter. This is for ensuring that the IME shortcuts always work even if an IME (or an IME extension - http://dev.chromium.org/developers/design-documents/extensions/proposed-changes/apis-under-development/input-method-editor) tries to consume the shortcuts. However, this strategy is not compatible with crbug.com/123856. In order to fix crbug.com/123856, we sometimes have to process an Ash global shortcut key (including IME ones) after the key is passed to a web page.
This CL modifies accelerator_table.cc and shell.cc so that they process IME shortcuts after InputMethodEventFilter, and also simplifies ash/accelerators/ and ui/base/accelerators/accelerator_manager.cc by removing code for processing pre-IME shortcuts.
BUG=123856
TEST=ran aura_shell_unittests and ui_unittests
Review URL: https://chromiumcodereview.appspot.com/10155015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Make LauncherView::CalculateIdealBounds to return last visible index;
- In LauncherView::LauncherItemAdded, use the last visible index to determine if
we need the animation;
BUG=122482
TEST=Verify fix for issue 122482.
Review URL: http://codereview.chromium.org/10068027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133603 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
index in C++
In this CL, we replace the old index system with a smarter one.
Its basically the same index system used for default user profile images.
BUG=124035
TEST=
Review URL: http://codereview.chromium.org/10021066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=123961
TEST=added new test
Review URL: http://codereview.chromium.org/10151001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Due to a race between when window show/hide animations change IsVisible() and "solo" window counting for determining header transparency, a missed update when windows are hidden, and FramePainter::PaintHeader() being called repeatedly with different clip rects for widget updates, we could get into a state where the window header has different transparency values behind various views::View widgets.
Fix this by using Window::TargetVisibility() instead of IsVisible() and monitoring for window visibility change events.
BUG=123866
TEST=manual, see bug
Review URL: http://codereview.chromium.org/10192001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifically, animate when a view in the tray hides/shows itself. For now, the
tray does not animate when the size of a view changes (e.g. date-view changes
size because it's 10:00).
BUG=117209
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9969068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=117303
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10139025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL fix the wallpaper fade animation problem. The problem was when user
switched to a new wallpaper, it seems there is a white flashing before new
wallpaper fade in.
The reason was I started the hide animation before loading new wallpaper. And it
took around 300ms to load while the animation finished around 200ms. So there is
100ms period where the background color (white) showed up.
I delayed the hide animation, but then another problem showed up. Now the show
and hide animation happened at the same time. At some point in the animation,
the background color will have 25% opacity and it also cause a flashing.
To fix all, this CL only animate on Show new wallpaper and delete the old widget
after the Show animation completed.
BUG=118651
TEST=Change wallpaper in chromeos, and verify if the animation is smooth.
Review URL: http://codereview.chromium.org/10146016
TBR=bshe@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10184012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL fix the wallpaper fade animation problem. The problem was when user
switched to a new wallpaper, it seems there is a white flashing before new
wallpaper fade in.
The reason was I started the hide animation before loading new wallpaper. And it
took around 300ms to load while the animation finished around 200ms. So there is
100ms period where the background color (white) showed up.
I delayed the hide animation, but then another problem showed up. Now the show
and hide animation happened at the same time. At some point in the animation,
the background color will have 25% opacity and it also cause a flashing.
To fix all, this CL only animate on Show new wallpaper and delete the old widget
after the Show animation completed.
BUG=118651
TEST=Change wallpaper in chromeos, and verify if the animation is smooth.
Review URL: http://codereview.chromium.org/10146016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add accessibility info to app list items and allow them to be focused.
TBR=sky@chromium.org
BUG=120496
TEST=See Bug
Review URL: http://codereview.chromium.org/10139028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
be focused.
R=mukai@chromium.org
BUG=120496
TEST=See Bug
Review URL: http://codereview.chromium.org/9985005
TBR=zork@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10161021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=mukai@chromium.org
BUG=120496
TEST=See Bug
Review URL: http://codereview.chromium.org/9985005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=hashimoto@chromium.org
BUG=chromium-os:29383
TEST=See bug
Review URL: http://codereview.chromium.org/10078009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note that this patch doesn't handle dragging panels to rearrange them (if we want that at all) and panels with no launcher icon because they are in overflow.
BUG=124115
TEST=aura_shell_unittests --gtest_filter=*Panel* --aura-panels
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133309
Review URL: http://codereview.chromium.org/10091017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=122722
TEST=none
Review URL: http://codereview.chromium.org/10166020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133341 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Caused test failures on Win and CrOS:PanelLayoutManagerTest.AddOnePanel)
Note that this patch doesn't handle dragging panels to rearrange them (if we want that at all) and panels with no launcher icon because they are in overflow.
BUG=124115
TEST=aura_shell_unittests --gtest_filter=*Panel* --aura-panels
Review URL: https://chromiumcodereview.appspot.com/10091017
TBR=dcheng@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10134018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Note that this patch doesn't handle dragging panels to rearrange them (if we want that at all) and panels with no launcher icon because they are in overflow.
BUG=124115
TEST=aura_shell_unittests --gtest_filter=*Panel* --aura-panels
Review URL: https://chromiumcodereview.appspot.com/10091017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133309 0039d316-1c4b-4281-b951-d872f2087c98
|