summaryrefslogtreecommitdiffstats
path: root/ash
Commit message (Collapse)AuthorAgeFilesLines
* Removes the space for notification icon if it's not visible (2nd)mukai@chromium.org2013-05-103-10/+29
| | | | | | | | | | | | | | | | | | | | GridLayout will make the space for a child even if the child is not visible, which makes an extra space between status area and panels when there are no notifications. To remove this space, this CL makes StatusAreaWidgetDelegate catch child's visibility change, and do not count invisible children in its GridLayout. The previous CL was reverted due to test break on win_aura. This CL includes its fix. BUG=238770 TBR=stevenjb@chromium.org Review URL: https://chromiumcodereview.appspot.com/14969008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199451 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ash-disable-launcher-per-display flagoshima@chromium.org2013-05-1012-118/+51
| | | | | | | | | BUG=239681 TEST=none Review URL: https://chromiumcodereview.appspot.com/14584004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199368 0039d316-1c4b-4281-b951-d872f2087c98
* Remove AshNativeCursorManagerTest.DisabledMouseEventsLocationoshima@chromium.org2013-05-101-44/+0
| | | | | | | | | | | This no longer makes sense as the location no longer moves outside with https://codereview.chromium.org/14047015. BUG=112222,237659 TEST=none Review URL: https://chromiumcodereview.appspot.com/15082002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199361 0039d316-1c4b-4281-b951-d872f2087c98
* Add --disable-new-dialog-style flag; use DialogDelegate::UseNewStyle(); etc.msw@chromium.org2013-05-091-5/+3
| | | | | | | | | | | | | | | Add a --disable-new-dialog-style flag; matches --enable*. Update the about:flags strings for consistency and clarity. Use DialogDelegate::UseNewStyle() instead of checking flags. (this is in preparation for enabling-by-default soon) BUG=166075 TEST=The about:flags "New Dialog Style" Default/Enabled/Disabled settings and the --[en|dis]able-new-dialog-style command-line flags work as expected, default is still disabled. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/14629017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199302 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Update 2x window control assets.xiyuan@chromium.org2013-05-0924-0/+0
| | | | | | | | | BUG=239638 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/14858032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199301 0039d316-1c4b-4281-b951-d872f2087c98
* keyboard: Allow the proxy to customize the way the keyboard window is ↵sadrul@chromium.org2013-05-091-3/+0
| | | | | | | | | | | shown/hidden. BUG=none R=ben@chromium.org, bryeung@chromium.org Review URL: https://codereview.chromium.org/14310003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199289 0039d316-1c4b-4281-b951-d872f2087c98
* Disable two display-related ash_unittests on Win8 Aurajamescook@chromium.org2013-05-092-2/+18
| | | | | | | | | | | | | DisplayManagerTest.EnsurePointerInDisplays_2ndOnLeft DisplayControllerTest.CursorDeviceScaleFactorSwapPrimary BUG=239539,237642 TEST=ash_unittests TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/14773019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199250 0039d316-1c4b-4281-b951-d872f2087c98
* Magnifier: Prevent the cursor jumping on HiDPI display.yoshiki@chromium.org2013-05-093-59/+59
| | | | | | | | | | | | Magnifier have to use RootWindow::GetRootTransform() instead of getting the transform matrix from the layer because the transform from the layer isn't DPI-unaware. BUG=235928 TEST=manual R=oshima@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/14466005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199249 0039d316-1c4b-4281-b951-d872f2087c98
* Add a "Settings..." menu item to a11y uber menu.yoshiki@chromium.org2013-05-096-2/+20
| | | | | | | | | | | | This patch add a "Settings..." which should go to the a11y section of chrome://settings at the right of "Learn more..." button. BUG=178548 TEST=manual R=stevenjb@chromium.org Review URL: https://codereview.chromium.org/14333028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199196 0039d316-1c4b-4281-b951-d872f2087c98
* views: Convert View::GetClassName() to return const char*.tfarina@chromium.org2013-05-094-5/+5
| | | | | | | | | BUG=235984 R=jamescook@chromium.org,sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/14676008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199164 0039d316-1c4b-4281-b951-d872f2087c98
* Update the volume and audio tray view when TrayAudio is updated.jennyz@chromium.org2013-05-091-1/+5
| | | | | | | | BUG=238853 Review URL: https://chromiumcodereview.appspot.com/14630015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199163 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r199090 and r199077 since these two breaks ↵tzik@chromium.org2013-05-093-26/+8
| | | | | | | | | | | | | | PanelWindowResizerTest.PanelDetachReattachTop and PanelWindowResizerTest.PanelDetachReattachBottom on win8_aura bot. Revert "Removes the space for notification icon if it's not visible." Revert "Fixes a test expectation broken by r199077" TBR=mukai@chromium.org NOTRY=True Review URL: https://chromiumcodereview.appspot.com/14791011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199146 0039d316-1c4b-4281-b951-d872f2087c98
* Save and restore State for ShellWindows, including panels stevenjb@chromium.org2013-05-095-13/+7
| | | | | | | | | | | | | | | | This replaces ShellWindow::CreateParams::State with ui::WindowShowState for simplicty and consistency with Browser session restore. BUG=233556 TBR=flackr@chromium.org, skuhne@chromium.org, sky@chromium.org Original CL: https://codereview.chromium.org/14031021/ + disabled flakey browser tests on linux Review URL: https://chromiumcodereview.appspot.com/14663010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199145 0039d316-1c4b-4281-b951-d872f2087c98
* Make it possible to have both label and avatar for user.antrim@chromium.org2013-05-092-29/+69
| | | | | | | | BUG=234677 Review URL: https://chromiumcodereview.appspot.com/14695008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199119 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a test expectation broken by r199077mukai@chromium.org2013-05-091-1/+1
| | | | | | | | | | It passed on my local machine, but failed on buildbots, possibly because the new expectation (height 800px) is too high under the buildbot environment. Decreasing. TBR=stevenjb@chromium.org Review URL: https://codereview.chromium.org/14629016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199090 0039d316-1c4b-4281-b951-d872f2087c98
* Removes the space for notification icon if it's not visible.mukai@chromium.org2013-05-093-8/+26
| | | | | | | | | | | | | | | | GridLayout will make the space for a child even if the child is not visible, which makes an extra space between status area and panels when there are no notifications. To remove this space, this CL makes StatusAreaWidgetDelegate catch child's visibility change, and do not count invisible children in its GridLayout. BUG=238770 Review URL: https://chromiumcodereview.appspot.com/14688018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199077 0039d316-1c4b-4281-b951-d872f2087c98
* This is the first of two patches to drag and drop items from the app list to ↵skuhne@chromium.org2013-05-0814-26/+205
| | | | | | | | | | | | | | | | | | | the launcher. Everything basically works with this patch, but two essential things are still missing: 1. The icon which gets dragged should get its own widget so that it can get visually dragged outside the app list. 2. The unit tests. They will be send as a second patch because of: a. The patch is already pretty big as it is. b. I want to make get this "signed off" before continuing this route. BUG=166429 TEST=visual, tests come with second patch Review URL: https://chromiumcodereview.appspot.com/14533006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199016 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 198959 "Use GetCursorPos to return the current cursor pos..."sky@chromium.org2013-05-081-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Here's one of the failures (win aura) CustomFrameViewAshTest.MaximizeLeftButtonDragOut: c:\b\build\slave\win_aura_builder\build\src\ash\wm\custom_frame_view_ash_unittest.cc(449): error: Value of: maximize_button->phantom_window_open() Actual: false Expected: true c:\b\build\slave\win_aura_builder\build\src\ash\wm\custom_frame_view_ash_unittest.cc(458): error: Value of: maximize_button->phantom_window_open() Actual: false Expected: true [3080:3328:0508/131455:598497:E > Use GetCursorPos to return the current cursor position in windows ASH instead of relying on the last mouse > coordinates. > > This is needed because some of the real estate in Windows 8 ASH belongs to Windows, i.e. we don't receive mouse > events for portions of the top/top left/top right/bottom parts of the ASH screen. > > This fixes the issue with not being able to exit from the fullscreen mode in ASH. > > BUG=179988 > R=sky@chromium.org > TEST=Manual for Windows ASH at this point. There is work underway to run browser tests for ASH which has fullscreen > tests. > > Review URL: https://codereview.chromium.org/15047004 TBR=ananta@chromium.org Review URL: https://codereview.chromium.org/15003005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198973 0039d316-1c4b-4281-b951-d872f2087c98
* Use GetCursorPos to return the current cursor position in windows ASH ↵ananta@chromium.org2013-05-081-0/+5
| | | | | | | | | | | | | | | | | | | | instead of relying on the last mouse coordinates. This is needed because some of the real estate in Windows 8 ASH belongs to Windows, i.e. we don't receive mouse events for portions of the top/top left/top right/bottom parts of the ASH screen. This fixes the issue with not being able to exit from the fullscreen mode in ASH. BUG=179988 R=sky@chromium.org TEST=Manual for Windows ASH at this point. There is work underway to run browser tests for ASH which has fullscreen tests. Review URL: https://codereview.chromium.org/15047004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198959 0039d316-1c4b-4281-b951-d872f2087c98
* Do not show low battery notification bubble unless battery state is ↵jennyz@chromium.org2013-05-081-1/+1
| | | | | | | | | | | DISCHARGING, which is consistent with the protocol of PowerSupplyProperties. BUG=238802 R=mukai@chromium.org, sschmitz@chromium.org Review URL: https://codereview.chromium.org/14935007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198950 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 198918 "Save and restore State for ShellWindows, includin..."csharp@chromium.org2013-05-085-7/+13
| | | | | | | | | | | | | | | | | | | | | | | | | It looks like this broke InNonGuestMode/FileManagerBrowserLocalTest.TestFileDisplay/0 on Linux ChromiumOS Tests Test Logs: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/13656/steps/browser_tests/logs/stdio > Save and restore State for ShellWindows, including panels > > This replaces ShellWindow::CreateParams::State with > ui::WindowShowState for simplicty and consistency with > Browser session restore. > > BUG=233556 > R=flackr@chromium.org, skuhne@chromium.org, sky@chromium.org > > Review URL: https://codereview.chromium.org/14031021 TBR=stevenjb@chromium.org Review URL: https://codereview.chromium.org/15062002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198927 0039d316-1c4b-4281-b951-d872f2087c98
* Save and restore State for ShellWindows, including panelsstevenjb@chromium.org2013-05-085-13/+7
| | | | | | | | | | | | | This replaces ShellWindow::CreateParams::State with ui::WindowShowState for simplicty and consistency with Browser session restore. BUG=233556 R=flackr@chromium.org, skuhne@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/14031021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198918 0039d316-1c4b-4281-b951-d872f2087c98
* [content shell] move code common to several processes to a common dirjochen@chromium.org2013-05-071-1/+1
| | | | | | | | | BUG=180021 TBR=marja@chromium.org Review URL: https://codereview.chromium.org/14767019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198723 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Clang warnings in .cc files for Linux+[Aura/ChromeOS]rsleevi@chromium.org2013-05-072-3/+6
| | | | | | | | | BUG=115047 R=darin Review URL: https://chromiumcodereview.appspot.com/14890005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198649 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Extract Observer out of ShelfLayoutManager.tfarina@chromium.org2013-05-078-38/+60
| | | | | | | | | | | | | | - Moves it into its own header file. - Add virtual destructor. - Moves it out of internal namespace. BUG=223936 TEST=Nope, this is just a simple clean up, no functionality intended. R=jamescook@chromium.org,sadrul@chromium.org Review URL: https://chromiumcodereview.appspot.com/14562008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198611 0039d316-1c4b-4281-b951-d872f2087c98
* Regression issue with "ShouldHop", the UpdateState->Layout flow was updated ↵jennyz@chromium.org2013-05-072-14/+2
| | | | | | | | | | | during M-27 to resolve a similar issue due to Updates that didn't change bounds not flowing into Layout, however due to some merging/partial reverts, this flow got partially reverted regressing these bugs. BUG=234655 R=davemoore@chromium.org Review URL: https://codereview.chromium.org/14640019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198585 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mouse locking in Chrome AURA Windows and ASH.ananta@chromium.org2013-05-071-8/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Mouse locking is used for e.g. by WebGL and is implemented in the browser by entering a state in the web view where in we ensure that the mouse stays within the boundaries of the view and we send only mouse increment/decrement information to the renderer. We had support for this in Chrome AURA which did not work correctly due to a number of bugs. 1. We need to implement the MoveCursorTo override in the DesktopRootWindowHostWin, DesktopRootWindowHostX11 and RemoteRootWindowHostWin classes which implement the aura RootWindowHost interface. In desktop Chrome windows we invoke the SetCursorPos API to ensure that the cursor is set to the position specified. In desktop Chrome linux we invoke the XWarpPointer API to achieve this. In ASH chrome on Windows we cannot call SetCursorPos in the RemoteRootWindowHostWin class's implementation of the MoveCursorTo function. As mouse input is received by the viewer process and sent to the browser, we have scenarios wherein we receive stale mouse input from the viewer after invoking the SetCursorPos API in the browser. To workaround this we call SetCursorPos API in the viewer process from an IPC MetroViewerHostMsg_SetCursorPos which is sent from the RemoteRootWindowHostWin::MoveCursorTo function. We send out an ACK from the viewer process when the call finishes and in the meantime we ignore any mouse messages coming from the viewer while we wait for the ACK. If we don't do this then we have issues with the image locking up on screen in ASH. In the viewer process we also send out a fake mousemove IPC after the SetCursorPos API as we don't receive the corresponding real mouse move for some reason. This is needed as RVHAura class sets a flag which is reset when it receives the mousemove corresponding to the cursor pos. 2. The RenderWidgetHostViewAura::ShouldMoveToCenter function which checks if the mouse cursor has moved beyond the window bounds needs to convert the window rect to screen. 3. The MakeWebMouseEvent function in the web_input_Event_aura.cc file should use not set the globalX and globalY members in the WebMouseEvent structure from the root coordinates if we have a native mouse event for Windows. This breaks the lock mouse coordinate calculations. I also fixed the implementation of the RootWindowHost::QueryMouseLocation function in the RemoteRootWindowHostWin class and the DesktopRootWindowHostWin class. We can now safely enable the AshNativeCursorManagerTest.DisabledQueryMouseLocation test with some windows specific fixes. BUG=222497 R=cpu@chromium.org, palmer@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/14574010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198582 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the rest of the audio API.rkc@chromium.org2013-05-072-0/+8
| | | | | | | | | | | | | | Picking up where https://codereview.chromium.org/13486004/ left off, implemented the setProperties and setActiveDevices calls; also fixed GetNodes to also return the volume of the devices. R=hshi@chromium.org, jennyz@chromium.org, mpcomplete@chromium.org BUG=175798 TEST=Wrote a test extension to set the volume on the active and inactive devices, to verify they were set correctly. Also wrote code to switch active devices to verify that the devices did switch. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198556 Review URL: https://codereview.chromium.org/14652027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198581 0039d316-1c4b-4281-b951-d872f2087c98
* Removes blue background color for notification icon too.mukai@chromium.org2013-05-071-2/+0
| | | | | | | | | | | | | Same reason as crrev.com/198502, for M28. Now no one is using the blue background color in tray_background_view.cc, but let's keep it to minimize the change and we'll revive it soon in M29. BUG=238516 R=stevenjb@chromium.org Review URL: https://codereview.chromium.org/15021005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198579 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 198556 "Implement the rest of the audio API."rkc@chromium.org2013-05-072-8/+0
| | | | | | | | | | | | | | | | | > Implement the rest of the audio API. > Picking up where https://codereview.chromium.org/13486004/ left off, implemented the setProperties and setActiveDevices calls; also fixed GetNodes to also return the volume of the devices. > > R=hshi@chromium.org, jennyz@chromium.org, mpcomplete@chromium.org > BUG=175798 > TEST=Wrote a test extension to set the volume on the active and inactive devices, to verify they were set correctly. Also wrote code to switch active devices to verify that the devices did switch. > > Review URL: https://codereview.chromium.org/14652027 TBR=rkc@chromium.org Review URL: https://codereview.chromium.org/14655010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198568 0039d316-1c4b-4281-b951-d872f2087c98
* Notify all visible renderers when the visibility of the mouse cursor changestdanderson@google.com2013-05-062-6/+84
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Blink side patch: https://codereview.chromium.org/14047016/ The ultimate goal of both patches is to disallow new hover effects from being invoked in web contents when the mouse cursor is not visible to the user (i.e., while touch scrolling). The job of this patch is to communicate the cursor visibility state to all visible renderers using the new IPC InputMsg_CursorVisibilityChange whenever the visibility state changes. Added the new observer type CursorClientObserver. Subscribers (instances of RenderWidgetHostViewAura) are notified whenever the cursor visibility changes, at which point the IPC is sent to the renderer. I have also removed the code in ash_native_cursor_manager.cc that sets the mouse cursor location to the bogus value of (-10000,-10000) when mouse events are disabled; afaik this was originally added as a way to prevent unwanted hover effects in web contents but it does not work in all cases and causes other problems (see crbug.com/174358). BUG=153784,174358 R=jamesr@chromium.org, kenrb@chromium.org, oshima@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198519 Review URL: https://codereview.chromium.org/14047015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198563 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the rest of the audio API.rkc@chromium.org2013-05-062-0/+8
| | | | | | | | | | | | Picking up where https://codereview.chromium.org/13486004/ left off, implemented the setProperties and setActiveDevices calls; also fixed GetNodes to also return the volume of the devices. R=hshi@chromium.org, jennyz@chromium.org, mpcomplete@chromium.org BUG=175798 TEST=Wrote a test extension to set the volume on the active and inactive devices, to verify they were set correctly. Also wrote code to switch active devices to verify that the devices did switch. Review URL: https://codereview.chromium.org/14652027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198556 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 198519 "Notify all visible renderers when the visibility ..."skaslev@chromium.org2013-05-062-84/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Notify all visible renderers when the visibility of the mouse cursor changes > > Blink side patch: > https://codereview.chromium.org/14047016/ > > The ultimate goal of both patches is to disallow new hover > effects from being invoked in web contents when the mouse > cursor is not visible to the user (i.e., while touch > scrolling). The job of this patch is to communicate the > cursor visibility state to all visible renderers using > the new IPC InputMsg_CursorVisibilityChange whenever the > visibility state changes. > > Added the new observer type CursorClientObserver. > Subscribers (instances of RenderWidgetHostViewAura) are > notified whenever the cursor visibility changes, at which > point the IPC is sent to the renderer. > > I have also removed the code in ash_native_cursor_manager.cc > that sets the mouse cursor location to the bogus value > of (-10000,-10000) when mouse events are disabled; afaik > this was originally added as a way to prevent unwanted > hover effects in web contents but it does not work in all > cases and causes other problems (see crbug.com/174358). > > BUG=153784,174358 > R=jamesr@chromium.org, kenrb@chromium.org, oshima@chromium.org, sky@chromium.org > > Review URL: https://codereview.chromium.org/14047015 TBR=tdanderson@google.com Review URL: https://codereview.chromium.org/14975004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198526 0039d316-1c4b-4281-b951-d872f2087c98
* Introduces a boolean flag for ShouldBlockLauncherAutoHide().mukai@chromium.org2013-05-062-3/+13
| | | | | | | | | | | | | As described in the comment, ShouldBlockLauncherAutoHide() check can be called during the instantiation of message_center_bubble_ itself, therefore check using this member will cause a flicker of shelf. See the bug for the details. BUG=181213 Review URL: https://chromiumcodereview.appspot.com/14887005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198520 0039d316-1c4b-4281-b951-d872f2087c98
* Notify all visible renderers when the visibility of the mouse cursor changestdanderson@google.com2013-05-062-6/+84
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Blink side patch: https://codereview.chromium.org/14047016/ The ultimate goal of both patches is to disallow new hover effects from being invoked in web contents when the mouse cursor is not visible to the user (i.e., while touch scrolling). The job of this patch is to communicate the cursor visibility state to all visible renderers using the new IPC InputMsg_CursorVisibilityChange whenever the visibility state changes. Added the new observer type CursorClientObserver. Subscribers (instances of RenderWidgetHostViewAura) are notified whenever the cursor visibility changes, at which point the IPC is sent to the renderer. I have also removed the code in ash_native_cursor_manager.cc that sets the mouse cursor location to the bogus value of (-10000,-10000) when mouse events are disabled; afaik this was originally added as a way to prevent unwanted hover effects in web contents but it does not work in all cases and causes other problems (see crbug.com/174358). BUG=153784,174358 R=jamesr@chromium.org, kenrb@chromium.org, oshima@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/14047015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198519 0039d316-1c4b-4281-b951-d872f2087c98
* Stop changing background color to blue in status area.mukai@chromium.org2013-05-062-10/+4
| | | | | | | | | | | | | | | We'll decide how it'll look like in M29. This CL doesn't revert the original CL because I've done a few CLs depending on that CL, and that CL also fixes a height issue (crbug.com/234258) as a side effect. BUG=235992 R=stevenjb@chromium.org Review URL: https://codereview.chromium.org/14994002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198502 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 197366 "ash: Update app list button."xiyuan@chromium.org2013-05-0615-200/+63
| | | | | | | | | | | | | | | | | | | | | | | > ash: Update app list button. > > - Update the icons assets; > - Make app list button a ToggleImageButton and wire its > toggle state with app list UI visibility; > - Make app list button icon vertically center aligned and > get rid of the special handling; > - Expose toggled state from ToggleImageButton so that it > could be checked in test; > > BUG=235994 > R=sky@chromium.org > > Review URL: https://codereview.chromium.org/13993027 TBR=jamescook@chromium.org Review URL: https://codereview.chromium.org/14863006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198478 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Rename tray_views.{h,cc} to tray_utils.{h,cc}tfarina@chromium.org2013-05-0621-21/+14
| | | | | | | | | | BUG=174228 R=jamescook@chromium.org TBR=xiyuan@chromium.org # for trivial change in chrome/browser/chromeos/system/ Review URL: https://chromiumcodereview.appspot.com/14949004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198445 0039d316-1c4b-4281-b951-d872f2087c98
* Fix wimax badges for status areastevenjb@chromium.org2013-05-061-3/+3
| | | | | | | | BUG=237655 Review URL: https://chromiumcodereview.appspot.com/14890006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198410 0039d316-1c4b-4281-b951-d872f2087c98
* Do not change the tray background color for popups.mukai@chromium.org2013-05-062-5/+10
| | | | | | | | | | | | Popups are used for some additional info like volume change or screen brightness. We do not want to show blue background for this purpose. BUG=237855 Review URL: https://chromiumcodereview.appspot.com/14595007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198380 0039d316-1c4b-4281-b951-d872f2087c98
* Show more detailed battery states; handle "neither charging nor discharging"sschmitz@chromium.org2013-05-048-67/+217
| | | | | | | | | | | | | | | BUG=172894, 196402 R=jamescook@chromium.org, stevenjb@chromium.org TEST=manual Plug in various power supplies into Spring Reviewers: jamescook@ for ash stevenjb@ for chromeos Review URL: https://chromiumcodereview.appspot.com/14841005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198291 0039d316-1c4b-4281-b951-d872f2087c98
* Sets web_notification tray icon invisible if there're no notifications.mukai@chromium.org2013-05-031-19/+4
| | | | | | | | | | | | Previously the icon is always visible even if there are no notifications, but now it should be invisible in such case. BUG=237981 R=stevenjb@chromium.org Review URL: https://codereview.chromium.org/14645024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198252 0039d316-1c4b-4281-b951-d872f2087c98
* Remove myself from some OWNERS files and make per-file ownership more specific.ben@chromium.org2013-05-031-1/+0
| | | | | | | | | BUG=none R=brettw@chromium.org Review URL: https://codereview.chromium.org/14945002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198229 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes unread_count handling.mukai@chromium.org2013-05-032-2/+23
| | | | | | | | | | | - decrement the unread_count when it's shown as a toast. - increment again if the notification is dismissed by timeout. BUG=234538 Review URL: https://chromiumcodereview.appspot.com/14559004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198218 0039d316-1c4b-4281-b951-d872f2087c98
* Adding artwork fro power iconsskuhne@google.com2013-05-034-0/+0
| | | | | | | | | BUG=172894 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/14759007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198111 0039d316-1c4b-4281-b951-d872f2087c98
* Extend MouseWheelEvent to support both X and Y scrollssheckylin@chromium.org2013-05-031-2/+6
| | | | | | | | | | | | | | | | | | The patch extends the ui::MouseWheelEvent class to support X (horizontal) scrolls and updates the corresponding interface in event_utils.h. It also revises throughout the codebase where the old method calls were used. Contributed by sheckylin@chromium.org BUG=231419 TEST=Tested on device. Change-Id: I86a7b6b62ec4ac8c296251a2333234170f1cd2e7 Review URL: https://chromiumcodereview.appspot.com/13829007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198086 0039d316-1c4b-4281-b951-d872f2087c98
* Disable AshNativeCursorManagerTest.DisabledMouseEventsLocationxiyuan@chromium.org2013-05-031-8/+3
| | | | | | | | BUG=237659 Review URL: https://chromiumcodereview.appspot.com/14561005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198081 0039d316-1c4b-4281-b951-d872f2087c98
* Support Shift+Search+Arrows to navigate and Control to silence speech everywheredmazzoni@chromium.org2013-05-028-2/+61
| | | | | | | | | | | | | Adds new ash keyboard shortcuts that mirror common ChromeVox keys, for use everywhere else in the UI. Only activated when spoken feedback is on. See bug for more info. BUG=236922 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/14674002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197991 0039d316-1c4b-4281-b951-d872f2087c98
* Disable DisplayControllerTest.SwapPrimary and SwapPrimaryById on win+aura.mattm@chromium.org2013-05-021-2/+14
| | | | | | | | | | | They crash flakily on win8 aura bots. BUG=237642 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/14705007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197980 0039d316-1c4b-4281-b951-d872f2087c98
* Adding Alt+1 for browser switching. Part of this CL will get reverted once ↵skuhne@chromium.org2013-05-022-2/+22
| | | | | | | | | | | | | | 11596003 lands. This patch contains the second part of the ALt+<number> application switching: Switching the content of the chrome icon. With a landed CL 11596003 this would have been much easier and as such this is partially temporary and will be reverted with the mentioned CL. BUG=230903 TEST=unittest Review URL: https://chromiumcodereview.appspot.com/14786011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197925 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-16 10:07:52 +0000