| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The show press gesture fires a set time after a tap down event occurs, if
nothing has happened to cancel the tap gesture. This change also makes views
menus listen to show press, instead of tap down, avoiding menu items flashing
active on scroll.
Tap down gestures are temporarily disabled by the GEF, a later patch will enable them once
they're handled correctly in Blink. Their functionality has been replaced by the show press gesture.
See crbug.com/302752#c1 for more details on cleanup work required after this patch.
BUG=302752
TEST=GestureRecognizerTest.GestureEventShowPress, GestureRecognizerTest.GestureEventShowPressCancelledByScroll, GestureRecognizerTest.GestureEventShowPressSentOnTap
Review URL: https://codereview.chromium.org/26419004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
overview.
BUG=276502
TEST=Create several differently shaped windows (i.e. some tall, some wide).
Begin alt tabbing between them. When in overview, the selector should morph to
match the selected windows size (plus some padding).
Review URL: https://codereview.chromium.org/32913002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The callout widgets (arrows) pointing down from the panel windows need to show above the shelf and must be stacked with the panel windows in order for the shadows to be drawn correctly. A new container is created for shelf bubble windows (currently only the overflow bubble) so that it can show above the attached panel windows.
BUG=292840
TEST=Open a panel window such as hangouts and then maximize a browser window. The arrow pointing to the launcher icon from the panel window should still be visible.
Review URL: https://codereview.chromium.org/30673003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
R=nick@chromium.org, robliao@chromium.org
TBR=nick@chromium.org, robliao@chromium.org
BUG=308740
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229443
Review URL: https://codereview.chromium.org/29273003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In the settings page, we have both a checkbox to enable/disable the feature and a dropdown menu to choose the delay. This feature is hidden behind a flag.
BUG=272401
TEST=manual
Review URL: https://codereview.chromium.org/27196006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=flackr@chromium.org
Review URL: https://codereview.chromium.org/32683008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use correct work area when adjusting the bounds.
BUG=286302
TEST=covered by tests
Review URL: https://codereview.chromium.org/28413003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=272460
Review URL: https://codereview.chromium.org/29153006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously committed (https://codereview.chromium.org/26893004),
and then reverted(https://codereview.chromium.org/26731003) due
to an unrelated valgrind error.
This patch is slightly different from that one, as it prevents
the RenderWidgetHostImpl from ignoring touch cancel events.
This change was necessary due to jdduke's recent work in
simplifying the input router (https://codereview.chromium.org/26775003).
BUG=268075
TEST=WindowModalityControllerTest.TouchEvent
Review URL: https://codereview.chromium.org/27712002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=279317
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229753
R=sadrul@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/25350006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
aura::RootWindows"
Breaks windows bots on chromium.webkit.
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder/builds/44634
TBR=varunjain
Review URL: https://codereview.chromium.org/30813003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=279317
Review URL: https://codereview.chromium.org/25350006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This leaves the date and the |?| in the bubble.
TBR=sadrul
BUG=227247
TEST=power button not seen
Review URL: https://codereview.chromium.org/28453003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
which may be invalid, to check docked mode
I still not sure how the bug can happen, but this is
probably better.
BUG=279484
Review URL: https://codereview.chromium.org/29823004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will make it possible to depend on components from content shell
BUG=247431
R=jam@chromium.org
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/28123002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the teleport items to the context menu. At the same time I was also adding a GetUserID function to the SessionStateController to avoid adding the sanitization of the user names all over the place.
BUG=306143
TEST=visual, a few things got handled by unit tests
Review URL: https://codereview.chromium.org/27217003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This way any children of the Root can call GetRootWindow() from their
destructor and get a valid root.
BUG=307369
TEST=covered by unit test
R=ben@chromium.org
Review URL: https://codereview.chromium.org/27570004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This way notification message is fully shown and not truncated as it happened when it was set to the title instead.
BUG=308901
Review URL: https://codereview.chromium.org/29013003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=307668
R=hans@chromium.org
TBR=oshima
Review URL: https://codereview.chromium.org/29263007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
content_browsertests ContentWindowReparent test was failing, presumably because a focus notification wasn't being broadcast by the new test focus client.
R=sky@chromium.org
BUG=
Review URL: https://codereview.chromium.org/29883002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Remove old FocusManager code from Aura.
>
> Needed to add a simple TestFocusClient that can be used by tests, which were still using the old FocusManager. This allows us to remove some obsolete methods from FocusClient/RootWindow/etc.
>
> R=sky@chromium.org
> BUG=
>
> Review URL: https://codereview.chromium.org/26116008
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/29693004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ForcedIncludeFiles seems broken in the VS generator.
Error messages like:
109>..\build\precompile.cc : fatalerror C1083: Cannot open include file: 'r': No such file or directory
> fix intsafe.h compile errors on express/automatic toolchain on windows
>
> R=nick@chromium.org, robliao@chromium.org
> TBR=nick@chromium.org, robliao@chromium.org
> BUG=308740
>
> Review URL: https://codereview.chromium.org/29273003
TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/28963003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=nick@chromium.org, robliao@chromium.org
TBR=nick@chromium.org, robliao@chromium.org
BUG=308740
Review URL: https://codereview.chromium.org/29273003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Needed to add a simple TestFocusClient that can be used by tests, which were still using the old FocusManager. This allows us to remove some obsolete methods from FocusClient/RootWindow/etc.
R=sky@chromium.org
BUG=
Review URL: https://codereview.chromium.org/26116008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=234271
TEST=visual, using arabic language, made sure that status menu, launcher, notifications and chat window icons were at the right place
Review URL: https://codereview.chromium.org/27711005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=273142
R=mukai@chromium.org
Review URL: https://codereview.chromium.org/27709004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=306277
TEST=WindowSelectorTest.CyclePanelVisibility
Review URL: https://codereview.chromium.org/27706002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the header instead of NonClientFrameView. This functionality is necessary so that CustomFrameViewAsh can be put into immersive fullscreen.
BUG=307622
TEST=ResizeShadowAndCursorTest.*
R=jamescook
TBR=sky (For trivial refactor as a result of merging CustomFrameViewAsh::Init() and the CustomFrameViewAsh constructor)
Review URL: https://codereview.chromium.org/27267003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=248353
TEST=none, no functional changes.
R=jamescook@chromium.org, xiyuan@chromium.org
TBR=sky@chromium.org # for chrome/browser/ui
Review URL: https://codereview.chromium.org/27628002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
resized if possible to take up the whole available vertical space. Subsequent windows are sub-dividing this space by getting resized or by resizing other windows or by forcing other windows to get minimized.
BUG=275812
TEST=ash_unittests --gtest_filter=*ThreeWindowsSplitHeightEvenly*:*TwoWindowsHeightRestrictions*
Review URL: https://codereview.chromium.org/25172002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
FirstRunHelper is an interface providing API for manipulating and retreiving
information about Shell elements. It will be used by new first-run tutorial.
BUG=269286
Review URL: https://codereview.chromium.org/26277006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Remove obsolete code and comments for 165214
BUG=273142,165214
Review URL: https://codereview.chromium.org/26800007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=273142
R=mukai@chromium.org
TBR=hongbo.min@intel.com, pkotwicz@chromium.org
Review URL: https://codereview.chromium.org/27257004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
due to flakiness.
TBR=cpu@chromium.org
BUG=297650
Review URL: https://codereview.chromium.org/27493003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=298210
TEST=ash_unittests --gtest_filter=*AttachOneAutoHideShelf*
Review URL: https://codereview.chromium.org/26662002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=tdresser@chromium.org
BUG=268075
Due to memory leak on chromiumos bot.
Review URL: https://codereview.chromium.org/26731003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=268075
TEST=WindowModalityControllerTest.TouchEvent
Review URL: https://codereview.chromium.org/26893004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=270135
R=derat@chromium.org
Review URL: https://codereview.chromium.org/26959007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=305064
TEST=visual
Review URL: https://codereview.chromium.org/27226005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
BUG=NONE
Review URL: https://codereview.chromium.org/26971004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previous CL was reverted (https://codereview.chromium.org/23606016/) because LauncherItemDelegateManager holds destoryed LauncherModel pointer (in win7_aura trybot).
To handle this, destroy LauncherItemDelegateManager and recreates a new one with new LauncherModel.
Original description.
* LauncherItemController subclasses LauncherItemDelegate
* Register/Unregister when LauncherItemDelegate is created/removed
* LauncherItemDelegateManager handles LauncherItemDelegate by LauncherID
* LauncherItemDelegateManager take ownership of all LauncherItemDelegate
R=sky@chromium.org, skuhne@chromium.org
BUG=279105
TEST=unit_tests, browser_tests, ash_unittests, ash_shell
Review URL: https://codereview.chromium.org/25823002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
shelf (and which is always set)
Code removed!
BUG=307046
TEST=visual, unit test changed and still works
Review URL: https://codereview.chromium.org/27260002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
desktop to another ones desktop.
How it works:
When multiple users are loaded, the current user can drag one of the windows on his desktop to a user's icon on the tray menu. If a transfer to that icon is possible, the window will "zap back" to it's original location to indicate the operation. If he drops the window there it will be transferred to the other users desktop.
BUG=305068
TEST=visual
Review URL: https://codereview.chromium.org/27042003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem with relying on the flags set in Env is on windows and
linux non-chromeos not all events flow through the RootWindow. This
means Env is not always upto date with the real state of the OS.
I've made this so all tests continue to use existing behavior (state
of Env matches that explicitly set), where as non-tests query the OS
on windows (linux non-chromeos is TODO).
BUG=306048
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/26467004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes another ifdef, which should be avoided in general.
This is a follow up to the clean up started in crrev.com/225862.
See discussion from https://codereview.chromium.org/25022004/
BUG=None
TEST=None, no behavior changed.
R=sky@chromium.org,asvitkine@chromium.org
TBR=darin # for trivial changes in content/
Review URL: https://codereview.chromium.org/25435002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=303873
TEST=Close all windows, press Ctrl+N three times, Ctrl+M twice, begin alt-tabbing, selector should be behind all windows.
Review URL: https://codereview.chromium.org/26358013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
call to FinishDragging would always crash. I suspect that resizer->CompleteDrag is called twice when first and then second fingers are lifted.
BUG=305730
TEST=Touch-drag a window with one, then two fingers under --enable-docked-windows flag.
Review URL: https://codereview.chromium.org/26974003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
three fingers.
BUG=263528
TEST=Swipe down from the top of the screen with three fingers to toggle overview.
Review URL: https://codereview.chromium.org/26664008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* remove auto_window_management.{h|cc}
* remove GetTopWindowForNewWindow
BUG=272460
Review URL: https://codereview.chromium.org/26899004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228108 0039d316-1c4b-4281-b951-d872f2087c98
|