| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test:
1) drag bookmark
2) Hit Alt-Tab, or Ctrl-Atl-Right
BUG=None
TEST=Manual
Review URL: https://chromiumcodereview.appspot.com/9234079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a new layer type backed by
WebKit::WebSolidColorLayer. I'm using it for the power
button animation's background (which previously had a
fullscreen texture that it just painted black).
I'm also renaming LAYER_HAS_TEXTURE to LAYER_TEXTURED and
LAYER_HAS_NO_TEXTURE to LAYER_NOT_DRAWN.
BUG=109083
TEST=manual: checked that the power button animation looks the same as before
TBR=sky
Review URL: http://codereview.chromium.org/9289036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
files.
BUG=111326
R=jam
TBR=sky,tony,ajwong,ananta
Review URL: http://codereview.chromium.org/9232060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=110920
TEST=Open a system modal dialog, lock the screen, and verify that you can now unlock the screen.
Review URL: https://chromiumcodereview.appspot.com/9271062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Introduces VisibilityClient, which aura::Window defers to to update layer visibility, if present. This replaces code which previously undid layer visibility changes after they were set. Layer visibility changes are potentially destructiver (they can drop textures associated with the layer and require a repaint).
- Implements this in ash in VisibilityController, which animates the visibility changes of children in annotated parents.
- Annotates various windows as requiring child window visibility change animations. This replaces animating visibility changes in LayoutManagers.
- Adds a second layer of visibility determination to aura::Window. Some code may check Window->IsVisible which was simply testing layer visibility. We want Window->IsVisible to return false as soon as Window::Hide() is called, so we add a member for this.
- We prevent stacking changes to the window from being propagated to the layer if the layer's delegate has been detached (i.e. the layer is hiding)
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9235016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
showing the background.
This fix the problem when we alt-tab too fast, offscreen windows are not hidden yet, therefore we may/may not get a visiblity change event to update the current window. Also, should set the current window before animation starts, so that when animation end and we started hiding windows, we don't accidentally hide the current window.
BUG=111211
TEST=tested on alex that background doesn't show if alt-tab is continuously down.
Review URL: http://codereview.chromium.org/9169039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fixes status area position in RTL languages
BUG=111537
TEST=Run Chrome OS in English with lots of tabs then lock and unlock screen, also try RTL language like Hebrew
Review URL: http://codereview.chromium.org/9271088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=103948
TEST=builds, tests pass
Review URL: http://codereview.chromium.org/9288053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
shortcut keys could always work.
BUG=110572
TEST=ran the new tests in aura_shell_unittests
Review URL: http://codereview.chromium.org/9290011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
App list widget is in always-on-top container which is destructed after default
container. This causes crash when destructing a live app list widget during
Shell shutdown.
BUG=111523
TEST=Verify fix for issue 111523.
Review URL: http://codereview.chromium.org/9234071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. All normal windows end up in a single workspace.
. Each maximized window ends up in its own workspace.
. There is an additional workspace for split windows, but the
heuristics of this aren't implemented yet.
I've left some bits of the old code, in particular overview but there
isn't really a way to get into it yet and it'll need some reworking if
we decide to keep it.
BUG=111285
TEST=none
R=ben@chromium.org,oshima@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9113045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This fixes an issue where it was possible to get the tab contents to jump out of their frame by opening the network menu and starting to drag the window while the menu was open.
The reason is that the HANDLE_DRAG would handle the drag as if it originated at the location that the menu was opened
Review URL: http://codereview.chromium.org/9006034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
grid. Resizes snap, but drags don't set bounds until done.
BUG=111285
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9234056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
BUG=104192
TEST=None
Review URL: http://codereview.chromium.org/9113056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When shell shutdown starts, if the active window is in a container that gets
destructed after the default container (e.g. status area widget, full screen
bubble), GetTopmostWindowToActivate will be called when destructing this active
window. However, GetContainer(kShellWindowId_DefaultContainer) would return NULL
because default container is already destructed at this point.
Add a NULL check to avoid the crash.
BUG=110916
TEST=Verify the crash in issue 110916 no longer happens.
Review URL: http://codereview.chromium.org/9169058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a transparent flag to Window;
- Use the transparent in Window::Init to call Layer::SetFillsBoundsOpaquely;
- Update ShadowController to use SHADOW_TYPE_NONE for transparent window;
Side change:
- Make tooltip widget non-transparent as it needs the default shadow;
BUG=110916
TEST=Verify fix for issue 110916 and drop-n-drop works as before.
Review URL: http://codereview.chromium.org/9169050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds root_location to LocatedEvent
Converted a couple of tests to use EventGenerator.
BUG=none
TEST=added TranslatedEvent test to window_unittests.
Review URL: http://codereview.chromium.org/9117018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* In debug builds, Ctrl-Alt-A shows/hides it
* Added test coverage for switching modes
* Refactored Shell initialization to support this
BUG=110174
TEST=aura_shell_unittests ShellTest.ChangeWindowMode, manual toggling
Review URL: https://chromiumcodereview.appspot.com/9289008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Excludes drag and drop tests from aura_shell_unittests on Mac.
Will reenable once drag and drop is functional on Aura/Mac.
BUG=111279
TEST=aura_shell_unittests
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9169034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=mazda@chromium.org
BUG=None
TEST=Run aura_shell_unittests --gtest_filter="ActivationControllerTest.ClickOnMenu"
Review URL: https://chromiumcodereview.appspot.com/9169041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
BUG=104192
TEST=None
Review URL: http://codereview.chromium.org/9117021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
disables animations for browser tests as other wise code that gets
bounds and does calculates based on that ends up with the wrong thing.
BUG=111086
TEST=none
R=ben@chromium.org,phadjan.jr@chromium.org
TBR=phadjan.jr@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9160020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and that each item isn't associated with a window. This allows the
chrome side to populate the launcher with items that correspond to app
tabs.
BUG=110827
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9271007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Setting the layer of the window as invisible rather than calling Show()/Hide() to avoid excessive re-layout and observers notification.
BUG=109766
TEST=tested on lumpy in compact mode.
Review URL: http://codereview.chromium.org/9141026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The layout manager for compact window mode calls Show() on the status area widget as part of its visibility updates when a new Aura window opens. This causes the status area widget to try to activate and take focus, which tries to release focus and close the omnibox popup, which causes a crash. Only call Show() if the widget is currently invisible, for transitions out of fullscreen.
BUG=110897
TEST=Run Aura in compact window mode, type into omnibox, should not crash
Review URL: https://chromiumcodereview.appspot.com/9160002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=106873
Review URL: https://chromiumcodereview.appspot.com/9132004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118540
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118698
Review URL: https://chromiumcodereview.appspot.com/9124021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118540
Review URL: https://chromiumcodereview.appspot.com/9124021
TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9270051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118540
Review URL: https://chromiumcodereview.appspot.com/9124021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/110024
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9141024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
directory.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9226040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
like crosbug.com/21842.
This CL depends on https://chromiumcodereview.appspot.com/9241007/.
BUG=None
TEST=ran the unit tests
Review URL: http://codereview.chromium.org/9228013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Write a CL description next time (!)
Interactive Tests (dbg) build #20055 has blame ranging 118532-118542. This CL
looks like the culprit but not 100% sure.
TBR=pkotwicz@chromium.org,beng@chromium.org
BUG=
TEST=Interactive Tests (dbg) turns green
Review URL: https://chromiumcodereview.appspot.com/9131035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
from interfering in existing window layout heuristics/animations.
BUG=none
TEST=existing
Review URL: https://chromiumcodereview.appspot.com/9138026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9124021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extends 'aura_builder' target to work on Mac. This excludes bits
that are not currently working.
To build:
ash_shell
aura_demo
aura_unittests
compositor_unittests
To run:
compositor_unittests
webkit_unit_tests
Gyp flags:
'use_aura': 1
BUG=110632, 110627
TEST=Compile 'aura_builder' target on Mac with 'use_aura' bit set.
R=cmp@chromium.org, oshima@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9226024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This replaces the aura_show_about_flag_window_mode and
chromeos_legacy_power_button GYP flags with
--aura-force-compact-window-mode and
--aura-legacy-power-button command-line switches. There is
concern that using compile-time flags to control these
features will greatly increase the workload on the Chrome OS
builders; we apparently currently share Chrome binaries
across all Chrome OS boards with the same architecture.
BUG=109209,109052,chrome-os-partner:7570
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/9264025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This mimics the creation and alt+tab scrolling in classic chromeos.
BUG=109042
TEST=on alex and lumpy in compact mode.
Review URL: http://codereview.chromium.org/9187020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Provide stub implementation for Mac/Aura for this new RootWindowHost
method. Also fixes up other compile and clang/style problem.
MainAppBundle call got renamed to FrameworkBundle.
BUG=None
TEST=None
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9270011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. When dragging over BrowserRootView, we must sanitize the dragged string
before querying Autocomplete.
2. We may receive un-expected events during drag drop session if the user
moves out of the root window.
BUG=110733
TEST=chrome no longer crashes on drag drop.
Review URL: http://codereview.chromium.org/9270001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also speeds up all animations from 200ms->120ms per feedback from Glen.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9176012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=mazda@chromium.org
BUG=None
TEST=run the test
Review URL: https://chromiumcodereview.appspot.com/9269003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
be activated.
R=yusukes@chromium.org
BUG=104192
TEST=With Aura enabled, tab through the status bar on the login screen
Review URL: https://chromiumcodereview.appspot.com/9264005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts r118199, which was a revert of r118171.
aura::VideoPropertyWriter (not ash::VideoDetector -- made a
typo in the revert's description) was outliving the
ash::Shell singleton. Now we explicitly destroy the
VideoPropertyWriter before the shell.
The only differences from r118171 are the addition of the
final chunk in chrome_browser_main_chromeos.cc and a change
to reparent a window in VideoDetectorTest.WindowNotVisible
needed in response to r118259.
BUG=110114
TEST=avoided missing DCHECK on shutdown in trybot logs this time
Review URL: http://codereview.chromium.org/9254018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/110024
TEST=none
Review URL: http://codereview.chromium.org/9167032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=nkostylev@chromium.org
BUG=104192
TEST=Try to tab to status area on an aura build.
Review URL: http://codereview.chromium.org/9185002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
more clearly.
BUG=None
TEST=ran aura_shell_unittests
Review URL: http://codereview.chromium.org/9240002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds first cut at "Aura Shell.app" on Mac. The 'ash_shell' is extended
to generate a Cocoa application. This application brings up a single
window containing the Aura desktop. The main view of this window provides
an accelerated surface to Aura in which it can composite and draw its
results.
What works:
- The application launches and renders the Aura desktop and background
- Mouse movement, clicking, double-clicking, and interactions with
Aura windows and widgets
- Text buttons render with Skia text (needs improvement)
- Non-modal transient window button
- Window-modal window button
- System-modal window button
- Example Widgets button (checkboxes, radios, buttons)
- Lock Screen button
- Create Non-Resizable window button
- Create Pointy Bubble button
- Create Widow button
- Switcher and Taskbar
What doesn't work:
- Open Views Examples Window button
- Views menus
- Views scrollbars
- Views accelerators
- Views tooltips
- Drag and drop
- Anything involving MessageLoop dispatcher logic
- Mouse movement doesn't pass through to Aura when mouse button is up
Note: Required .gyp flags are:
'use_aura': 1,
'use_webkit_compositor': 1,
BUG=109946
TEST=Manual tests.
R=sky@chromium.org, thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9232028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts r118171. There's an issue in the destruction
order of ash::VideoDetector vs. ash::Shell.
BUG=110114
TEST=built it
TBR=apatrick
Review URL: https://chromiumcodereview.appspot.com/9232037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
minor bug in tooltip displaying logic.
BUG=102563
TEST=added new test.
Review URL: http://codereview.chromium.org/9249010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118187 0039d316-1c4b-4281-b951-d872f2087c98
|