| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Add missing virtual dtor to a few classes.
BUG=417463
R=mukai@chromium.org, sadrul@chromium.org
Review URL: https://codereview.chromium.org/641683003
Cr-Commit-Position: refs/heads/master@{#301170}
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://codereview.chromium.org/653563004
Cr-Commit-Position: refs/heads/master@{#300978}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* New ContainerParams
- default_parent to specify the default parent when no
transient parent is specified.
- modal_container_priority now controls the modal container
used for a modal window created for the given container.
- if not specified, it will fallback downwards to find one.
- if window is specified as always_on_top, it will use top
most modal container.
* Changed network selector/shutdown dialog to use the new API.
* Other change:
Separated test windows to athena/test/base/test_windows.h
BUG=410499
TBR=sky@chromium.org,reed@chromium.org
TEST=coverd by unit tests
Committed: https://crrev.com/4903fd36b2b36f00efeb1b7bba81b7de6e9457a3
Cr-Commit-Position: refs/heads/master@{#300192}
Review URL: https://codereview.chromium.org/662763002
Cr-Commit-Position: refs/heads/master@{#300288}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/662763002/)
Reason for revert:
Reverting because this CL because WithOrWithoutTargeter.* introduced a memory leak and made all of the Athena Asan tests fail http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)
Based on tools/lsan/suppressions.txt reverting is now preferred over adding a suppression
Original issue's description:
> Support modal windows
>
> * New ContainerParams
> - default_parent to specify the default parent when no
> transient parent is specified.
> - modal_container_priority now controls the modal container
> used for a modal window created for the given container.
> - if not specified, it will fallback downwards to find one.
> - if window is specified as always_on_top, it will use top
> most modal container.
>
> * Changed network selector/shutdown dialog to use the new API.
>
> * Other change:
> Separated test windows to athena/test/base/test_windows.h
>
> BUG=410499
> TBR=sky@chromium.org,reed@chromium.org
> TEST=coverd by unit tests
>
> Committed: https://crrev.com/4903fd36b2b36f00efeb1b7bba81b7de6e9457a3
> Cr-Commit-Position: refs/heads/master@{#300192}
TBR=mukai@chromium.org,sky@chromium.org,reed@chromium.org,oshima@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=410499
Review URL: https://codereview.chromium.org/665803003
Cr-Commit-Position: refs/heads/master@{#300226}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* New ContainerParams
- default_parent to specify the default parent when no
transient parent is specified.
- modal_container_priority now controls the modal container
used for a modal window created for the given container.
- if not specified, it will fallback downwards to find one.
- if window is specified as always_on_top, it will use top
most modal container.
* Changed network selector/shutdown dialog to use the new API.
* Other change:
Separated test windows to athena/test/base/test_windows.h
BUG=410499
TBR=sky@chromium.org,reed@chromium.org
TEST=coverd by unit tests
Review URL: https://codereview.chromium.org/662763002
Cr-Commit-Position: refs/heads/master@{#300192}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a fling gesture having a sufficiently large velocity
is dispatched to the drag handle, then disengage split
view mode and activate the window on the side opposite
the direction of the fling.
BUG=413880
TEST=SplitViewControllerTest.ScrollDragHandle,
DragHandleTest.ScrollTest
Review URL: https://codereview.chromium.org/640303003
Cr-Commit-Position: refs/heads/master@{#299548}
|
|
|
|
|
|
|
|
|
|
| |
BUG=411878
TEST=covered by test.
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/640503002
Cr-Commit-Position: refs/heads/master@{#298632}
|
|
|
|
|
|
|
|
| |
BUG=417463
Review URL: https://codereview.chromium.org/623103002
Cr-Commit-Position: refs/heads/master@{#298050}
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=404661, 179713
TEST=Manual, see bug
R=flackr, oshima, derat
TBR=stevenjb
Review URL: https://codereview.chromium.org/585623003
Cr-Commit-Position: refs/heads/master@{#296515}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding split view divider widget which could be dragged to exit the split view.
Resubmit of https://codereview.chromium.org/545393002
TBR=mukai@chromium.org
BUG=403207, 408691
Review URL: https://codereview.chromium.org/598083002
Cr-Commit-Position: refs/heads/master@{#296464}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/545393002/)
Reason for revert:
DragHandleTest.ScrollTest is failing on the bots: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/36880
Original issue's description:
> Adding split view divider widget.
>
> Adding split view divider widget which could be dragged to exit the split view.
>
> BUG=403207,408691
>
> Committed: https://crrev.com/b47c16517f0882cbabf8c9aa9ce66711f026fd5b
> Cr-Commit-Position: refs/heads/master@{#296351}
TBR=mukai@chromium.org,oshima@chromium.org,sadrul@chromium.org,tdanderson@chromium.org,pkotwicz@chromium.org,mfomitchev@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=403207,408691
Review URL: https://codereview.chromium.org/602603003
Cr-Commit-Position: refs/heads/master@{#296433}
|
|
|
|
|
|
|
|
|
|
| |
Adding split view divider widget which could be dragged to exit the split view.
BUG=403207,408691
Review URL: https://codereview.chromium.org/545393002
Cr-Commit-Position: refs/heads/master@{#296351}
|
|
|
|
|
|
|
|
|
| |
BUG=405859
TEST=manual
Review URL: https://codereview.chromium.org/542623002
Cr-Commit-Position: refs/heads/master@{#294305}
|
|
"common" is used for the code that is common better renderer and browser. Rename to "util" instead.
BUG=None
TBR=danakj@chromium.org
Review URL: https://codereview.chromium.org/558483003
Cr-Commit-Position: refs/heads/master@{#294025}
|