summaryrefslogtreecommitdiffstats
path: root/athena
Commit message (Collapse)AuthorAgeFilesLines
* Allow launcher pages to add subpages to app list model.calamity2014-12-032-0/+4
| | | | | | | | | | | | | | | | | This CL allows launcher pages to add subpages to the app list model. This is similar to the HTML5 history API in that once the launcher page calls pushState(), the app list's back button will send onPopSubpage events to the launcher page extension before doing a top-level 'back' action. All launcher pages are cleared when the page transitions, regardless of the pushed subpages as browser/renderer execution ordering issues can cause the app list's 'back' to get triggered despite a subpage being pushed. BUG=434243 Review URL: https://codereview.chromium.org/749613003 Cr-Commit-Position: refs/heads/master@{#306548}
* Experimental app list: Remove dummy search box and use real one.mgiuca2014-12-021-1/+0
| | | | | | | | | | | | | | | | The dummy search box on the start page has been replaced with an invisible spacer view (to maintain the existing layout positioning). The real search box is now visible at all times along the top of the page. This introduces a regression (search box is in the wrong place on the start page), which will be rectified in a follow-up CL. BUG=437674,437377,437984 TBR=mukai@chromium.org Review URL: https://codereview.chromium.org/749363003 Cr-Commit-Position: refs/heads/master@{#306341}
* Resubmit https://codereview.chromium.org/722703002/ because of buildcylee2014-12-011-5/+5
| | | | | | | | | | | | | | | breakage. Make "source" a required argument of AppLaunchParams and fill in the argument in all call points. This reverts commit bad38cd9f3199784a10cdb99de9184c9055bef28. BUG=400619 Review URL: https://codereview.chromium.org/752143002 Cr-Commit-Position: refs/heads/master@{#306222}
* Fix blocking of non-repeatable acceleratorspkotwicz2014-11-243-6/+5
| | | | | | | | | | | | | | | | This CL makes ui::EF_IS_REPEAT get propagated to AcceleratorController. In particular, this CL: - preserves ui::EF_IS_REPEAT when converting from ui::KeyEvent -> content::NativeWebKeyboardEvent -> ui::KeyEvent - preserves ui::EF_IS_REPEAT when remapping accelerator via ImeControlDelegate::RemapAccelerator() BUG=434743 TEST=AcceleratorControllerBrowserTest.RepeatedToggleMaximizeViaAccelerator Review URL: https://codereview.chromium.org/735943002 Cr-Commit-Position: refs/heads/master@{#305434}
* Regression: Search+Key pops up app launcherafakhry2014-11-212-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We decided to fix this issue even though it only happens when the following 'wrong' key sequence is pressed: - SearchKey [pressed] - Key [pressed] - SearchKey [released] - Key [released] Resulted wrong behavior: the AppLancher appears. The Cause: ---------- When the search key is used as a modifier, the following pressed key is rewritten and consumed. It doesn't get forwarded to AcceleratorController managed by the AcceleratorManager in the FocusManager. The AcceleratorController needs to know the previous Accelerator to determine the correct behavior. The 'Suggested' Fix: -------------------- Track the system-wide current and previous key accelerators and require that the ToggleAppList would only be triggered if LWIN [pressed] is immediately followed by LWIN [released]. BUG=410835 TEST=manual, ash_unittests Review URL: https://codereview.chromium.org/727583002 Cr-Commit-Position: refs/heads/master@{#305278}
* adding skuhne to OWNERS of components/sessionsMr4D2014-11-211-4/+4
| | | | | | | | | BUG=424679 TEST=- Review URL: https://codereview.chromium.org/720633003 Cr-Commit-Position: refs/heads/master@{#305246}
* Make "source" a required argument of AppLaunchParams and fill in the ↵cylee2014-11-201-4/+4
| | | | | | | | | | argument at all call points. BUG=400619 Review URL: https://codereview.chromium.org/722703002 Cr-Commit-Position: refs/heads/master@{#305038}
* Consolidate javascript_dialog_manager.h and javascript_dialog_manager_impl.hoshima2014-11-193-10/+11
| | | | | | | | | | | | | | * Renamed JavaScriptDialgoManagerImpl to JavaScriptDialogManager. * Add namespace app_modal_dialogs * Add namespace javascript_dialog_extensions_client * Shortened InstallJavaScriptDialogExtensionsClient to InstallClient to fit the 80 chars limit. BUG=410499 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/688853005 Cr-Commit-Position: refs/heads/master@{#304903}
* Refactor ShellDesktopController and ShellNativeAppWindow to allow for ↵yoz2014-11-192-2/+6
| | | | | | | | | | | | | | | non-Aura implementations. Rename ShellDesktopController to ShellDesktopControllerAura; make ShellNativeAppWindow implement only some of the BaseWindow methods, and move aura-specific bits to ShellNativeAppWindowAura. Adds a unit test for ShellNativeAppWindowAura. This is a precursor to a Cocoa implementation for Mac. BUG=399363 TBR=danakj@chromium.org,reed@google.com Review URL: https://codereview.chromium.org/696063008 Cr-Commit-Position: refs/heads/master@{#304897}
* PPAPI: Make CreateResourceHost take PP_Resourcedmichael2014-11-191-5/+4
| | | | | | | | | | | | | | | | None of the derived classes actually use the sequence number, and I can't think of a reason that they would. This simplifies things just a tiny bit and will make an upcoming change less confusing. See: https://codereview.chromium.org/735873002/diff/60001/content/renderer/pepper/v8_var_converter.cc mukai: TBR for athena BUG=417316 TBR=mukai@chromium.org Review URL: https://codereview.chromium.org/741753002 Cr-Commit-Position: refs/heads/master@{#304848}
* Add WebContents source to methods in WebContentsDelegatemathiash2014-11-191-1/+2
| | | | | | | | | | The added parameter helps us avoid a potential timing-related security issue. The UI can be instructed to open a new tab and show a dialog roughly at the same time, and since it's handled asynchronously the dialog may end up in front of the new tab. Knowing what web contents issued the dialog would allow us to prevent that from happening. BUG=428793 Review URL: https://codereview.chromium.org/691823002 Cr-Commit-Position: refs/heads/master@{#304781}
* Componentize AshKeyboardControllerProxy part1pkotwicz2014-11-191-6/+1
| | | | | | | | | | | | | This CL makes KeyboardControllerProxy take in a BrowserContext in the constructor. A new KeyboardControllerProxy is created via ash::Shell::CreateKeyboard() when the BrowserContext changes BUG=431448 TEST=None Review URL: https://codereview.chromium.org/711843002 Cr-Commit-Position: refs/heads/master@{#304707}
* Rename app_modal_dialogs dir to app_modaloshima2014-11-185-8/+7
| | | | | | | | | BUG=410499 TBR=benwells@chromium.org, jochen@chromium.org, agl@chromium.org Review URL: https://codereview.chromium.org/735473002 Cr-Commit-Position: refs/heads/master@{#304697}
* Add NetworkConfigurationObserver class to notify observers when the ↵stevenjb2014-11-171-0/+3
| | | | | | | | | | | | | | | | | following events occur: ConfigurationCreated ConfigurationRemoved PropertiesSet ConfigurationProfileChanged BUG=427638 For athena/system/network_selector.cc: TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/679323002 Cr-Commit-Position: refs/heads/master@{#304523}
* app_shell: Change flag for loading apps to --load-app and only launchzork2014-11-172-2/+4
| | | | | | | | | | the first one. BUG=432359 Review URL: https://codereview.chromium.org/727963004 Cr-Commit-Position: refs/heads/master@{#304500}
* MacViews: Fix inconsistencies with window modal dialog parent types.andresantoso2014-11-151-1/+4
| | | | | | | | | | | | | | | | | | | On Aura, both gfx::NativeView and gfx::NativeWindow map to the same type (aura::Window*). On Mac, they map to different types (NSView* and NSWindow*) so they are not interchangeable. CreateBrowserModalDialogViews() is changed back to take a NativeWindow parent because that is what the callers expect. It was recently changed to NativeView in https://crrev.com/699553002. Added platform_util::GetViewForWindow() to convert the parent to the NativeView type that the Widget expects. BUG=425229 Review URL: https://codereview.chromium.org/718913004 Cr-Commit-Position: refs/heads/master@{#304324}
* Support error handling for Surface read-backs.siva.gunturi2014-11-142-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | CopyFromCompositingSurface, CopyFromBackingStore return callbacks with a result value of boolean (pass or fail) and the resultant SkBitmap.But in few cases for example, we want to request output in a differnt format say RGB_565. It depends on the hardware whether it supports that texture format for readback, so on few systems CopyFromCompositingSurface may fail and return false status, with empty SkBitmap. The user of the api should be able to know the exact reason of failure,(there can be a different reasons) to take appropriate action,say in the above case FORMAT_NOT_SUPPORTED. 1.This patch defines enum to support possible failure reasons. 2.Changes the signature of readback callback by removing boolean and passing ReadbackResponse enum. BUG=430871 Review URL: https://codereview.chromium.org/593503003 Cr-Commit-Position: refs/heads/master@{#304244}
* Make getters of NativeAppWindowViews publichashimoto2014-11-144-44/+3
| | | | | | | | | | Remove AthenaNativeAppWindowViews BUG=None Review URL: https://codereview.chromium.org/721873007 Cr-Commit-Position: refs/heads/master@{#304150}
* Introduce system_info as an independent container.mukai2014-11-1314-39/+93
| | | | | | | | | | | | | | | | | | - system info persists on the screen, not in the background - introduce a new container to overwrap with home card nicely - conflicting with overview windows doesn't look correct -- therefore its y-coordinate should be moved by the height of system info. - system_ui's "ColorScheme" isn't used anymore, since it's always white (LIGHT) colors in the latest mock. I'll create another CL to remove this. BUG=425724 R=oshima@chromium.org TEST=manually Review URL: https://codereview.chromium.org/715053003 Cr-Commit-Position: refs/heads/master@{#304043}
* Fix virtual keyboard overscroll on Athenapkotwicz2014-11-121-1/+0
| | | | | | | | | | | | | | | | This CL: - Removes GetFrameWindow() from KeyboardController because the function is not compatible with Athena - Avoids showing the keyboard container after creating it. This was causing the insets not to be set on the RenderWidgetHostViews the first time that the keyboard is shown BUG=431798 TEST=None Review URL: https://codereview.chromium.org/711243004 Cr-Commit-Position: refs/heads/master@{#303888}
* Fixing flakiness of read back test by waiting until rendered result is availableskuhne2014-11-121-4/+26
| | | | | | | | | | BUG=410400 TEST=existing unit test TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/719783003 Cr-Commit-Position: refs/heads/master@{#303864}
* Fix Athena build after ExtensionService::extensions() deprecation.reillyg2014-11-121-1/+2
| | | | | | | | | | | Apparently the CQ allows me to land CLs that break Athena. This fixes it. BUG= Review URL: https://codereview.chromium.org/714273005 Cr-Commit-Position: refs/heads/master@{#303770}
* Flakiness on release trybot tests might be caused by inability to render the ↵skuhne2014-11-111-0/+7
| | | | | | | | | | | | frame before we request an image BUG=410400 TEST=ContentProxyBrowserTest.CreateContent TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/715823003 Cr-Commit-Position: refs/heads/master@{#303748}
* Fix leak in shutdown dialogoshima2014-11-111-8/+5
| | | | | | | | | BUG=432162 R=mukai@chromium.org Review URL: https://codereview.chromium.org/716793005 Cr-Commit-Position: refs/heads/master@{#303712}
* Fixing browser testsskuhne2014-11-111-1/+11
| | | | | | | | | | BUG=410400 TEST=fixing broken browser tests TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/711403002 Cr-Commit-Position: refs/heads/master@{#303652}
* Synchronizes the app_list state and the home card state.mukai2014-11-115-2/+76
| | | | | | | | | | | | | | | | | | - "all apps" from BOTTOM state should switch to CENTERED state - switching to BOTTOM state should switch to the start page BUG=425724, 425717 R=oshima@chromium.org TEST=the new test covers Export HomeCardView into a separate file. HomeCardView gets fairly complicated and it's worth exporting into a different file. Review URL: https://codereview.chromium.org/712133002 Cr-Commit-Position: refs/heads/master@{#303593}
* Enable debug accelerator in InputManger unit testoshima2014-11-114-9/+28
| | | | | | | | | | * InputManagerTest in accelerator_manager_unittests has been renamed to avoid name conflict. BUG=424109 Review URL: https://codereview.chromium.org/692333010 Cr-Commit-Position: refs/heads/master@{#303565}
* Fills athena background always.mukai2014-11-116-21/+62
| | | | | | | | | | BUG=431861 R=oshima@chromium.org, mohsen@chromium.org TEST=manually Review URL: https://codereview.chromium.org/697143005 Cr-Commit-Position: refs/heads/master@{#303563}
* [Athena] Add a test of focus transition from modal windowyoshiki2014-11-111-0/+32
| | | | | | | | BUG=431729 Review URL: https://codereview.chromium.org/716493002 Cr-Commit-Position: refs/heads/master@{#303554}
* Export HomeCardView into a separate file.mukai2014-11-104-264/+342
| | | | | | | | | | | | | HomeCardView gets fairly complicated and it's worth exporting into a different file. BUG=None R=oshima@chromium.org TEST=build succeeds Review URL: https://codereview.chromium.org/712023003 Cr-Commit-Position: refs/heads/master@{#303541}
* Add namespace to constrained_window componentoshima2014-11-102-4/+4
| | | | | | | | | BUG=None TBR=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/705303002 Cr-Commit-Position: refs/heads/master@{#303523}
* Notify launcher page with onTransitionChanged event.calamity2014-11-102-0/+4
| | | | | | | | | | | | | | This CL adds a launcherPage API which notifies the launcher page when the app launcher switches to and from the custom launcher page. These events are only sent to the first custom launcher page. BUG=425444 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/683703002 Cr-Commit-Position: refs/heads/master@{#303427}
* Fix some minor typos related to the word "accelerate" and its derivative.sungmann.cho2014-11-082-2/+2
| | | | | | | | | BUG=none TBR=sky@chromium.org Review URL: https://codereview.chromium.org/711873002 Cr-Commit-Position: refs/heads/master@{#303383}
* athena: Add missing ui/events/devices dep for athena_mainspang2014-11-071-0/+1
| | | | | | | | TEST=compile athena_main in Debug Review URL: https://codereview.chromium.org/703193006 Cr-Commit-Position: refs/heads/master@{#303322}
* Add AthenaBrowserTest frameworkoshima2014-11-0724-260/+496
| | | | | | | | | | | | | | | This allow us to run tests that depends on content/extensions without chrome/. * extract AthenaMainDelegate from athena_main.cc to use it in browser tests. * renamed existing AthenaBrowserTest for chrome to AthenaChromeBrowserTset * Renamed athena_xxx_brosertest.{h|cc} to xxx_browser_test.{h|cc} to match the patter used for other base test class for browser tests. BUG=None TBR=davidben@chromium.org, jamescook@chromium.org Review URL: https://codereview.chromium.org/689163003 Cr-Commit-Position: refs/heads/master@{#303307}
* [Athena] Map displays to touchscreensdnicoara2014-11-072-1/+84
| | | | | | | | | | | | | In order to support different modes and different multi-monitor configurations Ozone will no longer match the touchscreen to the primary display. Instead Ozone relies on the display manager to setup the mapping correctly. BUG=none Review URL: https://codereview.chromium.org/682093003 Cr-Commit-Position: refs/heads/master@{#303276}
* Fixes minor style issues which was in r303001mukai2014-11-072-2/+7
| | | | | | | | | | BUG=425717, 425724, 425719 TBR=oshima@chromium.org TEST=none Review URL: https://codereview.chromium.org/700333004 Cr-Commit-Position: refs/heads/master@{#303204}
* Search next activatable window among containersyoshiki2014-11-064-9/+134
| | | | | | | | | | Previously, the focus doesn't move to window in other containers. This patch enables cross-container focus move when the active window is disappeared. BUG=424750 Review URL: https://codereview.chromium.org/688053004 Cr-Commit-Position: refs/heads/master@{#303067}
* JS dialogs for athenaoshima2014-11-069-2/+236
| | | | | | | | | | | | | | | | | Adds athena impl for following client/host web_modal::ModalDialogHost ConstrainedWindowViewsClient JavaScriptDialogManagerClient This depends on https://codereview.chromium.org/666533007/ BUG=410499 TBR=yoz@chromium.org, wittman@chromium.rg, msw@chromium.org, avi@chromium.org Review URL: https://codereview.chromium.org/692563002 Cr-Commit-Position: refs/heads/master@{#303062}
* Replace the content of the home card by AppListMainView.mukai2014-11-0610-980/+111
| | | | | | | | | | | | | Athena specific AthenaStartPageView is not used anymore. We'll share the same view as the experimental app list. BUG=425717, 425724, 425719 R=calamity@chromium.org, oshima@chromium.org TEST=manually Review URL: https://codereview.chromium.org/683243004 Cr-Commit-Position: refs/heads/master@{#303001}
* athena: Make sure the ActivityViewModel is always initialized correctly.Sadrul Habib Chowdhury2014-11-052-1/+60
| | | | | | | | | | | | The ActivityViewModel should always be initialized, whether the Activity creates its own views::Widget or not. BUG=430030 R=oshima@chromium.org Review URL: https://codereview.chromium.org/704623003 Cr-Commit-Position: refs/heads/master@{#302877}
* Re-factored printing defines and build configs.vitalybuka2014-11-051-4/+4
| | | | | | | | | | | Renamed DISABLE_BASIC_PRINTING to ENABLE_BASIC_PRINTING. Renamed ENABLE_FULL_PRINTING to ENABLE_PRINT_PREVIEW. BUG=430281 Review URL: https://codereview.chromium.org/702603004 Cr-Commit-Position: refs/heads/master@{#302868}
* athena: Introduce ActivityView.Sadrul Habib Chowdhury2014-11-0518-25/+106
| | | | | | | | | | | | | ActivityViewModel has the necessary information that should be displayed to the user. So provide mechanism for it to be able to update the view when the relevant information (e.g. title, icon, color) changes. BUG=none R=oshima@chromium.org Review URL: https://codereview.chromium.org/694413005 Cr-Commit-Position: refs/heads/master@{#302753}
* Move all event related devices from ui/events/ to ui/events/devices/dnicoara2014-11-041-1/+1
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/685793002 Cr-Commit-Position: refs/heads/master@{#302647}
* Fixes the mouse click of the search box in the home card.mukai2014-11-041-1/+18
| | | | | | | | | | | | | | | | Minimized background (the black layer) is still "visible" in views point of view even though its layer opacity is 0.0f, and it intercepts mouse/touch events over the actual visible views. It needs to SetVisible(false) when it's not used. BUG=428442 R=yoshiki@chromium.org TEST=manually Review URL: https://codereview.chromium.org/693103002 Cr-Commit-Position: refs/heads/master@{#302585}
* athena: Expose the list of activities from the ActivityManager.Sadrul Habib Chowdhury2014-11-049-132/+152
| | | | | | | | | | | | | | | | | Notable implementation details of the change: . Have ActivityManagerImpl observer each aura::Window of the activities, and update order of the activities when their windows are restacked. . Introduce ActivityManagerObserver::OnActivityOrderChanged(). . Remove the code from ResourceManagerImpl that tracks the activity order, and replace it to get the list from ActivityManager instead. - Make sure the code traverses the activities in the correct order. BUG=413928 R=oshima@chromium.org, skuhne@chromium.org Review URL: https://codereview.chromium.org/694353004 Cr-Commit-Position: refs/heads/master@{#302574}
* athena: Remove ActivityViewModel::CreateWidget().Sadrul Habib Chowdhury2014-11-0311-45/+26
| | | | | | | | | | | | | Use the existing views API (views::Widget::GetWidgetForNativeView()) to get any existing views::Widget for an athena::Activity, instead of asking its ActivityViewModel. BUG=none R=oshima@chromium.org Review URL: https://codereview.chromium.org/702473005 Cr-Commit-Position: refs/heads/master@{#302523}
* Creating default implementation for aura::client::ScreenPositionClientmfomitchev2014-11-031-21/+4
| | | | | | | | | | | | | Making all implementations except for ash's use the new default base class. I left the ash's implementation as is, since I am not sure if the display origin is always the same as the root window origin. My suspicion is that it's not.. BUG=NONE Review URL: https://codereview.chromium.org/686513004 Cr-Commit-Position: refs/heads/master@{#302502}
* Do not allow split view to be engaged by a bezel gesturetdanderson2014-11-038-475/+50
| | | | | | | | | | | | | | | Remove the ability to engage split view mode with the use of a bezel gesture, and remove BezelController which is currently only used for this purpose. BUG=429184 TEST=WindowManagerTest.TitleDragSwitchBetweenWindowsInSplitViewMode renamed to WindowManagerTest.ReplaceWindowsInSplitViewMode and modified, WindowManagerTest.BezelGestureToSplitViewMode removed, WindowManagerTest.BezelGestureToSwitchBetweenWindows removed Review URL: https://codereview.chromium.org/694883002 Cr-Commit-Position: refs/heads/master@{#302436}
* Popups should not fill container in FillLayoutManagermohsen2014-10-312-2/+13
| | | | | | | | | | | | | Popup windows should be excluded from windows that fill their container entirely when managed by a FillLayoutManager. An example is touch text selection handles and quick menu which are popups and are needed in Athena login/lock screen which uses a FillLayoutManager. BUG=425595 Review URL: https://codereview.chromium.org/682123002 Cr-Commit-Position: refs/heads/master@{#302289}
generated by cgit v1.1 at 2025-02-14 16:55:36 +0000