summaryrefslogtreecommitdiffstats
path: root/base/allocator
Commit message (Collapse)AuthorAgeFilesLines
* Replace most LOG/CHECK statements with DLOG/DCHECK statements in base.brettw@chromium.org2011-10-262-4/+4
| | | | | | | | | | | [ Reland of 107042 http://codereview.chromium.org/8368009 ] I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8341026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107434 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 107042 - Replace most LOG/CHECK statements with DLOG/DCHECK ↵brettw@chromium.org2011-10-252-4/+4
| | | | | | | | | | | | | | statements in base. I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8368009 TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/8351025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107051 0039d316-1c4b-4281-b951-d872f2087c98
* Replace most LOG/CHECK statements with DLOG/DCHECK statements in base.brettw@chromium.org2011-10-252-4/+4
| | | | | | | | | I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8368009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107042 0039d316-1c4b-4281-b951-d872f2087c98
* Enable TCMalloc doubly-linked freelist in release buildsBUG=NoneTEST=Nonejschuh@chromium.org2011-10-131-4/+0
| | | | | | Review URL: http://codereview.chromium.org/8242017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105312 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 100640 - Enable doubly linked lists by default.bxx@chromium.org2011-09-111-1/+4
| | | | | | | | | | | | BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/7865020 TBR=bxx@chromium.org Review URL: http://codereview.chromium.org/7796034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100642 0039d316-1c4b-4281-b951-d872f2087c98
* Enable doubly linked lists by default.bxx@chromium.org2011-09-111-4/+1
| | | | | | | | | BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/7865020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100640 0039d316-1c4b-4281-b951-d872f2087c98
* tcmalloc doubly-linked free-lists for thread cachesbxx@chromium.org2011-09-091-0/+6
| | | | | | | | | | | | | | | Added the ability for free lists to be built out of doubly-linked lists in tcalloc. TCMALLOC_USE_DOUBLYLINKED_FREELIST flag must be set in order for doubly-linked lists to be used. By default flag is only set in Debug builds. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99515 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100074 Review URL: http://codereview.chromium.org/7671034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100525 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 100074 - tcmalloc doubly-linked free-lists for thread cachesbxx@chromium.org2011-09-081-3/+0
| | | | | | | | | | | | | | | | Added the ability for free lists to be built out of doubly-linked lists in tcalloc. TCMALLOC_USE_DOUBLYLINKED_FREELIST flag must be set in order for doubly-linked lists to be used. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99515 Review URL: http://codereview.chromium.org/7671034 TBR=bxx@chromium.org Review URL: http://codereview.chromium.org/7845012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100087 0039d316-1c4b-4281-b951-d872f2087c98
* tcmalloc doubly-linked free-lists for thread cachesbxx@chromium.org2011-09-081-0/+3
| | | | | | | | | | | | | Added the ability for free lists to be built out of doubly-linked lists in tcalloc. TCMALLOC_USE_DOUBLYLINKED_FREELIST flag must be set in order for doubly-linked lists to be used. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99515 Review URL: http://codereview.chromium.org/7671034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100074 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 99515 - tcmalloc doubly-linked free-lists for thread cachesbxx@chromium.org2011-09-031-3/+0
| | | | | | | | | | | | | | Added the ability for free lists to be built out of doubly-linked lists in tcalloc. TCMALLOC_USE_DOUBLYLINKED_FREELIST flag must be set in order for doubly-linked lists to be used. BUG=None TEST=None Review URL: http://codereview.chromium.org/7671034 TBR=bxx@chromium.org Review URL: http://codereview.chromium.org/7834009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99520 0039d316-1c4b-4281-b951-d872f2087c98
* tcmalloc doubly-linked free-lists for thread cachesbxx@chromium.org2011-09-031-0/+3
| | | | | | | | | | | Added the ability for free lists to be built out of doubly-linked lists in tcalloc. TCMALLOC_USE_DOUBLYLINKED_FREELIST flag must be set in order for doubly-linked lists to be used. BUG=None TEST=None Review URL: http://codereview.chromium.org/7671034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99515 0039d316-1c4b-4281-b951-d872f2087c98
* Fix obsolete dependencies so that needless recompilation does not happen.jeanluc@chromium.org2011-08-041-1/+1
| | | | | | | BUG=71130 Review URL: http://codereview.chromium.org/7545020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95527 0039d316-1c4b-4281-b951-d872f2087c98
* tcmalloc: make warning-disable flags match upstreamevan@chromium.org2011-07-181-2/+4
| | | | | | | | | | Upstream turns off some warnings. We should too. BUG=89109 Review URL: http://codereview.chromium.org/7396027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92876 0039d316-1c4b-4281-b951-d872f2087c98
* tcmalloc: disable the warning about ignoring return valuesevan@chromium.org2011-07-131-0/+5
| | | | | | | | | | | If we ever do fix the code, we can reenable the warning. But right now we just ignore the warning so there's no reason to spam it. BUG=89109 Review URL: http://codereview.chromium.org/7352005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92410 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the comments setting emands and vim tab width and expansion variables.tony@chromium.org2011-07-111-6/+0
| | | | | | | | | | | | | | | | | These were added in r28089 (http://codereview.chromium.org/256059) but are unnecessary bloat for everyone to carry around, even those that don't use emacs or vim. In an earlier change, I added editor config files in src/tools/emacs/ and src/tools/vim/ so users of the appropriate editor can source those instead. BUG=none TEST=none Review URL: http://codereview.chromium.org/7310019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92046 0039d316-1c4b-4281-b951-d872f2087c98
* Merge google-perftools r109 (the current contents of ↵glider@chromium.org2011-06-172-2/+9
| | | | | | | | | | | | | third_party/tcmalloc/vendor) with the forked Chromium version of tcmalloc. This change also requires some fixes to base/allocator/allocator.gyp: new tcmalloc source files added, unittest_utils.cc disabled (tcmalloc has its own snprintf() implementation now) Review URL: http://codereview.chromium.org/7050034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89452 0039d316-1c4b-4281-b951-d872f2087c98
* Remove msvs_guids from app, base, breakpad and build.tony@chromium.org2011-06-131-2/+0
| | | | | | | | BUG=28727 Review URL: http://codereview.chromium.org/7108053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88871 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce the ANNOTATE_LEAKING_OBJECT_PTR annotation that can be used to markglider@chromium.org2011-05-311-0/+1
| | | | | | | | | | | | heap allocated objects as intentionally leaked ones. Annotate the histograms produced by {Histogram,BooleanHistogram,LinearHistogram,CustomHistogram}::FactoryGet(), as leaked. Rename StatsHistogram::StatsHistogramFactoryGet to StatsHistogram::FactoryGet, annotate the result as leaky, update the suppressions. BUG=79322 Review URL: http://codereview.chromium.org/7071036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87278 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 86990 - Fix http://codereview.chromium.org/6869009 to ignore an ↵msw@chromium.org2011-05-271-1/+0
| | | | | | | | | | | | | | | | | | | existing object exactly once and land the CL again: Introduce the ANNOTATE_LEAKING_OBJECT_PTR annotation that can be used to mark heap allocated objects as intentionally leaked ones. Annotate the histograms produced by {Histogram,BooleanHistogram,LinearHistogram,CustomHistogram}::FactoryGet(), as leaked. Rename StatsHistogram::StatsHistogramFactoryGet to StatsHistogram::FactoryGet, annotate the result as leaky, update the suppressions. BUG=79322 TBR=jar Review URL: http://codereview.chromium.org/6976044 TBR=glider@chromium.org Review URL: http://codereview.chromium.org/7071035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86993 0039d316-1c4b-4281-b951-d872f2087c98
* Fix http://codereview.chromium.org/6869009 to ignore an existing object ↵glider@chromium.org2011-05-271-0/+1
| | | | | | | | | | | | | | | | exactly once and land the CL again: Introduce the ANNOTATE_LEAKING_OBJECT_PTR annotation that can be used to mark heap allocated objects as intentionally leaked ones. Annotate the histograms produced by {Histogram,BooleanHistogram,LinearHistogram,CustomHistogram}::FactoryGet(), as leaked. Rename StatsHistogram::StatsHistogramFactoryGet to StatsHistogram::FactoryGet, annotate the result as leaky, update the suppressions. BUG=79322 TBR=jar Review URL: http://codereview.chromium.org/6976044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86990 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Land http://codereview.chromium.org/6869009 for the third time."oshima@google.com2011-05-261-1/+0
| | | | | | | | | | | | | | | | | | | | | | This reverts commit d4ff483fbf60aad0b49fddd1937774edb3ba1d7e. --- Introduce the ANNOTATE_LEAKING_OBJECT_PTR annotation that can be used to mark heap allocated objects as intentionally leaked ones. Annotate the histograms produced by {Histogram,BooleanHistogram,LinearHistogram,CustomHistogram}::FactoryGet(), as leaked. Rename StatsHistogram::StatsHistogramFactoryGet to StatsHistogram::FactoryGet, annotate the result as leaky, update the suppressions. --- TBR=glider@chromium.org TEST=HistogramTest.RecordedStartupTest and WebSocketTest.ServerSentData in heapchecker bot wont hang. BUG=79322 Review URL: http://codereview.chromium.org/6962016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86853 0039d316-1c4b-4281-b951-d872f2087c98
* Land http://codereview.chromium.org/6869009 for the third time.glider@chromium.org2011-05-261-0/+1
| | | | | | | | | | | | | | Introduce the ANNOTATE_LEAKING_OBJECT_PTR annotation that can be used to mark heap allocated objects as intentionally leaked ones. Annotate the histograms produced by {Histogram,BooleanHistogram,LinearHistogram,CustomHistogram}::FactoryGet(), as leaked. Rename StatsHistogram::StatsHistogramFactoryGet to StatsHistogram::FactoryGet, annotate the result as leaky, update the suppressions. BUG=79322 TBR=jar,willchan Review URL: http://codereview.chromium.org/7062016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86794 0039d316-1c4b-4281-b951-d872f2087c98
* Globally replace <(library) with static_libraryevan@chromium.org2011-05-191-1/+1
| | | | | | | | | | | We provided <(library) as a variable to support a peculiar build configuration on Linux. We no longer support that build configuration, so we can simplify this code to no longer use a variable. Review URL: http://codereview.chromium.org/7051014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86004 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using TCMALLOC in browser process to fix WinHeap hanging IO thread ↵rtenneti@chromium.org2011-05-191-1/+1
| | | | | | | | | | | | | for 15 secs. Note that the renderer process is still using TCMALLOC, and this only changes the default in the browser process. BUG=83285 TEST=memory unit tests R=jar Review URL: http://codereview.chromium.org/7047018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85998 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 85898 - Re-land http://codereview.chromium.org/6869009 (except for ↵glider@chromium.org2011-05-191-1/+0
| | | | | | | | | | | | | | | | | | | | | the suppressions) Introduce the ANNOTATE_LEAKING_OBJECT_PTR annotation that can be used to mark heap allocated objects as intentionally leaked ones. Annotate the histograms produced by {Histogram,BooleanHistogram,LinearHistogram,CustomHistogram}::FactoryGet(), as leaked. Rename StatsHistogram::StatsHistogramFactoryGet to StatsHistogram::FactoryGet, annotate the result as leaky. The previous commit broke the build on Linux Heapcheck, but looks like the problem has gone now. TBR=jar,willchan BUG=79322 Review URL: http://codereview.chromium.org/7048005 TBR=glider@chromium.org Review URL: http://codereview.chromium.org/7049006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85905 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land http://codereview.chromium.org/6869009 (except for the suppressions)glider@chromium.org2011-05-191-0/+1
| | | | | | | | | | | | | | | | Introduce the ANNOTATE_LEAKING_OBJECT_PTR annotation that can be used to mark heap allocated objects as intentionally leaked ones. Annotate the histograms produced by {Histogram,BooleanHistogram,LinearHistogram,CustomHistogram}::FactoryGet(), as leaked. Rename StatsHistogram::StatsHistogramFactoryGet to StatsHistogram::FactoryGet, annotate the result as leaky. The previous commit broke the build on Linux Heapcheck, but looks like the problem has gone now. TBR=jar,willchan BUG=79322 Review URL: http://codereview.chromium.org/7048005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85898 0039d316-1c4b-4281-b951-d872f2087c98
* The gyp files don't have a way to refer to POSIX-like OS's as a group, so I ↵mark@chromium.org2011-05-121-1/+1
| | | | | | | | | | | | | | | | defined os_posix, toolkit_gtk, and use_x11 in common.gypi to handle them. I used something similar when porting Chromium 10 and 11 to OpenBSD and Solaris, plus a version of this patch has been tested on FreeBSD. Chromium has also been built on other BSDs, so rather than adding each Unix to every gyp file individually every time another port is added, these broad defines can be used instead and modified with specific logic only where necessary. I included a few modified gyp files so the usage can be seen. I also added sunos5 to some grd/html files and set the default host_arch on i86pc solaris to ia32. BUG=0 TEST={} Patch by ruben <chromium@hybridsource.org>. Review URL: http://codereview.chromium.org/6965007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85154 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 82460 - Introduce the ANNOTATE_LEAKING_OBJECT_PTR annotation that can ↵glider@chromium.org2011-04-211-1/+0
| | | | | | | | | be used to markheap allocated objects as intentionally leaked ones.Annotate the histograms produced by {Histogram,BooleanHistogram,LinearHistogram,CustomHistogram}::FactoryGet(), as leaked.Rename StatsHistogram::StatsHistogramFactoryGet to StatsHistogram::FactoryGet, annotate the result as leaky, update the suppressions.BUG=79322Review URL: http://codereview.chromium.org/6869009 TBR=cbentzel Review URL: http://codereview.chromium.org/6873152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82483 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce the ANNOTATE_LEAKING_OBJECT_PTR annotation that can be used to markglider@chromium.org2011-04-211-0/+1
| | | | | | | | | | | | heap allocated objects as intentionally leaked ones. Annotate the histograms produced by {Histogram,BooleanHistogram,LinearHistogram,CustomHistogram}::FactoryGet(), as leaked. Rename StatsHistogram::StatsHistogramFactoryGet to StatsHistogram::FactoryGet, annotate the result as leaky, update the suppressions. BUG=79322 Review URL: http://codereview.chromium.org/6869009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82460 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 79258 - Mark all the free'ed region with special markers so that browserrtenneti@chromium.org2011-03-241-2/+1
| | | | | | | | | | | | | | | | will crash if free'ed memory is accessed (hoping to detect the memory corrupters). Landed the original CL to get results from stability tests. BUG=76891 TBR=jar Review URL: http://codereview.chromium.org/6676098 TBR=rtenneti@chromium.org Review URL: http://codereview.chromium.org/6732018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79259 0039d316-1c4b-4281-b951-d872f2087c98
* Mark all the free'ed region with special markers so that browserrtenneti@chromium.org2011-03-241-1/+2
| | | | | | | | | | | will crash if free'ed memory is accessed (hoping to detect the memory corrupters). BUG=76891 TBR=jar Review URL: http://codereview.chromium.org/6676098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79258 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to using WinHeap for the browser processjar@chromium.org2011-03-241-2/+2
| | | | | | | | | | | | | | | | | | | | | Disabled the TCMalloc double-free detection, which should restore much of the performance loss caused by this experiment (to find double frees, if any). This should resolve bug 76640 As an alternate experiment to better illuminate our memory corruption problem, this CL also enables WinHeap (default Windows allocator) in the browser process. There is a chance that this will cause a very tiny reduction in performance, but it will surely increase our crash rate (based on what we saw recently on the dev channel). BUG=76640 r=rtenneti Review URL: http://codereview.chromium.org/6705027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79224 0039d316-1c4b-4281-b951-d872f2087c98
* Add redundancy to detect double frees in TCMallocjar@chromium.org2011-03-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I don't think I want to ship this to dev or stable, but I think it may be valuable to try on our canary builds. Added a single byte or word (tranparently) to all allocations, and wrote a unique value into that location after each allocation. When free() is called, we validate the flag, and then mark the block as not being allocated. Any time a block fails to validate, we crash, as this means the object either overran its allocated region (or suffered memory corruption), or else (more likely) a double free took place. We have two distinct crash stacks for the two distinct validation problems (corrupt vs double free). ALthough I haven't been able to demonstrate a problem on the bots, I'm pretty psyched to try to find something in the field with this change. The perf loss is very low, and I think that the likely cause for TCMalloc cross-linked-list corruption (double frees) will be detected (I can hope!) R=mbelshe BUG=75921 Review URL: http://codereview.chromium.org/6683029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78369 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 78166 - Test impact of an allocator change to detect double freesjar@chromium.org2011-03-151-1/+1
| | | | | | | | | | | | I'll revert as soon as the builds kick off. TBR=willchan Review URL: http://codereview.chromium.org/6677037 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/6693013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78169 0039d316-1c4b-4281-b951-d872f2087c98
* Test impact of an allocator change to detect double freesjar@chromium.org2011-03-151-1/+1
| | | | | | | | | I'll revert as soon as the builds kick off. TBR=willchan Review URL: http://codereview.chromium.org/6677037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78166 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 77958 - Make sure Windows default heap will crash on corruptionjar@chromium.org2011-03-131-3/+0
| | | | | | | | | | | | | | | I'm hoping this will get us some crashes on double frees, but I'm wary about performance impact, so I'll land this, and then revert it, to see what impact it has on the perf bots. TBR=cpu Review URL: http://codereview.chromium.org/6686022 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/6686030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77962 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure Windows default heap will crash on corruptionjar@chromium.org2011-03-131-0/+3
| | | | | | | | | | | | I'm hoping this will get us some crashes on double frees, but I'm wary about performance impact, so I'll land this, and then revert it, to see what impact it has on the perf bots. TBR=cpu Review URL: http://codereview.chromium.org/6686022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77958 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 77948 - Add redundancy to detect double frees in TCMallocjar@chromium.org2011-03-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [I just wanted to kick a reliability run with it as a test] Added a single byte or word (tranparently) to all allocations, and wrote a unique value into that location after each allocation. When free() is called, we validate the flag, and then mark the block as not being allocated. Any time a block fails to validate, we crash, as this means the object either overran its allocated region (or suffered memory corruption), or else (more likely) a double free took place. We have two distinct crash stacks for the two distinct validation problems (corrupt vs double free). I did a first landing of this patch to test perf impact and see what corruption it surfaced in: http://src.chromium.org/viewvc/chrome?view=rev&revision=77941 It appears that Windows is not using TCMalloc on our bots. TBR=mbelshe Review URL: http://codereview.chromium.org/6683027 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/6682020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77949 0039d316-1c4b-4281-b951-d872f2087c98
* Add redundancy to detect double frees in TCMallocjar@chromium.org2011-03-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added a single byte or word (tranparently) to all allocations, and wrote a unique value into that location after each allocation. When free() is called, we validate the flag, and then mark the block as not being allocated. Any time a block fails to validate, we crash, as this means the object either overran its allocated region (or suffered memory corruption), or else (more likely) a double free took place. We have two distinct crash stacks for the two distinct validation problems (corrupt vs double free). I did a first landing of this patch to test perf impact and see what corruption it surfaced in: http://src.chromium.org/viewvc/chrome?view=rev&revision=77941 It appears that Windows is not using TCMalloc on our bots. TBR=mbelshe Review URL: http://codereview.chromium.org/6683027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77948 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 77941 - Add redundancy to detect double frees in TCMallocjar@chromium.org2011-03-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | I'll land and revert this quickly, to see what impact it has on performance. Added a single byte or word (tranparently) to all allocations, and wrote a unique value into that location after each allocation. When free() is called, we validate the flag, and then mark the block as not being allocated. Any time a block fails to validate, we crash, as this means the object either overran its allocated region (or suffered memory corruption), or else (more likely) a double free took place. We have two distinct crash stacks for the two distinct validation problems (corrupt vs double free). TBR=mbelshe Review URL: http://codereview.chromium.org/6679021 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/6679029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77942 0039d316-1c4b-4281-b951-d872f2087c98
* Add redundancy to detect double frees in TCMallocjar@chromium.org2011-03-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | I'll land and revert this quickly, to see what impact it has on performance. Added a single byte or word (tranparently) to all allocations, and wrote a unique value into that location after each allocation. When free() is called, we validate the flag, and then mark the block as not being allocated. Any time a block fails to validate, we crash, as this means the object either overran its allocated region (or suffered memory corruption), or else (more likely) a double free took place. We have two distinct crash stacks for the two distinct validation problems (corrupt vs double free). TBR=mbelshe Review URL: http://codereview.chromium.org/6679021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77941 0039d316-1c4b-4281-b951-d872f2087c98
* Support mixed allocation in browser vs subprocessesjar@chromium.org2011-03-083-18/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [This is a re-landing of CL 6623059, which broke the shared library build on windows in revision 77207. An ifdef has been added to avoid the unresolved variable when allocator_shim.cc is never even compiled] Continue to support selection of a browser allocator selection via the environment variable CHROME_ALLOCATOR, and also add CHROME_ALLOCATOR_2 that can select the allocator to use in subprocesses, such as a renderer. Temporarilly set the browser default to the default windows heap allocator, and the subprocess allocator to TCMalloc to help detect memory corruption in a cannary for a few days. This may illuminate some flakiness in the tree, as double frees (hidden by races) may cause crashes. Add minor cleanup (removing reserved word "override" etc.). BUG=74901 TBR=mbelshe Review URL: http://codereview.chromium.org/6623072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77245 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 77207 - Support mixed allocation in browser vs subprocessesjar@chromium.org2011-03-073-78/+18
| | | | | | | | | | | | | | | | | | | | | | | | | Continue to support selection of a browser allocator selection via the environment variable CHROME_ALLOCATOR, and also add CHROME_ALLOCATOR_2 that can select the allocator to use in subprocesses, such as a renderer. Temporarilly set the browser default to the default windows heap allocator, and the subprocess allocator to TCMalloc to help detect memory corruption in a cannary for a few days. Add minor cleanup (removing reserved word "override" etc.). r=mbelshe bug=74901 Review URL: http://codereview.chromium.org/6623059 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/6623069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77208 0039d316-1c4b-4281-b951-d872f2087c98
* Support mixed allocation in browser vs subprocessesjar@chromium.org2011-03-073-18/+78
| | | | | | | | | | | | | | | | | | | | | | Continue to support selection of a browser allocator selection via the environment variable CHROME_ALLOCATOR, and also add CHROME_ALLOCATOR_2 that can select the allocator to use in subprocesses, such as a renderer. Temporarilly set the browser default to the default windows heap allocator, and the subprocess allocator to TCMalloc to help detect memory corruption in a cannary for a few days. Add minor cleanup (removing reserved word "override" etc.). r=mbelshe bug=74901 Review URL: http://codereview.chromium.org/6623059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77207 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 77111 - Test performance of default allocator in browser processjar@chromium.org2011-03-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | This is a test, and will be reverted as soon as the build starts. We just want to see what the perf bots have to say. This CL changes the default allocator to be the Windows Allocator (rather than TCMalloc), but then overrides that default via the environment variable control *during* the running of the browser_main. The result is that the browser process will use the Windows Allocator, but all sub-processes, such as renderers, will use TCMalloc. TBR=cpu BUG=74901 Review URL: http://codereview.chromium.org/6624050 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/6627045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77116 0039d316-1c4b-4281-b951-d872f2087c98
* Test performance of default allocator in browser processjar@chromium.org2011-03-071-1/+1
| | | | | | | | | | | | | | | | | | | | | This is a test, and will be reverted as soon as the build starts. We just want to see what the perf bots have to say. This CL changes the default allocator to be the Windows Allocator (rather than TCMalloc), but then overrides that default via the environment variable control *during* the running of the browser_main. The result is that the browser process will use the Windows Allocator, but all sub-processes, such as renderers, will use TCMalloc. TBR=cpu BUG=74901 Review URL: http://codereview.chromium.org/6624050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77111 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 77066 - Test impact of using default windows allocatorjar@chromium.org2011-03-061-1/+1
| | | | | | | | | | | | | | | | | | | I'll revert this as soon as the builds kick off. I just want to look at perf impact. I'll ceate a fancier CL that uses different allocators for render vs browser, but I wanted an overall baseline for transitioning completely from TCMalloc to the default allocator on Windows. TBR=cpu Review URL: http://codereview.chromium.org/6635004 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/6623041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77067 0039d316-1c4b-4281-b951-d872f2087c98
* Test impact of using default windows allocatorjar@chromium.org2011-03-061-1/+1
| | | | | | | | | | | | | | | | I'll revert this as soon as the builds kick off. I just want to look at perf impact. I'll ceate a fancier CL that uses different allocators for render vs browser, but I wanted an overall baseline for transitioning completely from TCMalloc to the default allocator on Windows. TBR=cpu Review URL: http://codereview.chromium.org/6635004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77066 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete dependencies that create needless recompiling.jeanluc@chromium.org2011-02-151-1/+0
| | | | | | | | | BUG=71130 Review URL: http://codereview.chromium.org/6523009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74966 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 73121 - Remove obsolete files from 'sources'. This causes needless ↵nsylvain@chromium.org2011-01-311-0/+1
| | | | | | | | | | | | | | | | | | work on incremental builds in VS2010. This is breaking clobber builds with this error : e:\b\build\slave\google-chrome-rel-win\build\src\chrome_frame\iids.cc(6) : fatal error C1083: Cannot open include file: 'chrome_tab.h': No such file or directory BUG=71130 TEST=Check that Chrome builds. Review URL: http://codereview.chromium.org/6307018 TBR=jeanluc@chromium.org Review URL: http://codereview.chromium.org/6347032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73124 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 06:29:26 +0000