| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
This allows classes to more naturally extend classes using WeakPtr.
TEST=None
BUG=
Review URL: https://chromiumcodereview.appspot.com/10537127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It will be needed in webkit/dom_storage/.
BUG=NONE
TEST=Existing tests.
Review URL: https://chromiumcodereview.appspot.com/10540003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBRing as it is a simple gyp change.
TBR=mark@chromium.org
BUG=125059
TEST=
Review URL: https://chromiumcodereview.appspot.com/10544080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding a nacl version of base.
BUG=None
TEST=None
R=bbudge@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10389196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally base.gypi was intended to sequester the syntactic trick
used to instantiate base as both regular Win32 base and base_nacl_win64.
The intention was to keep all the magic in one place.
It's unclear if this is a real advantage.
In a coming CL we will want to instantiate base a third time as a nacl
module. Rather than do that in base.gyp (bringing in a nacl dependency),
we will instead add base_untrusted.gyp in this directory.
Repositioning everything outside target_defaults in base.gypi will
allow us to include it in two places.
All targets and conditional targets are moved to base.gyp.
BUG=None
TEST=builds
R=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10532040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
content files. Fix the instances other sandbox stuff, which I'll do in a followup.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/10512010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an upstream of chromium-android.
The WebKit part is https://bugs.webkit.org/show_bug.cgi?id=86862.
TBR=darin (for base/base.gyp)
BUG=none
TEST=build and run current native tests without error
Review URL: https://chromiumcodereview.appspot.com/10408091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The primary issues is specifying the right path to PRODUCT_DIR (i.e.
out/Release). The gyp generator for make specifies the absolute path but
for ninja would use a relative path. Since the gyp targets don't line
up with where the ant build files are located this causes failures such
as base's java being generated in base/android/out/Release/...
See:
https://groups.google.com/forum/#!msg/gyp-developer/K2T_9obUya0/qq78_Ut-E-AJ
for details.
A couple of other minor fixes:
- content java files are placed in out/Release/java/content to be
consisent with other packages.
- shared-libraries are now referenced by correct variables for apk-based
tests
- removed unused media/base/android/java/java.gyp (target is in
media/media.gyp)
TBR=mark@chromium.org,ben@chromium.org,rsleevi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10386188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When tests are run in an APK, we do not have an executable to exec.
We resort to forking and executing the test method directly.
BUG=125059
TEST=
Review URL: https://chromiumcodereview.appspot.com/10408081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a gyp template to simplify adding new targets.
- Add support for multiple jars in the test APK.
BUG=125059
TEST=
Review URL: https://chromiumcodereview.appspot.com/10399126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change does the following:
* Parses the input string and generates the object representation in O(n) time.
* Optimizes string decoding by using StringPiece where possible, which also
introduces the JSON_DETACHABLE_CHILDREN parser option.
* Makes JSONReader a simpler interface by hiding the parser details in an
internal JSONParser class.
BUG=49212,111581,121469
TEST=Hopefully covered by all test suites. New tests added for edge cases.
Review URL: https://chromiumcodereview.appspot.com/10035042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test failures are ignored for now.
TBR=mark@chromium.org,tsepez@chromium.org
BUG=125059
TEST=
Review URL: https://chromiumcodereview.appspot.com/10387086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename tests_run to test_isolation_mode.
TBR=mad@chromium.org
BUG=98636
TEST=
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10392073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, Don't make try_compile_test bot RED if native tests APK fails to compile.
BUG=125059
TBR=mark@chromium.org,tsepez@chromium.org
TEST=
Review URL: https://chromiumcodereview.appspot.com/10310098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed an "unused variable" issue of the original CL (http://codereview.chromium.org/10224004/).
Use Android API for GetDisplayNameForLocale().
Using Android API, we can reduce the data size of ICU and thus reduce the
binary size of chromium-android.
BUG=none
TEST=L10nUtilTest.GetDisplayNameForLocale,L10nUtilTest.GetDisplayNameForCountry
TBR=jrg@chromium.org,isherman@chromium.org,mark@chromium.org,jshin@chromium.org,rvargas@chromium.org
Review URL: http://codereview.chromium.org/10310029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
failure:
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/4835/steps/BuildTarget/logs/stdio
Using Android API, we can reduce the data size of ICU and thus reduce the
binary size of chromium-android.
BUG=none
TEST=L10nUtilTest.GetDisplayNameForLocale,L10nUtilTest.GetDisplayNameForCountry
TBR=sky
Review URL: http://codereview.chromium.org/10224004
TBR=wangxianzhu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10380018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using Android API, we can reduce the data size of ICU and thus reduce the
binary size of chromium-android.
BUG=none
TEST=L10nUtilTest.GetDisplayNameForLocale,L10nUtilTest.GetDisplayNameForCountry
TBR=sky
Review URL: http://codereview.chromium.org/10224004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- This test invokes JNI calls and included only if gtest_target_type=shared_library.
- Also set the application context to get these JNI calls working.
BUG=125059
TEST=
Review URL: http://codereview.chromium.org/10161032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also adding unittests to FileUtilProxy.
BUG=123558,77454
TEST=FileUtilProxyTest.*
Review URL: http://codereview.chromium.org/10095028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
foo=bar.
Otherwise, path quoting gets in the way on windows in a way that is very hard to
fix, as the 'bar' value could have double-quote in it, resulting in something like foo="bar".
R=nsylvain@chromium.org
R=mark@chromium.org
R=rsleevi@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/10139020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(ipc, base).
OFF by default; enable with a gyp var. E.g.
GYP_DEFINES="$GYP_DEFINES gtest_target_type=shared_library" android_gyp
Some useful commands:
adb uninstall org.chromium.native_test
adb install -r out/Release/base_unittests_apk/ChromeNativeTests-debug.apk
adb shell am start -n org.chromium.native_test/org.chromium.native_test.ChromeNativeTestActivity
For the moment, all apks can be built simultaneously but use the same
activity name. Thus you cannot have more than one installed at the
same time.
BUG=None
TEST=
Review URL: http://codereview.chromium.org/10051021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reapplying r132608. Original code review: http://codereview.chromium.org/10062001
Fixed cacheinvalidation_unittests.
It makes the code simpler by automatically deducing the root directory to use.
TBR=rogerta@chromium.org
TBR=mark@chromium.org
TBR=rsleevi@chromium.org
BUG=98834
TEST=
Review URL: http://codereview.chromium.org/10115025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It makes the code simpler by automatically deducing the root directory to use.
R=rogerta@chromium.org
TBR=mark@chromium.org
TBR=rsleevi@chromium.org
BUG=98834
TEST=
Review URL: http://codereview.chromium.org/10062001
TBR=maruel@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10117005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It makes the code simpler by automatically deducing the root directory to use.
R=rogerta@chromium.org
TBR=mark@chromium.org
TBR=rsleevi@chromium.org
BUG=98834
TEST=
Review URL: http://codereview.chromium.org/10062001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
As requested in http://codereview.chromium.org/10073024/, I've created
templates for these two actions. I've also applied them to base.
Review URL: http://codereview.chromium.org/10081035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=TBD
TEST=no
Review URL: http://codereview.chromium.org/9416060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert base_unittests_run and net_unittests_run to use the new format.
Rename isolate_files to isolate_dependency_tracked and ..._dirs to ..._untracked.
Rewrite merge_isolate.py to have fully deterministic and sane behavior, especially for 'else' conditions.
Convert 'python' to sys.executable when running the command.
Add a lot of unit tests.
Move hashtable default directory into dirname(result) + '/hashtable'.
R=rogerta@chromium.org
R=mark@chromium.org
R=rsleevi@chromium.org
BUG=98834
TEST=
Review URL: http://codereview.chromium.org/10019014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move it into anonymous namespace in sequenced_worker_pool.cc.
BUG=122458
TEST=trybots
Review URL: http://codereview.chromium.org/10005054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Third time is a charm.
Original Reviews:
https://chromiumcodereview.appspot.com/9838033/
http://codereview.chromium.org/9967017
Revert "Revert 131593"
This reverts commit e306ea7f630d4264075913ea3a1a728d98ca9605.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9960072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Speculatively reverting due to gyp update error on official bots:
KeyError: 'src/breakpad/breakpad.gyp:dump_syms#target while trying to load target src/remoting/remoting.gyp:remoting_linux_symbols#target'
This is the only patch in the regression range that touches breakpad.gyp.
---
Upstream Android native crash handling changes.
This is actulaly the second time.
Revert "Revert 131404 - Upstream native crash handling changes for Android."
This reverts commit 421df96aab6267e963ddff16c9f738aa903a2cba.
Conflicts:
chrome/browser/chrome_browser_main.cc
BUG=
TEST=
Review URL: http://codereview.chromium.org/9967017
TBR=carlosvaldivia@google.com
Review URL: https://chromiumcodereview.appspot.com/10037013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is actulaly the second time.
Revert "Revert 131404 - Upstream native crash handling changes for Android."
This reverts commit 421df96aab6267e963ddff16c9f738aa903a2cba.
Conflicts:
chrome/browser/chrome_browser_main.cc
BUG=
TEST=
Review URL: http://codereview.chromium.org/9967017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Android native crash handling is almost identical to linux handling with
some differences.
Note that even after this change Chrome on Android will not compile with
the USE_LINUX_BREAKPAD flag. Forthcomming changes in breakpad should
remedy this state of affairs.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9838033
TBR=carlosvaldivia@google.com
Review URL: https://chromiumcodereview.appspot.com/9999004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Android native crash handling is almost identical to linux handling with
some differences.
Note that even after this change Chrome on Android will not compile with
the USE_LINUX_BREAKPAD flag. Forthcomming changes in breakpad should
remedy this state of affairs.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9838033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CreateProcess calls.
This CL includes the definition of the class along with changes to clients of CreateProcess.
Please see http://codereview.chromium.org/9959018/ for the most substantial usages I propose introducing.
This was motivated by realizing that my previous fix to LaunchProcess actually still had a leak of the thread handle.
BUG=None
TEST=tests added in base_unittests
Review URL: https://chromiumcodereview.appspot.com/9700038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also includes specification tests for SequencedTaskRunner.
BUG=114330,114327
TEST=--gtest_filter=SequencedWorkerPoolTaskRunner*
Review URL: http://codereview.chromium.org/9663075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because |char| is signed, the upper bits of the BOM bytes were getting
interpreted as the sign bit. Cast to |uint8| to preserve them for proper
comparison.
BUG=119975
TEST=Try to install the Gmail extension. Do not get JSON error when unpacking.
Review URL: http://codereview.chromium.org/9860035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
128680 in GYP phse, this is the only change that touched GYP files.
apk-based test runner work. Not enabled yet. This CL is a combination of upstreaming, ndk/ant-ification, and other tweaks.
BUG=None
TEST=
Review URL: http://codereview.chromium.org/9834037
TBR=jrg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9852004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
upstreaming, ndk/ant-ification, and other tweaks.
BUG=None
TEST=
Review URL: http://codereview.chromium.org/9834037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make all the places that include run_all_unittests.cc manually depend
on this target instead.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9691067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=The "DumpRenderTree" target on the FYI bot should link.
Review URL: http://codereview.chromium.org/9706022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/9443018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/9657025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add --flags flag to isolate.py.
Fix issue with directory dependency.
R=rogerta@chromium.org,mark@chromium.org
BUG=117176
TEST="GYP_DEFINES=tests_run=run build/gyp_chromium; cd out/Debug; ninja base_unittests_run" work
Review URL: http://codereview.chromium.org/9621014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A few more changes as required by:
http://codereview.chromium.org/9466024/
Also, rather than just running the python-based tests
(jni_generator_py_tests), we'll now run the full suite
(jni_generator_tests) instead.
BUG=none
TEST=jni_generator_tests
Review URL: http://codereview.chromium.org/9599010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This target uses isolate.py to run the unit test in a separate directory.
BUG=98636
TEST=
Review URL: http://codereview.chromium.org/9513003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Split out from https://chromiumcodereview.appspot.com/9363008/
BUG=110400
TEST=NONE
Review URL: http://codereview.chromium.org/9580018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
notification to SystemMonitor and Mac impl
BUG=110400
TEST=run chrome with -v=1, attach and a mass storage media device and observe the log entries for the attach and detach events.
Review URL: https://chromiumcodereview.appspot.com/9363008
TBR=vandebo@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9555014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9549012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=110400
TEST=run chrome with -v=1, attach and a mass storage media device and observe the log entries for the attach and detach events.
Review URL: https://chromiumcodereview.appspot.com/9363008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes a dependency from sync stuff to chrome/common stuff.
test utility functions should belong with their corresponding classes anyway.
BUG=113723
TEST=
Review URL: http://codereview.chromium.org/9483002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124112 0039d316-1c4b-4281-b951-d872f2087c98
|