summaryrefslogtreecommitdiffstats
path: root/base/base.gyp
Commit message (Collapse)AuthorAgeFilesLines
...
* Create the crash key registration system and register some Mac-specific keys.rsesek@chromium.org2013-01-151-0/+1
| | | | | | | | | BUG=77656 Review URL: https://chromiumcodereview.appspot.com/11761030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177015 0039d316-1c4b-4281-b951-d872f2087c98
* TCMalloc: restrict maximum size of memory allocationsjln@chromium.org2013-01-151-0/+1
| | | | | | | | | | | | For security purposes, we restrict the maximum size of memory allocations under what can be indexed by an int. BUG=169327 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11857007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176961 0039d316-1c4b-4281-b951-d872f2087c98
* Serialize/Deserialize support in HistogramBasekaiwang@chromium.org2013-01-111-0/+1
| | | | | | | | | BUG=139612,167343 Review URL: https://chromiumcodereview.appspot.com/11682003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176449 0039d316-1c4b-4281-b951-d872f2087c98
* Make all base targets build on Win64jschuh@chromium.org2013-01-091-0/+10
| | | | | | | | | BUG=166496 BUG=167187 Review URL: https://chromiumcodereview.appspot.com/11825006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175916 0039d316-1c4b-4281-b951-d872f2087c98
* android: Pass CPU properties from browser to renderer process.digit@chromium.org2013-01-091-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | This is necessary to allow the renderer processes to use NEON instructions on ARM devices that support them in libraries like Skia. The main issue is that on JellyBean and higher, the renderer process runs in a sandbox that prevents it from accessing the filesystem, including /proc/ which is the only way to query the kernel for the features detected by the CPU. To overcome this, send the result of the probe to each renderer process, which will use the new android_setCpu() function introduced in https://gerrit.chromium.org/gerrit/#/c/39370/ Note that this requires that third-party libraries use the android_getCpuCount() and android_getCpuFeatures() function to get this data at runtime. BUG=164154 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11503013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175820 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add option to use system nspr.phajdan.jr@chromium.org2013-01-081-0/+10
| | | | | | | | | | Note that for NaCl bundles nspr files will be used anyway, since NaCl toolchain doesn't looks for libraries in system directories. BUG=none Review URL: https://codereview.chromium.org/11685002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175539 0039d316-1c4b-4281-b951-d872f2087c98
* Implement SequenceChecker, which is a generalization of ThreadCheckerakalin@chromium.org2012-12-271-0/+4
| | | | | | | | | | | | | | SequenceChecker will be used in WeakPtr instead of ThreadChecker, since WeakPtr needs only the guarantees of a SequencedTaskRunner. Add NullTaskRunner implementation and make test_browser_context.cc use it. BUG=165590 Review URL: https://codereview.chromium.org/11550031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174693 0039d316-1c4b-4281-b951-d872f2087c98
* Base: Modify ScopedHandle so that Receive() doesn't fully expose the gutsrvargas@google.com2012-12-221-0/+1
| | | | | | | | | | of the object from that point until destruction. BUG=none TEST=base_unittests Review URL: https://codereview.chromium.org/11618048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174480 0039d316-1c4b-4281-b951-d872f2087c98
* Unify various test TaskRunner implementationsakalin@chromium.org2012-12-191-0/+4
| | | | | | | | | | | | | | Remove various ad-hoc test implementations of TaskRunner and implement TestSimpleTaskRunner instead. Add TestPendingTask class for use by test TaskRunner implementations. Clean up TestTaskRunner implementation in net/ and make it use TestPendingTask. BUG=165806 Review URL: https://codereview.chromium.org/11554036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174016 0039d316-1c4b-4281-b951-d872f2087c98
* Remove extra string copies when iterating listsjoth@chromium.org2012-12-141-0/+1
| | | | | | | | | | | Micro-opimization: remove additional string deep copies in inner loops. BUG= Review URL: https://chromiumcodereview.appspot.com/11416360 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173035 0039d316-1c4b-4281-b951-d872f2087c98
* Move PrefMember to base/prefs/public now that it has no bad dependencies.joi@chromium.org2012-12-121-1/+3
| | | | | | | | | | | | | | | | | | Move PrefObserver out of base/prefs/public to base/prefs/ since it is now an internal implementation detail. Update .gyp(i) files to match. The rest is just mechanical updates to include paths and such, generated by the tools/git/move_source_file.py script. TBR=brettw@chromium.org BUG=155525 Review URL: https://chromiumcodereview.appspot.com/11459002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172581 0039d316-1c4b-4281-b951-d872f2087c98
* Create LibDispatchTaskRunner, a SingleThreadTaskRunner that is backed by a ↵rsesek@chromium.org2012-12-071-0/+1
| | | | | | | | | | | | | | | libdispatch queue. This task runner is meant to be used when an object needs to live on a single thread but needs to both post tasks and receive callbacks via a dispatch queue. BUG=158170 TEST=Covered by new unit test. Review URL: https://chromiumcodereview.appspot.com/11464009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171718 0039d316-1c4b-4281-b951-d872f2087c98
* Add STLSetDifference to stl_util.h, because std::set_difference is extremelykalman@chromium.org2012-12-051-0/+1
| | | | | | | | | awkward to work with. Review URL: https://chromiumcodereview.appspot.com/11415239 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171321 0039d316-1c4b-4281-b951-d872f2087c98
* Enable MessageLoop unittests on iOS and fix MessagePumpIOForIOS bug.blundell@chromium.org2012-12-041-5/+0
| | | | | | | | | | | | | | | | This CL does follow-up work to https://chromiumcodereview.appspot.com/11412101/ : 1. Turns on MessageLoop unittests on iOS. 2. Fixes a bug that the |FileDescriptorWatcherOutlivesMessageLoop| test uncovered wherein |FileDescriptorWatcher| needs to retain its pump to ensure that it can safely call |RemoveRunLoopSource()| on the pump at destruction if necessary. 3. Stops message_pump_libevent being built on iOS. Review URL: https://chromiumcodereview.appspot.com/11299301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170965 0039d316-1c4b-4281-b951-d872f2087c98
* Provide an iOS message pump for IO implementation.blundell@chromium.org2012-11-301-3/+8
| | | | | | | | | The implementation is done as a subclass of MessagePumpNSRunLoop. It is conceptually quite similar to the libevent implementation (message_pump_libevent*), on which it is based. Review URL: https://chromiumcodereview.appspot.com/11412101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170470 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 170287 - Add dependency on allocator.gyp from 'base' and export itakalin@chromium.org2012-11-301-14/+6
| | | | | | | | | | | | | | | | | | This is so that other targets don't have to depend on allocator.gyp themselves if they only depend on it via base. Add explicit dependency on allocator.gyp from base_unittests. Add 'toolsets' property to 'allocator' target (for ChromeOS builds). BUG=162998 Review URL: https://codereview.chromium.org/11411243 TBR=akalin@chromium.org Review URL: https://codereview.chromium.org/11416275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170300 0039d316-1c4b-4281-b951-d872f2087c98
* Add dependency on allocator.gyp from 'base' and export itakalin@chromium.org2012-11-291-6/+14
| | | | | | | | | | | | | | | This is so that other targets don't have to depend on allocator.gyp themselves if they only depend on it via base. Add explicit dependency on allocator.gyp from base_unittests. Add 'toolsets' property to 'allocator' target (for ChromeOS builds). BUG=162998 Review URL: https://codereview.chromium.org/11411243 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170287 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_temp_dir from base to base/filesbrettw@chromium.org2012-11-161-1/+1
| | | | | | | | | | Also add to base namespace. BUG= Review URL: https://codereview.chromium.org/11359217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168281 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Make Linux stack dump signal handler async-signal safe.phajdan.jr@chromium.org2012-11-141-0/+4
| | | | | | | | | | | This also re-enables in-process stack dumping on Linux. BUG=101155 Review URL: https://chromiumcodereview.appspot.com/11362048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167714 0039d316-1c4b-4281-b951-d872f2087c98
* Move mru_cache to the new containers subdirectory.brettw@chromium.org2012-11-131-1/+1
| | | | | | Review URL: https://codereview.chromium.org/11361193 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167456 0039d316-1c4b-4281-b951-d872f2087c98
* Move stack_container and linked_list to the new containers subdirectory.brettw@chromium.org2012-11-101-2/+2
| | | | | | | | | | This also replaces the StackWString with StackString16 and adds a char traits definition to the string16 header file to make this possible without ifdefs. BUG= Review URL: https://codereview.chromium.org/11360174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167022 0039d316-1c4b-4281-b951-d872f2087c98
* Add a SmallMap to base for small map lookups.brettw@chromium.org2012-11-091-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This map has a static array that it will check brute-force before overflowing into a normal map. For cases where simple key-value lookup is needed where there are not expected to be many elements, this will be faster. This adds ManualConstructor which is required for this. This code is from internal util/gtl/small_map.h. I made the following changes: Renamed small_map to SmallMap. Added everything to the base namespace. Added the helper templates at the top to a sub namespace "internal" I renamed small_map_default_init to SmallMapDefaultInit since it's a class and that's how we name clases. However, I didn't rename has_key_equal and select_key_equal since those work with something called key_equal on the base container. I went back and forth on this, I'm happy to change. Renamed the non-STL-like functions to CamelCase. The only case was "using_full_map" -> UsingFullMap Removed unit test for the size of a Small Map (I don't think we care). Added note about preferring hash_map for key equality checking. Redid manual_constructor to use aligned_memory instead of manually doing everything itself. This removed a bunch of preprocessor goop and manual alignment. I also removed the 9-12 argument constructor versions of Init, which seemed excessive. Removed InsertIfNotPresent unit test (we don't have an InsertIfNotPresent map helper function). Added std:: on various things like pairs and make_pair and max. Made SmallMap::size() and count() and erase() return size_t insted of int to keep compat for unsigned-vs-signed for STL. Added "u" after numbers in EXPECT_EQs to avoid signed/unsigned warnings. BUG= Review URL: https://codereview.chromium.org/11366050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167001 0039d316-1c4b-4281-b951-d872f2087c98
* Move FileDescriptorShuffle to base/posix. This file is very posix-specific.brettw@chromium.org2012-11-091-3/+3
| | | | | | | | | TEST=it compiles BUG=none Review URL: https://codereview.chromium.org/10399100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166970 0039d316-1c4b-4281-b951-d872f2087c98
* Remove content::NotificationObserver dependency from most Prefs code.joi@chromium.org2012-11-011-0/+1
| | | | | | | | | | | | | | | | | | | | | Instead of using content::NotificationObserver, introduce specific type-safe observer classes and update users to use them. In a very large number of cases this was the users' only reason for being a content::NotificationObserver and they would have a lot of boiler-plate code such as a DCHECK on the notification type and unpacking of the generic NotificationDetails types, so this change removes a bunch of boilerplate and introduces more type safety. This is part of enabling more of the Prefs code to live in base/prefs/. TBR=ben@chromium.org,brettw@chromium.org BUG=155525 Review URL: https://chromiumcodereview.appspot.com/11345008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165414 0039d316-1c4b-4281-b951-d872f2087c98
* Adding 'base_prefs' target to base/gypi.joi@chromium.org2012-11-011-0/+36
| | | | | | | | | BUG=155525 Review URL: https://chromiumcodereview.appspot.com/11336034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165343 0039d316-1c4b-4281-b951-d872f2087c98
* Move ImportantFileWriter to base/. It now has two consumers, base/prefs and ↵joi@chromium.org2012-10-241-0/+1
| | | | | | | | | | | | chrome/. TBR=ben@chromium.org BUG=155525 Review URL: https://chromiumcodereview.appspot.com/11227026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163840 0039d316-1c4b-4281-b951-d872f2087c98
* Convert all the foo_test_run from using actions to use rules.maruel@chromium.org2012-10-201-21/+3
| | | | | | | | | | | | | | | This removes a lot of the duplication of the exact details about how to run isolate.py exactly.. This will permit inserting arbitrary command line arguments eventually, for --subdir support. TBR=csharp@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11236005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163144 0039d316-1c4b-4281-b951-d872f2087c98
* Include stack_trace_unittest.cc in Android buildnileshagrawal@chromium.org2012-10-191-4/+0
| | | | | | | | | | | TBR=mark@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11187061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163076 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some unit tests from iOS coverage buildslliabraa@chromium.org2012-10-161-2/+12
| | | | | | | | | | Several unit tests cause the test app to crash when run with coverage=1. BUG=156058 Review URL: https://chromiumcodereview.appspot.com/11155006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162126 0039d316-1c4b-4281-b951-d872f2087c98
* Android: Integrates native and java SystemMonitor.bulach@chromium.org2012-10-161-0/+1
| | | | | | | | BUG=154293 Review URL: https://chromiumcodereview.appspot.com/11027024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162124 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for coverage=1 builds on iOSstuartmorgan@chromium.org2012-10-121-0/+10
| | | | | | | | | | | | Uses the same method as is used on Mac to enable coverage. Some sources need to be removed in coverage mode due to a toolchain bug. BUG=None Review URL: https://chromiumcodereview.appspot.com/11111014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161633 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream base/android/jni_android.ccavayvod@chromium.org2012-10-091-0/+1
| | | | | | | | | | | | | | | Original change descriptions: - make JNIAndroidTest work with --gtest_repeat - add java exception info to breakpad - add JniArray test BUG=136707 TEST=Built and run jni_android_unittests.cc Review URL: https://chromiumcodereview.appspot.com/11090022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160895 0039d316-1c4b-4281-b951-d872f2087c98
* Make java.gypi use all_dependent_settings for input_jars_pathscjhopman@chromium.org2012-10-091-3/+0
| | | | | | | | | | | | | | | | | | all_dependent_settings is more like the link_settings that we would like to use here. This variable is used by java targets to set the classpath for javac, i.e. to set the libraries that are needed by the target. Use of direct_dependent_settings with export_dependent_settings causes unnecessary duplication of all java dependencies for all of our java library targets. BUG=146049 TBR=sky,brettw Review URL: https://chromiumcodereview.appspot.com/10986094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160768 0039d316-1c4b-4281-b951-d872f2087c98
* Add SampleMap and use it in SparseHistogramkaiwang@chromium.org2012-10-051-0/+1
| | | | | | | | | BUG=139612 Review URL: https://chromiumcodereview.appspot.com/11022002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160485 0039d316-1c4b-4281-b951-d872f2087c98
* Rename .swarm to .isolated, as done in r160469.maruel@chromium.org2012-10-051-1/+1
| | | | | | | | | | TBR=csharp@chromium.org NOTRY=true BUG= Review URL: https://codereview.chromium.org/11029063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160471 0039d316-1c4b-4281-b951-d872f2087c98
* Don't make base/net/ui depend on their Java counterpart when building for ↵pliard@chromium.org2012-10-051-1/+5
| | | | | | | | | | | | webview. This is needed to build Android webview. TBR=brettw,willchan,sky Review URL: https://chromiumcodereview.appspot.com/11065035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160390 0039d316-1c4b-4281-b951-d872f2087c98
* Update all the .results to .swarm.maruel@chromium.org2012-10-051-1/+1
| | | | | | | | | | | | | Starting with r160349, isolate.py now produces .swarm instead of .results files. TBR=csharp@chromium.org NOTRY=true BUG= Review URL: https://chromiumcodereview.appspot.com/11035056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160355 0039d316-1c4b-4281-b951-d872f2087c98
* Move src/tools/isolate to src/tools/swarm_client@159961 as a DEPS.maruel@chromium.org2012-10-041-1/+1
| | | | | | | | | | | src/tools/swarm_client is fetched from tools/swarm_client. TBR=csharp@chromium.org BUG= Review URL: https://codereview.chromium.org/11045023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160016 0039d316-1c4b-4281-b951-d872f2087c98
* Add ScopedPathOverride to the unit test suite.pastarmovj@chromium.org2012-09-271-0/+2
| | | | | | | | | | | | | | | Unit tests have to restore the Overrdies they make because they all live in the same process and not cleaning up their mess means other tests will run against possibly modified profiles. This class allows tests to set up path overrides and clean them up in a convenient way and makes sure the global path map stays clean afterwards. BUG=149161 TEST=unit_tests still pass. Review URL: https://chromiumcodereview.appspot.com/10948010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158951 0039d316-1c4b-4281-b951-d872f2087c98
* Move base Java utils to base/test/android/javatests.nyquist@chromium.org2012-09-241-1/+1
| | | | | | | | | | | | | | | | | | | gyp targets should not depend on tests from other packages, but instead be able to depend on their test utils. The target including the base utilities is called base_java_test_support and contains files from base/test/android/javatests. base_java_test_support was also the name of the wrongly named target for building base/android/javatests, but since only contained util-classes, no new target has been created for tests of base/android/java. BUG=151561,150773 Review URL: https://chromiumcodereview.appspot.com/10974012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158422 0039d316-1c4b-4281-b951-d872f2087c98
* SampleSet -> HistogramSamples which can be reused by SparseHistogramkaiwang@chromium.org2012-09-221-0/+1
| | | | | | | | BUG=139612 Review URL: https://chromiumcodereview.appspot.com/10829466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158166 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Android ninja sdk buildcjhopman@chromium.org2012-09-131-2/+2
| | | | | | | | | | | | For some reason, the way we build jars needs us to specify java_in_dir this way with ninja. BUG= Review URL: https://chromiumcodereview.appspot.com/10908223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156457 0039d316-1c4b-4281-b951-d872f2087c98
* [Android] Upstream org.chromium.base.test.UrlUtils (partially) and device filesmnaganov@chromium.org2012-09-121-1/+1
| | | | | | | | | | Required by android_webview AwSettingsTest BUG=146009 Review URL: https://chromiumcodereview.appspot.com/10911097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156304 0039d316-1c4b-4281-b951-d872f2087c98
* Fix and re-commit http://codereview.chromium.org/10914109/ (after revert in ↵gab@chromium.org2012-09-121-0/+14
| | | | | | | | | | | | | | | | | | | | | | | http://crrev.com/155918) -- Refactoring and tests for the highly undertested file_util::CreateOrUpdateShortcutLink() method. Simplify file_util::CreateOrUpdateShortcutLink()'s interface (use a struct to set parameters passed which allows callers to specify exactly what they want without having to pass in a bunch of NULLs for the unused parameters). The same concept will be used for ShellUtil's shortcut functions in an upcoming CL. Moved ShellUtil::VerifyChromeShortcut() to file_util::VerifyShortcut() and augmented it for every shortcut properties. This will also allow other shortcut creators (web apps, profiles, etc.) to have a broader test coverage on the shortcut they create (i.e. more testable properties available). I will leave it up to the owners of these various projects to augment their tests, this CL keeps the previously tested behavior, not more, not less. This is the 1st CL of a massive refactoring effort for shortcuts (http://goo.gl/Az889) in which ShellUtil's shortcut methods have to be refactored (http://codereview.chromium.org/10836247/ : soon to incorporate interface changes from this CL) which led me even lower to first refactor file_util's shortcut methods. TBR=robertshield@chromium.org, sky@chromium.org, agl@chromium.org, dgrogan@chromium.org BUG=132825, 148539 TEST=base_unittests --gtest_filter=FileUtilShortcutTest* installer_util_unitests --gtest_filter=ShellUtilTestWithDirAndDist* unit_tests --gtest_filter=ProfileShortcutManagerTest* (run tests on XP as well) Review URL: https://chromiumcodereview.appspot.com/10909171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156250 0039d316-1c4b-4281-b951-d872f2087c98
* installer_util_unittests has failed on XP Tests (dbg)(1) since this landeddgrogan@chromium.org2012-09-111-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | Revert 155869 - Refactoring and tests for the highly undertested file_util::CreateOrUpdateShortcutLink() method. Simplify file_util::CreateOrUpdateShortcutLink()'s interface (use a struct to set parameters passed which allows callers to specify exactly what they want without having to pass in a bunch of NULLs for the unused parameters). The same concept will be used for ShellUtil's shortcut functions in an upcoming CL. Moved ShellUtil::VerifyChromeShortcut() to file_util::VerifyShortcut() and augmented it for every shortcut properties. This will also allow other shortcut creators (web apps, profiles, etc.) to have a broader test coverage on the shortcut they create (i.e. more testable properties available). I will leave it up to the owners of these various projects to augment their tests, this CL keeps the previously tested behavior, not more, not less. This is the 1st CL of a massive refactoring effort for shortcuts (http://goo.gl/Az889) in which ShellUtil's shortcut methods have to be refactored (http://codereview.chromium.org/10836247/ : soon to incorporate interface changes from this CL) which led me even lower to first refactor file_util's shortcut methods. BUG=132825 TEST=base_unittests --gtest_filter=FileUtilShortcutTest* installer_util_unitests --gtest_filter=ShellUtilTestWithDirAndDist* unit_tests --gtest_filter=ProfileShortcutManagerTest* Review URL: https://chromiumcodereview.appspot.com/10914109 TBR=gab@chromium.org Review URL: https://chromiumcodereview.appspot.com/10910183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155918 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring and tests for the highly undertested ↵gab@chromium.org2012-09-101-0/+3
| | | | | | | | | | | | | | | | | | | | | | file_util::CreateOrUpdateShortcutLink() method. Simplify file_util::CreateOrUpdateShortcutLink()'s interface (use a struct to set parameters passed which allows callers to specify exactly what they want without having to pass in a bunch of NULLs for the unused parameters). The same concept will be used for ShellUtil's shortcut functions in an upcoming CL. Moved ShellUtil::VerifyChromeShortcut() to file_util::VerifyShortcut() and augmented it for every shortcut properties. This will also allow other shortcut creators (web apps, profiles, etc.) to have a broader test coverage on the shortcut they create (i.e. more testable properties available). I will leave it up to the owners of these various projects to augment their tests, this CL keeps the previously tested behavior, not more, not less. This is the 1st CL of a massive refactoring effort for shortcuts (http://goo.gl/Az889) in which ShellUtil's shortcut methods have to be refactored (http://codereview.chromium.org/10836247/ : soon to incorporate interface changes from this CL) which led me even lower to first refactor file_util's shortcut methods. BUG=132825 TEST=base_unittests --gtest_filter=FileUtilShortcutTest* installer_util_unitests --gtest_filter=ShellUtilTestWithDirAndDist* unit_tests --gtest_filter=ProfileShortcutManagerTest* Review URL: https://chromiumcodereview.appspot.com/10914109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155869 0039d316-1c4b-4281-b951-d872f2087c98
* Remove {base,net}_java dependencies from GYP client targets on Android.pliard@chromium.org2012-09-101-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | On Android, some GYP client targets were explicitly depending on both the native and Java sides of a library. This removes the dependencies to {base,net}_java and make the native side ('base' and 'net) of these libraries depend on their Java counterpart. On Android it rarely makes sense to depend on a single side of a Java/C++ library. The {base,net}_java can now be considered as "private" targets although GYP does not support this concept unfortunately (AFAICT). Note that I made sure that the resulting APKs' size is unchanged. Additionally, this CL removes 'base_java' (i.e. does not replace it with 'base') from the targets including 'build/apk_test.gypi'. This dependency should not have been there (in the wrong layer) in the first place. It's needed by ChromeNativeTestActivity.java which clients should not know about. BUG=146323 TBR=lipalani,sky,willchan,brettw Review URL: https://chromiumcodereview.appspot.com/10913083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155737 0039d316-1c4b-4281-b951-d872f2087c98
* Build test_file_util_mac.cc on iOS.msarda@chromium.org2012-09-051-0/+9
| | | | | | | | | | The file test_file_util_mac.cc was filters out by file name rules on iOS. This CL adds it back to the iOS build. Review URL: https://chromiumcodereview.appspot.com/10919063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154933 0039d316-1c4b-4281-b951-d872f2087c98
* Move base_java_test_support out of gtest_target_type == shared_library' guard.jnd@chromium.org2012-08-311-12/+12
| | | | | | | | | | | "base_java_test_support" is needed by all the java instrumentation tests on Chromium Android. Move it out the 'gtest_target_type == shared_library' gurad and make sure that running 'android_gyp' can pass with or without 'gtest_target_type == shared_library'. BUG=None TEST=running 'android_gyp' passes with 'gtest_target_type == executable' Review URL: https://chromiumcodereview.appspot.com/10874079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154470 0039d316-1c4b-4281-b951-d872f2087c98
* * Rename ScopedStartupInfoEx to StartupInformation.jschuh@chromium.org2012-08-271-1/+1
| | | | | | | | | * Add const accessor for startup_info_ member. * Add has_extended_startup_info check. * Make startup_info_ member explicitly unicode. Review URL: https://chromiumcodereview.appspot.com/10870093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153543 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 18:59:42 +0000