summaryrefslogtreecommitdiffstats
path: root/base/command_line.cc
Commit message (Collapse)AuthorAgeFilesLines
* Allow callers of CommandLine::Init to know whether they were the first caller.erikwright@chromium.org2012-02-271-3/+5
| | | | | | | | | | | | | | | | If there are multiple callers to Init, only one should call Reset. The boolean return value tells the caller whether they are the one responsible for the destruction. As long as the lifetimes of clients are strictly nested (i.e., a client X who uses CommandLine after client Y has initialized it always ceases its use before client Y destroys it) this secures access to this singleton object. One client in particular is updated to follow this model. I will submit follow-up CLs for remaining clients (at least, those who currently do call Reset). This is motivated by a crash in the chrome_frame_net_tests. This test executable nests a TestSuite within the lifetime of a ContentMainRunner (i.e., the engine that is typically used to run Chrome). The content layer initializes CommandLine and Resets it, but the TestSuite also resets it, leading to a DCHECK. This is currently the last remaining issue keeping the chrome_frame_net_tests off the waterfall, and I am very eager to get them back there to reduce the likelihood of further issues being introduced. BUG=114369 TEST=A test has been modified to reflect this change. Review URL: http://codereview.chromium.org/9477001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123763 0039d316-1c4b-4281-b951-d872f2087c98
* Replace most LOG/CHECK statements with DLOG/DCHECK statements in base.brettw@chromium.org2011-10-261-4/+4
| | | | | | | | | | | [ Reland of 107042 http://codereview.chromium.org/8368009 ] I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8341026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107434 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 107042 - Replace most LOG/CHECK statements with DLOG/DCHECK ↵brettw@chromium.org2011-10-251-4/+4
| | | | | | | | | | | | | | statements in base. I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8368009 TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/8351025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107051 0039d316-1c4b-4281-b951-d872f2087c98
* Replace most LOG/CHECK statements with DLOG/DCHECK statements in base.brettw@chromium.org2011-10-251-4/+4
| | | | | | | | | I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8368009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107042 0039d316-1c4b-4281-b951-d872f2087c98
* micro optimize CommandLine.GetSwitchPrefixLengthjoth@chromium.org2011-09-131-1/+1
| | | | | | | | | | | | avoid searching the entire length of each switch for the -- prefix, as we know it can only exist at the start. BUG=None TEST=None Review URL: http://codereview.chromium.org/7866036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100918 0039d316-1c4b-4281-b951-d872f2087c98
* Rename CommandLine::GetCommandLineString().msw@chromium.org2011-07-201-1/+1
| | | | | | | | | | | | Fix string hackery in net/tools/dump_cache/dump_cache.cc Fix const casts in chrome/installer/util/product.cc and base/process_util_win.cc. BUG=73195 TEST=none Review URL: http://codereview.chromium.org/7386002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93165 0039d316-1c4b-4281-b951-d872f2087c98
* Rename CommandLine::GetArgs(), update callers.msw@chromium.org2011-07-131-1/+1
| | | | | | | | | BUG=73195 TEST=none Review URL: http://codereview.chromium.org/7352006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92448 0039d316-1c4b-4281-b951-d872f2087c98
* Nix CommandLine::GetSwitchCount.msw@chromium.org2011-07-131-4/+0
| | | | | | | | | BUG=73195 TEST=none Review URL: http://codereview.chromium.org/7342024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92423 0039d316-1c4b-4281-b951-d872f2087c98
* Base: Don't delete the previous command line when callingrvargas@google.com2011-07-131-1/+7
| | | | | | | | | | | | | | CommandLine::Init() In the multi-DLL build, we can end up initializing the object twice at startup (once in chrome.exe and once in chrome.dll). It should be harmless. BUG=76996 TEST=base_unittests Review URL: http://codereview.chromium.org/7273053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92380 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate most CommandLine code across platforms.msw@chromium.org2011-05-141-250/+167
| | | | | | | | | | | | | | | | | | | | | | Significant refactoring with some notable behavior changes: 1. Switches are appended preceding existing arguments (after other swtiches). 2. (Windows) command_line_string() is generated and properly quoted/escaped. 3. Appended switches will retain their (optional) included prefixes (--,-,/). Notable internal changes (shouldn't affect behavior): 1. (Windows) Generate the cl string, instead of storing&updating the original. 2. Explicitly retain switch prefixes (--,-,/) (was automatic in init*/ctor). Update (obvious) code expecting switches to be appended antecedent to args. Add Nico's test from: codereview.chromium.org/6728016/. An intermediary CL landed between patch set 3 and 4, see: http://codereview.chromium.org/6596020 BUG=73195,67764 TEST=Commandline usage. Review URL: http://codereview.chromium.org/6526040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85360 0039d316-1c4b-4281-b951-d872f2087c98
* iwyu: Cleanup in the following files:jhawkins@chromium.org2011-04-041-7/+2
| | | | | | | | | | | | | | | | | | | | | * at_exit.cc * atomicops.h * base_paths.h * bzip2_error_handler.cc * callback_internal.h * command_line.cc * cpu.cc * environment.h * event_recorder.cc * file_descriptor_shuffle.cc * file_path.cc BUG=none TEST=none Review URL: http://codereview.chromium.org/6759017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80340 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Out-of-line default Commandline ctor and provide dtor.msw@chromium.org2011-03-011-0/+6
| | | | | | | | | BUG=73195 TEST=none Review URL: http://codereview.chromium.org/6588087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76419 0039d316-1c4b-4281-b951-d872f2087c98
* Reorganize CommandLine code.msw@chromium.org2011-03-011-236/+217
| | | | | | | | | | | | The majority of these changes are purely moving code. Conducted some minor (and hopefully straightforward) refactoring. BUG=73195 TEST=none Review URL: http://codereview.chromium.org/6596020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76339 0039d316-1c4b-4281-b951-d872f2087c98
* Register Application Restart with Windows Restart Manager on browser_main ↵msw@chromium.org2011-02-201-56/+75
| | | | | | | | | | | | | startup for Windows Vista / Server 2008 and beyond. This launches Chrome and restores tabs if the computer is restarted as the result of an update. Use GetFunctionPointer/GetProcAddress to avoid XP link and run errors. Make changes to support necessary CommandLine operations. Other minor cleanup and refactoring. BUG=70824 TEST=Reboot from update or ::ExitWindowsEx(EWX_RESTARTAPPS... Chrome should restart and restore tabs on login. Test launching Chrome with a variety of command-line switches and arguments. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75405 Review URL: http://codereview.chromium.org/6462024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75516 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 75405 - Register Application Restart with Windows Restart Manager on ↵msw@chromium.org2011-02-181-75/+56
| | | | | | | | | | | | | | browser_main startup for Windows Vista / Server 2008 and beyond. This launches Chrome and restores tabs if the computer is restarted as the result of an update. Make changes to support necessary CommandLine operations. Other minor cleanup and refactoring. BUG=70824 TEST=Reboot from update or ::ExitWindowsEx(EWX_RESTARTAPPS... Chrome should restart and restore tabs on login. Test launching Chrome with a variety of command-line switches and arguments. Review URL: http://codereview.chromium.org/6462024 TBR=msw@chromium.org Review URL: http://codereview.chromium.org/6538059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75410 0039d316-1c4b-4281-b951-d872f2087c98
* Register Application Restart with Windows Restart Manager on browser_main ↵msw@chromium.org2011-02-181-56/+75
| | | | | | | | | | | startup for Windows Vista / Server 2008 and beyond. This launches Chrome and restores tabs if the computer is restarted as the result of an update. Make changes to support necessary CommandLine operations. Other minor cleanup and refactoring. BUG=70824 TEST=Reboot from update or ::ExitWindowsEx(EWX_RESTARTAPPS... Chrome should restart and restore tabs on login. Test launching Chrome with a variety of command-line switches and arguments. Review URL: http://codereview.chromium.org/6462024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75405 0039d316-1c4b-4281-b951-d872f2087c98
* Move the SetProcTitle code out of base and into chrome/common. This is onlybrettw@chromium.org2010-12-291-62/+8
| | | | | | | | | | | | | | used to support the weird way Chrome manages processes, so doesn't belong in the central CommandLine class. This also provides an empty implementation on Mac & Windows to avoid some ifdefs in the main functions. TEST=everything compiles BUG=none Review URL: http://codereview.chromium.org/6002013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70276 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of std::wstring version of HasSwitch.tfarina@chromium.org2010-12-081-7/+0
| | | | | | | | | BUG=24672 TEST=trybots Review URL: http://codereview.chromium.org/5649003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68650 0039d316-1c4b-4281-b951-d872f2087c98
* Start using file_util symlink code, now that it's available.gspencer@chromium.org2010-12-031-6/+5
| | | | | | | | | | | | In CL http://codereview.chromium.org/5349007 I added some base API for manipulating symlinks (since I needed it for some ChromeOS code and noticed that other places could use it too), and this just starts using that API. BUG=none TEST=Ran ui_tests, passed trybots. Review URL: http://codereview.chromium.org/5286010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68181 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to reland http://codereview.chromium.org/4928002/tommi@chromium.org2010-11-151-3/+16
| | | | | | | | | | | | | | | | | | | | | | | | For some reason the Win bot failed to compile the sandbox unit test. Trybots and my machines don't have these build problems, so I'm going to try again, unchanged. Original description: Changing the installer switches from wchar_t[] to char[]. Because of this I'm also refactoring some code that before was using wstring to build command lines by hand instead of using the CommandLine class. Now we use CommandLine. To get this to work correctly, I also needed to fix CommandLine::AppendArguments so I added a little test for it. TEST=There should be no changes in functionality. Run all installer tests. BUG=61609 TBR=robertshield Review URL: http://codereview.chromium.org/4989001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66096 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 66088 - Changing the installer switches from wchar_t[] to char[].tommi@chromium.org2010-11-151-16/+3
| | | | | | | | | | | | | | | | | | Because of this I'm also refactoring some code that before was using wstring to build command lines by hand instead of using the CommandLine class. Now we use CommandLine. To get this to work correctly, I also needed to fix CommandLine::AppendArguments so I added a little test for it. TEST=There should be no changes in functionality. Run all installer tests. BUG=61609 Review URL: http://codereview.chromium.org/4928002 TBR=tommi@chromium.org Review URL: http://codereview.chromium.org/4988001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66089 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the installer switches from wchar_t[] to char[].tommi@chromium.org2010-11-141-3/+16
| | | | | | | | | | | | | | | Because of this I'm also refactoring some code that before was using wstring to build command lines by hand instead of using the CommandLine class. Now we use CommandLine. To get this to work correctly, I also needed to fix CommandLine::AppendArguments so I added a little test for it. TEST=There should be no changes in functionality. Run all installer tests. BUG=61609 Review URL: http://codereview.chromium.org/4928002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66088 0039d316-1c4b-4281-b951-d872f2087c98
* Bring up IPC in NaCl.abarth@chromium.org2010-11-121-1/+1
| | | | | | | | | | | | This patch gets a bunch of the IPC and Base libraries compiling (but not linking) in NaCl. There's obviously a bunch more work to do, but this patch is a starting point. Original patch by Eric Seidel. Review URL: http://codereview.chromium.org/4812002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65920 0039d316-1c4b-4281-b951-d872f2087c98
* Rename CommandLine::ARGUMENTS_ONLY to NO_PROGRAM.mattm@chromium.org2010-10-211-2/+2
| | | | | | | | | | | ARGUMENTS_ONLY was misleading since CommandLine has methods for handling "switches" and "arguments", but that constructor still allows both. BUG=none TEST=still builds Review URL: http://codereview.chromium.org/3935001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63325 0039d316-1c4b-4281-b951-d872f2087c98
* CommandLine: remove wstring-based program() accessorevan@chromium.org2010-10-141-6/+0
| | | | | | | | | | | | | | This was already removed on non-Windows, so this change modifies the remaining Windows-specific usage. In a few places I converted use of wstring paths into FilePath, but in general for Windows-specific code I don't think it's too important to use FilePath everywhere, because it is equivalent on Windows and the current code already works. BUG=23581 Review URL: http://codereview.chromium.org/3817001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62637 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move SplitString functions into the base namespace and update the callers.tfarina@chromium.org2010-10-141-2/+2
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3750001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62483 0039d316-1c4b-4281-b951-d872f2087c98
* CommandLine: deprecate another function on non-Windowsevan@chromium.org2010-10-081-6/+6
| | | | | | | | | BUG=23581 TEST=CommandLine unit tests Review URL: http://codereview.chromium.org/3549023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61889 0039d316-1c4b-4281-b951-d872f2087c98
* CommandLine: remove deprecated wstring APIevan@chromium.org2010-10-071-18/+10
| | | | | | | | | | | | (o3d still uses an older version of base; if they update past this change they will need to apply the change I reverted in r55433.) BUG=23581 TEST=compiles, existing tests still pass Review URL: http://codereview.chromium.org/3552011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61839 0039d316-1c4b-4281-b951-d872f2087c98
* base: Finish moving the SplitString functions from string_util.h to ↵tfarina@chromium.org2010-09-241-0/+1
| | | | | | | | | | | string_split.h BUG=None TEST=trybos Review URL: http://codereview.chromium.org/3447008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60422 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move some heavy, repeatedly emitted symbols to implementation files.erg@google.com2010-08-301-0/+12
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3162047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57896 0039d316-1c4b-4281-b951-d872f2087c98
* CommandLine: eliminate wstring-accepting AppendLooseValueevan@chromium.org2010-08-131-6/+18
| | | | | | | | Instead use AppendArg variants which accept a FilePath or an ASCII string. Review URL: http://codereview.chromium.org/3134008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56100 0039d316-1c4b-4281-b951-d872f2087c98
* CommandLine: remove three useless functions.evan@chromium.org2010-08-121-34/+10
| | | | | | | | | | | | | PrefixedSwitchString was full of encoding conversions, but there was only one real caller, and the function is trivial. Terminate is leftover cruft. TEST=compiles Review URL: http://codereview.chromium.org/3138001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55931 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out command-line quoting code on Windows.evan@chromium.org2010-08-101-16/+49
| | | | | | | | | | | | | | | | | | Our command line code is not very good with respect to getting quoting right. Because of this, callers will sometimes themselves attempt to quote arguments, though some of them get it wrong(!) by just surrounding with quotes. The first step is to add a quoting function that we think is correct and update the unit test to test it. (Note that most of this is Windows-specific, because on POSIX we can pass arguments to commands as a vector -- trying to do quoting on POSIX is usually wrong.) Review URL: http://codereview.chromium.org/3007038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55591 0039d316-1c4b-4281-b951-d872f2087c98
* CommandLine: Deprecate a function on non-Windows.evan@chromium.org2010-08-091-0/+3
| | | | | | | | | | Merge deprecated functions together. TEST=compiles Review URL: http://codereview.chromium.org/3029068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55460 0039d316-1c4b-4281-b951-d872f2087c98
* PrependWrapper is platform-specific, so it should take a platform string.evan@chromium.org2010-08-041-2/+3
| | | | | | | | | Though the comments said it was POSIX only, I see it used on Windows as well so I'm updating the comment. Review URL: http://codereview.chromium.org/3030043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54933 0039d316-1c4b-4281-b951-d872f2087c98
* Move ASCIIToWide and ASCIIToUTF16 to utf_string_conversions.h. I've found itbrettw@chromium.org2010-07-311-1/+1
| | | | | | | | | | | | | | | | | | | | | | | weird that UTF8ToWide is in utf_string_conversions, but ASCIIToWide is in string_util.h. This should help some dependencies since string_util changes much more frequently than utf_string_conversions and fewer files will now need string_utils. Since this requires a lot of changes, this keeps a forward-declaration in string_util so I can update the entire project incrementally. This change updates base and net only. I removed some includes of string_util from header files in net. In particular, url_request_context which involved creating a new .cc file to implement a function (already virtual so there's no speed penalty). It turns out a lot of files were getting string_util from this include, so I had to update a bunch of random files to now explicitly include string_util.h TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3076013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54456 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated CommandLine API.evan@chromium.org2010-07-301-12/+0
| | | | | | | | | Cleaned up the final few callers, punting the remaining harder ones to TODOs. Review URL: http://codereview.chromium.org/3043033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54400 0039d316-1c4b-4281-b951-d872f2087c98
* Add an AppendSwitchASCII to CommandLine, and convert a test to it.evan@chromium.org2010-07-301-5/+10
| | | | | | | | | | | I'm removing all the AppendSwitchWithValue() users due to wstrings, and this is one caller. Since fixing this one caller requires touching many files, I thought I'd isolate this change from the other WithValue->ASCII conversions. Review URL: http://codereview.chromium.org/2878065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54257 0039d316-1c4b-4281-b951-d872f2087c98
* CommandLine: add a CopySwitchesFrom() and AppendSwitchPath()evan@chromium.org2010-07-291-10/+44
| | | | | | | | | | | These are two common patterns in Chrome code: copying a subset of switches from one CommandLine to another, and appending a FilePath to a CommandLine. This sets me up to do a lot more deprecation in a follow-up change. Review URL: http://codereview.chromium.org/3012021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54218 0039d316-1c4b-4281-b951-d872f2087c98
* base/ header cleanup. Forward declaration instead of including.erg@google.com2010-07-281-0/+43
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3068004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53969 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated CommandLine::GetLooseValues(), rename to args().evan@chromium.org2010-07-211-14/+5
| | | | | | | | | | | | | | | It returned a wstring, when really we wanted the native encoded strings. Fixing the majority of callers actually simplified them in many cases because the callers wanted native strings too. Since I'm touching every caller, I gave it a more useful name. I'm not sure where "loose" came from but it never made sense to me. BUG=24672 Review URL: http://codereview.chromium.org/3028010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53193 0039d316-1c4b-4281-b951-d872f2087c98
* Move implementation from header to source.erg@chromium.org2010-07-151-0/+7
| | | | | | | | | | | | | | | | | | | | This is an effort to speed up compile and link time, and also minimizing the size of the intermediary .o files on disk. For example, just moving the constructor/destructor from the classes in chrome/browser/pref_member.{cc,h} netted a 368k drop in total .o file size. In aggregate, this shrinks libbrowser.a by 10 megabytes, and a few odd megabytes on most other chrome .a files. A lot of this was done before I started harvesting what the most included symbols were across all of chrome's code. Most of them are in webkit, but there's plenty in base/ that are used everywhere to keep me busy for several patches to come. BUG=none TEST=none Review URL: http://codereview.chromium.org/3012001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52528 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a TODO in data export of net-internals, added Chrome version and ↵maruel@chromium.org2010-05-211-0/+5
| | | | | | | | | | | | | command line. BUG=none TEST=Go to about:net-internals click on dump to text, check if version and command line are good. Patch contributed by malavv Review URL: http://codereview.chromium.org/2104012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47926 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Replace deprecated CommandLine::program() with ↵thestig@chromium.org2010-05-031-4/+3
| | | | | | | | | | | | | CommandLine::GetProgram(). Simplify a couple DCHECKs with DCHECK_EQ. Committing for Shriram Kunchanapalli (kshriram18@gmail.com) Original code review: http://codereview.chromium.org/413003/show BUG=none TEST=none Review URL: http://codereview.chromium.org/1733010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46281 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes CommandLine::AppendLooseValue() to append the parameter to the ↵jschuh@chromium.org2010-01-111-0/+1
| | | | | | | | | | | loose_values_ vector. BUG=None. TEST=None. Review URL: http://codereview.chromium.org/536012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35970 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35907 - Fixes CommandLine::AppendLooseValue() to append the parameter ↵jschuh@chromium.org2010-01-111-1/+0
| | | | | | | | to the loose_values_ vector. TBR=jschuh@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35913 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes CommandLine::AppendLooseValue() to append the parameter to the ↵jschuh@chromium.org2010-01-111-0/+1
| | | | | | loose_values_ vector. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35907 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: use readlink() and prctl() in SetProcTitle() to fix "exe" showing in ↵mdm@chromium.org2010-01-031-2/+34
| | | | | | | | | | | process listings. BUG=29118 TEST=none Review URL: http://codereview.chromium.org/490028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35441 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to base/ from a combination of FreeBSD and OpenBSD patches.evan@chromium.org2009-12-291-1/+1
| | | | | | Review URL: http://codereview.chromium.org/495002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35321 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-27 11:25:53 +0000