summaryrefslogtreecommitdiffstats
path: root/base/debug/trace_event.h
Commit message (Collapse)AuthorAgeFilesLines
* Add ASYNC_STEP support to trace_event and change START to ASYNC_BEGIN.jbates@chromium.org2012-03-011-44/+73
| | | | | | | | | BUG=116095 Review URL: http://codereview.chromium.org/9522010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124348 0039d316-1c4b-4281-b951-d872f2087c98
* Implement proper atomic code for trace macros.jbates@chromium.org2012-02-221-10/+15
| | | | | | | | | | | | | | This is not meant to prevent races on what is pointed to by the uint8*. Instead, it is meant to prevent the compiler from assuming that consecutive loads of the uint8 will be the same value. This prevents the scenario described in Clarification 4: http://code.google.com/p/data-race-test/wiki/AboutRaces#Objection_4 R=dvyukov BUG=98417,115107 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=122552 Review URL: http://codereview.chromium.org/9416044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122949 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r122552: "Implement proper atomic code for trace macros."rnk@chromium.org2012-02-211-15/+10
| | | | | | | | | | | | | | | | | | The tsan bots have been red since this change, and crashing on WorkerPoolTest.PostTask in base. I've been unable to reproduce the failure from the bots locally, so I'm reverting this and we'll see what happens on the bots. Unfortunately we don't have a win_tsan try bot, or I'd say reapply once you get a green run from that. TBR=jbates@chromium.org BUG=115107 TEST=base_unittests.exe Review URL: https://chromiumcodereview.appspot.com/9430018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122881 0039d316-1c4b-4281-b951-d872f2087c98
* Implement proper atomic code for trace macros.jbates@chromium.org2012-02-171-10/+15
| | | | | | | | | | | | This is not meant to prevent races on what is pointed to by the uint8*. Instead, it is meant to prevent the compiler from assuming that consecutive loads of the uint8 will be the same value. This prevents the scenario described in Clarification 4: http://code.google.com/p/data-race-test/wiki/AboutRaces#Objection_4 R=dvyukov BUG=98417 Review URL: http://codereview.chromium.org/9416044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122552 0039d316-1c4b-4281-b951-d872f2087c98
* Remove pointer mangling API from trace_event.h and use an addTraceEvent flag ↵jbates@chromium.org2012-01-271-40/+48
| | | | | | | | | | instead BUG=109779 Review URL: https://chromiumcodereview.appspot.com/9223005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119519 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup trace_event, fix webkit API naming.jbates@chromium.org2012-01-251-14/+14
| | | | | | | | Remove unused TRACE_EVENT_API_ADD_COUNTER_EVENT and improve comments in trace_event.h. Review URL: http://codereview.chromium.org/9234007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118999 0039d316-1c4b-4281-b951-d872f2087c98
* Split up trace_event.h into trace_event_impl.h and add webkitplatform support.jbates@chromium.org2012-01-231-385/+79
| | | | | | | | | | No new features here, this is just a code split and API glue. (Good news! I copied over trace_event.h to WebKit and verified that this all works!) Review URL: https://chromiumcodereview.appspot.com/9213013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118733 0039d316-1c4b-4281-b951-d872f2087c98
* Allow tracing in third_party librariesjbates@chromium.org2012-01-131-311/+404
| | | | | | | | | | | | | | | | This is step 1 -- refactor the code to allow us to split up trace_event.h into trace_event.h and trace_event_export.h/cc. Step 2 is to cut out trace_event_export.h/cc. The _export.h/cc will be laid out so they can be copied to other third_party libraries and then tweaked to call through to chromium's internal tracing API via platform APIs or function pointers. To make these APIs easily exportable, this change primarily aims to eliminate the custom objects (ie: TraceValue) and types that will cause problems when defined in multiple libraries. The macros and internal namespace are destined for trace_event_export.h/cc in a future CL. BUG=109779 Review URL: http://codereview.chromium.org/9155024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117598 0039d316-1c4b-4281-b951-d872f2087c98
* Retry 114494 - Remove BindStateHolder and have Bind() return a Callback<> ↵ajwong@chromium.org2011-12-201-2/+3
| | | | | | | | | | | | | | | object directly." This removes some complexity and also fixes a bug where if you call Bind() with the result of Bind(), the resulting Callback would only be valid during the first call. Ouch. Also makes the static type checking a bit more strict when assigning into a Callback<>. BUG=none TEST=new unittests Review URL: http://codereview.chromium.org/8915024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115045 0039d316-1c4b-4281-b951-d872f2087c98
* Push a marker into Android's kernel trace system to allow clock sync in ↵nduca@chromium.org2011-12-161-1/+2
| | | | | | | | about:tracing Review URL: http://codereview.chromium.org/8947006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114756 0039d316-1c4b-4281-b951-d872f2087c98
* Add event counters with IDspiman@chromium.org2011-12-161-4/+43
| | | | | | | | | | BUG=None TEST=about:tracing Review URL: http://codereview.chromium.org/8953009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114739 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 114494 - Remove BindStateHolder and have Bind() return a Callback<> ↵sail@chromium.org2011-12-141-3/+2
| | | | | | | | | | | | | | | | | object directly. This removes some complexity and also fixes a bug where if you call Bind() with the result of Bind(), the resulting Callback would only be valid during the first call. Ouch. BUG=none TEST=new unittests Review URL: http://codereview.chromium.org/8738001 TBR=ajwong@chromium.org Review URL: http://codereview.chromium.org/8914022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114495 0039d316-1c4b-4281-b951-d872f2087c98
* Remove BindStateHolder and have Bind() return a Callback<> object directly.ajwong@chromium.org2011-12-141-2/+3
| | | | | | | | | | | | This removes some complexity and also fixes a bug where if you call Bind() with the result of Bind(), the resulting Callback would only be valid during the first call. Ouch. BUG=none TEST=new unittests Review URL: http://codereview.chromium.org/8738001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114494 0039d316-1c4b-4281-b951-d872f2087c98
* Improve GPU tests to fail when GPU drawing fails.jbates@chromium.org2011-12-021-0/+13
| | | | | | | | | | | Changed the accelerated html pages to use raf to draw multiple frames. Changed the webgl and canvas2d pages to draw onscreen rather than offscreen to make sure the compositor draws the page. BUG=105785,104142 Review URL: http://codereview.chromium.org/8692013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112763 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Aura build break.jbates@chromium.org2011-12-021-1/+1
| | | | | | | | TBR=avi Review URL: http://codereview.chromium.org/8772049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112727 0039d316-1c4b-4281-b951-d872f2087c98
* trace_event: distinguish between scoped begin/end and global start/finish eventsjbates@chromium.org2011-12-021-52/+187
| | | | | | | | BUG=100131 Review URL: http://codereview.chromium.org/8590015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112722 0039d316-1c4b-4281-b951-d872f2087c98
* Implement TRACE_COUNTERnduca@chromium.org2011-11-181-2/+70
| | | | | | Review URL: http://codereview.chromium.org/8579001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110675 0039d316-1c4b-4281-b951-d872f2087c98
* Support thread name changes in trace eventjoth@chromium.org2011-11-101-1/+4
| | | | | | | | | | | | | This is needed for trace names to appear correctly on startup traces, as early threads start tracing before their name is set. The thread local boolean was previously defeating the logic to detect name changes (the code was inaccessible), and we'd just permanently record early threads as having no name. BUG=None TEST=--trace-startup results in correct names in traces Review URL: http://codereview.chromium.org/8470001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109439 0039d316-1c4b-4281-b951-d872f2087c98
* Support --trace-startup and task tracingjoth@chromium.org2011-11-091-0/+16
| | | | | | | | | | | | | passing --trace-startup puts the tracing system into record mode immediately saving the result to chrometrace.log or a file specified by --trace-startup-file BUG=None TEST=start chrome with --trace-startup, wait 5 secs, see chrometrace.log in current dir. open it in chrome://tracing/ Review URL: http://codereview.chromium.org/7887013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109281 0039d316-1c4b-4281-b951-d872f2087c98
* Remove 1 exit time destructor and 1 static initializer in trace_event.thakis@chromium.org2011-11-031-1/+1
| | | | | | | | | | | | Also remove USE_UNRELIABLE_NOW. BUG=101600,94925 TEST=none Review URL: http://codereview.chromium.org/8363056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108552 0039d316-1c4b-4281-b951-d872f2087c98
* add classes trace_analyzer::Query and TraceAnalyzer to improve testing (retry)jbates@chromium.org2011-10-291-2/+10
| | | | | | | | | | | http://codereview.chromium.org/7981004/ BUG=95714 TEST=base_unittests Review URL: http://codereview.chromium.org/8418044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107861 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 107813 - add classes trace_analyzer::Query and TraceAnalyzer to make ↵jbates@chromium.org2011-10-291-10/+2
| | | | | | | | | | | | | | | | it easy to search through trace data. This also adds a trace_analyzer::TraceEvent class that can be constructed from JSON data (via base::Value). TraceEvent mirrors base::debug::TraceEvent in a form that is lower performance and easier to use in test code. BUG=95714 TEST=base_unittests Review URL: http://codereview.chromium.org/7981004 TBR=jbates@chromium.org Review URL: http://codereview.chromium.org/8413063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107845 0039d316-1c4b-4281-b951-d872f2087c98
* add classes trace_analyzer::Query and TraceAnalyzer to make it easy to ↵jbates@chromium.org2011-10-281-2/+10
| | | | | | | | | | | | | search through trace data. This also adds a trace_analyzer::TraceEvent class that can be constructed from JSON data (via base::Value). TraceEvent mirrors base::debug::TraceEvent in a form that is lower performance and easier to use in test code. BUG=95714 TEST=base_unittests Review URL: http://codereview.chromium.org/7981004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107813 0039d316-1c4b-4281-b951-d872f2087c98
* Internalize JSON chunk merging to trace_event.h API (retry).jbates@chromium.org2011-10-241-1/+47
| | | | | | | | | | | Original review: http://codereview.chromium.org/8355024/ BUG=100291 TEST=base_unittests, content_unittests Review URL: http://codereview.chromium.org/8373018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106924 0039d316-1c4b-4281-b951-d872f2087c98
* Revert: Internalize JSON chunk merging to trace_event.h API.mpcomplete@chromium.org2011-10-221-47/+1
| | | | | | | | | | | BUG=100291 TEST=base_unittests, content_unittests Review URL: http://codereview.chromium.org/8355024 Review URL: http://codereview.chromium.org/8369021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106812 0039d316-1c4b-4281-b951-d872f2087c98
* Internalize JSON chunk merging to trace_event.h API.jbates@chromium.org2011-10-211-1/+47
| | | | | | | | | BUG=100291 TEST=base_unittests, content_unittests Review URL: http://codereview.chromium.org/8355024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106808 0039d316-1c4b-4281-b951-d872f2087c98
* Add trace code to track all posted tasks in message_loop and WorkerThreads ↵jbates@chromium.org2011-10-031-105/+124
| | | | | | | | | | | | (non-official builds only). It's very helpful to understand what chrome is doing at runtime. Sometimes a thread in chrome does something expensive that causes a frame hitch. With this change, any expensive task will show up clearly in traces, with the file/function of where the task was posted. TEST=go to about:tracing, run a trace and notice that all tasks are traced. Review URL: http://codereview.chromium.org/7778033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103740 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for filtering traces by categories. The TraceLog API is updated ↵jbates@chromium.org2011-09-121-3/+19
| | | | | | | | | | | to support included and excluded categories. This API is then plumbed through to the TraceController so that it can be used across all processes. BUG=96122 TEST=base_unittests Review URL: http://codereview.chromium.org/7867013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100777 0039d316-1c4b-4281-b951-d872f2087c98
* Added support to trace_event for passing static string arguments without copyjbates@chromium.org2011-09-061-25/+94
| | | | | | | | | | Occasionally you want to add some static string to a trace, such as the __FILE__ string, but don't want the overhead of a allocation/copy. This change let's you specify those as argument values via a new TraceValue type. You specify const char* types to get the no-copy behavior. std::string types are always copied. To force a const char*, specify TRACE_STR_COPY(str). TEST=trace_event_unittest.cc Review URL: http://codereview.chromium.org/7767014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99763 0039d316-1c4b-4281-b951-d872f2087c98
* Implement backend for thread names and process names.nduca@chromium.org2011-08-091-1/+6
| | | | | | | | | | | | | | | | | Added a new trace event phase 'M'/TRACE_EVENT_PHASE_METADATA, which can become a general mechanism for adding metadata to traces. The two M-type events that we then add are: {ph=M pid=<pid> name="process_name" args={ name="name of pid" }} {ph=M pid=<pid> tid=<tid> name="thread_name" args={ name="name of tid" }} base::thread is instrumented to set names automatically. I will do a followon changelist to add instrumentation to Chrome for its various processes and threads. Review URL: http://codereview.chromium.org/7495031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95997 0039d316-1c4b-4281-b951-d872f2087c98
* Rename BASE_API to BASE_EXPORT.darin@chromium.org2011-08-051-4/+4
| | | | | | | R=rvargas Review URL: http://codereview.chromium.org/7461141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95618 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land r93365 - add RefCountedStringjoth@chromium.org2011-07-221-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added RefCountedString, as this is what many RefCountedMemory users seem to want Made data member of RefCountedBytes private, as per style guide Changed base64 APIs to accept StringPiece, as it's sometimes better and never worse than string. Fix chromeos build; additional files updated comapred to previous patch: chrome/browser/ui/login/login_prompt_ui.cc chrome/browser/ui/webui/active_downloads_ui.cc chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.cc chrome/browser/ui/webui/chromeos/enterprise_enrollment_ui.cc chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc chrome/browser/ui/webui/chromeos/login/login_ui.cc chrome/browser/ui/webui/chromeos/login/login_ui_helpers.cc chrome/browser/ui/webui/chromeos/login/login_ui_helpers.h chrome/browser/ui/webui/chromeos/login/mock_login_ui_helpers.h chrome/browser/ui/webui/chromeos/login/oobe_ui.cc chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc chrome/browser/ui/webui/chromeos/register_page_ui.cc chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc chrome/browser/ui/webui/chromeos/system_info_ui.cc chrome/browser/ui/webui/collected_cookies_ui_delegate.cc BUG=None TEST=All existing tests pass. Extended ref_counted_memory_unittests Review URL: http://codereview.chromium.org/7397021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93617 0039d316-1c4b-4281-b951-d872f2087c98
* Allow trace event to work with temporary name strings.joth@chromium.org2011-07-211-27/+68
| | | | | | | | | | | | This is needed where the name or arg_names may not be available as compile time constants. BUG=None TEST=base_unittests --gtest_filter=TraceEvent* Review URL: http://codereview.chromium.org/7354025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93375 0039d316-1c4b-4281-b951-d872f2087c98
* Add COMPILE_ASSERT to ensure the result of Bind matches the Callback's type.ajwong@chromium.org2011-06-261-1/+1
| | | | | | | | | | | | | | Required because we abstract the storage of the funciton pointer out using a reinterpret_cast to reduce template bloat. This effectively readds the failure that would have happened had we stored the function pointer directly in the template class. BUG=86008 TEST=new unittests. Review URL: http://codereview.chromium.org/7241015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90525 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented threshold based trace events that only get added to the trace if ↵jbates@chromium.org2011-05-131-126/+190
| | | | | | | | | | | | | | | | | the elapsed time between begin and end is greater than a specified time. In order to reduce macro code duplication, created some additional internal helper macros. Improved performance on the critical trace-disabled code path by deferring some member initialization. Removed the unused __LINE__/__FILE__ data. Prefixed internal macros with "INTERNAL_" so that users ignore them. Moved all the internal macros below so that the user sees the relevant macros first. BUG=81565 TEST=base_unittests Review URL: http://codereview.chromium.org/7016012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85349 0039d316-1c4b-4281-b951-d872f2087c98
* Nits fix on trace_event.h and child_trace_message_filter.ccscheib@chromium.org2011-05-101-1/+1
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/7004011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84893 0039d316-1c4b-4281-b951-d872f2087c98
* Merge gpu_trace_event back into base/debug/trace_event.scheib@chromium.org2011-05-101-107/+451
| | | | | | | | | | | | | | | | | | | | | | | Initial land attempt at http://codereview.chromium.org/6551019/ gpu_trace_event fork at http://codereview.chromium.org/6691013 - gpu_trace_event renamed to base/debug/trace_event and modified as appropriate for base::debug - Unit Tests implemented for trace_event - gpu_common library removed (was added only for gpu_trace_event) - Existing calls to trace_event suffixed with _ETW to make ETW calls (see decisions and incremental plans at end of 6551019) - GPU trace calls renamed to new calls. - Tracing switch removed from test_shell, as linux log file support removed. BUG=79509 TEST=trace_event_win_unittest and about:gpu Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84284 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84486 Review URL: http://codereview.chromium.org/6862002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84739 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 84486 - Merge gpu_trace_event back into ↵scheib@chromium.org2011-05-061-401/+107
| | | | | | | | | base/debug/trace_event.Initial land attempt at http://codereview.chromium.org/6551019/gpu_trace_event fork at http://codereview.chromium.org/6691013- gpu_trace_event renamed to base/debug/trace_event and modified as appropriate for base::debug- Unit Tests implemented for trace_event- gpu_common library removed (was added only for gpu_trace_event)- Existing calls to trace_event suffixed with _ETW to make ETW calls (see decisions and incremental plans at end of 6551019)- GPU trace calls renamed to new calls.- Tracing switch removed from test_shell, as linux log file support removed.BUG=79509TEST=trace_event_win_unittest and about:gpuCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=84284Review URL: http://codereview.chromium.org/6862002 TBR=scheib@chromium.org Review URL: http://codereview.chromium.org/6955006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84494 0039d316-1c4b-4281-b951-d872f2087c98
* Merge gpu_trace_event back into base/debug/trace_event.scheib@chromium.org2011-05-061-107/+401
| | | | | | | | | | | | | | | | | | | | | Initial land attempt at http://codereview.chromium.org/6551019/ gpu_trace_event fork at http://codereview.chromium.org/6691013 - gpu_trace_event renamed to base/debug/trace_event and modified as appropriate for base::debug - Unit Tests implemented for trace_event - gpu_common library removed (was added only for gpu_trace_event) - Existing calls to trace_event suffixed with _ETW to make ETW calls (see decisions and incremental plans at end of 6551019) - GPU trace calls renamed to new calls. - Tracing switch removed from test_shell, as linux log file support removed. BUG=79509 TEST=trace_event_win_unittest and about:gpu Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84284 Review URL: http://codereview.chromium.org/6862002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84486 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 84284 - Merge gpu_trace_event back into ↵scheib@chromium.org2011-05-051-406/+107
| | | | | | | | | base/debug/trace_event.Initial land attempt at http://codereview.chromium.org/6551019/gpu_trace_event fork at http://codereview.chromium.org/6691013- gpu_trace_event renamed to base/debug/trace_event and modified as appropriate for base::debug- Unit Tests implemented for trace_event- gpu_common library removed (was added only for gpu_trace_event)- Existing calls to trace_event suffixed with _ETW to make ETW calls (see decisions and incremental plans at end of 6551019)- GPU trace calls renamed to new calls.- Tracing switch removed from test_shell, as linux log file support removed.BUG=79509TEST=trace_event_win_unittest and about:gpuReview URL: http://codereview.chromium.org/6862002 TBR=scheib@chromium.org Review URL: http://codereview.chromium.org/6933035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84293 0039d316-1c4b-4281-b951-d872f2087c98
* Merge gpu_trace_event back into base/debug/trace_event.scheib@chromium.org2011-05-051-107/+406
| | | | | | | | | | | | | | | | | | | Initial land attempt at http://codereview.chromium.org/6551019/ gpu_trace_event fork at http://codereview.chromium.org/6691013 - gpu_trace_event renamed to base/debug/trace_event and modified as appropriate for base::debug - Unit Tests implemented for trace_event - gpu_common library removed (was added only for gpu_trace_event) - Existing calls to trace_event suffixed with _ETW to make ETW calls (see decisions and incremental plans at end of 6551019) - GPU trace calls renamed to new calls. - Tracing switch removed from test_shell, as linux log file support removed. BUG=79509 TEST=trace_event_win_unittest and about:gpu Review URL: http://codereview.chromium.org/6862002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84284 0039d316-1c4b-4281-b951-d872f2087c98
* linux: components buildevan@chromium.org2011-05-021-1/+1
| | | | | | | | Reapply r83630, r83629, r83583, and fix the one compile error. TBR=rvargas git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83740 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 83630 - linux components: expose one last function from base needed ↵maf@chromium.org2011-04-301-1/+1
| | | | | | | | | | | by test_shell Review URL: http://codereview.chromium.org/6883279 TBR=evan@chromium.org Review URL: http://codereview.chromium.org/6902182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83636 0039d316-1c4b-4281-b951-d872f2087c98
* linux components: expose one last function from base needed by test_shellevan@chromium.org2011-04-291-1/+1
| | | | | | Review URL: http://codereview.chromium.org/6883279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83630 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete base/lock.h and fix up callers to use the new header file andbrettw@chromium.org2011-01-211-2/+2
| | | | | | | | | | | the base namespace. Fix several files including lock.h unnecessarily. BUG=none TEST=none Original review=http://codereview.chromium.org/6142009/ Patch by leviw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
* This CL add a GetInstance() method to singleton classes instead of relying ↵satish@chromium.org2010-12-041-3/+5
| | | | | | | | | | | | | | | | | on the callers to use Singleton<T>. In some cases I have used the LazyInstance<T> pattern as that was simpler. This is a small step towards making all singleton classes use the Singleton<T> pattern within their code and not expect the callers to know about it. I have selected all files under src/app and src/base which use Singleton<T> in this CL. Once this CL goes in I'll work on the rest of the files. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5527004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68300 0039d316-1c4b-4281-b951-d872f2087c98
* Move debug-related stuff from base to the base/debug directory and use thebrettw@chromium.org2010-10-261-0/+147
base::debug namespace. This splits apart debug_util into base/debugger and base/stack_trace There are still two functions in debug_util that I'm not sure what to do with. Since this uses the base::debug namespace, I removed the functions in debugger.h from the static class and just made them free functions in the namespace. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3945002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63859 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 09:47:19 +0000