| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The deadlock occurs because we hold lock when posting flush tasks.
If MessageLoop::PostTask() also calls TRACE_EVENT and the TRACE_EVENT
has never been reached before, the TRACE_EVENT will try to get the
category enabled flag which will also need a lock.
Copy thread_message_loops into a temporary vector of
scoped_refptr<SingleProcessTaskRunner> to avoid lock when calling
PostTask().
BUG=397022
TEST=Existing tests and ThreadSanitizer
Review URL: https://codereview.chromium.org/491393002
Cr-Commit-Position: refs/heads/master@{#293144}
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the rewrite_scoped_refptr clang tool
on a Linux build.
BUG=110610
Review URL: https://codereview.chromium.org/510563002
Cr-Commit-Position: refs/heads/master@{#292050}
|
|
|
|
|
|
|
|
|
|
| |
BUG=302040
TBR=noelallen@chromium.org
Review URL: https://codereview.chromium.org/357623003
Cr-Commit-Position: refs/heads/master@{#291168}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The MessageLoop has some code for adding debug annotations such as trace
flows and memory usage tags to posted tasks. Since we want to use these
annotations more generally for tasks that are scheduled outside the base
message loop, this patch factors it out into a standalone class.
TEST=TaskAnnotatorTest
BUG=391005
Review URL: https://codereview.chromium.org/455833004
Cr-Commit-Position: refs/heads/master@{#289560}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This updates the includes in base but leaves a forwarding header for the rest of the project for now.
R=yzshen@chromium.org
Review URL: https://codereview.chromium.org/468253002
Cr-Commit-Position: refs/heads/master@{#289360}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
SetFromString that allows setting TraceOptions from a string instead.
SetFromString returns true upon success.
BUG=400382
Review URL: https://codereview.chromium.org/443523003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With current implementation of devtool_tracing_handler, it doesn't do
anything with invalid options and just use RECORD_UNTIL_FULL by default. So
the change to telemetry's tracing backend will not break backward
compatibility for browsers that don't support "record-as-much-as-possible" option.
However, this is a hacky way to maintain backward compatibility, and we
should fix devtool_tracing_handler so it can respond with error message on
Tracing.start if there is options parsing error.
BUG=396081
Review URL: https://codereview.chromium.org/440903003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This vector is now used to store all config lists. Previously the code did a bunch of work to uniquify configs at certain points (in target.cc) but direct_dependent_configs still ended up with lots of duplicates.
Before this patch the chrome/browser target has 41098 direct_dependent_configs, and after this patch it has 7. Apparently we were also spending a lot of time on these. Before this patch Windows wall clock time was 1031ms, and after this patch it's 831ms. Linux was 834ms before and 593ms after.
Also fix minor build issues in base I noticed while working on this.
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/26537002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=396403
Review URL: https://codereview.chromium.org/432473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test breaks on iOS Simulation.
Introduced by https://codereview.chromium.org/425593002
BUG=400382
TBR=nednguyen
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287361
Review URL: https://codereview.chromium.org/438043003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test breaks on iOS Simulation.
Introduced by https://codereview.chromium.org/425593002
BUG=400382
TBR=nednguyen
Review URL: https://codereview.chromium.org/438043003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, the options for tracing were passed around with different ad hoc
systems. Strings in some places, base::debug::TraceOptions enum in others,
and a content::TraceOptions in yet another. There were two separate ad-hoc
string formats. Similar messes were present with category filters: sometimes
we passed strings, sometimes the CategoryFilter.
This patch though enormous looking simply consolidates all this ad-hockery
into base::debug::TraceOptions. It may look like the call sites have gotten
more verbose,
but the end result of this is a consistent understanding of TraceOptions.
There is one exception to this consolidation: devtools has to maintain its own
mapping of string->TraceOptions encoding. This is because DevTools makes
guarantees about backward compatibility: if base changes its mind about the
string form of a TraceOption, devtools needs to keep supporting the old form.
BUG=396081
TBR=cevans@chromium.org
Review URL: https://codereview.chromium.org/425593002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new classes allow building JSON-like structural arguments. Current implementation uses base::Value as backing store but that can be replaced in the future with something more efficient without changing client code.
All clients of cc/debug/traced_value.h should eventually switch to use the new builders.
BUG=361045
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286849
R=alph@chromium.org, dsinclair@chromium.org, nduca@chromium.org, willchan@chromium.org
Review URL: https://codereview.chromium.org/380763002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/380763002/)
Reason for revert:
linux ASAN errors.
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/4493/steps/base_unittests/logs/stdio
Original issue's description:
> Add builders for tracing event's structural arguments
>
> The new classes allow building JSON-like structural arguments. Current implementation uses base::Value as backing store but that can be replaced in the future with something more efficient without changing client code.
>
> All clients of cc/debug/traced_value.h should eventually switch to use the new builders.
>
> BUG=361045
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286849
TBR=alph, caseq, dsinclair, nduca, willchan, yurys
NOTREECHECKS=true
NOTRY=true
BUG=361045
Review URL: https://codereview.chromium.org/421183003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new classes allow building JSON-like structural arguments. Current implementation uses base::Value as backing store but that can be replaced in the future with something more efficient without changing client code.
All clients of cc/debug/traced_value.h should eventually switch to use the new builders.
BUG=361045
Review URL: https://codereview.chromium.org/380763002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we draw the start of input event's latencyinfo using the
timestamp when we issue the async trace event when the input event
is passing through RWH. This CL changes that we now draw the start
of input event's latencyinfo using the input event's orignial/ui
component's timestamp so visually we can better see when the input
event was created.
BUG=396236
TEST=do scroll latency tracing on pixel/android, see that now latency
for TouchMove and GestureScrollUpdate are drawn at the same starting
time.
Review URL: https://codereview.chromium.org/424833009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary for the code in base/debug/... because it gets included by base_nacl which is compiled with g++ which doesn't support SyzyASan.
R=thakis@chromium.org
BUG=
Review URL: https://codereview.chromium.org/433493002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=thakis@chromium.org
BUG=
Review URL: https://codereview.chromium.org/425773002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The fix was picked up in the r282874 libvpx roll.
BUG=350982
Review URL: https://codereview.chromium.org/423643002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=396403
Review URL: https://codereview.chromium.org/412033003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=397022
TBR=earthdok@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/411283003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Data from http://chromium-build-logs.appspot.com/flakiness_dashboard?master=chromium.win.
BUG=386891,387124,396373,396384,396386,396387,396388,396390,396392,387124,396393,396395,396399,396402,396403,396404,396405,393149,396409,95557,396413,396414,375894
R=viettrungluu@chromium.org
TBR=brettw, rvargas, sky
Review URL: https://codereview.chromium.org/410843003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=223352
TBR=bruening@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/416463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
overflowed_at_ts is between the timestamp of last event and current trace_log's time.
BUG=395739
Review URL: https://codereview.chromium.org/402283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This matches current definition in the design doc[1] and unifies phase name between Chromium and Blink. Telemetry already expects both "i" and "I" values [2].
It used to be "I" in Chromium but it was changed in https://chromiumcodereview.appspot.com/12252058/
[1] https://docs.google.com/a/chromium.org/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU/edit#
[2] https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/telemetry/timeline/trace_event_importer.py&q=%22elif%20phase%20==%20'I'%20or%20phase%20==%20'i':%22&sq=package:chromium&type=cs&l=252
BUG=None
Review URL: https://codereview.chromium.org/399423005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome!DumpProcessWithoutCrash.
BUG=391974
TEST=chrome://crashdump and verify crash dump appears and tab does not crash
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/371073003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
that happens.
BUG=393750
Review URL: https://codereview.chromium.org/398913003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The synthetic delay macro initializes a local atomic variable to point
to a delay implementation class. Because initializing the class involves
writing data to memory which is subsequently deferences through the
atomic pointer, we need to use memory barries when updating the pointer
to make sure the data behind it is committed.
Thanks to Alexander Potapenko for spotting this.
Review URL: https://codereview.chromium.org/392933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=392035
Review URL: https://codereview.chromium.org/374043002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If PathService dcheks or checks then we deadlock since the symbolizer
uses path service itself. See bug for details.
BUG=391331
NOTRY=true
Review URL: https://codereview.chromium.org/363393002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This contains fixes for the following sorts of issues:
* Signedness mismatch
* Assignment inside conditional
* Nonstandard extension: unnamed struct/union
* Octal escape sequence terminated by decimal number
* Possibly-uninitialized local variable
This also contains a very small number of other cleanups/simplifications to
nearby code.
BUG=81439
TEST=none
Review URL: https://codereview.chromium.org/368133002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is a followup from https://codereview.chromium.org/228753003 which expands the subset of chromium that should be possible to build with uClibc.
BUG=386961
Review URL: https://codereview.chromium.org/354873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- on system_base_info in usrsctp (issue 348984)
- in WebRtcBrowserTest tests (issue 389098)
BUG=389098,348984
TBR=eugenis@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/336943009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This introduces NO FUNCTIONAL CHANGES. It is strictly a file move and namespace change.
BUG=338338
R=michaeln@chromium.org
TBR=cevans, darin
Review URL: https://codereview.chromium.org/344493002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- data race on g_next_user_script_id in extensions::ContentScriptsHandler::Parse (issue 388730)
- memory leak in DataReductionProxyUsageStatsTest.isDataReductionProxyUnreachable (issue 388668)
BUG=388668,388730
TBR=eugenis@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/346633003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TBR=earthdok@chromium.org
Review URL: https://codereview.chromium.org/350853004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Lock order was inverted while stopping the stream which can lead
to deadlock.
BUG=327817,374135
TEST=No more lock inversion warning from TSANv2.
R=ajwong@chromium.org, dgreid@chromium.org
TBR=awong
Review URL: https://codereview.chromium.org/348843004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=361790
TBR=nhiroki@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/341033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=386385
TBR=jianli@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/344633003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the operator to avoid misuse like the following:
TRACE_EVENT1("a", "b", "c",
condition ? TRACE_STR_COPY(short_live_string) : "literal");
In the above case, the argument value is actually const char*, not
TraceValueWithCopy because it is automatically converted back to
const char* with the const char* operator.
Found no errornous usages in chromium, but found one error in WebKit.
R=dsinclair
BUG=382789 (perhaps the reason)
Review URL: https://codereview.chromium.org/338653005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Traditionally we pass the full path to the source tree in ASAN_OPTIONS at
runtime. However, in release builds it always ends with "Release/../../" so we
can just make that the default.
BUG=302040
R=glider@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/327003002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fixes ASAN component build after r277201.
TBR=ajwong@chromium.org
Review URL: https://codereview.chromium.org/339543002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will allows to induce ASan crashes in the browser and in the renderer processes, this is really useful when trying to debug an ASan crash (to make sure that the build is really instrumented).
This code add the following crash urls to chrome:
chrome://crash/browser-heap-overflow
chrome://crash/browser-heap-underflow
chrome://crash/browser-use-after-free
chrome://crash/browser-corrupt-heap-block
chrome://crash/browser-corrupt-heap
Those URLs induce a crash in the browser process, while those:
chrome://crash/heap-overflow
chrome://crash/heap-underflow
chrome://crash/use-after-free
chrome://crash/corrupt-heap-block
chrome://crash/corrupt-heap
induce a crash in the renderer process.
We need this because as these process use a different DLL (chrome.dll vs
chrome_child.dll) one of them could be ASan-instrumented while the other one
isn't... So the current code in renderer/ is useless for the browser-only
instrumented builds...
BUG=
Review URL: https://codereview.chromium.org/306753003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
suppression,
enable a test.
BUG=375672,345251
TBR=jamesr@chromium.org
Review URL: https://codereview.chromium.org/321103003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- false positive in FcStrStaticName due to unannotated atomics in Skia (issue 369257)
- lock inversion in Gtk2UI (issue 380554)
BUG=380554,369257
TBR=timurrrr@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/318553004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=379738
TBR=groby@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/306333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=137973,374151,377420
Review URL: https://codereview.chromium.org/308733004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=302040
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/296173006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR for analyzer changes, which are just fixes to the analyzer unit tests.
R=dsinclair
CC=epenner
TBR=willchan
Review URL: https://codereview.chromium.org/277883002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for TSan.
This broke TSan compilation, as the tool dies when attempting to open a non-existent file.
BUG=302040
TBR=earthdok@chromium.org
Review URL: https://codereview.chromium.org/296513014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272262 0039d316-1c4b-4281-b951-d872f2087c98
|