summaryrefslogtreecommitdiffstats
path: root/base/debug
Commit message (Collapse)AuthorAgeFilesLines
* enable -Wstring-conversion when compiling with clangscottmg@chromium.org2013-02-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary of try run with flag enabled as warning: On linux_clang, there's false positives from a bunch of assert usage that does !"string" or "string" for a true or false value. It's only in third_party (Mesa, skia, libjingle, etc.) so it probably wouldn't be too hard to disable the warnings in those subtrees. It diagnoses 4 useful locations: 1. ../../base/debug/trace_event_unittest.cc:70:41: warning: implicit conversion turns string literal into bool: 'const char [2]' to 'bool' [-Wstring-conversion] TraceLog::GetInstance()->SetEnabled("*"); ~~~~~~~~ ^~~ 2. ../../sync/syncable/entry_kernel.cc:77:38: warning: implicit conversion turns string literal into bool: 'const char [5]' to 'bool' [-Wstring-conversion] value->SetBoolean("encrypted", "true"); ~~~~~ ^~~~~~ 3. ../../chrome/browser/webdata/web_data_service.cc:334:17: warning: implicit conversion turns string literal into bool: 'const char [44]' to 'bool' [-Wstring-conversion] DLOG_ASSERT("WebDataService dtor called without Shutdown"); ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../base/logging.h:595:43: note: expanded from macro 'DLOG_ASSERT' 4. ../../chrome/browser/renderer_host/web_cache_manager_unittest.cc:259:20: warning: implicit conversion turns string literal into bool: 'const char [29]' to 'bool' [-Wstring-conversion] EXPECT_FALSE("Unexpected entry in strategy"); ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Finding #1 is what made me look into this, #3 and #4 are not doing what they're supposed to, and #2 is kind of funny so not all is lost. So, 3 bugs and 1 very-close-to-a-bug: seems worth enabling. R=thakis@chromium.org TBR=darin@chromium.org, dhollowa@chromium.org, brettw@chromium.org, zea@chromium.org BUG=177306 Review URL: https://chromiumcodereview.appspot.com/12258039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183998 0039d316-1c4b-4281-b951-d872f2087c98
* Add a missing base:: in the tracing macros.dsinclair@chromium.org2013-02-191-1/+1
| | | | | | | | | | | | | When the macro gets expanded outside of the base directory there are compile errors. Add the needed base:: to make everything happy. BUG=111509 Review URL: https://chromiumcodereview.appspot.com/12289010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183274 0039d316-1c4b-4281-b951-d872f2087c98
* Make a new TRACE macro that is slower but uses less memorygman@chromium.org2013-02-162-0/+74
| | | | | | | | | | | | | | | | | | | | | | | The current TRACE macros are designed for speed but it means they generate lots of code. I added a TRACE_EVENT_BINARY_EFFICENTx for those cases where memory is more important the speed. The issue here is I'm auto generating traces. The normal TRACE_EVENT0 ended up adding 90k+ to the release build. This new macro does not. This won't effect perf because these macros used through a wrapper that only gets used when certain command line flags are passed in. In other words the code that uses these macros is not called without the command line flags. BUG=176383 Review URL: https://chromiumcodereview.appspot.com/12278018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182993 0039d316-1c4b-4281-b951-d872f2087c98
* Adding raw tracing to trace framework.dsinclair@chromium.org2013-02-155-78/+295
| | | | | | | | | | | | With some types of tracing you do not want to use the system time as the recorded event time. In those cases, we want to provide a timestamp that will be used to display the event. In a similar vein, the thread which is outputting the event may not be the thread where the event happened so we also allow an explicit thread_id to be provided. BUG=111509 Review URL: https://chromiumcodereview.appspot.com/11366109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182768 0039d316-1c4b-4281-b951-d872f2087c98
* Support JellyBean MR2 style of systracewangxianzhu@chromium.org2013-02-152-7/+19
| | | | | | | | | | | | | | | | | | JB MR2 systrace.py combined the steps of trace tags settings and trace collection into one step, so we need to react to the change of trace tags settings to enable/disable atrace in chrome. The change also benefit pre-JB-MR2 systems that we don't need to restart chrome after changing the trace tags settings in Developer options. However, we still need "adb shell stop; adb shell start" if we set the trace tags using pre-JB-MR2 systrace.py. BUG=173954 Review URL: https://chromiumcodereview.appspot.com/12221047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182739 0039d316-1c4b-4281-b951-d872f2087c98
* Linux/ChromeOS Chromium style checker cleanup, base/ edition.rsleevi@chromium.org2013-02-071-2/+2
| | | | | | | | | | | Automated clean up of style checker errors that were missed due to the plugin not being executed on implementation files. BUG=115047 Review URL: https://chromiumcodereview.appspot.com/12236004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181246 0039d316-1c4b-4281-b951-d872f2087c98
* Move string_number_conversions to base/strings.brettw@chromium.org2013-02-071-1/+1
| | | | | | | | | | This only updates includes in base and keeps a forwarding header for now to keep the change under control. BUG= Review URL: https://codereview.chromium.org/12092078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181161 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "GTTF: Add missing virtual destructors."phajdan.jr@chromium.org2013-02-061-2/+0
| | | | | | | | | | | | | | It turned out this is not necessary, we have a better warning already enabled in clang (-Wdelete-non-virtual-dtor, part of -Wall). TBR=darin,satorux,fischman,jamesr,jar,sky BUG=45135 Review URL: https://codereview.chromium.org/12224027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180971 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Add missing virtual destructors.phajdan.jr@chromium.org2013-02-051-0/+2
| | | | | | | | | | | R=jar TBR=darin,satorux,fischman,jamesr,sky BUG=45135 Review URL: https://codereview.chromium.org/12086018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180669 0039d316-1c4b-4281-b951-d872f2087c98
* Move string tokenizer to base/strings.brettw@chromium.org2013-02-021-9/+9
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/12087091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180211 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: Add trace event Pepper APIelijahtaylor@chromium.org2013-01-283-904/+911
| | | | | | | | | | | | | | | | | | | This facilitates adding trace data to chrome://tracing from plugins. - broke out trace_event.h into trace_event.h/trace_event_internal.h for easier transplanting to plugin code by eliminating dependence on base/. - inlined trace_event.cc methods (4 total) so the trace_event_internal implementation is contained in headers. - added new PPB_TraceEvent_Dev interface (implemented entirely on the plugin side) BUG=93839 TEST=base_unittests, manual for plugin testing Review URL: https://chromiumcodereview.appspot.com/12047066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179171 0039d316-1c4b-4281-b951-d872f2087c98
* Add ability to retrieve a thread_name given a thread_id.dsinclair@chromium.org2013-01-252-4/+9
| | | | | | | | | | | | | | | | | | The work to add GPU tracing needs the ability to map from a thread_id back to a thread_name in order to allow us to have the correct display on the chrome://tracing page. We want to be able to output our traces without having to post to a thread to handle the output, and to have the GPU traces differentiated from the GPU-process which will be doing the tracing calls. BUG=111509 TEST=Added tests in base_unittests Review URL: https://chromiumcodereview.appspot.com/11438022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178886 0039d316-1c4b-4281-b951-d872f2087c98
* Android: removes "trace_event_clock_sync" from atrace.bulach@chromium.org2013-01-183-51/+0
| | | | | | | | | | | | This event was written to debugfs when trace was finished. It happens on the UI thread and IO is not allowed. BUG=170284 Review URL: https://chromiumcodereview.appspot.com/12025014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177764 0039d316-1c4b-4281-b951-d872f2087c98
* Replaced DictionaryValue::key_iterator by DictionaryValue::Iterator outside ↵pneubeck@chromium.org2013-01-181-8/+3
| | | | | | | | | | | | | | | of chrome/browser. Marked Iterator::HasNext() as deprecated and added a method Iterator::CanAdvance() as replacement. As DictionaryValue::Iterator is actually a const iterator, I had to add several missing const annotations, mostly, in json_schema_validator.* and command.* BUG=162611 TEST=No new tests. Only semantically equivalent refactorings. Review URL: https://chromiumcodereview.appspot.com/11418150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177673 0039d316-1c4b-4281-b951-d872f2087c98
* Enable overlapping, usage counted SetEnabled()/SetDisabled() for TraceLogcaseq@google.com2013-01-163-11/+81
| | | | | | | | | | | This allows multiple clients to enable/disable trace events collection independently on each other. BUG=none TEST=TraceEventTestFixture.TraceEnableDisable Review URL: https://codereview.chromium.org/11802005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177135 0039d316-1c4b-4281-b951-d872f2087c98
* Create the crash key registration system and register some Mac-specific keys.rsesek@chromium.org2013-01-153-4/+315
| | | | | | | | | BUG=77656 Review URL: https://chromiumcodereview.appspot.com/11761030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177015 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Print more detailed information about deadly signals.phajdan.jr@chromium.org2013-01-151-13/+76
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/11879021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176989 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing, and remove unnecessary, 'explicit' from constructors. (base/)hans@chromium.org2013-01-152-13/+13
| | | | | | | | | | | | | | | The style guide says that constructors which can be called with one argument should be explicit. For constructors which cannot be called with exactly one argument, there is no reason to mark them explicit. BUG=163357 Review URL: https://chromiumcodereview.appspot.com/11779022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176881 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: dump registers on crash on 32-bit Linuxphajdan.jr@chromium.org2013-01-141-16/+51
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/11854018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176689 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 176681sky@chromium.org2013-01-141-51/+16
| | | | | | | | | | | | | > GTTF: dump registers on crash on 32-bit Linux > > BUG=none > > Review URL: https://codereview.chromium.org/11854018 TBR=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/11880027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176684 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: dump registers on crash on 32-bit Linuxphajdan.jr@chromium.org2013-01-141-16/+51
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/11854018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176681 0039d316-1c4b-4281-b951-d872f2087c98
* Add regression test for lazy evaluation of tracing parameters.dsinclair@chromium.org2013-01-141-0/+18
| | | | | | | | | BUG=80709 Review URL: https://chromiumcodereview.appspot.com/11860011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176679 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: dump registers on crash on 64-bit Linuxphajdan.jr@chromium.org2013-01-103-29/+98
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/11745003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176110 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 175233 because Linux ASAN builder cannot compile it.alexeypa@google.com2013-01-043-911/+904
| | | | | | | | | | | | | | | | | | | | | | | | | http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASAN%20Builder&number=15352 > Add trace event Pepper API > > This facilitates adding trace data to chrome://tracing from plugins. > > - broke out trace_event.h into trace_event.h/trace_event_internal.h > for easier transplanting to plugin code by eliminating dependence on base/. > - inlined trace_event.cc methods (4 total) so the trace_event_internal > implementation is contained in headers. > - added new PPB_TraceEvent_Dev interface (implemented entirely on the plugin side) > > BUG=none > TEST=base unittests, manual for plugin testing > > > Review URL: https://chromiumcodereview.appspot.com/11464005 TBR=elijahtaylor@chromium.org Review URL: https://codereview.chromium.org/11782008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175236 0039d316-1c4b-4281-b951-d872f2087c98
* Add trace event Pepper APIelijahtaylor@chromium.org2013-01-043-904/+911
| | | | | | | | | | | | | | | | | | This facilitates adding trace data to chrome://tracing from plugins. - broke out trace_event.h into trace_event.h/trace_event_internal.h for easier transplanting to plugin code by eliminating dependence on base/. - inlined trace_event.cc methods (4 total) so the trace_event_internal implementation is contained in headers. - added new PPB_TraceEvent_Dev interface (implemented entirely on the plugin side) BUG=none TEST=base unittests, manual for plugin testing Review URL: https://chromiumcodereview.appspot.com/11464005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175233 0039d316-1c4b-4281-b951-d872f2087c98
* Create a cross-platform crash key system in base/debug/crash_logging.h.rsesek@chromium.org2013-01-032-0/+148
| | | | | | | | | | | | | | This is a direct port of the Mac-specific one, and that has been reimplemented on top of the new cross-platform one. Currently only the Mac implementation is hooked up. BUG=77656 TEST=Built official and caused some crashes, verified report data in upload. Review URL: https://chromiumcodereview.appspot.com/11635030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174911 0039d316-1c4b-4281-b951-d872f2087c98
* Remove support for TRACE_EVENT_IF_LONGER_THANx macroscaseq@google.com2012-12-135-268/+15
| | | | | | | | | | | | These add consederable amount of complexity, yet only have 1 (one) usage. BUG=none TEST=base_unittest TBR=gman,darin Review URL: https://codereview.chromium.org/11557009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172863 0039d316-1c4b-4281-b951-d872f2087c98
* Add tracing support to NaCljbauman@chromium.org2012-12-082-1/+11
| | | | | | | | | | Add Ppapi IPC messages and a handler inside of the NaCl IRT to enable, disable, and send the result of tracing. BUG=93839 Review URL: https://codereview.chromium.org/11411118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171911 0039d316-1c4b-4281-b951-d872f2087c98
* Fix gcc 4.7 compilation problem by adding explict unistd.h inclusion.shenhan@google.com2012-11-171-0/+4
| | | | | | | | | | | | | (intptr_t is defined in unistd.h) TEST=Built using gcc 4.7 BUG= Review URL: https://chromiumcodereview.appspot.com/11412026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168439 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 168239 - Extract SIGPIPE ignoring code to a common place.dmichael@google.com2012-11-162-5/+11
| | | | | | | | | | | | | | | | | | | Failed compile on Linux Clang: http://build.chromium.org/p/chromium.linux/builders/Linux%20Clang%20%28dbg%29/builds/35971/steps/compile/logs/stdio ../../chrome/test/webdriver/webdriver_server.cc:230:8:error: use of undeclared identifier 'IgnoreSigPipe'; did you mean 'base::IgnoreSigPipe'? if (!IgnoreSigPipe()) { ^~~~~~~~~~~~~ base::IgnoreSigPipe ../../base/process_util.h:153:18: note: 'base::IgnoreSigPipe' declared here BUG=none Review URL: https://codereview.chromium.org/11280010 TBR=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/11308073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168248 0039d316-1c4b-4281-b951-d872f2087c98
* Extract SIGPIPE ignoring code to a common place.phajdan.jr@chromium.org2012-11-162-11/+5
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/11280010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168239 0039d316-1c4b-4281-b951-d872f2087c98
* Put Android systrace calls in trace_event_impl only.wangxianzhu@chromium.org2012-11-155-58/+72
| | | | | | | | | | | | | | | | | | | http://codereview.chromium.org/11345019/ added code in both trace_event.h/cc and trace_event_impl.h/cc to support Android systrace. However, to make TRACE_EVENT in Webkit work, we would also need to change the TraceEvent.h in WebKit. This change removes Android systrace calls from trace_event.h/cc and put all ATrace specific code into trace_event_impl.h/cc so that trace_event for Android can work for WebKit without changing WebKit and/or webkit glue code. TBR=brettw BUG= Review URL: https://chromiumcodereview.appspot.com/11360208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167983 0039d316-1c4b-4281-b951-d872f2087c98
* Move eintr_wrapper.h from base to base/posixbrettw@chromium.org2012-11-142-2/+2
| | | | | | Review URL: https://codereview.chromium.org/11366229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167739 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Make Linux stack dump signal handler async-signal safe.phajdan.jr@chromium.org2012-11-144-66/+332
| | | | | | | | | | | This also re-enables in-process stack dumping on Linux. BUG=101155 Review URL: https://chromiumcodereview.appspot.com/11362048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167714 0039d316-1c4b-4281-b951-d872f2087c98
* Use ';' instead of '|' to separate arguments in Android trace.wangxianzhu@chromium.org2012-11-101-1/+4
| | | | | | | | | | | | According to comments in https://codereview.appspot.com/6822089/, using ';' instead '|' to separate arguments can improve extensibility. BUG= Review URL: https://chromiumcodereview.appspot.com/11366166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167086 0039d316-1c4b-4281-b951-d872f2087c98
* Move stack_container and linked_list to the new containers subdirectory.brettw@chromium.org2012-11-101-1/+1
| | | | | | | | | | This also replaces the StackWString with StackString16 and adds a char traits definition to the string16 header file to make this possible without ifdefs. BUG= Review URL: https://codereview.chromium.org/11360174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167022 0039d316-1c4b-4281-b951-d872f2087c98
* Move EnableInProcessStackDumping to base/debugphajdan.jr@chromium.org2012-11-015-0/+173
| | | | | | | | | | | | | | This is a preparation to fix async-signal unsafety of the stack dumping signal handler, and I'd like to share code between the handler and stack trace code that wouldn't be useful outside those two. BUG=101155 TEST=if it compiles, it is perfect Review URL: https://codereview.chromium.org/11293021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165514 0039d316-1c4b-4281-b951-d872f2087c98
* Make Chrome Trace work with Android ATrace.wangxianzhu@chromium.org2012-11-015-90/+231
| | | | | | | | | | | | | | | | | | | | | | | | | | It uses "view" tag in the ATrace to enable tracing Chrome events. Steps to grab a trace: 1. Enable trace of "view" in the Developer options. 2. adb shell stop; adb shell start or if the system itself supports changing trace settings without restart: adb shell am force-stop com.android.chrome (for stable version) adb shell am force-stop com.google.android.apps.chrome (for beta/dev version) 3. Start Chrome 4. // grab a 5-seconds trace, the result is in trace.html third_party/android_tools/sdk/tools/systrace/systrace.py -t 5 -f -w Note: the intent triggered Chrome trace still works with this patch. BUG= Review URL: https://chromiumcodereview.appspot.com/11345019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165507 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: remove FAILS_ prefix, part 1phajdan.jr@chromium.org2012-11-011-1/+1
| | | | | | | | | | | See http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/handling-a-failing-test and https://groups.google.com/a/chromium.org/d/topic/chromium-dev/_OwJ_GWfOaY/discussion BUG=none Review URL: https://codereview.chromium.org/11293028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165415 0039d316-1c4b-4281-b951-d872f2087c98
* Trace PostTasks from post to run.jbates@chromium.org2012-09-181-25/+153
| | | | | | | | | | | | To do this properly, we need a new type of trace event "FLOW" which will be drawn as lines in about:tracing from BEGIN to END. Also instruments SequencedWorkerPool and ChannelReader::DispatchInputData, which were not currently traced. BUG=79942 Review URL: https://codereview.chromium.org/10913242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157288 0039d316-1c4b-4281-b951-d872f2087c98
* Fix trace event macro naming issuejbates@chromium.org2012-09-112-9/+9
| | | | | | Review URL: https://chromiumcodereview.appspot.com/10908183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155955 0039d316-1c4b-4281-b951-d872f2087c98
* implement SetWatchEvent and WaitForEvent for trace-based-tests.jbates@chromium.org2012-09-013-103/+281
| | | | | | | | | | | | Up until now, tracing-based tests have been required to either run a trace for some amount of time or use existing notification mechanisms to return control to the test. This change adds a 'watch event' feature to trace_event_impl which can be used by tests to wait for an event to occur. This mechanism could replace the use of test-only notifications which is frowned upon as well as mock classes for catching events. Trace events also have the huge advantage of working on all chrome processes as opposed to the browser-only notification service. BUG=139939 Review URL: https://chromiumcodereview.appspot.com/10837082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154552 0039d316-1c4b-4281-b951-d872f2087c98
* Disable leak annotations for NaCl untrusted builds.bbudge@chromium.org2012-08-171-1/+2
| | | | | | | | BUG=116317 TEST=compiles on linux heap checker bots Review URL: https://chromiumcodereview.appspot.com/10824356 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152137 0039d316-1c4b-4281-b951-d872f2087c98
* Fix TraceEventTestFixture flakinessjbates@chromium.org2012-08-162-6/+28
| | | | | | | | | BUG=142804 Review URL: https://chromiumcodereview.appspot.com/10828326 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151851 0039d316-1c4b-4281-b951-d872f2087c98
* Remove executable bits on file.mmoss@chromium.org2012-08-091-0/+0
| | | | | | | | | TBR=brettw@chromium.org TEST=fixes checkperms on Linux builder. Review URL: https://chromiumcodereview.appspot.com/10855077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150798 0039d316-1c4b-4281-b951-d872f2087c98
* [MIPS] Add DEBUG_BREAK() for MIPS architecture.petarj@mips.com2012-08-091-0/+2
| | | | | | | | | | | Small change to add correct asm break instruction for MIPS architecture. BUG= https://code.google.com/p/chromium/issues/detail?id=130022 TEST=make chrome Review URL: https://chromiumcodereview.appspot.com/10834234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150789 0039d316-1c4b-4281-b951-d872f2087c98
* trace event macro ambiguity fix when int64 is used on 64-bit buildjbates@chromium.org2012-08-071-0/+2
| | | | | | Review URL: https://chromiumcodereview.appspot.com/10834192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150376 0039d316-1c4b-4281-b951-d872f2087c98
* mac: Delete some pre-10.5 code.thakis@chromium.org2012-08-061-14/+0
| | | | | | | | BUG=none Review URL: https://chromiumcodereview.appspot.com/10827175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150171 0039d316-1c4b-4281-b951-d872f2087c98
* Correct const accessors in base/values.(h|cc), Part II (ListValue)vabr@chromium.org2012-08-031-23/+24
| | | | | | | | | | | | | | For problem description and other info please see the BUG page. This is for ListValue. BUG=138946 TEST=N/A (no fix & no new feature) TBR=jar,zelidrag,scottbyer,mpcomplete,darin,achuith,sky,estade,atwilson,grt,thakis,jamesr,hans,sadrul,pastarmovj Review URL: https://chromiumcodereview.appspot.com/10837044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149819 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fully initialize the |trace_| member variable.jhawkins@chromium.org2012-07-253-8/+13
| | | | | | | | | | | | | | | Also changed the type of |count_| to size_t since it's a size variable. CID_COUNT=1 CID=13504 BUG=none TEST=none R=brettw Review URL: https://chromiumcodereview.appspot.com/10834006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148420 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-18 13:07:06 +0000