| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
| |
(Long term intention is to add a subset of cpplint.py to the presubmit script.)
Review URL: http://codereview.chromium.org/276008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28914 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I found a case of renderers trying to die in a signal handler but a
corrupt heap (and some atexit() handlers installed by XmlSomething)
made us hang forever.
BUG=http://crbug.com/23590, http://crbug.com/23919, http://crbug.com/22287 (maybe)
It isn't clear this fixes any known renderer hangs (e.g. the bugs
above) but it's a step in the right direction.
TEST=no known way to reliably hit this state.
Review URL: http://codereview.chromium.org/261059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28750 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The list was too long and was catching signals corresponding to Mach
exceptions that Apple Crash Reporter never attempts to catch, and signals
that don't even map to Mach exceptions. The default signal handlers are fine
in these cases.
BUG=24568
TEST=Crash reporting still disabled when appropriate
(see chrome/app/chrome_dll_main.cc and the comment before
DisableOSCrashDumps in ChromeMain)
Specifically, with stats reporting disabled, about:crash should result in
a sad tab but no silent crash report generated in
~/Library/Logs/CrashReporter
Review URL: http://codereview.chromium.org/272025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28701 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1)Fix logic inversion in IsCrashReporterEnabled().
2)Don't intercept SIGPIPE in non-branded builds since it isn't fatal.
3)Roll DEPS to pickup a bunch of Mac Breakpad fixes.
When breakpad is disabled, we intercept a bunch of signals so that we can crash fast, without waiting for Apple's crash reporter. The problem was that the function we where using to test whether breakpad was enabled was wrong so we were always installing these signal handlers which where just calling exit().
By fixing the IsCrashReporterEnabled() call, we no longer install these signal handlers if Breakpad is enabled.
In any case SIGPIPE is non-fatal so we remove it from the list of signals we intercept.
There have been a number of fixes to the OSX version of Breakpad recently, so we pull those in as well.
BUG=11929
Review URL: http://codereview.chromium.org/115493
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
See http://crbug.com/7652
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9757 0039d316-1c4b-4281-b951-d872f2087c98
|
