| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
My first Chromium linux build greeted me with a backtrace of mangled symbols
(FWIW, my /dev/shm permission was wrong). That made me write this patch.
BEFORE:
../sconsbuild/Debug/base_unittests(_ZN10StackTraceC1Ev+0x20) [0x817795e]
../sconsbuild/Debug/base_unittests(_ZN30StackTrace_OutputToStream_Test8TestBodyEv+0x18) [0x805fc98]
../sconsbuild/Debug/base_unittests(_ZN7testing4Test3RunEv+0x7e) [0x82005ea]
AFTER:
../sconsbuild/Debug/base_unittests(StackTrace::StackTrace()+0x20) [0x817778c]
../sconsbuild/Debug/base_unittests(StackTrace_OutputToStream_Test::TestBody()+0x18) [0x805fc98]
../sconsbuild/Debug/base_unittests(testing::Test::Run()+0x7e) [0x8200786]
BUG=none
TEST=manually tested. also ran base_unittests
Review URL: http://codereview.chromium.org/267074
Patch from Satoru Takabayashi <satorux@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(Long term intention is to add a subset of cpplint.py to the presubmit script.)
Review URL: http://codereview.chromium.org/276008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The previous implementation was overly verbose. The new one is now functional and the unit test now works.
TEST=unit_test
BUG=none
Review URL: http://codereview.chromium.org/174250
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
particular, symbols are not present on the buildbot which means this test always fails on the buildbot. Disabling the code for now to bring the tree green.
Review URL: http://codereview.chromium.org/92112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
This provides basic support for looking up backtrace information on GNU libc systems and in Windows. The code is only enabled for FATAL log messages in debug mode. In a release build, it is unlikely that symbols will be available making the backtrace less useful.
Review URL: http://codereview.chromium.org/62140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14391 0039d316-1c4b-4281-b951-d872f2087c98
|