summaryrefslogtreecommitdiffstats
path: root/base/env_var.cc
Commit message (Collapse)AuthorAgeFilesLines
* base: add home environment variable to env_var.htfarina@chromium.org2010-07-211-0/+10
| | | | | | | | | | | BUG=None TEST=trybots Signed-off-by: Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/2847058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53143 0039d316-1c4b-4281-b951-d872f2087c98
* base: Return bool instead of void in EnvVarGetter::SetEnv.tfarina@chromium.org2010-07-161-6/+8
| | | | | | | | | | | | | | | Returning bool instead of void in this function is better, because with that we can know if we had succeeded when tried to set an environment variable or not. Also it makes this function more testable. BUG=None TEST=out/Debug/base_unittests --gtest_filter=EnvVarTest.* Signed-off-by: Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/2891024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52602 0039d316-1c4b-4281-b951-d872f2087c98
* Move implementation from header to source.erg@chromium.org2010-07-151-0/+6
| | | | | | | | | | | | | | | | | | | | This is an effort to speed up compile and link time, and also minimizing the size of the intermediary .o files on disk. For example, just moving the constructor/destructor from the classes in chrome/browser/pref_member.{cc,h} netted a 368k drop in total .o file size. In aggregate, this shrinks libbrowser.a by 10 megabytes, and a few odd megabytes on most other chrome .a files. A lot of this was done before I started harvesting what the most included symbols were across all of chrome's code. Most of them are in webkit, but there's plenty in base/ that are used everywhere to keep me busy for several patches to come. BUG=none TEST=none Review URL: http://codereview.chromium.org/3012001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52528 0039d316-1c4b-4281-b951-d872f2087c98
* base: Add SetEnv() to EnvVarGetter class and get rid of the some ifdefs.tfarina@chromium.org2010-07-081-2/+15
| | | | | | | | | | | (Note: This was a TODO) BUG=None TEST=included Review URL: http://codereview.chromium.org/2843048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51840 0039d316-1c4b-4281-b951-d872f2087c98
* Move EnvironmentVariableGetter from base/linux_util.h to base/env_var.h and ↵thestig@chromium.org2010-04-031-0/+80
rename it EnvVarGetter. Label base::SysInfo::{Get,Has}EnvVar as deprecated. BUG=none TEST=none Review URL: http://codereview.chromium.org/1606007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43559 0039d316-1c4b-4281-b951-d872f2087c98