summaryrefslogtreecommitdiffstats
path: root/base/files
Commit message (Collapse)AuthorAgeFilesLines
* Remove dmaclach from OWNERS filesthestig@chromium.org2012-08-221-1/+0
| | | | | | | TBR=brettw Review URL: https://chromiumcodereview.appspot.com/10873013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152839 0039d316-1c4b-4281-b951-d872f2087c98
* base: Add missing "virtual" keyword and OVERRIDE to some methods.tfarina@chromium.org2012-07-311-1/+1
| | | | | | | | | | | | | | | Found with: $ ./build/gyp_chromium -Dclang=1 -Dclang_use_chrome_plugins=1 $ ninja -C out/Debug base -k4 -j4 2>&1 | tee errors And a tweak in plugin_flags.sh BUG=115047 R=willchan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10834060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149109 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-114-4/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* Move dir_reader to base/filesbrettw@chromium.org2012-06-294-0/+264
| | | | | | | | | TEST=it compiles BUG=none Review URL: https://chromiumcodereview.appspot.com/10413022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144989 0039d316-1c4b-4281-b951-d872f2087c98
* Added a base::Callback interface to FilePathWatcher.joaodasilva@chromium.org2012-06-043-2/+95
| | | | | | | | | BUG=130980 TEST=browser_tests:FilePathWatcher* are green Review URL: https://chromiumcodereview.appspot.com/10519003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140285 0039d316-1c4b-4281-b951-d872f2087c98
* Removed file_path_watcher_mac.cc, which isn't used anymore.joaodasilva@chromium.org2012-06-043-504/+8
| | | | | | Review URL: https://chromiumcodereview.appspot.com/10500012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140272 0039d316-1c4b-4281-b951-d872f2087c98
* RefCounted types should not have public destructors, base/ editionrsleevi@chromium.org2012-04-256-9/+28
| | | | | | | | | | BUG=123295 TEST=none Review URL: http://codereview.chromium.org/10065037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133825 0039d316-1c4b-4281-b951-d872f2087c98
* Update uses of TimeDelta in base/files.tedvessenes@gmail.com2012-04-161-1/+1
| | | | | | | | | | R=dmaclach@chromium.org BUG=108171 Review URL: http://codereview.chromium.org/10019016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132411 0039d316-1c4b-4281-b951-d872f2087c98
* [Coverity] Check return value.craig.schlenter@chromium.org2012-04-051-17/+18
| | | | | | | | | | | CID=101407 BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9956064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130924 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a unused parameter in the Linux FilePathWatcher implementation.thestig@chromium.org2012-03-131-18/+11
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/9553007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126359 0039d316-1c4b-4281-b951-d872f2087c98
* [base] Make FilePathWatcher::Watch virtual so that it can be mocked.szym@chromium.org2012-02-241-3/+4
| | | | | | | | | TEST=./base_unittests Review URL: http://codereview.chromium.org/9447066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123563 0039d316-1c4b-4281-b951-d872f2087c98
* Flakiness cleanup: disable flaky tests under base/evan@chromium.org2012-02-141-3/+3
| | | | | | | | | | See https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/fcec09fc659f39a6 BUG=46246,85930,10611,86494,95058,61589,25038 Review URL: https://chromiumcodereview.appspot.com/9386014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121782 0039d316-1c4b-4281-b951-d872f2087c98
* Remove task.h and finish base::Bind() migration.ajwong@chromium.org2012-01-061-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Over 341 CLs, in ~3 months, touching 3251 unique files! Top 5 most CLs: (121) jhawkins ( 45) dcheng ( 24) achuith ( 23) csilv ( 12) tfarina ( 12) groby ~1000 files touched: (918) jhawkins 100+ files touched: (486) ajwong (385) willchan (372) dcheng (126) csilv (123) fischman (112) sergeyu 49+ files touched: (65) tfarina (57) acolwell (52) adamk (49) tzik BUG=35223 TEST=existing Review URL: http://codereview.chromium.org/9114020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116748 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Remove Task.jhawkins@chromium.org2012-01-051-63/+50
| | | | | | | | | | BUG=none TEST=none R=awong Review URL: http://codereview.chromium.org/9086002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116439 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Convert FilePathWatcher.jhawkins@chromium.org2011-11-235-70/+44
| | | | | | | | | | | BUG=none TEST=none R=willchan@chromium.org Review URL: http://codereview.chromium.org/8677015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111405 0039d316-1c4b-4281-b951-d872f2087c98
* Add CHECKs for file descriptors used in select() by InotifyReaderTaskmnissler@chromium.org2011-11-231-0/+5
| | | | | | | | | | | | Since these are used in an fd_set, there's the possibility that invalid file descriptors cause stack overflow/corruption. BUG=chromium:105162 TEST=No functional changes, compiles and passes tests. Review URL: http://codereview.chromium.org/8681006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111369 0039d316-1c4b-4281-b951-d872f2087c98
* Add OVERRIDE to base/.avi@chromium.org2011-11-161-1/+1
| | | | | | | | | BUG=104314 TEST=no change Review URL: http://codereview.chromium.org/8520018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110218 0039d316-1c4b-4281-b951-d872f2087c98
* Allow linker initialization of lazy instancejoth@chromium.org2011-11-151-2/+2
| | | | | | | | | | | | | | Using the initializer list construct = {0} allows the object to be linker initialized. Modify the LazyInstance class design to make it a pod aggregate type that can be linker initialized this way. Also combines the instance and state members, in line with the Singleton<> class design. Introduces a new LAZY_INSTANCE_INITIALIZER macro specifically for using to init all lazy instances + modify all existing callsites to use it. (Old code would no longer compile) BUG=94925 TEST=existing tests pass. http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&header=chrome-si&graph=chrome-si&rev=-1 should step downward. TBR=jam@chromium.org,rvargas@chromium.org,darin@chromium.org,ben@chromium.org,apatrick@chromium.org,akalin@chromium.org Review URL: http://codereview.chromium.org/8491043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110076 0039d316-1c4b-4281-b951-d872f2087c98
* Mark FilePathWatcherTest.DisappearingDirectory as flaky.joi@chromium.org2011-11-091-0/+4
| | | | | | | | | TBR=dmaclach@chromium.org BUG=85930 Review URL: http://codereview.chromium.org/8508012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109250 0039d316-1c4b-4281-b951-d872f2087c98
* Replace most LOG/CHECK statements with DLOG/DCHECK statements in base.brettw@chromium.org2011-10-262-3/+497
| | | | | | | | | | | [ Reland of 107042 http://codereview.chromium.org/8368009 ] I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8341026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107434 0039d316-1c4b-4281-b951-d872f2087c98
* rename file_path_watcher_mac to file_path_watcher_kqueuerobert.nagy@gmail.com2011-10-251-0/+8
| | | | | | | | | | | | | so that other platforms (*bsd) with kqueue can use it BUG= TEST= Review URL: http://codereview.chromium.org/8393013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107240 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 107042 - Replace most LOG/CHECK statements with DLOG/DCHECK ↵brettw@chromium.org2011-10-252-10/+10
| | | | | | | | | | | | | | statements in base. I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8368009 TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/8351025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107051 0039d316-1c4b-4281-b951-d872f2087c98
* Replace most LOG/CHECK statements with DLOG/DCHECK statements in base.brettw@chromium.org2011-10-252-10/+10
| | | | | | | | | I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8368009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107042 0039d316-1c4b-4281-b951-d872f2087c98
* Switch over to base::Bind for base/debug/trace_event_unittests and base/files/*.jbates@chromium.org2011-10-053-10/+12
| | | | | | Review URL: http://codereview.chromium.org/8115013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104117 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream ProcessUtilTest, and make a few other files compile on Android.jingzhao@chromium.org2011-09-291-2/+5
| | | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/8059007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103236 0039d316-1c4b-4281-b951-d872f2087c98
* Delete Tracked, and move Location to its own file.ajwong@chromium.org2011-09-211-0/+1
| | | | | | | | | | | | | The Birth/Death tracking of tasks has been moved out-of-band into MessageLoop's PendingTask structure. Thus, Task no longer needs to inherit from Tracked. Since Task was the only child of Tracked, delete the Tracked class and move Location to its own file. BUG=none TEST=builds Review URL: http://codereview.chromium.org/7879006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102132 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux] Make FilePathWatcher somewhat more symlink aware.craig.schlenter@chromium.org2011-09-052-33/+227
| | | | | | | | | | | This is still broken in a variety of ways. BUG=91561 TEST=updated FilePathWatcher tests and manual testing Review URL: http://codereview.chromium.org/7583034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99657 0039d316-1c4b-4281-b951-d872f2087c98
* Move test utilities into test_file_util.*.ahendrickson@chromium.org2011-09-021-0/+1
| | | | | | | | | | | | | Split from CL 7134019. brettw: base. BUG=None TEST=None Review URL: http://codereview.chromium.org/7740081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99416 0039d316-1c4b-4281-b951-d872f2087c98
* Mirror Windows implementation of CancelOnMessageLoopThread.dominich@chromium.org2011-08-181-9/+11
| | | | | | | | | | | | | | Before this change, there was a code path where the FilePathWatcher could have been canceled but the delegate_ was not set to NULL. At exit, the destructor would then call Cancel() which would try to post a task to the message loop. With this change, the delegate is correctly set to NULL when the MessageLoop is destroyed even if the FilePathWatcher itself has been canceled. This allows Cancel() from the destructor to do the right thing and not call into the MessageLoop. This implementation matches the Windows version which does not crash. BUG=83190 TEST=FilePathWatcherTest.* Review URL: http://codereview.chromium.org/7655028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97248 0039d316-1c4b-4281-b951-d872f2087c98
* Add MessageLoopProxy::currentnduca@chromium.org2011-08-154-4/+4
| | | | | | Review URL: http://codereview.chromium.org/7583053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96819 0039d316-1c4b-4281-b951-d872f2087c98
* Rename BASE_API to BASE_EXPORT.darin@chromium.org2011-08-051-2/+2
| | | | | | | R=rvargas Review URL: http://codereview.chromium.org/7461141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95618 0039d316-1c4b-4281-b951-d872f2087c98
* some cleanup for base/stl_utildilmah@chromium.org2011-07-191-1/+1
| | | | | | | | | | | | | removed unused/irrelevant functions removed irrelevant comments Moved stl_util-inl.h => stl_util.h BUG=None TEST=None Review URL: http://codereview.chromium.org/7342047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93110 0039d316-1c4b-4281-b951-d872f2087c98
* Mark FilePathWatcherTest.DestroyWithPendingNotification as FLAKY on MacOSasargent@chromium.org2011-06-131-1/+7
| | | | | | | | | BUG=85930 TEST=none TBR=phajdan.jr@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88851 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_temp_dir and scoped_native_library back from base/memory to base.thakis@chromium.org2011-05-191-1/+1
| | | | | | | | | | | It looks like they got moved accidentally in http://codereview.chromium.org/6714032 BUG=none TEST=none Review URL: http://codereview.chromium.org/7048007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86010 0039d316-1c4b-4281-b951-d872f2087c98
* iwyu: Include stringprintf.h where appropriate, part 3.jhawkins@chromium.org2011-05-121-2/+2
| | | | | | | | | | | BUG=82098 TEST=none R=csilv@chromium.org Review URL: http://codereview.chromium.org/7016011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85088 0039d316-1c4b-4281-b951-d872f2087c98
* Base: More adjustments to BASE_API and project dependencies torvargas@google.com2011-04-211-1/+2
| | | | | | | | | | use base.dll from chrome. BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6877053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82564 0039d316-1c4b-4281-b951-d872f2087c98
* Move FilePathWatcher to base/files.craig.schlenter@chromium.org2011-04-148-0/+2053
FilePathWatcher is going to be used in future for monitoring changes to /etc/resolv.conf so it needs live somewhere where various consumers can get at it without incurring the wrath of the layering gods. TEST=existing tests BUG=67734 Review URL: http://codereview.chromium.org/6793020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81606 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 23:47:09 +0000