summaryrefslogtreecommitdiffstats
path: root/base/id_map_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* base: Use TEST() macro when possible.tfarina@chromium.org2012-12-031-12/+10
| | | | | | | | | | | | | | | | | There is no need to inherit from testing::Test and then have to use TEST_F(), if you aren't overridding SetUp() or TearDow(). So if you don't need to customize it, you can use TEST() macro directly and it does that for us automagically. Fix all the cases found with the following command line: $ git grep -n1 "public testing::Test" base/ | grep "};" TEST=base_unittests R=willchan@chromium.org Review URL: https://codereview.chromium.org/11308261 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170747 0039d316-1c4b-4281-b951-d872f2087c98
* Add IDMap::Clear() which removes all items.jsbell@chromium.org2012-10-291-0/+73
| | | | | | | | | | | Includes unit tests. R=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/11266017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164742 0039d316-1c4b-4281-b951-d872f2087c98
* Make IDMap respect C++ rule of three,phajdan.jr@chromium.org2012-10-271-0/+69
| | | | | | | | | | | | | | | | i.e. when the dtor is defined, copy ctor and assignment operator should also be defined. We can't use DISALLOW_COPY_AND_ASSIGN because IDMap is being copied/assigned in the codebase. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/11263023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164473 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up of -Wunused-but-set-variable (gcc 4.6)pph34r@gmail.com2011-06-251-5/+3
| | | | | | | | | | BUG=80071 TEST=base_unittests Review URL: http://codereview.chromium.org/7232025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90489 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly recognize emptiness of IDMap.phajdan.jr@chromium.org2010-02-161-3/+14
| | | | | | | | | | | | This prevents a leak of RenderProcessHost, and possibly other bad bugs. TEST=Added to base_unittests; also existing browser and unit tests. BUG=35571 Review URL: http://codereview.chromium.org/604048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39084 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor Pepper device APIneb@chromium.org2010-01-251-0/+80
| | | | | | | | | Track Pepper DeviceContexts using ID (and reclaim them upon shutdown) Refactor device-specific code into pepper_devices.h Review URL: http://codereview.chromium.org/548100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37060 0039d316-1c4b-4281-b951-d872f2087c98
* Move IDMap back to base/ where it is needed.phajdan.jr@chromium.org2009-08-191-0/+106
TEST=Covered by base_unittests. BUG=none Review URL: http://codereview.chromium.org/173026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23709 0039d316-1c4b-4281-b951-d872f2087c98