| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since r266618, we require SCM_CREDENTIALS to work correctly across PID
namespaces, and refuse to run on kernels where it doesn't.
Reland of r270173. The original attempt failed to update kControlMsgSize,
which caused failures like this one:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/5169
This is only noticed on 32-bit machines because CMSG_SPACE(sizeof(int))
happens to equal CMSG_SPACE(2*sizeof(int)) on x86-64 due to structure
padding and alignment, but they're different on i386.
Review URL: https://codereview.chromium.org/271703012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
build break: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/5169/steps/browser_tests/logs/CDMExpectedCrash
> Remove SCM_CREDENTIALS fallback code from breakpad
>
> Since r266618, we require SCM_CREDENTIALS to work correctly across PID
> namespaces, and refuse to run on kernels where it doesn't.
>
> NOTRY=true
>
> Review URL: https://codereview.chromium.org/283643004
TBR=mdempsky@chromium.org
Review URL: https://codereview.chromium.org/275913003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The last use was removed in r269530.
BUG=357670
Review URL: https://codereview.chromium.org/288463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since r266618, we require SCM_CREDENTIALS to work correctly across PID
namespaces, and refuse to run on kernels where it doesn't.
NOTRY=true
Review URL: https://codereview.chromium.org/283643004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=viettrungluu@chromium.org, viettrungluu
Review URL: https://codereview.chromium.org/183853011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
R=rvargas@chromium.org
Review URL: https://codereview.chromium.org/89523002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also updates any stragglers that I missed, fixes mistakes I may have made,
and deletes the forwarding headers.
After this CL, the proces_util.h project is complete.
BUG=242290
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/20265004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16667013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally landed in r204547
Reverted in r204553 due to cq anomaly.
Android builds with coverage=1 fail due to uninitialized variable
warnings in base/linux_util.cc and base/net/net_util.cc
BUG=245467
TBR=willchan
Review URL: https://chromiumcodereview.appspot.com/16589002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CQ anomaly x2.
> Fix errors when building android with coverage=1
>
> Android builds with coverage=1 fail due to uninitialized variable
> warnings in base/linux_util.cc and base/net/net_util.cc
>
> BUG=245467
>
> Review URL: https://chromiumcodereview.appspot.com/16077010
TBR=rwalker@codeaurora.org
Review URL: https://codereview.chromium.org/16505004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Android builds with coverage=1 fail due to uninitialized variable
warnings in base/linux_util.cc and base/net/net_util.cc
BUG=245467
Review URL: https://chromiumcodereview.appspot.com/16077010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CQ error. Committed without tryjobs.
> Fix errors when building android with coverage=1
>
> Android builds with coverage=1 fail due to uninitialized variable
> warnings in base/linux_util.cc and base/net/net_util.cc
>
> BUG=245467
>
> Review URL: https://chromiumcodereview.appspot.com/16077010
TBR=rwalker@codeaurora.org
Review URL: https://codereview.chromium.org/16415008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Android builds with coverage=1 fail due to uninitialized variable
warnings in base/linux_util.cc and base/net/net_util.cc
BUG=245467
Review URL: https://chromiumcodereview.appspot.com/16077010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=109874
R=darin@chromium.org,ajwong@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11961021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes ChromeOS more consistent with Linux, which uses the DISTRIB_DESCRIPTION from /etc/lsb-release here. We have a different pre-existing mechanism in the code for reading the value (since ChromeOS doesn't have the lsb_release tool), but it's conceptually the same thing.
This makes it possible to search / catagorize ChromeOS crash reports based on the build, or other information about the ChromeOS version. It also allows the matching build/symbols to be more easily found given a crash report.
There's no need for Aura customization of distro anymore - that was added when
Aura was experimental. All ChromeOS is now Aura.
BUG=142630
Review URL: https://chromiumcodereview.appspot.com/10827322
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We move the setuid sandbox "client" code to its own location in
/sandbox/linux/suid/client and we create a SetuidSandboxClient class
to use it.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10807059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Android uses linux breakpad (USE_LINUX_BREAKPAD is set) and hence needs
base::GetLinuxDistro
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10785008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10535141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10539099
TBR=thestig@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10543130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10539099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=binji
Review URL: https://chromiumcodereview.appspot.com/9271061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=105046
TEST=none
Review URL: http://codereview.chromium.org/8660001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In TOUCH_UI ChromeOS builds, augment the Linux distro so that crash reports
will have lsb-release="CrOS Touch" instead of just "CrOS". This mirrors the
change in User-Agent in TOUCH_UI builds as well (see BuildOSCpuInfo() in
webkit/glue/user_agent.cc).
BUG=chromium-os:22255
TEST=Manual
Review URL: http://codereview.chromium.org/8479002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=101600
TEST=none
Review URL: http://codereview.chromium.org/8507022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
[ Reland of 107042 http://codereview.chromium.org/8368009 ]
I tried hard not to change CHECKs that had side effects. I kept fatal checks
that seemed security or debugging-info (in crash reports) sensitive, and ones
that seems particularly well-conceived.
Review URL: http://codereview.chromium.org/8341026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
statements in base.
I tried hard not to change CHECKs that had side effects. I kept fatal checks
that seemed security or debugging-info (in crash reports) sensitive, and ones
that seems particularly well-conceived.
Review URL: http://codereview.chromium.org/8368009
TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/8351025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I tried hard not to change CHECKs that had side effects. I kept fatal checks
that seemed security or debugging-info (in crash reports) sensitive, and ones
that seems particularly well-conceived.
Review URL: http://codereview.chromium.org/8368009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base/base.gyp:
- exclude test/test_file_util_linux.cc on OpenBSD because of
missing fdatasync()
base/base.gypi:
- include linux_util.cc on OpenBSD too
- exclude some linux specific files from the OpenBSD build
because the openbsd implementation is different
base/file_util_posix.cc:
- Use file_util::GetTempDir directly to get the shm dir
on !linux
base/sys_info_freebsd.cc:
- return 0 and do a NOTREACHED() in case sysctlbyname() fails
base/sys_info_openbsd.cc:
- cleanup includes
- use arraysize() in the sysctl() call
- implement SysInfo::MaxSharedMemorySize()
build/common.gypi:
- -Wno-deprecated is C++ only flag so move it to cflags_cc
- Do not exclude linux specific files, dirs on OpenBSD since
90% of it is sharable
base/sys_info_linux.cc:
- DCHECK if the read string is empty
- Use base::StringToInt64() to convert the string
to an int64
- DCHECK if the returned int64 is okay for a size_t
- call NOTREACHED() and return 0 if fails
BUG=
TEST=runs on linux?
Review URL: http://codereview.chromium.org/8382001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Kernels newer than 2.6.32 support TID and PID namespacing where
processes' view of their TIDs and PIDs are not globally unique or
externally meaningful. We have workarounds to find the TID and PID of
the crashing process from outside in the browser process. However, we
were only assuming TID namespacing was happening if PID namespacing
was enabled and the kernel had a bug that was fixed since 2.6.38.
This change causes us to always treat the TID as subject to
namespacing. Our trick to find the TID relies on a procfs feature
added in 2008. We assume if that feature is not yet present that
the TID translation is not necessary.
This fixes the bug where all crashes of non-browser processes on Linux
2.6.38+ (Chrome OS r13+) are unusable (result in
UnspecifiedStackSignature).
BUG=chromium-os:15462
TEST=Do about:crash on 2.6.38 kernel and verify proper tid listed in
MDException block
Review URL: http://codereview.chromium.org/7190019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is my first attempt at contributing, so please tell me where I'm going wrong.
BUG=58409
TEST=
Review URL: http://codereview.chromium.org/6851016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
raw_scoped_refptr_mismatch_checker.h
ref_counted.cc
ref_counted.h
ref_counted_memory.cc
ref_counted_memory.h
ref_counted_unittest.cc
scoped_callback_factory.h
scoped_comptr_win.h
scoped_handle.h
scoped_native_library.cc
scoped_native_library.h
scoped_native_library_unittest.cc
scoped_nsobject.h
scoped_open_process.h
scoped_ptr.h
scoped_ptr_unittest.cc
scoped_temp_dir.cc
scoped_temp_dir.h
scoped_temp_dir_unittest.cc
scoped_vector.h
singleton.h
singleton_objc.h
singleton_unittest.cc
linked_ptr.h
linked_ptr_unittest.cc
weak_ptr.cc
weak_ptr.h
weak_ptr_unittest.cc
BUG=None
TEST=Compile
Review URL: http://codereview.chromium.org/6714032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the base namespace. Fix several files including lock.h unnecessarily.
BUG=none
TEST=none
Original review=http://codereview.chromium.org/6142009/
Patch by leviw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton.
This primarily covers files in chrome os and other directories, missed in the previous CL.
In a couple of files i changed Singleton<T> usage to LazyInstance<T>, because changing the method name to GetInstance() in there would require a whole lot of updates throughout the chrome os codebase.
BUG=65298
TEST=all existing tests should pass.
Review URL: http://codereview.chromium.org/5734002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3358014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Mac and Linux, keep the client id in a global variable kept by the
child_process_logging implementations. This allows to read it in a
thread safe fashion when starting a child process.
Also replace std::string with statically allocated buffers for the
various items we add to the crash reports. This allows to properly
handle crashes upon shutdown (std::string would run its destructor,
invalidating the memory).
BUG=53231
TEST=Crash reporting should still work
Review URL: http://codereview.chromium.org/3186028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now EnvVarGetter do much more than getting environment variables.
Per suggestion from Pawel in http://codereview.chromium.org/3043018/.
BUG=None
TEST=trybots
Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: http://codereview.chromium.org/3052034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=48997
TEST=Google Chrome gets valid crash reports for about:crash most of the time.
Review URL: http://codereview.chromium.org/2961008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
from sprewell
Review URL: http://codereview.chromium.org/2058004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This allows the shared code to build on the BSDs without
them needing to build _linux files.
Review URL: http://codereview.chromium.org/1701005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Hardy, the DESKTOP_SESSION environment variable is "xfce4" but on Karmic,
it is "xfce"
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1572042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
rename it EnvVarGetter. Label base::SysInfo::{Get,Has}EnvVar as deprecated.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1606007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will regress default startup time for users by 50ms. This doesn't matter
because this is what the users want--I've lost count of the number bloggers,
people on twitter, and people in our IRC channel complaining about the lack of
GTK+ integration...when it's just not on by default.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1442001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
where applicable, missing includes, etc)
Review URL: http://codereview.chromium.org/774001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
than Chromium specific, and clean up a few headers.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/449048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=25938
TEST=try to configure proxy settings on KDE4 when $DESKTOP_SESSION=kde, it should work
Review URL: http://codereview.chromium.org/427013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
base/linux_util.cc. Reimplement FileDescriptorGetInode().
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/312002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=With crash reporting enabled, renderer process command line doesn't have a trailing '?' in the --enable-crash-reporter switch value.
Review URL: http://codereview.chromium.org/307027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/303018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the distro. On Chrome OS, we don't need to do this.
Review URL: http://codereview.chromium.org/285013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=24659
TEST=none
Review URL: http://codereview.chromium.org/273026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28785 0039d316-1c4b-4281-b951-d872f2087c98
|