summaryrefslogtreecommitdiffstats
path: root/base/linux_util.cc
Commit message (Collapse)AuthorAgeFilesLines
* Remove SCM_CREDENTIALS fallback code from breakpadmdempsky@chromium.org2014-05-141-121/+0
| | | | | | | | | | | | | | | | | | Since r266618, we require SCM_CREDENTIALS to work correctly across PID namespaces, and refuse to run on kernels where it doesn't. Reland of r270173. The original attempt failed to update kControlMsgSize, which caused failures like this one: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/5169 This is only noticed on 32-bit machines because CMSG_SPACE(sizeof(int)) happens to equal CMSG_SPACE(2*sizeof(int)) on x86-64 due to structure padding and alignment, but they're different on i386. Review URL: https://codereview.chromium.org/271703012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270367 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 270173 "Remove SCM_CREDENTIALS fallback code from breakpad"piman@chromium.org2014-05-141-0/+121
| | | | | | | | | | | | | | | | | | | build break: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/5169/steps/browser_tests/logs/CDMExpectedCrash > Remove SCM_CREDENTIALS fallback code from breakpad > > Since r266618, we require SCM_CREDENTIALS to work correctly across PID > namespaces, and refuse to run on kernels where it doesn't. > > NOTRY=true > > Review URL: https://codereview.chromium.org/283643004 TBR=mdempsky@chromium.org Review URL: https://codereview.chromium.org/275913003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270277 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded kFindInodeSwitchmdempsky@chromium.org2014-05-131-2/+0
| | | | | | | | | | The last use was removed in r269530. BUG=357670 Review URL: https://codereview.chromium.org/288463002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270179 0039d316-1c4b-4281-b951-d872f2087c98
* Remove SCM_CREDENTIALS fallback code from breakpadmdempsky@chromium.org2014-05-131-121/+0
| | | | | | | | | | | Since r266618, we require SCM_CREDENTIALS to work correctly across PID namespaces, and refuse to run on kernels where it doesn't. NOTRY=true Review URL: https://codereview.chromium.org/283643004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270173 0039d316-1c4b-4281-b951-d872f2087c98
* Move TrimWhitespace to the base namespace.brettw@chromium.org2014-03-031-1/+1
| | | | | | | | R=viettrungluu@chromium.org, viettrungluu Review URL: https://codereview.chromium.org/183853011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254521 0039d316-1c4b-4281-b951-d872f2087c98
* Move Posix file utils to the base namespace.brettw@chromium.org2013-11-271-2/+1
| | | | | | | | | BUG= R=rvargas@chromium.org Review URL: https://codereview.chromium.org/89523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237642 0039d316-1c4b-4281-b951-d872f2087c98
* Update include paths in base for base/process changes.rsesek@chromium.org2013-07-251-1/+1
| | | | | | | | | | | | | | This also updates any stragglers that I missed, fixes mistakes I may have made, and deletes the forwarding headers. After this CL, the proces_util.h project is complete. BUG=242290 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/20265004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213702 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in base/.avi@chromium.org2013-06-101-1/+1
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16667013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205261 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: Fix errors when building android with coverage=1 ilevy@chromium.org2013-06-061-1/+1
| | | | | | | | | | | | | | | Originally landed in r204547 Reverted in r204553 due to cq anomaly. Android builds with coverage=1 fail due to uninitialized variable warnings in base/linux_util.cc and base/net/net_util.cc BUG=245467 TBR=willchan Review URL: https://chromiumcodereview.appspot.com/16589002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204662 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 204556 "Fix errors when building android with coverage=1"ilevy@chromium.org2013-06-061-1/+1
| | | | | | | | | | | | | | | | | | | CQ anomaly x2. > Fix errors when building android with coverage=1 > > Android builds with coverage=1 fail due to uninitialized variable > warnings in base/linux_util.cc and base/net/net_util.cc > > BUG=245467 > > Review URL: https://chromiumcodereview.appspot.com/16077010 TBR=rwalker@codeaurora.org Review URL: https://codereview.chromium.org/16505004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204562 0039d316-1c4b-4281-b951-d872f2087c98
* Fix errors when building android with coverage=1rwalker@codeaurora.org2013-06-061-1/+1
| | | | | | | | | | | Android builds with coverage=1 fail due to uninitialized variable warnings in base/linux_util.cc and base/net/net_util.cc BUG=245467 Review URL: https://chromiumcodereview.appspot.com/16077010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204556 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 204547 "Fix errors when building android with coverage=1"ilevy@chromium.org2013-06-061-1/+1
| | | | | | | | | | | | | | | | | | | CQ error. Committed without tryjobs. > Fix errors when building android with coverage=1 > > Android builds with coverage=1 fail due to uninitialized variable > warnings in base/linux_util.cc and base/net/net_util.cc > > BUG=245467 > > Review URL: https://chromiumcodereview.appspot.com/16077010 TBR=rwalker@codeaurora.org Review URL: https://codereview.chromium.org/16415008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204553 0039d316-1c4b-4281-b951-d872f2087c98
* Fix errors when building android with coverage=1rwalker@codeaurora.org2013-06-061-1/+1
| | | | | | | | | | | Android builds with coverage=1 fail due to uninitialized variable warnings in base/linux_util.cc and base/net/net_util.cc BUG=245467 Review URL: https://chromiumcodereview.appspot.com/16077010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204547 0039d316-1c4b-4281-b951-d872f2087c98
* base: Convert scoped_arrays to the new scoped_ptr style.tfarina@chromium.org2013-01-181-1/+1
| | | | | | | | | | BUG=109874 R=darin@chromium.org,ajwong@chromium.org Review URL: https://chromiumcodereview.appspot.com/11961021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177670 0039d316-1c4b-4281-b951-d872f2087c98
* Set linux distro to CHROMEOS_RELEASE_DESCRIPTION on ChromeOSrbyers@chromium.org2012-08-151-3/+1
| | | | | | | | | | | | | | | | This makes ChromeOS more consistent with Linux, which uses the DISTRIB_DESCRIPTION from /etc/lsb-release here. We have a different pre-existing mechanism in the code for reading the value (since ChromeOS doesn't have the lsb_release tool), but it's conceptually the same thing. This makes it possible to search / catagorize ChromeOS crash reports based on the build, or other information about the ChromeOS version. It also allows the matching build/symbols to be more easily found given a crash report. There's no need for Aura customization of distro anymore - that was added when Aura was experimental. All ChromeOS is now Aura. BUG=142630 Review URL: https://chromiumcodereview.appspot.com/10827322 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151741 0039d316-1c4b-4281-b951-d872f2087c98
* Create a new SetuidSandboxClient class.jln@chromium.org2012-07-231-5/+0
| | | | | | | | | | | | We move the setuid sandbox "client" code to its own location in /sandbox/linux/suid/client and we create a SetuidSandboxClient class to use it. NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10807059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147993 0039d316-1c4b-4281-b951-d872f2087c98
* Include linux_util for android.nileshagrawal@chromium.org2012-07-181-26/+23
| | | | | | | | | | | | | Android uses linux breakpad (USE_LINUX_BREAKPAD is set) and hence needs base::GetLinuxDistro BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10785008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147158 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Move some const char definitions to the .cc file. (try 2)thestig@chromium.org2012-06-131-4/+11
| | | | | | | | | BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10535141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142013 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 141810 - Cleanup: Move some const char definitions to the .cc file.cpu@chromium.org2012-06-131-8/+1
| | | | | | | | | | | | BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10539099 TBR=thestig@chromium.org Review URL: https://chromiumcodereview.appspot.com/10543130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141823 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Move some const char definitions to the .cc file.thestig@chromium.org2012-06-131-1/+8
| | | | | | | | | BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10539099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141810 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove static storage for variables in an unnamed namespace.jhawkins@chromium.org2012-01-281-1/+1
| | | | | | | | | | BUG=none TEST=none R=binji Review URL: https://chromiumcodereview.appspot.com/9271061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119535 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete usage of TOUCH_UI.saintlou@chromium.org2011-11-231-2/+2
| | | | | | | | | | BUG=105046 TEST=none Review URL: http://codereview.chromium.org/8660001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111287 0039d316-1c4b-4281-b951-d872f2087c98
* Differentiate TOUCH_UI builds in crash reporting.rbyers@chromium.org2011-11-101-1/+3
| | | | | | | | | | | | | | | In TOUCH_UI ChromeOS builds, augment the Linux distro so that crash reports will have lsb-release="CrOS Touch" instead of just "CrOS". This mirrors the change in User-Agent in TOUCH_UI builds as well (see BuildOSCpuInfo() in webkit/glue/user_agent.cc). BUG=chromium-os:22255 TEST=Manual Review URL: http://codereview.chromium.org/8479002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109436 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the remaining exit time destructors from base for linux and chromeos.thakis@chromium.org2011-11-091-3/+3
| | | | | | | | | BUG=101600 TEST=none Review URL: http://codereview.chromium.org/8507022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109309 0039d316-1c4b-4281-b951-d872f2087c98
* Replace most LOG/CHECK statements with DLOG/DCHECK statements in base.brettw@chromium.org2011-10-261-7/+7
| | | | | | | | | | | [ Reland of 107042 http://codereview.chromium.org/8368009 ] I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8341026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107434 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 107042 - Replace most LOG/CHECK statements with DLOG/DCHECK ↵brettw@chromium.org2011-10-251-7/+7
| | | | | | | | | | | | | | statements in base. I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8368009 TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/8351025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107051 0039d316-1c4b-4281-b951-d872f2087c98
* Replace most LOG/CHECK statements with DLOG/DCHECK statements in base.brettw@chromium.org2011-10-251-7/+7
| | | | | | | | | I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8368009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107042 0039d316-1c4b-4281-b951-d872f2087c98
* OpenBSD patches for base and build, part 2robert.nagy@gmail.com2011-10-241-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | base/base.gyp: - exclude test/test_file_util_linux.cc on OpenBSD because of missing fdatasync() base/base.gypi: - include linux_util.cc on OpenBSD too - exclude some linux specific files from the OpenBSD build because the openbsd implementation is different base/file_util_posix.cc: - Use file_util::GetTempDir directly to get the shm dir on !linux base/sys_info_freebsd.cc: - return 0 and do a NOTREACHED() in case sysctlbyname() fails base/sys_info_openbsd.cc: - cleanup includes - use arraysize() in the sysctl() call - implement SysInfo::MaxSharedMemorySize() build/common.gypi: - -Wno-deprecated is C++ only flag so move it to cflags_cc - Do not exclude linux specific files, dirs on OpenBSD since 90% of it is sharable base/sys_info_linux.cc: - DCHECK if the read string is empty - Use base::StringToInt64() to convert the string to an int64 - DCHECK if the returned int64 is okay for a size_t - call NOTREACHED() and return 0 if fails BUG= TEST=runs on linux? Review URL: http://codereview.chromium.org/8382001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106984 0039d316-1c4b-4281-b951-d872f2087c98
* Always search TIDs for the crashing processes.kmixter@chromium.org2011-06-211-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | Kernels newer than 2.6.32 support TID and PID namespacing where processes' view of their TIDs and PIDs are not globally unique or externally meaningful. We have workarounds to find the TID and PID of the crashing process from outside in the browser process. However, we were only assuming TID namespacing was happening if PID namespacing was enabled and the kernel had a bug that was fixed since 2.6.38. This change causes us to always treat the TID as subject to namespacing. Our trick to find the TID relies on a procfs feature added in 2008. We assume if that feature is not yet present that the TID translation is not necessary. This fixes the bug where all crashes of non-browser processes on Linux 2.6.38+ (Chrome OS r13+) are unusable (result in UnspecifiedStackSignature). BUG=chromium-os:15462 TEST=Do about:crash on 2.6.38 kernel and verify proper tid listed in MDException block Review URL: http://codereview.chromium.org/7190019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89795 0039d316-1c4b-4281-b951-d872f2087c98
* Replacing outdated DCHECK(a == b) with DCHECK_EQ(a, b).david.mike.futcher@gmail.com2011-04-181-1/+1
| | | | | | | | | | | | | This is my first attempt at contributing, so please tell me where I'm going wrong. BUG=58409 TEST= Review URL: http://codereview.chromium.org/6851016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81988 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete base/lock.h and fix up callers to use the new header file andbrettw@chromium.org2011-01-211-4/+4
| | | | | | | | | | | the base namespace. Fix several files including lock.h unnecessarily. BUG=none TEST=none Original review=http://codereview.chromium.org/6142009/ Patch by leviw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
* Rename all methods accessing Singleton<T> as GetInstance().satish@chromium.org2010-12-131-2/+2
| | | | | | | | | | | | | | | This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton. This primarily covers files in chrome os and other directories, missed in the previous CL. In a couple of files i changed Singleton<T> usage to LazyInstance<T>, because changing the method name to GetInstance() in there would require a whole lot of updates throughout the chrome os codebase. BUG=65298 TEST=all existing tests should pass. Review URL: http://codereview.chromium.org/5734002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69007 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup some duplicated includes.tfarina@chromium.org2010-09-041-1/+0
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3358014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58582 0039d316-1c4b-4281-b951-d872f2087c98
* Make crash reporting client_id accessible through child_process_logging.mnissler@chromium.org2010-08-261-6/+14
| | | | | | | | | | | | | | | | | | On Mac and Linux, keep the client id in a global variable kept by the child_process_logging implementations. This allows to read it in a thread safe fashion when starting a child process. Also replace std::string with statically allocated buffers for the various items we add to the crash reports. This allows to properly handle crashes upon shutdown (std::string would run its destructor, invalidating the memory). BUG=53231 TEST=Crash reporting should still work Review URL: http://codereview.chromium.org/3186028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57497 0039d316-1c4b-4281-b951-d872f2087c98
* base: Rename EnvVarGetter to Environment.tfarina@chromium.org2010-08-031-1/+0
| | | | | | | | | | | | | | | Now EnvVarGetter do much more than getting environment variables. Per suggestion from Pawel in http://codereview.chromium.org/3043018/. BUG=None TEST=trybots Signed-off-by: Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/3052034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54696 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Guess the thread id for crashing renderers in a different PID namespace.thestig@chromium.org2010-07-161-0/+47
| | | | | | | | BUG=48997 TEST=Google Chrome gets valid crash reports for about:crash most of the time. Review URL: http://codereview.chromium.org/2961008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52723 0039d316-1c4b-4281-b951-d872f2087c98
* Move non-linux specific code from base/linux_util to app/gtk_utilpvalchev@google.com2010-05-131-20/+0
| | | | | | | | from sprewell Review URL: http://codereview.chromium.org/2058004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47201 0039d316-1c4b-4281-b951-d872f2087c98
* bsd: refactor XDG bits of linux_util into a shared file.evan@chromium.org2010-04-221-87/+0
| | | | | | | | | This allows the shared code to build on the BSDs without them needing to build _linux files. Review URL: http://codereview.chromium.org/1701005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45380 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Improve xfce detection.erg@chromium.org2010-04-151-5/+5
| | | | | | | | | | | | On Hardy, the DESKTOP_SESSION environment variable is "xfce4" but on Karmic, it is "xfce" BUG=none TEST=none Review URL: http://codereview.chromium.org/1572042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44698 0039d316-1c4b-4281-b951-d872f2087c98
* Move EnvironmentVariableGetter from base/linux_util.h to base/env_var.h and ↵thestig@chromium.org2010-04-031-53/+17
| | | | | | | | | | rename it EnvVarGetter. Label base::SysInfo::{Get,Has}EnvVar as deprecated. BUG=none TEST=none Review URL: http://codereview.chromium.org/1606007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43559 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Turn on the GTK+ integration by default.erg@chromium.org2010-03-261-0/+4
| | | | | | | | | | | | | | This will regress default startup time for users by 50ms. This doesn't matter because this is what the users want--I've lost count of the number bloggers, people on twitter, and people in our IRC channel complaining about the lack of GTK+ integration...when it's just not on by default. BUG=none TEST=none Review URL: http://codereview.chromium.org/1442001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42804 0039d316-1c4b-4281-b951-d872f2087c98
* BSD port changes for base/ (OS_POSIX/GTK instead of OS_LINUXpvalchev@google.com2010-03-101-1/+3
| | | | | | | | where applicable, missing includes, etc) Review URL: http://codereview.chromium.org/774001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41143 0039d316-1c4b-4281-b951-d872f2087c98
* Move some XDG code from chrome to base, make DIR_USER_CACHE generic rather ↵thestig@chromium.org2009-12-021-1/+39
| | | | | | | | | | than Chromium specific, and clean up a few headers. BUG=none TEST=none Review URL: http://codereview.chromium.org/449048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33565 0039d316-1c4b-4281-b951-d872f2087c98
* Properly detect KDE4 on newer systems (e.g. [K]Ubuntu 9.04).mdm@chromium.org2009-11-251-1/+6
| | | | | | | | BUG=25938 TEST=try to configure proxy settings on KDE4 when $DESKTOP_SESSION=kde, it should work Review URL: http://codereview.chromium.org/427013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33132 0039d316-1c4b-4281-b951-d872f2087c98
* Move FileDescriptorGetInode() and FindProcessHoldingSocket() into ↵thestig@chromium.org2009-10-291-0/+126
| | | | | | | | | | base/linux_util.cc. Reimplement FileDescriptorGetInode(). BUG=none TEST=none Review URL: http://codereview.chromium.org/312002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30433 0039d316-1c4b-4281-b951-d872f2087c98
* Trim the lsb_release output in GetLinuxDistro.thestig@chromium.org2009-10-211-1/+3
| | | | | | | | BUG=none TEST=With crash reporting enabled, renderer process command line doesn't have a trailing '?' in the --enable-crash-reporter switch value. Review URL: http://codereview.chromium.org/307027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29718 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify GetLinuxDistro() for Chrome OS.thestig@chromium.org2009-10-211-5/+13
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/303018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29682 0039d316-1c4b-4281-b951-d872f2087c98
* On Linux, Chrome uses lsb_release (a python script) to determine the name of ↵cmasone@google.com2009-10-191-0/+4
| | | | | | | | the distro. On Chrome OS, we don't need to do this. Review URL: http://codereview.chromium.org/285013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29405 0039d316-1c4b-4281-b951-d872f2087c98
* Make GetLinuxDistro thread-safe.thestig@chromium.org2009-10-131-8/+61
| | | | | | | | BUG=24659 TEST=none Review URL: http://codereview.chromium.org/273026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28785 0039d316-1c4b-4281-b951-d872f2087c98