summaryrefslogtreecommitdiffstats
path: root/base/logging.cc
Commit message (Collapse)AuthorAgeFilesLines
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-111-4/+4
| | | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70920 Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70977 0039d316-1c4b-4281-b951-d872f2087c98
* Order function definitions in base/ according to the header.erg@google.com2011-01-111-53/+53
| | | | | | | | | BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6085015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70975 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70920 - Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-101-4/+4
| | | | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Review URL: http://codereview.chromium.org/6070006 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/6099012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70923 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-101-4/+4
| | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70920 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70782 - Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-071-4/+4
| | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Review URL: http://codereview.chromium.org/6070006 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/6100007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70783 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-071-4/+4
| | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70782 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/lock and base/condition_variable to base/synchronization/brettw@chromium.org2011-01-011-4/+4
| | | | | | | | | | | I kept a base/lock.h in place with a using statement to avoid updating all callers in one CL. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6018013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70363 0039d316-1c4b-4281-b951-d872f2087c98
* Print out filename on logs instead of the entire pathakalin@chromium.org2010-12-231-1/+1
| | | | | | | | | | | This probably regressed from a merge. BUG=None TEST=Manual Review URL: http://codereview.chromium.org/5996004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70013 0039d316-1c4b-4281-b951-d872f2087c98
* linux: remove the xmessage-based error dialogevan@chromium.org2010-12-161-17/+5
| | | | | | | | | | | | Since this is for developers only, developers use the console anyway. The dialog is cute but superfluous and actually kind of annoying. BUG=37026 Review URL: http://codereview.chromium.org/5905005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69484 0039d316-1c4b-4281-b951-d872f2087c98
* Add Debug Message Dialog Support for Mac OSdmaclach@chromium.org2010-12-141-3/+13
| | | | | | | | | BUG=37026 TEST=NONE Review URL: http://codereview.chromium.org/5804004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69138 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid recursive DisplayDebugMessageInDialog call when an assert is hit on ↵joth@chromium.org2010-12-071-0/+4
| | | | | | | | | | | the IO thread BUG=None TEST=Hacked code to call NOTREACHED() from IO thread. Review URL: http://codereview.chromium.org/5614003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68468 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed logging so that vmodule works correctly againakalin@chromium.org2010-11-231-6/+0
| | | | | | | | | | | | | | Removed extraneous check in LogMessage destructor; all the checks are now done before LogMessage is created. Removed useless warning if --vmodule is used but --v is not. BUG=None TEST=Manual Review URL: http://codereview.chromium.org/5329001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67131 0039d316-1c4b-4281-b951-d872f2087c98
* Bring up IPC in NaCl.abarth@chromium.org2010-11-121-0/+11
| | | | | | | | | | | | This patch gets a bunch of the IPC and Base libraries compiling (but not linking) in NaCl. There's obviously a bunch more work to do, but this patch is a starting point. Original patch by Eric Seidel. Review URL: http://codereview.chromium.org/4812002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65920 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate ETW with VLOG logging.siggi@chromium.org2010-11-041-10/+22
| | | | | | | | | | | | | This change extends the log severities into the negative for VLOG verbosities. It also keeps track of file/line information and passes it to any registered log handler. The log level is naturally controlled by translating ETW log levels to the severities. BUG=none TEST=none Review URL: http://codereview.chromium.org/4164011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65062 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the testing::LogDisabler for the change r64883. See ↵hansl@google.com2010-11-031-0/+4
| | | | | | | | | | | | | http://codereview.chromium.org/4262001/show The r64883 broke most unit tests in CEEE that relied on disabling logs while testing error paths. BUG=None TEST=None Review URL: http://codereview.chromium.org/4390001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64948 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed bug where CHECKs don't fire if min_log_level > FATALakalin@chromium.org2010-11-031-1/+1
| | | | | | | | | BUG=61510 TEST=New unittests in base_unittests Review URL: http://codereview.chromium.org/4262001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64883 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed bug where the entire file path was being printed for logs on non-Windowsakalin@chromium.org2010-10-291-5/+5
| | | | | | | | | BUG=None TEST=Manual Review URL: http://codereview.chromium.org/4215003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64345 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes the logging for ChromeOS so that it uses symlinksgspencer@chromium.org2010-10-281-3/+3
| | | | | | | | | | | | | | | | | | | | | | | to log to instead of going to the timestamped files directly, so that the browser process can more precisely control the output file being used. It still creates timestamped logs, and the regular chrome operations should be unchanged. Added a bool return value to InitLogging so we know when it fails, because failing needs to be handled properly in ChromeOS to remove hanging symbolic links. [This change has already been reviewed and approved here: http://codereview.chromium.org/3983004/show Somehow the dcommit failed without me noticing, so I'm trying again.] BUG=http://crosbug.com/6343 TEST=ran on device in incognito and regular mode, looked at logs. Review URL: http://codereview.chromium.org/4167004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64184 0039d316-1c4b-4281-b951-d872f2087c98
* Move debug-related stuff from base to the base/debug directory and use thebrettw@chromium.org2010-10-261-7/+8
| | | | | | | | | | | | | | | | base::debug namespace. This splits apart debug_util into base/debugger and base/stack_trace There are still two functions in debug_util that I'm not sure what to do with. Since this uses the base::debug namespace, I removed the functions in debugger.h from the static class and just made them free functions in the namespace. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3945002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63859 0039d316-1c4b-4281-b951-d872f2087c98
* Two minor changes to the use of FormatMessageA in Win32ErrorLogMessage:grt@chromium.org2010-10-201-2/+2
| | | | | | | | | | | | - Follow the MSDN advice and use FORMAT_MESSAGE_IGNORE_INSERTS to avoid security issues and to prevent getting back ERROR_INVALID_PARAMETER for any message that has inserts. This is always the right thing since this function provides no arguments for inserts. - Don't specify a language identifier, thereby allowing FormatMessageA to make many sensible attempts to find a string in some suitable language. BUG=none TEST=none Review URL: http://codereview.chromium.org/3888001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63166 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging macros evaluate its stream arguments lazily.akalin@chromium.org2010-10-011-2/+3
| | | | | | | | | | | | | | | Also added logging unittests. BUG=57383 TEST=logging_unittest.cc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61127 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61142 Review URL: http://codereview.chromium.org/3575008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61249 0039d316-1c4b-4281-b951-d872f2087c98
* Solved a problem where a string was supposed to be passed as a reference but ↵hansl@google.com2010-10-011-12/+22
| | | | | | | | | | | | was instead passed by value. Also, if CreateMutex returns NULL (for the lock), try to call the Debugger and return nicely. TEST=none BUG=none Review URL: http://codereview.chromium.org/3589002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61191 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 61142 - Made logging macros evaluate its stream arguments lazily.akalin@chromium.org2010-10-011-3/+2
| | | | | | | | | | | | | | | | Also added logging unittests. BUG=57383 TEST=logging_unittest.cc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61127 Review URL: http://codereview.chromium.org/3575008 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/3527004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61143 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging macros evaluate its stream arguments lazily.akalin@chromium.org2010-10-011-2/+3
| | | | | | | | | | | | | Also added logging unittests. BUG=57383 TEST=logging_unittest.cc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61127 Review URL: http://codereview.chromium.org/3575008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61142 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 61127 - Made logging macros evaluate its stream arguments lazily.akalin@chromium.org2010-09-301-3/+2
| | | | | | | | | | | | | | Also added logging unittests. BUG=57383 TEST=logging_unittest.cc Review URL: http://codereview.chromium.org/3575008 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/3606003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61129 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging macros evaluate its stream arguments lazily.akalin@chromium.org2010-09-301-2/+3
| | | | | | | | | | | Also added logging unittests. BUG=57383 TEST=logging_unittest.cc Review URL: http://codereview.chromium.org/3575008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61127 0039d316-1c4b-4281-b951-d872f2087c98
* Mark the most common uses of MakeCheckOpString as extern templates on gcc ↵erg@google.com2010-09-301-0/+14
| | | | | | | | | | | | | | platforms. Remove broken template specializations that were never instantiated that references extern code that doesn't exist in the project (!). BUG=none TEST=compiles, smaller binaries on linux, chromeos and mac Review URL: http://codereview.chromium.org/3594003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61092 0039d316-1c4b-4281-b951-d872f2087c98
* Removed support for log prefix filters.akalin@chromium.org2010-09-301-19/+0
| | | | | | | | | | | No one is using this, and this is obsoleted by --vmodule. BUG=56965 TEST=None Review URL: http://codereview.chromium.org/3596003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61035 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented VLOG() et al.akalin@chromium.org2010-09-291-1/+22
| | | | | | | | | | | | | | Implemented VLOG(), VLOG_IF(), VLOG_IS_ON(). Added --v and --vmodule switches. Changed some spammy sync-related logs to use VLOG. BUG=56965 TEST=New unittests Review URL: http://codereview.chromium.org/3448028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60976 0039d316-1c4b-4281-b951-d872f2087c98
* Include log output in buildbot logs on Windows just as darin@chromium.org2010-09-241-15/+2
| | | | | | | | | | | | | we do on Linux and Mac. This can be very helpful when trying to debug flaky tests. R=erikkay BUG=none TEST=none Review URL: http://codereview.chromium.org/3435027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60472 0039d316-1c4b-4281-b951-d872f2087c98
* Lock log files when reiniting them.davemoore@chromium.org2010-09-141-100/+148
| | | | | | | | | | | | This is a second attempt of this cl: http://codereview.chromium.org/3195014/show BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/3347016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59439 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58074 - Lock all access to logging data, in case it's reinitializeddavemoore@chromium.org2010-08-311-148/+100
| | | | | | | | | | | Review URL: http://codereview.chromium.org/3195014 TBR=davemoore@chromium.org Problems with IE tests for ChromeFrame and heapcheck. Review URL: http://codereview.chromium.org/3229012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58079 0039d316-1c4b-4281-b951-d872f2087c98
* Lock all access to logging data, in case it's reinitializeddavemoore@chromium.org2010-08-311-100/+148
| | | | | | Review URL: http://codereview.chromium.org/3195014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58074 0039d316-1c4b-4281-b951-d872f2087c98
* base: Disallow mixing NDEBUG settings in logging.{h,cc}.derat@chromium.org2010-08-231-4/+4
| | | | | | | | | | | | | | | | | | | I am concerned about the possibility that other users of the files in Chrome's base/ directory (e.g. Chrome OS) may build a library from these files with NDEBUG defined and then link it into a binary that includes the headers without defining NDEBUG, or vice versa. This change mangles InitLogging()'s name in logging.h based on whether NDEBUG is defined so that linking will fail if there's a mismatch (Evan provided useful advice here). BUG=chromium-os:1124 TEST=built Debug and Release Chrome, built all Chrome OS packages, and then changed a Chrome OS package that links against libbase.a to define NDEBUG and checked that it failed to link Review URL: http://codereview.chromium.org/3106032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57098 0039d316-1c4b-4281-b951-d872f2087c98
* Header cleanup in base.brettw@chromium.org2010-08-171-2/+1
| | | | | | | | | | | | | | This makes uses of StringPrintf and friends use the base namespace and include stringprintf.h explicitly. This also removes a bunch of unnecessary string_util includes (which exposed a few other errors like people forgetting to include <vector>. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3119022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56446 0039d316-1c4b-4281-b951-d872f2087c98
* Stop eternal loop in DisplayDebugMessageInDialogcmasone@google.com2010-08-171-2/+9
| | | | | | | | | | | | | | | | if CommandLine was never initialized, CommandLine::ForCurrentProcess() will DCHECK. That causes DisplayDebugMessageInDialog() to run...which calls CommandLine::ForCurrentProcess(), which can DCHECK. Also, Chrome OS doesn't have xmessage, so we don't want to try to pop up a message using that mechanism. BUG=None TEST=Run a binary that doesn't initialize CommandLine (a chrome os unittest binary, for example) and make it CHECK(false). Instead of looping until the stack explodes, it should print messages for the check failures and exit. Review URL: http://codereview.chromium.org/3151016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56281 0039d316-1c4b-4281-b951-d872f2087c98
* Including pthread.h, compile fix for Android.bulach@chromium.org2010-08-051-0/+1
| | | | | | | | | pthread.h does not get including through the other include files on Android. Original change: http://codereview.chromium.org/2808076/show, landing on behalf of Kristian. Review URL: http://codereview.chromium.org/3007034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55069 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Ensure that when we're testing the logging system will not display ↵phajdan.jr@chromium.org2010-07-291-0/+3
| | | | | | | | | | | | | | | dialogs. When I was running ui_tests on Linux at the end there were to xmessage windows on the screen. They shouldn't be there, and they might gum up the bots, especially if it happens on Windows. TEST=none BUG=none Review URL: http://codereview.chromium.org/2847085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54180 0039d316-1c4b-4281-b951-d872f2087c98
* print stack trace to stderr as well as to dialog.oshima@chromium.org2010-03-241-12/+10
| | | | | | | | | | | Stacktrace info was shown only in dialog, and chromeos was not getting this as it does not have xmessage. Changed to include stacktrace to the log message before being printed to stderr. BUG=none TEST=none Review URL: http://codereview.chromium.org/1094012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42431 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an unused logging function.thestig@chromium.org2010-03-111-10/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/862002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41325 0039d316-1c4b-4281-b951-d872f2087c98
* linux: use xmessage for the dialog used in LOG(FATAL)evan@chromium.org2010-03-011-13/+24
| | | | | | | | | | | | The previous code printed to stderr, but since the logging code already had logged to stderr we'd end up printing the message twice, which was making me nervous. BUG=29997,31243,37026 Review URL: http://codereview.chromium.org/660269 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40271 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "linux: use xmessage for the dialog used in LOG(FATAL)"evan@chromium.org2010-03-011-24/+13
| | | | | | This reverts commit r40261. Test breakage. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40262 0039d316-1c4b-4281-b951-d872f2087c98
* linux: use xmessage for the dialog used in LOG(FATAL)evan@chromium.org2010-03-011-13/+24
| | | | | | | | | | | | The previous code printed to stderr, but since the logging code already had logged to stderr we'd end up printing the message twice, which was making me nervous. BUG=31243,37026 Review URL: http://codereview.chromium.org/661260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40261 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to base/ from a combination of FreeBSD and OpenBSD patches.evan@chromium.org2009-12-291-3/+6
| | | | | | Review URL: http://codereview.chromium.org/495002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35321 0039d316-1c4b-4281-b951-d872f2087c98
* Make POSIX SIGTERM/SIGINT/SIGHUP handler async signal safe.willchan@chromium.org2009-12-081-0/+37
| | | | | | | | | | * Don't use LOG/CHECK. Replace with RAW_LOG/DCHECK (newly added to logging.h) * Don't directly post a task to the UI loop. Write to a magic pipe. Read this from a separate thread which will post to a task to the UI loop. BUG=http://crbug.com/29240 Review URL: http://codereview.chromium.org/460094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34036 0039d316-1c4b-4281-b951-d872f2087c98
* Flush logging output.derat@chromium.org2009-12-021-11/+18
| | | | | | | | | | | It gets buffered otherwise, which is inconvenient when trying to follow what's going on in the Chrome OS window manager. TEST=compiled and ran it Review URL: http://codereview.chromium.org/459001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33520 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate the base logging with Event Tracing for Windows. This allows ETW ↵siggi@chromium.org2009-11-251-0/+10
| | | | | | | | | | | to control the log level and log feature flags from outside the process, and all log messages can be transported into ETW trace sessions.As is this provides an event trace provider class thatmanages the log level on control callbacks and shunts the formatted log messages to ETW when warranted.The provider observes one feature flag, which when turned on causes it to capture and log a stack trace at the log site, which can be helpful when diagnosing errors from logs.This CL also initializes ETW logging for chrome.dll, but only if the environment variable "CHROME_ETW_LOGGING" is set. The ETW machinery may create a thread in every process registering a trace provider, and the environment variable makes this overhead optional. TEST=Unittests in this change BUG=none Review URL: http://codereview.chromium.org/413006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33066 0039d316-1c4b-4281-b951-d872f2087c98
* Add logging macros that automatically append the last system error in string ↵tschmelcher@chromium.org2009-10-091-0/+92
| | | | | | | | | | | | | form. Also add thread-safe, portable variants for strerror() and strerror_r() on POSIX so that existing error logging code that calls strerror() for something other than LOG, LOG_IF, or CHECK can be changed to use safe versions too. After this CL I will eliminate all unsafe uses of strerror() in our code. TEST=Linux: tested PLOG and DPLOG with both a valid error and invalid error on a dbg build with both the default strerror_r implementation (GNU) and the other one (POSIX) via some throw-away macro evilness, and also tested the default strerror_r again on an opt build to verify DPLOG is a no-op; Windows: tested PLOG and DPLOG with both a valid error and invalid error on a dbg build; also tested LOG_GETLASTERROR_MODULE with winhttp and ERROR_WINHTTP_CANNOT_CONNECT and verified that it prints the correct system message and that it doesn't with PLOG; also tested LOG_GETLASTERROR_MODULE with a bogus module name and verified that it prints an error that it can't find the module, and the original error; Mac: none (implicitly tested via the Linux POSIX tests); trybots for Win, Mac, and Linux 32-bit; built locally for Linux 32-bit and 64-bit and tested base_unittests and also running Chromium itself; wrote the upcoming CL that switches strerror() calls to use PLOG and verified that it builds and works for both Linux 32-bit and Linux 64-bit; lint BUG=none Review URL: http://codereview.chromium.org/265052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28632 0039d316-1c4b-4281-b951-d872f2087c98
* Copy the relevant parts of ICU to a new file base/third_party/icu/icu_utf.*brettw@chromium.org2009-10-071-3/+3
| | | | | | | | | | | | | | so we can do basic UTF8/16/32 conversions without linking all of ICU. Change callers who used to call SysUTF8ToWide/SysWideToUTF8 in base to using these new functions. I will remove the Sys versions of these functions in a later patch. TEST=none BUG=none Review URL: http://codereview.chromium.org/243102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28219 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 28166.ojan@chromium.org2009-10-061-195/+0
| | | | | | Review URL: http://codereview.chromium.org/242167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28170 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 00:20:25 +0000