summaryrefslogtreecommitdiffstats
path: root/base/logging.h
Commit message (Collapse)AuthorAgeFilesLines
* Remove two unused logging::LogMessage constructors.viettrungluu@chromium.org2014-06-181-22/+4
| | | | | | | | | | | (We could probably also get rid of a third one, namely the one used by CHECK_EQ, etc. But I'd do that separately.) R=brettw@chromium.org Review URL: https://codereview.chromium.org/340573005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278066 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the LOG_ERROR_REPORT log severity level.viettrungluu@chromium.org2014-06-171-27/+8
| | | | | | | | | | | | | | | It's been unused since r255987 (which removed the --enable-dcheck flag, among other things). Also remove the --silent-dump-on-dcheck flag (because now there's not even code that pretends to use it). R=brettw@chromium.org,sky@chromium.org BUG=352378 Review URL: https://codereview.chromium.org/331143007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277736 0039d316-1c4b-4281-b951-d872f2087c98
* Removed LOG_GETLASTERROR and LOG_ERRNO macros.vitalybuka@chromium.org2014-05-211-9/+0
| | | | | | | | | | | Most code uses PLOG with the same effect. TBR=bradchen NOTRY=true Review URL: https://codereview.chromium.org/281223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271949 0039d316-1c4b-4281-b951-d872f2087c98
* Extracted logging::SystemErrorCodeToString function.vitalybuka@chromium.org2014-04-231-37/+12
| | | | | | | | | | | | Allows to use any errors, and particularly useful for logging HRESULT on Windows. Included error code on windows into error message. Removed unused LOG_GETLASTERROR_MODULE logging macros. Review URL: https://codereview.chromium.org/244583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265460 0039d316-1c4b-4281-b951-d872f2087c98
* Change DCHECK_IS_ON() to DCHECK_IS_ONwangxianzhu@chromium.org2014-03-141-15/+11
| | | | | | | | | | | | | | | DCHECK_IS_ON has been a constant since r255987, and can be used in both if() and #if. It no more needs to be in function form. Converted 'if (DCHECK_IS_ON)' to '#if DCHECK_IS_ON' if proper. BUG=350462 TEST=build TBR=darin Review URL: https://codereview.chromium.org/195973002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257156 0039d316-1c4b-4281-b951-d872f2087c98
* Let DCHECK in non-official-release build be opt-in with dcheck_always_on=1 onlywangxianzhu@chromium.org2014-03-101-68/+8
| | | | | | | | | | | | | | | | | | | | | | | | | - Remove DCHECK in non-official-release build by default - Gyp variable dcheck_always_on=1 (existing) forces to enable DCHECK in release build - Remove flag --enable-dcheck Other effects/notes: - Now allow "buildtype=Official dcheck_always_on=1" (which will enable DCHECK in official build) combination. - Gyp variable logging_like_official_build no longer has an effect - Leave DCHECK_IS_ON() unchanged. May deal with it in a later change if needed. This won't affect bots which use dcheck_always_on=1. BUG=350462 TEST=LoggingTest.Dcheck R=thakis@chromium.org TBR=darin,sehr (command line changes in components/nacl and mojo) Review URL: https://codereview.chromium.org/189603007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255987 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid function call for disabled DCHECK in non-official release buildwangxianzhu@chromium.org2014-03-051-6/+7
| | | | | | | | | | | | | | | | | | | | Previously each disabled DCHECK in non-official release build needs to call a function. This change avoids the cost of the function call. Now on x86, assembly code of a DCHECK is like the following: mov g_dcheck_state,%rax cmpl $0x1,(%rax) je dcheck_enabled # normal code ... dcheck_enabled: ... BUG=none Review URL: https://codereview.chromium.org/186963004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254909 0039d316-1c4b-4281-b951-d872f2087c98
* Documentation fix - Delete meaningless paragraph.girard@chromium.org2014-01-211-4/+0
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/135903010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246106 0039d316-1c4b-4281-b951-d872f2087c98
* Log an error in release builds when NOTREACHED is hit in ChromiumOS builds. ↵zork@chromium.org2013-09-261-0/+5
| | | | | | | | | | This data can be collected on ChromiumOS when the user consents to it; this should help us collect more data about what shouldn't be happening in prod that happens anyways. BUG=288014 Review URL: https://codereview.chromium.org/24313004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225383 0039d316-1c4b-4281-b951-d872f2087c98
* Define a LoggingSettings struct to use for InitLogging()akalin@chromium.org2013-06-211-30/+52
| | | | | | | | | | | | | | | | | | Update all callers of InitLogging() to use LoggingSettings, only setting fields that need a non-default value. Turn LoggingDestination enum into a bit field and define add LOG_DEFAULT and LOG_ALL constants. Fix erroneous comment saying that the default was to not lock the log file. BUG=247594 TBR=brettw@chromium.org, cpu@chromium.org, gene@chromium.org, jam@chromium.org, rch@chromium.org, scherkus@chromium.org, sergeyu@chromium.org, sky@chromium.org, tkent@chromium.org, yfriedman@chromium.org, zea@chromium.org Review URL: https://codereview.chromium.org/16519003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207920 0039d316-1c4b-4281-b951-d872f2087c98
* allow unofficial builds with DCHECK and DLOG disabledmostynb@opera.com2013-06-211-2/+10
| | | | | | | | | Previously, it was not possible to produce unofficial builds without DCHECKS and DLOGS. Review URL: https://chromiumcodereview.appspot.com/17165003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207826 0039d316-1c4b-4281-b951-d872f2087c98
* Remving global statics from the headers, so we can split-link.cpu@chromium.org2013-05-211-2/+3
| | | | | | | | | | | | | | The issue is that the split linker has issues with data exports vs function exports currently only function exports are supported. NOTRY=true TBR=brettw,jam TEST=none BUG=237249 Review URL: https://chromiumcodereview.appspot.com/15403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201194 0039d316-1c4b-4281-b951-d872f2087c98
* If OFFICIAL_BUILD is set on any platform, omit DCHECKs in Release mode.jyasskin@chromium.org2013-05-171-5/+1
| | | | | | | | | | | | This allows GYP_DEFINES="branding=Chromium buildtype=Official" to remove DCHECKS on Linux. I haven't tested Mac. BUG=16512 R=mark@chromium.org Review URL: https://codereview.chromium.org/14896010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200905 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that logging works in the GPU process when the --enable-logging and ↵ananta@chromium.org2013-02-271-0/+5
| | | | | | | | | | | | | | | | | | | | --v switches are specified. This stopped working a long time back due to changes made to launch the GPU process under low integrity mode on Vista+ which prevents write up operations on the files. Fix is to add a sandbox policy allowing access to the log file and also pass the user-data-dir to the GPU process. When the GPU process attempts to open the log file our intercepts kick in and broker the call to the browser where the file is opened. I had to add an accessor to the logging code to return the log file name. Fixes bug https://code.google.com/p/chromium/issues/detail?id=178326 BUG=178326 R=jschuh, cpu Review URL: https://chromiumcodereview.appspot.com/12319107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185055 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile breakage when using stream operators when NOTIMPLEMENTED_POLICY=5.miu@chromium.org2013-02-131-3/+5
| | | | | | | | | | | | | | | In logging.h, the NOTIMPLEMENTED_POLICY macro defines the behavior of the NOTIMPLEMENTED() macro. For case 5 (log only once per call-site), code that uses stream output operators would fail to compile. For example, in ui/aura/root_window_host_linux.cc:747: NOTIMPLEMENTED() << "Unsupported bits-per-pixel " << image->bits_per_pixel; The solution is to add EAT_STREAM_PARAMETERS to the end of the definition in base/logging.h. This will log call sites as "not implemented" but will not log the additional custom messages. TEST=Compiled chrome with compiler define set to NOTIMPLEMENTED_POLICY=5 and ran to confirm desired NOTIMPLEMENTED() behaviors. Review URL: https://chromiumcodereview.appspot.com/12221152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182167 0039d316-1c4b-4281-b951-d872f2087c98
* Only define ERROR on windows buildsjoth@chromium.org2013-01-101-0/+2
| | | | | | | | | | | This is to stop people accidentally using the ERROR macro for other uses, e.g. VLOG(ERROR) is not meaningful. BUG= Review URL: https://chromiumcodereview.appspot.com/11669010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175998 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert 147986 - [Android] Add remaining build/common.gypi changes ↵yfriedman@chromium.org2012-07-251-0/+4
| | | | | | | | | | | | | | | | from downstream and strip NOTIMPLEMENTED()s from official builds." Relanding http://codereview.chromium.org/10816039/ but removing the clang parts and fixing x86. This reverts commit 7fc96c8b734fc9bc8152329d99e8ee3f3de14a65. BUG=137569 Review URL: https://chromiumcodereview.appspot.com/10809081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148338 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 147986 - [Android] Add remaining build/common.gypi changes from ↵yfriedman@chromium.org2012-07-241-4/+0
| | | | | | | | | | | | | | | | | | | | | | | downstream and strip NOTIMPLEMENTED()s from official builds. Includes: 1) Allowing overridding of android_ndk_sysroot (addition of "%" in variable name). 2) Disable NOTIMPLEMENTED output for official builds (see base/logging.h) 3) Add clang build configurations 4) Remove unnecessary cflags from regular build. 5) Include crtbegin_so.o and crtend_so.so for _type=="loadable_module" which is needed for ppapi_tests. BUG=137569 Review URL: https://chromiumcodereview.appspot.com/10808042 TBR=yfriedman@chromium.org Review URL: https://chromiumcodereview.appspot.com/10816039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148147 0039d316-1c4b-4281-b951-d872f2087c98
* [Android] Add remaining build/common.gypi changes from downstream and strip ↵yfriedman@chromium.org2012-07-231-0/+4
| | | | | | | | | | | | | | | | | | | | NOTIMPLEMENTED()s from official builds. Includes: 1) Allowing overridding of android_ndk_sysroot (addition of "%" in variable name). 2) Disable NOTIMPLEMENTED output for official builds (see base/logging.h) 3) Add clang build configurations 4) Remove unnecessary cflags from regular build. 5) Include crtbegin_so.o and crtend_so.so for _type=="loadable_module" which is needed for ppapi_tests. BUG=137569 Review URL: https://chromiumcodereview.appspot.com/10808042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147986 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-111-1/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* Make NOTIMPLEMENTED_POLICY=0 actually work.torne@chromium.org2012-01-301-1/+1
| | | | | | | | | | | | Various places in the code use NOTIMPLEMENTED() with << "message" like the other logging macros; this doesn't work when NOTIMPLEMENTED expands to a semicolon. Expand it to EAT_STREAM_PARAMETERS instead so any parameters are simply compiled away in this case. Review URL: http://codereview.chromium.org/9244006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119711 0039d316-1c4b-4281-b951-d872f2087c98
* Add OSSTATUS_LOG API.mark@chromium.org2012-01-271-1/+0
| | | | | | Review URL: https://chromiumcodereview.appspot.com/9235084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119511 0039d316-1c4b-4281-b951-d872f2087c98
* Move operator<< for StringPiece into string_piece.{h,cc}akalin@chromium.org2012-01-201-11/+1
| | | | | | | | | BUG=110651 TEST= Review URL: https://chromiumcodereview.appspot.com/9159005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118416 0039d316-1c4b-4281-b951-d872f2087c98
* Extract common code from StringPiece and StringPiece16 into a templated base ↵erikwright@chromium.org2011-12-221-1/+2
| | | | | | | | | | | | | | | | | class. Convert copy-and-pasted unit tests into TYPED_TESTs. The motivation is that I wish to add constructors for string::iterator ranges and I don't want to do it twice. The motivation for adding the string::iterator range constructors is to reduce the number of overloads in string_number_conversions.h . BUG=87634 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114242 Review URL: http://codereview.chromium.org/8659047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115616 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Extract common code from StringPiece and StringPiece16 into a ↵erikwright@chromium.org2011-12-131-2/+1
| | | | | | | | | | | | | | | templated base class.... ... Convert copy-and-pasted unit tests into TYPED_TESTs." This reverts commit 20543ba53ab8737affb06a21149c15f772246aed. BUG= TEST= Review URL: http://codereview.chromium.org/8933012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114255 0039d316-1c4b-4281-b951-d872f2087c98
* Extract common code from StringPiece and StringPiece16 into a templated base ↵erikwright@chromium.org2011-12-131-1/+2
| | | | | | | | | | | | | | | class. Convert copy-and-pasted unit tests into TYPED_TESTs. The motivation is that I wish to add constructors for string::iterator ranges and I don't want to do it twice. The motivation for adding the string::iterator range constructors is to reduce the number of overloads in string_number_conversions.h . BUG=87634 TEST= Review URL: http://codereview.chromium.org/8659047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114242 0039d316-1c4b-4281-b951-d872f2087c98
* Don't delete g_vlog_infostevenjb@chromium.org2011-12-031-0/+4
| | | | | | | | | | | | Fixes a race on startup. See issue for details. BUG=chromium-os:20865 TEST=Ensure logging, including VLOG, works. TBR=willchen@chromium.org Review URL: http://codereview.chromium.org/8757002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112828 0039d316-1c4b-4281-b951-d872f2087c98
* Make CHECK not print messages in official buildsakalin@chromium.org2011-12-021-27/+52
| | | | | | | | | | | | | | | | | | | | | | | | This cuts down on the number of strings in the executable, as well as executable code to print them. On Linux, this saves 208kb on a stripped official build (chrome executable file went from 64569072 bytes -> 64782064 bytes) On OS X, this saves 209kb on an official build (Google Chrome Framework went from 51483872 bytes -> 51274984 bytes) On Windows, this saves 139kb on an official build (chrome.dll went from 28619264 bytes -> 28477440 bytes) Fix test failure in logging_unittest.cc in official builds. Add new executable check_example for easy testing of changes to the CHECK macros. BUG=101561 TEST= Review URL: http://codereview.chromium.org/8734021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112649 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where DVLOGs are treated as DLOG(INFO)sakalin@chromium.org2011-10-251-1/+1
| | | | | | | | | | BUG=101424 TEST= Review URL: http://codereview.chromium.org/8375036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107072 0039d316-1c4b-4281-b951-d872f2087c98
* base: Reenable external templates in logging.h when using component build.erg@chromium.org2011-10-241-6/+10
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8360023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106966 0039d316-1c4b-4281-b951-d872f2087c98
* Remove no longer needed android hack from logging.torne@chromium.org2011-10-111-5/+0
| | | | | | | | | | This hack is not needed any more; NOTREACHEDs should be handled the same as explicit DCHECKs. Review URL: http://codereview.chromium.org/8233006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104913 0039d316-1c4b-4281-b951-d872f2087c98
* Add a gyp flag to enable dcheck by default in release withoutnsylvain@chromium.org2011-09-201-1/+14
| | | | | | | | | having the pass a flag. This will be used on the try bots. BUG=96753 Review URL: http://codereview.chromium.org/7719007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102017 0039d316-1c4b-4281-b951-d872f2087c98
* Rename BASE_API to BASE_EXPORT.darin@chromium.org2011-08-051-26/+26
| | | | | | | R=rvargas Review URL: http://codereview.chromium.org/7461141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95618 0039d316-1c4b-4281-b951-d872f2087c98
* Add COMPONENT_BUILD global define. darin@chromium.org2011-07-131-1/+1
| | | | | | | | | | | | | | | | | | | | | This avoids the need to define FOO_DLL macros for each project that we wish to optionally build as a DLL (when component=="shared_library"). This in turn means that we do not need direct_dependent_settings to define FOO_DLL, and that means that we don't need to update projects to convert transitive dependencies into explicit dependencies. This makes the component build more consistent with the static build. An alternative would be to use all_dependent_settings, but I feel that the global approach is simpler as it creates less repetition in each target definition for components. A side-effect of this change is that I needed to make base_nacl_win64 be a shared_library in the component build. R=rvargas,bradnelson,evan Review URL: http://codereview.chromium.org/7344022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92409 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add COMPONENT_BUILD global define. "yurys@chromium.org2011-07-131-1/+1
| | | | | | | | | | | | | The change broke compilation on Linux Builder (dbg)(shared): http://build.chromium.org/p/chromium/builders/Linux%20Builder%20%28dbg%29%28shared%29/builds/3365/steps/compile/logs/stdio TBR=darin BUG=None TEST=None Review URL: http://codereview.chromium.org/7352014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92329 0039d316-1c4b-4281-b951-d872f2087c98
* Add COMPONENT_BUILD global define. darin@chromium.org2011-07-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | This avoids the need to define FOO_DLL macros for each project that we wish to optionally build as a DLL (when component=="shared_library"). This in turn means that we do not need direct_dependent_settings to define FOO_DLL, and that means that we don't need to update projects to convert transitive dependencies into explicit dependencies. This makes the component build more consistent with the static build. An alternative would be to use all_dependent_settings, but I feel that the global approach is simpler as it creates less repetition in each target definition for components. A side-effect of this change is that I needed to make base_nacl_win64 be a shared_library in the component build. R=rvargas,bradnelson Review URL: http://codereview.chromium.org/7344022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92325 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream android debug and log related filesmichaelbai@google.com2011-07-071-0/+5
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/7238012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91748 0039d316-1c4b-4281-b951-d872f2087c98
* Adding missing inclusionstzik@chromium.org2011-06-181-0/+1
| | | | | | | | | | BUG=None TEST='LoggingTest.*,FileUtilTest.*,PlatformFile.*,StringNumberConversionsTest.*,Time,TimeTicks,TimeDelta' Review URL: http://codereview.chromium.org/7108033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89595 0039d316-1c4b-4281-b951-d872f2087c98
* linux: components support for base/evan@chromium.org2011-04-291-2/+2
| | | | | | | | This builds base_unittests using libbase as a component. Review URL: http://codereview.chromium.org/6904109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83583 0039d316-1c4b-4281-b951-d872f2087c98
* Base: Fix the logging export api to fix release builds ofrvargas@google.com2011-04-261-1/+1
| | | | | | | | | | chrome using base.dll BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6904010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83073 0039d316-1c4b-4281-b951-d872f2087c98
* Base: More adjustments to BASE_API and project dependencies torvargas@google.com2011-04-211-1/+1
| | | | | | | | | | use base.dll from chrome. BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6877053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82564 0039d316-1c4b-4281-b951-d872f2087c98
* Base: A few more changes to build base.dllrvargas@google.com2011-04-011-2/+2
| | | | | | | | BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6784002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80104 0039d316-1c4b-4281-b951-d872f2087c98
* Base: A few more files using BASE_API (for base.dll)rvargas@google.com2011-03-251-23/+25
| | | | | | | | BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6733031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79426 0039d316-1c4b-4281-b951-d872f2087c98
* Lower logging for expected errors in process_util_mac.mmsail@chromium.org2011-03-061-0/+21
| | | | | | | | BUG=None TEST=None git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77082 0039d316-1c4b-4281-b951-d872f2087c98
* [Logging] Remove unneeded CheckOpString struct for CHECKsakalin@chromium.org2011-02-081-17/+9
| | | | | | | | | | | | | | | Using string* directly works. Made LogMessage delete any passed in string* after it uses it. Removed suppressions for fixed memory leak. BUG=57683 TEST=Existing unit tests Review URL: http://codereview.chromium.org/6413032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74100 0039d316-1c4b-4281-b951-d872f2087c98
* Change UTF8ToUTF16 to accept const StringPiece&.suzhe@google.com2011-01-281-0/+9
| | | | | | | | | BUG=70936 TEST=All unit tests should pass. Review URL: http://codereview.chromium.org/6317016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72921 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-111-7/+16
| | | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70920 Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70977 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70920 - Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-101-16/+7
| | | | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Review URL: http://codereview.chromium.org/6070006 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/6099012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70923 0039d316-1c4b-4281-b951-d872f2087c98
* Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-101-7/+16
| | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782 Review URL: http://codereview.chromium.org/6070006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70920 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 70782 - Made logging not look up --enable-dcheck from command lineakalin@chromium.org2011-01-071-16/+7
| | | | | | | | | | | | | | | Made --enable-dcheck a parameter to InitLogging() and fixed up all callsites. BUG=62736 TEST=Manual Review URL: http://codereview.chromium.org/6070006 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/6100007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70783 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 14:52:10 +0000