| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
toll-free bridging of CT/NSFont.
BUG=312436
TEST=no console spew as in bug
R=asvitkine@chromium.org, mark@chromium.org, shess@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231670
Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=231685
Review URL: https://codereview.chromium.org/49503003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Make RenderTextMac more efficient by caching fonts and taking advantage of toll-free bridging of CT/NSFont.
>
> BUG=312436
> TEST=no console spew as in bug
> R=asvitkine@chromium.org, mark@chromium.org, shess@chromium.org
>
> Review URL: https://codereview.chromium.org/49503003
TBR=avi@chromium.org
Review URL: https://codereview.chromium.org/51463003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=304860, 312196
TEST=run from the command line with dots
R=mark@chromium.org
Review URL: https://codereview.chromium.org/51023003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
toll-free bridging of CT/NSFont.
BUG=312436
TEST=no console spew as in bug
R=asvitkine@chromium.org, mark@chromium.org, shess@chromium.org
Review URL: https://codereview.chromium.org/49503003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=304860, 312196
TEST=run from the command line with dots
Review URL: https://codereview.chromium.org/45703003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The contents of a CALayer can be set to an NSImage* as of 10.6.
BUG=none
TEST=no changes in download started animation or in tabpose
Review URL: https://codereview.chromium.org/45893002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This involves Process Manager functions, which in 10.9 cause a WindowServer checkin, which causes "not responding" notifications on any child process that doesn't pump events (which is everything but the renderers).
BUG=304860
TEST=Plugin process on Mavericks shouldn't have an app icon to its left, shouldn't be "not responding"
R=mark@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/45253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=304860
TEST=GPU process on Mavericks shouldn't have an app icon to its left, shouldn't be "not responding"
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/41493002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the flag is enabled and the user attempts to reveal a plaintext password
in chrome://settings/passwords, they will be prompted to reauthenticate with
their OS password. This matches Safari's behaviour on OS X.
BUG=303113
Review URL: https://codereview.chromium.org/28713002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- FoundationUtilTest.NSStringToFilePath
- BrowserAccessibilityTest.BasicAttributeTest
BUG=173983
R=dmazzoni@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/26887007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=less annoying logging
Review URL: https://codereview.chromium.org/26316003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=covered
Review URL: https://codereview.chromium.org/25286002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
it fails with EINTR. Specifically, in this case, the FD will already have been
closed.
BUG=269623
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/23455051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23514018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When launching an app from Chrome, start the app shim without activating
it.
In case the app was launched from the shim, focus the app when its first
window opens.
BUG=263217
TEST=Start an app from the NTP.
The shim should start without stealing focus.
Quit and restart the app from the shim.
The app's first window should take focus.
Close the window and click the app's dock icon.
A new window should open and take focus.
Review URL: https://chromiumcodereview.appspot.com/20037002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=260807
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19224003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/18286004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Manual follow-up to mechanical https://codereview.chromium.org/17593006/
BUG=251957
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/17627005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most references were updated from base::mac:: to base:: in r208245.
Manually fix up a few stragglers in this CL too.
BUG=251957
R=mark@chromium.org
Review URL: https://codereview.chromium.org/17618003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1.) The header is now in base/mac instead of base/memory
2.) The class is now in namespace base.
This CL was created programmatically by running:
1.)
git grep -l memory/scoped_nsobject.h | xargs sed -i -e 's/memory\/scoped_nsobject.h/mac\/scoped_nsobject.h/g'
for f in $(git diff --name-only origin); do tools/sort-headers.py $f -f; done
git commit -a -m headers
# manually undo changes to gypi file
git cl upload # patch set 1
2.)
git grep -l 'scoped_nsobject<' | xargs sed -i -e 's/scoped_nsobject</base::scoped_nsobject</g'
# manually undo comment changes in scoped_nsobject.h, tracking_area.h
git commit -a -m format
git cl upload # patch set 2
# Manually audit all files, file bugs and clean up bad clang-format decisions
git cl upload # patch set 3
BUG=251957
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/17593006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL was created fully mechanically by running
git grep -l base::mac::ScopedCFTypeRef | xargs sed -i -e 's/base::mac::ScopedCFTypeRef/base::ScopedCFTypeRef/g'
git commit -a -m.
git clang-format HEAD^ --style=Chromium
git commit -a -m.
git cl upload -t $TITLE
BUG=251957
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/16917011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Makes the favicons (tab, bookmarks) look the same in the browser UI as they do in the renderer). This fixes a regression (probably by one of my CLs) since https://codereview.chromium.org/6117006
2) Make the favicons in the tab strip look the same after refreshing. The difference is due to the conversions PNG -> NSImage and PNG -> SkBitmap -> NSImage producing visually different NSImages. In particular, the result is different when the input PNG data has no colorspace information specified. Cocoa defaults to the device colorspace when decoding PNG data with no colorspace information. The generic RGB colorspace is used for converting from SkBitmap to NSImage.
BUG=242877
TEST=Manual, see bug
Review URL: https://chromiumcodereview.appspot.com/16370006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
So it's next to scoped_cftyperef.h. Also move both scoped_nsobject and
ScopedCFTypeRef to namespace base.
BUG=251957
R=mark@chromium.org
Review URL: https://codereview.chromium.org/17500005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also fixes some namespace usage inside the message pump files and updates all users of these files to use the new location.
Reland of 206507.
Original review https://codereview.chromium.org/17078005/
TBR=sky
Review URL: https://codereview.chromium.org/16897006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Move message_pump to base/message_loop.
>
> This also fixes some namespace usage inside the message pump files and updates all users of these files to use the new location.
>
> BUG=
> R=sky@chromium.org
>
> Review URL: https://codereview.chromium.org/17078005
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/16897005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also fixes some namespace usage inside the message pump files and updates all users of these files to use the new location.
BUG=
R=sky@chromium.org
Review URL: https://codereview.chromium.org/17078005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16667013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/15870009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the flag --use-core-animation to enable this path.
Make the RenderWidgetHostViewCocoa layer-backed, and add a
default white layer.
Add a CALayer, softwareLayer_ to draw into when the accelerated
path is disabled. Update the software draw methods to use the CG
calls (this changes the non-CA path as well, but should be equivalent
to previous behavior).
If accelerated compositing is enabled, then add CAOpenGLLayer to
draw accelerated frames (frames using IOSurfaces). If we receive a
software frame, then delete this layer (and the software layer will
appear below it).
This still has a number of issues to resolve before enabling, including
- corrupted bookmark bars
- increased CPU usage (3.5%->5% without compositing, 7%->10% with)
- increased startup time
BUG=245900
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/16189012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/16129005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These are either missed in the first pass, or added after the first pass.
TBR=thestig@chromium.org
BUG=236029
Review URL: https://codereview.chromium.org/16092013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=mark@chromium.org
Review URL: https://codereview.chromium.org/15979009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/15848005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202828 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without this patch, users have to install a driver that exposes a standard HID
device for the controller. Unfortunately, apart from the problems with
requiring users to install a driver, the only such available driver
(http://tattiebogle.net/index.php/ProjectRoot/Xbox360Controller/OsxDriver)
crashes the kernel when the controller is unplugged.
This change uses IOKit to talk directly to the Xbox controller without the need
for a driver, and exposes it through the normal HTML5 gamepad API.
BUG=232238
R=scottmg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14328036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Uses LSOpenApplication to launch the given application bundle.
R=mark@chromium.org
TBR=cpu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/13835013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=NONE
Review URL: https://chromiumcodereview.appspot.com/14247015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ReleaseFullScreen incorrectly DCHECKed > 0 instead of >= 0.
BUG=229700
Review URL: https://chromiumcodereview.appspot.com/13973005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This restructures the way MachBroker parent-child communication happens. Now,
the MachBroker lock will be held for the duration of LaunchProcess until the
PID is returned and inserted into the MachMap. Since the lock must also be
acquired on the broker thread to insert the received task port into the
MachMap, this ensures that the placeholder is always inserted before the task
port.
MachBroker has also been rewritten to use Mach IPC directly, rather than the C++
wrappers in base/mach_ipc_mac.h. The wrappers are not flexible enough to allow
the use of an audit trailer. This trailer is used to verify the PID of the
sender of the check in message in the parent. Previously, this was done by
another kernel trap, pid_for_task.
BUG=179923
Originally Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193486
Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=193511
Review URL: https://codereview.chromium.org/13845008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> [Mac] Remove base::LaunchSynchronize and rewrite content::MachBroker.
>
> This restructures the way MachBroker parent-child communication happens. Now,
> the MachBroker lock will be held for the duration of LaunchProcess until the
> PID is returned and inserted into the MachMap. Since the lock must also be
> acquired on the broker thread to insert the received task port into the
> MachMap, this ensures that the placeholder is always inserted before the task
> port.
>
> MachBroker has also been rewritten to use Mach IPC directly, rather than the C++
> wrappers in base/mach_ipc_mac.h. The wrappers are not flexible enough to allow
> the use of an audit trailer. This trailer is used to verify the PID of the
> sender of the check in message in the parent. Previously, this was done by
> another kernel trap, pid_for_task.
>
> BUG=179923
>
>
> Review URL: https://chromiumcodereview.appspot.com/13845008
TBR=rsesek@chromium.org
Review URL: https://codereview.chromium.org/14120002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This restructures the way MachBroker parent-child communication happens. Now,
the MachBroker lock will be held for the duration of LaunchProcess until the
PID is returned and inserted into the MachMap. Since the lock must also be
acquired on the broker thread to insert the received task port into the
MachMap, this ensures that the placeholder is always inserted before the task
port.
MachBroker has also been rewritten to use Mach IPC directly, rather than the C++
wrappers in base/mach_ipc_mac.h. The wrappers are not flexible enough to allow
the use of an audit trailer. This trailer is used to verify the PID of the
sender of the check in message in the parent. Previously, this was done by
another kernel trap, pid_for_task.
BUG=179923
Review URL: https://chromiumcodereview.appspot.com/13845008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Starting with the 10.8 SDK and the iOS 6.0 SDK, enums are declared
strongly typed in C++11 mode, which the old forward-declares weren't
compatible with. This creates a new macro for forward-declaring these
enums in a way that will match the SDK and compilation mode.
BUG=226494
Review URL: https://chromiumcodereview.appspot.com/13455004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=170189, 225659
TEST=change is to comment only; no behavior change
Review URL: https://chromiumcodereview.appspot.com/13467018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=170189,225659
TEST=as in bug 225659
Review URL: https://chromiumcodereview.appspot.com/13583005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
string_piece.h was moved into base/strings/ in r191206 -
https://chromiumcodereview.appspot.com/12982018/
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/13374002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
PerformSelectorIgnoringExceptions() -> RunBlockIgnoringExceptions(),
as the block version is more generalized.
BUG=none
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/12342021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=sky
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This removes the "using" in file_path.h for Mac since Mac now passes trybots with no using. It still leaves the using for Windows.
Review URL: https://codereview.chromium.org/12294008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
string_number_conversions in some chrome subdirectories.
Review URL: https://codereview.chromium.org/12218065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium cannot control that code, and NSExceptions should be safe-ish
since there is no Chromium code on the stack.
BUG=174708
Review URL: https://chromiumcodereview.appspot.com/12208053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This updates callers in base but I left a forwarding header so I can the rest in pieces (there are >300).
Review URL: https://codereview.chromium.org/12213061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181345 0039d316-1c4b-4281-b951-d872f2087c98
|