| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
BUG=19951,20552
TEST=compare pages rendered in Chromium and Safari. They should appear the same.
mark: review
jrg/brettw: FYI
Review URL: http://codereview.chromium.org/194013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
background helper.
This fixes the Breakpad about:crash problem, but not directly. I'm not
exactly sure of the failure mechanism here. It's likely that doing this call
properly here caches the Info.plist dictionary, and that something in Breakpad
crashes when that's not done. Without this fix, we're seeing a double fault,
with the second exception occurring in the renderer while it is processing
the crash. Likely because of the use of fork && execv instead of posix_spawn
to launch the renderer, the second exception is delivered to the browser
process. The browser's Breakpad instance recognizes that the exception is not
its own, but attempts to act on it in part anyway. There may be a Breakpad
bug here, I'll investigate more tomorrow.
BUG=20371
TEST=In a Breakpad-enabled build, about:crash should bring up a sad tab and
not crash the browser process
Review URL: http://codereview.chromium.org/194007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
.../src/chrome/app/breakpad_mac.mm: In function ‘void InitCrashReporter()’:
.../src/chrome/app/breakpad_mac.mm:56: error: ‘parsed_command_line’ was not declared in this scope
IMPORTANT NOTE: When you're making changes to files that aren't part of the
normal build, you MUST test them. The next time I see an obvious case of
"oops, I never actually built that file," I'm just going to back it out. As
for this instance, I'm fixing it now, but you MUST build and test your change
locally. We can't afford accidentally losing Breakpad coverage. I've already
seen an embarrassing number of instances of "oops, Breakpad's broken" but we've
fortunately caught them all before integrating them into a release.
BUG=It doesn't build
TEST=Does it build now?
Review URL: http://codereview.chromium.org/178056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable Apple Crash Reporter for Browser process in Non-Debug builds.
* Introduce mac_util::IsBackgroundProcess().
* Invert logic around Breakpad Enabling/Disabling to make it clearer.
* Honor the kDisableBreakpad switch.
Our new policy:
* Breakpad is enabled/disabled based on the user stats reporting opt-in flag - this hasn't changed.
* Always disable Apple Crash in background processes (plug-in, renderer, etc).
* If Breakpad is enabled browser crashes will be passed to Crash Reporter.
* If Breakpad is NOT enabled browser [or any other foreground app] crashes will be passed to Crash Reporter in Release builds.
Effectively this means that we now enable Crash Reporter for the browser process in Chromium release builds so these will no longer crash silently with no trace.
Review URL: http://codereview.chromium.org/180048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
initialized data even if the system is totally unable to service the request.
BUG=19000
Review URL: http://codereview.chromium.org/164388
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the correct creator code for the application. This is 'rimZ' for branded
Google Chrome, and 'Cr24' for Chromium.
BUG=19000
TEST=No functional change in Google Chrome-branded builds
Review URL: http://codereview.chromium.org/164332
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159668
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- provide apis to get and override the app bundle
- w/in the core code, use this api for fetching the bundle
- render sandbox config
- resource bundles
- test shell font
- w/in the unittest boot straps, use the mac util to override the bundle so resources can be found.
Review URL: http://codereview.chromium.org/28214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
test_shell_tests.
Review URL: http://codereview.chromium.org/13719
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
Review URL: http://codereview.chromium.org/13260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6584 0039d316-1c4b-4281-b951-d872f2087c98
|