summaryrefslogtreecommitdiffstats
path: root/base/message_pump_x.cc
Commit message (Collapse)AuthorAgeFilesLines
* CrOS: Add a CHECK to help debug a crash in the wild.jhawkins@chromium.org2012-02-161-3/+5
| | | | | | | | | | BUG=113106 TEST=none R=binji Review URL: https://chromiumcodereview.appspot.com/9347049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122206 0039d316-1c4b-4281-b951-d872f2087c98
* MessagePumpX: Fix leak of the GPollFD.jhawkins@chromium.org2012-02-061-5/+5
| | | | | | | | | | BUG=none TEST=none R=sadrul Review URL: https://chromiumcodereview.appspot.com/9328036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120543 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor MessagePumpX to dispatch events inside of the source Dispatch function.piman@chromium.org2011-12-141-13/+9
| | | | | | | | | | | | | | Also clean up MessagePumpGlib. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114168 Review URL: http://codereview.chromium.org/8872055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114439 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r114168 "Refactor MessagePumpX to dispatch events inside of the ↵oshima@chromium.org2011-12-131-8/+12
| | | | | | | | | | | | | | source Dispatch function." This reverts commit bae6675d851184f2be0ac117c1a847289c1c7bd9. TBR=piman@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/8931009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114245 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor MessagePumpX to dispatch events inside of the source Dispatch function.piman@chromium.org2011-12-131-12/+8
| | | | | | | | | | | | Also clean up MessagePumpGlib. BUG=None TEST=None Review URL: http://codereview.chromium.org/8872055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114168 0039d316-1c4b-4281-b951-d872f2087c98
* Share X connection between GLSurfaceGLX/EGL and MessagePumpX/GTKpiman@chromium.org2011-12-091-2/+2
| | | | | | | | | | BUG=104248 TEST=chrome: about:gpu and webgl pages (both aura and gtk), compositor_unittests, views_unittests Review URL: http://codereview.chromium.org/8890042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113858 0039d316-1c4b-4281-b951-d872f2087c98
* Fix MessagePumpX::ProcessXEvent checking of WillProcessXEvent return value.davidxli@chromium.org2011-12-031-1/+1
| | | | | | | | | | | | WillProcessXEvent returns false to indicate continue normal dispatch. The check worked because EVENT_CONTINUE happens to be 0. BUG=None TEST=None Review URL: http://codereview.chromium.org/8769049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112872 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Fix unit_tests on linuxsadrul@chromium.org2011-12-011-5/+3
| | | | | | | | | | | | | | | | | Make sure the aura::Desktop is destroyed with the message-loop. This is done by adding a DestroyMessagePump notification to MessagePumpObserver. Also remove some views_unittests that were added to test NativeWidgetViews (which aren't used anymore), and do proper cleanup in AccessibilityEventRouter unittest. TBR=darin@chromium.org BUG=104559, 105613 TEST=unit_tests Review URL: http://codereview.chromium.org/8566037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112474 0039d316-1c4b-4281-b951-d872f2087c98
* DefaultDispatcher for MessagePumpXoshima@chromium.org2011-11-231-4/+18
| | | | | | | | | | | | | | MPX itself doesn't know how to handle events and we've been converting MessageLoop::Run() -> Desktop::Run() or RunAllPending to use ui_test_utils::RunAllPendingInMessageLoop(). It's no longer necessary with this CL. Windows's message pump can dispatch events without dispatcher. BUG=none TEST=none, but I believe some of browser_tests on aura is flaky because of this, and this CL should make them less/non flaky. Review URL: http://codereview.chromium.org/8635014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111324 0039d316-1c4b-4281-b951-d872f2087c98
* Some dead-code removal from message_pump_x and touch_factory.sadrul@chromium.org2011-11-211-144/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8575017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110980 0039d316-1c4b-4281-b951-d872f2087c98
* Replace most LOG/CHECK statements with DLOG/DCHECK statements in base.brettw@chromium.org2011-10-261-5/+5
| | | | | | | | | | | [ Reland of 107042 http://codereview.chromium.org/8368009 ] I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8341026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107434 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 107042 - Replace most LOG/CHECK statements with DLOG/DCHECK ↵brettw@chromium.org2011-10-251-5/+5
| | | | | | | | | | | | | | statements in base. I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8368009 TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/8351025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107051 0039d316-1c4b-4281-b951-d872f2087c98
* Replace most LOG/CHECK statements with DLOG/DCHECK statements in base.brettw@chromium.org2011-10-251-5/+5
| | | | | | | | | I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8368009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107042 0039d316-1c4b-4281-b951-d872f2087c98
* Fix X events processingpiman@chromium.org2011-10-191-4/+13
| | | | | | | | | | BUG=100226 TEST=Drag windows around Review URL: http://codereview.chromium.org/8305005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106393 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Make MessagePumpX check that X connection is open.derat@chromium.org2011-10-191-1/+3
| | | | | | | | | | | | | | This doesn't fix the current problem that we're seeing on bots, but it at least prints a more useful error message than just seeing a segfault in Xlib. BUG=100909 TEST=none TBR=oshima Review URL: http://codereview.chromium.org/8357011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106338 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete DisableGtkMessagePumposhima@chromium.org2011-10-121-42/+19
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8216036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104962 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Fix views_unittests and aura_unittests on linux.sadrul@chromium.org2011-10-061-1/+1
| | | | | | | | | | | | | | | . Use NativeScrollBarViews in aura and wayland. . Disable clipboard-related tests in TextfieldViewsModelTest until aura on linux has clipboard support. . Use osmesa implementation for aura_unittests. TBR=evan@chromium.org BUG=97845, 99128 TEST=views_unittests passes on linux with use_aura Review URL: http://codereview.chromium.org/8143021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104220 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate message observer API for MessagePumpX and MessagePumWinoshima@google.com2011-10-041-7/+11
| | | | | | | | | | | This is an attempt to simplify the code around message pump observer. BUG=none TEST=none Review URL: http://codereview.chromium.org/8021009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103825 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: support XInput2 multitouchsadrul@chromium.org2011-09-251-0/+13
| | | | | | | | | | | | | | Use XI2 multitouch events instead of mouse events as touch event input for touchui build. Note: XI MT will be supported in X server 1.12 and XI2.2. Please use build switch "use_xi2_mt=<minor version number>" to specify the minimum XI2 minor version. It is useful to test on experimental XI2.1 with MT support (e.g. build with use_xi2_mt=1). BUG=95150 TEST=(1) build with touchui=1 use_xi2_mt=1 (2) test on ubuntu 11.04 (X server 1.10 and XI2.1 with experimental MT support). (3) manually test if touch works on browser UI and JS touch events. Review URL: http://codereview.chromium.org/7792094 Patch from Ningxin Hu <ningxin.hu@intel.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102668 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 102005 and 102009: aura: Explicitly disable GTK.sadrul@chromium.org2011-09-211-39/+73
| | | | | | | | | | | | | | | Explicitly disable GTK by setting TOOLKIT_USES_GTK. This is the first in a series of changes required to have chrome on aura build and link without GTK. This CL makes base/ build without GTK. Subsequent CLs will do this for other components. TBR=evan@chromium.org BUG=97131 TEST=none Review URL: http://codereview.chromium.org/7983022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102058 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 102005 - aura: Explicitly disable GTK.sky@chromium.org2011-09-201-63/+29
| | | | | | | | | | | | | | Explicitly disable GTK by setting TOOLKIT_USES_GTK. This is the first in a series of changes required to have chrome on aura build and link without GTK. This CL makes base/ build without GTK. Subsequent CLs will do this for other components. BUG=97131 TEST=none Review URL: http://codereview.chromium.org/7904034 TBR=sadrul@chromium.org Review URL: http://codereview.chromium.org/7978007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102015 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 102009 - Follow up fix from r102005: Fix static build of base_unittests.sky@chromium.org2011-09-201-10/+10
| | | | | | | | | | | | | TBR=evan@chromium.org BUG=97131 TEST=none Review URL: http://codereview.chromium.org/7979010 TBR=sadrul@chromium.org Review URL: http://codereview.chromium.org/7983020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102014 0039d316-1c4b-4281-b951-d872f2087c98
* Follow up fix from r102005: Fix static build of base_unittests.sadrul@chromium.org2011-09-201-10/+10
| | | | | | | | | | TBR=evan@chromium.org BUG=97131 TEST=none Review URL: http://codereview.chromium.org/7979010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102009 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Explicitly disable GTK.sadrul@chromium.org2011-09-201-29/+63
| | | | | | | | | | | Explicitly disable GTK by setting TOOLKIT_USES_GTK. This is the first in a series of changes required to have chrome on aura build and link without GTK. This CL makes base/ build without GTK. Subsequent CLs will do this for other components. BUG=97131 TEST=none Review URL: http://codereview.chromium.org/7904034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102005 0039d316-1c4b-4281-b951-d872f2087c98
* Get views_unittests pass on touch buildoshima@google.com2011-08-241-1/+1
| | | | | | | | | | | | | | | | * Changed views test to use ViewsTestBase. * Always calls ViewsTestBase::SetUp/TearDown. Added flags to check if this is enforced. * Excluded tests that does not make sense on touch/pure views build. BUG=none TEST=views_unittets now passes on touch build, with a few exceptions below. WidgetTest.GrabUngrab: assigned to sadrul NativeTextfieldViewsTest.DragAndDrop_XXX: msw will look into it. Review URL: http://codereview.chromium.org/7720020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98128 0039d316-1c4b-4281-b951-d872f2087c98
* mpx: Use [mostly proper] glib event source for X events when GTK events are ↵sadrul@chromium.org2011-08-241-10/+65
| | | | | | | | | | | | | not used. The non-gtk aura WM can be run with this message-pump without taking up 100% CPU. BUG=none TEST=none Review URL: http://codereview.chromium.org/7704003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98099 0039d316-1c4b-4281-b951-d872f2087c98
* check xinput2 capability so that it runs on the system that doesn't support ↵oshima@google.com2011-07-231-27/+32
| | | | | | | | | | | xinput2 BUG=none TEST=none Review URL: http://codereview.chromium.org/7495013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93777 0039d316-1c4b-4281-b951-d872f2087c98
* re-landing r93629oshima@google.com2011-07-221-2/+9
| | | | | | | | | | | | | | | | | | | | | | Consolidate access to X Display Change ui::GetXDisplay to use the MessagePumpForUI class to get Display. This allows us to have two different implementation for x and gtk. Remove MessageLoop::GetDisplay from message loop API. Client should use ui::GetXDisplay instead. This will also be removed in near future, and client should get display from window it is dealing with. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93629 Review URL: http://codereview.chromium.org/7484006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93686 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 93629 - Linux build failure: ↵leandrogracia@chromium.org2011-07-221-9/+2
| | | | | | | | | | | | | | | | | | | | | | | | | http://build.chromium.org/p/chromium/builders/Linux%20Builder%20%28dbg%29%28shared%29/builds/4098/steps/compile/logs/stdio#error1 Consolidate access to X Display Change ui::GetXDisplay to use the MessagePumpForUI class to get Display. This allows us to have two different implementation for x and gtk. Remove MessageLoop::GetDisplay from message loop API. Client should use ui::GetXDisplay instead. This will also be removed in near future, and client should get display from window it is dealing with. BUG=none TEST=none Review URL: http://codereview.chromium.org/7484006 TBR=oshima@google.com Review URL: http://codereview.chromium.org/7493014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93633 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate access to X Displayoshima@google.com2011-07-221-2/+9
| | | | | | | | | | | | | | | | | | Change ui::GetXDisplay to use the MessagePumpForUI class to get Display. This allows us to have two different implementation for x and gtk. Remove MessageLoop::GetDisplay from message loop API. Client should use ui::GetXDisplay instead. This will also be removed in near future, and client should get display from window it is dealing with. BUG=none TEST=none Review URL: http://codereview.chromium.org/7484006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93629 0039d316-1c4b-4281-b951-d872f2087c98
* touch: Always expect XInput2 availability.sadrul@chromium.org2011-07-221-18/+0
| | | | | | | | | BUG=80790 TEST=touch compiles Review URL: http://codereview.chromium.org/6975045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93621 0039d316-1c4b-4281-b951-d872f2087c98
* use MessageLoop::GetDisplay to get X's Display to make message_pump_x less ↵oshima@google.com2011-07-151-10/+8
| | | | | | | | | | | | | | | GTK/GDK dependent. Add log message to CHECK. I've seen visiblity notify passing through there. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92764 Review URL: http://codereview.chromium.org/7390001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92770 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "use MessageLoop::GetDisplay to get X's Display ..."oshima@google.com2011-07-151-8/+10
| | | | | | | | | | | This reverts commit 4eeea551f778f9c3062e98b8d4f75283a69db60c. BUG= TEST= Review URL: http://codereview.chromium.org/7399012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92766 0039d316-1c4b-4281-b951-d872f2087c98
* use MessageLoop::GetDisplay to get X's Display to make message_pump_x less ↵oshima@google.com2011-07-151-10/+8
| | | | | | | | | | | | | GTK/GDK dependent. Add log message to CHECK. I've seen visiblity notify passing through there. BUG=none TEST=none Review URL: http://codereview.chromium.org/7390001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92764 0039d316-1c4b-4281-b951-d872f2087c98
* Add ability to disable gtk event pumping in MessagePumpXoshima@google.com2011-07-131-7/+17
| | | | | | | | | | | This is intermediate step to remove gtk from chromeos/touch. BUG=none TEST=none Review URL: http://codereview.chromium.org/7357004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92414 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the glib message-pump, and use it as the base for a gtk message ↵sadrul@chromium.org2011-06-241-0/+232
pump and an X message pump. The changes: * Rename MessagePumpGlibX to MessagePumpX. * Rename MessagePumpForUI to MessagePumpGlib. * Move some stuff out of MessagePumpGlib, and into MessagePumpGtk and MessagePumpX. * Rename MessagePumpForUI::Observer to MessageObserver, moved the platform-specific implementations into MessagePumpGtk and MessagePumpX. Ditto for MessagePumpForUI::Dispatcher. MessagePumpX is independent of MessagePumpGtk. At the moment, MessagePumpX does process some GDK event, but once we have a complete native_widget_x, we can take out the GDK processing and things should continue to work. BUG=none TEST=existing message-pump tests. Review URL: http://codereview.chromium.org/7250001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90418 0039d316-1c4b-4281-b951-d872f2087c98