summaryrefslogtreecommitdiffstats
path: root/base/metrics
Commit message (Collapse)AuthorAgeFilesLines
* Update comments on how to create a field trial in field_trial.h.asvitkine@chromium.org2012-06-131-2/+3
| | | | | | | | | BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10546121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141826 0039d316-1c4b-4281-b951-d872f2087c98
* Add shared memory cleanup before/after all testsjar@chromium.org2012-06-061-2/+5
| | | | | | | | | | | | | | | Cleanup was already in place, but was missing for StatsRate and StatsCounterTimer. This should *hopefully* remove apparent flakiness seen when running StatsRate alone in a test bot. bug=131024 r=asvitkine Review URL: https://chromiumcodereview.appspot.com/10538027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140830 0039d316-1c4b-4281-b951-d872f2087c98
* Disable StatsTableTest.StatsRatecsharp@chromium.org2012-06-041-1/+2
| | | | | | | | | | | | | It fails on all platforms when run by itself. R=maruel@chromium.org,jar@chromium.org BUG=131024 TEST= Review URL: https://chromiumcodereview.appspot.com/10511013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140394 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify private FieldTrial constructor.asvitkine@chromium.org2012-05-112-31/+34
| | | | | | | | | | | Move the date checking to the FactoryGetFieldTrial() factory method instead. BUG=none TEST=existing unit tests Review URL: https://chromiumcodereview.appspot.com/10332076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136483 0039d316-1c4b-4281-b951-d872f2087c98
* Added a SetForced method to allow forcing a new set of group bucketting.mad@chromium.org2012-05-073-0/+57
| | | | | | | | | | | | | | This will be needed by the Finch client (soon to be known as the Variations Service) that will get updated information about FieldTrials and pre-feed the field trial list based on this information. So this is different from CreateFieldTrial, which forced a group choice, this new method allows forcing a new set of appended groups. BUG=121695 TEST=build\Debug\base_unittests.exe --gtest_filter=FieldTrialTest.SetForced Review URL: https://chromiumcodereview.appspot.com/10382018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135748 0039d316-1c4b-4281-b951-d872f2087c98
* FieldTrial - Use ObserverListThreadSafe instead ofrtenneti@chromium.org2012-05-042-9/+11
| | | | | | | | | | | | ObserverList. R=jar TEST=base unit tests BUG=126027 Review URL: http://codereview.chromium.org/10342021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135263 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the hash fields from FieldTrials.stevet@chromium.org2012-04-273-122/+46
| | | | | | | | | | | | | | We want to migrate the hash fields and related methods from FieldTrials over to experiments_helper. We've also updated the unit tests that accomodate these changes. We've also refactored the experiments_helper APIs for GoogleExperimentIDs to take strings instead of NameGroupIds as keys... we do the hashing internally instead. BUG=None TEST=Ensure that base_unittests FieldTrialTest.* all pass. Ensure that unit_tests ExperimentsHelperTest.* all pass. Review URL: http://codereview.chromium.org/10151017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134350 0039d316-1c4b-4281-b951-d872f2087c98
* Add and implement API to associate Google experiment IDs with FieldTrials.stevet@chromium.org2012-04-232-0/+14
| | | | | | | | | | | | | | This includes unit tests for the API, but no uses yet. This change also involves exposing a new MakeGroupNameId static helper in FieldTrial to assist with the usage of this new API. BUG=121988 TEST=Ensure that unit_tests GoogleExperimentsTest.* pass. Review URL: http://codereview.chromium.org/10165014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133470 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 133212 - Add and implement API to associate Google experiment IDs ↵groby@chromium.org2012-04-202-14/+0
| | | | | | | | | | | | | | | | | | | | with FieldTrials. Reverted temporarily due to memory leak. This includes unit tests for the API, but no uses yet. This change also involves exposing a new MakeGroupNameId static helper in FieldTrial to assist with the usage of this new API. BUG=121988 TEST=Ensure that unit_tests GoogleExperimentsTest.* pass. Review URL: http://codereview.chromium.org/9965086 TBR=stevet@chromium.org Review URL: https://chromiumcodereview.appspot.com/10167015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133220 0039d316-1c4b-4281-b951-d872f2087c98
* Add and implement API to associate Google experiment IDs with FieldTrials.stevet@chromium.org2012-04-202-0/+14
| | | | | | | | | | | | | This includes unit tests for the API, but no uses yet. This change also involves exposing a new MakeGroupNameId static helper in FieldTrial to assist with the usage of this new API. BUG=121988 TEST=Ensure that unit_tests GoogleExperimentsTest.* pass. Review URL: http://codereview.chromium.org/9965086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133212 0039d316-1c4b-4281-b951-d872f2087c98
* Don't depend on undefined compiler behavior for computing persistent field ↵isherman@chromium.org2012-04-191-2/+4
| | | | | | | | | | | | trial identifiers. BUG=124096 TEST=field trials should continue to work as before Review URL: http://codereview.chromium.org/10116043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133047 0039d316-1c4b-4281-b951-d872f2087c98
* Add isherman to base/metrics/OWNERSisherman@chromium.org2012-04-191-0/+7
| | | | | | | | | | | Also add helpful(?) comments. BUG=none TEST=noen Review URL: https://chromiumcodereview.appspot.com/10119029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133040 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing issues with alignment, undefined behaviour and endianness in the ↵jwd@chromium.org2012-04-161-3/+5
| | | | | | | | | | | | FieldTrial::HashName function. I also added new functions to base that convert from host order to little endian. BUG=123230FieldTrialTest.HashName TEST=FieldTrialTest.HashName Review URL: http://codereview.chromium.org/10088001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132404 0039d316-1c4b-4281-b951-d872f2087c98
* Field Trials choices can now be forced from a command line argument, and yet ↵mad@chromium.org2012-04-123-140/+266
| | | | | | | | | | | | | | | | | still behave as if a coin was tossed, except the coin is tricked :-). To do this, we needed to change the usage from a regular constructor (which is not private) to a static CreateInstance method (which is why there is a bunch of TBR'd owners, those changes were trivial to existing users of FieldTrials). OWNERs of trivially changed files: TBR=sky,jamesr,cpu,joi, BUG=119726 TEST=base_unittests.exe --gtest_filter=FieldTrialTest.* You can also find an active field trial name and force it to a given group by passing the following command line argument "--force-fieldtest=<trial_name>/<default_group_name>/<group_name>/" Review URL: http://codereview.chromium.org/9705074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131948 0039d316-1c4b-4281-b951-d872f2087c98
* Add virtual and OVERRIDE to base/ implementation filesrsleevi@chromium.org2012-04-061-2/+4
| | | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/10004001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131098 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid using Pickle::WriteSize(), which writes an architecture-dependent amountmdm@chromium.org2012-03-141-7/+7
| | | | | | | | | of data, in histogram pickles. (The goal is to remove that method entirely. Uses that never persist or send pickles over the network are [probably] safe, but having the method around is waiting for accidental misuses.) Review URL: https://chromiumcodereview.appspot.com/9696001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126514 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor Pickle Read methods to use higher performance PickleIterator.jbates@chromium.org2012-03-072-19/+20
| | | | | | | | | | | | | | | | There was a lot of redundant error checking and initialization code in all Pickle Read methods because of the void** iterator type. This change replaces the void* iterator with PickleIterator, which encapsulates the read pointer so that less error checking and initialization code is needed for reading. PickleIterator has all the necessary data to do the actual reading. The advantage of having it provide Read methods (as opposed to leaving them solely in the Pickle interface) is that the callers do not need to pass around the const Pickle* once they have a PickleIterator. Followup CLs will refactor the call sites to remove const Pickle* arguments where they are now unnecessary. Then the Pickle::Read* methods can be removed entirely. The alternative approach would have been to change the Pickle::Read methods to non-const and remove the iterator parameter (making Read methods advance an internal read pointer). Unfortunately, the const Read with iterator design is entrenched throughout the chromium code, making this a much more complex change with the same performance outcome. BUG=13108 Review URL: https://chromiumcodereview.appspot.com/9447084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125447 0039d316-1c4b-4281-b951-d872f2087c98
* Disable StatsTableTest.MultipleThreads on Mac.vandebo@chromium.org2012-02-251-1/+7
| | | | | | | | | | | | | It's failing on the Mac Valgrind bot TBR=thestig@chromium.org BUG=10611 TEST=NONE Review URL: http://codereview.chromium.org/9466039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123672 0039d316-1c4b-4281-b951-d872f2087c98
* Improve SharedMemory::Lock on Posix and reenable StatsTableTest.MultipleThreadsvandebo@chromium.org2012-02-251-2/+1
| | | | | | | | | | BUG=10611 TEST=NONE Review URL: http://codereview.chromium.org/9463018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123647 0039d316-1c4b-4281-b951-d872f2087c98
* Flakiness cleanup: disable flaky tests under base/evan@chromium.org2012-02-141-3/+3
| | | | | | | | | | See https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/fcec09fc659f39a6 BUG=46246,85930,10611,86494,95058,61589,25038 Review URL: https://chromiumcodereview.appspot.com/9386014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121782 0039d316-1c4b-4281-b951-d872f2087c98
* Need the unsigned constants marked as unsigned.backer@chromium.org2012-01-271-9/+9
| | | | | | | | | | TBR=mad BUG=none TEST=linux bot compiles without warning Review URL: https://chromiumcodereview.appspot.com/9296008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119451 0039d316-1c4b-4281-b951-d872f2087c98
* Added a Unique ID for a Field Trial containing it's hashed name and the ↵mad@chromium.org2012-01-273-13/+158
| | | | | | | | | | | | selected group ID. Also returns the list of UIDs of all currently running Field Trials BUG=None TEST=FieldTrialTest.UIDs Review URL: https://chromiumcodereview.appspot.com/9117037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119444 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent calling internal metrics code with invalid values.rkc@chromium.org2012-01-062-4/+19
| | | | | | | | | | | | | | | Currently we can call the internal metrics code in Chrome from the metrics extension with completely arbitrary values; some of which can cause the creation of invalid histograms which in turn can Chrome to crash. This CL sanitizes the inputs to the extension so that the histogram constructed is valid. Currently this is causing one crash due to code from http://codereview.chromium.org/8819013 This CL fixes the issue with the extension and fixes the crash. The issues with the JS code still needs to be fixed in another CL. R=jar@chromium.org BUG=chromium:24115 TEST=Tried the repro case for the crash several times to confirm that it isn't happening anymore. Review URL: http://codereview.chromium.org/9113002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116627 0039d316-1c4b-4281-b951-d872f2087c98
* Update Sleep() calls in metrics tests to use TimeDelta instead of int.tedvessenes@gmail.com2011-12-311-20/+20
| | | | | | | | | | | R=jar@chromium.org BUG=108171 TEST= Review URL: http://codereview.chromium.org/9056001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116064 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all usages of FRIEND_TEST() with FRIEND_TEST_ALL_PREFIXES()robertshield@chromium.org2011-11-292-19/+19
| | | | | | | | BUG=105287 TEST=NONE Review URL: http://codereview.chromium.org/8678017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111935 0039d316-1c4b-4281-b951-d872f2087c98
* Add OVERRIDE to base/.avi@chromium.org2011-11-162-10/+12
| | | | | | | | | BUG=104314 TEST=no change Review URL: http://codereview.chromium.org/8520018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110218 0039d316-1c4b-4281-b951-d872f2087c98
* Support using UMA_HISTOGRAM_CUSTOM_ENUMERATION from the renderer.fischman@chromium.org2011-11-132-1/+51
| | | | | | | | | | BUG=103633 TEST=trybots & manually checking that chrome://histograms/Aspect now shows the two custom enum histograms from r108951, with correctly specific buckets. Review URL: http://codereview.chromium.org/8506038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109823 0039d316-1c4b-4281-b951-d872f2087c98
* base: export GetBuildTimeagl@chromium.org2011-11-112-13/+2
| | | | | | | | | | | | | A need for the function came up in another context so this change exposes it from base/. BUG=none TEST=base_unittests Review URL: http://codereview.chromium.org/8510027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109638 0039d316-1c4b-4281-b951-d872f2087c98
* Replace most LOG/CHECK statements with DLOG/DCHECK statements in base.brettw@chromium.org2011-10-262-7/+7
| | | | | | | | | | | [ Reland of 107042 http://codereview.chromium.org/8368009 ] I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8341026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107434 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 107042 - Replace most LOG/CHECK statements with DLOG/DCHECK ↵brettw@chromium.org2011-10-252-7/+7
| | | | | | | | | | | | | | statements in base. I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8368009 TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/8351025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107051 0039d316-1c4b-4281-b951-d872f2087c98
* Replace most LOG/CHECK statements with DLOG/DCHECK statements in base.brettw@chromium.org2011-10-252-7/+7
| | | | | | | | | I tried hard not to change CHECKs that had side effects. I kept fatal checks that seemed security or debugging-info (in crash reports) sensitive, and ones that seems particularly well-conceived. Review URL: http://codereview.chromium.org/8368009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107042 0039d316-1c4b-4281-b951-d872f2087c98
* Cache the ranges_ vector and share the ranges_ vectorrtenneti@chromium.org2011-10-203-31/+257
| | | | | | | | | | | | | | | across histograms if the ranges in the ranges_ vector is same. This change saves around 100k of memory in the browser (around 400 histograms sharing the same ranges_ vector and each ranges_ vector has around 50 elements). In each renderer process we are sharing ranges_ vector for around 30 histograms (a savings of 6k of memory). R=jar TEST=histogram unit tests. Review URL: http://codereview.chromium.org/7696017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106425 0039d316-1c4b-4281-b951-d872f2087c98
* Fix of unused variable warnings related to DHISTOGRAM* in release builds.pph34r@gmail.com2011-10-162-8/+50
| | | | | | | | | | | | | | Make DHISTOGRAM* keep a mention of passed variables. Add Histogram::DebugNow() for use in DHISTOGRAM* as a start_time. BUG=87490 TEST=None Review URL: http://codereview.chromium.org/8225001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105722 0039d316-1c4b-4281-b951-d872f2087c98
* Expand the inline documentation for the HISTOGRAM_ENUMERATION macros.isherman@chromium.org2011-10-141-1/+7
| | | | | | | | | | | | This should help to reduce confusion about the recommended upper- and lower-bounds for enumerated histograms. BUG=none TEST=none Review URL: http://codereview.chromium.org/8273022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105440 0039d316-1c4b-4281-b951-d872f2087c98
* Update SHA1_LENGTH -> kSHA1Length to match previous change to SHA256_LENGTH.pkasting@chromium.org2011-09-281-1/+1
| | | | | | | | | | (I didn't try and understand or fix why kSHA1Length is in base:: while kSHA256Length is in crypto::.) BUG=92247 TEST=compiles Review URL: http://codereview.chromium.org/7972024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103179 0039d316-1c4b-4281-b951-d872f2087c98
* Some possible comment typos?rogerta@chromium.org2011-09-151-4/+1
| | | | | | | | | BUG=None TEST=None, only changes to comments Review URL: http://codereview.chromium.org/7888015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101409 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Purify and Quantify.Doing so will reduce substantially the size of ↵jeanluc@chromium.org2011-08-171-1/+1
| | | | | | | | | the project files. BUG=92102 Review URL: http://codereview.chromium.org/7528010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97156 0039d316-1c4b-4281-b951-d872f2087c98
* Add acquire/release calls in one-time init for histogramsjar@chromium.org2011-08-071-93/+110
| | | | | | | | | | | | Clean up macros which do one-time initialization of static pointer to histograms to use subtle atomic operators. r=willchan, dvyukov BUG=7535006 Review URL: http://codereview.chromium.org/7535006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95762 0039d316-1c4b-4281-b951-d872f2087c98
* Rename BASE_API to BASE_EXPORT.darin@chromium.org2011-08-054-16/+16
| | | | | | | R=rvargas Review URL: http://codereview.chromium.org/7461141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95618 0039d316-1c4b-4281-b951-d872f2087c98
* Removed wchat_t from Time::FromString.shinyak@google.com2011-08-031-2/+1
| | | | | | | | | | | | Also, some of the test case are moved for pr_time_unittests to time_unittests. BUG=77962 TEST=base_unittests:TimeTest.* Review URL: http://codereview.chromium.org/7492063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95207 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 94426 - Removed wchat_t from Time::FromString.morrita@chromium.org2011-07-281-1/+2
| | | | | | | | | | | | | | | Also, some of the test case are moved for pr_time_unittests to time_unitests. BUG=77962 TEST=base_unittests:TimeTest.* Review URL: http://codereview.chromium.org/7470038 TBR=shinyak@google.com Review URL: http://codereview.chromium.org/7520021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94427 0039d316-1c4b-4281-b951-d872f2087c98
* Removed wchat_t from Time::FromString.shinyak@google.com2011-07-281-2/+1
| | | | | | | | | | | | Also, some of the test case are moved for pr_time_unittests to time_unitests. BUG=77962 TEST=base_unittests:TimeTest.* Review URL: http://codereview.chromium.org/7470038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94426 0039d316-1c4b-4281-b951-d872f2087c98
* Apply CSP to chrome: and about: pagestsepez@chromium.org2011-06-281-8/+0
| | | | | | | Apply Content Security Policy to the chrome://credits page, and the other pages handled by browser_about_handler.cc while we're at it. Move inline JS out of several html files. Move top-level page generation to the about_handler.cc, with tracked_objects.cc/hisogram.cc generating markup fragments to be included. This keeps this files agnostic to CSP issues. Also fix an output encoding issue in the <title> of some pages. Review URL: http://codereview.chromium.org/7215034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90788 0039d316-1c4b-4281-b951-d872f2087c98
* Add back a check for improper usage of IsOneTimeRandomizationEnabled.joi@chromium.org2011-06-222-11/+11
| | | | | | | | | BUG=none TEST=existing Review URL: http://codereview.chromium.org/7204004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90135 0039d316-1c4b-4281-b951-d872f2087c98
* Implement A/B experiment for anti-DDoS.joi@chromium.org2011-06-161-1/+3
| | | | | | | | | BUG=85258 TEST=manual testing done by developer Review URL: http://codereview.chromium.org/7027040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89376 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: base/scoped_ptr.h -> base/memory/scoped_ptr.h. (part 2)thestig@chromium.org2011-06-151-1/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7149008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89131 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce the ANNOTATE_LEAKING_OBJECT_PTR annotation that can be used to markglider@chromium.org2011-05-311-2/+13
| | | | | | | | | | | | heap allocated objects as intentionally leaked ones. Annotate the histograms produced by {Histogram,BooleanHistogram,LinearHistogram,CustomHistogram}::FactoryGet(), as leaked. Rename StatsHistogram::StatsHistogramFactoryGet to StatsHistogram::FactoryGet, annotate the result as leaky, update the suppressions. BUG=79322 Review URL: http://codereview.chromium.org/7071036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87278 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 86990 - Fix http://codereview.chromium.org/6869009 to ignore an ↵msw@chromium.org2011-05-271-9/+0
| | | | | | | | | | | | | | | | | | | existing object exactly once and land the CL again: Introduce the ANNOTATE_LEAKING_OBJECT_PTR annotation that can be used to mark heap allocated objects as intentionally leaked ones. Annotate the histograms produced by {Histogram,BooleanHistogram,LinearHistogram,CustomHistogram}::FactoryGet(), as leaked. Rename StatsHistogram::StatsHistogramFactoryGet to StatsHistogram::FactoryGet, annotate the result as leaky, update the suppressions. BUG=79322 TBR=jar Review URL: http://codereview.chromium.org/6976044 TBR=glider@chromium.org Review URL: http://codereview.chromium.org/7071035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86993 0039d316-1c4b-4281-b951-d872f2087c98
* Fix http://codereview.chromium.org/6869009 to ignore an existing object ↵glider@chromium.org2011-05-271-0/+9
| | | | | | | | | | | | | | | | exactly once and land the CL again: Introduce the ANNOTATE_LEAKING_OBJECT_PTR annotation that can be used to mark heap allocated objects as intentionally leaked ones. Annotate the histograms produced by {Histogram,BooleanHistogram,LinearHistogram,CustomHistogram}::FactoryGet(), as leaked. Rename StatsHistogram::StatsHistogramFactoryGet to StatsHistogram::FactoryGet, annotate the result as leaky, update the suppressions. BUG=79322 TBR=jar Review URL: http://codereview.chromium.org/6976044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86990 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Land http://codereview.chromium.org/6869009 for the third time."oshima@google.com2011-05-261-5/+0
| | | | | | | | | | | | | | | | | | | | | | This reverts commit d4ff483fbf60aad0b49fddd1937774edb3ba1d7e. --- Introduce the ANNOTATE_LEAKING_OBJECT_PTR annotation that can be used to mark heap allocated objects as intentionally leaked ones. Annotate the histograms produced by {Histogram,BooleanHistogram,LinearHistogram,CustomHistogram}::FactoryGet(), as leaked. Rename StatsHistogram::StatsHistogramFactoryGet to StatsHistogram::FactoryGet, annotate the result as leaky, update the suppressions. --- TBR=glider@chromium.org TEST=HistogramTest.RecordedStartupTest and WebSocketTest.ServerSentData in heapchecker bot wont hang. BUG=79322 Review URL: http://codereview.chromium.org/6962016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86853 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 23:23:57 +0000