summaryrefslogtreecommitdiffstats
path: root/base/metrics
Commit message (Collapse)AuthorAgeFilesLines
* Add metric for whether Autofill is enabled or disabled.isherman@chromium.org2011-04-131-0/+9
| | | | | | | | | BUG=none TEST=unit_tests --gtest_filter=AutofillMetrics* Review URL: http://codereview.chromium.org/6826047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81474 0039d316-1c4b-4281-b951-d872f2087c98
* Use lock-free lazy initialization for static histogram referencesjar@chromium.org2011-04-053-180/+227
| | | | | | | | | | | | | | | | Make all histogram macros thread safe, and fast by again using statics to achieve performance. ...at the cost of: Leak all histograms to avoid races at shutdown. Also included leak suppression for valgrind. r=rtenneti BUG=78207 Review URL: http://codereview.chromium.org/6780035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80412 0039d316-1c4b-4281-b951-d872f2087c98
* Move flags initialization into block before sharing across threadsjar@chromium.org2011-03-301-4/+4
| | | | | | | | | | | | | | | | | | | | | | | We re-initialized the flags after we shared the histograms, so there was a potential race for multiple simultaneous initializations. This change completes the basic setting of the flags prior to registration, which in turn shares the histogram across threads. There was a potential race with the (later) setting of the flag during an upload from the renderer. With the new code, the flag is const except for its potential change by the renderer-serialization routine, which is also the only consumer of this flag (in the renderer). I also made the corresponding change to stats_histogram, even though the code was already at least as correct, as I wanted the patterns of use to remain analagous. r=rvargas,rtenneti BUG=77760 Review URL: http://codereview.chromium.org/6731074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79835 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-283-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Base: A few more files using BASE_API (for base.dll)rvargas@google.com2011-03-253-11/+14
| | | | | | | | BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6736019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79427 0039d316-1c4b-4281-b951-d872f2087c98
* Base: A few more files using BASE_API (for base.dll)rvargas@google.com2011-03-241-2/+3
| | | | | | | | BUG=76996 TEST=none Review URL: http://codereview.chromium.org/6729002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79303 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the sum of square tally from histogramsjar@chromium.org2011-03-242-19/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | This value is accrued without locking, and hence is too commonly corrupted. Even if it is gathered perfectly, I've been informed that for very large samples the computed variance is "not a stable metric" and can diverge." If we did want to look at the variance for most distribution, then we need to look at the variance of the log normal distribution, which would mean we wanted to take the sum-of-squares of the log, which is computationally intense... and probably of little value. Bottom line: Remove the useless metric. I still need to change the protobufs so that this value is optional in uploads, but other than that tiny point, this CL removes almost all traces of this metric. r=rtenneti Review URL: http://codereview.chromium.org/6672071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79225 0039d316-1c4b-4281-b951-d872f2087c98
* Removed the static on all stats macros and changed the static declarationrtenneti@chromium.org2011-03-221-2/+2
| | | | | | | | | | | | | of StatsCounter, StatsCounterTimer and StatsRate variables to auto. This change would fix possibel race condition during static's initialization in multi-threaded environments. BUG=76980 TEST=unit tests in net, browser and plugins R=jar@chromium.org Review URL: http://codereview.chromium.org/6719011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79065 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding histogram static removal changes. This is a revert rtenneti@chromium.org2011-03-221-10/+10
| | | | | | | | | | | | | | | | | | | | | | of http://src.chromium.org/viewvc/chrome?view=rev&revision=78925 The following is the original check-in and review. Removed the static on all histogram macros. If this change sticks, then we could stop using these macros and will change all the code that use histogram macros. BUG=76092 TEST=histogram unit tests and watch out if this change has performance impact. We did a trial run of this patch and we didn't see any impact in performance bots. R=jar Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78460 Review URL: http://codereview.chromium.org/6675020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78966 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 78460 - Removed the static on all histogram macros. If this changertenneti@chromium.org2011-03-211-10/+10
| | | | | | | | | | | | | | | | | | | | | | sticks, then we could stop using these macros and will change all the code that use histogram macros. We wanted to see how much impact this CL had on performance. Will reland the change again to fix the memory corruption crashes in net area. BUG=76092 TEST=histogram unit tests and watch out if this change has performance impact. We did a trial run of this patch and we didn't see any impact in performance bots. R=jar Review URL: http://codereview.chromium.org/6667061 TBR=rtenneti@chromium.org Review URL: http://codereview.chromium.org/6718009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78925 0039d316-1c4b-4281-b951-d872f2087c98
* Rework field_trial.h comment.gavinp@chromium.org2011-03-211-15/+27
| | | | | | | | | | | | | | | This comment was getting increasingly out of date; the interfaces were wrong, and the coding practices suggested wouldn't get past review. Here's my first pass at fixing the comment so it at least will compile and pass a review. Have at it! BUG=none TEST=none Review URL: http://codereview.chromium.org/6685031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78879 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid racy construction of statics unless StatsTable is enabled.rtenneti@chromium.org2011-03-191-4/+12
| | | | | | | | | BUG=76092 TEST=unit tests of network stack R=jar Review URL: http://codereview.chromium.org/6685106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78810 0039d316-1c4b-4281-b951-d872f2087c98
* Removed the static on all histogram macros. If this changertenneti@chromium.org2011-03-161-10/+10
| | | | | | | | | | | | | | | sticks, then we could stop using these macros and will change all the code that use histogram macros. BUG=76092 TEST=histogram unit tests and watch out if this change has performance impact. We did a trial run of this patch and we didn't see any impact in performance bots. R=jar Review URL: http://codereview.chromium.org/6667061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78460 0039d316-1c4b-4281-b951-d872f2087c98
* Remove DCHECK on overflowjar@chromium.org2011-03-161-1/+0
| | | | | | | | | | | | This was getting in the way of debugging a more complex problem, and the entire value should probably be removed RSN. For now, we won't DCHECK when it goes negative. R=CPU Review URL: http://codereview.chromium.org/6672061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78451 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 78333 - Removed "static" in histogram macros. Checking in tortenneti@chromium.org2011-03-161-10/+10
| | | | | | | | | | | | | | | | see the performance impact. Will revert as soon as performance tests. BUG=76092 TEST=histogram unit tests TBR=jar Review URL: http://codereview.chromium.org/6673074 Review URL: http://codereview.chromium.org/6672037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78334 0039d316-1c4b-4281-b951-d872f2087c98
* Removed "static" in histogram macros. Checking in tortenneti@google.com2011-03-161-10/+10
| | | | | | | | | | | | | | see the performance impact. Will revert as soon as performance tests. BUG=76092 TEST=histogram unit tests TBR=jar Review URL: http://codereview.chromium.org/6673074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78333 0039d316-1c4b-4281-b951-d872f2087c98
* Reland code to detect corruption of histogram rangesjar@chromium.org2011-03-053-67/+180
| | | | | | | | | | | | | | | | | | | | | | | | | | | This code was reverted because it caused, or exposed flakiness in sync unit test code (mostly on the Mac). We need to monitor that closely as we re-land. See the reviews and history in CLs: http://codereview.chromium.org/6577013 and http://codereview.chromium.org/6591052 This code generates CRC checksums for the histogram bucket-range vectors, and guarantees they remain intact when the histogram data is about to be uploaded to UMA. If the data is corrupted, then we will fail on a CHECK(). r=mbelshe,rvargas bug=73939 Review URL: http://codereview.chromium.org/6627011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77033 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 76239 - Crash when we notice a corruption of the histogram range-vectorrsimha@chromium.org2011-03-033-170/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reason for revert: This patch might have resulted in some flakiness in the sync bots on the chromium waterfall. The range vector is calculated once when a histogram is constructed, and should never change over the lifetime of the histogram. When it does change, it means that memory is being overwritten. We now crash (via CHECK) when there is any detected corruption of the range vector. This CL uses a more robust check-sum algorithm to detect corruption of the vector. The previous algorithm just did a sum, and was too easilly tricked by small (offsetting) changes in several ranges. Hopefully, this CRC-32 implementation will not be so easilly fooled. I had to refactor the class to ensure that each histogram was completely constructed before I registered it. The old code could sometimes register a base class (tradtional Histogram, with exponential bucket spread) and then run the derived constructor (such as when creating a LinearHistogram, with a second construction of the ranges and checksum). I now carefully avoid generating the checksum until fully constructing the instance, and then I run InitializeBuckets only once on the instance before registering it. bug=73939,74467 r=mbelshe Review URL: http://codereview.chromium.org/6577013 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/6611001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76667 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 76345 - Small cleanup for previous histogram checkinrsimha@chromium.org2011-03-022-17/+14
| | | | | | | | | | | | | | | | | | | | | Reason for revert: This patch might have resulted in some flakiness in the sync bots on the chromium waterfall. CL http://codereview.chromium.org/6577013/ had a few changes suggested that were not incorporated. This CL has those name changes etc. r=rvargas Review URL: http://codereview.chromium.org/6591052 BUG=74467 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/6591129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76662 0039d316-1c4b-4281-b951-d872f2087c98
* Until we have sparse histograms, to track error codes, we are usingrtenneti@chromium.org2011-03-022-2/+2
| | | | | | | | | | | | | UMA_HISTOGRAM_ENUMERATION and specify 16000 as the bucket size. Bumped up kBucketCount_MAX to 2**16. BUG=74618 TEST=We need to test MemoryMappedFile on windows in the browser to send histogram data for MemoryMappedFile.CreateFileMapping. R=jar Review URL: http://codereview.chromium.org/6592087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76514 0039d316-1c4b-4281-b951-d872f2087c98
* Small cleanup for previous histogram checkinjar@chromium.org2011-03-012-14/+17
| | | | | | | | | | | | | | CL http://codereview.chromium.org/6577013/ had a few changes suggested that were not incorporated. This CL has those name changes etc. r=rvargas Review URL: http://codereview.chromium.org/6591052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76345 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compilation bug on ARMjar@chromium.org2011-02-282-3/+3
| | | | | | | | | | Avoid re-use of method name with different signature when creating custom histograms TBR=mbelshe Review URL: http://codereview.chromium.org/6592043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76244 0039d316-1c4b-4281-b951-d872f2087c98
* Crash when we notice a corruption of the histogram range-vectorjar@chromium.org2011-02-283-60/+170
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The range vector is calculated once when a histogram is constructed, and should never change over the lifetime of the histogram. When it does change, it means that memory is being overwritten. We now crash (via CHECK) when there is any detected corruption of the range vector. This CL uses a more robust check-sum algorithm to detect corruption of the vector. The previous algorithm just did a sum, and was too easilly tricked by small (offsetting) changes in several ranges. Hopefully, this CRC-32 implementation will not be so easilly fooled. I had to refactor the class to ensure that each histogram was completely constructed before I registered it. The old code could sometimes register a base class (tradtional Histogram, with exponential bucket spread) and then run the derived constructor (such as when creating a LinearHistogram, with a second construction of the ranges and checksum). I now carefully avoid generating the checksum until fully constructing the instance, and then I run InitializeBuckets only once on the instance before registering it. bug=73939 r=mbelshe Review URL: http://codereview.chromium.org/6577013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76239 0039d316-1c4b-4281-b951-d872f2087c98
* Minor fixes in FieldTrial.cbentzel@chromium.org2011-02-252-2/+4
| | | | | | | | | | | | | | - Add a DCHECK - Comment what the return value is on AddGroup - const a member - Typo fix BUG=None TEST=None Review URL: http://codereview.chromium.org/6577038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76061 0039d316-1c4b-4281-b951-d872f2087c98
* Added CHECKs to make sure histogram caller's don't creatertenneti@chromium.org2011-02-232-2/+8
| | | | | | | | | | | | histogram that are larger 1G. Added CHECK's to catch bucket_count_ is not corrupted before accessing ranges_ vector. BUG=73452 TEST=none. histogram unit tests are enough. Review URL: http://codereview.chromium.org/6542034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75804 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize StatsTable::Private members.finnur@chromium.org2011-02-111-2/+9
| | | | | | | | | | BUG=None TEST=None CID=13412 Review URL: http://codereview.chromium.org/6483011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74594 0039d316-1c4b-4281-b951-d872f2087c98
* Stats tables are only used for debugging at this point, and when I turnmbelshe@chromium.org2011-02-101-1/+1
| | | | | | | | | | | | | | on full dom tracing, I need larger names and more of them. Increase the counter limit and the size per name. This only has effect when the user is using --enable-stats-table BUG=none TEST=none Review URL: http://codereview.chromium.org/6474008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74481 0039d316-1c4b-4281-b951-d872f2087c98
* Properly order the cc files based off the h files in base/.erg@google.com2011-01-252-293/+283
| | | | | | | | | BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6385003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72505 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete base/lock.h and fix up callers to use the new header file andbrettw@chromium.org2011-01-212-4/+4
| | | | | | | | | | | the base namespace. Fix several files including lock.h unnecessarily. BUG=none TEST=none Original review=http://codereview.chromium.org/6142009/ Patch by leviw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
* .c Feature to disable field trials in old versions of Chromium. Field trialsrtenneti@chromium.org2011-01-193-83/+242
| | | | | | | | | | | | | | tests are (usually) monitored for a fixed length of time. With this change field trial tests turn them selves off (will use the default group) after the expiration time (specified in the Field Trial constructor). BUG=13463 TEST=field_trial_unittests tests this code thorougly. spdy session and testing field_trials in renderer process would be very helpful. thanks much. Review URL: http://codereview.chromium.org/6317004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71820 0039d316-1c4b-4281-b951-d872f2087c98
* Order function definitions in base/ according to the header.erg@google.com2011-01-112-142/+142
| | | | | | | | | BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6085015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70975 0039d316-1c4b-4281-b951-d872f2087c98
* Start sorting methods in class declarations.erg@google.com2011-01-073-15/+17
| | | | | | | | | | | | | | | | | | | | | | | | A lot of our headers are a mess and aren't organized. Impose the following order on files in the base/ directory: class Blah { each public/protected/private section: typedefs; enums; static constants; ctors; dtors; methods; overridden virtual methods; data members; }; BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6081007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70749 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/lock and base/condition_variable to base/synchronization/brettw@chromium.org2011-01-012-12/+13
| | | | | | | | | | | I kept a base/lock.h in place with a using statement to avoid updating all callers in one CL. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6018013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70363 0039d316-1c4b-4281-b951-d872f2087c98
* Move platform_thread to base/threading and put in the base namespace. I left abrettw@chromium.org2010-12-312-2/+2
| | | | | | | | | | | stub and "using" declarations in the old location to avoid having to change the entire project at once. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6001010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70342 0039d316-1c4b-4281-b951-d872f2087c98
* Move thread local stuff from base to base/threading and consistently use thebrettw@chromium.org2010-12-302-3/+3
| | | | | | | | | | | base namespace. This also fixes references to TLSSlot to base::ThreadLocalStorage::Slot. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/5986012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70322 0039d316-1c4b-4281-b951-d872f2087c98
* Move some misc thread-related stuff from base to base/thread and into the basebrettw@chromium.org2010-12-301-3/+3
| | | | | | | | | | namespace. This does not move the "hard" thread stuff (thread.h). TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6079009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70315 0039d316-1c4b-4281-b951-d872f2087c98
* Properly lock access to static variables.mad@chromium.org2010-12-232-13/+40
| | | | | | | | | | | | There were a few race conditions where the static method would test the validity of the hitograms_ static variable before attempting to use the lock_ to protect access to it but nothing then prevented the destructor to free both the lock_ and the hitograms_ memory. So I decided to not use a dynamic allocation of the static lock_ to resolve this problem. BUG=38354 TEST=Hard to repro exit scenario crashes. Review URL: http://codereview.chromium.org/5784005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70054 0039d316-1c4b-4281-b951-d872f2087c98
* Start deinlining non-empty virtual methods. (This will be automatically checkederg@google.com2010-12-092-3/+15
| | | | | | | | | | | for in the future.) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5574006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68746 0039d316-1c4b-4281-b951-d872f2087c98
* Turn off field trials and reporting of metrics when running benchmarking.mbelshe@google.com2010-12-072-2/+32
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5628005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68532 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a pair of overly aggressive DCHECKsjar@chromium.org2010-11-291-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Consistency checks (to detect memory corruption) were disabled for non-standard derived forms of histograms (some cache stats were using histograms a bit differently). When I added a virtual function to allow such derived classes to override the checking code, I forgot I had some inline DCHECKs as well. The method for getting the total_count was still DCHECKing the consistency, and there was another consistency assertion made when gathering data for upload to UMA. Both of these DCHECKs, which were not overridden, were removed. They were there to assure my code was working, and to detect memory smashers (or broken DRAM) more quickly... but are too hard to cleanly override (for the one histogram that does not support this facility). BUG=61281 BUG=64268 r=jam Review URL: http://codereview.chromium.org/5365004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67608 0039d316-1c4b-4281-b951-d872f2087c98
* Revert previous commit which was by accidentjabdelmalek@google.com2010-11-231-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67052 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile error on Linuxjabdelmalek@google.com2010-11-231-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67051 0039d316-1c4b-4281-b951-d872f2087c98
* Allow histograms in cache stats.cc to bypass corruption checksjar@chromium.org2010-11-033-14/+206
| | | | | | | | | | | | | | | | This is a relanding of http://codereview.chromium.org/4174002 The change in this CL is that I've made the function to look for errors virtual, and over-rode it in StatsHistograms. The current override doesn't actually check for inconsistencies, so that the UMA checks (and renderer-to-histogram checks) won't complain and refuse to transport the histograms. BUG=61281 r=rvargas Review URL: http://codereview.chromium.org/4364001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64990 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64687 - Try to detect internal corruption of histogram instances.jar@chromium.org2010-11-023-206/+14
| | | | | | | | | | | | | | | | | | | | | | | | Corruptions can include changes in bucket boundaries, large changes in sample counts (in a bucket), etc. We now detect problems, and don't forward the corrupt data any further. This means it won't exit the renderer and go to the browser if corrupt, and it won't exit the browser and be sent up via UMA if corrupt. IF the would-be corruption is caused by a race to snapshot the data, then a later snapshot should get the clean copy, and all data (across the precluded period) will be sent onward. BUG=61281 r=mbelshe Review URL: http://codereview.chromium.org/4174002 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/4349002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64846 0039d316-1c4b-4281-b951-d872f2087c98
* Try to detect internal corruption of histogram instances.jar@chromium.org2010-11-013-14/+206
| | | | | | | | | | | | | | | | | | | | | Corruptions can include changes in bucket boundaries, large changes in sample counts (in a bucket), etc. We now detect problems, and don't forward the corrupt data any further. This means it won't exit the renderer and go to the browser if corrupt, and it won't exit the browser and be sent up via UMA if corrupt. IF the would-be corruption is caused by a race to snapshot the data, then a later snapshot should get the clean copy, and all data (across the precluded period) will be sent onward. BUG=61281 r=mbelshe Review URL: http://codereview.chromium.org/4174002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64687 0039d316-1c4b-4281-b951-d872f2087c98
* Convert implicit scoped_refptr constructor calls to explicit ones, part 1thakis@chromium.org2010-11-011-1/+1
| | | | | | | | | | | This CL was created automatically by this clang rewriter: http://codereview.appspot.com/2776043/ . I manually fixed a few rough spots of the rewriter output (doh1-3) and fixed all presubmit errors. BUG=28083 TEST=None Review URL: http://codereview.chromium.org/4192012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64573 0039d316-1c4b-4281-b951-d872f2087c98
* Add histogram to track number of .nexe launches, normalized against opening ↵mmortensen@google.com2010-10-282-0/+52
| | | | | | | | | | | | new tabs. BUG=914 (http://code.google.com/p/nativeclient/issues/detail?id=914) TEST=none Relied on trybots and manually checking "about:histograms" Review URL: http://codereview.chromium.org/4065005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64261 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up SharedMemory implementation so that it is more equivalent on Windows ↵dmaclach@chromium.org2010-10-271-1/+1
| | | | | | | | | | | | | vs Posix and enforces exclusive creates. Clean up some naming to make it clearer what size you are getting by changing max_size to created_size. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/4034006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64097 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63012 - Revert 63011 - Convert a lot of DCHECK()s to DCHECK_EQ() and ↵pkasting@chromium.org2010-10-191-45/+46
| | | | | | | | | | | | | | | | similar, so that when they fail they print the values in question. BUG=none TEST=none Review URL: http://codereview.chromium.org/3828013 TBR=pkasting@chromium.org, jamesr@chromium.org Review URL: http://codereview.chromium.org/3854004 TBR=dpranke@chromium.org Review URL: http://codereview.chromium.org/3783013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63062 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63011 - Convert a lot of DCHECK()s to DCHECK_EQ() and similar, so ↵dpranke@chromium.org2010-10-191-46/+45
| | | | | | | | | | | | | that when they fail they print the values in question. BUG=none TEST=none Review URL: http://codereview.chromium.org/3828013 TBR=pkasting@chromium.org, jamesr@chromium.org Review URL: http://codereview.chromium.org/3854004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63012 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-06 11:55:03 +0000