summaryrefslogtreecommitdiffstats
path: root/base/process_util_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* Do not run ProcessUtilTest.MacMallocFailureDoesNotTerminate under ASan.glider@chromium.org2012-04-061-2/+6
| | | | | | | | BUG=122140 TBR=willchan Review URL: https://chromiumcodereview.appspot.com/10012036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131124 0039d316-1c4b-4281-b951-d872f2087c98
* Add virtual and OVERRIDE to base/ implementation filesrsleevi@chromium.org2012-04-061-3/+3
| | | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/10004001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131098 0039d316-1c4b-4281-b951-d872f2087c98
* In CrMallocErrorBreak, do not kill the process if errno is ENOMEM.rsesek@chromium.org2012-04-041-5/+29
| | | | | | | | | | | | This is based on CL 9597031, but clears errno when calling through the overriden allocators. BUG=103980 TEST=Covered by ProcessUtilTest.MacTerminateOnHeapCorruption Review URL: https://chromiumcodereview.appspot.com/9965075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130712 0039d316-1c4b-4281-b951-d872f2087c98
* Add preliminary OOM support for Mountain Lion.avi@chromium.org2012-03-141-1/+1
| | | | | | | | | | BUG=117476 TEST=run base_unittests on Mountain Lion Review URL: http://codereview.chromium.org/9701031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126773 0039d316-1c4b-4281-b951-d872f2087c98
* Use cmd.exe instead of python.exe for unit test.maruel@chromium.org2012-03-081-14/+13
| | | | | | | | | | | | | | | | This removes the last dependency on src/third_party/python_26 from base_unittests.exe. Windows-only change. R=jar@chromium.org BUG=116206 TEST=base_unittests still pass Review URL: http://codereview.chromium.org/9625022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125506 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 125441 - In CrMallocErrorBreak, do not kill the process if errno is ↵viettrungluu@chromium.org2012-03-071-23/+5
| | | | | | | | | | | | | | | | | | | | | | | ENOMEM. [Caused test failures on 10.5.] This will allow large JPEG decodes to be handled and optionally killed by the OOM killer instead. Based on a sampling of the other malloc_error_break() bugs ("unaligned pointer", "freed was not allocated", "double free", and "incorrect checksum"), this will only affect the "allocate region" error, as those others happen at free(), rather than malloc(). BUG=103980 TEST=Covered by ProcessUtilTest.MacTerminateOnHeapCorruption Review URL: http://codereview.chromium.org/9597031 TBR=rsesek@chromium.org Review URL: https://chromiumcodereview.appspot.com/9622023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125464 0039d316-1c4b-4281-b951-d872f2087c98
* In CrMallocErrorBreak, do not kill the process if errno is ENOMEM.rsesek@chromium.org2012-03-071-5/+23
| | | | | | | | | | | | | | | | This will allow large JPEG decodes to be handled and optionally killed by the OOM killer instead. Based on a sampling of the other malloc_error_break() bugs ("unaligned pointer", "freed was not allocated", "double free", and "incorrect checksum"), this will only affect the "allocate region" error, as those others happen at free(), rather than malloc(). BUG=103980 TEST=Covered by ProcessUtilTest.MacTerminateOnHeapCorruption Review URL: http://codereview.chromium.org/9597031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125441 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the regexp for ProcessUtilTest.MacTerminateOnHeapCorruptionglider@chromium.org2012-03-061-1/+1
| | | | | | | | TBR=willchan BUG=114996 Review URL: https://chromiumcodereview.appspot.com/9615007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125141 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ProcessUtilTest.MacTerminateOnHeapCorruption to pass under ASan on Mac.glider@chromium.org2012-03-061-0/+7
| | | | | | | | BUG=114996 TBR=willchan Review URL: https://chromiumcodereview.appspot.com/9583012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125135 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove base::environment_vector and ↵thestig@chromium.org2012-02-241-8/+8
| | | | | | | | | | | base::file_handle_mapping_vector to StudlyCaps. BUG=none TEST=none Review URL: http://codereview.chromium.org/9429039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123438 0039d316-1c4b-4281-b951-d872f2087c98
* Flakiness cleanup: disable flaky tests under base/evan@chromium.org2012-02-141-7/+1
| | | | | | | | | | See https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/fcec09fc659f39a6 BUG=46246,85930,10611,86494,95058,61589,25038 Review URL: https://chromiumcodereview.appspot.com/9386014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121782 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup in ProcessSingleton. These originated as candidate fixes for issue ↵joi@chromium.org2012-02-101-0/+19
| | | | | | | | | | | | | | | | | 111361, but the true fix is cpu@'s r119830. a) Unify code to retrieve HMODULE based on address in base::GetModuleFromAddress. (cpu@'s r119830 already has the fix to use the DLL's HMODULE 119830 rather than the EXE's HINSTANCE) b) Try harder to unregister the window class, by trying it first in ProcessSingleton::Cleanup, which gets called before the fast shutdown path calls ExitProcess(). Also, use correct HMODULE to unregister. c) Avoid any possibility of a race to create the message window when the Create() method is called from NotifyOtherProcessOrCreate() or from outside the class by moving the implementation of Create(), which was always called from the constructor, into the constructor and making Create() just return true or false based on the success of the work already done. BUG=111361 Review URL: http://codereview.chromium.org/9121046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121480 0039d316-1c4b-4281-b951-d872f2087c98
* Adding GetProcId unittestcpu@chromium.org2012-01-261-1/+15
| | | | | | | | | | | - I want to refactor the windows version. But first I need a test. BUG=none TEST=yes it is. Review URL: http://codereview.chromium.org/9283009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119201 0039d316-1c4b-4281-b951-d872f2087c98
* Change code in base (primarily unit tests) to use Sleep(TimeDelta).tedvessenes@gmail.com2011-12-311-6/+6
| | | | | | | | | | BUG=108171 TEST= Review URL: http://codereview.chromium.org/9055001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116065 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the nested #ifdef ADDRESS_SANITIZERglider@chromium.org2011-12-201-15/+10
| | | | | | Review URL: http://codereview.chromium.org/9007010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115130 0039d316-1c4b-4281-b951-d872f2087c98
* Do not run OutOfMemoryDeathTest.* under AddressSanitizer.glider@chromium.org2011-12-191-0/+7
| | | | | | | TBR=willchan Review URL: http://codereview.chromium.org/8994003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114978 0039d316-1c4b-4281-b951-d872f2087c98
* Move the ProcessWatcher methods out of content/common/process_watcher into ↵jam@chromium.org2011-11-231-0/+45
| | | | | | | | | | | base/process_util, alongside the other process methods. The only non-trivial move change is to the Windows implementation, where I changed KillProcess to use an exit code of kProcessKilledExitCode instead of content::RESULT_CODE_HUNG. cpu said that the existing code was incorrect, since GetTerminationStatus() should be mapping that result to TERMINATION_STATUS_PROCESS_WAS_KILLED. So I changed the exit code to kProcessKilledExitCode. This might make the UMA stats for killed processes to go up (and crashed to go down), but that will be an accounting change and should be zero-sum. BUG=98716 Review URL: http://codereview.chromium.org/8674003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111371 0039d316-1c4b-4281-b951-d872f2087c98
* disable GetAppOutputRestrictedSIGPIPE and enable ::vswprintf on OpenBSDrobert.nagy@gmail.com2011-11-121-1/+1
| | | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/8544003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109806 0039d316-1c4b-4281-b951-d872f2087c98
* OpenBSD patches for base / split from CR #8275005mark@chromium.org2011-10-181-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | base/base.gypi: - Add native_library_linux.cc to the openbsd build. - Add '..' to include_dirs so that OS_* definitions are available in symbolize.cc base/debug/debugger_posix.cc: - Add support for figuring out if the process is being debugged on OpenBSD by sharing some code with Mac. base/process_util_unittest.cc: - Disable the OutOfMemoryTest on OpenBSD base/third_party/symbolize/symbolize.cc: - Include the correct elf header on OpenBSD build/linux/system.gyp: - The dl library is linux only, so only use it there. BUG= TEST= Review URL: http://codereview.chromium.org/8329023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106078 0039d316-1c4b-4281-b951-d872f2087c98
* OpenBSD and FreeBSD fixes for base.mark@chromium.org2011-10-131-2/+0
| | | | | | | | | | | | | OpenBSD and FreeBSD need -I/usr/local/include for <execinfo.h>. Use !#/usr/bin/env bash because on !linux it's not located there. Patch by Robert Nagy <robert@openbsd.org> BUG=none TEST=none Review URL: http://codereview.chromium.org/8228005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105257 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Clang-built ProcessUtilTest.GetTerminationStatusCrash.hans@chromium.org2011-10-111-1/+1
| | | | | | | | | | | | | | Writing to a NULL pointer is undefined behaviour, and unless that pointer is volatile, Clang will optimize it away, replacing it with an UD2 instruction which causes the process to die by SIGILL. This patch makes the pointer volatile, so the write occurrs, and the process dies with SIGSEGV as intended. BUG=68707 TEST=build with Clang, out/Release/base_unittests --gtest_filter=ProcessUtilTest.GetTerminationStatusCrash Review URL: http://codereview.chromium.org/8233010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104930 0039d316-1c4b-4281-b951-d872f2087c98
* Upstream ProcessUtilTest, and make a few other files compile on Android.jingzhao@chromium.org2011-09-291-14/+57
| | | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/8059007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103236 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ProcessUtilTest.GetTerminationStatusCrash under AddressSanitizer.glider@chromium.org2011-09-201-1/+8
| | | | | | | TBR=gspencer Review URL: http://codereview.chromium.org/7983024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102027 0039d316-1c4b-4281-b951-d872f2087c98
* Disable GetTerminationStatusExit on Windows.thakis@chromium.org2011-09-191-2/+2
| | | | | | | | | | | | Timed out here: http://build.chromium.org/p/tryserver.chromium/builders/win/builds/56264/steps/base_unittests/logs/stdio BUG=95058 TEST=none TBR=gspencer Review URL: http://codereview.chromium.org/7944001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101770 0039d316-1c4b-4281-b951-d872f2087c98
* ProcessUtilTest.GetTerminationStatusExit is flaky at best...mad@chromium.org2011-09-141-2/+2
| | | | | | | | BUG=95058 Review URL: http://codereview.chromium.org/7885011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101078 0039d316-1c4b-4281-b951-d872f2087c98
* Synchronize the parent and child processes during launch, ensuring that themark@chromium.org2011-09-011-0/+4
| | | | | | | | | | | | | | | | | | | | | child doesn't try to check in with the Mach broker before the parent is ready. This resolves a race between the browser and its child processes. base::LaunchOptions gets a new member, synchronize, currently Mac-only although there's nothing Mac-specific about the implementation. When set, it allows base::LaunchProcess clients to request that the child process block until released by the new base::LaunchSynchronize call. When creating child processes, the child process launcher now requests this new synchronization behavior to give it a chance to set up the Mach broker to expect the child before the child tries to check in with it. BUG=94295 TEST=Chrome should work. You see fewer of this logged: Unknown process (pid) is sending Mach IPC messages! But you still might see some of these due to bug 94543. Review URL: http://codereview.chromium.org/7740036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99245 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failed test GetTerminationStatusExit on Linux.dyu@chromium.org2011-09-011-1/+8
| | | | | | | | BUG=95058 TEST=none Review URL: http://codereview.chromium.org/7792062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99207 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Implement base::EnableTerminationOnHeapCorruption() by overriding ↵rsesek@chromium.org2011-08-181-0/+15
| | | | | | | | | | | | | | | | | malloc_error_break(). This makes malloc_error_break() fatal for all processes in an attempt to get better stack traces when heap corruption may occur. BUG=90884,91068,93191 TEST=See bug 93191 for repro steps. A crash report gets generated with a hopefully more-useful stack. Originally landed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97315 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=97322 Review URL: http://codereview.chromium.org/7670025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97351 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "[Mac] Implement base::EnableTerminationOnHeapCorruption() by ↵rsesek@chromium.org2011-08-181-15/+0
| | | | | | | | | | | | | | overriding malloc_error_break" This reverts commits r97315 and r97319. BUG=none TEST=none TBR=mark Review URL: http://codereview.chromium.org/7631046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97322 0039d316-1c4b-4281-b951-d872f2087c98
* Change the expectation for ProcessUtilTest.MacTerminateOnHeapCorruption to ↵rsesek@chromium.org2011-08-181-1/+2
| | | | | | | | | | | work on 10.5-10.7. BUG=none TEST=ProcessUtilTest.MacTerminateOnHeapCorruption Review URL: http://codereview.chromium.org/7671047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97319 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Implement base::EnableTerminationOnHeapCorruption() by overriding ↵rsesek@chromium.org2011-08-181-0/+14
| | | | | | | | | | | | | | malloc_error_break(). This makes malloc_error_break() fatal for all processes in an attempt to get better stack traces when heap corruption may occur. BUG=90884,91068,93191 TEST=See bug 93191 for repro steps. A crash report gets generated with a hopefully more-useful stack. Review URL: http://codereview.chromium.org/7670025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97315 0039d316-1c4b-4281-b951-d872f2087c98
* Rename CommandLine::GetCommandLineString().msw@chromium.org2011-07-201-1/+1
| | | | | | | | | | | | Fix string hackery in net/tools/dump_cache/dump_cache.cc Fix const casts in chrome/installer/util/product.cc and base/process_util_win.cc. BUG=73195 TEST=none Review URL: http://codereview.chromium.org/7386002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93165 0039d316-1c4b-4281-b951-d872f2087c98
* Remove LaunchAppAsUser().evan@chromium.org2011-07-191-1/+3
| | | | | | | | | | This is the last of the LaunchApp family. BUG=88990 Review URL: http://codereview.chromium.org/7409004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93034 0039d316-1c4b-4281-b951-d872f2087c98
* Disable process_util unit test that uses clone() on valgrind bots.bradchen@google.com2011-07-191-2/+6
| | | | | | | | | | BUG= TEST=this is a test Review URL: http://codereview.chromium.org/7409005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92936 0039d316-1c4b-4281-b951-d872f2087c98
* Add a "clone" option to base/process_util.h:LaunchProcess(). Useful inside ↵bradchen@google.com2011-07-151-7/+17
| | | | | | | | | | | | Linux sandbox. BUG=nativeclient:480 TEST=base/process_util_unittest.cc Review URL: http://codereview.chromium.org/7401002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92771 0039d316-1c4b-4281-b951-d872f2087c98
* Change base::LaunchProcess API slightlyevan@chromium.org2011-07-151-1/+1
| | | | | | | | | | | Rather than passing the out param process handle via the options, take it as a function argument. This simplifies many callers. BUG=88990 Review URL: http://codereview.chromium.org/7377012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92701 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up users of a deprecated base::LaunchApp API.evan@chromium.org2011-07-121-11/+13
| | | | | | | | BUG=88990 Review URL: http://codereview.chromium.org/7258005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92200 0039d316-1c4b-4281-b951-d872f2087c98
* Added ability to run a command, getting output and exit status on POSIX.benwells@chromium.org2011-07-061-0/+38
| | | | | | | | | | | | | | | Register protocol handler needs to check the return value of scripts it runs and collects output from. There needs a variant of GetAppOutput which returns the exit code of the application run, not just a success or failure, so this function has been added. BUG=83557 TEST=Unit test added Review URL: http://codereview.chromium.org/7198034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91527 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Initialize TestTimeouts in out-of-process test runner.phajdan.jr@chromium.org2011-06-091-6/+5
| | | | | | | | | | | This is needed to make command-line changes take effect. Also, added checks to prevent a similar mistake from happening in the future. Actually, the checks detected such misuse in process_util_unittests, and this CL fixes it. BUG=85287 Review URL: http://codereview.chromium.org/7044048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88561 0039d316-1c4b-4281-b951-d872f2087c98
* Fix one more time the linux tests, in other words giving up on improving the ↵cpu@chromium.org2011-04-291-10/+14
| | | | | | | | tests TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83469 0039d316-1c4b-4281-b951-d872f2087c98
* fix failing linux tests.cpu@chromium.org2011-04-291-0/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83458 0039d316-1c4b-4281-b951-d872f2087c98
* Add a more comprehensive background mode for a process.cpu@chromium.org2011-04-281-2/+19
| | | | | | | | | | | | | | It also lowers the priority of IO. -Windows vista, win7 only -Bad usage of closehandle fixed BUG=none TEST=unittest included Review URL: http://codereview.chromium.org/6880265 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83447 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Get service process running standalone on the mac by hooking it into launchd.dmaclach@chromium.org2011-02-241-2/+2
| | | | | | | | | BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/6482016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75893 0039d316-1c4b-4281-b951-d872f2087c98
* Fix file descriptor leak in base_unittests ProcessUtilTest.LaunchApp. Themark@chromium.org2011-01-101-2/+5
| | | | | | | | | | TestLaunchApp helper function should close base_unittests' end of the pipe. BUG=none TEST=base_unittests --gtest_filter=ProcessUtilTest.LaunchApp Review URL: http://codereview.chromium.org/6128004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70901 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base/debug_util. Move the debug UI related functions to ↵brettw@google.com2011-01-011-1/+0
| | | | | | | | | | | | base/debug/debugger.h Move the OS X specific crash report changing function to base/mac/os_crash_dumps TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6092005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70358 0039d316-1c4b-4281-b951-d872f2087c98
* Move platform_thread to base/threading and put in the base namespace. I left abrettw@chromium.org2010-12-311-3/+3
| | | | | | | | | | | stub and "using" declarations in the old location to avoid having to change the entire project at once. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6001010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70342 0039d316-1c4b-4281-b951-d872f2087c98
* This adds some plumbing for propagating the status and error code of a ↵gspencer@chromium.org2010-12-141-17/+155
| | | | | | | | | | | | | | | | | | | | | renderer process that went away so that we can tell at the UI level what happened to the tab: did it crash, or was it killed by the OOM killer (or some other reason). This is in preparation for implementing a new UI for when a process is killed by the OOM on ChromeOS which handles it differently from a crash. Most of the changes are modifications of the argument list to include a status and error code for the exited process, but in addition the following was done: - Changed the name of DidProcessCrash to GetTerminationStatus. - Added TerminationStatus enum in process_util.h, so it can be used as the status returned by GetTerminationStatus. - Improved process_util_unittest to actually test for crashing and terminated processes on all platforms. - Added a new notification for renderers that were killed. - Added error code information to crash notification. - Added status and error code information to renderer IPC message for RenderViewGone. - Added a UMA histogram count for number of renderer kills. BUG=http://crosbug.com/8505 TEST=ran new unit test. Test passes on try servers. Review URL: http://codereview.chromium.org/5172009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69082 0039d316-1c4b-4281-b951-d872f2087c98
* Reconstructing 67000.bradnelson@google.com2010-11-231-1/+1
| | | | | | | | | | | | | | (python24 -> python26). Regression in nacl fixed, new DEPS change. BUG=None TEST=NOne Review URL: http://codereview.chromium.org/5310001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67057 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 67000.bradnelson@google.com2010-11-221-1/+1
| | | | | | | | | | BUG=None TEST=None TBR=nsylvain Review URL: http://codereview.chromium.org/5272001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67004 0039d316-1c4b-4281-b951-d872f2087c98