| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Native client uses the GLIBC style of strerror_r but does not define __GLIBC__.
It's possible the right thing to do is for the native client toolchain to
define GLIBC, but the path of least resistance seems to be to adjust our
conditionals in this file to understand NaCl.
Original patch by Eric Seidel.
Review URL: http://codereview.chromium.org/4883001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65961 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes the following error with gcc-4.4 on Ubuntu:
base/safe_strerror_posix.cc: In function ‘void wrap_posix_strerror_r(int (*)(int, char*, size_t), int, char*, size_t)’:
base/safe_strerror_posix.cc:86: error: ‘snprintf’ was not declared in this scope
Patch by Joel Stanley <joel@jms.id.au>
Review URL: http://codereview.chromium.org/269046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
form.
Also add thread-safe, portable variants for strerror() and strerror_r() on POSIX so that existing error logging code that calls strerror() for something other than LOG, LOG_IF, or CHECK can be changed to use safe versions too. After this CL I will eliminate all unsafe uses of strerror() in our code.
TEST=Linux: tested PLOG and DPLOG with both a valid error and invalid error on a dbg build with both the default strerror_r implementation (GNU) and the other one (POSIX) via some throw-away macro evilness, and also tested the default strerror_r again on an opt build to verify DPLOG is a no-op; Windows: tested PLOG and DPLOG with both a valid error and invalid error on a dbg build; also tested LOG_GETLASTERROR_MODULE with winhttp and ERROR_WINHTTP_CANNOT_CONNECT and verified that it prints the correct system message and that it doesn't with PLOG; also tested LOG_GETLASTERROR_MODULE with a bogus module name and verified that it prints an error that it can't find the module, and the original error; Mac: none (implicitly tested via the Linux POSIX tests); trybots for Win, Mac, and Linux 32-bit; built locally for Linux 32-bit and 64-bit and tested base_unittests and also running Chromium itself; wrote the upcoming CL that switches strerror() calls to use PLOG and verified that it builds and works for both Linux 32-bit and Linux 64-bit; lint
BUG=none
Review URL: http://codereview.chromium.org/265052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28632 0039d316-1c4b-4281-b951-d872f2087c98
|
